Re: Review Request 34984: Added help for files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/#review86374 --- Patch looks great! Reviews applied: [34984] All tests passed. - M

Re: Review Request 33824: Stub for the new HTTP API in the slave

> On June 3, 2015, 4:38 a.m., Marco Massenzio wrote: > > Hi Alex - I noticed the new 'code drop' but none of the comments were > > addressed in the new diff: is something missing? > > > > Thanks! The code drop was just a rebasing, I'm slowly getting to all my old patches. - Alexander -

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review86379 --- Patch looks great! Reviews applied: [34976] All tests passed. - M

Review Request 35000: Doxygen'ized Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/ --- Review request for mesos, Bernd Mathiske and Joerg Schad. Repository: mesos D

Re: Review Request 35000: Doxygen'ized Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86407 --- Patch looks great! Reviews applied: [35000] All tests passed. - M

Re: Review Request 35000: Doxygen'ized Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86423 --- Just a fly by comment: can't get my hands down for this initiative!

Re: Review Request 35000: Doxygen'ized Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86404 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 34633: Added QoS Controller test.

> On May 29, 2015, 7:23 p.m., Vinod Kone wrote: > > src/tests/oversubscription_tests.cpp, line 117 > > > > > > Why not implement the TODO? > > > > s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ?

Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34534/#review86433 --- docs/configuration.md

Re: Review Request 32356: Refactor synchronized to use mutex, recursive_mutex, atomic_flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32356/ --- (Updated June 3, 2015, 5:11 p.m.) Review request for mesos, Benjamin Hindman an

Review Request 35012: Move synchronized.hpp into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35012/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35013: Move synchronized.hpp out of libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35013/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Re: Review Request 32358: Refactor Future to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32358/ --- (Updated June 3, 2015, 5:16 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 32360: Refactor Mutex to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32360/ --- (Updated June 3, 2015, 5:16 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86436 --- src/hook/manager.cpp

Re: Review Request 32361: Refactor Queue to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32361/ --- (Updated June 3, 2015, 5:16 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 32362: Refactor Metrics::Timer to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32362/ --- (Updated June 3, 2015, 5:17 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 32363: Refactor Metrics::Metric to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32363/ --- (Updated June 3, 2015, 5:18 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 32365: Remove libprocess internal.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32365/ --- (Updated June 3, 2015, 5:19 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 32364: Refactor http to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32364/ --- (Updated June 3, 2015, 5:19 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34534/ --- (Updated June 3, 2015, 5:23 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34534/#review86440 --- Ship it! Ship It! - Timothy Chen On June 3, 2015, 5:23 p.m., Joe

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86441 --- src/slave/slave.cpp

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86447 --- include/mesos/slave/qos_controller.hpp

Re: Review Request 32365: Remove libprocess internal.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32365/#review86448 --- Patch looks great! Reviews applied: [32356, 35012, 35013, 32358, 32

Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review86442 --- docs/home.md

Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34910/#review86449 --- Can we make the test a unit test? Looks like we could pull up '`val

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

> On June 3, 2015, 5:58 a.m., Bartek Plotka wrote: > > Any idea why review requests failed to show diff of noop.hpp? > > > > I guess it something with > > https://reviews.apache.org/r/34962/diff/#file976910, since this patch > > depends on that. > > Bartek Plotka wrote: > reviewboard* N

Re: Review Request 34832: Add new qdisc tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated June 3, 2015, 6:25 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86457 --- Ditto, can we roll it in to a unit test of '`validateResources`'? -

Re: Review Request 34832: Add new qdisc tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review86458 --- Ship it! src/tests/routing_tests.cpp

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On June 3, 2015, 11:49 a.m., Niklas Nielsen wrote: > > src/common/http.cpp, line 209 > > > > > > We haven't established a doxygen style in the style guide yet, but > > shouldn't we expand this to: > > > > /

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review86453 --- Looking much better! :) A few suggestions below and let's get this

Re: Review Request 34984: Added help for files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/#review86463 --- Thanks for taking this on, Aditi! I listed a few suggestions below

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated June 3, 2015, 7:36 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34863: Add tests for new qdisc statistics functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/ --- (Updated June 3, 2015, 7:40 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34863: Add tests for new qdisc statistics functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/#review86474 --- Patch looks great! Reviews applied: [34832, 34426, 34863] All test

Re: Review Request 34911: Added a test for launching an executor on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34911/#review86477 --- Ship it! src/tests/oversubscription_tests.cpp

Re: Review Request 34832: Add new qdisc tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated June 3, 2015, 8:35 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

> On June 3, 2015, 6:49 p.m., Niklas Nielsen wrote: > > src/common/http.cpp, line 209 > > > > > > We haven't established a doxygen style in the style guide yet, but > > shouldn't we expand this to: > > > > /*

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- (Updated June 3, 2015, 9 p.m.) Review request for mesos, haosdent huang and Nik

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86464 --- Do you want to add a test to verify that this works? :) include/me

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 9:16 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

> On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote: > > Do you want to add a test to verify that this works? :) Definitely will do that in next patch (: - Bartek --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated June 3, 2015, 9:19 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34863: Add tests for new qdisc statistics functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/ --- (Updated June 3, 2015, 9:20 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review86461 --- Overall it's looking pretty good! I'd suggest splitting out the test

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review86482 --- Patch looks great! Reviews applied: [34687] All tests passed. - M

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 1, 2015, 7:17 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 529 > > > > > > This page doesn't seem to document these statistics. Is there a more > > relevant page? Only slightly more relevant

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/ --- (Updated June 3, 2015, 9:54 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34317: Updated callers of os::getenv() in /src and removed calls to os::hasenv()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review86486 --- Ship it! Ship It! - Timothy Chen On May 25, 2015, 4:44 p.m., Gre

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/#review86485 --- Ship it! Ship It! - Timothy Chen On May 25, 2015, 4:43 p.m., Gre

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318/#review86487 --- Ship it! Ship It! - Timothy Chen On May 25, 2015, 4:36 p.m., Gre

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- (Updated June 3, 2015, 10:05 p.m.) Review request for mesos, Bartek Plotka, Nik

Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone. Reposi

Review Request 35024: Fixed _resources_used() to include only *regular* resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2776 https://issues.ap

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86490 --- Ship it! src/slave/resource_estimators/noop.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 10:21 p.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/#review86493 --- Ship it! src/linux/routing/queueing/internal.hpp

Re: Review Request 34863: Add tests for new qdisc statistics functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/#review86494 --- Ship it! Ship It! - Jie Yu On June 3, 2015, 9:20 p.m., Paul Bret

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86496 --- Ship it! Ship It! - Niklas Nielsen On June 3, 2015, 3:21 p.m., B

Review Request 35033: Define potentially missing MS_* mount flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Descriptio

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86497 --- src/slave/resource_estimators/noop.cpp

Re: Review Request 35033: Define potentially missing MS_* mount flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/ --- (Updated June 3, 2015, 3:53 p.m.) Review request for mesos, Jie Yu and Vinod Ko

Re: Review Request 35033: Define potentially missing MS_* mount flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/#review86498 --- Ship it! Ship It! - Jie Yu On June 3, 2015, 10:53 p.m., Ian Down

Re: Review Request 31012: [1/5] Added memory statisics test fixure and a test for RSS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31012/ --- (Updated June 3, 2015, 10:58 p.m.) Review request for mesos, Dominic Hamon, Ian

Re: Review Request 31012: [1/5] Added memory statisics test fixure and a test for RSS.

> On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/cgroups_tests.cpp, line 1262 > > > > > > Why is this a member variable: it's not used internally by the class. Setup uses limit now. kept 'limit' and 'a

Re: Review Request 32755: [3/5] Added a memory statistics test for memory-mapped file.

> On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/memory_test_helper.cpp, lines 191-194 > > > > > > What happens to this test if /tmp is a tmpfs? Do the cache pages get > > accounted differently Tested w

Re: Review Request 32754: [2/5] Added a memory statistics test for page cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32754/ --- (Updated June 3, 2015, 10:59 p.m.) Review request for mesos, Ian Downes and Jie

Review Request 35037: Added doxygen link to home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35037/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 32755: [3/5] Added a memory statistics test for memory-mapped file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32755/ --- (Updated June 3, 2015, 11 p.m.) Review request for mesos, Ian Downes and Jie Yu

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review86499 --- Ship it! include/mesos/slave/qos_controller.hpp

Re: Review Request 32756: [4/5] Added a memory statistics test for active anonymous memory.

> On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/memory_test_helper.hpp, lines 69-70 > > > > > > How does this tie into the timing loop above in the test? Do we know > > within what time the kernel will m

Re: Review Request 32756: [4/5] Added a memory statistics test for active anonymous memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32756/ --- (Updated June 3, 2015, 11:01 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/ --- (Updated June 3, 2015, 11:05 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86503 --- Patch looks great! Reviews applied: [34894] All tests passed. - M

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

> On April 8, 2015, 6:44 p.m., Ian Downes wrote: > > src/tests/memory_test_helper.cpp, lines 297-300 > > > > > > What happens to this test if /tmp is a tmpfs? Yeah, with /tmp mounted as tmpfs, 'writeback' is 0. To a

Review Request 35036: Changed to use constexpr in MemoryTestHelper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35036/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 11:10 p.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86502 --- LGTM :) src/Makefile.am

Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35038/ --- Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen. Bugs: MESOS-2

Re: Review Request 34317: Updated callers of os::getenv() in /src and removed calls to os::hasenv()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/#review86506 --- Greg can you rebase your patches on latest master and update the rev

Re: Review Request 35024: Fixed _resources_used() to include only *regular* resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/#review86505 --- Ship it! Ship It! - Vinod Kone On June 3, 2015, 10:08 p.m., Jian

Re: Review Request 34632: Added QoS Controller in slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86501 --- LGTM overall. Just one place (regarding the time when we start to re

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86507 --- src/slave/resource_estimators/fixed.cpp

Re: Review Request 34633: Added QoS Controller test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86508 --- Ship it! src/tests/oversubscription_tests.cpp

Re: Review Request 35037: Added doxygen link to home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35037/#review86510 --- Ship it! Thanks Nik! docs/home.md

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35038/#review86514 --- Ship it! src/slave/slave.cpp

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:30 p.m., Vinod Kone wrote: > > src/slave/resource_estimators/fixed.cpp, line 47 > > > > > > Since the slave now asks the estimator everytime it wants to forward an > > update and doesn't store a c

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

> On June 3, 2015, 11:44 p.m., Jie Yu wrote: > > Also, could you please adjust the comments above the public resource estimator 'oversubscribable()' interface since we incur a minimal interval in the slave? - Jie --- This is an automat

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35038/#review86518 --- LGTM modulo Jie's comment on the hard check - Niklas Nielsen On J

Re: Review Request 34631: Added QoS Controller.

> On June 3, 2015, 10:54 a.m., Bartek Plotka wrote: > > include/mesos/slave/qos_controller.hpp, line 52 > > > > > > Small thing: > > s/type/name/ ..to be consistent with allocator factory. (: > > > > What i

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35038/ --- (Updated June 4, 2015, 12:03 a.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 4, 2015, 12:08 a.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34631: Added QoS Controller.

> On June 3, 2015, 5:54 p.m., Bartek Plotka wrote: > > include/mesos/slave/qos_controller.hpp, line 52 > > > > > > Small thing: > > s/type/name/ ..to be consistent with allocator factory. (: > > > > What is

Re: Review Request 35033: Define potentially missing MS_* mount flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/#review86528 --- Patch looks great! Reviews applied: [35033] All tests passed. - M

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

> On June 3, 2015, 10:35 p.m., Jie Yu wrote: > > src/linux/routing/queueing/internal.hpp, line 320 > > > > > > Why <=? The definition for RTNL_TC_STATS_MAX comes from libnl and looks like this: enum rtnl_tc_stat {

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated June 4, 2015, 1:19 a.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34631: Added QoS Controller.

> On June 3, 2015, 10:54 a.m., Bartek Plotka wrote: > > include/mesos/slave/qos_controller.hpp, line 52 > > > > > > Small thing: > > s/type/name/ ..to be consistent with allocator factory. (: > > > > What i

Re: Review Request 35036: Changed to use constexpr in MemoryTestHelper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35036/#review86534 --- Patch looks great! Reviews applied: [31012, 32754, 32755, 32756, 32

  1   2   >