Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40292/ --- (Updated Nov. 17, 2015, 8:07 a.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 40378: Added link to upgrade guide to documentation page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/#review106806 --- Patch looks great! Reviews applied: [40378] All tests passed. -

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40292/#review106807 --- docs/markdown-style-guide.md (line 116)

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40292/#review106809 --- What is the motivation for this? Are there any studies proving it f

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 16, 2015, 7:01 p.m., Joseph Wu wrote: > > include/mesos/quota/quota.proto, lines 54-57 > > > > > > I noticed that the other endpoints do not take `QuotaInfo` objects; but > > instead take a `Resources` cust

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review106811 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

> On Nov. 13, 2015, 3:04 a.m., Neil Conway wrote: > > This patch should also have updated v1/mesos.proto, I'd think? > > haosdent huang wrote: > Because I found we have some inconsistents between mesos.proto and > v1/mesos.proto. Should we update v1/mesos.proto? +1, Please update v1/mesos.

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > What is the motivation for this? Are there any studies proving it > > facilitates preception? Motivation is the current inconsistent writing of numbers e.g. in the c++ styleguide. - Joerg

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

> On Nov. 17, 2015, 8:16 a.m., Guangya Liu wrote: > > docs/markdown-style-guide.md, line 116 > > > > > > s/10/ten? > > > > Another question is that can you please show an example from 10 upwards? 10 should

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

> On Nov. 16, 2015, 3:23 p.m., Joerg Schad wrote: > > src/tests/mesos.hpp, line 1245 > > > > > > This looks somehow weird... Who is satisfying the expect_call? > > Guangya Liu wrote: > I also have the same ques

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

> On 十一月 17, 2015, 8:16 a.m., Guangya Liu wrote: > > docs/markdown-style-guide.md, line 116 > > > > > > s/10/ten? > > > > Another question is that can you please show an example from 10 upwards? > > Joerg S

Re: Review Request 40293: Applied consistent number syle in c++ styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/#review106821 --- Patch looks great! Reviews applied: [40291, 40292, 40293] All tes

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 17, 2015, 10:29 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 37266: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/ --- (Updated Nov. 17, 2015, 10:33 a.m.) Review request for mesos. Bugs: MESOS-257

Re: Review Request 37267: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37267/ --- (Updated Nov. 17, 2015, 10:34 a.m.) Review request for mesos. Bugs: MESOS-257

Re: Review Request 37268: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/ --- (Updated Nov. 17, 2015, 10:34 a.m.) Review request for mesos. Bugs: MESOS-257

Re: Review Request 40187: Fixed and formatted JSON examples.

> On Nov. 17, 2015, 6:27 a.m., Neil Conway wrote: > > This should also update docs/configuration.md Thanks! Fortunately `docs/configuration.md` looks very good overall. Just a comma too much -- though I hope that I haven't overlooked something there. - Jan --

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/ --- (Updated Nov. 17, 2015, 11:41 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106831 --- Ship it! Ship It! - Neil Conway On Nov. 17, 2015, 10:41 a.m., J

Review Request 40382: Windows: Added threadsafe `strerror_r` implementaiton.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoort

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Nov. 17, 2015, 10:59 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 37266: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/#review106832 --- support/cpplint.py (line 2966)

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106838 --- Patch looks great! Reviews applied: [40187] All tests passed. -

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Nov. 17, 2015, 2:14 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106851 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 3

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 17, 2015, 2:35 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 17, 2015, 2:36 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106860 --- Bad patch! Reviews applied: [40226, 40227, 39276, 37998, 37999, 38

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 4, 2015, 1:02 a.m., Michael Hopcroft wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line > > 107 > > > > > > Is the enum+switch+unreachable a common pattern in stout? It s

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 17, 2015, 3:23 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 17, 2015, 3:44 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

> On Nov. 17, 2015, 3:12 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 216-228 > > > > > > Can you please explain more why using mesos containerizer can also run > > a docker container? Thanks! The '''Ima

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 17, 2015, 5:07 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. Bugs: M

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review106891 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913, 38059, 39

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 17, 2015, 5:38 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review106892 --- src/health-check/main.cpp (line 238)

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Nov. 17, 2015, 9:43 a.m.) Review request for mesos, Anand Mazumdar, Ji

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review106893 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913, 38059, 39

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

> On Nov. 17, 2015, 6:11 p.m., Vinod Kone wrote: > > Also needs updating of resources.cpp - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review106898 -

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/ --- (Updated Nov. 17, 2015, 10:14 a.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review106898 --- include/mesos/mesos.proto (line 651)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 17, 2015, 6:16 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 171 > > > > > > For ```request.guarantee()```, I think we need to call ```flatten()``` > > to remove role first. That's exatly

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review106908 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

> On Nov. 2, 2015, 10:02 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, lines > > 66-69 > > > > > > This seems weird. `readdir_r`, per your implementation, only return

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 43 > > > > > > Presumably, this will always be true for Stout. So do we need

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Nov. 17, 2015, 7:02 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/ --- (Updated Nov. 17, 2015, 7:02 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 43 > > > > > > Presumably, this will always be true for Stout. So do we need

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Nov. 17, 2015, 7:06 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38233: os: add swap information to memory().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38233/#review106917 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (lin

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/#review106914 --- Ship it! LGTM. - Joseph Wu On Nov. 16, 2015, 1:32 p.m., Alex Cl

Re: Review Request 38234: Check if swap is enabled before running memory pressure related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38234/#review106919 --- src/tests/containerizer/cgroups_tests.cpp (lines 560 - 568)

Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40195/#review106916 --- Ship it! Checked that empty commits do not lint everything. (OSX)

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4244-4247 > > > > > > why do it here instead of in recoverFramework() #4363? that feels more > > consistent with #1345. > > James Pea

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/#review106928 --- Patch looks great! Reviews applied: [40372] All tests passed. -

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/#review106927 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 17, 2015, 8:15 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 17, 2015, 8:16 p.m.) Review request for mesos, Bernd Mathiske, Jo

Review Request 40396: Quota: Added a test for offer rescinding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Jos

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review106929 --- Ship it! LGTM. 3rdparty/libprocess/3rdparty/stout/include/stout/

Review Request 40398: Quota: Extended allocator interface with recovery method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and

Review Request 40399: Quota: Introduced quota registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/#review105936 --- Ship it! Checked that `process.hpp` logically the same as `posix/p

Review Request 40400: Quota: Added registry tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and

Review Request 40401: Quota: Persisted quota to registry for set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40401/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and

Review Request 40402: Quota: Loaded quotas upon master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40402/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and

Re: Review Request 40253: Added URI protobuf definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/ --- (Updated Nov. 17, 2015, 8:43 p.m.) Review request for mesos, Ben Mahler, Ian Do

Re: Review Request 40400: Quota: Added registry tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/ --- (Updated Nov. 17, 2015, 8:52 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40399: Quota: Introduced quota registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/ --- (Updated Nov. 17, 2015, 8:51 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40402/ --- (Updated Nov. 17, 2015, 8:52 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40401: Quota: Persisted quota to registry for set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40401/ --- (Updated Nov. 17, 2015, 8:52 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40401: Quota: Persisted quota to registry for set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40401/ --- (Updated Nov. 17, 2015, 8:54 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40400: Quota: Added registry tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/ --- (Updated Nov. 17, 2015, 8:54 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40398: Quota: Extended allocator interface with recovery method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/ --- (Updated Nov. 17, 2015, 8:54 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40402/ --- (Updated Nov. 17, 2015, 8:54 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 40399: Quota: Introduced quota registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/ --- (Updated Nov. 17, 2015, 8:53 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/#review106930 --- Ship it! Double-checked non-Windows build. src/files/files.hpp (

Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40146/#review106936 --- Ship it! Looks good. Just a few nits (newlines) here and there to

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106937 --- Ship it! Since the Windows build was broken by this (https://revi

Re: Review Request 40396: Quota: Added a test for offer rescinding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review106940 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Review Request 40403: Added streaming and construction methods for URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

> On Nov. 17, 2015, 9:11 p.m., Joseph Wu wrote: > > Since the Windows build was broken by this > > (https://reviews.apache.org/r/39005/), you may want to separate this commit > > from the chain. The reason I put it at the end is because I briefly thought that it would be unwise to get caught

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review106926 --- src/linux/perf.cpp (line 514)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in 'future

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40402/#review106945 --- Patch looks great! Reviews applied: [40399, 40400, 40401, 40398, 4

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 26, 2015, 5:20 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > > > > > Why not add a 0x prefix if it's not present so you can use numify? > > >

Re: Review Request 37101: Remove unused sched API's

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review106954 --- Ship it! Ship It! - Ian Downes On Aug. 24, 2015, 2:30 p.m., Con

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review106951 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 1

Re: Review Request 40403: Added streaming and construction methods for URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/#review106961 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274, 4

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/ --- (Updated Nov. 17, 2015, 3:49 p.m.) Review request for mesos, Jie Yu, Jojy Vargh

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/#review106960 --- docs/home.md (line 40)

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40243/#review106962 --- Ship it! include/mesos/mesos.proto (line 583)

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/#review106963 --- Ship it! src/master/http.cpp

Re: Review Request 40245: Fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/#review106964 --- Ship it! Ship It! - Michael Park On Nov. 13, 2015, 12:43 p.m.,

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/#review106965 --- Ship it! Ship It! - Michael Park On Nov. 13, 2015, 12:43 p.m.,

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review106967 --- Patch looks great! Reviews applied: [38901, 38919, 39712] Passed

  1   2   >