Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-01-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41848/#review113354 --- Overall, the changes and tests LGTM. src/master/validation.cpp

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113353 --- 3rdparty/libprocess/README.md (line 247)

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review113375 --- src/slave/containerizer/mesos/containerizer.cpp (lines 482 - 483)

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated 一月 8, 2016, 1:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 8, 2016, 1:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41815: Unified Container: Added provisioner to mesos containerizer.

2016-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41815/#review113351 --- Ship it! Ship It! - Jie Yu On Jan. 6, 2016, 11:40 p.m.,

Re: Review Request 42025: Added flag for enabling HTTP authentication.

2016-01-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/ --- (Updated Jan. 7, 2016, 11:21 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-07 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 7, 2016, 4 p.m.) Review request for mesos and Artem Harutyunyan.

Re: Review Request 41817: Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.

2016-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41817/#review113370 --- Ship it! Ship It! - Jie Yu On Jan. 6, 2016, 11:41 p.m.,

Re: Review Request 41819: Added ContainerConfig to all isolators.

2016-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/#review113372 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines

Re: Review Request 42025: Added flag for enabling HTTP authentication.

2016-01-07 Thread Till Toenshoff
> On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/tests/master_quota_tests.cpp, line 1103 > > > > > > Does it matter that credentials != None()? Should you maybe clear out > > credentials as well? It should

Review Request 42040: Added Quota Operator Documentation.

2016-01-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

2016-01-07 Thread Joseph Wu
> On Jan. 3, 2016, 2:43 a.m., Klaus Ma wrote: > > I think it's too early to update total allocation slack here; my suggestion > > to handle dynamic reservation: > > > > 1. Did not reduce total allocation slack in > > updateAllocation/updateAvailable; but if no allocated ALLOCATIONS_SLACK, >

Review Request 42044: Fixed typos in comments.

2016-01-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42044/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

2016-01-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41782/#review113373 --- src/Makefile.am (line 1077)

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- (Updated Jan. 8, 2016, 12:52 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 7:04 p.m., Joseph Wu wrote: > > include/mesos/resources.hpp, line 166 > > > > > > s/ revocable/, resources reserved but not allocated/ Done > On 一月 7, 2016, 7:04 p.m., Joseph Wu wrote: > >

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-01-07 Thread Guangya Liu
> On 一月 6, 2016, 11:32 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 712-723 > > > > > > Suggestion: > > ``` > > if (role.isSome() && role.get() != resource.role()) { > > return false; > >

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
> On 一月 6, 2016, 12:01 p.m., Klaus Ma wrote: > > Overall comments is that: is this code called by any others? If not, why > > should we add that? I'd suggest to add this on demand. > > Joseph Wu wrote: > I agree. If this is not used, we should not add it. > > Guangya Liu wrote: > It

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-07 Thread Joseph Wu
> On Jan. 6, 2016, 11:32 a.m., Jojy Varghese wrote: > > src/tests/container_logger_tests.cpp, line 95 > > > > > > What is the ownership semantics of this pointer? Here and other places. Other than the `Docker`

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113358 --- Can we link this page from `home.md`? Overall: looks great! Only

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-07 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review113368 --- Ship it! Ship It! - Daniel Pravat On Dec. 23, 2015, 6:44 a.m.,

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

2016-01-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/#review113369 --- Ship it! src/tests/container_logger_tests.cpp (lines 28 - 30)

Re: Review Request 42044: Fixed typos in comments.

2016-01-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42044/#review113374 --- Ship it! Ship It! - Adam B On Jan. 7, 2016, 4:15 p.m., Neil

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread David Forsythe
> On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 659 > > > > > > s/int */int* / > > Project style guide: > >

Re: Review Request 35711: Disallow special characters in role name.

2016-01-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113287 --- Still wondering if `class Roles` is any better than `namespace

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-07 Thread Joseph Wu
> On Jan. 6, 2016, 11:21 a.m., Jojy Varghese wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > Do you need all the variables on the stack to be passed to the capture? > > Maybe just executorInfo ?

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-07 Thread Daniel Pravat
> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 104 > > > > > > Can you check the semnatic of opendir() function? I'm

Re: Review Request 41816: Generated ContainerConfig in mesos containerizer.

2016-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41816/#review113366 --- src/slave/containerizer/mesos/containerizer.cpp (lines 693 - 702)

Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-07 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3307

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2016-01-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Jan. 7, 2016, 11:27 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113239 --- Bad patch! Reviews applied: [42011] Failed command:

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Jan. 7, 2016, 8:04 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 7, 2016, 10:52 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41848/ --- (Updated 一月 7, 2016, 11:26 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113240 --- src/master/allocator/mesos/hierarchical.cpp (line 1379)

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/#review113222 --- Ship it! Ship It! - Klaus Ma On Jan. 7, 2016, 7:05 a.m., Neil

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 7, 2016, 11:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 6:55 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1350 > > > > > > It does not include `ALLOCATIONS_SLACK` in `remainingClusterResources`; > > so if account

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review113236 --- Bad patch! Reviews applied: [42015, 41870] Failed command:

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41989/#review113233 --- Patch looks great! Reviews applied: [41934, 41935, 41989] Passed

Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated Jan. 7, 2016, 9:09 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 42011: Added gtest flags to generate xml report.

2016-01-07 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/ --- (Updated Jan. 7, 2016, 1:55 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42025: Added flag for enabling HTTP authentication.

2016-01-07 Thread Till Toenshoff
> On Jan. 7, 2016, 2:38 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 210 > > > > > > Please add to configuration.md Thanks! - Till --- This is

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 4:01 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 一月 7, 2016, 1:41 p.m.) Review request for mesos and Alexander

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113250 --- Bad patch! Reviews applied: [42011] Failed command:

Re: Review Request 41859: WIP: Launch tasks after evicting executors.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/ --- (Updated Jan. 7, 2016, 8:36 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 41858: WIP: Added helper functions to kill executor.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/ --- (Updated Jan. 7, 2016, 8:36 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review113260 --- Patch looks great! Reviews applied: [41787] Passed command:

Re: Review Request 41855: WIP: Trace pending executors.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/ --- (Updated Jan. 7, 2016, 8:34 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42025: Added flag for enabling HTTP authentication.

2016-01-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113255 --- src/master/flags.cpp (line 210)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113242 --- Great stuff, happy to see it landing! Some general suggestions,

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review113386 --- Ship it! 3rdparty/libprocess/README.md (line 665)

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113391 --- Overall looks good! Is it worth adding a unit test for this, I

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Guangya Liu
> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 一月 8, 2016, 2:13 a.m.) Review request for mesos and Alexander

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 11:51 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1379 > > > > > > Add `allocation slack resource` if any `resources.unreserved()` already include allocation

Re: Review Request 41791: Updated allocation slack when dynamic reservation was updated.

2016-01-07 Thread Guangya Liu
> On 一月 3, 2016, 10:43 a.m., Klaus Ma wrote: > > I think it's too early to update total allocation slack here; my suggestion > > to handle dynamic reservation: > > > > 1. Did not reduce total allocation slack in > > updateAllocation/updateAvailable; but if no allocated ALLOCATIONS_SLACK, > >

Review Request 42059: Update ContainerLogger to use Subprocess::IO type

2016-01-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository:

Review Request 42052: Changed Subprocess::IO to an abstract type.

2016-01-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42052/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository:

Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 11:38 p.m., Joseph Wu wrote: > > src/master/validation.cpp, line 487 > > > > > > This is probably not necessary. > > > > Before you'd see: > > "Task (and its executor, if exists) uses

Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-01-07 Thread Guangya Liu
> On 一月 8, 2016, 2:02 a.m., Jian Qiu wrote: > > maybe should also add a test case with mix of usage slack and allocation > > slack? Yes. - Guangya --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Till Toenshoff
> On Jan. 7, 2016, 3:28 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1187-1190 > > > > > > Let's remove this in a patch chained to this review (and fix MESOS-4149 > > as a consequence) in

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 8:22 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 438-443 > > > > > > Resources can be dynamically reserved, so ideally, you should > > recalculating the

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113377 --- This looks ready Alexander. Let me fix most issues marked here

Re: Review Request 41943: Fixed stout protobuf::parse to support JSON containing JSON::Null.

2016-01-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41943/ --- (Updated Jan. 7, 2016, 6:20 p.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42058: Fixed stout protobuf::parse by passing error message in nested JSON.

2016-01-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42058/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 8, 2016, 2:34 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-07 Thread Michael Park
> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 38 > > > > > > Is formatting off or it's just review board? The formatting is off I think. I can't

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 8, 2016, 4:47 a.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-07 Thread Michael Park
> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 97-99 > > > > > > Why this behaviour? I would expect if `set()` is not called,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 5:41 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rojas
> On Jan. 7, 2016, 4:28 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.cpp, lines 435-438 > > > > > > Since `setAuthenticator` is called in `Master::initialize()` won't it > > be a problem if we have

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 5:03 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Alexander Rukletsov
> On Jan. 7, 2016, 3:28 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.cpp, lines 435-438 > > > > > > Since `setAuthenticator` is called in `Master::initialize()` won't it > > be a problem if we have

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 7, 2016, 5:13 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

2016-01-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 7, 2016, 5:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113276 --- Ship it! Ship It! - Greg Mann On Jan. 7, 2016, 4:41 p.m.,

Re: Review Request 40529: Added helper function to get stateless resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 一月 8, 2016, 1:35 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/#review113387 --- src/slave/slave.cpp (line 3872)

Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41848/#review113389 --- maybe should also add a test case with mix of usage slack and

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113402 --- Patch looks great! Reviews applied: [42040] Passed command:

Re: Review Request 41878: Consistently used fixed width types.

2016-01-07 Thread Benjamin Bannier
> On Jan. 8, 2016, 6:42 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp, lines 404-405 > > > > > > Not yours, but can we actually fix the overflow issue here? We should >

Re: Review Request 41850: Add map to trace evictable executors.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/ --- (Updated Jan. 8, 2016, 2:53 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41858: Added helper functions to kill executor.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/ --- (Updated Jan. 8, 2016, 3:02 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review113427 --- Patch looks great! Reviews applied: [41600] Passed command:

Re: Review Request 41791: Updated allocation slack when dynamic reservation reserve some new resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 8, 2016, 7:11 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113428 --- LGTM. Two minor issues: 1. May be we can escape without passing

Re: Review Request 41858: Added helper functions to kill executor.

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/#review113429 --- src/slave/slave.cpp (line 4886)

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review113412 --- Patch looks great! Reviews applied: [41596, 41726] Passed

Re: Review Request 41878: Consistently used fixed width types.

2016-01-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/#review113413 --- Ship it!

Re: Review Request 41879: Removed constructor which uses restricted width.

2016-01-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/#review113414 --- Ship it! Ship It! - Michael Park On Jan. 5, 2016, 8:27 a.m.,

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113418 --- Bad patch! Reviews applied: [42053] Failed command:

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 8, 2016, 6:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41857: WIP: Got evictable executors.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated Jan. 8, 2016, 2:51 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

2016-01-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated Jan. 8, 2016, 2:51 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 8, 2016, 6:46 a.m.) Review request for mesos, Ben Mahler, Artem

  1   2   >