Review Request 46188: Added the missing 'break' when handling ERROR event.

2016-04-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46188/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 14, 2016, 6:29 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Guangya Liu
> On 四月 13, 2016, 8:54 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 113 > > > > > > other `--flag` params are computed elsewhere (e.g. DvdClient::mount); > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Guangya Liu
> On 四月 5, 2016, 5:47 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 110 > > > > > > ``` > > foreach (const string& driverOption, > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Guangya Liu
> On 四月 13, 2016, 9:05 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 106 > > > > > > we should probably validate (or else sanitize) the contents of driver, > >

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128841 --- Patch looks great! Reviews applied: [45806, 46134] Passed

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 14, 2016, 6:05 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review128873 --- This'll do quite nicely once we address these issues.

Re: Review Request 45922: Added agent authorization flags.

2016-04-14 Thread Jan Schlicht
> On April 13, 2016, 3:58 p.m., Benjamin Bannier wrote: > > src/tests/cluster.cpp, lines 398-410 > > > > > > You are shadowing the outer `Option` here with a > > `Result`. All of the

Re: Review Request 45922: Added agent authorization flags.

2016-04-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 14, 2016, 1 p.m.) Review request for mesos, Adam B and

Re: Review Request 45922: Added agent authorization flags.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review128875 --- Patch looks great! Reviews applied: [45922] Passed command:

Re: Review Request 46083: Used already forward-declared process::http::OK.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46083/#review128866 --- Ship it! Ship It! - Adam B On April 12, 2016, 6:48 a.m.,

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128872 --- Looks good. Fix these issues (mine and AlexR's) and we can commit

Re: Review Request 46084: Added needed forward-declaration for InternalServerError.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46084/#review128868 --- Ship it! Ship It! - Adam B On April 12, 2016, 6:06 a.m.,

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

2016-04-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/#review128871 --- Ship it! Ship It! - Adam B On April 12, 2016, 1:04 p.m.,

Re: Review Request 46149: Speed up ExamplesTest.DynamicReservationFramework.

2016-04-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/#review128877 --- This is much better, but still long. I see that now most of the

Re: Review Request 45370: Implemented prepare() for volume isolator.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128946 ---

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/#review128955 --- Ship it! Ship It! - Joseph Wu On April 10, 2016, 6:39 p.m.,

Re: Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/ --- (Updated April 14, 2016, 8:33 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-14 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128938 --- Fix it, then Ship it!

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-14 Thread Joris Van Remoortere
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp, lines 22-23 > > > > > > This seems generally useful? > > I think I've even seen it

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-14 Thread Anand Mazumdar
> On April 12, 2016, 9:11 p.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/#review128939 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review128941 --- src/slave/flags.cpp (line 803)

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review128971 --- src/slave/containerizer/mesos/isolators/docker/volume/spec.proto

Re: Review Request 45377: Updated prepare() logic for unified container.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review128981 --- Patch looks great! Reviews applied: [45214, 45217, 45270, 45360,

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/#review128956 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 7:24 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Greg Mann
> On April 14, 2016, 8:17 p.m., Greg Mann wrote: > > Could you fix the typo in the commit message: "protobut" should be "protobuf". Also, could you remove the duplicate Summary that's in the Description field, and add a more verbose description of the patch in the Description field? - Greg

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review128942 ---

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/ --- (Updated April 14, 2016, 8:38 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-14 Thread Joris Van Remoortere
> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179 > > > > > > Can you explain why this is not defined on windows? > > Alex Clemmer

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/#review128960 --- Patch looks great! Reviews applied: [46214] Passed command:

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review128997 ---

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129011 --- src/CMakeLists.txt (lines 52 - 54)

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-14 Thread Alex Clemmer
> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp, lines 22-23 > > > > > > This seems generally useful? > > I think I've even seen it

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-14 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46189/ --- (Updated 四月 14, 2016, 11:27 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46189/#review128992 --- Can you comment in the testing section how you verified that you

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46190/#review128993 --- Can you comment in the testing section how you verified that you

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-14 Thread Alex Clemmer
> On April 13, 2016, 2:38 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 168 > > > > > > Do we no longer have a "not implemented" error? Per our conversation on

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-14 Thread Alex Clemmer
> On April 12, 2016, 2:57 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines > > 188-189 > > > > > > Where did `processes()` go? It goes into a later

Re: Review Request 45217: Implemented docker volume driver isolator interface.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/#review128985 --- Ship it! Ship It! - Jie Yu On April 14, 2016, 12:32 a.m.,

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- (Updated April 14, 2016, 2:43 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 14, 2016, 2:43 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129003 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review129012 --- Bad patch! Reviews applied: [45905, 45604] Failed command:

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review129023 ---

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review129022 --- docs/configuration.md (line 1411)

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

2016-04-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/ --- (Updated April 14, 2016, 11:07 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/#review128989 --- Fix it, then Ship it!

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-14 Thread Joseph Wu
> On April 12, 2016, 3:46 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 69-90 > > > > > > The interaction between these flags is a bit unclear. > > > > If some doesn't set

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129016 --- src/CMakeLists.txt (line 145)

Review Request 46227: Added an user to indicate owner of persistent volume.

2016-04-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4893

Review Request 46229: Add unit tests for adding a user for persistent volumes.

2016-04-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4893

Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-04-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4893

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128983 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line

Re: Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/#review129005 --- Patch looks great! Reviews applied: [45969, 46053, 45970, 46220]

Re: Review Request 46015: Stout:[2/2] Moved process tests to their own file.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46015/#review128995 --- Ship it! Ship It! - Michael Park On April 11, 2016, 9:02

Re: Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46192/#review129006 --- 3rdparty/libprocess/3rdparty/stout/tests/os/systems_tests.cpp

Re: Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

2016-04-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46193/#review129007 --- Ship it! Ship It! - Michael Park On April 14, 2016, 8:28

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/#review129021 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Review Request 46228: Create persistent volume with a supplied user.

2016-04-14 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4893

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46190/ --- (Updated 四月 14, 2016, 11:25 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

2016-04-14 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46190/ --- (Updated 四月 14, 2016, 11:26 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-14 Thread Anand Mazumdar
> On April 13, 2016, 10:05 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > Also, I'm wondering if it would be better for the library to take > Authorization string as a parameter instead of Credential. That way it is > more generic because the library can just set "Authorization: >

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/ --- (Updated April 15, 2016, 12:11 a.m.) Review request for mesos and Vinod Kone.

Review Request 46242: Removed a check in Reserve operation validation.

2016-04-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/ --- Review request for mesos, Adam B and Joris Van Remoortere. Repository: mesos

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/ --- (Updated April 15, 2016, 9:51 a.m.) Review request for mesos and Vinod Kone.

Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46245/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-14 Thread Guangya Liu
> On 四月 15, 2016, 2:19 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 62 > > > > > > You should update it, right? > > > > Can you make sure you test the patch using cmake? Thanks! was testing now, just

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Guangya Liu
> On 四月 15, 2016, 12:27 a.m., Jie Yu wrote: > > Second thoughts on this. We should not use a single protobuf file for > > checkpointing. Otherwise, we'll have to write the entire file to the > > filesystem anytime we do a mount or umount. Let's just create some > > directory structure under

Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/#review129041 --- Fix it, then Ship it! src/master/master.cpp (lines 5945 -

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129043 --- Second thoughts on this. We should not use a single protobuf file

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-14 Thread Guangya Liu
> On 四月 14, 2016, 10:55 p.m., Jie Yu wrote: > > docs/configuration.md, line 1411 > > > > > > It's a directory or a file? Instead of doing that, can we just assume > > dvdcli is in 'PATH' and add a check in

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/#review129059 --- Patch looks great! Reviews applied: [46242] Passed command:

Re: Review Request 45014: Add /containers endpoint.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review129045 --- ping? - Jie Yu On April 12, 2016, 9:11 a.m., Jay Guo wrote: >

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-04-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/ --- (Updated April 15, 2016, 1:23 a.m.) Review request for mesos, Adam B and Joris

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Guangya Liu
> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, line 19 > > > > > > Why this namespace? This is technically not 'spec', but the _state_ > > scheme

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/#review129062 --- Patch looks great! Reviews applied: [46214] Passed command:

Re: Review Request 46209: Explicitly set `FrameworkInfo.principal` if AuthN is enabled.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46209/#review129038 --- Fix it, then Ship it! src/master/master.cpp (lines 2370 -

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/#review129048 --- Update the docs based on the previous review's changes. - Vinod

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129044 --- src/master/constants.hpp (line 132)

Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46245/ --- (Updated 四月 15, 2016, 2:35 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/#review129036 --- Patch looks great! Reviews applied: [46227, 46228, 46229, 46230]

Re: Review Request 46214: Valided role when framework subscribe.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/#review129035 --- src/tests/master_tests.cpp (lines 4081 - 4083)

Re: Review Request 46149: Speed up DynamicReservationFramework.

2016-04-14 Thread Klaus Ma
> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? > > Klaus Ma wrote: > @Bannier, how did you check the time in

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/ --- (Updated April 15, 2016, 12:23 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 15, 2016, 1:25 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46245/#review129058 --- src/CMakeLists.txt (line 62)

Review Request 46246: Log executor commands w/o verbose logs enabled.

2016-04-14 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46246/ --- Review request for mesos, Artem Harutyunyan and Joseph Wu. Bugs: MESOS-5197

  1   2   >