Re: Review Request 49961: Supported relative container path in docker containerizer.

> On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 568-570 > > > > > > why this does not work if I was using relative path for both? Here the > > relative container_path will be

Re: Review Request 49961: Supported relative container path in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/#review142073 --- Ship it! Can we follow up with some tests? - Jie Yu On July

Re: Review Request 49994: Fixed mismatching `delete`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49994/#review142079 --- Ship it! Thanks for fixing this! Note: Your description needs

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated July 13, 2016, 4:16 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On July 13, 2016, 1:32 p.m., Guangya Liu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1104 > > > > > > ```javascript > > EXPECT_TRUE(wait->has_status()); > > ``` All the other

Review Request 49994: Fixed mismatching `delete`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49994/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 49799: Added test case for 'GetTasks' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49799/#review142106 --- Ship it! Ship It! - Vinod Kone On July 12, 2016, 4:02 a.m.,

Review Request 49997: Modified docker test mount absolute/relative host path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49997/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated July 13, 2016, 7:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

> On July 13, 2016, 11 a.m., Gilbert Song wrote: > > src/tests/containerizer/appc_spec_tests.cpp, lines 227-228 > > > > > > ``` > > EXPECT_EQ( > > imageManifest->annotations(0).value(), > >

Re: Review Request 49816: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49816/ --- (Updated July 13, 2016, 6:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 13, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/ --- (Updated July 13, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/ --- (Updated July 13, 2016, 6:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46094/#review142100 --- Ship it! Ship It! - Joseph Wu On June 2, 2016, 1:30 p.m.,

Re: Review Request 46146: Fixed libprocess tests to use smart pointers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/#review142101 --- Ship it! Ship It! - Joseph Wu On June 2, 2016, 1:30 p.m.,

Re: Review Request 49961: Supported relative container path in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/ --- (Updated July 13, 2016, 12:26 p.m.) Review request for mesos, Guangya Liu,

Review Request 49998: Added docker test mount relative container path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49998/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 49815: Implemented `CgroupsIsolatorProcess::prepareHierarchy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49815/ --- (Updated July 13, 2016, 6:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 13, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 49999: Added docker test relative host path and relative container path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 49818: Implemented `CgroupsIsolatorProcess::createCgroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49818/ --- (Updated July 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49800: Added test case for 'GetState' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49800/#review142107 --- Ship it! Ship It! - Vinod Kone On July 12, 2016, 4:03 a.m.,

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 13, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142104 --- Ship it! I committed this patch and helped address some style

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142087 --- Fix it, then Ship it!

Re: Review Request 49990: Added cmake scripts to build slave component libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49990/#review142105 --- Patch looks great! Reviews applied: [49990] Passed command:

Re: Review Request 49975: Clarified motivation and responsibilities of maintainers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49975/#review142134 --- Ship it! Ship It! - Jie Yu On July 13, 2016, 4:26 a.m.,

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review142145 --- src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On July 12, 2016, 9:25 a.m., Neil Conway wrote: > > Is this change still necessary, given the changes in > > https://reviews.apache.org/r/48313 ? I'd prefer to keep the ability to > > create `MOUNT` volumes on existing filesystem content. > > Anindya Sinha wrote: > Without this change,

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/#review142155 --- src/examples/CMakeLists.txt (line 113)

Re: Review Request 42441: Decrease scheduler authenticate timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review142152 --- The patch looks good, thanks! However, the summary and

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 562 > > > > > > what about `path::absolute(volume.container_path())`? > > Jie Yu wrote: > +1 > > Guangya Liu wrote: > I saw

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142179 --- Patch looks great! Reviews applied: [50002, 50003] Passed

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 562 > > > > > > what about `path::absolute(volume.container_path())`? +1 > On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > >

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142137 --- Fix it, then Ship it!

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142140 --- Fix it, then Ship it! src/master/master.hpp (line 1758)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On 七月 13, 2016, 1:32 p.m., Guangya Liu wrote: > > @Lin Shuai, can you please help rebase this? I did some clean up before for src/tests/containerizer/filesystem_isolator_tests.cpp here https://reviews.apache.org/r/44160/ , for the new added test cases, instead of keeping consistent, what

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review142154 --- Patch looks great! Reviews applied: [5] Passed command:

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On 七月 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 562 > > > > > > what about `path::absolute(volume.container_path())`? > > Jie Yu wrote: > +1 I saw that the code was merged but

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated July 13, 2016, 5:21 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142181 --- 3rdparty/stout/tests/flags_tests.cpp (line 534)

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated July 13, 2016, 10:27 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 13, 2016, 10:26 p.m.) Review request for mesos. Bugs:

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 13, 2016, 11:05 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49381: Benchmark for Resources class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/#review142096 --- Some of my comments are spread across your review revisions

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 14, 2016, 12:11 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

> On July 13, 2016, 11:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated July 14, 2016, 1:20 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/ --- (Updated July 13, 2016, 10:26 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 13, 2016, 10:26 p.m.) Review request for mesos, Gilbert Song and

Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/ --- Review request for mesos and Artem Harutyunyan. Repository: mesos

Re: Review Request 49998: Added docker test mount relative container path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49998/#review142143 --- Ship it! Ship It! - Jie Yu On July 13, 2016, 7:26 p.m.,

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 568-570 > > > > > > why this does not work if I was using relative path for both? Here the > > relative container_path will be

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review142173 --- Fix it, then Ship it!

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142178 --- 3rdparty/stout/include/stout/flags/flags.hpp (lines 85 - 94)

Re: Review Request 49997: Modified docker test mount absolute/relative host path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49997/#review142142 --- Ship it! Ship It! - Jie Yu On July 13, 2016, 7:26 p.m.,

Re: Review Request 49999: Added docker test relative host path and relative container path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review142144 --- Ship it! Ship It! - Jie Yu On July 13, 2016, 7:26 p.m.,

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated July 13, 2016, 11:33 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46298: Rejected relative path agent work_dir.

> On July 11, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 175-179 > > > > > > Can we do that check in `add` function. `add` function supports an > > optional validate lambda to be passed in. > >

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On 七月 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 568-570 > > > > > > why this does not work if I was using relative path for both? Here the > > relative container_path will be

Re: Review Request 46298: Rejected relative path agent work_dir.

> On July 12, 2016, 4:23 a.m., Jie Yu wrote: > > src/slave/main.cpp, lines 175-179 > > > > > > Can we do that check in `add` function. `add` function supports an > > optional validate lambda to be passed in. > >

Re: Review Request 46298: Rejected relative path agent work_dir.

> On July 11, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 175-179 > > > > > > Can we do that check in `add` function. `add` function supports an > > optional validate lambda to be passed in. > >

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- (Updated July 13, 2016, 5:21 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated July 13, 2016, 5:21 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/ --- (Updated July 14, 2016, 1:19 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

> On July 11, 2016, 9:32 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3196 > > > > > > Two issues for this patch: > > > > 1) The new added framework number will introduce

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49784/#review142035 --- Ship it! Ship It! - Jiang Yan Xu On July 7, 2016, 9:02

Re: Review Request 49960: Added private registry with auth document and fixed correspondings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49960/#review142019 --- docs/container-image.md (lines 195 - 196)

Re: Review Request 49961: Supported relative container path in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/#review142022 --- src/docker/docker.cpp (line 562)

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142025 --- src/tests/containerizer/appc_spec_tests.cpp (lines 77 - 80)

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/#review142098 --- Note: I replaced `NULL` with `nullptr` prior to committing. -

Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5613

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review142099 --- Ship it! Note: I replaced `NULL` with `nullptr` prior to

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142113 --- Ship it! Ship It! - Gilbert Song On July 13, 2016, 9:16

Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5613

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/#review142097 --- Note: I replaced `NULL` with `nullptr` prior to committing. -

Re: Review Request 49975: Clarified motivation and responsibilities of maintainers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49975/#review142121 --- Ship it! LGTM. Thanks Ben! - Vinod Kone On July 13, 2016,

Re: Review Request 49999: Added docker test relative host path and relative container path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review142127 --- Patch looks great! Reviews applied: [49960, 49961, 49997, 49998,

Re: Review Request 49552: Fixed typo in docker runtime.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49552/#review142110 --- Ship it! Ship It! - Gilbert Song On July 2, 2016, 2:39

Re: Review Request 50016: Fixed the flaky test case `AgentAPITest.GetState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50016/#review142191 --- Ship it! Ship It! - Vinod Kone On July 14, 2016, 2:22 a.m.,

Review Request 50016: Fixed the flaky test case `AgentAPITest.GetState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50016/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5846

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142187 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/#review142188 --- Patch looks great! Reviews applied: [50010] Passed command:

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/#review142190 --- Bad review! Reviews applied: [49689] Error: No reviewers

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142046 --- src/tests/api_tests.cpp (line 95)

Re: Review Request 49232: Added appcManifest to ImageIt nfo and ProvisionInfo.

> On 七月 12, 2016, 6:42 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 212-221 > > > > > > You just need to check isError here. Yes, you can refer to

Re: Review Request 49232: Added appcManifest to ImageIt nfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142032 --- src/slave/containerizer/mesos/containerizer.cpp (lines 59 - 68)

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review142052 --- BTW, one thought: rather than writing out a new checkpoint and

Re: Review Request 49381: Benchmark for Resources class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/#review142053 --- Patch looks great! Reviews applied: [49381] Passed command:

Re: Review Request 42441: Decrease scheduler authenticate timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/ --- (Updated July 13, 2016, 1:54 p.m.) Review request for mesos, Alexander

Re: Review Request 49381: Benchmark for Resources class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 13, 2016, 9:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 42441: Decrease scheduler authenticate timeout.

> On Jan. 22, 2016, 1:59 p.m., Jian Qiu wrote: > > The reason I think is that the master starting from local drop the > > framework authentication message before it is fully started which cause the > > authentication timeout. I am not sure whether we can delay the start of > > framework until

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review142061 --- @Lin Shuai, can you please help rebase this?

Re: Review Request 49381: Benchmark for Resources class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49381/ --- (Updated July 13, 2016, 5:24 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 49990: Added cmake scripts to build slave component libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49990/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 49990: Added cmake scripts to build slave component libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49990/ --- (Updated July 13, 2016, 2:32 p.m.) Review request for mesos, Alex Clemmer and

  1   2   >