Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 10, 2016, 4:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 10, 2016, 4:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 10, 2016, 4:31 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50758/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/ --- (Updated Aug. 10, 2016, 5:21 p.m.) Review request for mesos, Alexander

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 10, 2016, 4:33 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 10, 2016, 4:35 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 10, 2016, 4:34 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 10, 2016, 4:35 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50954: Added documentation to Appc runtime support.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50954/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5837

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 10, 2016, 4:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

2016-08-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/ --- (Updated Aug. 10, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50266: Introduced linux capabilities API.

2016-08-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/ --- (Updated Aug. 10, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 10, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50700: Added a list of "unreachable" agents to the registry.

2016-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50700/#review145360 --- src/master/registry.proto (line 45)

Re: Review Request 50266: Introduced linux capabilities API.

2016-08-10 Thread Benjamin Bannier
> On July 22, 2016, 2:32 a.m., Jie Yu wrote: > > src/linux/capabilities.hpp, lines 179-180 > > > > > > Do we still need this given that we only accept > > `_LINUX_CAPABILITY_VERSION_3`? Good point. We only support

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 10, 2016, 4:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 10, 2016, 4:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 10, 2016, 4:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

2016-08-10 Thread haosdent huang
> On Aug. 8, 2016, 3:17 p.m., Qian Zhang wrote: > > Hi, @qianzhang Because I think all the test cases are associate with `CgroupsIsolator`, I think it would be better to update the test cases name to make it more clear and exactly. - haosdent

Review Request 50956: Added name to uri fetcher plugins.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50956/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 10, 2016, 4:35 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 10, 2016, 4:35 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 10, 2016, 4:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-08-10 Thread Guangya Liu
> On 八月 10, 2016, 3:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp, line 153 > > > > > > What about update the message here as well by highlighting `mesos > >

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-08-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review145340 --- src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line

Re: Review Request 50872: Removed the redundant `mesos::` namespace prefix + minor style fixes.

2016-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50872/#review145339 --- Ship it! Ship It! - Vinod Kone On Aug. 6, 2016, 1:35 a.m.,

Re: Review Request 50851: Decode Protobuf long int form strings.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review145430 --- Can you add the reason/motivation for this change in your patch

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145434 --- Bad patch! Reviews applied: [50271, 50270, 50269, 50889, 50266]

Re: Review Request 50940: Removed a limitation.

2016-08-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50940/#review145435 --- Ship it! Ship It! - Qian Zhang On Aug. 10, 2016, 9:12 a.m.,

Re: Review Request 49351: Updated 'HealthCheck' protobuf validation.

2016-08-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49351/#review145417 --- src/docker/executor.cpp (lines 470 - 471)

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Kevin Klues
> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Kevin Klues
> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the

Re: Review Request 50907: Abstracted mesos-style.py to wrap the cpp linter in a class.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50907/#review145437 --- Fix it, then Ship it! Since you're making the linter object

Re: Review Request 50878: Avoid subtract resource when check contains for non persistent volume.

2016-08-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50878/#review145440 --- Ship it! Ship It! - Benjamin Mahler On Aug. 7, 2016, 3:40

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Joseph Wu
> On Aug. 10, 2016, 12:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside

Re: Review Request 50877: Added more cases for sorter benchmark test.

2016-08-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50877/#review145443 --- Fix it, then Ship it! src/tests/sorter_tests.cpp (line 699)

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review145445 --- Patch looks great! Reviews applied: [43558] Passed command:

Review Request 50957: Added fetch method based on plugin name.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50957/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288

Review Request 50960: Added appc uri fetcher tests.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288

Re: Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50964/#review145392 --- Ship it! Thanks for the prompt fix! - Anand Mazumdar On

Re: Review Request 50266: Introduced linux capabilities API.

2016-08-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/ --- (Updated Aug. 10, 2016, 9:14 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-08-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review145390 --- src/examples/persistent_volume_framework.cpp (lines 402 - 410)

Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50964/ --- Review request for mesos, Anand Mazumdar and Artem Harutyunyan. Repository:

Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.

2016-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50887/#review145370 --- Ship it! Ship It! - Michael Park On Aug. 8, 2016, 4:13

Re: Review Request 50899: Removed unneeded extra space in stout code base.

2016-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50899/#review145371 --- Ship it! Ship It! - Michael Park On Aug. 8, 2016, 4:17

Re: Review Request 50900: Removed unneeded extra space in libprocess code base.

2016-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50900/#review145372 --- Ship it! Ship It! - Michael Park On Aug. 8, 2016, 4:19

Review Request 50959: Added appc fetcher plugin to use rkt tool.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288

Re: Review Request 50914: Removed the external containerizer.

2016-08-10 Thread Vinod Kone
> On Aug. 10, 2016, 7:21 p.m., Vinod Kone wrote: > > src/Makefile.am, line 2263 > > > > > > this should be deleted as well. this is causing the ASF CI to fail. I pushed the fix. - Vinod

Re: Review Request 50914: Removed the external containerizer.

2016-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50914/#review145389 --- src/Makefile.am (line 2258)

Re: Review Request 50266: Introduced linux capabilities API.

2016-08-10 Thread Benjamin Bannier
> On July 22, 2016, 2:32 a.m., Jie Yu wrote: > > src/linux/capabilities.hpp, line 196 > > > > > > I'd prefer this method returns `Set`. > > > > We should have a general way to convert `CapabilityInfo` to >

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Haris Choudhary
> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the

Re: Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50964/ --- (Updated Aug. 10, 2016, 1:08 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- (Updated Aug. 10, 2016, 1:17 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-08-10 Thread haosdent huang
> On Aug. 10, 2016, 7:23 p.m., Benjamin Mahler wrote: > > src/examples/persistent_volume_framework.cpp, lines 402-410 > > > > > > Can you give some context on why lowering these speeds up the test? How > > much

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review145466 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999,

Re: Review Request 49571: Added a benchmark test for allocations.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review145459 --- Patch looks great! Reviews applied: [45960, 45961, 45962, 45963,

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review145451 --- src/health-check/health_checker.hpp (line 275)

Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50958/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4288

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145386 --- support/mesos-style.py (lines 228 - 234)

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

2016-08-10 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Aug. 10, 2016, 7:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review145406 --- Patch looks great! Reviews applied: [49819, 49820, 49821, 49823,

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

2016-08-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50922/#review145398 --- Fix it, then Ship it! src/health-check/health_checker.hpp

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Aug. 10, 2016, 9:49 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 八月 10, 2016, 10:33 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 八月 10, 2016, 10:33 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50857: WIP: Added an HTTP scheduler test with SSL enabled.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Aug. 10, 2016, 10:33 p.m.) Review request for mesos, Benjamin Mahler

Review Request 50969: Updated SSL environment variables in HTTP API libraries.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/ --- Review request for mesos, Joseph Wu and Vinod Kone. Bugs: MESOS-5966

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Aug. 10, 2016, 10:37 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50969: Updated SSL environment variables in HTTP API libraries.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/ --- (Updated Aug. 10, 2016, 10:39 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Haris Choudhary
> On Aug. 10, 2016, 4:53 a.m., Vinod Kone wrote: > > support/mesos-style.py, line 242 > > > > > > Don't follow this comment? I meant that as a note to myself. Forgot to remove it. I was talking about how pylint

Re: Review Request 50969: Updated SSL environment variables in HTTP API libraries.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/#review145426 --- src/executor/executor.cpp (lines 210 - 216)

Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/ --- (Updated Aug. 10, 2016, 10:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

2016-08-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Aug. 10, 2016, 10:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Haris Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/ --- (Updated Aug. 10, 2016, 10:43 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Haris Choudhary
> On Aug. 10, 2016, 4:53 a.m., Vinod Kone wrote: > > support/mesos-style.py, lines 228-234 > > > > > > this indentation looks weird? or is it just RB? I fixed that. Hope its better now. - Haris

Re: Review Request 50769: Fixed a broken link to CNI repo.

2016-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50769/#review145416 --- Ship it! Ship It! - Vinod Kone On Aug. 10, 2016, 1:11 a.m.,

Re: Review Request 50769: Fixed a broken link to CNI repo.

2016-08-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50769/#review145419 --- Ship it! Ship It! - Gilbert Song On Aug. 9, 2016, 6:11

Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/#review145420 --- 3rdparty/libprocess/src/http.cpp (lines 1373 - 1375)

Re: Review Request 50954: Added documentation to Appc runtime support.

2016-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50954/#review145423 --- Patch looks great! Reviews applied: [50954] Passed command:

Re: Review Request 50625: Renamed the filter for tests that depend on "perf".

2016-08-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50625/ --- (Updated Aug. 10, 2016, 11:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/#review145422 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 144)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-08-10 Thread Vinod Kone
> On Aug. 6, 2016, 12:29 a.m., Vinod Kone wrote: > > src/local/local.cpp, lines 179-180 > > > > > > not sure if 'propagated_flags' is the right name. > > > > also, wondering if it would be intuitive to just

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review145425 --- can you rebase? - Vinod Kone On July 21, 2016, 1:38 a.m.,

Re: Review Request 49571: Added a benchmark test for allocations.

2016-08-10 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Aug. 10, 2016, 11:09 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 八月 10, 2016, 10:32 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-10 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

2016-08-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review145428 --- src/tests/scheduler_tests.cpp (line 1516)

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

2016-08-10 Thread Ammar Askar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/ --- (Updated Aug. 10, 2016, 11:24 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-08-10 Thread Ammar Askar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated Aug. 10, 2016, 11:28 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-08-10 Thread Kevin Klues
> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the