Re: Review Request 38528: Disabled perf test when perf version is not supported.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/ --- (Updated Sept. 13, 2016, 4:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/#review148739 --- src/common/protobuf_utils.hpp (lines 185 - 189)

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/ --- (Updated Sept. 13, 2016, 2:37 p.m.) Review request for mesos and Vinod Kone.

Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/ --- Review request for mesos, Anindya Sinha and Guangya Liu. Repository: mesos

Re: Review Request 38528: Disable perf test when perf version is not support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/ --- (Updated Sept. 13, 2016, 4:19 p.m.) Review request for mesos, Joris Van

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148733 --- Patch looks great! Reviews applied: [51654, 50271] Passed

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review148728 --- Fix it, then Ship it! Ship It!

Re: Review Request 51673: Update mesos containerizer launch for sub-container support.

> On Sept. 6, 2016, 10:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1152-1160 > > > > > > why we need to do that? for the pod case, we have different tasks. and each task may

Re: Review Request 51789: Refactored the test cases for net_cls cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51789/#review148742 --- Ship it! Ship It! - Jie Yu On Sept. 13, 2016, 8:22 a.m.,

Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6151

Review Request 51855: Cleaned up `getExecutorInfo()` function in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51855/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 51857: Modified the `prepare` method to be aware of nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- Review request for mesos, Jie Yu, Joseph Wu, and Qian Zhang. Repository: mesos

Re: Review Request 50969: Made use of SSL flags to determine scheduler/executor scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/ --- (Updated Sept. 13, 2016, 6:10 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 51788: Refactored mem isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51788/#review148741 --- Fix it, then Ship it!

Re: Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51845/#review148752 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148743 --- Ship it! Ship It! - haosdent huang On Sept. 13, 2016, 5:04

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/#review148746 --- Looks like this needs a rebase? - Greg Mann On Aug. 13, 2016,

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148769 --- Patch looks great! Reviews applied: [51771] Passed command:

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Sept. 13, 2016, 6:13 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148812 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2016, 2:38

Re: Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51845/#review148814 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2016, 12:58

Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/#review148796 --- Fix it, then Ship it! src/slave/slave.cpp (line 6115)

Re: Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review148797 --- src/slave/containerizer/mesos/containerizer.cpp (lines 903 -

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review148799 --- Bad patch! Reviews applied: [50857, 50969, 50737, 51065, 50736,

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148815 --- include/mesos/resources.hpp (lines 503 - 504)

Re: Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/#review148802 --- Fix it, then Ship it! src/master/validation.cpp (line 56)

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review148821 --- Patch looks great! Reviews applied: [51857] Passed command:

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

> On Sept. 13, 2016, 2:59 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 55-59 > > > > > > s/::Error/Error/g We need the `::Error` to disambiguate the global

Re: Review Request 51672: Changed containerizer launch for nested containers to return a bool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51672/ --- (Updated Sept. 13, 2016, 2:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51669/ --- (Updated Sept. 13, 2016, 2:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Review Request 51860: Disabled deprecated function warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51860/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 51861: Removed macro redefinition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51861/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 51511: Added check in FileEncoder's destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148771 --- Ship it! Ship It! - Joris Van Remoortere On Aug. 30, 2016,

Re: Review Request 51860: Disabled deprecated function warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51860/ --- (Updated Sept. 13, 2016, 8:56 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51671: Implement mesos conainertizer launch for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51671/ --- (Updated Sept. 13, 2016, 2:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 51670: Changed the containerizer launch interface for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51670/ --- (Updated Sept. 13, 2016, 2:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 51668: Changed the nested ContainerID from hashmap to hashset in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/ --- (Updated Sept. 13, 2016, 2:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148793 --- Patch looks great! Reviews applied: [51850] Passed command:

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51850/#review148791 --- Ship it! Ship It! - Anindya Sinha On Sept. 13, 2016, 5:04

Re: Review Request 51855: Cleaned up `getExecutorInfo()` function in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51855/#review148795 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2016, 7:49

Re: Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/ --- (Updated Sept. 13, 2016, 9:20 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/#review148831 --- src/tests/containerizer/cgroups_tests.cpp (line 532)

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 14, 2016, 12:41 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 595-601 > > > > > > Looks like this assumes 2-levels of nesting (maximum). You might as > >

Review Request 51879: Determine disk size when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6062

Re: Review Request 51501: Exposed metrics in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review148822 --- src/scheduler/scheduler.cpp (line 744)

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

> On Sept. 13, 2016, 2:59 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 55-59 > > > > > > s/::Error/Error/g > > Avinash sridharan wrote: > We need the

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

> On Sept. 13, 2016, 5:41 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 595-601 > > > > > > Looks like this assumes 2-levels of nesting (maximum). You might as > >

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

> On Sept. 13, 2016, 6:02 p.m., Joseph Wu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 532 > > > > > > This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`: > > ``` > >

Re: Review Request 51878: Fixed a typo in `CpuIsolatorTest.ROOT_SystemCpuUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51878/#review148848 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2016, 6:52

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51881: Fixed failed cgroups isolator test cases in CentOS 6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51881/ --- (Updated Sept. 14, 2016, 2:54 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51878: Fixed a typo in `CpuIsolatorTest.ROOT_SystemCpuUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51878/#review148844 --- Ship it! Ship It! - Qian Zhang On Sept. 14, 2016, 9:52

Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6062

Review Request 51882: Reverted "Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51882/ --- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

> On Sept. 14, 2016, 1:02 a.m., Joseph Wu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 532 > > > > > > This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`: > > ``` > >

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

> On Sept. 14, 2016, 1:02 a.m., Joseph Wu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 532 > > > > > > This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`: > > ``` > >

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

> On Sept. 14, 2016, 1:02 a.m., Joseph Wu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 532 > > > > > > This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`: > > ``` > >

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Review Request 51878: Fixed a typo in `CpuIsolatorTest.ROOT_SystemCpuUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51878/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.

> On 九月 14, 2016, 12:08 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 511-512 > > > > > > I think that we should also mention for how to convert a `Resource` > > object to `Resource_` object in

Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos

Review Request 51881: Fixed failed cgroups isolator test cases in CentOS 6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51881/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 51882: Reverted "Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51882/ --- (Updated Sept. 14, 2016, 3:54 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51861: Removed macro redefinition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51861/#review148854 --- Patch looks great! Reviews applied: [51860, 51861] Passed

Re: Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/#review148859 --- Patch looks great! Reviews applied: [51855, 51856] Passed

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/ --- (Updated 九月 14, 2016, 5:47 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51148/#review148727 --- Patch looks great! Reviews applied: [51149, 51150, 51151, 51808,

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/ --- (Updated Sept. 13, 2016, 2:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51808/ --- (Updated Sept. 13, 2016, 10:24 a.m.) Review request for mesos and Michael

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/ --- (Updated Sept. 13, 2016, 10:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

> On Sept. 13, 2016, 3:01 a.m., Qian Zhang wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 517-523 > > > > > > I think we may not need these code anymore since `100.5` has already > > covered both `big`

Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51808/#review148675 --- Ship it! Ship It! - Michael Park On Sept. 12, 2016, 2:41

Re: Review Request 51151: Moved MockContainerLogger to the single test where it is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51151/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael

Re: Review Request 51149: Cleaned up 'using' statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51149/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael

Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51150/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael

Re: Review Request 51152: Moved MockDocker and related declarations to separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51152/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael

Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51148/ --- (Updated Sept. 13, 2016, 10:21 a.m.) Review request for mesos and Michael

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

> On Sept. 12, 2016, 8:26 p.m., Vinod Kone wrote: > > src/master/validation.cpp, lines 1020-1021 > > > > > > ``` > > return Error("Docker ContainerInfo is not supported"); > > ``` Took the liberty of

Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/ --- (Updated Sept. 13, 2016, 9:01 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/#review148690 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Review Request 51839: Checked correct file descriptor after call to `dup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51839/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Joris Van

Re: Review Request 51149: Cleaned up 'using' statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51149/ --- (Updated Sept. 13, 2016, 10:22 a.m.) Review request for mesos and Michael

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/ --- (Updated Sept. 13, 2016, 10:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148692 --- Bad review! Reviews applied: [51631, 51791, 51790, 51789, 51788,

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 2:34 a.m., Jie Yu wrote: > > Can you move tests into a separate patch? If you have no strong objections I would really like to keep them as part of this patch. - Benjamin --- This is an automatically generated

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 8, 2016, 11:12 a.m., Jay Guo wrote: > > src/tests/containerizer/isolator_tests.cpp, line 1802 > > > > > > I think we need more comprehensive tests for all the cases listed in > > the matrix in design

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp, lines 57-68 > > > > > > Do you know that `Set` supports union and intersection. I think here we > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 13, 2016, 1:52 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

> On Sept. 12, 2016, 10:52 p.m., Vinod Kone wrote: > > src/master/flags.cpp, line 571 > > > > > > do we want to enforce that `registry_max_agent_age` is >= > > `registry_gc_interval`? otherwise, users might be

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/ --- (Updated Sept. 13, 2016, 12:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148695 --- Fix it, then Ship it! Ship It!

Re: Review Request 51840: Fixed leak of task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51840/#review148707 --- Patch looks great! Reviews applied: [51840] Passed command:

Re: Review Request 51835: Support changing the cgroup owner for command tasks that has rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51835/#review148664 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 51835: Support changing the cgroup owner for command tasks that has rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51835/#review148663 --- Ship it! Ship It! - haosdent huang On Sept. 13, 2016, 4:59

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On 九月 12, 2016, 8:46 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 273-274 > > > > > > It seems a bit odd that the caller has to both touch allocation > > candidates and then

  1   2   >