Re: Review Request 63818: Added quick start instructions for CMake.

2017-11-15 Thread Andrew Schwartzmeyer
> On Nov. 14, 2017, 5:40 p.m., Gaston Kleiman wrote: > > docs/cmake.md > > Lines 43 (patched) > > > > > > I had to look up how to pass more parameters to make in order to use > > more threads: > > > >

Re: Review Request 63818: Added quick start instructions for CMake.

2017-11-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63818/ --- (Updated Nov. 15, 2017, 11:08 a.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63848/#review191085 --- Ship it! Ship It! - Jie Yu On Nov. 15, 2017, 7:42 p.m.,

Review Request 63741: Fixed framework subscription with suppressed roles.

2017-11-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

2017-11-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63830/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

2017-11-15 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63846/ --- (Updated Nov. 15, 2017, 8:14 p.m.) Review request for mesos and Alexander

Re: Review Request 63809: Windows: Fixed symlink code to not need admin privileges.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63809/#review191091 --- Ship it! - John Kordich On Nov. 14, 2017, 11:14 p.m., Andrew

Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

2017-11-15 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63846/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

2017-11-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63846/#review191090 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 15, 2017,

Re: Review Request 63818: Added quick start instructions for CMake.

2017-11-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63818/#review191080 --- Ship it! Thanks for the doc update!!! docs/cmake.md Lines 50

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

2017-11-15 Thread Benjamin Bannier
> On Nov. 13, 2017, 11:07 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3800-3803 (patched) > > > > > > Am I correct in thinking that we usually don't use quotes around IDs > > that we generate

Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63848/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 15, 2017, 9:21 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63639: Enabled rvalue reference parameters in protobuf handlers.

2017-11-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63639/#review191115 --- Ship it! 3rdparty/libprocess/include/process/protobuf.hpp

Re: Review Request 62637: Added an object approver to authorize requests from resource providers.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62637/#review191084 --- src/authorizer/local/authorizer.cpp Lines 558-567 (patched)

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-11-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/ --- (Updated Nov. 15, 2017, 9:40 p.m.) Review request for mesos and Benjamin

Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/#review191098 --- Ship it! - John Kordich On Nov. 14, 2017, 11:16 p.m., Andrew

Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.

2017-11-15 Thread Andrew Schwartzmeyer
> On Nov. 15, 2017, 12:53 p.m., John Kordich wrote: > > Nice fix, that would have been annoying otherwise. Indeed, and we need to follow it up with properly propogating `GLOG_v`. - Andrew --- This is an automatically generated e-mail.

Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

2017-11-15 Thread Andrew Schwartzmeyer
> On Nov. 15, 2017, 12:38 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 178 (patched) > > > > > > I've seen this function "stringify" before, but I don't have

Re: Review Request 63768: Added 'ReconcileOfferOperations' response to scheduler API.

2017-11-15 Thread Greg Mann
> On Nov. 14, 2017, 10:12 p.m., Gaston Kleiman wrote: > > src/scheduler/scheduler.cpp > > Lines 123-124 (original), 123 (patched) > > > > > > For consistency I think that it'd also be nice to remove the `using > >

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/#review191109 --- src/slave/slave.cpp Lines 3751-3757 (patched)

Review Request 63850: Used fully qualified namespace in the scheduler library for consistency.

2017-11-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63850/ --- Review request for mesos and Gaston Kleiman. Repository: mesos Description

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review191106 --- src/slave/container_daemon.hpp Lines 40 (patched)

Re: Review Request 63850: Used fully qualified namespace in the scheduler library for consistency.

2017-11-15 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63850/#review191118 --- Ship it! <3 - Gaston Kleiman On Nov. 15, 2017, 1:54 p.m.,

Re: Review Request 63842: Allowed removing non-terminal offer operations.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191104 --- src/master/master.cpp Lines 9816-9817 (original)

Re: Review Request 63844: Removed acknowledged offer operation status updates.

2017-11-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/#review191093 --- src/slave/slave.cpp Lines 3791-3798 (patched)

Re: Review Request 63811: Windows: Added `get_handle_follow` which follows symlinks.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63811/#review191095 --- Ship it! I'm not an expert, but I don't see any problems here.

Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63815/#review191099 --- Ship it! Nice fix, that would have been annoying otherwise. -

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-11-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review191107 --- Fix it, then Ship it! 3rdparty/stout/Makefile.am Line 122

Re: Review Request 63804: Added plumbing for operation reconciliation between master and agent.

2017-11-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Nov. 15, 2017, 9:51 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63851: Changed backend validation logic from exclusive to inclusive.

2017-11-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63851/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8236

Re: Review Request 63810: Windows: Added internal `fullpath` API to normalize paths.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63810/#review191094 --- Fix it, then Ship it!

Re: Review Request 63850: Used fully qualified namespace in the scheduler library for consistency.

2017-11-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63850/ --- (Updated Nov. 15, 2017, 9:54 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63752: Updated documentation on protobuf version requirements.

2017-11-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63752/#review191113 --- Ship it! Ship It! - Benjamin Mahler On Nov. 13, 2017, 1:35

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/#review191119 --- PASS: Mesos patch 63678 was successfully built and tested. All

Re: Review Request 63812: Windows: Fixed `os::realpath` to behave like POSIX version.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63812/#review191096 --- Ship it! - John Kordich On Nov. 14, 2017, 11:14 p.m., Andrew

Re: Review Request 63813: Windows: Fixed name of default executor.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63813/#review191097 --- Ship it! - John Kordich On Nov. 14, 2017, 11:15 p.m., Andrew

Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/#review191100 --- Ship it! - John Kordich On Nov. 14, 2017, 11:17 p.m., Andrew

Re: Review Request 63829: Modified Containerizer::remove to allow top-level containers.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63829/#review191041 --- FAIL: Failed to apply the dependent review: 55334. Failed

Review Request 63828: Added authorization tests for standalone container APIs.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/ --- Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.

Review Request 63829: Modified Containerizer::remove to allow top-level containers.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63829/ --- Review request for mesos, Gilbert Song, Jie Yu, and Zhitao Li. Repository:

Re: Review Request 63674: Updated a comment about resubscribing completed frameworks.

2017-11-15 Thread Alexander Rukletsov
> On Nov. 14, 2017, 8:55 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 2671 (original), 2671 (patched) > > > > > > s/opeartor/operator/ Fixed in

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/#review191114 --- src/slave/slave.cpp Lines 3743 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191108 --- src/slave/slave.cpp Line 6722 (original), 6722 (patched)

Re: Review Request 63021: Added `getService()` function to launch CSI plugins.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/#review191138 --- src/resource_provider/storage/provider.cpp Lines 124 (patched)

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Nov. 16, 2017, 3:58 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63799: Improved log messages of offer operations.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63799/#review191123 --- Ship it! Ship It! - Jie Yu On Nov. 14, 2017, 2:12 p.m., Jan

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-11-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review191117 --- Fix it, then Ship it! LGTM! Thank you for patientlt addressing

Re: Review Request 63385: Added utility functions for CSI responses and volume ID and metadata.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/#review191126 --- src/csi/utils.cpp Lines 41-46 (patched)

Re: Review Request 63732: Reconciled offer operations between agent and master.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191131 --- src/master/master.cpp Lines 7090-7091 (patched)

Re: Review Request 63732: Reconciled offer operations between agent and master.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191135 --- src/master/master.cpp Line 7044 (original), 7044 (patched)

Re: Review Request 63830: Fixed 'NoOffersWithAllRolesSuppressed' test.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63830/#review191139 --- PASS: Mesos patch 63830 was successfully built and tested.

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Nov. 16, 2017, 4:03 a.m.) Review request for mesos, Gilbert Song,

Review Request 63852: Added "Task" prefix to status update manager related classes/methods.

2017-11-15 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63852/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Review Request 63853: Added the "task" prefix to the name of the status update manager files.

2017-11-15 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8197

Re: Review Request 63798: Added resource provider support for all offer operations.

2017-11-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/#review191122 --- src/slave/slave.cpp Line 3737 (original), 3737 (patched)

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-11-15 Thread Zhitao Li
> On Nov. 16, 2017, 12:04 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Lines 472 (patched) > > > > > > is it possible to pass by value for our ReadWriteLock? so

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Nov. 16, 2017, 4 a.m.) Review request for mesos, Gilbert Song, Jason

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

2017-11-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review191121 --- Ship it! Ship It! - Michael Park On Nov. 6, 2017, 10:11

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review191140 --- PASS: Mesos patch 62777 was successfully built and tested.

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/ --- (Updated Nov. 16, 2017, 4:05 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63377: Added filesystem layout for storage resource providers.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/#review191087 --- src/resource_provider/storage/paths.hpp Lines 31-34 (patched)

Re: Review Request 63019: Encapsulated common error handling in CSI clients.

2017-11-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63019/#review191132 --- src/csi/client.cpp Lines 34-49 (patched)

Re: Review Request 63019: Encapsulated common error handling in CSI clients.

2017-11-15 Thread Chun-Hung Hsiao
> On Nov. 16, 2017, 12:47 a.m., Joseph Wu wrote: > > src/csi/client.cpp > > Lines 34-49 (patched) > > > > > > Can you add a comment explaining why these are recoverable? And how to > > recover from them (or a TODO

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

2017-11-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/ --- (Updated Nov. 16, 2017, 3:22 p.m.) Review request for mesos, Alexander

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

2017-11-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 16, 2017, 3:21 p.m.) Review request for mesos, Alexander

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191160 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review191159 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

2017-11-15 Thread Qian Zhang
> On Nov. 16, 2017, 8:49 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Line 830 (original), 831-833 (patched) > > > > > > This looks terrible, I wonder on which systems this will break... >

Re: Review Request 63844: Removed acknowledged offer operation status updates.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/#review191154 --- PASS: Mesos patch 63844 was successfully built and tested.

Re: Review Request 63853: Added the "task" prefix to the name of the status update manager files.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/#review191155 --- FAIL: Mesos failed to build. Reviews applied: `['63852',

Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

2017-11-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8223

Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63848/#review191149 --- PASS: Mesos patch 63848 was successfully built and tested.

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 5:24 a.m.) Review request for mesos, James Peach,

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191156 --- Fix it, then Ship it!

Re: Review Request 63850: Used fully qualified namespace in the scheduler library for consistency.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63850/#review191150 --- PASS: Mesos patch 63850 was successfully built and tested.

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

2017-11-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Nov. 15, 2017, 8:33 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-15 Thread Megha Sharma
> On Oct. 26, 2017, 8:23 a.m., Jiang Yan Xu wrote: > > src/master/master.hpp > > Lines 2591 (patched) > > > > > > You made a redundant copy here but I understand this line may go away > > anyways. :) That's

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 5:43 a.m.) Review request for mesos, James Peach,

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

2017-11-15 Thread Qian Zhang
> On Nov. 16, 2017, 8:49 a.m., Alexander Rukletsov wrote: > > src/checks/health_checker.cpp > > Lines 266-273 (patched) > > > > > > Hm, maybe this is more readable? > > ``` > > if ((healthCheck.type() ==

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-11-15 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 7:20 a.m.) Review request for mesos, James Peach,

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

2017-11-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/ --- (Updated Nov. 16, 2017, 3:20 p.m.) Review request for mesos, Alexander

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

2017-11-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review191124 --- Ship it! Could you rebase this patch? Cannot apply. - Gilbert

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

2017-11-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/#review191128 --- src/checks/checker_process.cpp Line 830 (original), 831-833

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

2017-11-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191133 --- src/checks/tcp_connect.cpp Line 86 (original), 84 (patched)

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

2017-11-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/#review191127 --- src/checks/health_checker.cpp Lines 266-273 (patched)

Re: Review Request 63798: Added resource provider support for all offer operations.

2017-11-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/ --- (Updated Nov. 15, 2017, 12:35 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63678: Improved the signal safety of `ns::clone`.

2017-11-15 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63678/#review191050 --- Ship it! Ship It! - Andrei Budnik On Nov. 14, 2017, 7:11

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

2017-11-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/ --- (Updated Nov. 15, 2017, 12:34 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63828: Added authorization tests for standalone container APIs.

2017-11-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/#review191043 --- Ship it! Ship It! - Alexander Rojas On Nov. 15, 2017, 9:42

Re: Review Request 63675: Added a non-allocating variant of `os::clone`.

2017-11-15 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63675/#review191051 --- Ship it! Ship It! - Andrei Budnik On Nov. 14, 2017, 7:06

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

2017-11-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/ --- (Updated Nov. 15, 2017, 5:06 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63677: Changed `os:Stack` to allocate with `mmap`.

2017-11-15 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63677/#review191052 --- Ship it! Ship It! - Andrei Budnik On Nov. 14, 2017, 7:11

Review Request 63833: Added context to new agent processing calls.

2017-11-15 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63833/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 63828: Added authorization tests for standalone container APIs.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/#review191053 --- PASS: Mesos patch 63828 was successfully built and tested.

Re: Review Request 63833: Added context to new agent processing calls.

2017-11-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63833/#review191068 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 15, 2017,

Re: Review Request 63577: Fixed a task status update race in default executor tests.

2017-11-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/#review191073 --- PASS: Mesos patch 63577 was successfully built and tested.

Re: Review Request 63730: Passed operations from resource provider to agent.

2017-11-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/ --- (Updated Nov. 15, 2017, 6:31 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 63842: Allowed removing non-terminal offer operations.

2017-11-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. Repository:

Review Request 63844: Removed acknowledged offer operation status updates.

2017-11-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/ --- Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. Repository:

  1   2   >