rpm builds look good, thanks!
- Jacob Janco
On Feb. 26, 2016, 8:18 a.m., Zhiwei Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/46416/diff/
Testing
---
Thanks,
Jacob Janco
/
Testing
---
Thanks,
Jacob Janco
://reviews.apache.org/r/46505/diff/
Testing
---
Thanks,
Jacob Janco
---
Thanks,
Jacob Janco
a9cb99a92ff5a783e719df5e5cfb6e8301241df9
src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c
Diff: https://reviews.apache.org/r/46505/diff/
Testing
---
Thanks,
Jacob Janco
9b558862e025c5caa71e05fc5eeba783c0ad6fd5
Diff: https://reviews.apache.org/r/46505/diff/
Testing (updated)
---
make check
visual check by sending a (`PUT`) request to an endpoint that does not support
it (`/quota`)
Thanks,
Jacob Janco
/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5
Diff: https://reviews.apache.org/r/46505/diff/
Testing (updated)
---
make check
Thanks,
Jacob Janco
/
Testing (updated)
---
make check
Thanks,
Jacob Janco
)
---
Constructed error string in MethodNotAllowed.
Diffs (updated)
-
3rdparty/libprocess/include/process/http.hpp
8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297
Diff: https://reviews.apache.org/r/46504/diff/
Testing
---
make check
Thanks,
Jacob Janco
=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check
Thanks,
Jacob Janco
; > ++suppressCount;
> > }
> >
> > ...
> > }
> > ```
I agree this is easier to understand and simpler if we loop by the expected
counts.
- Jacob
---
T
https://reviews.apache.org/r/49616/diff/
>
>
> Testing
> ---
>
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check
>
>
> Thanks,
>
> Jacob Janco
>
>
/tests/hierarchical_allocator_tests.cpp
bb6947fcecb5b78047e98d10fc1278c612a69548
Diff: https://reviews.apache.org/r/49616/diff/
Testing
---
MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check
Thanks,
Jacob Janco
/#review143901
---
On July 28, 2016, 8:42 p.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apac
ut of 6000
frameworks suppressing offers
allocate() took 17.318823secs to make 0 offers with 6000 out of 6000 frameworks
suppressing offers
...
Thanks,
Jacob Janco
shutdownFramework to associated agents.
Diffs
-
src/master/master.cpp 78a8889313179b4509a6657e6c61d9f6d3bb99c0
src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22
Diff: https://reviews.apache.org/r/50268/diff/
Testing
---
Thanks,
Jacob Janco
frameworks on 1 agent with 2 agents in cluster
pre: ShutDownFrameworkMessage sent to both agents.
post: ShutdownFrameworkMessage sent to agent with executors associated with
framework.
Thanks,
Jacob Janco
: https://reviews.apache.org/r/50268/diff/
Testing
---
5 frameworks on 1 agent with 2 agents in cluster
pre: ShutDownFrameworkMessage sent to both agents.
post: ShutdownFrameworkMessage sent to agent with executors associated with
framework.
Thanks,
Jacob Janco
in batches.
Diffs
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49617/diff/
Testing
---
make check
Thanks,
Jacob Janco
,
Jacob Janco
Diff: https://reviews.apache.org/r/49617/diff/
Testing
---
make check
Thanks,
Jacob Janco
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49616/diff/
Testing
---
make check
Thanks,
Jacob Janco
/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49616/diff/
Testing (updated)
---
MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressFrameworks*" make check
Thanks,
Jacob Janco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
---
On July 8, 2016, 5:55 p.m., Jacob Janco wrote:
>
> --
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141251
-------
On July 8, 2016, 5:55 p.m., Jacob Janco wrote:
>
> ---
> This i
test.
Agreed, I'll add this.
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141253
---
/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49616/diff/
Testing (updated)
---
MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check
Thanks,
Jacob Janco
) {
> > allocator->recoverResources(
> > offer.frameworkId,
> > offer.slaveId,
> > offer.resources,
> > None());
> > }
> >
> > offers.clear();
> > }
> >
frameworks.
- In this scenario, frameworks are offered resources
and suppressed in batches.
Diffs (updated)
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49617/diff/
Testing
---
make check
Thanks,
Jacob Janco
frameworks.
- In this scenario, frameworks are offered resources
and suppressed in batches.
Diffs (updated)
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49617/diff/
Testing
---
make check
Thanks,
Jacob Janco
are offered resources
and suppressed in batches.
Diffs (updated)
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49617/diff/
Testing
---
make check
Thanks,
Jacob Janco
/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49616/diff/
Testing
---
make check
Thanks,
Jacob Janco
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
-------
On July 8, 2016, 3:48 a.m., Jacob Janco wrote:
>
>
ition for (unsigned i = batchStart; i < batchEnd && i
< frameworkCount; i++) {
to account for all frameworkCount cases.
Also, I recover offers there because only framework 1 of the batch will get an
offer, so we will get 1005 offers for the whole of a test run with 1000 agents
the 5 being
,
Jacob Janco
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49784/diff/
Testing
---
make check
Thanks,
Jacob Janco
) {
> > allocator->recoverResources(
> > offer.frameworkId,
> > offer.slaveId,
> > offer.resources,
> > None());
> > }
> >
> > offers.clear();
> > }
> >
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review140714
-------
On July 5, 2016, 6:17 p.m., Jacob Janco wrote:
>
> ---
> T
/diff/
Testing
---
make check
Thanks,
Jacob Janco
frameworks suppressing offers
allocate() took 17.318823secs to make 0 offers with 6000 out of 6000 frameworks
suppressing offers
...
Thanks,
Jacob Janco
allocator settled after 7us
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
(6332 ms)
Thanks,
Jacob Janco
---
Thanks,
Jacob Janco
/master/allocator/mesos/hierarchical.cpp
234ef98529964a0b6d3f132426a6c8ccbb1263ee
Diff: https://reviews.apache.org/r/51027/diff/
Testing
---
Thanks,
Jacob Janco
or settled after 7us
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
(6332 ms)
Thanks,
Jacob Janco
allocator settled after 25.525654secs
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(220137 ms)
Thanks,
Jacob Janco
://reviews.apache.org/r/51028/diff/
Testing (updated)
---
make check
Thanks,
Jacob Janco
,
Jacob Janco
filters depends on https://reviews.apache.org/r/51028
Thanks,
Jacob Janco
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review164111
---
On Jan. 31, 2017, 1:46 a.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
cpp
5f540569043df9d2bb75416c8c36bb4dd7bd68a1
Diff: https://reviews.apache.org/r/56296/diff/
Testing (updated)
---
make check.
Thanks,
Jacob Janco
ing
---
Thanks,
Jacob Janco
t;
> Jiang Yan Xu wrote:
> Ah I see what you mean now, thanks! I guess we can copy
> `allocationInterval` in.
>
> Jacob Janco wrote:
> ^I'll submit a patch with the above fix.
https://reviews.apache.org/r/56296
- Jacob
-
check
Thanks,
Jacob Janco
/
Testing
---
With https://reviews.apache.org/r/51027/:
GTEST_FILTER="-*SmallOfferFilter*" make check -j8
Thanks,
Jacob Janco
---
On Jan. 31, 2017, 1:47 a.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52534/
> -
check
Thanks,
Jacob Janco
check
Thanks,
Jacob Janco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
---
Ship it!
Ship It!
- Jacob Janco
On Jan. 31, 2017, 9:03 a.m
880e64ee7614e224660c6616b4bbb1ee5fab8ec9
Diff: https://reviews.apache.org/r/55791/diff/
Testing (updated)
---
make check + verification of clipboard functionality
Thanks,
Jacob Janco
to comments in review 54216.
Diffs
-
src/webui/master/static/js/controllers.js
b6364fa636a6dc4b8d314285bec7dc19eb1c9c3b
src/webui/master/static/pailer.html 2f48d2393088bd1eceab0f25174c0366cdb41694
Diff: https://reviews.apache.org/r/55889/diff/
Testing
---
Thanks,
Jacob Janco
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review162229
---
On Jan. 12, 2017, 6:55 p.m., Jacob Janco wrote:
>
>
, RescindRevocableOfferWithIncreasedRevocable),
fix in 51621
Thanks,
Jacob Janco
/
Testing
---
With https://reviews.apache.org/r/51027/:
GTEST_FILTER="-*SmallOfferFilter*" make check -j8
Thanks,
Jacob Janco
yea I like that better
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162722
---
On Jan. 27, 2
eviews.apache.org/r/51028/#review162237
---
On Jan. 27, 2017, 2:33 a.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
make check
Thanks,
Jacob Janco
d, was waiting for that commit =D
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review162529
---
On Jan. 27, 2
://reviews.apache.org/r/51028/diff/
Testing
---
make check
Thanks,
Jacob Janco
> On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote:
> > Ship It!
Makes sense, with batched allocation recovery and allocation can be interleaved
causing flakiness in this test.
- Jacob
---
This is an automatically generat
108546b97
testing::internal::HandleExceptionsInMethodIfSupported<>()
@0x108546a68 testing::UnitTest::Run()
@0x107642ee1 RUN_ALL_TESTS()
@0x10763ec1d main
@ 0x7fffc2091255 start
Segmentation fault: 11
- Jacob Janco
On Jan. 24, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55852/#review163594
---
Ship it!
Ship It!
- Jacob Janco
On Jan. 23, 2017, 7:08 p.m
> On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote:
> > Ship It!
>
> Jacob Janco wrote:
> Makes sense, with batched allocation recovery and allocation can be
> interleaved causing flakiness in this test.
Passed --gtest_
, RescindRevocableOfferWithIncreasedRevocable),
fix in 51621
Thanks,
Jacob Janco
/51028/diff/
Testing
---
make check
Thanks,
Jacob Janco
://reviews.apache.org/r/52534/diff/
Testing
---
With https://reviews.apache.org/r/51027/:
GTEST_FILTER="-*SmallOfferFilter*" make check -j8
Thanks,
Jacob Janco
(OversubscriptionTest, RescindRevocableOfferWithIncreasedRevocable),
fix in 51621
Thanks,
Jacob Janco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55874/#review163611
---
Ship it!
Ship It!
- Jacob Janco
On Jan. 24, 2017, 9:46 p.m
> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote:
> > If it looks the same as the other navbar tabs, it seems clickable? At least
> > when it is greyed out I wouldn't think I can click it.
>
> haosdent huang wrote:
> Got it, use `btn disabled` to make it grey now.
Hey, responding to
d45551d6c9f75c275032219768549f76865b9cd3
src/webui/master/static/js/zeroclipboard-1.1.7.min.js
32535fddf1baab255fcbf5d3d776a0a9ac1447e8
src/webui/master/static/obj/zeroclipboard-1.1.7.swf
880e64ee7614e224660c6616b4bbb1ee5fab8ec9
Diff: https://reviews.apache.org/r/55791/diff/
Testing
---
Thanks,
Jacob
/diff/
Testing
---
make check
Thanks,
Jacob Janco
19e0981143bd7e8372b49f4f036867e9dd05727a
Diff: https://reviews.apache.org/r/55691/diff/
Testing
---
make -j8 + test framework + checking pailer representation of files in sandbox
Thanks,
Jacob Janco
framework + checking pailer representation of files in sandbox
Thanks,
Jacob Janco
w162303
---
On Jan. 18, 2017, 11:40 p.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55
25.525654secs
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(220137 ms)
Thanks,
Jacob Janco
> >
> > allocation += createPorts(ranges.get());
> > ```
I took this out to simplify the test.
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review146625
---
On
following
> > event in the queue, are we still going to get the correct result?
> > ```
> > batch -> addFramework(f1) -> addFramework(f2)
> > ```
>
> Jacob Janco wrote:
> insert in a loop?
>
> Klaus Ma wrote:
> No; if multiple fr
on.
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review147697
---
On Aug. 23, 2016, 8:47 a.m., Jacob Janco
ly, visit:
https://reviews.apache.org/r/51028/#review147809
---
On Aug. 23, 2016, 8:47 a.m., Jacob Janco wrote:
>
> ---
> This is an automatically generated e-mail. To re
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review147697
---
On Aug. 23, 2016, 8:47 a.m., Jacob Janco wrote
> > finished after `addSlave` finished.
> >
> > Shall we do a `while` loop in the benchmark to wait till all
> > allocations are got?
>
> Guangya Liu wrote:
> Perhaps we can simply remove the `ASSERT_EQ` for offer and agent count in
> `Hierarchic
25.525654secs
[ OK ]
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(220137 ms)
Thanks,
Jacob Janco
(220137 ms)
Thanks,
Jacob Janco
generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review146919
---
On Aug. 23, 2016, 8:49 a.m., Jacob Janco wrote:
>
> ---
> This is an automatically
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review147722
---
On Sept. 3, 2016, 6:05 a.m., Jacob Janco wrote:
>
>
> ```
Yea, I think preserving the original behavior was the idea here so the metrics
reflect that.
- Jacob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5102
> > finished after `addSlave` finished.
> >
> > Shall we do a `while` loop in the benchmark to wait till all
> > allocations are got?
>
> Guangya Liu wrote:
> Perhaps we can simply remove the `ASSERT_EQ` for offer and agent count in
> `Hierarchic
this test may
> > be failed as r/51027
>
> Jacob Janco wrote:
> Since there is an `AWAIT_READY(allocation)` beforehand for the previous 2
> calls to the allocator, I believe we should be OK here.
>
> Guangya Liu wrote:
> Sorry, I posted this in the wrong place, it
/
Testing
---
make check
Thanks,
Jacob Janco
this test may
> > be failed as r/51027
>
> Jacob Janco wrote:
> Since there is an `AWAIT_READY(allocation)` beforehand for the previous 2
> calls to the allocator, I believe we should be OK here.
>
> Guangya Liu wrote:
> Sorry, I posted this in the wrong place, it
1 - 100 of 269 matches
Mail list logo
