Change in vdsm[master]: vdsm: Rely on system for logrotation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Rely on system for logrotation
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/63682/3/vdsm/vdsm-remove-logs
File vdsm/vdsm-remove-logs:

Line 15: /usr/bin/logger -t vdsm "ALERT clean of old import log files 
exited abnormally with [$EXITVALUE]"
Line 16: fi
Line 17: fi
Line 18: 
Line 19: exit $EXITVALUE
For another day, it would be nice to fix this bug. If the first operation 
failed and the second succeeded, we lie and return 0.


-- 
To view, visit https://gerrit.ovirt.org/63682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2: Verified+1

Tested on rhel 7.3 beta.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

Yaniv, what sparsify-inplace is doing is basically adding your disk to a 
special minimal vm, and running fstrim inside the vm.

If can sparsify only the top volume as the other volumes are read only, we 
cannot change history unless you ask to remove it (merge).

According to Richard, sparsify does not work on:

- guest files backed with NFS (before v4.2)
- guest storage on regular LVs (not using lvm-thinp)

So it should work with NFS >= 4.2, local storage, maybe glusterfs, probably not 
because of fuse.

Shmuel, did you try this with all storage types? can you report interesting 
results?

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Add module doc string for format converter ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Add module doc string for format converter 
class.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Add module doc string for format converter ...

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Add module doc string for format converter 
class.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-09-18 12:08:32 +0300
Line 4: Commit: Maor Lipchuk 
Line 5: CommitDate: 2016-09-18 13:47:09 +0300
Line 6: 
Line 7: formatConverter: Adding comment for format converter class.
> Add moulde docstring
Done
Line 8: 
Line 9: Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

1. I was under the impression it can sparsify all the way down to the parent 
(so if there are snaps, it'll sparsify in the correct layer, not just the 
current layer)?
2. I assume it can work on all storages (local, block, NFS, Gluster) - and just 
won't do the 'hole punching' on those not supporting DISCARD silently, which I 
think is OK for us.
3. not sure what the '--tmp prebuilt:file' is for - is it for our qcow2 (vs. 
qcow2v3) ? Can it run on /dev/shm/ (I assume every server will have 
few gigs available for this)?

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: log: Nicer logging format
..

log: Nicer logging format

Use nicer and more standard logging format, similar to engine log
format. Having similar logging formats should make it easier to debug
and support.

Here is an example log using the new format:

2016-09-19 00:02:25,291 INFO[vds] (MainThread) (PID: 10281) I am the actual 
vdsm 4.18.999-578.git61bfe00.el7 voodoo6.tlv.redhat.com (3.10.0-489.el7.x86_64)
2016-09-19 00:02:25,291 INFO[vds] (MainThread) VDSM will run with cpu 
affinity: frozenset([1])
2016-09-19 00:02:25,379 INFO[storage.check] (MainThread) Starting check 
service
2016-09-19 00:02:25,384 INFO[storage.Dispatcher] (MainThread) Starting 
StorageDispatcher...
2016-09-19 00:02:25,385 INFO[storage.asyncevent] (check/loop) Starting 

2016-09-19 00:02:25,482 INFO[dispatcher] (MainThread) Run and protect: 
registerDomainStateChangeCallback(callbackFunc=)
2016-09-19 00:02:25,482 INFO[dispatcher] (MainThread) Run and protect: 
registerDomainStateChangeCallback, Return response: None
2016-09-19 00:02:25,485 INFO[MOM] (MainThread) Preparing MOM interface
2016-09-19 00:02:25,486 INFO[MOM] (MainThread) Using named unix socket 
/var/run/vdsm/mom-vdsm.sock
2016-09-19 00:02:25,487 INFO[root] (MainThread) Unregistering all secrets
2016-09-19 00:02:25,491 INFO[vds] (MainThread) Setting channels' timeout to 
30 seconds.
2016-09-19 00:02:25,493 INFO[vds.MultiProtocolAcceptor] (MainThread) 
Listening at :::54321
2016-09-19 00:02:25,526 INFO[vds] (clientIFinit) recovery: completed in 0s
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map 
'360014052c81462a280847e8a6e3af8cd' has no slaves
2016-09-19 00:02:25,560 WARNING [storage.Multipath] (hsm/init) Map 
'36001405292bb96f19064f81b884fa63f' has no slaves
2016-09-19 00:02:27,115 INFO[vds] (BindingXMLRPC) XMLRPC server running
2016-09-19 00:02:27,122 INFO[health] (MainThread) Starting health monitor 
(interval=60)
2016-09-19 00:02:40,256 INFO[ProtocolDetector.AcceptorImpl] (Reactor 
thread) Accepting connection from ::1:42888
2016-09-19 00:02:40,270 INFO[ProtocolDetector.Detector] (Reactor thread) 
Detected protocol xml from ::1:42888
2016-09-19 00:02:40,270 INFO[vds.XMLRPCServer] (BindingXMLRPC) Starting 
request handler for ::1:42888
2016-09-19 00:02:40,271 INFO[vds.XMLRPCServer] (Thread-12) Request handler 
for ::1:42888 started
2016-09-19 00:02:40,272 INFO[throttled] (Thread-12) Current getAllVmStats: 
{}
2016-09-19 00:02:40,272 INFO[vds] (Thread-12) RPC call getAllVmStats 
finished (code=0) in 0.00 seconds

Unfinished: require updating all the tools parsing vdsm log.

Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Signed-off-by: Nir Soffer 
---
M static/etc/vdsm/logger.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64113/1

diff --git a/static/etc/vdsm/logger.conf.in b/static/etc/vdsm/logger.conf.in
index 34137ff..820fcb4 100644
--- a/static/etc/vdsm/logger.conf.in
+++ b/static/etc/vdsm/logger.conf.in
@@ -86,7 +86,7 @@
 format: %(message)s
 
 [formatter_long]
-format: 
%(threadName)s::%(levelname)s::%(asctime)s::%(module)s::%(lineno)d::%(name)s::(%(funcName)s)
 %(message)s
+format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) %(message)s
 
 [formatter_sysform]
 format= vdsm %(name)s %(levelname)s %(message)s


-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 1: Code-Review+1

Seems pretty straight forward, and it doesn't seem like you've left anything 
over.

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Remove unneeded fallback to blockRebase
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove unneeded fallback to blockRebase

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: vm: Remove unneeded fallback to blockRebase
..

vm: Remove unneeded fallback to blockRebase

If blockCopy was not supported, we fallback to blockRebase. This was
required when we supported libvirt < 1.2.9, but now we require 1.2.17
and we can remove this legacy code.

Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Signed-off-by: Nir Soffer 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/64111/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c936987..7e33227 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3537,26 +3537,7 @@
 flags = (libvirt.VIR_DOMAIN_BLOCK_COPY_SHALLOW |
  libvirt.VIR_DOMAIN_BLOCK_COPY_REUSE_EXT)
 
-# TODO: Remove fallback when using libvirt >= 1.2.9.
-try:
-self._dom.blockCopy(drive.name, destxml, flags=flags)
-except libvirt.libvirtError as e:
-if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
-raise
-
-self.log.warning("blockCopy not supported, using blockRebase")
-
-base = drive.diskReplicate["path"]
-self.log.debug("Replicating drive %s to %s", drive.name, base)
-
-flags = (libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY |
- libvirt.VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT |
- libvirt.VIR_DOMAIN_BLOCK_REBASE_SHALLOW)
-
-if drive.diskReplicate["diskType"] == DISK_TYPE.BLOCK:
-flags |= libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY_DEV
-
-self._dom.blockRebase(drive.name, base, flags=flags)
+self._dom.blockCopy(drive.name, destxml, flags=flags)
 
 def _setDiskReplica(self, drive, replica):
 """


-- 
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08a7f5e2e0308b7278c4b2512c95b209dacd9c26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

Can you rebase on master?

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

(4 comments)

Great work Shmuel!

The only thing missing is blocking this for volumes that do not support 
sparsifying. If think that this works now only on nfs 4.2 and later (correct me 
if you have more recent info).

I think the best way would be to add supports_sparsify() method to 
sd.StorageDomainManifest and return False.

Then add real implementation to NFStorageDomainManifest returning True if the 
current version > 4.2. We can get the version from the mount options, see 
https://gerrit.ovirt.org/63636, for info on getting the mount options.

There is no NFStorageDomainManifest yet, but it should be easy to add, we need 
to override only one method or even class attribute, and define:

class NfsStorageDomain(fileSD.FileStorageDomain):
manifestClass = NFSDomainManifest

Note that gluster storage domain inherits from nfs, so you need to override 
this back to False in this class - unless gluster supports sparsifying. I don't 
think it does since fuse does not support it, but gluster guys know better.

We can then validate the storage domain when creating a job and fail the 
operation with SparifyNotSupported error.

See the comments for some minor improvements.

I think we can merge this patch as is and add the validation in the next 
patch(s).

https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 64: :param vol_path: path to the volume
Line 65: """
Line 66: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 67: 
Line 68: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
Please add documentation why this is needed, I know Richard is against using 
this flag.
Line 69: 
Line 70: if rc != 0:


https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/storage/sdm/api/sparsify_volume.py:

Line 22: 
Line 23: from vdsm import virtsparsify
Line 24: from vdsm.storage import guarded
Line 25: 
Line 26: from .copy_data import CopyDataDivEndpoint
Importing from another verb is ugly. Since CopyDataDivEndpoint is reusable, it 
should move out of copy_data.py to a shared module in the sdm package, and it 
should be renamed since it is not related to copying data.

Maybe sdm/endpoints.DIVEndpoint?

Lets discuss this with Adam before we move stuff.
Line 27: 
Line 28: from . import base
Line 29: 
Line 30: 


Line 27: 
Line 28: from . import base
Line 29: 
Line 30: 
Line 31: class Job(base.Job):
Please keep empty line after the class declaration.
Line 32: def __init__(self, job_id, host_id, vol_info):
Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
Line 35: 


Line 30: 
Line 31: class Job(base.Job):
Line 32: def __init__(self, job_id, host_id, vol_info):
Line 33: super(Job, self).__init__(job_id, 'sparsify_volume', host_id)
Line 34: self._vol_info = CopyDataDivEndpoint(vol_info, host_id, True)
True is not clear, better use writable=True - see copy_data.Job.__init__.
Line 35: 
Line 36: def _run(self):
Line 37: with guarded.context(self._vol_info.locks):
Line 38: with self._vol_info.prepare():


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[ahino]

Ala Hino has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Verified+1

Verified following scenario on two different VMs - one running on SPM and other 
in HSM:
1. create a VM
2. add 1gb disk
3. create a snapshot
4. extend the disk by 1gb
5. run the VM
6. remove the snapshot

On both VMs, removing the snapshot successfully completed.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running 
tests"
..


Patch Set 2:

ping

-- 
To view, visit https://gerrit.ovirt.org/64035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: shorten py3 blacklist
..


Patch Set 3: Verified+1

tests still pass, on py3 as well

-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Introduce the thinp module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Introduce the thinp module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb627cc5a355f531502f9179e6a3863f4f98202
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> I don't see any use for leaving the warning here that way. the all idea was
This will show warnings if you run python with warnings enabled.

See https://docs.python.org/2/using/cmdline.html#cmdoption-W


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
> I really don't understand your expectation. I suggest to keep it and focus 
master is 4.1 - logging warnings to a secret logger the user does not know 
about is rude, you should not do this.

We don't control the other programs using vdscli - for example, user programs. 
We cannot spam this programs with warnings.

The warnings module was invented for this purpose - if you enable warnings, you 
get lot of useful warnings from the standard library about old apis that should 
be replaced. But warnings are disabled by defaults since nobody wants users to 
see warnings.

What you suggest, adding user facing warnings is exactly what we did with the 
schema consistency checks, and this was a complete failure. We should not go in 
this way again.
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 29:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Remove OVS bond implementation.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Remove OVS bond implementation.
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Mark integration tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Mark integration tests
..


Patch Set 6: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/55730/6//COMMIT_MSG
Commit Message:

Line 9: Mark tests that test the environment and not vdsm code as integration
Line 10: tests. This skip the tests in make check and prevent failures on travis
Line 11: and jenkins.
Line 12: 
Line 13: Integration tests should run separately in a special environment, not
can you elaborate what "special environment" means?
Line 14: during regular make check.
Line 15: 
Line 16: These tests still fail on travis:
Line 17: 


Line 20: 
Line 21: utilsTests.CommandPathTests
Line 22: testExistingNotInPaths  
FAIL
Line 23: 
Line 24: I marked these tests as @brokentest for now, will look into them later.
please separate it from the "mark integration tests" idea
Line 25: 
Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the
Line 27: docker image. This must be fixed in the image.
Line 28: 


Line 23: 
Line 24: I marked these tests as @brokentest for now, will look into them later.
Line 25: 
Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the
Line 27: docker image. This must be fixed in the image.
just add it to contrib/Dockerfile - there is no need to mention it here
Line 28: 
Line 29: Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27


-- 
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
I don't see any use for leaving the warning here that way. the all idea was to 
make it bold to the users


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
> This is wrong usage of warnings, causing user facing regression in any prog
this was supposed to be only in master and the idea was to remove the usages 
and catch them quickly - this is exactly what we have here which is good - lets 
replace the usages and remove the warning from 4.0
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
> Please remove this change from the patch, as devel logger is not good solut
I really don't understand your expectation. I suggest to keep it and focus on 
the areas that imports vdscli. for 4.0 please remove this warning at all, leave 
it only on master and we'll move forward with replacing usages. in 4.1 we will 
remove vdscli at all
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-09-18 12:08:32 +0300
Line 4: Commit: Maor Lipchuk 
Line 5: CommitDate: 2016-09-18 13:47:09 +0300
Line 6: 
Line 7: formatConverter: Adding comment for format converter class.
Add moulde docstring
Line 8: 
Line 9: Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/62212/4//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsm: drop the warnings module configuration
Line 8: 
Line 9: We don't use the warnings module anymore in Vdsm, so we
Line 10: don't need this configuration anymore and we can drop it.
This change is correct but bot because we don't use the warnings module, but 
because we don't use it for reporting inconsistency issues.

We can leave the warnings module in vdscli, but we don't need to configure 
anything for it. Application using this library may like to configure warnings 
filter to show warnings if they want to show warnings.
Line 11: 
Line 12: Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Line 13: Related-To: https://bugzilla.redhat.com/1364149
Line 14: Bug-Url: https://bugzilla.redhat.com/1369822


-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> Not in this patch, this should be backported to 4.0, only minimal changes h
In 4.0 I prefer that you will remove the warning usage in vdscli at all. 
Although, as I mentioned before, Dan requested for that
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2: Code-Review-1

This fixes vdsClient, but more work is needed in other programs importing 
vdsClient.

I think a better approach is This is not the right approach, replaced by 
https://gerrit.ovirt.org/64100

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Add caching decorator with invalidation

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: cache: Add caching decorator with invalidation
..


Patch Set 6: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
> One issue with this - vdscli is a library used outside vdsm - users of this
Please remove this change from the patch, as devel logger is not good solution 
for a library. warnings module is ok for this usage since we we issue one 
constant warning.
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Add caching decorator with invalidation

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: cache: Add caching decorator with invalidation
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/34709/6/lib/vdsm/cache.py
File lib/vdsm/cache.py:

Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
2016 - and please move this module to infra package
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

(2 comments)

Tanks for the reivew, commit message fixed in current version.

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 13: 
Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
> s/remove/removes
Done
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77


Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
> s/hare/are s/remove/removes
Done
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
> Maintainers' conflict? Dan wanted it that way exactly. I guess this warning
This is wrong usage of warnings, causing user facing regression in any program 
using. We should try hard to avoid such issue.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 13: 
Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
s/remove/removes
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77


Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
s/hare/are s/remove/removes
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Maintainers' conflict? Dan wanted it that way exactly. I guess this warning has 
a purpose and the purpose was achieved. I susgest to focus about removing the 
usages and with that also the warning will disappear
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> please sort it and rebase
Not in this patch, this should be backported to 4.0, only minimal changes here.
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsClient: Configure logging before imports
Line 8: 
Line 9: Because vdscli logs devel warning on import, we get this unwanted
Line 10: error from the logging module:
> please rebase over https://gerrit.ovirt.org/#/c/62209/ if its part of it
This is already rebased on https://gerrit.ovirt.org/#/c/62209.
Line 11: 
Line 12:No handlers could be found for logger "devel"
Line 13: 
Line 14: Configuring logging avoids this error.


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsClient: Configure logging before imports
Line 8: 
Line 9: Because vdscli logs devel warning on import, we get this unwanted
Line 10: error from the logging module:
please rebase over https://gerrit.ovirt.org/#/c/62209/ if its part of it
Line 11: 
Line 12:No handlers could be found for logger "devel"
Line 13: 
Line 14: Configuring logging avoids this error.


https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> Since imports are not sorted, we cannot add logging in the correct place.
please sort it and rebase
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-hooks: All

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1: Verified+1

Tested with vdsClient and by importing vdscli.

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 1:

* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: vdsm: Do not modify warnings filter in a library
..

vdsm: Do not modify warnings filter in a library

vdsm.vdscli was modifying warnings filter, taking control from the
application importing it. With the old code, there is no way to disable
the warnings - if the application sets a warnings filter, importing
vdscli will override the application filter.

This warnings is highly unwanted, causing user facing warnings each time
you run a vdsClient or hosted-engine command.

This patch remove the wrong filter, returning control to the application
using vdscli. Since warnings hare hidden by default, this remove the
unwanted warnings from vdsClient and hosted-engine command line tools.

Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer 
---
M lib/vdsm/vdscli.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/64100/1

diff --git a/lib/vdsm/vdscli.py b/lib/vdsm/vdscli.py
index 22e7bc8..552330c 100644
--- a/lib/vdsm/vdscli.py
+++ b/lib/vdsm/vdscli.py
@@ -136,7 +136,6 @@
 server = xmlrpclib.Server('http://%s' % hostPort, transport)
 return server
 
-warnings.simplefilter("always", category=DeprecationWarning)
 warnings.warn(
 "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use "
 "vdsm.jsonrpcvdscli", DeprecationWarning, stacklevel=2)


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 4: Code-Review+1

We still need warnings for vdscli.

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 135
Line 136
Line 137
Line 138
Line 139
This is the major issue here - the application using this library does not have
any control over warnings.


Line 142: 
Line 143: 
Line 144: _devel.warning(
Line 145: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 146: "vdsm.jsonrpcvdscli")
One issue with this - vdscli is a library used outside vdsm - users of this 
library must use logging level of ERROR, or configure the devel logger, 
otherwise they will see this warning in their logs, or worse in their stderr.

I think this change is better then what we had before, but in general we should 
avoid such warnings in library code.
Line 147: 
Line 148: 
Line 149: if __name__ == '__main__':
Line 150: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 366: # a 4.1 Data Center should be supported only with V4 storage domains.
Line 367: #
Line 368: # Version 4 should eventualy reflect support for old and new
Line 369: # qcow formats, 0.10 and 1.1.
Line 370: #
> We need a module docstring - just bellow the copyright notice.
Done
Line 371: class FormatConverter(object):
Line 372: def __init__(self, conversionTable):
Line 373: self._convTable = conversionTable
Line 374: 


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: upgrade: Support upgrade from v3 to v4.
..


upgrade: Support upgrade from v3 to v4.

Adding support for v4 upgrade.

Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Signed-off-by: Maor Lipchuk 
Reviewed-on: https://gerrit.ovirt.org/63547
Reviewed-by: Allon Mureinik 
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/constants.py.in
M vdsm/storage/blockSD.py
M vdsm/storage/imageRepository/formatConverter.py
M vdsm/storage/sd.py
4 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64098/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 366: # a 4.1 Data Center should be supported only with V4 storage domains.
Line 367: #
Line 368: # Version 4 should eventualy reflect support for old and new
Line 369: # qcow formats, 0.10 and 1.1.
Line 370: #
We need a module docstring - just bellow the copyright notice.

Please use this format:

"""
module name - short description

Few lines about this module...

Supported storage formats - don't waste time on formats 0, 2, and 3.

How format 4 is different from older formats...
"""
Line 371: class FormatConverter(object):
Line 372: def __init__(self, conversionTable):
Line 373: self._convTable = conversionTable
Line 374: 


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
Since imports are not sorted, we cannot add logging in the correct place.

We should sort the import here in another patch.
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 5:

* #1369822::Update tracker: OK
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 2:

* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
..


Patch Set 1:

* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
* Check Product::#1377069::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsClient: Configure logging before imports

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: vdsClient: Configure logging before imports
..

vdsClient: Configure logging before imports

Because vdscli logs devel warning on import, we get this unwanted
error from the logging module:

   No handlers could be found for logger "devel"

Configuring logging avoids this error.

Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer 
---
M client/vdsClient.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/64099/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index dde8b87..1f9ea52 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -29,9 +29,14 @@
 import shlex
 import socket
 import pprint as pp
+import logging
 
 from six.moves import xmlrpc_client
 
+# Must configure logging before importing vdsm modules, some modules may log
+# warnings during import.
+logging.basicConfig(level=logging.ERROR)
+
 from vdsm import utils, vdscli, constants
 from vdsm.compat import json
 


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: formatConverter: Adding comment for format converter class.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Adding comment for format converter class.

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: formatConverter: Adding comment for format converter class.
..

formatConverter: Adding comment for format converter class.

Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/64098/1

diff --git a/vdsm/storage/imageRepository/formatConverter.py 
b/vdsm/storage/imageRepository/formatConverter.py
index 6d4c319..80741a0 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -356,6 +356,18 @@
 }
 
 
+# The format converter is responsible for the storage domains'
+# version maintenancy.
+#
+# A storage domain's version reflects its meta data compatibility,
+# for example, data storage domain should be supported for version 3 and 4.
+#
+# The FormatConverter is mainly being used on upgrade process, for example
+# a 4.1 Data Center should be supported only with V4 storage domains.
+#
+# Version 4 should eventualy reflect support for old and new
+# qcow formats, 0.10 and 1.1.
+#
 class FormatConverter(object):
 def __init__(self, conversionTable):
 self._convTable = conversionTable


-- 
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spbackends: simplify over-general evaluation

[nsoffer]

Nir Soffer has restored this change.

Change subject: spbackends: simplify over-general evaluation
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/41253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I775c4a6003a03c6b65bee3abc8559a88e3eaec01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Mark integration tests

[nsoffer]

Nir Soffer has restored this change.

Change subject: tests: Mark integration tests
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdc: Rename method to make it less confusing

[nsoffer]

Nir Soffer has restored this change.

Change subject: sdc: Rename method to make it less confusing
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: HA: Make getHostLeaseStatus API public

[nsoffer]

Nir Soffer has restored this change.

Change subject: HA: Make getHostLeaseStatus API public
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/29157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I415c1fee6256bf8d4e03ee542cc58e193162e9b8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: scsi: Scan only the required domain type

[nsoffer]

Nir Soffer has restored this change.

Change subject: scsi: Scan only the required domain type
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

[nsoffer]

Nir Soffer has restored this change.

Change subject: cache: Replace utils.memoized with cache.memoized()
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I12e2f2919cf92ff7d0758d70e2ed40523d66174f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cache: Add caching decorator with invalidation

[nsoffer]

Nir Soffer has restored this change.

Change subject: cache: Add caching decorator with invalidation
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/63022/3/tests/v2vTests.py
File tests/v2vTests.py:

Line 533: vms = v2v.get_external_vms(self.xen_url, 'user',
Line 534:ProtectedPassword('password'),
Line 535:None)['vmList']
Line 536: 
Line 537: self.assertEqual(len(vms), len(VM_SPECS) - 1)
> please check that the missing VM is the one you set the disk type as block.
Done
Line 538: 
Line 539: @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
Line 540: @MonkeyPatch(v2v, '_LOG_DIR', None)
Line 541: def testSuccessfulImportOVA(self):


-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP]fencenode: split fenceNode into its own module

[danken]

Dan Kenigsberg has abandoned this change.

Change subject: [WIP]fencenode: split fenceNode into its own module
..


Abandoned

On Sun, Sep 18, 2016 at 09:32:19AM +0300, Yaniv Bronheim wrote:
> Hi Dan, please abandon this patch

-- 
To view, visit https://gerrit.ovirt.org/43597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7bd5e7246cf6da21e355849014a8fc71d5edbde6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [WIP]fencenode: split fenceNode into its own module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: [WIP]fencenode: split fenceNode into its own module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd5e7246cf6da21e355849014a8fc71d5edbde6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Consume ifcfg files that have a non vdsm standard name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/64096
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Consume ifcfg files that have a non vdsm standard name

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..

net: Consume ifcfg files that have a non vdsm standard name

VDSM assumes that the ifcfg files which represent network devices are
named in the following format: ifcfg-

If the host is set initially by Network Manager, the names of the files
do no correspond to the expected format.

This patch adjusts the ifcfg file name to the mentioned format and
erases any other ifcfg files that correspond to the same device.

This is not a NM friendly patch, it assumes that NM is not active while
setupNetworks is issued.

Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
2 files changed, 70 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/64096/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 33d2aae..6d1bfd6 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -106,6 +106,8 @@
 self.runningConfig = None
 
 def configureBridge(self, bridge, **opts):
+if not self.owned_device(bridge.name):
+self.normalize_device_filename(bridge.name)
 self.configApplier.addBridge(bridge, **opts)
 ifdown(bridge.name)
 if bridge.port:
@@ -114,12 +116,16 @@
 _ifup(bridge)
 
 def configureVlan(self, vlan, **opts):
+if not self.owned_device(vlan.name):
+self.normalize_device_filename(vlan.name)
 self.configApplier.addVlan(vlan, **opts)
 vlan.device.configure(**opts)
 self._addSourceRoute(vlan)
 _ifup(vlan)
 
 def configureBond(self, bond, **opts):
+if not self.owned_device(bond.name):
+self.normalize_device_filename(bond.name)
 self.configApplier.addBonding(bond, **opts)
 if not vlans.is_vlanned(bond.name):
 for slave in bond.slaves:
@@ -143,6 +149,9 @@
 nicsToSet = frozenset(nic.name for nic in bond.slaves)
 currentNics = frozenset(_netinfo.getNicsForBonding(bond.name))
 nicsToAdd = nicsToSet - currentNics
+
+if not self.owned_device(bond.name):
+self.normalize_device_filename(bond.name)
 
 # Create bond configuration in case it was a non ifcfg controlled bond.
 # Needed to be before slave configuration for initscripts to add slave
@@ -181,6 +190,8 @@
 'switch': 'legacy'})
 
 def configureNic(self, nic, **opts):
+if not self.owned_device(nic.name):
+self.normalize_device_filename(nic.name)
 self.configApplier.addNic(nic, **opts)
 self._addSourceRoute(nic)
 if nic.bond is None:
@@ -189,6 +200,8 @@
 _ifup(nic)
 
 def removeBridge(self, bridge):
+if not self.owned_device(bridge.name):
+self.normalize_device_filename(bridge.name)
 DynamicSourceRoute.addInterfaceTracking(bridge)
 ifdown(bridge.name)
 self._removeSourceRoute(bridge, StaticSourceRoute)
@@ -198,6 +211,8 @@
 bridge.port.remove()
 
 def removeVlan(self, vlan):
+if not self.owned_device(vlan.name):
+self.normalize_device_filename(vlan.name)
 DynamicSourceRoute.addInterfaceTracking(vlan)
 ifdown(vlan.name)
 self._removeSourceRoute(vlan, StaticSourceRoute)
@@ -219,6 +234,8 @@
 DynamicSourceRoute.addInterfaceTracking(netEnt)
 
 def removeBond(self, bonding):
+if not self.owned_device(bonding.name):
+self.normalize_device_filename(bonding.name)
 to_be_removed = self._ifaceDownAndCleanup(bonding)
 if to_be_removed:
 self.configApplier.removeBonding(bonding.name)
@@ -243,6 +260,8 @@
 ipwrapper.linkSet(bonding.name, ['mtu', str(set_mtu)])
 
 def removeNic(self, nic, remove_even_if_used=False):
+if not self.owned_device(nic.name):
+self.normalize_device_filename(nic.name)
 to_be_removed = self._ifaceDownAndCleanup(nic, remove_even_if_used)
 if to_be_removed:
 self.configApplier.removeNic(nic.name)
@@ -295,6 +314,33 @@
 else:
 return content.startswith(CONFFILE_HEADER_SIGNATURE)
 
+@staticmethod
+def normalize_device_filename(device):
+"""
+Attempts to detect a device ifcfg file and rename it to a vdsm
+supported format.
+In case of multiple ifcfg files that treat the same device, all except
+the first are deleted.
+"""
+device_files = []
+paths = glob.iglob(NET_CONF_PREF + '*')
+for ifcfg_file in paths:
+with open(ifcfg_file) as f:
+for line 

Change in vdsm[ovirt-4.0]: net: Expose owned_device method through the configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose owned_device method through the configurator
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Expose owned_device method through the configurator

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Expose owned_device method through the configurator
..

net: Expose owned_device method through the configurator

Provide means to check if a device is owned by VDSM specific driver.
In this case, by the ifcfg configurator.

It will be used by a following patch to determine if the device is being
used by the Linux switch.

Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63442
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit 8e72106a39f435471e591c465b5f49bd934868e7)
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
2 files changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/64095/1

diff --git a/lib/vdsm/network/configurators/__init__.py 
b/lib/vdsm/network/configurators/__init__.py
index 43ddec9..525f3e6 100644
--- a/lib/vdsm/network/configurators/__init__.py
+++ b/lib/vdsm/network/configurators/__init__.py
@@ -97,6 +97,10 @@
 def removeSourceRoute(self, routes, rules, device):
 raise NotImplementedError
 
+@staticmethod
+def owned_device(device):
+raise NotImplementedError
+
 def configureLibvirtNetwork(self, network, iface):
 self.configApplier.createLibvirtNetwork(network,
 isinstance(iface, Bridge),
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index ea09dc3..33d2aae 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -67,6 +67,8 @@
 NET_CONF_PREF = NET_CONF_DIR + 'ifcfg-'
 NET_LOGICALNET_CONF_BACK_DIR = NET_CONF_BACK_DIR + 'logicalnetworks/'
 
+CONFFILE_HEADER_SIGNATURE = '# Generated by VDSM version'
+
 
 def is_available():
 return True
@@ -280,11 +282,23 @@
 self._removeSourceRouteFile('rule', device)
 self._removeSourceRouteFile('route', device)
 
+@staticmethod
+def owned_device(device):
+try:
+with open(misc.NET_CONF_PREF + device) as conf:
+content = conf.read()
+except IOError as ioe:
+if ioe.errno == errno.ENOENT:
+return False
+else:
+raise
+else:
+return content.startswith(CONFFILE_HEADER_SIGNATURE)
+
 
 class ConfigWriter(object):
-CONFFILE_HEADER_BASE = '# Generated by VDSM version'
-CONFFILE_HEADER = CONFFILE_HEADER_BASE + ' %s' % \
-dsaversion.raw_version_revision
+CONFFILE_HEADER = (CONFFILE_HEADER_SIGNATURE + ' ' +
+   dsaversion.raw_version_revision)
 DELETED_HEADER = '# original file did not exist'
 
 def __init__(self, unifiedPersistence=False):


-- 
To view, visit https://gerrit.ovirt.org/64095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 12: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade from v3 to v4.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: upgrade: Support upgrade from v3 to v4.
..


Patch Set 12: -Verified

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip: tests: change testing framework to pytest
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

[igoihman]

Irit Goihman has abandoned this change.

Change subject: wip: tests: change testing framework to pytest
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Abandoned

as we agreed

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: test ovs info with southbound nic

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: test ovs info with southbound nic
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd3ab225172a0edfda9bb998c509ed3c2e318401
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org