gerrit-hooks has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Maor Lipchuk has uploaded a new change for review.
Change subject: formatConverter: Adding comment for format converter class.
..
formatConverter: Adding comment for format converter class.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 1:
(1 comment)
Nir Soffer has submitted this change and it was merged.
Change subject: upgrade: Support upgrade from v3 to v4.
..
upgrade: Support upgrade from v3 to v4.
Adding support for v4 upgrade.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 4: Code-Review+1
We still need warnings for vdscli.
--
To view, visit https://gerrit.ovirt.org/62212
To
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/63483
To
Irit Goihman has abandoned this change.
Change subject: jsonrpcvdscli: fix results of several commands
..
Abandoned
as we agreed
--
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: wip: tests: change testing framework to pytest
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/60217
To
gerrit-hooks has posted comments on this change.
Change subject: net: Expose owned_device method through the configurator
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
Edward Haas has uploaded a new change for review.
Change subject: net: Expose owned_device method through the configurator
..
net: Expose owned_device method through the configurator
Provide means to check if a device is owned
Dan Kenigsberg has abandoned this change.
Change subject: [WIP]fencenode: split fenceNode into its own module
..
Abandoned
On Sun, Sep 18, 2016 at 09:32:19AM +0300, Yaniv Bronheim wrote:
> Hi Dan, please abandon this patch
--
gerrit-hooks has posted comments on this change.
Change subject: [WIP]fencenode: split fenceNode into its own module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/43597
Shahar Havivi has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2:
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
* #1369822::Update tracker: OK
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: sos: remove jsonrpcvdscli.connect parameters
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:
Line 15: you run a
gerrit-hooks has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has restored this change.
Change subject: spbackends: simplify over-general evaluation
..
Restored
--
To view, visit https://gerrit.ovirt.org/41253
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 1:
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1: Verified+1
Tested with vdsClient and by importing vdscli.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
Rerun-hooks: All
--
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:
Line 3:
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 142:
Irit Goihman has abandoned this change.
Change subject: wip: tests: change testing framework to pytest
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: remove jsonrpcvdscli.connect parameters
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has restored this change.
Change subject: cache: Add caching decorator with invalidation
..
Restored
--
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Restored
--
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 135
Line
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: vdsm: Do not modify warnings filter in a library
..
vdsm: Do not modify warnings filter in a library
vdsm.vdscli was modifying warnings filter, taking control
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1:
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Nir Soffer has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/34709/6/lib/vdsm/cache.py
File lib/vdsm/cache.py:
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 6: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:
Line 15: you
gerrit-hooks has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Shahar Havivi has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63022/3/tests/v2vTests.py
File tests/v2vTests.py:
Line 533:
Nir Soffer has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2: Code-Review-1
This fixes vdsClient, but more work is needed in other programs importing
vdsClient.
I
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/64098
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62212/4//COMMIT_MSG
Commit Message:
Line 6:
Line 7: vdsm:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 12: -Verified
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: upgrade: Support upgrade from v3 to v4.
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit
Edward Haas has uploaded a new change for review.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
net: Consume ifcfg files that have a non vdsm standard name
VDSM assumes that the ifcfg files
Nir Soffer has restored this change.
Change subject: scsi: Scan only the required domain type
..
Restored
--
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: tests: Mark integration tests
..
Restored
--
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Nir Soffer has restored this change.
Change subject: sdc: Rename method to make it less confusing
..
Restored
--
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: HA: Make getHostLeaseStatus API public
..
Restored
--
To view, visit https://gerrit.ovirt.org/29157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has uploaded a new change for review.
Change subject: vdsClient: Configure logging before imports
..
vdsClient: Configure logging before imports
Because vdscli logs devel warning on import, we get this unwanted
error
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 1:
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Adding comment for format converter class.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: Configure logging before imports
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:
Line
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 1:
(2 comments)
Tanks for the reivew, commit message fixed in current version.
gerrit-hooks has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
* #1377069::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377069::OK, public bug
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Mark integration tests
..
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/55730/6//COMMIT_MSG
Commit Message:
Line 9: Mark tests
Nir Soffer has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 142:
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: Introduce the thinp module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
Rerun-hooks: all
--
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Verified+1
tests still pass, on py3 as well
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Patch Set 2:
ping
--
To view, visit https://gerrit.ovirt.org/64035
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: Verified+1
Verified following scenario on two different VMs - one running on SPM and other
in HSM:
Edward Haas has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63999
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: formatConverter: Add module doc string for format converter
class.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64098/4//COMMIT_MSG
Commit Message:
gerrit-hooks has posted comments on this change.
Change subject: formatConverter: Add module doc string for format converter
class.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
Yaniv, what sparsify-inplace is doing is basically adding your disk to a
special minimal vm, and
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
1. I was under the impression it can sparsify all the way down to the parent
(so if there are snaps,
gerrit-hooks has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has uploaded a new change for review.
Change subject: log: Nicer logging format
..
log: Nicer logging format
Use nicer and more standard logging format, similar to engine log
format. Having similar logging formats
Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63682/3/vdsm/vdsm-remove-logs
File
Nir Soffer has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 2: Verified+1
Tested on rhel 7.3 beta.
--
To view, visit https://gerrit.ovirt.org/64111
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(4 comments)
Great work Shmuel!
The only thing missing is blocking this for volumes that do not
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
Can you rebase on master?
--
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: vm: Remove unneeded fallback to blockRebase
..
vm: Remove unneeded fallback to blockRebase
If blockCopy was not supported, we fallback to blockRebase. This was
gerrit-hooks has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 1: Code-Review+1
Seems pretty straight forward, and it doesn't seem like you've left anything
over.
gerrit-hooks has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
94 matches
Mail list logo