Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 1:11 PM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 10:24 AM, Geoffrey Garen > > wrote: >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >>> > wrote: Can you explain more about what "O3 with

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 10:24 AM, Geoffrey Garen написал(а): > >>> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >> > wrote: >>> >>> Can you explain more about what "O3 with no-inlining” is? How does >>> --force-opt=O3 avoid inlining? Would this fully resolve Simon

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 9:59 AM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov > <mailto:a...@webkit.org>> wrote: >> >> >> >>> 18 июня 2020 г., в 9:30 PM, Saam Barati >> <mailto:sbar...@apple.

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 18 июня 2020 г., в 9:30 PM, Saam Barati написал(а): > > Why are we insisting on doing something on the bots that takes ~10x longer to > run than necessary? I’d rather have that time spent running more tests. Replying to this point specifically, I wanted to point out that WebKit tests take

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Alexey Proskuryakov
I frequently find it critically useful to see stack traces from debug builds, because of no inlining. So I don't think that we should do this. A local build does not help when the issue is not readily reproducible. - Alexey > 17 июня 2020 г., в 1:36 PM, Mark Lam написал(а): > > Hi folks, >

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Alexey Proskuryakov
I see substantial appeal in having a separate data file, however I'm not sure if it can inform IDE parsing and syntax highlighting for code enabled/disabled at compile time. Header files seem like they would get that right more often. - Alexey > 10 мая 2020 г., в 10:07 PM, Maciej Stachowiak

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Alexey Proskuryakov
The license is not BSD or LGPL, so that's one aspect to consider. Why exactly are distros unwilling to update ICU? - Alexey > 9 апр. 2020 г., в 10:32 AM, Michael Catanzaro > написал(а): > > > Any objections to uploading a bundled ICU 60 under Source/ThirdParty? > > Seems easier than

[webkit-dev] Checking out WebKit source code when using Xcode 11.4

2020-03-24 Thread Alexey Proskuryakov
Hello everyone, Xcode 11.4 was released today, and it does not include svn or git-svn any more. We have posted a standalone installer at to keep getting tools needed for WebKit development easy. - Alexey ___

Re: [webkit-dev] Terminology: Could we change 'roll out' to 'roll back'?

2020-03-06 Thread Alexey Proskuryakov
> 6 марта 2020 г., в 18:29, Ryosuke Niwa написал(а): > > On Fri, Mar 6, 2020 at 6:15 PM Kirsling, Ross wrote: >> >> Late on Friday seems like a good time for a terminological debate (), so I’d >> like to propose we revisit one of the strangest items of WebKit-specific >> terminology: the

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Alexey Proskuryakov
> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): > > Does anyone oppose clearing all review requests that are older than 6 months? > (or 1 year?) Looking at ancient patches in the review queue, quite a few look like they should still work (e.g. adding new tests). So said that we are not

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-05 Thread Alexey Proskuryakov
10 more test failures on two retries (combined) than in a clean run seems reasonable. - Alexey > Thanks > Aakash > >> On Dec 3, 2019, at 12:28 PM, Alexey Proskuryakov > <mailto:a...@webkit.org>> wrote: >> >> >> Yes, I think that this makes more sense

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-03 Thread Alexey Proskuryakov
Yes, I think that this makes more sense than retrying. What is the current behavior when a patch introduces substantial flakiness? E.g. this scenario: - First test run produces 5 failures. - Second test run produces 5 different failures. - Clean re-run produces no failures. This looks like

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-11 Thread Alexey Proskuryakov
> 10 нояб. 2019 г., в 1:16 AM, Noam Rosenthal написал(а): > > Hola > > I would like to open a discussion that has started a few years back and has > never reached a consensus: https://bugs.webkit.org/show_bug.cgi?id=145380 > > > In a

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-05 Thread Alexey Proskuryakov
> 4 нояб. 2019 г., в 1:37 PM, Ryosuke Niwa написал(а): > > > On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov <mailto:a...@webkit.org>> wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure useful > to reviewers? > > Gett

Re: [webkit-dev] iOS EWS behind by 3 days??

2019-11-05 Thread Alexey Proskuryakov
> 4 нояб. 2019 г., в 11:30 PM, Ryosuke Niwa написал(а): > > Hi all, > > Does anyone know what's happening with iOS EWS? Not yet, but it's part of a cluster of problems related to interactions between simulator and specific macOS host versions. https://bugs.webkit.org/show_bug.cgi?id=203792

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Alexey Proskuryakov
s not something anyone can Cc themselves on, and is not > archived, so seems like a strictly worse form of communication. > >> On Nov 2, 2019, at 9:34 AM, Alexey Proskuryakov wrote: >> >> >> My preference is still e-mailing the patch author directly (possibly, a

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-02 Thread Alexey Proskuryakov
My preference is still e-mailing the patch author directly (possibly, also having an option to opt in for anyone). Bugzilla comments will always be irrelevant for most people CC'ed on the bug, and they are almost always undesirable to keep within the discussion flow. - Alexey > 1 нояб. 2019

Re: [webkit-dev] 2019 WebKit Contributors Meeting - Hurry! Registration is Closing!

2019-10-25 Thread Alexey Proskuryakov
Seems like an issue to look into. However this should not prevent you from registering, because you do have a Trac account (it's the same thing as your svn account). - Alexey > 25 окт. 2019 г., в 8:07 AM, Geoffrey Garen написал(а): > > The Login page looks like this: > > > > If you

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Alexey Proskuryakov
> 15 июля 2019 г., в 23:04, Fujii Hironori > написал(а): > > > On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa > wrote: > > I don’t think anyone is arguing that we’d eventually need to move to Python3. > I’m arguing that it’s not okay to require random WebKit

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Alexey Proskuryakov
> 10 мая 2019 г., в 13:50, Darin Adler написал(а): > >> On May 10, 2019, at 1:13 PM, Keith Miller wrote: >> >> I’m not sure I know what you mean by allow a whole-directory exception. Do >> you mean a top level directory? Or some kind of parameter we pass to the >> hook to ignore some

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Alexey Proskuryakov
I posted a tool that I used for this today to https://bugs.webkit.org/show_bug.cgi?id=197537. Probably a lot to improve, but it works. - Alexey > 2 мая 2019 г., в 14:32, Darin Adler написал(а): > > Should we post instructions somewhere for people dealing with spam? I believe > the

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Alexey Proskuryakov
One change that I'm going to make is to mark spam comments as private instead of simply tagging. That way, bugs will look cleaner, and there will be no doubt about whether search engines index hidden comments or not. I'll also mark old spam comments as private. I think that this will generate

Re: [webkit-dev] Spam and indexing

2019-03-29 Thread Alexey Proskuryakov
> 28 марта 2019 г., в 14:10, Konstantin Tokarev написал(а): > > > > 28.03.2019, 23:58, "Alexey Proskuryakov" : >> Hello, >> >> The robots.txt file that we have on bugs.webkit.org currently allows search >> engines access to individual bug

[webkit-dev] Spam and indexing

2019-03-28 Thread Alexey Proskuryakov
Hello, The robots.txt file that we have on bugs.webkit.org currently allows search engines access to individual bug pages, but not to any bug lists. As a result, search engines and the Internet Archive only index bugs that were filed before robots.txt changes a few years ago, and bugs that are

[webkit-dev] WebCorePrefix.h vs. config.h

2018-12-07 Thread Alexey Proskuryakov
Hi, Do we still need separate WebCorePrefix.h and config.h? The former has this comment, which I don't think is true any more: /* This prefix file should contain only: *1) files to precompile for faster builds *2) in one case at least: OS-X-specific performance bug workarounds *

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 16:45, Ryosuke Niwa написал(а): > > Alternatively, is there a way you can make more of us be able to moderate > these spammers? Anyone can tag comments to make them invisible, but there is no privilege level in Bugzilla where one can disable user accounts, but cannot

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 16:43, Ryosuke Niwa написал(а): > > > On Tue, Dec 4, 2018 at 12:55 PM Jonathan Bedard > wrote: > These directories would be along-side tests. > > I don't like that platform-specific results are under LayoutTests/platform > and device-specific

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 11:21, Ryosuke Niwa написал(а): > > e.g. > https://bugs.webkit.org/show_bug.cgi?id=168774 > > > Is there a way we can integrate CAPTCHA, etc... to prevent these spammers > from getting Bugzilla account? We can integrate

Re: [webkit-dev] Design for review: EWS for security bugs

2018-06-20 Thread Alexey Proskuryakov
> 16 июня 2018 г., в 0:12, Daniel Bates написал(а): > > Hi all, > > I am working to support EWS processing of patches on security bugs (see > >) and I am writing to this > list to solicit

Re: [webkit-dev] Trying to builder older version of webkit (but failing) - looking for help

2018-05-22 Thread Alexey Proskuryakov
Hello Ted, 603.1.30 is the version included with Safari 10.1 on Sierra, so yes, building it against High Sierra SDK with newer Xcode puts you on uncharted territory. The file that you are hitting an issue with is one of the first files in WebCore to build, so chances are that there will be

Re: [webkit-dev] Request for upgrading xcode toolchains in Apple bots for C++17

2018-05-21 Thread Alexey Proskuryakov
Hi, To clarify, are you asking specifically for mac-32bit EWS to be upgraded? It has Xcode 9.2, and can be upgraded to 9.3.1 (that will be a multi-step process, as we need to keep the version in sync with several other setups). But macOS Sierra bots have Xcode 8.3.3, and that is the latest

Re: [webkit-dev] Test262 includes some tab characters

2018-02-04 Thread Alexey Proskuryakov
> 4 февр. 2018 г., в 7:09, Yusuke SUZUKI написал(а): > > Hi WebKittens, > > Recently, I updated test262, and I found newly added test262 files include > TAB characters (\t). > IIRC, I need some help to import such files into WebKit tree. > Can we make JSTests/test262

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Alexey Proskuryakov
he copying, but trying to make a legitimate story for why any extra work is needed. - Alexey > Anything not on *.webkit.org <http://webkit.org/> or similar, or anything not > on on S2 buckets that are owned by Apple directly, does not fit that policy. > > On T

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Alexey Proskuryakov
> 12 дек. 2017 г., в 1:34, Mathias Bynens написал(а): > > It would be great to make such downloads available from webkit.org > or > a similar domain! Can you explain in more detail why this is important? If there is an expectation that this will make

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-28 Thread Alexey Proskuryakov
> 17 нояб. 2017 г., в 23:02, youenn fablet написал(а): > > Tests are available at https://w3c-test.org which > makes it easy to share through any tool supporting hyperlinks. > A webarchive can also be made so that it is easy to share and probably edit

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Alexey Proskuryakov
(re-sending from a correct address) > 17 нояб. 2017 г., в 9:18, youenn fablet > написал(а): > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. > This is now fixed and should improve

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-16 Thread Alexey Proskuryakov
Migrating WebKit tests seems undesirable to me, as that would make us lose all their modification history. As mentioned before, WPT tests are inherently getting less attention in CI support, largely because of unclear benefit when there isn't any history for why the particular test was added.

Re: [webkit-dev] Dead code in webkitpy runtests.py

2017-11-01 Thread Alexey Proskuryakov
I think that we would still like to have a unified way to run tests. Right now, even knowing whether a particular script or build step is covered by tests is not straightforward. At the same time, I think that the tiny subset of tests that webkit-patch used to run wasn't meaningful.

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 26 окт. 2017 г., в 9:50, Brian Burg написал(а): > > why differ from the vast majority of all other Python code in existence, just > to be different? What's the point? My point is that people familiar with all other Python code in existence will not be hacking on

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 25 окт. 2017 г., в 18:21, Michael Catanzaro > написал(а): > > On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain wrote: >> Does anyone else has any opinion/preference for this? > > The number of spaces before a comment really does not matter, but my

Re: [webkit-dev] SVN server broken?

2017-09-08 Thread Alexey Proskuryakov
Is anyone still seeing issues? I see a number of patches landed overnight, including by commit queue. One problem I do see is that trac is stale. - Alexey > 8 сент. 2017 г., в 3:19, Carlos Alberto Lopez Perez > написал(а): > > On 08/09/17 11:56, Carlos Alberto Lopez

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Alexey Proskuryakov
> 30 авг. 2017 г., в 11:55, Andy Estes написал(а): > In a completely other direction, what does this mean for use of Xcode? Can we still build from Xcode? Debug? >>> >>> CMake can generate Xcode files, so you can still develop and debug in Xcode. >> >> This

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 16:12, Sam Weinig <wei...@apple.com> написал(а): > > > >> On May 12, 2017, at 2:49 PM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@webkit.org>> wrote: >> >> >>> 12 мая 2017 г., в 14:38, Sam Wei

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 14:39, Ryosuke Niwa написал(а): > > This is absolutely not how I operate at all. Since almost all custom > elements and shadow DOM API tests I wrote are written using > testharness.js and upstreamed to web-platform-tests, they have been > deleted from

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 14:38, Sam Weinig написал(а): > > I regret piling on here, as I think this thread has diverged from it’s > original purpose, but…I understand this frustration. That said, perhaps this > is something we can solve with some tooling. For instance, a >

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 11:52, Ben Kelly <b...@wanderview.com> написал(а): > > On Fri, May 12, 2017 at 2:26 PM, Rick Byers <rby...@chromium.org > <mailto:rby...@chromium.org>> wrote: > On Fri, May 12, 2017 at 2:06 PM, Alexey Proskuryakov <a...@webkit.org > &

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 9 мая 2017 г., в 11:27, Simon Fraser написал(а): > > Another consideration here is "would my test be useful for other browser > vendors". I don't think the answer is a unanimous "yes", so I think we should > only use WPT for tests that will think are worth sharing.

Re: [webkit-dev] Commits in branches triggering build in the bots now

2017-05-04 Thread Alexey Proskuryakov
Hi Carlos, Could you please file a bug, and include the relevant links to investigate the issue? - Alexey > 4 мая 2017 г., в 0:46, Carlos Garcia Campos написал(а): > > I don't know what have changed, but now, commits in other branches are > triggering builds in the

[webkit-dev] Aakash Jain is now a WebKit Reviewer

2017-04-02 Thread Alexey Proskuryakov
Hi everyone, I would like to announce that Aakash Jain is now a WebKit reviewer. Aakash works on WebKit tools and infrastructure. Please join me in congratulating Aakash, and send him some patches to review! - Alexey ___ webkit-dev mailing list

Re: [webkit-dev] Unable to log in to bugs.webkit.org

2017-04-01 Thread Alexey Proskuryakov
Done. If anyone else hits this, please e-mail ad...@webkit.org . Resetting the password did work for other people, so clearly there is some flakiness to diagnose. - Alexey > 1 апр. 2017 г., в 10:24, Dan Bernstein написал(а): > > Can someone help me

[webkit-dev] Bugzilla 5.0.3 password strength requirements

2017-03-21 Thread Alexey Proskuryakov
Hi, Our updated Bugzilla installation now has password strength check enabled. It will refuse logging in with a weak password. One specific tool that is affected is webkit-patch, which logs in every time. If it's giving you strange errors like the below, please try logging out from Bugzilla

[webkit-dev] DEFERRED: Scheduled Outage: WebKit Bugzilla (bugs.webkit.org) March 13th, 2017 from 9AM PDT to Noon PDT

2017-03-11 Thread Alexey Proskuryakov
Hi, The upgrade was deferred to a later date. There will be svn.webkit.org maintenance with some downtime on Monday afternoon. The exact time will be announced on Monday. - Alexey > 8 марта 2017 г., в 11:49, Ling Ho

Re: [webkit-dev] Can I get the editbugs-bit?

2017-03-01 Thread Alexey Proskuryakov
Done. - Alexey > 1 марта 2017 г., в 17:15, Suzuki, Basuke > написал(а): > > Hi > > My name is Basuke Suzuki, working at SONY Interactive Entertainment, a.k.a > PlayStation, > working with Don Olmstead and Hironori Fujii > > I want to ask to assign the

Re: [webkit-dev] SVN trouble

2017-02-26 Thread Alexey Proskuryakov
On Feb 25, 2017, at 8:40 AM, Simon Fraser <simon.fra...@apple.com > <mailto:simon.fra...@apple.com>> wrote: > >> EWS is still down. Do we have an ETA? >> >> Simon >> >>> On Feb 24, 2017, at 10:25 PM, Alexey Proskuryakov <a...@webkit.org >

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 19:50, Chris Dumez <cdu...@apple.com> написал(а): > > > > >> On Feb 24, 2017, at 11:41 AM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@webkit.org>> wrote: >> >> I believe that all infrastructure has r

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
gt; On 24/02/17 20:16, Alexey Proskuryakov wrote: >> >> How does one create a local git-svn checkout to try this out? Given that >> the offending file has been effectively deleted from svn, I think that >> git-svn should work too. > > You have the scri

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 9:31, Carlos Alberto Lopez Perez <clo...@igalia.com> > написал(а): > > On 24/02/17 18:08, Alexey Proskuryakov wrote: >> works. There is almost certainly more cleanup that needs to be done - I >> can see that trac.webkit.org <http://trac.we

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 7:48, Antti Koivisto написал(а): > > Hi, > > Looks like https://bugs.webkit.org/show_bug.cgi?id=168774 > caused some sort of SVN > problem. Please hold commits until this is resolved. I deleted the

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Alexey Proskuryakov
> 6 февр. 2017 г., в 12:28, Ryosuke Niwa написал(а): > > The concern I've heard about is not how run-webkit-tests run the tests. It's > about how a test is opened inside a browser, DRT, WTR while debugging. +1 I think that making web platform tests more practical for

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Alexey Proskuryakov
There are two considerations which make me skeptical that auto is a good thing. 1. There are many smart pointer types in C++, and ignoring pointer types is very error prone. Others have mentioned std::optional, and mistakes being made with RefPtrs. I even saw a case where a review comment that

Re: [webkit-dev] Asserting versus throwing in internals and testRunner objects

2016-09-23 Thread Alexey Proskuryakov
Note that we are talking about API misuse here, so associating the crash with a test is not really needed - it's the test that you are writing. I've seen tests getting checked in even when they don't run to completion and raise JS exceptions. I want it to be very clear and obvious when a test

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 22:34, Darin Adler <da...@apple.com> написал(а): > >> On Jul 22, 2016, at 10:25 PM, Alexey Proskuryakov <a...@webkit.org> wrote: >> >> Simon and I were trying to move all tests out of platform/ directories. > > Is this nearly done

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 21:57, Darin Adler написал(а): > >> What is the right way to deal with tests like these? > > I think we should move the tests into platform/mac. Simon and I were trying to move all tests out of platform/ directories. When the expected results are

Re: [webkit-dev] ./Tools/Scripts/run-safari doesn't work with Safari 10

2016-07-18 Thread Alexey Proskuryakov
Hello Marco, > 18 июля 2016 г., в 13:02, Marco Barisione > написал(а): > > Hello, > > I recently installed Safari 10 on some machines running 10.11.6 DP. > Unfortunately, I cannot get Safari 10 to work with WebKit compiled from SVN. > > I tried with both SVN

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Alexey Proskuryakov
Hi, I do not think that there is a way to algorithmically define what an acceptable difference is. Here are a few cases where it's critical to detect small differences: - color management, e.g. testing different code paths that should match precisely; - finding uninitialized memory use bugs

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Alexey Proskuryakov
> 18 нояб. 2015 г., в 11:50, Simon Fraser написал(а): > > There are some well-understood reasons why a test might not exactly match its > reference. One is that the test uses compositing layers to do clipping, but > the reference just clips with drawing, and these are

Re: [webkit-dev]

2015-11-17 Thread Alexey Proskuryakov
Hello Yoav, Is there any technology on the horizon that would simplify doing this kind of optimization? If done manually, this seems: - complicated, so only a few sites will do this; - very likely to go stale, as the content changes, but preload instructions do not get updated; - related to the

Re: [webkit-dev] Windows EWS not working?

2015-11-07 Thread Alexey Proskuryakov
(re-sending from the right e-mail address for the list) > 7 нояб. 2015 г., в 16:56, Darin Adler написал(а): > > I was looking at the patch in this bug: > > https://bugs.webkit.org/show_bug.cgi?id=150967 > > The patch was posted 20 hours ago. EWS has processed this for all

Re: [webkit-dev] Mac EWS Updates!

2015-10-21 Thread Alexey Proskuryakov
Normally, we try to configure EWS with OS versions that most engineers no longer use on their machines, to maximize the chances of catching problems that one can't catch locally. It would certainly be ideal to cover the full spectrum, as many contributors don't have Macs at all. - Alexey >

Re: [webkit-dev] Bugzilla default assignees

2015-09-14 Thread Alexey Proskuryakov
Yet another approach used by the Accessibility component is to have a technical account auto-CC'ed, and then anyone interested can follow this account. This seems like the most reliable solution to me. - Alexey 14 сент. 2015 г., в 9:26, Brian Burg написал(а): > It should

Re: [webkit-dev] Commit queue issues

2015-09-02 Thread Alexey Proskuryakov
02 сент. 2015 г., в 5:41, Philippe Normand написал(а): > It seems the commit queue cannot land patches? > > https://bugs.webkit.org/show_bug.cgi?id=148702 This should be resolved now. I see that you already marked this patch for cq+ again; I'll see if any others are stuck.

Re: [webkit-dev] Commit queue issues

2015-09-02 Thread Alexey Proskuryakov
> 2 сент. 2015 г., в 9:59, Alexey Proskuryakov <a...@webkit.org> написал(а): > > > 02 сент. 2015 г., в 5:41, Philippe Normand <ph...@igalia.com> написал(а): > >> It seems the commit queue cannot land patches? >> >> https://bugs.webkit.org/show_b

Re: [webkit-dev] Switching servers for EWS and flakiness dashboard [Caution: Message contains Suspicious URL content]

2015-07-31 Thread Alexey Proskuryakov
I tried running the style queue from command line, and it processed some patches, errored out on some others, and then hit a different error. I restarted the queue normally then, and it has processed all patches except for https://bugs.webkit.org/attachment.cgi?id=257920action=prettypatch. We

Re: [webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

2015-04-24 Thread Alexey Proskuryakov
24 апр. 2015 г., в 9:06, Brady Eidson beid...@apple.com написал(а): Killing the feature would lead to a confusing experience for such users. Additionally, I think that outright killing multipart main resources would cause unnecessarily confusing experience for WebKit developers. One of the

Re: [webkit-dev] Running W3C tests using wptserve

2015-02-01 Thread Alexey Proskuryakov
correctly. Is it possible to get access to the corresponding WebKitBuild/Release/layout-test-results, in particular wptwk_process_log.out.txt? Also, does it happen on all bots or only windows bot? 2015-02-01 4:41 GMT+01:00 Alexey Proskuryakov a...@webkit.org: 31 янв. 2015 г., в 11:57

Re: [webkit-dev] Running W3C tests using wptserve

2015-01-31 Thread Alexey Proskuryakov
31 янв. 2015 г., в 11:57, youenn fablet youe...@gmail.com написал(а): Currently, only two tests are run within that folder: - web-platform-tests/domparsing/DOMParser-parseFromString-html.html - web-platform-tests/domparsing/insert-adjacent.html Should there be any issus with those tests,

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-23 Thread Alexey Proskuryakov
23 янв. 2015 г., в 10:01, Ryosuke Niwa rn...@webkit.org написал(а): We could add a new test expectation like ImageDiff to suppress these or we could expose a new internals or testRunner methods to mark a test as such. Good idea! An ImageHashMismatch expectation seems like a reasonable way to

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-22 Thread Alexey Proskuryakov
22 янв. 2015 г., в 11:30, Simon Fraser simon.fra...@apple.com написал(а): This happens when the expected and actual images are very close, but not identical. ImageDiff has some built-in rounding that effectively acts as a small tolerance, so the hashes are different, but ImageDiff

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-22 Thread Alexey Proskuryakov
22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а): What about the test I cited? svg/css/svg-resource-fragment-identifier-img-src.html This particular test is buggy - it is a hidpi test, so it dumps results as a 1600x1200 image, but its -expected.html is not hidpi, and is

Re: [webkit-dev] review times

2014-12-03 Thread Alexey Proskuryakov
03 дек. 2014 г., в 2:32, Daniel Lazarenko dani...@opera.com написал(а): Whatsoever it would be nice find a new reviewer for my patch. Does anybody want to take it? Just to be clear about this part, the reviewer should not be just anybody. This patch is part of an effort to implement a new

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-30 Thread Alexey Proskuryakov
24 нояб. 2014 г., в 1:28, Antti Koivisto koivi...@iki.fi написал(а): I don't think this is really 32bit vs 64bit platform issue. The vast majority of 64bit systems our users have (that is iOS devices) can't use memory buffers sized anywhere near the 32bit limit even in theory. Also when

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-20 Thread Alexey Proskuryakov
19 нояб. 2014 г., в 14:58, Alexey Proskuryakov a...@webkit.org написал(а): These and related uses are all over the place - see also Vectors in FormDataBuilder, data returned from FrameLoader::loadResourceSynchronously, plug-in code that loads from network, SharedBuffer etc. Another way

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-20 Thread Alexey Proskuryakov
20 нояб. 2014 г., в 10:45, Filip Pizlo fpi...@apple.com написал(а): - uint64_t everywhere. This way, we'll solve practical problems with large resources once and for all. Also, this may prove to be necessary to solve even YouTube/Google Drive uploads, I do not know that yet. How does

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Alexey Proskuryakov
This is not exactly about Vector, but if one uses FileReader.prototype.readAsArrayBuffer() on a large file, I think that it overflows ArrayBuffer. WebKit actually crashes when uploading multi-gigabyte files to YouTube, Google Drive and other similar services, although I haven't checked

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Alexey Proskuryakov
be a primitive type but a class that carefully checked that you never overflowed 53 bits. -Filip On Nov 19, 2014, at 12:54 PM, Alexey Proskuryakov a...@webkit.org wrote: This is not exactly about Vector, but if one uses FileReader.prototype.readAsArrayBuffer() on a large file, I think

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Alexey Proskuryakov
19 нояб. 2014 г., в 13:58, Filip Pizlo fpi...@apple.com написал(а): With Vector though, I don't know how we would differentiate code paths that need large allocations from ones that don't. Nearly anything that is exposed as a JS API or deals with external world can hit sizes over 4Gb.

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

2014-10-24 Thread Alexey Proskuryakov
The bug got actually created despite the error, https://bugs.webkit.org/show_bug.cgi?id=138043. - Alexey 24 окт. 2014 г., в 3:54, Philippe Normand ph...@igalia.com написал(а): Hi! I'm using the XML-RPC API (via git-bz) and when attaching a patch to a bug I get the following error:

Re: [webkit-dev] New EWS status bubbles in Bugzilla

2014-09-30 Thread Alexey Proskuryakov
29 сент. 2014 г., в 23:12, Carlos Garcia Campos carlo...@webkit.org написал(а): Please try it out, and let me know if something breaks, or is not as good as it could be! Looks great! thanks. I've noticed that now we use red also for patches that don't apply. I liked that there was a

Re: [webkit-dev] New EWS status bubbles in Bugzilla

2014-09-30 Thread Alexey Proskuryakov
On 30 сент. 2014 г., at 0:56, Carlos Garcia Campos carlo...@webkit.org wrote: Thinking about this now, we could replace bubbles with text when no queue has results (i.e. at least one queue has failed to apply, and those that didn't still haven't started processing - we can reasonably expect

[webkit-dev] New EWS status bubbles in Bugzilla

2014-09-29 Thread Alexey Proskuryakov
Hi, WebKit Bugzilla has new EWS status bubbles now, which will hopefully make it more clear what's going on with a patch. Mysterious yellow bubbles that could mean anything were eliminated, and most importantly, there is now detailed information presented on hover: Please try it out, and

[webkit-dev] Fooling with EWS and commit queue

2014-09-25 Thread Alexey Proskuryakov
Hi, I started making changes to the logic of EWS and commit queue, please e-mail me if something breaks, or even if something begins to behave more strangely than it did before. - Alexey ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] DOMWindow::isCurrentlyDisplayedInFrame does not forbid PostMessageTimer for subframe

2014-09-04 Thread Alexey Proskuryakov
Hi! Could you please file a bug at bugs.webkit.org? If you have a reproducible test case where any bad behavior happens, that would be most useful. I think that the proposed fix would break a case where we currently match Firefox: main.html: - button

[webkit-dev] WebKit Dashboard metrics

2014-09-02 Thread Alexey Proskuryakov
Hi, You may have noticed some patches for WebKit Dashboard metrics page landed recently. The page is now live at http://build.webkit.org/dashboard/metrics.html. It's a tool that collects historical information from Buildbot and answers these questions: - How much of the time did trunk build

Re: [webkit-dev] WebKit2 EWS bots are sick

2014-08-25 Thread Alexey Proskuryakov
25 авг. 2014 г., в 1:54, Benjamin Poulain benja...@webkit.org написал(а): It looks like the WebKit2 EWS bots are having a bad time. They keep timing out on a bunch of tests. Can anyone restart them? The bots restart themselves frequently. Looks like there must be a real problem that makes

Re: [webkit-dev] Mac WK2 EWS bots having issues

2014-08-01 Thread Alexey Proskuryakov
30 июля 2014 г., в 11:17, Alexey Proskuryakov a...@webkit.org написал(а): https://bugs.webkit.org/show_bug.cgi?id=135418 media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions

Re: [webkit-dev] Mac WK2 EWS bots having issues

2014-07-30 Thread Alexey Proskuryakov
30 июля 2014 г., в 3:16, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): If there is no volunteer for fixing it in the near future, I'm going to propose a patch making the Mac WK2 EWS not comment bugzilla and set cq- for random patches. I've been already looking into this, and fixed some

Re: [webkit-dev] Mac WK2 EWS bots having issues

2014-07-30 Thread Alexey Proskuryakov
30 июля 2014 г., в 3:16, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): You can check the SPAM history with this bugzilla query: http://goo.gl/qepg2l (30 days history) Thank you for posting this. What's interesting is that right now, the latest result is accurate, the patch actually

Re: [webkit-dev] Mixed content checking

2014-07-24 Thread Alexey Proskuryakov
23 июля 2014 г., в 17:08, Michael Catanzaro mcatanz...@igalia.com написал(а): One problem with these settings is that frames are treated as mixed passive content rather than mixed active content. For the WebKitGTK+ API I want frames to be treated as active content, which is what most major

Re: [webkit-dev] Mac WK2 EWS bots having issues

2014-07-15 Thread Alexey Proskuryakov
Some of the bugs tracking the issues are https://bugs.webkit.org/show_bug.cgi?id=122475 and https://bugs.webkit.org/show_bug.cgi?id=134793. - Alexey 14 июля 2014 г., в 7:23, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): Hi, It seems the Mac WK2 EWS bots are very flakey nowadays,

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-11 Thread Alexey Proskuryakov
(re-sent from correct address) 11 июля 2014 г., в 3:59, Maciej Stachowiak m...@apple.com написал(а): So it seems like the extra request for people using “webkitbot rollout” is to add diagnostic information to the rollout bug, and wait a reasonable period before cq+ing it. Is that something

  1   2   3   4   5   >