Re: [webkit-dev] jsc bus error EXC_BAD_ACCESS with jsc-only build on Mac

2024-04-22 Thread Alexey Proskuryakov via webkit-dev
+ Keith for visibility 16 апр. 2024 г., в 3:01 PM, Steve Glass via webkit-dev написал(а): Hi, Hi, I’m trying to build jsc on my M1 Mac following the instructions at https://trac.webkit.org/wiki/JSCOnly and https://webkit.org/getting-started/ . However when I run the built binary it exits

Re: [webkit-dev] webkit-unassigned

2023-12-18 Thread Alexey Proskuryakov via webkit-dev
> 18 дек. 2023 г., в 1:44 PM, Michael Catanzaro > написал(а): > > On Mon, Dec 18 2023 at 09:16:21 PM +00:00:00, Alexey Proskuryakov > wrote: >> Same thing - limiting the ability to trivially watch for security bugs that >> are initially filed in a wrong compon

Re: [webkit-dev] webkit-unassigned

2023-12-18 Thread Alexey Proskuryakov via webkit-dev
> 18 дек. 2023 г., в 1:11 PM, Michael Catanzaro via webkit-dev > написал(а): > > On Mon, Dec 18 2023 at 06:07:48 PM +00:00:00, Alexey Proskuryakov via > webkit-dev wrote: >> I'm still inclined to break the scenario of watching webkit-unassigned. What >> do other

Re: [webkit-dev] webkit-unassigned

2023-12-18 Thread Alexey Proskuryakov via webkit-dev
comments that you don't have access to the bug. I'd like to notice that someone commented to unassigned bugs. I don't have to check bugs assigned to a developer. On Sat, Dec 16, 2023 at 8:04 AM Alexey Proskuryakov mailto:a...@webkit.org> > wrote: My approach would be to also disable the a

Re: [webkit-dev] webkit-unassigned

2023-12-15 Thread Alexey Proskuryakov via webkit-dev
that works. - Alexey 15 дек. 2023 г., в 2:25 PM, Fujii Hironori via webkit-dev написал(а): I check it every day. Can I receive the same mails by setting my user watching to webkit-unassig...@lists.webkit.org <mailto:webkit-unassig...@lists.webkit.org> ? On Sat, Dec 16, 2023 at 7:12 AM

[webkit-dev] webkit-unassigned

2023-12-15 Thread Alexey Proskuryakov via webkit-dev
Hello, Does anybody make use of the webkit-unassigned mailing list? I'd like to disable it, to reduce exposure of spam and accidental postings. - Alexey ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2023-01-30 Thread Alexey Proskuryakov via webkit-dev
Hi, Reviving this old thread, reading it again made me wish for two things: - a wiki document that describes what we are trying to do, not just a thread which patches the proposal with clarifications; - a discussion of why we can postpone figuring out what to do with containers (like Vector

Re: [webkit-dev] Update commit log template to make GNU changelog optional

2022-12-01 Thread Alexey Proskuryakov via webkit-dev
Hi Michael, The intention of per-file or per-function comments is to have a deeper explanation of code changes, as opposed to overall explanation of what the change does at the top. Not every patch needs it, but many do. These are very helpful in my experience.     *

Re: [webkit-dev] Nicks in contributors.json

2022-10-24 Thread Alexey Proskuryakov via webkit-dev
I think that nicks are handy in a couple cases: 1. Finding people on Slack. For this, they would probably need to stay on https://webkit.org/team. 2. Bugzilla autocomplete - I type "smfr" and do not need to scroll like if I typed "Simon". This could be addressed by switching to GitHub names

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-07 Thread Alexey Proskuryakov via webkit-dev
id <https://aka.ms/AAb9ysg> -------- From: Alexey Proskuryakov via webkit-dev mailto:webkit-dev@lists.webkit.org> > Sent: Wednesday, September 7, 2022 5:05:40 PM To: Michael Catanzaro mailto:mcatanz...@gnome.org> > Cc: webkit-dev@lists.webkit.org <mailto:

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-07 Thread Alexey Proskuryakov via webkit-dev
I can't speak for everyone, but the reason why I haven't been responding was that the discussion went in circles, and didn't address the concerns raised. There is new evidence showing that maintaining the non-unified build is very hard. We knew that from the start, which is why the plan was to

Re: [webkit-dev] webkit-changes substitute

2022-08-10 Thread Alexey Proskuryakov via webkit-dev
Hi, There doesn't appear to be anything good enough, filed https://bugs.webkit.org/show_bug.cgi?id=243793 to track. Please add your use scenarios if they are different from what I listed. I wanted this too, but gave Jonathan incorrect information about importance - it seemed like the mailing

Re: [webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Alexey Proskuryakov via webkit-dev
It seems like we still need to host watchlist CC service though, to support patch workflow - and we'll have separate lists in GitHub and in Bugzilla, unless watchlists are reimplemented. I believe that while there are stale watchlists entries, newer additions are valid. - Alexey 2 июня 2022

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-01 Thread Alexey Proskuryakov via webkit-dev
Hi, I'm not sure if we have a consensus on whether it is a project goal to keep non-unified build working at all times. As discussed last year, setting up post-commit bots is a pre-requisite for having EWS, so this part is resolved. But proactively maintaining the non-unified build is strictly

Re: [webkit-dev] Proposed changes to Bugzilla 'Resolution' categories

2022-02-10 Thread Alexey Proskuryakov via webkit-dev
> 10 февр. 2022 г., в 12:06 PM, Michael Catanzaro via webkit-dev > написал(а): > > On Thu, Feb 10 2022 at 11:55:56 AM -0800, Brent Fulgham via webkit-dev > wrote: >> (1) Add a new “Behaves As Designed” option: >>> This will represent bugs that were filed when the reporter misunderstands a

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-30 Thread Alexey Proskuryakov via webkit-dev
(Re-sending from correct address) These points from my yesterday email remain without responses: 1. Cannot have an EWS without corresponding post-commit queue. 2. It doesn't appear like we looked into whether there are any ways to mitigate the problem other that this most costly one. - Alexey

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Alexey Proskuryakov via webkit-dev
Hi, Do we have a post-commit non-unified builder? Starting with EWS wouldn't seem like a workable plan to me, as breakages would creep in anyway, and it's really hard to notice and isolate those from EWS results alone. Giving all WebKit developers the responsibility to support more build

Re: [webkit-dev] New EWS queue: Stress Test EWS

2021-04-28 Thread Alexey Proskuryakov via webkit-dev
Hi, This issue is tracked as https://bugs.webkit.org/show_bug.cgi?id=225126 - Alexey > 28 апр. 2021 г., в 3:23 AM, Manuel Rego Casasnovas via webkit-dev > написал(а): > > Hi, > > The stress test EWS has some issue when dealing with

[webkit-dev] Updated Subversion installer for WebKit development on macOS

2021-03-31 Thread Alexey Proskuryakov via webkit-dev
Hi, We've posted a new svn installer for macOS to https://webkit.org/build-tools/ . It now runs natively on Apple Silicon, and the build contains the fix for https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-17525

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Alexey Proskuryakov
> 3 окт. 2020 г., в 2:24 AM, Adrien Destugues > написал(а): > > On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote: >>> I realize that Gerrit might not integrate at all with hosting the repo >>> on Github, but has any thought been given to this aspect of the >>> transition? >>

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 1:11 PM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 10:24 AM, Geoffrey Garen > > wrote: >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >>> > wrote: Can you explain more about what "O3 with

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 10:24 AM, Geoffrey Garen написал(а): > >>> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen >> > wrote: >>> >>> Can you explain more about what "O3 with no-inlining” is? How does >>> --force-opt=O3 avoid inlining? Would this fully resolve Simon

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 19 июня 2020 г., в 9:59 AM, Mark Lam написал(а): > > > >> On Jun 19, 2020, at 9:53 AM, Alexey Proskuryakov > <mailto:a...@webkit.org>> wrote: >> >> >> >>> 18 июня 2020 г., в 9:30 PM, Saam Barati >> <mailto:sbar...@apple.

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Alexey Proskuryakov
> 18 июня 2020 г., в 9:30 PM, Saam Barati написал(а): > > Why are we insisting on doing something on the bots that takes ~10x longer to > run than necessary? I’d rather have that time spent running more tests. Replying to this point specifically, I wanted to point out that WebKit tests take

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Alexey Proskuryakov
I frequently find it critically useful to see stack traces from debug builds, because of no inlining. So I don't think that we should do this. A local build does not help when the issue is not readily reproducible. - Alexey > 17 июня 2020 г., в 1:36 PM, Mark Lam написал(а): > > Hi folks, >

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Alexey Proskuryakov
I see substantial appeal in having a separate data file, however I'm not sure if it can inform IDE parsing and syntax highlighting for code enabled/disabled at compile time. Header files seem like they would get that right more often. - Alexey > 10 мая 2020 г., в 10:07 PM, Maciej Stachowiak

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Alexey Proskuryakov
The license is not BSD or LGPL, so that's one aspect to consider. Why exactly are distros unwilling to update ICU? - Alexey > 9 апр. 2020 г., в 10:32 AM, Michael Catanzaro > написал(а): > > > Any objections to uploading a bundled ICU 60 under Source/ThirdParty? > > Seems easier than

[webkit-dev] Checking out WebKit source code when using Xcode 11.4

2020-03-24 Thread Alexey Proskuryakov
Hello everyone, Xcode 11.4 was released today, and it does not include svn or git-svn any more. We have posted a standalone installer at to keep getting tools needed for WebKit development easy. - Alexey ___

Re: [webkit-dev] Terminology: Could we change 'roll out' to 'roll back'?

2020-03-06 Thread Alexey Proskuryakov
> 6 марта 2020 г., в 18:29, Ryosuke Niwa написал(а): > > On Fri, Mar 6, 2020 at 6:15 PM Kirsling, Ross wrote: >> >> Late on Friday seems like a good time for a terminological debate (), so I’d >> like to propose we revisit one of the strangest items of WebKit-specific >> terminology: the

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Alexey Proskuryakov
> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): > > Does anyone oppose clearing all review requests that are older than 6 months? > (or 1 year?) Looking at ancient patches in the review queue, quite a few look like they should still work (e.g. adding new tests). So said that we are not

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-05 Thread Alexey Proskuryakov
10 more test failures on two retries (combined) than in a clean run seems reasonable. - Alexey > Thanks > Aakash > >> On Dec 3, 2019, at 12:28 PM, Alexey Proskuryakov > <mailto:a...@webkit.org>> wrote: >> >> >> Yes, I think that this makes more sense

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-03 Thread Alexey Proskuryakov
Yes, I think that this makes more sense than retrying. What is the current behavior when a patch introduces substantial flakiness? E.g. this scenario: - First test run produces 5 failures. - Second test run produces 5 different failures. - Clean re-run produces no failures. This looks like

Re: [webkit-dev] Content-DPR: Image resolution optimization at CDN/transport layer

2019-11-11 Thread Alexey Proskuryakov
> 10 нояб. 2019 г., в 1:16 AM, Noam Rosenthal написал(а): > > Hola > > I would like to open a discussion that has started a few years back and has > never reached a consensus: https://bugs.webkit.org/show_bug.cgi?id=145380 > > > In a

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-05 Thread Alexey Proskuryakov
> 4 нояб. 2019 г., в 1:37 PM, Ryosuke Niwa написал(а): > > > On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov <mailto:a...@webkit.org>> wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure useful > to reviewers? > > Gett

Re: [webkit-dev] iOS EWS behind by 3 days??

2019-11-05 Thread Alexey Proskuryakov
> 4 нояб. 2019 г., в 11:30 PM, Ryosuke Niwa написал(а): > > Hi all, > > Does anyone know what's happening with iOS EWS? Not yet, but it's part of a cluster of problems related to interactions between simulator and specific macOS host versions. https://bugs.webkit.org/show_bug.cgi?id=203792

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Alexey Proskuryakov
s not something anyone can Cc themselves on, and is not > archived, so seems like a strictly worse form of communication. > >> On Nov 2, 2019, at 9:34 AM, Alexey Proskuryakov wrote: >> >> >> My preference is still e-mailing the patch author directly (possibly, a

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-02 Thread Alexey Proskuryakov
My preference is still e-mailing the patch author directly (possibly, also having an option to opt in for anyone). Bugzilla comments will always be irrelevant for most people CC'ed on the bug, and they are almost always undesirable to keep within the discussion flow. - Alexey > 1 нояб. 2019

Re: [webkit-dev] 2019 WebKit Contributors Meeting - Hurry! Registration is Closing!

2019-10-25 Thread Alexey Proskuryakov
Seems like an issue to look into. However this should not prevent you from registering, because you do have a Trac account (it's the same thing as your svn account). - Alexey > 25 окт. 2019 г., в 8:07 AM, Geoffrey Garen написал(а): > > The Login page looks like this: > > > > If you

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Alexey Proskuryakov
> 15 июля 2019 г., в 23:04, Fujii Hironori > написал(а): > > > On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa > wrote: > > I don’t think anyone is arguing that we’d eventually need to move to Python3. > I’m arguing that it’s not okay to require random WebKit

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Alexey Proskuryakov
> 10 мая 2019 г., в 13:50, Darin Adler написал(а): > >> On May 10, 2019, at 1:13 PM, Keith Miller wrote: >> >> I’m not sure I know what you mean by allow a whole-directory exception. Do >> you mean a top level directory? Or some kind of parameter we pass to the >> hook to ignore some

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Alexey Proskuryakov
I posted a tool that I used for this today to https://bugs.webkit.org/show_bug.cgi?id=197537. Probably a lot to improve, but it works. - Alexey > 2 мая 2019 г., в 14:32, Darin Adler написал(а): > > Should we post instructions somewhere for people dealing with spam? I believe > the

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Alexey Proskuryakov
One change that I'm going to make is to mark spam comments as private instead of simply tagging. That way, bugs will look cleaner, and there will be no doubt about whether search engines index hidden comments or not. I'll also mark old spam comments as private. I think that this will generate

Re: [webkit-dev] Spam and indexing

2019-03-29 Thread Alexey Proskuryakov
> 28 марта 2019 г., в 14:10, Konstantin Tokarev написал(а): > > > > 28.03.2019, 23:58, "Alexey Proskuryakov" : >> Hello, >> >> The robots.txt file that we have on bugs.webkit.org currently allows search >> engines access to individual bug

[webkit-dev] Spam and indexing

2019-03-28 Thread Alexey Proskuryakov
Hello, The robots.txt file that we have on bugs.webkit.org currently allows search engines access to individual bug pages, but not to any bug lists. As a result, search engines and the Internet Archive only index bugs that were filed before robots.txt changes a few years ago, and bugs that are

[webkit-dev] WebCorePrefix.h vs. config.h

2018-12-07 Thread Alexey Proskuryakov
Hi, Do we still need separate WebCorePrefix.h and config.h? The former has this comment, which I don't think is true any more: /* This prefix file should contain only: *1) files to precompile for faster builds *2) in one case at least: OS-X-specific performance bug workarounds *

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 16:45, Ryosuke Niwa написал(а): > > Alternatively, is there a way you can make more of us be able to moderate > these spammers? Anyone can tag comments to make them invisible, but there is no privilege level in Bugzilla where one can disable user accounts, but cannot

Re: [webkit-dev] Proposal for Device-Specific Layout Tests

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 16:43, Ryosuke Niwa написал(а): > > > On Tue, Dec 4, 2018 at 12:55 PM Jonathan Bedard > wrote: > These directories would be along-side tests. > > I don't like that platform-specific results are under LayoutTests/platform > and device-specific

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-04 Thread Alexey Proskuryakov
> 4 дек. 2018 г., в 11:21, Ryosuke Niwa написал(а): > > e.g. > https://bugs.webkit.org/show_bug.cgi?id=168774 > > > Is there a way we can integrate CAPTCHA, etc... to prevent these spammers > from getting Bugzilla account? We can integrate

Re: [webkit-dev] Design for review: EWS for security bugs

2018-06-20 Thread Alexey Proskuryakov
> 16 июня 2018 г., в 0:12, Daniel Bates написал(а): > > Hi all, > > I am working to support EWS processing of patches on security bugs (see > >) and I am writing to this > list to solicit

Re: [webkit-dev] Trying to builder older version of webkit (but failing) - looking for help

2018-05-22 Thread Alexey Proskuryakov
Hello Ted, 603.1.30 is the version included with Safari 10.1 on Sierra, so yes, building it against High Sierra SDK with newer Xcode puts you on uncharted territory. The file that you are hitting an issue with is one of the first files in WebCore to build, so chances are that there will be

Re: [webkit-dev] Request for upgrading xcode toolchains in Apple bots for C++17

2018-05-21 Thread Alexey Proskuryakov
Hi, To clarify, are you asking specifically for mac-32bit EWS to be upgraded? It has Xcode 9.2, and can be upgraded to 9.3.1 (that will be a multi-step process, as we need to keep the version in sync with several other setups). But macOS Sierra bots have Xcode 8.3.3, and that is the latest

Re: [webkit-dev] Test262 includes some tab characters

2018-02-04 Thread Alexey Proskuryakov
> 4 февр. 2018 г., в 7:09, Yusuke SUZUKI написал(а): > > Hi WebKittens, > > Recently, I updated test262, and I found newly added test262 files include > TAB characters (\t). > IIRC, I need some help to import such files into WebKit tree. > Can we make JSTests/test262

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Alexey Proskuryakov
he copying, but trying to make a legitimate story for why any extra work is needed. - Alexey > Anything not on *.webkit.org <http://webkit.org/> or similar, or anything not > on on S2 buckets that are owned by Apple directly, does not fit that policy. > > On T

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Alexey Proskuryakov
> 12 дек. 2017 г., в 1:34, Mathias Bynens написал(а): > > It would be great to make such downloads available from webkit.org > or > a similar domain! Can you explain in more detail why this is important? If there is an expectation that this will make

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-28 Thread Alexey Proskuryakov
> 17 нояб. 2017 г., в 23:02, youenn fablet написал(а): > > Tests are available at https://w3c-test.org which > makes it easy to share through any tool supporting hyperlinks. > A webarchive can also be made so that it is easy to share and probably edit

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Alexey Proskuryakov
(re-sending from a correct address) > 17 нояб. 2017 г., в 9:18, youenn fablet > написал(а): > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. > This is now fixed and should improve

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-16 Thread Alexey Proskuryakov
Migrating WebKit tests seems undesirable to me, as that would make us lose all their modification history. As mentioned before, WPT tests are inherently getting less attention in CI support, largely because of unclear benefit when there isn't any history for why the particular test was added.

Re: [webkit-dev] Dead code in webkitpy runtests.py

2017-11-01 Thread Alexey Proskuryakov
I think that we would still like to have a unified way to run tests. Right now, even knowing whether a particular script or build step is covered by tests is not straightforward. At the same time, I think that the tiny subset of tests that webkit-patch used to run wasn't meaningful.

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 26 окт. 2017 г., в 9:50, Brian Burg написал(а): > > why differ from the vast majority of all other Python code in existence, just > to be different? What's the point? My point is that people familiar with all other Python code in existence will not be hacking on

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Alexey Proskuryakov
> 25 окт. 2017 г., в 18:21, Michael Catanzaro > написал(а): > > On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain wrote: >> Does anyone else has any opinion/preference for this? > > The number of spaces before a comment really does not matter, but my

Re: [webkit-dev] SVN server broken?

2017-09-08 Thread Alexey Proskuryakov
Is anyone still seeing issues? I see a number of patches landed overnight, including by commit queue. One problem I do see is that trac is stale. - Alexey > 8 сент. 2017 г., в 3:19, Carlos Alberto Lopez Perez > написал(а): > > On 08/09/17 11:56, Carlos Alberto Lopez

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Alexey Proskuryakov
> 30 авг. 2017 г., в 11:55, Andy Estes написал(а): > In a completely other direction, what does this mean for use of Xcode? Can we still build from Xcode? Debug? >>> >>> CMake can generate Xcode files, so you can still develop and debug in Xcode. >> >> This

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 16:12, Sam Weinig <wei...@apple.com> написал(а): > > > >> On May 12, 2017, at 2:49 PM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@webkit.org>> wrote: >> >> >>> 12 мая 2017 г., в 14:38, Sam Wei

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 14:39, Ryosuke Niwa написал(а): > > This is absolutely not how I operate at all. Since almost all custom > elements and shadow DOM API tests I wrote are written using > testharness.js and upstreamed to web-platform-tests, they have been > deleted from

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 14:38, Sam Weinig написал(а): > > I regret piling on here, as I think this thread has diverged from it’s > original purpose, but…I understand this frustration. That said, perhaps this > is something we can solve with some tooling. For instance, a >

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 12 мая 2017 г., в 11:52, Ben Kelly <b...@wanderview.com> написал(а): > > On Fri, May 12, 2017 at 2:26 PM, Rick Byers <rby...@chromium.org > <mailto:rby...@chromium.org>> wrote: > On Fri, May 12, 2017 at 2:06 PM, Alexey Proskuryakov <a...@webkit.org > &

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Alexey Proskuryakov
> 9 мая 2017 г., в 11:27, Simon Fraser написал(а): > > Another consideration here is "would my test be useful for other browser > vendors". I don't think the answer is a unanimous "yes", so I think we should > only use WPT for tests that will think are worth sharing.

Re: [webkit-dev] Commits in branches triggering build in the bots now

2017-05-04 Thread Alexey Proskuryakov
Hi Carlos, Could you please file a bug, and include the relevant links to investigate the issue? - Alexey > 4 мая 2017 г., в 0:46, Carlos Garcia Campos написал(а): > > I don't know what have changed, but now, commits in other branches are > triggering builds in the

[webkit-dev] Aakash Jain is now a WebKit Reviewer

2017-04-02 Thread Alexey Proskuryakov
Hi everyone, I would like to announce that Aakash Jain is now a WebKit reviewer. Aakash works on WebKit tools and infrastructure. Please join me in congratulating Aakash, and send him some patches to review! - Alexey ___ webkit-dev mailing list

Re: [webkit-dev] Unable to log in to bugs.webkit.org

2017-04-01 Thread Alexey Proskuryakov
Done. If anyone else hits this, please e-mail ad...@webkit.org . Resetting the password did work for other people, so clearly there is some flakiness to diagnose. - Alexey > 1 апр. 2017 г., в 10:24, Dan Bernstein написал(а): > > Can someone help me

[webkit-dev] Bugzilla 5.0.3 password strength requirements

2017-03-21 Thread Alexey Proskuryakov
Hi, Our updated Bugzilla installation now has password strength check enabled. It will refuse logging in with a weak password. One specific tool that is affected is webkit-patch, which logs in every time. If it's giving you strange errors like the below, please try logging out from Bugzilla

[webkit-dev] DEFERRED: Scheduled Outage: WebKit Bugzilla (bugs.webkit.org) March 13th, 2017 from 9AM PDT to Noon PDT

2017-03-11 Thread Alexey Proskuryakov
Hi, The upgrade was deferred to a later date. There will be svn.webkit.org maintenance with some downtime on Monday afternoon. The exact time will be announced on Monday. - Alexey > 8 марта 2017 г., в 11:49, Ling Ho

Re: [webkit-dev] Can I get the editbugs-bit?

2017-03-01 Thread Alexey Proskuryakov
Done. - Alexey > 1 марта 2017 г., в 17:15, Suzuki, Basuke > написал(а): > > Hi > > My name is Basuke Suzuki, working at SONY Interactive Entertainment, a.k.a > PlayStation, > working with Don Olmstead and Hironori Fujii > > I want to ask to assign the

Re: [webkit-dev] SVN trouble

2017-02-26 Thread Alexey Proskuryakov
On Feb 25, 2017, at 8:40 AM, Simon Fraser <simon.fra...@apple.com > <mailto:simon.fra...@apple.com>> wrote: > >> EWS is still down. Do we have an ETA? >> >> Simon >> >>> On Feb 24, 2017, at 10:25 PM, Alexey Proskuryakov <a...@webkit.org >

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 19:50, Chris Dumez <cdu...@apple.com> написал(а): > > > > >> On Feb 24, 2017, at 11:41 AM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@webkit.org>> wrote: >> >> I believe that all infrastructure has r

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
gt; On 24/02/17 20:16, Alexey Proskuryakov wrote: >> >> How does one create a local git-svn checkout to try this out? Given that >> the offending file has been effectively deleted from svn, I think that >> git-svn should work too. > > You have the scri

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 9:31, Carlos Alberto Lopez Perez <clo...@igalia.com> > написал(а): > > On 24/02/17 18:08, Alexey Proskuryakov wrote: >> works. There is almost certainly more cleanup that needs to be done - I >> can see that trac.webkit.org <http://trac.we

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Alexey Proskuryakov
> 24 февр. 2017 г., в 7:48, Antti Koivisto написал(а): > > Hi, > > Looks like https://bugs.webkit.org/show_bug.cgi?id=168774 > caused some sort of SVN > problem. Please hold commits until this is resolved. I deleted the

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Alexey Proskuryakov
> 6 февр. 2017 г., в 12:28, Ryosuke Niwa написал(а): > > The concern I've heard about is not how run-webkit-tests run the tests. It's > about how a test is opened inside a browser, DRT, WTR while debugging. +1 I think that making web platform tests more practical for

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Alexey Proskuryakov
There are two considerations which make me skeptical that auto is a good thing. 1. There are many smart pointer types in C++, and ignoring pointer types is very error prone. Others have mentioned std::optional, and mistakes being made with RefPtrs. I even saw a case where a review comment that

Re: [webkit-dev] Asserting versus throwing in internals and testRunner objects

2016-09-23 Thread Alexey Proskuryakov
Note that we are talking about API misuse here, so associating the crash with a test is not really needed - it's the test that you are writing. I've seen tests getting checked in even when they don't run to completion and raise JS exceptions. I want it to be very clear and obvious when a test

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 22:34, Darin Adler <da...@apple.com> написал(а): > >> On Jul 22, 2016, at 10:25 PM, Alexey Proskuryakov <a...@webkit.org> wrote: >> >> Simon and I were trying to move all tests out of platform/ directories. > > Is this nearly done

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 21:57, Darin Adler написал(а): > >> What is the right way to deal with tests like these? > > I think we should move the tests into platform/mac. Simon and I were trying to move all tests out of platform/ directories. When the expected results are

Re: [webkit-dev] ./Tools/Scripts/run-safari doesn't work with Safari 10

2016-07-18 Thread Alexey Proskuryakov
Hello Marco, > 18 июля 2016 г., в 13:02, Marco Barisione > написал(а): > > Hello, > > I recently installed Safari 10 on some machines running 10.11.6 DP. > Unfortunately, I cannot get Safari 10 to work with WebKit compiled from SVN. > > I tried with both SVN

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Alexey Proskuryakov
Hi, I do not think that there is a way to algorithmically define what an acceptable difference is. Here are a few cases where it's critical to detect small differences: - color management, e.g. testing different code paths that should match precisely; - finding uninitialized memory use bugs

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Alexey Proskuryakov
> 18 нояб. 2015 г., в 11:50, Simon Fraser написал(а): > > There are some well-understood reasons why a test might not exactly match its > reference. One is that the test uses compositing layers to do clipping, but > the reference just clips with drawing, and these are

Re: [webkit-dev]

2015-11-17 Thread Alexey Proskuryakov
Hello Yoav, Is there any technology on the horizon that would simplify doing this kind of optimization? If done manually, this seems: - complicated, so only a few sites will do this; - very likely to go stale, as the content changes, but preload instructions do not get updated; - related to the

Re: [webkit-dev] Windows EWS not working?

2015-11-07 Thread Alexey Proskuryakov
(re-sending from the right e-mail address for the list) > 7 нояб. 2015 г., в 16:56, Darin Adler написал(а): > > I was looking at the patch in this bug: > > https://bugs.webkit.org/show_bug.cgi?id=150967 > > The patch was posted 20 hours ago. EWS has processed this for all

Re: [webkit-dev] Mac EWS Updates!

2015-10-21 Thread Alexey Proskuryakov
Normally, we try to configure EWS with OS versions that most engineers no longer use on their machines, to maximize the chances of catching problems that one can't catch locally. It would certainly be ideal to cover the full spectrum, as many contributors don't have Macs at all. - Alexey >

Re: [webkit-dev] Bugzilla default assignees

2015-09-14 Thread Alexey Proskuryakov
Yet another approach used by the Accessibility component is to have a technical account auto-CC'ed, and then anyone interested can follow this account. This seems like the most reliable solution to me. - Alexey 14 сент. 2015 г., в 9:26, Brian Burg написал(а): > It should

Re: [webkit-dev] Commit queue issues

2015-09-02 Thread Alexey Proskuryakov
02 сент. 2015 г., в 5:41, Philippe Normand написал(а): > It seems the commit queue cannot land patches? > > https://bugs.webkit.org/show_bug.cgi?id=148702 This should be resolved now. I see that you already marked this patch for cq+ again; I'll see if any others are stuck.

Re: [webkit-dev] Commit queue issues

2015-09-02 Thread Alexey Proskuryakov
> 2 сент. 2015 г., в 9:59, Alexey Proskuryakov <a...@webkit.org> написал(а): > > > 02 сент. 2015 г., в 5:41, Philippe Normand <ph...@igalia.com> написал(а): > >> It seems the commit queue cannot land patches? >> >> https://bugs.webkit.org/show_b

Re: [webkit-dev] Switching servers for EWS and flakiness dashboard [Caution: Message contains Suspicious URL content]

2015-07-31 Thread Alexey Proskuryakov
I tried running the style queue from command line, and it processed some patches, errored out on some others, and then hit a different error. I restarted the queue normally then, and it has processed all patches except for https://bugs.webkit.org/attachment.cgi?id=257920action=prettypatch. We

Re: [webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

2015-04-24 Thread Alexey Proskuryakov
24 апр. 2015 г., в 9:06, Brady Eidson beid...@apple.com написал(а): Killing the feature would lead to a confusing experience for such users. Additionally, I think that outright killing multipart main resources would cause unnecessarily confusing experience for WebKit developers. One of the

Re: [webkit-dev] Running W3C tests using wptserve

2015-02-01 Thread Alexey Proskuryakov
correctly. Is it possible to get access to the corresponding WebKitBuild/Release/layout-test-results, in particular wptwk_process_log.out.txt? Also, does it happen on all bots or only windows bot? 2015-02-01 4:41 GMT+01:00 Alexey Proskuryakov a...@webkit.org: 31 янв. 2015 г., в 11:57

Re: [webkit-dev] Running W3C tests using wptserve

2015-01-31 Thread Alexey Proskuryakov
31 янв. 2015 г., в 11:57, youenn fablet youe...@gmail.com написал(а): Currently, only two tests are run within that folder: - web-platform-tests/domparsing/DOMParser-parseFromString-html.html - web-platform-tests/domparsing/insert-adjacent.html Should there be any issus with those tests,

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-23 Thread Alexey Proskuryakov
23 янв. 2015 г., в 10:01, Ryosuke Niwa rn...@webkit.org написал(а): We could add a new test expectation like ImageDiff to suppress these or we could expose a new internals or testRunner methods to mark a test as such. Good idea! An ImageHashMismatch expectation seems like a reasonable way to

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-22 Thread Alexey Proskuryakov
22 янв. 2015 г., в 11:30, Simon Fraser simon.fra...@apple.com написал(а): This happens when the expected and actual images are very close, but not identical. ImageDiff has some built-in rounding that effectively acts as a small tolerance, so the hashes are different, but ImageDiff

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-22 Thread Alexey Proskuryakov
22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а): What about the test I cited? svg/css/svg-resource-fragment-identifier-img-src.html This particular test is buggy - it is a hidpi test, so it dumps results as a 1600x1200 image, but its -expected.html is not hidpi, and is

Re: [webkit-dev] review times

2014-12-03 Thread Alexey Proskuryakov
03 дек. 2014 г., в 2:32, Daniel Lazarenko dani...@opera.com написал(а): Whatsoever it would be nice find a new reviewer for my patch. Does anybody want to take it? Just to be clear about this part, the reviewer should not be just anybody. This patch is part of an effort to implement a new

  1   2   3   4   5   >