[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934870#action_12934870
]
Thomas Koch commented on ZOOKEEPER-836:
---
Hi Benjamin,
we can not call it HostSet
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Attachment: ZOOKEEPER-836.patch
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch reassigned ZOOKEEPER-836:
-
Assignee: Thomas Koch
hostlist as string
--
Key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Status: Patch Available (was: Open)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch resolved ZOOKEEPER-895.
---
Resolution: Fixed
Has been solved as part of ZOOKEEPER-909 by using CopyOnWriteArraySet
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Attachment: (was: ZOOKEEPER-836.patch)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Status: Open (was: Patch Available)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Attachment: ZOOKEEPER-836.patch
forgot to add a file in the last patch
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Status: Patch Available (was: Open)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Attachment: (was: ZOOKEEPER-836.patch)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Attachment: ZOOKEEPER-836.patch
now also added apache license headers ...
hostlist
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Status: Patch Available (was: Open)
hostlist as string
[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-836:
--
Status: Open (was: Patch Available)
hostlist as string
Patrick Hunt:
http://www.jboss.org/netty/community.html#nabble-td5730963
Patrick
Hi Patrick,
you did shock me. :-) So the news is not, that the netty community would
split, but just that netty moves from SVN to GIT.
Cheers,
Thomas Koch, http://www.koch.ro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-908:
--
Attachment: (was: ZOOKEEPER-908.patch)
Remove code duplication and inconsistent naming
[
https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-908:
--
Attachment: ZOOKEEPER-908.patch
new patch against the current Client after ZOOKEEPER-909
[
https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-908:
--
Status: Patch Available (was: Open)
Remove code duplication and inconsistent naming
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930544#action_12930544
]
Thomas Koch commented on ZOOKEEPER-909:
---
Dear Hudson,
you're terribly annoying me
[
https://issues.apache.org/jira/browse/ZOOKEEPER-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930547#action_12930547
]
Thomas Koch commented on ZOOKEEPER-925:
---
Please don't check in _any_ generated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Patch Available (was: Open)
trying to trigger the hudson build once again to see
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930558#action_12930558
]
Thomas Koch commented on ZOOKEEPER-909:
---
In our build.xml we still have the old
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Open (was: Patch Available)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Open (was: Patch Available)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: (was: ZOOKEEPER-909.patch)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Patch Available (was: Open)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930074#action_12930074
]
Thomas Koch commented on ZOOKEEPER-909:
---
3 out of 3 test runs did pass
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
resubmitting the last patch without changes just to make
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ClientCnxnSocketNetty.java
just FYI: This is the ClientCnxnSocketNetty class
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929395#action_12929395
]
Thomas Koch commented on ZOOKEEPER-909:
---
I've added some javadoc and renamed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
I couldn't wait for the tests to finish now
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Patch Available (was: Open)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Assignee: Patrick Hunt (was: Thomas Koch)
Status: Patch Available (was: Open
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
add copyright blocks, replace deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Open (was: Patch Available)
Extract NIO specific code from ClientCnxn
this flaky tests would show
up more often.
Thanks
mahadev
On 10/20/10 11:48 PM, Thomas Koch tho...@koch.ro wrote:
Hi,
last night I let my hudson server do 42 (sic) builds of ZooKeeper trunk.
One of this builds failed:
junit.framework.AssertionFailedError: Leader hasn't joined: 5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch reassigned ZOOKEEPER-909:
-
Assignee: Thomas Koch (was: Patrick Hunt)
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923986#action_12923986
]
Thomas Koch commented on ZOOKEEPER-909:
---
Hi Benjamin,
you mean, I should add
separation of
concerns.
Wouldn't you like to setup Hudson to build ZooKeeper trunk every half an hour?
[1] http://en.wikipedia.org/wiki/Unusual_software_bug
Best regards,
Thomas Koch, http://www.koch.ro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923380#action_12923380
]
Thomas Koch commented on ZOOKEEPER-102:
---
Another option would be avro. Does
Issue Type: Sub-task
Reporter: Thomas Koch
rename record - request (since their is a counterpart record named response)
rename header - requestHeader (to distinguish from responseHeader)
remove ByteBuffer creation code from primeConnection() method and use the
duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-908:
--
Attachment: ZOOKEEPER-908.patch
ant test-core did work without failures.
Remove code
Reporter: Thomas Koch
Assignee: Patrick Hunt
Fix For: 3.4.0
This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus
everything Netty related. This means this patch only extract all NIO specific
code in the class ClientCnxnSocketNIO which extends
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
Extract NIO specific code from ClientCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Status: Patch Available (was: Open)
Extract NIO specific code from ClientCnxn
Type: Sub-task
Reporter: Thomas Koch
Fix For: 3.4.0
The SelectionKey class provides methods to replace something like this
(k.readyOps() (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0
with
selectionKey.isReadable() || selectionKey.isWritable()
It may be possible
knowledge of java reaches (which may
not be too far) incomingBuffer == lenBuffer _always_ evaluates to true. Isn't
that true?
So effectively we've got dead code in the elseif and else branches, didn't we?
Best regards,
Thomas Koch, http://www.koch.ro
Components: java client
Reporter: Thomas Koch
Copied from my email to the ZK dev list from 2010/05/26:
For my current code I'm using zkclient[1] and have also looked at cages[2] for
some ZK usage examples. I observed, that there's a common pattern to wrap ZK
operations in callables and feed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923476#action_12923476
]
Thomas Koch commented on ZOOKEEPER-835:
---
Hi Benjamin,
I'm sorry, I should have
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Description:
This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus
[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-909:
--
Attachment: ZOOKEEPER-909.patch
netty2 could not be found by ivy
--- a/ivysettings.xml
to test each incremental step at least 5 times to find the step(s)
that breaks ZK.
This approach should take me another two weeks, I believe, mostly because each
Test run takes ~15-25 minutes.
Cheers,
Thomas Koch, http://www.koch.ro
I could commit to this branch?
Or if sbd else commits on this branch, how should I send patches?
If I can commit, is there a way, how I could use GIT to work on this branch?
I've not yet used git-svn to do commits.
Have a nice weekend,
Thomas Koch, http://www.koch.ro
://issues.apache.org/jira/browse/ZOOKEEPER-835 that can
individually be discussed, reviewed and tested.
Have a nice weekend after Hadoop World!
Thomas Koch, http://www.koch.ro
ClientCnxn.authInfo must be thread safe
---
Key: ZOOKEEPER-895
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-895
Project: Zookeeper
Issue Type: Bug
Reporter: Thomas Koch
authInfo can
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
wrapped access to ClientCnxn.authInfo in synchonized
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: testWatchAutoResetWithPending_FAILURE
I did 10 builds now in total
add Package o.a.Zookeeper.Client
Key: ZOOKEEPER-894
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-894
Project: Zookeeper
Issue Type: Sub-task
Reporter: Thomas Koch
--
This message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-894:
--
Description:
I'd like to move classes that are not part of the API but belong to the ZK
-835
Best regards,
Thomas Koch, http://www.koch.ro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-894:
--
Description:
I'd like to move classes that are not part of the API but belong to the ZK
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12920715#action_12920715
]
Thomas Koch commented on ZOOKEEPER-823:
---
Hi Patrick,
I saw the same exceptions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12920750#action_12920750
]
Thomas Koch commented on ZOOKEEPER-823:
---
The problem with the failing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Open (was: Patch Available)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
Corrected another synchronization issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: testDisconnectedAddAuth_FAILURE
I've built this patch 4 times now and had only
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919293#action_12919293
]
Thomas Koch commented on ZOOKEEPER-823:
---
How to continue with this?
I know have
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
I may have fixed another issue:
I wrapped
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Open (was: Patch Available)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
I did another version of the patch with an example how I'd
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: (was: ZOOKEEPER-823.patch)
update ZooKeeper java client to optionally use
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12916168#action_12916168
]
Thomas Koch commented on ZOOKEEPER-762:
---
There are many changes in the java client
Reporter: Thomas Koch
Those methods change the inner state of Packet, work on Packet so they should
better be methods of class Packet. This may help to clarify synchronization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913954#action_12913954
]
Thomas Koch commented on ZOOKEEPER-823:
---
I can not reproduce any test failure
outgoingQueue should be a class
---
Key: ZOOKEEPER-879
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-879
Project: Zookeeper
Issue Type: Sub-task
Reporter: Thomas Koch
I'm not yet 100% sure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913446#action_12913446
]
Thomas Koch commented on ZOOKEEPER-823:
---
With the latest trunk merged in, works
-823 waiting to be tested by hudson, updated for newer
trunk on 15/09. Today is 21/09.
Could anybody please give a status update?
I'll have my last exam at university this saturday, so I'd have some time to
contribute afterwards, if you could help me.
happy hacking,
Thomas Koch, http
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Open (was: Patch Available)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Open (was: Patch Available)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
updated patch to newest trunk state
update ZooKeeper java
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12907270#action_12907270
]
Thomas Koch commented on ZOOKEEPER-823:
---
Hi Ivan,
thank you for looking over
Hi Ben, Mahadev,
Patrick suggested I might ask you for review on ZOOKEEPER-823. It
does some refactoring on ClientCnxn and blocks other issues which
also want to edit ClientCnxn.
Thanks,
Thomas Koch, http://www.koch.ro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-849:
--
Status: Open (was: Patch Available)
The ctor currently throws an unchecked exception
[
https://issues.apache.org/jira/browse/ZOOKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906503#action_12906503
]
Thomas Koch commented on ZOOKEEPER-866:
---
Thinking more about this, I'd consider
[
https://issues.apache.org/jira/browse/ZOOKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906328#action_12906328
]
Thomas Koch commented on ZOOKEEPER-866:
---
Just 2c: I'm going to use ZK too for some
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
changes:
- call ClientCnxn.cleanup() from
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
. If this happens, before the main thread calls packet.wait() then
there's nobody left to awake the main thread.
Regards,
Thomas Koch, http://www.koch.ro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
I changed the following things:
- call the correct cleanup
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Status: Patch Available (was: Open)
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
This is a refactoring of phunt's patch to separate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
update ZooKeeper java client to optionally use Netty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: (was: ZOOKEEPER-823.patch)
update ZooKeeper java client to optionally use
or
INI files. Some people may prefer one or the other.
[1] http://commons.apache.org/configuration/
Best regards,
Thomas Koch, http://www.koch.ro
to the socket() class, then I might be done. I'm a bit
puzzled because in NIO there's first a selector.select(to) and then
doWrites(), while in Netty there's first doWrites() and then
outgoingQueue.wait(to).
Best regards,
Thomas Koch, http://www.koch.ro
1 - 100 of 134 matches
Mail list logo
