Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
> Markos is correct, if element is inside element than, root has a > complex type and is not a simple type which anysimpleType represents. This > should make the validation failing in the example from bug #912722 even if lax > is specified. So this doesn't fix the bug #912722, at least the comment "Fixed > bug #912586, #912593 and #912722 (assertion failures with lax validation)" > should be changed. Cezar, will you then take care of these bugs and provide the correct fixes? Federico is only a volunteer at this time, and he shouldn't be spending too much time on this. Federico, will you transfer these bugs to Cezar? What is their priority? Are they blocking the PUL-related work? -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing The module works great. There is room for improvement regarding its documentation. "There are many ways to represent JSON data in XML" -> There are two ways to represent JSON data in XML: - bullet 1 (John Snelson's format) - bullet 2 (JSON) Then add two examples, you can take some inspiration at http://docs.basex.org/wiki/JSON_Module For parse#1, add a small example. For parse#2, add two small examples and some description of what is excepted for the option element (which namespace, example of schema instance instance) For serialize#1, please elaborate on what the following means: "Serializes an XDM into JSON using one of the representations described above." and add two small examples. For serialize#2, same comment than for serialize#1 + add some explanation of what is excepted for the option element. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646
fix for bug #866932 (string pool not empty on shutdown)
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/api/xmldatamanagerimpl.cpp'
--- src/api/xmldatamanagerimpl.cpp 2011-09-15 11:46:01 +
+++ src/api/xmldatamanagerimpl.cpp 2012-01-23 10:10:30 +
@@ -216,8 +216,7 @@
{
ZORBA_DM_TRY
{
-Item lQName = theFactory->createQName(static_context::W3C_FN_NS.c_str(),
- "parse-xml");
+Item lQName = theFactory->createQName(static_context::W3C_FN_NS, "parse-xml");
// create a streamable string item
std::vector lArgs;
@@ -247,7 +246,7 @@
{
ZORBA_DM_TRY
{
-Item lQName = theFactory->createQName(static_context::W3C_FN_NS.c_str(),
+Item lQName = theFactory->createQName(static_context::W3C_FN_NS,
"parse-xml");
// create a streamable string item
@@ -280,7 +279,7 @@
{
ZORBA_DM_TRY
{
-Item lQName = theFactory->createQName(static_context::ZORBA_XML_FN_NS.c_str(),
+Item lQName = theFactory->createQName(static_context::ZORBA_XML_FN_NS,
"parse-xml-fragment");
// create a streamable string item
@@ -315,7 +314,7 @@
{
ZORBA_DM_TRY
{
-Item lQName = theFactory->createQName(static_context::ZORBA_XML_FN_NS.c_str(),
+Item lQName = theFactory->createQName(static_context::ZORBA_XML_FN_NS,
"parse-xml-fragment");
// create a streamable string item
@@ -349,7 +348,7 @@
{
ZORBA_DM_TRY
{
-Item lQName = theFactory->createQName(static_context::ZORBA_FETCH_FN_NS.c_str(),
+Item lQName = theFactory->createQName(static_context::ZORBA_FETCH_FN_NS,
"content");
// create a streamable string item
=== modified file 'src/context/root_static_context.cpp'
--- src/context/root_static_context.cpp 2012-01-11 17:30:25 +
+++ src/context/root_static_context.cpp 2012-01-23 10:10:30 +
@@ -72,7 +72,7 @@
const char* const default_ns_initializers[] =
{
//"err", XQUERY_ERR_NS,
- "fn", static_context::W3C_FN_NS.c_str(),
+ "fn", static_context::W3C_FN_NS,
"local", XQUERY_LOCAL_FN_NS,
//"math", XQUERY_MATH_FN_NS,
"xml", XML_NS,
=== modified file 'src/context/static_context.cpp'
--- src/context/static_context.cpp 2012-01-11 17:30:25 +
+++ src/context/static_context.cpp 2012-01-23 10:10:30 +
@@ -249,7 +249,6 @@
/***//**
Target namespaces of zorba builtin modules
/
-#define NS_PRE static_context::ZORBA_NS_PREFIX
const zstring
static_context::DOT_VAR_NAME = "$$dot";
@@ -260,129 +259,151 @@
const zstring
static_context::DOT_SIZE_VAR_NAME = "$$last-idx";
-const zstring
+const char*
static_context::W3C_NS_PREFIX = "http://www.w3.org/";;
-const zstring
+const char*
static_context::ZORBA_NS_PREFIX = "http://www.zorba-xquery.com/";;
-const zstring
-static_context::W3C_FN_NS = W3C_NS_PREFIX + "2005/xpath-functions";
-
-const zstring
-static_context::W3C_XML_NS = W3C_NS_PREFIX + "XML/1998/namespace";
-
-const zstring
-static_context::ZORBA_MATH_FN_NS = NS_PRE + "modules/math";
-
-const zstring
-static_context::ZORBA_BASE64_FN_NS = NS_PRE + "modules/converters/base64";
-
-const zstring
-static_context::ZORBA_NODEREF_FN_NS = NS_PRE + "modules/node-reference";
-
-const zstring
-static_context::ZORBA_NODEPOS_FN_NS = NS_PRE + "modules/node-position";
-
-const zstring
-static_context::ZORBA_STORE_DYNAMIC_COLLECTIONS_DDL_FN_NS
- = NS_PRE + "modules/store/dynamic/collections/ddl";
-
-const zstring
-static_context::ZORBA_STORE_DYNAMIC_COLLECTIONS_DML_FN_NS
- = NS_PRE + "modules/store/dynamic/collections/dml";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_COLLECTIONS_DDL_FN_NS
- = NS_PRE + "modules/store/static/collections/ddl";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_COLLECTIONS_DML_FN_NS
- = NS_PRE + "modules/store/static/collections/dml";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_INDEXES_DDL_FN_NS
- = NS_PRE + "modules/store/static/indexes/ddl";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_INDEXES_DML_FN_NS
- = NS_PRE + "modules/store/static/indexes/dml";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_INTEGRITY_CONSTRAINTS_DDL_FN_NS
- = NS_PRE + "modules/store/static/integrity_constraints/ddl";
-
-const zstring
-static_context::ZORBA_STORE_STATIC_INTEGRITY_CONSTRAINTS_DML_FN_NS
- = NS_PRE + "modules/store/static/integrity_constra
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2012-01-23T10-18-01.711Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919189] Re: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer
Ghislain, yes, what you say makes sense, given the current implementation. But the current API reflects our long-term goal of separating zorba from the store (into separate libraries). The application may link with several stores and start zorba with a different store each time. In this scenario, the store must be passed as an input to zorba. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919189 Title: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer Status in Zorba - The XQuery Processor: Fix Committed Bug description: At this location, in function ZorbaImpl::init(Store* store): http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/src/api/zorbaimpl.cpp#L93 The assertion assert(store == NULL || store2 == store); allows the variable store to be NULL (and there are places that do call this function indirectly with an explicit NULL store pointer, such as here: http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/modules/com/zorba-xquery/www/modules /http-client.xq.src/http_client.cpp#L68 ). However, this assertion is followed by GlobalEnvironment::init(store); that always fails upon a NULL pointer. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919189/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2012-01-23T10-18-01.711Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/89646 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 866932] Re: "X strings remain in the string pool" failing tests
I have changed the global zstrings in staitc_context to const char* strings. ** Changed in: zorba Status: New => Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/866932 Title: "X strings remain in the string pool" failing tests Status in Zorba - The XQuery Processor: Fix Committed Bug description: There have been a number of bug reports over the years where Zorba crashes on exit with a message like the following: i = 94 String http://www.zorba-xquery.com/options/versioning is still in the pool Zorba Internal Fatal Error in home/ceej/zo/src/src/store/naive/string_pool.cpp:42: "count == 0": condition failed: 1 strings remain in the string pool As far as I know, we have never completely figured out what causes these errors nor how to correct them. Gabriel initially reported this bug 866932 listing several test cases which exhibited this symptom, but those were subsequently cleared up by some other change without fixing the underlying problem. I have just now found at least one reliable way to reproduce this result (see comment #3), so I have co-opted this bug report. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/866932/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
No, the statement "There are many ways to represent JSON data in XML" is correct as it is. There *are* *many* ways: Zorba only implements *two* of those *many* ways. Adding *two* examples is too much. API documentation isn't supposed to be the primary documentation. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing I think William is right. We should have a couple of examples which help the user to get started with this module. Those could either be inline in the text or links generated using the @example xqdoc tag. The serialize functions should be annotated %ann:streamable because they return a streamable string (see modules/com/zorba-xquery/www/modules/fetch.xq). Some error codes lack a prefix (e.g. ZJPE0001). If I understood correctly, it should be zerr:ZJPE0001. Otherwise, the user doesn't know how to catch the error. Under which circumstances does json:parse return the empty sequence? What does json:serialize return if the input is the empty sequence? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919757] Re: Add documentation from old zorba releases
This looks really good, clean, and professional. The links to the latest language APIs are kind of broken but that seems related to bug https://bugs.launchpad.net/zorba/+bug/919755. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919757 Title: Add documentation from old zorba releases Status in Zorba - The XQuery Processor: In Progress Bug description: Add documentation from old zorba releases in the new Zorba website. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919757/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
The proposal to merge lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/remove_old_json-2012-01-23T19-46-43.722Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
The attempt to merge lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job remove_old_json-2012-01-23T19-46-43.722Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
The proposal to merge lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919755] Re: Make Zorba APIs more prominents in website
** Changed in: zorba Importance: Undecided => Critical ** Changed in: zorba Status: New => In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919755 Title: Make Zorba APIs more prominents in website Status in Zorba - The XQuery Processor: In Progress Bug description: Right now the following page: http://zorba.my28msec.com/html/documentation Doesn't mention any non-C++ APIs in the left menu, this should be fixed To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919755/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Bug 919757] Re: Add documentation from old zorba releases
I've pushed a fix for https://bugs.launchpad.net/bugs/919757 as well, do you like it? I also disabled the jsoniq slide On Mon, Jan 23, 2012 at 8:17 PM, Matthias Brantner <919...@bugs.launchpad.net> wrote: > This looks really good, clean, and professional. > > The links to the latest language APIs are kind of broken but that seems > related to bug https://bugs.launchpad.net/zorba/+bug/919755. > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/919757 > > Title: > Add documentation from old zorba releases > > Status in Zorba - The XQuery Processor: > In Progress > > Bug description: > Add documentation from old zorba releases in the new Zorba website. > > To manage notifications about this bug go to: > https://bugs.launchpad.net/zorba/+bug/919757/+subscriptions -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919757 Title: Add documentation from old zorba releases Status in Zorba - The XQuery Processor: In Progress Bug description: Add documentation from old zorba releases in the new Zorba website. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919757/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919755] Re: Make Zorba APIs more prominents in website
I have committed a fix for it that you can see at http://zorba.my28msec.com/html/documentation/ For instance: http://zorba.my28msec.com/html/documentation/2.1.0/c/datastructures If you agree with this fix, please mark this bug as fix committed. ** Changed in: zorba Assignee: (unassigned) => Cezar Andrei (cezar-andrei) ** Changed in: zorba Milestone: None => 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919755 Title: Make Zorba APIs more prominents in website Status in Zorba - The XQuery Processor: In Progress Bug description: Right now the following page: http://zorba.my28msec.com/html/documentation Doesn't mention any non-C++ APIs in the left menu, this should be fixed To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919755/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919755] Re: Make Zorba APIs more prominents in website
The menu looks awesome. Very clean. However, the links only seem to work for C++ and C. The other APIs kind of work but always show the C++ index page. That's somehow confusing. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919755 Title: Make Zorba APIs more prominents in website Status in Zorba - The XQuery Processor: In Progress Bug description: Right now the following page: http://zorba.my28msec.com/html/documentation Doesn't mention any non-C++ APIs in the left menu, this should be fixed To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919755/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing 1) Should be possible to call json:serialize(json:parse(VALID_JSON)) where VALID_JSON is any valid JSON string see failing test test/rbkt/zorba/json/json-snelson-serialize-parse added bug lp:920717 2) array and object closed prematurely in json:parse see failing tests test/rbkt/zorba/json/json-snelson-parse-array-06 and test/rbkt/zorba/json/json-snelson-parse-array-07 added bug lp:920719 3) When trying to parsing a valid JSON string with invalid JSON option parameter the error raised is: http://www.w3.org/2005/xqt-errors:XPST0003 Please add a more useful error message: see failing test test/rbkt/zorba/json/json-invalid-option-parameter added bug lp:920720 4) Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value added bug lp:920721 5) Comment nodes should be ignored by json:serialize Please see failing tests: - test/rbkt/zorba/json/json-snelson-serialize-object-03 - test/rbkt/zorba/json/json-snelson-serialize-array-12 added bug lp:920722 6) XQDoc issues: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq Added bug lp:920724 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920724] [NEW] json 2.0 bug: XQDoc issues
Public bug reported: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq ** Affects: zorba Importance: Medium Assignee: Paul J. Lucas (paul-lucas) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920724 Title: json 2.0 bug: XQDoc issues Status in Zorba - The XQuery Processor: New Bug description: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920724/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920722] [NEW] json 2.0 bug: comment nodes should be ignored by json:serialize
Public bug reported:
Comment nodes should be ignored by json:serialize function: please see failing
tests:
- test/rbkt/zorba/json/json-snelson-serialize-object-03
- test/rbkt/zorba/json/json-snelson-serialize-array-12
For instance, test json-snelson-serialize-object-03:
import module namespace json = "http://www.zorba-
xquery.com/modules/converters/json";
let $json :=
1
return json:serialize( $json )
returns
{,"a":1,}
instead of
{"a":1}
** Affects: zorba
Importance: Medium
Assignee: Paul J. Lucas (paul-lucas)
Status: New
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/920722
Title:
json 2.0 bug: comment nodes should be ignored by json:serialize
Status in Zorba - The XQuery Processor:
New
Bug description:
Comment nodes should be ignored by json:serialize function: please see
failing tests:
- test/rbkt/zorba/json/json-snelson-serialize-object-03
- test/rbkt/zorba/json/json-snelson-serialize-array-12
For instance, test json-snelson-serialize-object-03:
import module namespace json = "http://www.zorba-
xquery.com/modules/converters/json";
let $json :=
1
return json:serialize( $json )
returns
{,"a":1,}
instead of
{"a":1}
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/920722/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920720] [NEW] json 2.0 bug: error raised when passing invalid JSON option
Public bug reported:
When trying to parsing a valid JSON string with invalid JSON option parameter
the error raised is:
http://www.w3.org/2005/xqt-errors:XPST0003:
In order to raise a more useful error message saying that the options are not
set correctly.
Please note that setting the wrong options will happen very often due to the
changing of the way the options were set in JSON 1.0 and JSON 2.0.
For instance adding try{} catch {} inside the validation of the options
will do the trick.
Please see added failing test
test/rbkt/zorba/json/json-invalid-option-parameter
** Affects: zorba
Importance: Medium
Assignee: Paul J. Lucas (paul-lucas)
Status: New
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/920720
Title:
json 2.0 bug: error raised when passing invalid JSON option
Status in Zorba - The XQuery Processor:
New
Bug description:
When trying to parsing a valid JSON string with invalid JSON option parameter
the error raised is:
http://www.w3.org/2005/xqt-errors:XPST0003:
In order to raise a more useful error message saying that the options are not
set correctly.
Please note that setting the wrong options will happen very often due to the
changing of the way the options were set in JSON 1.0 and JSON 2.0.
For instance adding try{} catch {} inside the validation of the
options will do the trick.
Please see added failing test
test/rbkt/zorba/json/json-invalid-option-parameter
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/920720/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920721] [NEW] json 2.0 bug: wrong behavior for parsing empty value
Public bug reported: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 ** Affects: zorba Importance: Medium Assignee: Paul J. Lucas (paul-lucas) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920721 Title: json 2.0 bug: wrong behavior for parsing empty value Status in Zorba - The XQuery Processor: New Bug description: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920721/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920719] [NEW] json 2.0 bug: array and object closed prematurely in json:parse
Public bug reported:
the items object and array are closed prematurely when json:parse is called.
Please see added tests:
- json-snelson-parse-array-06
- json-snelson-parse-array-07
For instance the result of test json-snelson-parse-array-06:
import module namespace json = "http://www.zorba-
xquery.com/modules/converters/json";
json:parse('[
{
"firstName": "John",
"lastName": "Smith",
"address": {
"streetAddress": "21 2nd Street",
"city": "New York",
"state": "NY",
"postalCode": 10021
},
"phoneNumbers": [
"212 732-1234",
"646 123-4567"
]
},
{
"firstName": "John",
"lastName": "Smith",
"address": {
"streetAddress": "21 2nd Street",
"city": "New York",
"state": "NY",
"postalCode": 10021
},
"phoneNumbers": [
"212 732-1234",
"646 123-4567"
]
}]')
is
http://john.snelson.org.uk/parsing-json-into-xquery";
type="array"> [...]
instead of:
http://john.snelson.org.uk/parsing-json-into-xquery";
type="array"> [...] [...]
** Affects: zorba
Importance: Medium
Assignee: Paul J. Lucas (paul-lucas)
Status: New
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/920719
Title:
json 2.0 bug: array and object closed prematurely in json:parse
Status in Zorba - The XQuery Processor:
New
Bug description:
the items object and array are closed prematurely when json:parse is called.
Please see added tests:
- json-snelson-parse-array-06
- json-snelson-parse-array-07
For instance the result of test json-snelson-parse-array-06:
import module namespace json = "http://www.zorba-
xquery.com/modules/converters/json";
json:parse('[
{
"firstName": "John",
"lastName": "Smith",
"address": {
"streetAddress": "21 2nd Street",
"city": "New York",
"state": "NY",
"postalCode": 10021
},
"phoneNumbers": [
"212 732-1234",
"646 123-4567"
]
},
{
"firstName": "John",
"lastName": "Smith",
"address": {
"streetAddress": "21 2nd Street",
"city": "New York",
"state": "NY",
"postalCode": 10021
},
"phoneNumbers": [
"212 732-1234",
"646 123-4567"
]
}]')
is
http://john.snelson.org.uk/parsing-json-into-xquery";
type="array"> [...]
instead of:
http://john.snelson.org.uk/parsing-json-into-xquery";
type="array"> [...] [...]
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/920719/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920717] [NEW] json 2.0 bug: json:serialize(json:parse(VALID_JSON))
Public bug reported:
Should be possible to call json:serialize(json:parse(VALID_JSON))
where VALID_JSON is any valid JSON string
see added failing test test/rbkt/zorba/json/json-snelson-serialize-parse:
import module namespace
json="http://www.zorba-xquery.com/modules/converters/json";;
declare variable $json-value := '{"html":"bold"}';
json:serialize(json:parse($json-value))
** Affects: zorba
Importance: Medium
Assignee: Paul J. Lucas (paul-lucas)
Status: New
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/920717
Title:
json 2.0 bug: json:serialize(json:parse(VALID_JSON))
Status in Zorba - The XQuery Processor:
New
Bug description:
Should be possible to call json:serialize(json:parse(VALID_JSON))
where VALID_JSON is any valid JSON string
see added failing test test/rbkt/zorba/json/json-snelson-serialize-parse:
import module namespace
json="http://www.zorba-xquery.com/modules/converters/json";;
declare variable $json-value := '{"html":"bold"}';
json:serialize(json:parse($json-value))
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/920717/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
r10618 contains all the tests mentioned above. The tests are passing because they are marked as EXPECTED_FAILURES. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Why did you mark them as EXPECTED_FAILURE if they're not expected to fail? Presumably, you *want* them fixed, right? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
EXPECTED_FAILURE does *not* mean "negative test". It means "this is broken, we know it's broken, and we're working on it". That's why you have to supply a bug number to the macro. It probably should be renamed "KNOWN_BUG". -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
It means "known bug" for things that are in the trunk. If it's on a branch (as this is), then either (1) it will be fixed before it's merged into the trunk (at which point the EXPECTED_FAILURE will have to be removed since it will no longer be failing -- which begs my question of, "Why put it in in the first place?") or (2) the test will be deemed invalid and removed. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920724] Re: json 2.0 bug: XQDoc issues
** Branch linked: lp:~zorba-coders/zorba/feature-json_parser -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920724 Title: json 2.0 bug: XQDoc issues Status in Zorba - The XQuery Processor: In Progress Bug description: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920724/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920724] Re: json 2.0 bug: XQDoc issues
** Changed in: zorba Status: New => In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920724 Title: json 2.0 bug: XQDoc issues Status in Zorba - The XQuery Processor: In Progress Bug description: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920724/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Hmm... valid points. I think there's some value in using EXPECTED_FAILURE() anyway, since it documents the relationship to new bugs that are filed. It does introduce the possibility of unintentionally merging a new bug onto the trunk, but the diff will clearly show a new EXPECTED_FAILURE() marker and I would hope that any reviewer would raise a serious question about that. I guess I would say that it's probably unnecessary to add EXPECTED_FAILURE()s (and associated bugs) for small review comments. However, for anything which might reasonably take more than a few hours to fix, IMHO it's probably good practice just to help ensure that no issues get forgotten. In general I would leave that decision up to the team working on the branch in question, though. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
> It means "known bug" for things that are in the trunk. If it's on a branch > (as this is), then either (1) it will be fixed before it's merged into the > trunk (at which point the EXPECTED_FAILURE will have to be removed since it > will no longer be failing -- which begs my question of, "Why put it in in the > first place?") or (2) the test will be deemed invalid and removed. Paul, IMO: - adding some bugs on Launchpad - adding tests that fail and marking them as KNOWN_ISSUE (a.k.a. EXPECTED_FAILURES) was far better than adding a comment in your merge proposal. Keep in mind that I have spent my time in order to give you a hand in pointing out the issues I found. Adding separate bugs allows us to: - discussed the raised issues separately - make commits to fix them separately into the branch And to prove my point: you already wrote 2 comments *without* even looking over *any* of the issues I have raised. Anyway, I already committed a fix in the branch for bug lp:920724. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Chris Hillery wrote: "I think there's some value in using EXPECTED_FAILURE() anyway, since it documents the relationship to new bugs that are filed." The relationship to new bugs *from* ___? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Documents the relationship of the newly-added failing tests to the bugs tracking those issues. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
IMO, you didn't *need* to add any comment to the merge proposal other than "Bugs filed" -- I can read the bugs myself. Sorin wrote: "Keep in mind that I have spent my time in order to give you a hand in pointing out the issues I found." It's all of our job to review each others' code under the "New Order" so please don't act like it was a personal favor. I never questioned your adding separate bugs. For the record, I *like* separate bugs. I *only* questioned why you added EXPECTED_FAILURE for those bugs that, as I've pointed out, is unnecessary and not only creates more work for you (because you put them in) but more work for me (because I have to take them out). Sorin wrote: "And to prove my point: you already wrote 2 comments *without* even looking over *any* of the issues I have raised." *My* point has *nothing* to do with any bugs in particular. Chris understands my point. Do you? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
@Chris: Hmmm... again, because this is a branch and no Zorba user will ever see this stuff, it's at best only marginally useful. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Paul, let me ask you something: are you sure you are not missing the point? IMHO the point is to fix the issues that were raised ASAP. I have spent my time in order to give as many details as possible in order to fix them ASAP. Also I have committed a fix in the branch for one of the opened bugs. Please look over the bugs and let's try to fix them in order to commit the new improved JSON 2.0 module to the trunk. If you think that the decision I took while reviewing your merge deserves further discussion let's put it on the next weekly conference agenda. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
> IMO, you didn't *need* to add any comment to the merge proposal other than > "Bugs filed" -- I can read the bugs myself. FYI: Matthias asked me (in a separate email discussion) to add a small review of the issues I fount in the merge proposal: please take this issue with him. > Sorin wrote: "Keep in mind that I have spent my time in order to give you a > hand in pointing out the issues I found." > > It's all of our job to review each others' code under the "New Order" so > please don't act like it was a personal favor. OK, next time I will review your code I will simply add a one sentence in the merge proposal and keep adding comments because you clearly think this is better. > I never questioned your adding separate bugs. For the record, I *like* > separate bugs. I *only* questioned why you added EXPECTED_FAILURE for those > bugs that, as I've pointed out, is unnecessary and not only creates more work > for you (because you put them in) but more work for me (because I have to take > them out). I will never do this again. > Sorin wrote: "And to prove my point: you already wrote 2 comments *without* > even looking over *any* of the issues I have raised." > > *My* point has *nothing* to do with any bugs in particular. Chris understands > my point. Do you? No, I do not. IMHO you are missing the point, that is: let's try to fix the *bugs* and discuss the procedures later. Do you understand my point? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
No, the point is *not* to fix this issues ASAP. The feature is not a high-priority feature, so there's no reason to do this ASAP. My *only* point was why you added EXPECTED_FAILURE lines to the CMakeLists.txt file -- that's it. But it's moot now since I've removed all the new EXPECTED_FAILURES that you've added. They're of no use to me. Now when I run the test suite and it reports 100% tests passed, I can be confident that I've fixed all the bugs and not have an errant EXPECTED_FAILURE in there. In the future, please don't add EXPECTED_FAILURE lines to code on a *branch* -- thanks. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
Chris Hillery has proposed merging lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 The test case sc3_ex3 depends on the non-core JSON module. This non-core module is being removed (to be replaced by a new core JSON module), but obviously doing so causes this core test case to fail. So, we need to remove the test case temporarily to successfully merge the non-core module change. It will be re-enabled along with the merge of the core JSON module. -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'test/update/Queries/zorba/store/sc3.spec' --- test/update/Queries/zorba/store/sc3.spec 2011-08-06 00:15:24 + +++ test/update/Queries/zorba/store/sc3.spec 2012-01-24 00:53:28 + @@ -1,5 +1,3 @@ State: sc3_ex1 Args: -x input-context:=$UPDATE_SRC_DIR/Queries/zorba/store/meat_poultry.csv State: sc3_ex2 -State: sc3_ex3 -Compare sc3_ex3.xml.res Text -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
Review: Approve I'll take your word for it. -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/disable-sc3-test-2012-01-24T01-02-59.785Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
> No, the point is *not* to fix this issues ASAP. The feature is not a high- > priority feature, so there's no reason to do this ASAP. My *only* point was > why you added EXPECTED_FAILURE lines to the CMakeLists.txt file -- that's it. > > But it's moot now since I've removed all the new EXPECTED_FAILURES that you've > added. They're of no use to me. Now when I run the test suite and it reports > 100% tests passed, I can be confident that I've fixed all the bugs and not > have an errant EXPECTED_FAILURE in there. > > In the future, please don't add EXPECTED_FAILURE lines to code on a *branch* > -- thanks. My 2 cents: no matter what the brief description of the "ctest -R SOME_TEST" shows, one should *always* check out the details inside the ctest logs. http://en.wikipedia.org/wiki/The_Devil_is_in_the_details -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920720] Re: json 2.0 bug: error raised when passing invalid JSON option
Your test in illegal XQuery: you need a "return" before the
json:parse(). Once the "return" is added, the test fails with an invalid
schema validation error which is correct.
This test wrong and this bug is bogus and should be closed.
** Changed in: zorba
Status: New => Invalid
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/920720
Title:
json 2.0 bug: error raised when passing invalid JSON option
Status in Zorba - The XQuery Processor:
Invalid
Bug description:
When trying to parsing a valid JSON string with invalid JSON option parameter
the error raised is:
http://www.w3.org/2005/xqt-errors:XPST0003:
In order to raise a more useful error message saying that the options are not
set correctly.
Please note that setting the wrong options will happen very often due to the
changing of the way the options were set in JSON 1.0 and JSON 2.0.
For instance adding try{} catch {} inside the validation of the
options will do the trick.
Please see added failing test
test/rbkt/zorba/json/json-invalid-option-parameter
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/920720/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
Validation queue job disable-sc3-test-2012-01-24T01-02-59.785Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/disable-sc3-test into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 -- https://code.launchpad.net/~zorba-coders/zorba/disable-sc3-test/+merge/89809 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
The proposal to merge lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/remove_old_json-2012-01-24T01-34-37.367Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920721] Re: json 2.0 bug: wrong behavior for parsing empty value
Renamed the tests to conform to all the rest, i.e., contain "parse" or "serialize" in the test name. Also, again, the second test is invalid XQuery since it's missing a "return". -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920721 Title: json 2.0 bug: wrong behavior for parsing empty value Status in Zorba - The XQuery Processor: New Bug description: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920721/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920721] Re: json 2.0 bug: wrong behavior for parsing empty value
These functions are declared as taking an xs:string? as an argument. If one is able to pass something like (which is not a string), then it points to a bug elsewhere in the code, i.e., something should have checked that the actual argument type doesn't match the declared argument type -- right? If so, that's not my code. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920721 Title: json 2.0 bug: wrong behavior for parsing empty value Status in Zorba - The XQuery Processor: New Bug description: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920721/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920721] Re: json 2.0 bug: wrong behavior for parsing empty value
What specification tells you that parsing an empty value should return an error? Why isn't returning nothing valid? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920721 Title: json 2.0 bug: wrong behavior for parsing empty value Status in Zorba - The XQuery Processor: New Bug description: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920721/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
Validation queue job remove_old_json-2012-01-24T01-34-37.367Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module
The proposal to merge lp:~zorba-coders/zorba/remove_old_json into lp:zorba/data-converters-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 -- https://code.launchpad.net/~zorba-coders/zorba/remove_old_json/+merge/89770 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 920721] Re: json 2.0 bug: wrong behavior for parsing empty value
The JSON grammar is not as pedantic as I would like, but it looks like a JSON text must be exactly an object or an array. http://tools.ietf.org/html/rfc4627 So an empty string is not a valid instance of JSON. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/920721 Title: json 2.0 bug: wrong behavior for parsing empty value Status in Zorba - The XQuery Processor: New Bug description: Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value For instance in zorba/json/json-snelson-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; json:parse() Should raise error(s) http://www.zorba-xquery.com/errors:ZJPE0001 But instead Zorba returns a result. For test/rbkt/zorba/json/json-jsonml-empty-value.xq: import module namespace json = "http://www.zorba-xquery.com/modules/converters/json";; let $options := http://www.zorba-xquery.com/modules/converters/json-options";> json:parse(,$options) Zorba returns http://www.w3.org/2005/xqt-errors:XPST0003 instead of http://www.zorba-xquery.com/errors:ZJPE0001 To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/920721/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
