Review: Needs Information
The module itself looks OK at a quick glance. However, unless I'm missing
something, I don't think this needs to be a core module. It should be a
non-core module in a separate branch.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Given the comments I received for the http-module I fear that the way I am
disconnecting from cloudant is not correct, because curl_global_init/cleanup
must not be called multiple times from different modules.
I tried disconnecting invoking an XQuery function but this does not work
because the
Review: Needs Fixing
Actually, a few code problems:
1. ConnectionMap::destroy() invokes a function in the
http://28msec.io/modules/cloudant namespace. I think that should be in
http://zorba.io/modules/cloudant, right?
2. The files in cloudant.xq.src have 28msec copyright notices.
3. I think
Ahh, I see, that call in ConnectionMap::destroy() is commented out. Didn't
notice that the first time.
Regarding the curl disconnect problems: That would all go away if this module
used the http-client module, rather than using C++ to invoke CURL directly. Is
there a reason this module
Hi Chris,
thanks for the quick review.
I think it is currently a core module due to the auto-disconnect functionality.
External module can have cpp external functions?
However, as I wrote in my previous comment, this feature is almost certainly
wrong at the moment.
If I recall correctly,
Actually, a few code problems:
1. ConnectionMap::destroy() invokes a function in the
http://28msec.io/modules/cloudant namespace. I think that should be in
http://zorba.io/modules/cloudant, right?
This is commented out :) I tried doing it in XQuery but I didn't manage so I
left the code
Ahh, I see, that call in ConnectionMap::destroy() is commented out. Didn't
notice that the first time.
Regarding the curl disconnect problems: That would all go away if this module
used the http-client module, rather than using C++ to invoke CURL directly. Is
there a reason this module
Yes, non-core modules can have C++ external functions; take a look at the
process module, for instance.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Description changed to:
Depends on
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
.
For more details, see:
Review: Needs Information
Since in its current state this module depends on CURL i made a single search
for the
CURL library and moved both the ADD_DIRECTORY(http-client) and
ADD..(cloudant) inside
the same check. The http client cmakelist doesn't do the search again.
Aha! Now I see what
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
You didn't actually create singleton zorba::Items for the JSON object key
strings. Using C++ #defines isn't the same. This code will still create a
separate zorba::Item for the string name for every single entry in every
archive passed to a:entries().
--
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Commit Message changed to:
Updated the expath http client on top of the json http client
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Commit Message changed to:
Updated the expath http client to use the json http client
For more details, see:
I've fixed the crash and added the query as zorba/eval/eval16.xq.
--
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
I don't understand why. In my example it wouldn't. The count functions could
count
the number of empty objects or objects that contain only the STREET field.
I've looked into the test and here are the issues:
1) The fn:count() does not have the %explores-json annotation. I've confused it
with
I agree that an external module is best suited for this module.
I will look in the wiki to see the submit procedure.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Ok, it wasn't too much work -- I've added a special handler for fn:count() in
the dataguide code and now the example you gave prunes all the fields except
price.
--
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch
I meant the STREET field. I've used price in the testcase.
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
I have no idea what problem this MP is supposed to solve; nor do I know what a
data guide is.
Paul, I've made some changes to the JSON loader so that it skips creating nodes
that are not in a given template (== dataguide). Since you've written the
loader, could you please review only the
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Review: Needs Information
I don't understand why. In my example it wouldn't. The count functions could
count
the number of empty objects or objects that contain only the STREET field.
I've looked into the test and here are the issues:
1) The fn:count() does not have the %explores-json
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage AddTestSuitesUbuntu failed.
Check console output at
http://jenkins.lambda.nu/job/AddTestSuitesUbuntu/125/console to view the
results.
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~zorba-coders/zorba/bug-1189801 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
--
Review: Approve
Yes, we cannot JSONify the EXPath module. More than that, this processing
depends on XML data formats for which it doesn't make sense to do it on JSON
because the input data is XML and people want to process that.
A JSONiq geo module would be a completely separate effort. Right
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/update3.0_string-module into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Stage TestZorbaUbuntu failed.
13 tests failed (8416 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/127/testReport/ to view the
results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
Your team Zorba
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1189801 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189801/+merge/176621
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
--
The way I see this is not a problem with the fn functions. The problem is
related to the fact how the objects are used. In this case, the objects are
used to construct a new object. The dataguide needs to handle that. Similar to
serialization, this means that the entire object is needed.
Yes,
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/skip-items into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/update3.0_geoproj-module into
lp:zorba/geoproj-module has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
--
Is there an easier way to do what's currently shown on lines 1309-1317 of the
diff, i.e., ask Is this atomic item *any* form of string?
Is there an easier way to do what's currently shown on lines 1407-1433 of the
diff, i.e., ask, Is this atomic type compatible with JSON?
Is there an easier
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233
Your team Zorba
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233 :
Votes: {'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1200090/+merge/177233
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/65/console to
view the results.
--
You didn't actually create singleton zorba::Items for the JSON object key
strings. Using C++ #defines isn't the same. This code will still create a
separate zorba::Item for the string name for every single entry in every
archive passed to a:entries().
I used #defines only for the strings that
56 matches
Mail list logo
