The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your team Zorb
Validation queue job mytrunk-2011-11-30T06-46-22.579Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Po
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/mytrunk-2011-11-30T06-46-22.579Z/log.html
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://l
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Commit Message changed to:
fn:analyze-string fix
also, adding config.h include to ensure correct error messages
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
--
h
Review: Approve
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Review: Approve
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
Your tea
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/83210
fn:analyze-string fix
Also removed
Looks like it needs another merge from the trunk, then hopefully it will go
through.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@l
Yes, it would compile, but with the wrong error messages. The way Paul
implemented it, it doesn't raise compile errors if the error messages are
incorrect. I don't know if it raises runtime errors.
So that include is necessary right now, it was necessary for some time ago.
--
https://code.launch
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your tea
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@li
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Commit Message changed to:
fn:analyze-string fix
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/7
Review: Approve
I still don't understand the #include situation. Clearly dict_en.cpp is not
*yet* using ZORBA_NO_FULL_TEXT or else it wouldn't compile. What I'm guessing
is that there is some other change coming from somewhere else which depends on
having that #include. If so, IMHO then the #in
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your tea
Review: Approve
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
> Sorry, I still don't understand why you added the zorba/config.h include. I
> was able to fix the included test case locally by doing only the change in
> strings_impl.cpp; it doesn't seem like the dict_XX_cpp.xq change is related at
> all. And I still think that adding that #include is a bad ide
True, that change is not related to fn:analyze-string.
It only solves the error messages included inside #if defined.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-cod
Sorry, I still don't understand why you added the zorba/config.h include. I was
able to fix the included test case locally by doing only the change in
strings_impl.cpp; it doesn't seem like the dict_XX_cpp.xq change is related at
all. And I still think that adding that #include is a bad idea unl
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165
fn:analyze-string fix
Also removed
There are a lot of #if defined and #if !defined in that file.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsub
But it doesn't look like like you're using any such settings here...?
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.n
The #include is necessary to have access to zorba settings.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubsc
Review: Needs Information
Still wondering what the #include additions are about. They
don't seem related or necessary...
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zor
Review: Approve
I approve the fix but it has merge conflicts in the ChangeLog.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.l
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79120
fn:analyze-string fix
Also removed
Review: Needs Fixing
IMHO, path_to_uri.xq / .spec / .xml.res shouldn't be checked in with this
change, since it's not related to the bug being fixed. path_to_uri.spec isn't
relevant and shouldn't be checked in at all, since the variable $input-context
it declares isn't used by path_to_uri.xq.
See bug https://bugs.launchpad.net/zorba/+bug/868329
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78996
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Information
What is the file test/rbkt/Queries/zorba/resolving/path_to_uri.xq supposed to
test. It imports the file module but doesn't use it.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78996
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Maili
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78996
fn:analyze-string fix
--
https://code.launchpad.net/~danielturcanu/zor
It looks like all the absolute path changes are still in there...
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78621
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
U
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78621
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78621
Your tea
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78621
Removed changes for URI, left only
So you propose a function like file:resolve-path-to-uri($baseUri, $filePath) ?
I guess it's fine too.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78253
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
Sorry, but we implement a spec. You've suggested at least two changes which
would break our compliance with that spec, so I don't have much choice but to
quote the spec back at you.
It sounds like what you want would be best served by an extension to the Expath
file module. As I said in my prev
Please stop giving arguments from the spec. I also know the spec.
I am trying to come with a solution to the problem. This problem cannot be
solved by sticking to the spec.
So I want like this: have a variable that contains an absolute or relative file
system path, and resolve it to a base absol
HTTP and FTP URIs certainly don't work with filesystem paths. File: URIs only
do by convention, and there are (somewhat hand-wavy) rules for mapping
filesystem paths to file: URIs. But a filesystem path is-not-a file: URI, and
so a filesystem path is never an appropriate argument for fn:resolve-
Maybe W3C doesn't care about file systems, but URIs do.
At least http, ftp and file all work with file system paths. We actually work
with URL, not URI, we don't have general URIs so far.
I tested now file:path-to-uri and it doesn't do what I want: if I give it an
absolute path, then it returns
The W3C doesn't care about filesystems. :) encode-for-uri() just escapes
illegal characters in URIs.
Fortunately, EXPath cares: the File module has functions to go back and forth.
file:path-to-uri() converts a filesystem path to a file: URI, and
file:path-to-uri() (which is a bit oddly named) d
Ok, I guess you are right. I reread again the URI spec and it doesn't say
anything about Windows paths.
But how to transform Windows filepaths into file URI in a OS independent way?
There is another function fn:encode-for-uri, which is supposed to encode a path
to be used as uri, but that isn't p
The path component of a file: URI on Windows can contain C:/ (or C%3A/), but
that's not directly relevant.
fn:resolve-uri() works with exactly URIs. It is not defined to accept
filesystem paths. Thus, if the input is "C:/foo", it will interpret that
strictly as a URI (and most likely fail since
For Windows, the absolute path for URI is still in the form C:/, only that it
looks like C3A/.
At least for file:// scheme. I guess I should add a check only for that scheme.
About absolute and relative paths in URI, think about what fn:resolve-uri works
with. It can receive a relative path, or
Review: Disapprove
This isn't a good fix. The "path" of a URI isn't a filesystem path; it's a
specific part of a URI (see RFC 3986). The path portion of a URI cannot be
"absolute" or "relative". So it doesn't make sense to have this functionality
in the URI class.
fn:resolve-uri() is not suppo
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78253
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78253
Your tea
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78253
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+m
Review: Needs Fixing
See comment recently made.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78110
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : http
Please open two bugs for this and link the bug numbers from the ChangeLog.
Also, please describe (or mention the bugs) in the commit message. We already
went back and forth with URI fixes plenty of times and it's very confusing if
it's unclear which scenario your commit is supposed to fix.
--
h
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/78110
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+m
Daniel, which test does the URI change fix? I don't see a test for that and
it's not mentioned in the ChangeLog. Same for analyze-string.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Your team Zorba Coders is requested to review the proposed merge of
lp:~danielturcanu/
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Your tea
Voting does not meet specified criteria. Required: Approve > 0, Disapprove < 1.
Got: 1 Pending.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Your team Zorba Coders is requested to review the proposed merge of
lp:~danielturcanu/zorba/mytrunk into lp:zorba.
--
Mailing
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Your tea
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Your tea
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/mytrunk into
lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76577
Various fixes
--
https://code.launchpad.net/~danielturcanu/zorba/mytru
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76556
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76556
Your tea
Voting does not meet specified criteria. Required: Approve > 0, Disapprove < 1.
Got: 1 Pending.
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76556
Your team Zorba Coders is requested to review the proposed merge of
lp:~danielturcanu/zorba/mytrunk into lp:zorba.
--
Mailing
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76556
--
https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/76556
Your tea
57 matches
Mail list logo
