On Fri, 2012-11-09 at 15:34 +0100, Patrick Ohly wrote: > On Wed, 2012-11-07 at 10:15 +0100, Daniel CLEMENT wrote: > > Now for the autosync part. The localization of the notification messages > > appears to be addressed in fr.po, e.g.: > > --- > > #. if sync is successfully started and done > > #: ../src/syncevo-dbus-server.cpp:6670 > > #, c-format > > msgid "%s sync complete" > > msgstr "Synchronisation %s terminée" > > --- > > but, for some reason, the translated strings don't make it into my > > notification messages (Linux Mint, Debian, XFCE). I wonder if it's an > > XFCE issue: do other users get their notifications translated? > > No, that seems to be completely broken. I wonder whether no-one has ever > used auto syncing or whether not having translated messages was accepted > as normal. > > The explanation is simple: localization was used, but never turned on in > the synevo-dbus-server, the process which creates these notifications. I > have a fix (and a unit test).
It turned out that this explanation is wrong: localization was turned on, just not in the place where I was expecting it to be. It is done inside a helper class, NotificationBackendLibnotify::init(), and not in main(). That means that I am still unsure why messages were not translated correctly for you. I was able to reproduce it, but I probably did it wrong when testing manually (syncevolution.mo not installed, for example) and the automated test couldn't work (because the path to syncevolution.mo has to be specified, which wasn't possible). Daniel, can you run strace -e trace=file <path>/syncevo-dbus-server | grep 'syncevolution\.mo' when syncevo-dbus-server is not already running? Does it find the translated messages? -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
