Hey Jerry,

Does this address this comment in 6621020:

This appears to point out at least one bug in zlogin, namely that it
keeps stdout_pipe[1] and stderr_pipe[1] from noninteractive_login()
open when returning to the parent.

Basically, I think the filer expected to see something like:


        if (fork() == 0) {
                /* in child, close pipe sides read by parent) */

                .. write to std*[1]...
        /* in parent, close pipe sides written by child */

        ... read from std*[0] ...

I think the "in child" part is handled by the closefrom on line 1559, but
the parent does not close the sides of the pipes that the child writes to.


On Tue, May 27, 2008 at 08:48:17AM -0600, Jerry Jelinek wrote:
> I have updated the webrev at:
> http://cr.opensolaris.org/~gjelinek/webrev/
> This includes the changes for the feedback I have
> received so far.  I also added the zlogin.c file
> to the webrev with two bug fixes.  One of these was for
> a bug I was hitting during testing of these changes
> and there is a second bug in zlogin that came in
> which I also fixed.  So, at a minimum, it would be
> good to take a look at that additional file.
> Thanks,
> Jerry
> _______________________________________________
> zones-discuss mailing list
> zones-discuss@opensolaris.org
zones-discuss mailing list

Reply via email to