Re: [chromium-dev] How to rebuild after modifying extension_api.json?

2010-01-15 Thread Evan Martin
On Fri, Jan 15, 2010 at 9:19 AM, Dominic Mazzoni dmazz...@google.com wrote: I've observed that after modifying extension_api.json and rebuilding on Linux (using make via distcc), often the entire extension api stops working, with no error message. A clean build always solves the problem. Is

Re: [chromium-dev] How to rebuild after modifying extension_api.json?

2010-01-15 Thread Evan Martin
On Fri, Jan 15, 2010 at 9:57 AM, Thomas Van Lenten thoma...@chromium.org wrote: Actually, it think it's sorta captured -- chrome.gyp has chrome_resources_inputs, which is created by running a script to figure out the input from the grd files.  Looking at my xcode project, there is a dependency

Re: [chromium-dev] Re: Setting global preferences/settings in code

2010-01-14 Thread Evan Martin
On Thu, Jan 14, 2010 at 1:33 PM, Brian G. Merrell bgmerr...@gmail.com wrote: Okay, I started looking into this.  After a bit of work, I'm to the point where I need to process the master_preferences json file. That is, I am currently writing a ProcessMasterPreferences function in

[chromium-dev] [linux] printing webcore strings in gdb

2010-01-14 Thread Evan Martin
We had a section of our wiki page with a GDB trick for printing webcore types. I just cleaned up and checked in that code. The wiki now just has the recipe on how to source this file into your GDB. It's easy, and now my GDB can display WebCore::AtomicString, UChar*, etc. as nice Unicode strings!

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Evan Martin
On Wed, Jan 13, 2010 at 9:22 AM, Mark Mentovai m...@chromium.org wrote: Dan Kegel wrote: On Wed, Jan 13, 2010 at 9:12 AM, Stephen White senorbla...@chromium.org wrote: 2)  Most of the supposed performance advantage of strict aliasing rules is probably taken care of by memory disambiguation

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Evan Martin
On Wed, Jan 13, 2010 at 11:00 AM, Peter Kasting pkast...@google.com wrote: On Wed, Jan 13, 2010 at 10:53 AM, Craig Schlenter craig.schlen...@gmail.com wrote: I'm one try-server run away from possibly turning -fno-strict-aliasing on for all linux/bsd gcc: http://codereview.chromium.org/519034

[chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-12 Thread Evan Martin
In this bug http://code.google.com/p/chromium/issues/detail?id=28749 It seems we're running afoul of a more finicky compiler not liking some tricks we're playing with objects and memory in LazyInstance. (You can skip down to comment #30 or so to get to the meat of it -- above that point we were

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

2010-01-12 Thread Evan Martin
On Tue, Jan 12, 2010 at 10:17 AM, Brett Wilson bre...@chromium.org wrote: I imagine the problems on Linux are the same as they were on Windows, where the underlying graphics layer wants to place glyphs aligned on pixel boundaries. This gives rounding problems and the letters jump around. I

Re: [chromium-dev] Where does documentation intended for non-developers go?

2010-01-08 Thread Evan Martin
On Thu, Jan 7, 2010 at 7:44 PM, Nico Weber tha...@chromium.org wrote: On Thu, Jan 7, 2010 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Jan 7, 2010 at 2:31 PM, Nico Weber tha...@chromium.org wrote: I wrote up a document that's relevant not only for people working on chromium

Re: [chromium-dev] Where does documentation intended for non-developers go?

2010-01-07 Thread Evan Martin
On Thu, Jan 7, 2010 at 2:31 PM, Nico Weber tha...@chromium.org wrote: I wrote up a document that's relevant not only for people working on chromium, but for (small parts of) the world in general (under which circumstances does google chrome display idn urls as punycode? I mean, who's not dying

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

2010-01-05 Thread Evan Martin
On Tue, Jan 5, 2010 at 2:44 PM, Glen Murphy g...@chromium.org wrote: I don't think anyone has any objection to DOMUIifying those pages, and I don't think it would be a large amount of work. The only reason they're not is that there hasn't been a reason to do so. DOM UI (at least when I last

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

2010-01-05 Thread Evan Martin
directory listing pages? It just seems to me that it would be rather redundant handle 3 separate instances of a file browse HTML page (ftp://, file:// and chrome://filebrowse) in 3 separate ways. Thanks. 2010/1/5 Evan Martin e...@chromium.org On Tue, Jan 5, 2010 at 2:44 PM, Glen Murphy g

Re: [chromium-dev] chromium crash when load flash plugin

2010-01-04 Thread Evan Martin
On Mon, Jan 4, 2010 at 3:38 PM, Peter Kasting pkast...@google.com wrote: On Mon, Jan 4, 2010 at 3:35 PM, if-ifone hello...@gmail.com wrote: Hi:      I build a Release chromium from latest trunk code.my Chromium always crash when page contain flash elements. on ubuntu 9.10 intel 32 build

Re: [chromium-dev] Shockwave and Flash high CPU usage

2010-01-03 Thread Evan Martin
On Sun, Jan 3, 2010 at 8:47 AM, ptr727 pieter.vilj...@gmail.com wrote: Hi, don't know if this is the right group, please redirect if not. I think the best forum is the bug tracker. In general, for Flash performance, if you have (1) something that performs significantly differently in Chrome than

Re: [chromium-dev] Any reason why we can't use Google's codesearch in chromium code base?

2010-01-01 Thread Evan Martin
On Fri, Jan 1, 2010 at 1:23 AM, Mohamed Mansour m0.interact...@gmail.com wrote: Hi everyone, first I want to say Happy New Years! For the last year, it was very easy and super fast searching the code base of Chromium via http://www.google.com/codesearch, everything was there. Codesearch gave

Re: [chromium-dev] Any reason why we can't use Google's codesearch in chromium code base?

2010-01-01 Thread Evan Martin
On Fri, Jan 1, 2010 at 10:05 AM, Mohamed Mansour m0.interact...@gmail.com wrote: Or even something that was deleted from our current state that still exists there: http://www.google.com/codesearch?q=package:http://src.chromium.org/svn/trunk/src+kEnableWebSockets That happens to everything. It

[chromium-dev] [linux] new shm drawing code, watch for glitches

2009-12-30 Thread Evan Martin
tl;dr I just landed a change that may improve drawing performance. Because the code path depends on the machine, it is difficult to test that I didn't break anything. Please let me know if you notice a drawing speed difference in Chrome builds after r35390/35392 (latter was a build fix for the

Re: [chromium-dev] [linux] new shm drawing code, watch for glitches

2009-12-30 Thread Evan Martin
On Wed, Dec 30, 2009 at 3:02 PM, Chris Evans cev...@google.com wrote: I'm interested in a breakdown here. Is it dependent on X server version? (e.g. can you say Ubuntu version 9.10+ has it)? Or is it more subtle, involving exact gfx chipset and proprietary vs. X.org drivers? The latter, I

Re: [chromium-dev] [linux] new shm drawing code, watch for glitches

2009-12-30 Thread Evan Martin
On Wed, Dec 30, 2009 at 3:21 PM, Evan Martin e...@chromium.org wrote: On Wed, Dec 30, 2009 at 3:02 PM, Chris Evans cev...@google.com wrote: I'm interested in a breakdown here. Is it dependent on X server version? (e.g. can you say Ubuntu version 9.10+ has it)? Or is it more subtle, involving

Re: [chromium-dev] Command Line switches persisted in Preferences

2009-12-24 Thread Evan Martin
On Thu, Dec 24, 2009 at 12:29 PM, Peter Kasting pkast...@google.com wrote: Yes: It allows/encourages people to use more command-line switches.  The switches we have are generally for exceptional cases.  If people need to use them regularly, we need to know about it, not simply enable even more

Re: [chromium-dev] Link error with chromium on ubuntu 9.10

2009-12-20 Thread Evan Martin
On Sat, Dec 19, 2009 at 5:39 PM, Jacob Mandelson ja...@mandelson.org wrote: Probably the OOM killer.  Chrome takes a very large amount of memory to link. You can add some swap, or trade a lot of link-time memory for a little startup delay by building shared.  You can do that by putting this in

Re: [chromium-dev] Re: Setting global preferences/settings in code

2009-12-20 Thread Evan Martin
On Sat, Dec 19, 2009 at 9:32 PM, cpu c...@chromium.org wrote: Yes, the MasterPreferences is what we use so far.  It is just a json file in a particular path. I am not sure if we have enabled this for the linux build. It hasn't. See browser_main.cc around line 540, the part that mentions

Re: [chromium-dev] Linux 32-bit build instructions

2009-12-19 Thread Evan Martin
On Sat, Dec 19, 2009 at 6:59 AM, Kevin Millikin kmilli...@chromium.org wrote: I'm trying to build Linux 32-bit on 64-bit Ubuntu 8.04. The closest think I've found is http://code.google.com/p/chromium/wiki/LinuxBuild32On64 , but unless I'm just missing it, that doesn't seem to have actual build

Re: [chromium-dev] Linux 32-bit build instructions

2009-12-19 Thread Evan Martin
On Sat, Dec 19, 2009 at 7:06 AM, Evan Martin e...@chromium.org wrote: On Sat, Dec 19, 2009 at 6:59 AM, Kevin Millikin kmilli...@chromium.org wrote: I'm trying to build Linux 32-bit on 64-bit Ubuntu 8.04. The closest think I've found is http://code.google.com/p/chromium/wiki/LinuxBuild32On64

Re: [chromium-dev] Running multiple Google Chrome channels side-by-side (for testing)

2009-12-18 Thread Evan Martin
It's not quite the same thing, but run both Google Chrome (for the beta channel) and the Ubuntu Chromium (for testing nightly builds). You might be able to do a similar thing with one of the variants on Windows (like, say, run Google Chrome beta channel and then a more recent version of Iron).

Re: [chromium-dev] Implementing the Chromium Webkit API

2009-12-18 Thread Evan Martin
On Fri, Dec 18, 2009 at 10:32 AM, Balaji Rao balajir...@gmail.com wrote: I'm new to this list and I've joined after my discovery of the new Chromium WebKit API. Great work, it's awesome. It's very new, so don't expect it to all quite work yet. I tried to compile a really stupid implementation

Re: [chromium-dev] [extensions] bug gardening, stable version

2009-12-16 Thread Evan Martin
On Mon, Dec 14, 2009 at 6:13 PM, Aaron Boodman a...@chromium.org wrote: I've gone through and gardened the bugs per our goals for stable: Win, linux: http://bit.ly/5s4lrp Mac: http://bit.ly/8hHpdO Surely I'm missing some, but this should be a start. I know you had to decide to boot some

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline -open-in-new-window switch

2009-12-16 Thread Evan Martin
On Tue, Dec 15, 2009 at 4:45 PM, Evan Stade est...@chromium.org wrote: a) We don't have good support for untabbed browsing; if we really wanted to support that we should have a --no-tabs mode which removes the tab strip and forces NEW_TAB to NEW_WINDOW, but I don't think we want to support it.

Re: [chromium-dev] Re: Proposal: Accessibility extension api

2009-12-16 Thread Evan Martin
(Disclaimer: I know very little about a11y.) On Wed, Dec 16, 2009 at 10:20 PM, Erik Kay erik...@chromium.org wrote: On Wed, Dec 16, 2009 at 1:15 PM, Dominic Mazzoni dmazz...@google.com This experimental API exposes information about focused controls in the native ui, like dialog boxes and the

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline -open-in-new-window switch

2009-12-12 Thread Evan Martin
On Sat, Dec 12, 2009 at 1:01 AM, Peter Kasting pkast...@google.com wrote: On Sat, Dec 12, 2009 at 12:54 AM, Clemens Fruhwirth clem...@endorphin.org wrote: http://codereview.chromium.org/464060 adds the small one-line feature to open an URL in a new window from commandline I wonder if you

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Evan Martin
On Sat, Dec 12, 2009 at 4:52 AM, Satoru Takabayashi sato...@chromium.org wrote: The chrome binary for Linux seems to load resource bundles from a file named chrome.pak, while the resource booundles are embedded in the chrome DLL in other platforms (correct me if I'm wrong). This makes me wonder

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

2009-12-11 Thread Evan Martin
On Fri, Dec 11, 2009 at 9:56 AM, Darin Fisher da...@chromium.org wrote: The goal is to annoy you so you will try to stop passing these arguments.  Don't we already have other infobars possibly showing at startup (e.g., restore tabs)? Yes. It looks a little silly -- you get two of them stacked

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-10 Thread Evan Martin
On Thu, Dec 10, 2009 at 1:02 PM, oshima osh...@chromium.org wrote: I have similar concern about our build, in a way we handle different configurations. There are several ways to specify a set of files for different configurations, such as suffic (_gtk/_mac), source!, exclude/include, concat

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Evan Martin
On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman a...@chromium.org wrote: If we had something like: plugins: { mac: ... win: ... linux: ... } FWIW, one reason to avoid this sort of thing is that there is really no single thing called linux to target. For example, because our builds of

Re: [chromium-dev] Can't build r34152

2009-12-09 Thread Evan Martin
Try pasting a subphrase of that into a search engine. :) On Wed, Dec 9, 2009 at 6:55 AM, Gary Thomas samoht.y...@gmail.com wrote: Fedora Linux host: make: *** No rule to make target `third_party/yasm/source/patched-yasm/ modules/arch/x86/gen_x86_insn.py', needed by `out/Debug/obj/gen/

Re: [chromium-dev] Plugin Manager UI Proposal

2009-12-08 Thread Evan Martin
On Mon, Dec 7, 2009 at 11:11 AM, Panayiotis panayio...@google.com wrote: A plugin is identified by its path in the filesystem. Different paths are considered different plugins. Can you discuss symlinks? We have to do some weird hacks in this area -- see webkit/glue/plugins/plugin_list_linux.cc

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Evan Martin
On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username /

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Evan Martin
On Tue, Dec 8, 2009 at 12:23 PM, Igor Gatis igorga...@gmail.com wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? On Linux, when you run make it will rerun gyp on your behalf if any gyp files

Re: [chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?

2009-12-08 Thread Evan Martin
I got through my mail backlog far enough to at least file a bug on this http://code.google.com/p/chromium/issues/detail?id=29230 so you can star that for updates. On Thu, Sep 17, 2009 at 9:42 AM, --v1c1ous-- v1c1ous...@gmail.com wrote: I use a Search engine too:

Re: [chromium-dev] event.target is a copy of the element and doesn't validate with an equality test Options

2009-12-05 Thread Evan Martin
Generally, the decision tree for this sort of thing is: 1) Does it also happen in Firefox and IE? If yes: not a bug. 2) Does it happen in one of Firefox or IE? If yes: probably not a bug, might wanna bring it up if the behavior seems really broken. 3) Does it happen in Safari but not Firefox/IE?

Re: [chromium-dev] Re: Something smells weird on the buildbot

2009-12-04 Thread Evan Martin
On Thu, Dec 3, 2009 at 1:09 PM, Tei oscar.vi...@gmail.com wrote: Chromium is kind of awesome, but on my Ubuntu crash a bit too much. I am looking forward for a stable version. Dudes!, speed the thing. Will be this thing in the hoven for much longer? I grown impatient. This is the wrong place

Re: [chromium-dev] Information about revisions

2009-12-02 Thread Evan Martin
It works for me. Anton, are you perhaps using Linux Chrome in a locale where decimals are written like 1,23? WebKit has a number of bugs in that area -- it'd be helpful to reduce the problem you're encountering to a test case. See e.g. https://bugs.webkit.org/show_bug.cgi?id=30342 and others. On

Re: [chromium-dev] Design doc: Geolocation

2009-12-01 Thread Evan Martin
On Tue, Dec 1, 2009 at 4:13 PM, Glen Murphy g...@chromium.org wrote: 1) Why green?  The other infobars in the product are yellow. Historically, green in browsers has signaled extended validation. We had intended to use a few differently-colored infobars for a while, but a more recent

Re: [chromium-dev] Symbolized backtrace on Linux chromium?

2009-11-30 Thread Evan Martin
On Mon, Nov 30, 2009 at 9:37 AM, Chris Bentzel cbent...@google.com wrote: When DCHECK's trigger on my debug chromium build, I get an unsymbolized stacktrace like [7036:25234:31462940569:FATAL:net/ocsp/nss_ocsp.cc(251)] Check failed: !request_.

Re: [chromium-dev] Use of external libICU

2009-11-30 Thread Evan Martin
On Mon, Nov 30, 2009 at 9:50 AM, Mark Mentovai m...@chromium.org wrote: nikuli...@gmail.com wrote: LibICU is almost ubiquitous in non microsoft OS distributions, usually more upstream and ahead of upstream with bugs subsequent to every ICU release. Also it takes a lot of time to compile. Is

Re: [chromium-dev] Symbolized backtrace on Linux chromium?

2009-11-30 Thread Evan Martin
On Mon, Nov 30, 2009 at 11:16 AM, Michael Moss mm...@chromium.org wrote: We have a test covering this:  ./out/Debug/base_unittests --gtest_filter=StackTrace* Running it locally reveals that it is broken -- but the bots still work? It looks like there isn't a debug builder that runs

Re: [chromium-dev] Re: NameError: name 'ffmpeg_asm_lib' is not defined

2009-11-28 Thread Evan Martin
2009/11/27 Maciej Bliziński maciej.blizin...@gmail.com: The next problem: there's the /usr/bin/gcc path hardcoded somewhere: [snip] sh: /usr/bin/gcc: not found Failed to read names from file: /home/maciej/src/opencsw/pkg/chromium/

Re: [chromium-dev] Warning message when running chrome in gdb

2009-11-27 Thread Evan Martin
I have never encountered this. Have you tried searching for the error message? On Fri, Nov 27, 2009 at 4:31 PM, n179911 n179...@gmail.com wrote: Hi, I am trying to run chrome under ubuntu. But I see a lot of 'internal error in the warning message'.  Can you please tell me what does those

Re: [chromium-dev] adding packages

2009-11-25 Thread Evan Martin
I think you've accidentally used the wrong mailing list. Please see http://www.chromium.org/chromium-os/discussion-groups On Tue, Nov 24, 2009 at 3:45 PM, b23prodtm tianab.rak...@gmail.com wrote: HI! I'm adding packages to my local repo. Since I've read the doc tutorial :

Re: [chromium-dev] SQLite compression in history database.

2009-11-24 Thread Evan Martin
Due to bugs we've seen users with 10gb history files, which may contribute to complaints. http://code.google.com/p/chromium/issues/detail?id=24947 Even if compression ends up being pretty slow, you could imagine using it for our archived history (history more than a month old). On Tue, Nov 24,

Re: [chromium-dev] NameError: name 'ffmpeg_asm_lib' is not defined

2009-11-24 Thread Evan Martin
We currently won't build on Solaris; ffmpeg is the least of your worries. Someone contributed patches to build on FreeBSD that might get you closer, but the patch is enormous (~100kb, I think?) so I've been refactoring bits of it into reviewable chunks (very slowly in my free time). 2009/11/24

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Evan Martin
On Sun, Nov 22, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: On Sun, Nov 22, 2009 at 1:35 PM, Adam Langley a...@chromium.org wrote: On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make

Re: [chromium-dev] gcl upload error

2009-11-21 Thread Evan Martin
A guess, but it looks like it's attempting to find your email address out of your SVN authorization data, and that the computer you're on has no SVN auth data. Try something like svn ls --username=mycommitern...@chromium.org svn://... and log in if it prompts you. On Sat, Nov 21, 2009 at 12:46

[chromium-dev] whitlisting compilers for -Werror

2009-11-21 Thread Evan Martin
On Sat, Nov 21, 2009 at 7:21 AM, rahul rahulsin...@gmail.com wrote: I happen to find this warning very useful, just as I find our policy to make warnings hard errors in our own code helpful. Yes, of course. That's a good practice. But what about the end-users who have to deal with warnings as

Re: [chromium-dev] whitlisting compilers for -Werror

2009-11-21 Thread Evan Martin
On Sat, Nov 21, 2009 at 11:59 AM, Peter Kasting pkast...@google.com wrote: There is another fix, which is to disable to warning within the file or globally for GCC versions less than X.  GCC exposes a number of different macros and switches that let you determine the version precisely either

Re: [chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Evan Martin
On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support for git-cl because there is already a watchlists.py file, but then there

[chromium-dev] user-contributed translations

2009-11-19 Thread Evan Martin
I persistently get questions from users wanting to provide localization for Chrome. I believe our answer is that we don't accept user-contributed translations. Is there a FAQ somewhere I can link these users to? Where would such a FAQ belong? Also, another option for these users is to write

[chromium-dev] StringPrintf and friends are now checked

2009-11-19 Thread Evan Martin
GCC-compiled code (Mac/Linux) will now warn / fail to compile if you pass the wrong types to our printf-like functions (StringPrintf, etc.). This would have caught at least two bugs I've seen in the past. There is one twist to be aware of if you haven't seen it before. The % format specifiers

Re: [chromium-dev] huge binary drop of native client code

2009-11-18 Thread Evan Martin
On Wed, Nov 18, 2009 at 4:43 PM, Bradley Nelson bradnel...@google.com wrote: Backing things out shortly. No rush; if you need the code, it's ok. (It'd be nice if you used deps_os though.) It didn't break nacl's trybots or waterfall because they're less pared down, and probably got thru a try

Re: [chromium-dev] building without svg

2009-11-17 Thread Evan Martin
On Tue, Nov 17, 2009 at 10:49 AM, Jonathan Dixon j...@chromium.org wrote: This is tangential to the core of your question, but just to check, are asserts disabled on linux release builds? This is a good thing to check! But it looks like they are. There are numerous calls to ASSERT within the

Re: [chromium-dev] building without svg

2009-11-16 Thread Evan Martin
13, 2009 at 2:39 PM, Evan Martin e...@chromium.org wrote: We track total binary size here:  http://build.chromium.org/buildbot/perf/dashboard/sizes.html I don't know of any place we track per-module sizes. On Fri, Nov 13, 2009 at 2:33 PM, Eric Seidel esei...@chromium.org wrote: Do we have any

Re: [chromium-dev] building without svg

2009-11-16 Thread Evan Martin
, 2009 at 12:33 AM, Evan Martin e...@chromium.org wrote: I spent some quality time with nm.  With it I can take a release binary (so all the inlining and optimizations like dead code removal have been done) and display symbol sizes as well as which file they're from. My Release Linux build stripped

Re: [chromium-dev] new matrix-view perf dashboard

2009-11-16 Thread Evan Martin
On Mon, Nov 16, 2009 at 4:05 PM, Steven Knight s...@chromium.org wrote: Let me know if you notice any problems or have any suggestions for making this more useful. I've noticed it's basically impossible to load this page over a moderately fast internet connection because of the quantity of data

[chromium-dev] building without svg

2009-11-13 Thread Evan Martin
I measured that SVG is nearly a sixth of the binary size of a Chrome debug build. That's not only more compile time, it's also more link time for each incremental link and more time for the debugger to grind it when starting gdb. For my day-to-day debugging I would like to build without SVG (and

Re: [chromium-dev] building without svg

2009-11-13 Thread Evan Martin
such data would be very useful. On Fri, Nov 13, 2009 at 2:14 PM, Evan Martin e...@chromium.org wrote: I measured that SVG is nearly a sixth of the binary size of a Chrome debug build.  That's not only more compile time, it's also more link time for each incremental link and more time

Re: [chromium-dev] Simulating keyboard input

2009-11-10 Thread Evan Martin
On Fri, Nov 6, 2009 at 8:16 AM, Simon Stewart simon.m.stew...@gmail.com wrote: I've noticed a difference between firefox and chrome, and was wondering whether it was deliberate. Generally, the way to resolve these issues is to also test Safari and IE. We almost always match Safari, so

Re: [chromium-dev] Re: 437k files checked out for an official build

2009-11-10 Thread Evan Martin
Note in Anthony's mail he said he was clobbering the build directory, not the checkout. I do not have very many files in my build directories: $ find Debug | wc -l 10499 $ find Release | wc -l 10290 I think this is not we have a lot of files because we do a lot of stuff but rather that

Re: [chromium-dev] Re: 437k files checked out for an official build

2009-11-10 Thread Evan Martin
BTW, the trick I always use for deleting directories on Windows 'cause it's so slow is: mv dirname foo; rm -rf foo that way you can start your build or whatever again immediately, because the target directory is gone immediately. On Tue, Nov 10, 2009 at 10:39 AM, Evan Martin e...@chromium.org

[chromium-dev] Re: [gyp-developer] Coping with configurations differences in sources

2009-11-10 Thread Evan Martin
On Mon, Nov 9, 2009 at 6:38 PM, Bradley Nelson bradnel...@google.com wrote: Currently they are porting base + app to 64-bit for windows. They only need a limited subset of functionality for nacl, so they have only made some source files 64-bit clean. They would like to simply disable the rest

Re: [chromium-dev] Re: test_shell performance is bad compared to Chromium

2009-11-10 Thread Evan Martin
On Thu, Nov 5, 2009 at 3:34 PM, Alexander Teinum atei...@gmail.com wrote: I want to make it clear, and it might be obvious by now, but test_shell isn't interesting to me. I just want the fastest browser engine that I can get. What makes Chromium different than WebKitGTK+ for my project, is

Re: [chromium-dev] Re: refactoring and git

2009-11-10 Thread Evan Martin
On Fri, Nov 6, 2009 at 10:50 AM, Yaar Schnitman y...@chromium.org wrote: Git is totally confusing my renames and new files. Take a look:  .../{WebSearchableFormData.h = WebElement.h}      |   49 -  webkit/api/public/WebSearchableFormData.h          |    4 +-  

[chromium-dev] Re: Reverting a change, the fast way

2009-11-04 Thread Evan Martin
On Tue, Nov 3, 2009 at 10:10 PM, Ben Goodger (Google) b...@chromium.org wrote: Can there be a way to apply this to a local tree only so that you can revert then revert the revert quickly locally so you can figure out why your change broke? I know this doesn't answer the question you are

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Evan Martin
: That's a good news. Can that info be put somewhere in the UsingGit wiki page? On Mon, Nov 2, 2009 at 23:56, Evan Martin e...@chromium.org wrote: On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson atwil...@chromium.org wrote: I'm doing some refactoring in the chromium worker code, and I got

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Evan Martin
?  For example, if we move the file, make sure that we commit it in the new location before making any text changes?  If so, we could at least document that. Erik On Tue, Nov 3, 2009 at 7:58 AM, Evan Martin e...@chromium.org wrote: I'm not sure which news you're referring to.  :) To answer

[chromium-dev] Re: Can't build chrome; NameError: name '_toolset' is not defined. Can't sync webkit. :-(

2009-11-03 Thread Evan Martin
On Tue, Nov 3, 2009 at 8:06 AM, Dan Kegel d...@kegel.com wrote: I get NameError: name '_toolset' is not defined while loading dependencies of base/base.gyp while loading dependencies of app/app.gyp while loading dependencies of build/all.gyp while trying to load build/all.gyp when

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Evan Martin
that unrelated files were actually copies of one another. In the end, I'm probably just going to land the patch via svn and manually setup the history linkage via svn copy. -atw On Tue, Nov 3, 2009 at 9:18 AM, Evan Martin e...@chromium.org wrote: Generally it should Just Work.  If it doesn't, I'd

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Evan Martin
On Tue, Nov 3, 2009 at 2:34 PM, Peter Kasting pkast...@google.com wrote: If a change closes the tree, the change author has 1 or 2 minutes to respond to a ping.  The change should be reverted if the author doesn't respond, if he says to revert, or if he does not say he has a fix within the

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-03 Thread Evan Martin
It has been working fine for me. Is it possible you have the wrong version of WebKit? What does tools/sync-webkit-git.py say? On Tue, Nov 3, 2009 at 6:46 PM, n179911 n179...@gmail.com wrote: Thanks. Kenneth, I fixed the ENABLE_3D_CANVAS redefined error. But I still get the following

[chromium-dev] Re: Compiling error after I did a 'gclient sync'

2009-11-03 Thread Evan Martin
On Tue, Nov 3, 2009 at 8:36 PM, n179911 n179...@gmail.com wrote: And when i got to a different directory trying to use git to get Webkit code, I get this error possible repository corruption on the remote side, not sure if these 2 are related.  git clone git://git.webkit.org/WebKit.git .

[chromium-dev] Re: Compiler warning with Arch Linux and make

2009-11-02 Thread Evan Martin
On Sun, Nov 1, 2009 at 8:01 AM, Alexander Teinum atei...@gmail.com wrote: Success. That's great! If you have any notes that would be useful to other Arch users, please update the instructions on the wiki at http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites (There's a

[chromium-dev] Re: readability extension (experience writeup)

2009-11-02 Thread Evan Martin
On Sat, Oct 31, 2009 at 3:41 PM, Aaron Boodman a...@chromium.org wrote:  - The docs are behind the code (had to read the code once or twice to figure out what was going wrong). Were you using trunk or dev? I was using dev. I think I just searched on Google and clicked through to whichever

[chromium-dev] Re: refactoring and git

2009-11-02 Thread Evan Martin
On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson atwil...@chromium.org wrote: I'm doing some refactoring in the chromium worker code, and I got the following review feedback: small request: can the files that were branched from existing files be svn copy'd instead of copying manually and svn

[chromium-dev] Re: readability extension (experience writeup)

2009-10-31 Thread Evan Martin
think we've fixed some crashers seen on the current dev channel on trunk, so I hope it was one of those. On Sat, Sep 12, 2009 at 7:02 PM, Evan Martin e...@chromium.org wrote: [resend, I think I screwed up the previous three tries] I wrote an extension that adds a page action to trigger Readability

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Evan Martin
On Thu, Oct 29, 2009 at 5:13 PM, John Abd-El-Malek j...@chromium.org wrote: Per the Chromium style guide (http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure

[chromium-dev] Re: git users and svn:eol-style

2009-10-29 Thread Evan Martin
On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page  http://dev.chromium.org/developers/coding-style then git will do the right thing as well.  (I just tested it on a local svn repo to be sure

[chromium-dev] Re: A Dictionary-Evaluation Plan

2009-10-28 Thread Evan Martin
2009/10/28 Hironori Bono (坊野 博典) hb...@chromium.org: Even though this is still a random thought, I would personally like to use chromium to evaluate the new dictionaries: i.e. uploading the new dictionaries to our dictionary server, changing the chromium code to use the updated ones, asking

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Evan Martin
On Tue, Oct 27, 2009 at 9:11 PM, Adam Barth aba...@chromium.org wrote: My three laptops have relatively comparable hardware and run Chrome on Windows, Mac, and Linux respectively.  The Linux version of Chrome feels ridiculously faster than Windows and Mac.  Do we understand why this is?  Can

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Evan Martin
On Wed, Oct 28, 2009 at 9:07 AM, Dan Kegel d...@kegel.com wrote: On Wed, Oct 28, 2009 at 8:05 AM, Evan Martin e...@chromium.org wrote: 3) Startup time is faster than calculator. I'm not sure if you're kidding.  Do you mean Windows calculator? On my home linux box (Jaunty, reasonably fast

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Evan Martin
On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: I actually got some weird warnings on the make build a while back when I specified the same file in two sources entries...something about circular dependencies and make ignore one. But don't remember the exact

[chromium-dev] Re: chromium linux' Native Client Plugin hides my NPAPI plugin

2009-10-27 Thread Evan Martin
On Fri, Oct 23, 2009 at 1:58 AM, Anselm R Garbe garb...@gmail.com wrote: However, I'm not sure if chrome resp. libnpGoogleNaClPluginChrome.a does it right with exporting these symbols as plain C symbols because this might conflict with other existing plugins as well in the same way. I

[chromium-dev] Re: chromium linux' Native Client Plugin hides my NPAPI plugin

2009-10-27 Thread Evan Martin
On Tue, Oct 27, 2009 at 2:50 PM, Evan Martin e...@chromium.org wrote: On Fri, Oct 23, 2009 at 1:58 AM, Anselm R Garbe garb...@gmail.com wrote: However, I'm not sure if chrome resp. libnpGoogleNaClPluginChrome.a does it right with exporting these symbols as plain C symbols because this might

[chromium-dev] Re: chromium linux' Native Client Plugin hides my NPAPI plugin

2009-10-26 Thread Evan Martin
On Mon, Oct 26, 2009 at 9:31 AM, Antoine Labour pi...@google.com wrote: On Fri, Oct 23, 2009 at 1:58 AM, Anselm R Garbe garb...@gmail.com wrote: The problem is that the chrome executable (in particular statically linked in libnpGoogleNaClPluginChrome.a) exports 'char

[chromium-dev] Re: chromium linux' Native Client Plugin hides my NPAPI plugin

2009-10-26 Thread Evan Martin
better still if the Linux community had made this crufty feature available on request rather than by default. David On Mon, Oct 26, 2009 at 10:10 AM, Evan Martin e...@chromium.org wrote: On Mon, Oct 26, 2009 at 9:31 AM, Antoine Labour pi...@google.com wrote: On Fri, Oct 23, 2009 at 1:58 AM

[chromium-dev] Re: HTML-as-UI CSS substitution

2009-10-26 Thread Evan Martin
On Mon, Oct 26, 2009 at 2:33 PM, Avi Drissman a...@google.com wrote: Many of our HTML files have CSS in them (about_credits.html, about_memory.html, etc) which needs to be tweaked per-platform (more specifically, using an appropriate sans-serif font; see http://crbug.com/21458). We already do

[chromium-dev] Re: Survey results and followup actions

2009-10-26 Thread Evan Martin
On Mon, Oct 26, 2009 at 4:15 PM, Peter Kasting pkast...@google.com wrote: * Visit http://sites.google.com/a/chromium.org/dev/getting-involved .  Two of the top areas of interest for contributions were in testing builds to file bugs, and helping users.  This short page has some links that

[chromium-dev] Re: Spellchecker and memory-mapped dicts

2009-10-22 Thread Evan Martin
On Thu, Oct 22, 2009 at 2:22 PM, Brett Wilson bre...@chromium.org wrote: This doesn't help on Mac where we want to use the system spellchecker. FYI, we got a patch to use the system spellchecker on Linux as well. http://code.google.com/p/chromium/issues/detail?id=24517 I should probably ping

[chromium-dev] Re: chrome build problem on Ubuntu

2009-10-21 Thread Evan Martin
http://groups.google.com/group/chromium-dev/browse_thread/thread/130391aa1809e41e Also: I am glad you mailed chromium-dev rather than me. On Tue, Oct 20, 2009 at 5:47 PM, webinfinite webinfin...@gmail.com wrote: Hi, I am building Chromium on my Ubuntu box but have the following errors:

[chromium-dev] [linux] how to work around nacl errors in 64-bit build

2009-10-20 Thread Evan Martin
(Since I've been contacted by a bunch people independently about this problem already, here's one mail to hopefully point others who have the same problem.) Though we auto-detect your system architecture when we build, for reasons opaque to me this doesn't work with nacl. I imagine someone is

[chromium-dev] Re: Brent's Windows port of WebKit moving to Skia

2009-10-19 Thread Evan Martin
On Sun, Oct 18, 2009 at 11:58 PM, Adam Barth aba...@chromium.org wrote: It looks like Brent Fulgham is strongly considering moving his Windows WebKit port to Skia: http://whtconstruct.blogspot.com/2009/10/exploring-skia.html Is there some way we could help him out by making the code in

[chromium-dev] Re: [Mac] Chromium terminates when running from Terminal

2009-10-19 Thread Evan Martin
On Mon, Oct 19, 2009 at 7:43 AM, Mark Mentovai m...@chromium.org wrote: If you had tried a debug build, you would have seen output like this: [mmdd/hhmmss:FATAL:/chrome/trunk/src/base/mac_util.mm(80)] Check failed: bundle. failed to load the bundle:

  1   2   3   4   5   6   >