Re: svn commit: r1561447 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_dir.c

2014-01-27 Thread Chris Darroch
Eric: Is the DirectorySlash side of things ever useful for these methods? You're thinking that maybe the return DECLINED statement could move up to the top of fixup_dir()? I've pondered that myself, but I think that's a much bigger change than just restoring the 2.2.x behaviour which should

Re: svn commit: r1557640 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_dir.xml modules/mappers/mod_dir.c

2014-01-13 Thread Chris Darroch
cove...@apache.org wrote: restore http://svn.apache.org/viewvc?view=revisionrevision=233369 under a configurable option: don't run mod_dir if r-handler is already set. PR53794 I like this, and it's certainly a more configurable solution to the problem with mod_dav which came up last week:

Re: mod_dav: Can dav be enabled in the root / location?

2013-12-30 Thread Chris Darroch
Graham Leggett wrote: I am currently struggling to turn mod_dav on. In theory, it is just Dav on, but in practice I am getting a 405 Method Not Allowed in response to PROPFIND By any chance, are you using 2.4.x/trunk and do you have mod_dir included in the build? I have a patch for a

Re: mod_dav: Can dav be enabled in the root / location?

2013-12-30 Thread Chris Darroch
Graham Leggett wrote: The second is that the module seems to want to respond to all methods, GET, POST, PROPFIND, etc when in theory it should only respond to GET. Yes, exactly. The history here seems to be due to a change made for PR 25435, which made it into 2.4.x but was vetoed for

Re: [VOTE] Release Apache httpd 2.2.26 as GA

2013-11-15 Thread Chris Darroch
Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.2.26 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.2.26 GA. +1: CentOS 5.5 (x86_64), APR 1.4.8, APR-util 1.5.2, OpenSSL 1.0.1e Chris.

Re: svn commit: r1541270 - /httpd/httpd/trunk/modules/http/http_filters.c

2013-11-12 Thread Chris Darroch
wr...@apache.org wrote: Wrap at 80 still, here at httpd project Amen to that. :-) Chris. -- GPG Key ID: 088335A9 GPG Key Fingerprint: 86CD 3297 7493 75BC F820 6715 F54F E648 0883 35A9

Re: [VOTE] Release mod_fcgid 2.3.9

2013-10-06 Thread Chris Darroch
Jeff Trawick wrote: [ ] Release mod_fcgid 2.3.9 as GA +1 Chris. -- GPG Key ID: 088335A9 GPG Key Fingerprint: 86CD 3297 7493 75BC F820 6715 F54F E648 0883 35A9

Re: svn commit: r1357986 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c

2013-10-04 Thread Chris Darroch
Jeff Trawick wrote: The app is out of spec either way. I think the trunk behavior is better. I'd agree on both counts (the latter IMHO, of course). For reference, here's a breakdown of 2.3.7 vs. trunk behaviour for Authorizers: Authorizer response2.3.7

Re: svn commit: r1357986 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c

2013-10-02 Thread Chris Darroch
Jeff Trawick wrote: URL: http://svn.apache.org/viewvc?rev=1357986view=rev http://svn.apache.org/viewvc?rev=1357986view=rev Log: Avoid internal sub-requests and processing of Location headers when in FCGI_AUTHORIZER mode, as the mod_fcgid_authenticator(), etc. hook

Re: svn commit: r1357986 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c

2013-10-02 Thread Chris Darroch
Chris Darroch wrote: The intent of r1357986 was to deal with a particular, wonky sub-case, when the Authorizer returns 200 (so the spec paragraph doesn't apply in this case, as it's a 200 OK response), but adds a Location header with a relative (not absolute) path. In this case, 2.3.7

Re: FYI... Planning to TR mod_fcgid 2.3.8 in 7-10 days

2013-09-26 Thread Chris Darroch
+1 with many thanks, Chris. -- GPG Key ID: 088335A9 GPG Key Fingerprint: 86CD 3297 7493 75BC F820 6715 F54F E648 0883 35A9

Re: UseListenScheme proposal

2013-07-11 Thread Chris Darroch
Nick: The idea is to introduce a non-default UseListenScheme On setting which uses the scheme from the Listen directive when constructing self-referencing URLs: Can you clarify for the lazy among us how this might interact with existing configuration options for self-referencing URLs? I'm

UseListenScheme proposal

2013-07-10 Thread Chris Darroch
Hi -- I thought I'd toss out a patch I've been working on lately; it's been a long time since I committed directly, so if some of the regulars wouldn't mind giving some feedback first, I'd appreciate it. The idea is to introduce a non-default UseListenScheme On setting which uses the scheme

doubly defined extensions in mime.types

2013-03-19 Thread Chris Darroch
Hi -- I notice we have the .wmz and .sub file extentions each defined twice in trunk mime.types: .wmz: application/x-msmetafile, application/x-ms-wmz .sub: text/vnd.dvb.subtitle, image/vnd.dvb.subtitle Any ideas on which to keep? I'm happy to make the trivial commit, but I don't follow

rotatelogs input from named pipe

2012-12-18 Thread Chris Darroch
Hi -- I recently needed to wire up httpd's rotatelogs to a named pipe (a FIFO) instead of to stdin. For context, we have a non-httpd server process configured to write to the pipe instead of a log file; further, this server likes to intermittently open, write to, and close its various log

Re: svn commit: r1362538 - in /httpd/httpd/trunk: CHANGES server/util_script.c

2012-08-21 Thread Chris Darroch
Jeff Trawick wrote: what about limiting the number of characters logged and potentially sent to the client via error-notes? (%.120s anyone?) Sounds good to me ... are there any debug/trace log which truncate output in a similar way that could serve as best practices examples? I fished

Re: svn commit: r1362538 - in /httpd/httpd/trunk: CHANGES server/util_script.c

2012-07-19 Thread Chris Darroch
Jeff Trawick wrote: Modified: httpd/httpd/trunk/server/util_script.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?rev=1362538r1=1362537r2=1362538view=diff == ---

Re: svn commit: r1362317 - in /httpd/mod_fcgid/trunk: CHANGES-FCGID modules/fcgid/mod_fcgid.c

2012-07-18 Thread Chris Darroch
Jeff Trawick wrote: Most of that is not user-visible stuff for CHANGES. (CHANGES would be barely usable by users if every refactor or other code improvement was described therein.) Improved logging for AAA handling perhaps? Sure -- I just didn't want it to go unremarked, mostly in case

Re: mod_fcgid support for ap_meets_conditions()

2012-07-17 Thread Chris Darroch
William A. Rowe Jr. wrote: On 6/29/2012 6:25 PM, Chris Darroch wrote: If this looks OK, I'd love to commit and move on to the next patch ... assuming I can keep paddling near the shore and avoid those dangerous undertows! Thanks and cheers, Looks sensible to me. Thanks, Bill

mod_fcgid support for ap_meets_conditions()

2012-06-29 Thread Chris Darroch
Hi -- After many years sailing far away from httpd shores, I happen to be making a visit again and might have a trickle of mod_fcgid patches to share. Because it's been a while I thought I'd post the first one or two for RTC instead of just committing them directly. This one is just adding

Re: using X-Forwarded-Host as r-hostname

2012-05-16 Thread Chris Darroch
Igor Galić wrote: One of the several things I'm uncertain about, though, is how to distinguish the case of just wanting to override, say, the Host header *after* the VirtualHost has been selected (perhaps this is the default case, to work like RemoteIPHeader), from the extra case of using

Re: using X-Forwarded-Host as r-hostname

2012-05-11 Thread Chris Darroch
William A. Rowe Jr. wrote: On 5/3/2012 6:14 PM, Igor Gali? wrote: Wouldn't it be more appropriate to hack up^W^Wexpand mod_remoteip? That answer seems sensible to me, too. Thanks, guys, for pointing me at mod_remoteip; I agree it's a more logical place for this kind of thing. The

Re: [Vote] Add commentary system to httpd docs

2012-05-04 Thread Chris Darroch
Daniel Gruno wrote: [+/-1] Add commentary system to the trunk documentation. +1 Chris. -- GPG Key ID: 088335A9 GPG Key Fingerprint: 86CD 3297 7493 75BC F820 6715 F54F E648 0883 35A9

using X-Forwarded-Host as r-hostname

2012-05-03 Thread Chris Darroch
Hi -- It's been a remarkably long time since I had anything useful to commit, and I'm pretty rusty, so I thought I'd throw this out for discussion as a RTC despite the CTR rules on trunk. I promise I won't be offended if anyone says it's a stupid hack and should never be committed, because,

Re: [Vote] Release mod_fcgid 2.3.7

2012-04-18 Thread Chris Darroch
+1 Chris. -- GPG Key ID: 088335A9 GPG Key Fingerprint: 86CD 3297 7493 75BC F820 6715 F54F E648 0883 35A9

Re: mod_authn_file + low ThreadStackSize = oops

2010-11-01 Thread Chris Darroch
Eric Covener wrote: I'd set my ThreadStackSize really low, to 64 KB, and while that usually lets you run without trouble I was just about to document that _lowering_ the stack size with ThreadStackSize is unreliable since the underlying call used only sets a _minimum_ stack size, not an

Re: mod_authn_file + low ThreadStackSize = oops

2010-10-07 Thread Chris Darroch
Stefan: This is PR 49437. crypt_data is a bit more than 128K on my Linux box. Yup, mine too, my bad -- typing while tired. Any opinions how this could be improved? - use malloc/free instead. This may be bad for performance (e.g. glibc's malloc will use mmap/munmap by default for blocks

mod_authn_file + low ThreadStackSize = oops

2010-10-04 Thread Chris Darroch
Hi -- It's been ages since I wrote to the list; as always, my apologies. I hope to get back to some actual programming soon, unless life gets in the way again. In the meantime, a quick note for anyone who might at some point stumble over the same thing and go to Google for help. I set up a

Re: svn commit: r964156 - in /httpd/httpd/trunk: docs/manual/developer/ include/ modules/aaa/ server/

2010-07-15 Thread Chris Darroch
Stefan Fritsch wrote: Because it's way too verbose in configurations where several Require directives are in a RequireAny block. In this case every Require that does not match would produce an ERROR-level log message, even if the request is finally allowed by a later Require directive. I

Re: svn commit: r956396 - /httpd/httpd/trunk/docs/manual/upgrading.xml

2010-06-21 Thread Chris Darroch
poir...@apache.org wrote: Author: poirier Date: Sun Jun 20 19:48:13 2010 New Revision: 956396 URL: http://svn.apache.org/viewvc?rev=956396view=rev Log: First pass at documentation for upgrading to 2.4. Went through CHANGES and tried to pick out things that would require a 2.2 user to make

Re: [VOTE] Release httpd 2.3.6-alpha

2010-06-16 Thread Chris Darroch
Jim Jagielski wrote: Test tarballs for Apache httpd 2.3.6-alpha are (will be) available at: http://httpd.apache.org/dev/dist/ Your votes please; +/- 1 [ ] Release httpd-2.3.6 as Alpha Vote closes at 15:00 UTC on Wednesday June 16 2010. I think I'm just squeaking in under the

Re: FYI... tentatively planning to roll mod_fcgid again towards the end of the week...

2010-02-08 Thread Chris Darroch
Jeff: I haven't seen any other complaints (yet), so I'm in no big hurry to get out another release. I'll wait until we have a handful of solutions ready for real end-user problems, unless we see that this issue is affecting a number of people. OK, great. I'll try to move on to my next

Re: FYI... tentatively planning to roll mod_fcgid again towards the end of the week...

2010-02-02 Thread Chris Darroch
Jeff: Go ahead with the fix; I'll review in detail and test it once you commit your final version. OK, I'll test more today first. Thanks. BTW, I haven't seen (or recognized) a commit to allow both a FastCGI authorizer and a FastCGI handler for the same request. Have I missed something

Re: FYI... tentatively planning to roll mod_fcgid again towards the end of the week...

2010-02-01 Thread Chris Darroch
Jeff Trawick wrote: ... to correct a regression when used with httpd 2.0.x on some Unix-ish platforms. OK, noted. I very much hope to pack in some additional changes to the wrapper management code this week; time's still on my side at the moment. I spent some of Friday on it but what

Re: FYI... tentatively planning to roll mod_fcgid again towards the end of the week...

2010-02-01 Thread Chris Darroch
Jeff Trawick wrote: ... to correct a regression when used with httpd 2.0.x on some Unix-ish platforms. OK, I have a first cut at what I'm hoping to commit shortly, unless anyone sees problems. Let me know if you want me to hold off until you've cut another GA; otherwise I'll continue

mod_fcgid versioning question

2010-01-22 Thread Chris Darroch
Chris Darroch wrote: Jeff Trawick wrote: Chris Darroch has a patch for that, which is a small part of http://people.apache.org/~chrisd/patches/mod_fcgid_auth/mod_fcgid-1auth-trunk.patch [snip] Yes -- and I'm really, really going to prioritize breaking this patchset up (I know I'm

Re: mod_fcgid versioning question

2010-01-22 Thread Chris Darroch
Jeff Trawick wrote: mod_fcgid doesn't currently provide a callable API. There are no public functions or structures. That's what I thought, but it's great to have it confirmed. 2.3.4 is GA already. 2.3.5 is being tested now and hopefully will be a GA too. Plz hold off on any serious

Re: [VOTE] release mod_fcgid-2.3.5

2010-01-22 Thread Chris Darroch
Jeff Trawick wrote: mod_fcgid users, please try out mod_fcgid-2.3.5.tar.gz (or .tar.bz2) or the win32/netware suitable package mod_fcgid-2.3.5-crlf.zip from http://httpd.apache.org/dev/dist/mod_fcgid/ and cast your vote: +1 to release as 2.3.5-GA Chris. -- GPG Key ID: 366A375B GPG Key

Re: [mod_fcgid] how about spin lock on share memory

2009-10-14 Thread Chris Darroch
Jeff Trawick wrote: maybe increasing the granularity of the lock could help (multiple busy lists with the inode used as a hash to get to the proper busy list) I happen to have a module, unrelated to mod_fcgid, which manages a fairly large shared-memory cache across a number of user

Re: [mod_fcgid] how about spin lock on share memory

2009-10-14 Thread Chris Darroch
Chris Darroch wrote: Because this runs on Linux and we're just using the APR defaults, the process locks are SysV semaphores. Maybe sometime in the far future, once glibc 2.10 appears on our systems, we might try APR_LOCK_PROC_PTHREAD and see if we can't get the shiny new

Re: mod_fcgid POST broken if FcgiAuthorizer is run

2009-10-09 Thread Chris Darroch
Jeff Trawick wrote: Chris Darroch has a patch for that, which is a small part of http://people.apache.org/~chrisd/patches/mod_fcgid_auth/mod_fcgid-1auth-trunk.patch which applies to the old mod_fcgid 2.2 but which he has submitted here for inclusion. If you get stuck, look in there at some

Re: [VOTE] release httpd mod_fcgid-2.3.4

2009-10-08 Thread Chris Darroch
William A. Rowe, Jr. wrote: [X] +1 to release as 2.3.4-beta Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B

Re: svn commit: r822094 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c

2009-10-07 Thread Chris Darroch
Jeff Trawick wrote: FCGIDOutputBufferSize - FCGIDResponseBufferSize FCGIDBusyTimeout - FCGIDRequestTimeout FCGIDBusyScanInterval - FCGIDRequestTimeoutScanInterval (unfortunate name for unfortunate concept) Hmm ... can't say I have any opinion on those, really. I suppose Response is

Re: svn commit: r822094 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c

2009-10-06 Thread Chris Darroch
Jeff Trawick wrote: Beyond beta, I think we have something that is clearly better than the 2007 mod_fcgid 2.2 release and should get out the door soon as a GA (as long as testing doesn't show any regression). I just made what I hope are uncontroversial changes to the directive names. I'll

Re: [mod_fcgid] Cleaning up configuration directive names

2009-09-21 Thread Chris Darroch
Rainer Jung wrote: The names of the configuration directives of mod_fcgid are somehow inconsistent. At least it's abit hard to remmber, that some directives use a prefix FCGI, others use FastCgi (and most do not have a prefix for a namespace). I'm not sure, how important we take configuration

Re: [VOTE] release httpd mod_fcgid-2.3.1?

2009-09-14 Thread Chris Darroch
William A. Rowe, Jr. wrote: Please fetch up the newly minted mod_fcgid-2.3.1.tar.gz (or bz2) or the win32 suitable package mod_fcgid-2.3.1-crlf.zip from: http://httpd.apache.org/dev/dist/mod_fcgid/ review, take it for a spin, and cast your choice [X] +1 to release as 2.3.1-beta Gave

Re: [VOTE] release httpd mod_fcgid-2.3.1?

2009-09-14 Thread Chris Darroch
William A. Rowe, Jr. wrote: Chris Darroch wrote: [X] +1 to release as 2.3.1-beta Gave it a quick compile and test run -- no heavy testing but it handles a pre-2.3 script fine, at least. So I'd vote we get a beta out there and encourage others to take a look. Thanks again, Thanks Chris

Re: [VOTE] release httpd mod_fcgid-2.3.1?

2009-09-10 Thread Chris Darroch
Jeff Trawick wrote: Interestingly, I found this post from Chris some time ago that covers the issue: http://www.mail-archive.com/mod-fcgid-us...@lists.sourceforge.net/msg00085.html His patch: http://people.apache.org/~chrisd/patches/mod_fcgid_auth/mod_fcgid-1auth-trunk.patch Yes -- we

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

2009-08-26 Thread Chris Darroch
William A. Rowe, Jr. wrote: Thank you for all this work ... it's much appreciated, especially since I've been utterly useless lately on the httpd front. Thanks again! So... if I throw the effort at getting unix to build clean for httpd-2.0 branch, you won't be offended ;-? Seriously, no

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

2009-08-25 Thread Chris Darroch
wr...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=807823view=rev Log: suppose this would be worth noting Changes with mod_fcgid 2.3.1 + *) Complete the unix port to 2.3-dev trunk. [William Rowe] Thank you for all this work ... it's much appreciated, especially since I've

Re: State of mod_auth_digest?

2009-07-10 Thread Chris Darroch
Dan Poirier wrote: I've added a patch to bug 16057 to replace the use of shared memory with socache. I was hoping the changes would be less pervasive, but the shared memory assumption showed up in a lot of places. Comments on the proposed changes would be more than welcome. Can't wait to

Re: slotmem API notes

2009-05-15 Thread Chris Darroch
Jim Jagielski wrote: No +1... When do you think you might work on this? I have some cycles today and would like to start the migration. Thanks for tackling this ... I see much stuff going on! I fear the time gap between idea and implementation seems to grow ever larger these days. I was

Re: User/Realm order in AuthDBDUserRealmQuery (mod_authn_dbd)

2009-05-15 Thread Chris Darroch
KaiGai Kohei wrote: But, I would like to set up the query as follows: AuthDBDUserRealmQuery \ SELECT md5(uname || ':' || %s || ':' || upass) FROM uaccount WHERE uname = %s ^^... to be realmto be user ... ^^ It seems to me we have no

Re: slotmem API notes

2009-05-15 Thread Chris Darroch
Joe Orton wrote: w.r.t. locking, my take for socache was: you either duplicate the code in every provider, or you duplicate the code in every API consumer, so it wasn't obvious what was best. I expected the latter would be both simpler and more flexible, so went for that. It looks like

Re: User/Realm order in AuthDBDUserRealmQuery (mod_authn_dbd)

2009-05-15 Thread Chris Darroch
KaiGai Kohei wrote: I think a new directive with formats support is preferable to keep compatibility with existing directives. We definitely need compatibility with existing directives. That's why I figured the extra parameter would be optional -- if you only provided one parameter, the

Re: slotmem API notes

2009-05-14 Thread Chris Darroch
Jim Jagielski wrote: Remove mod_slotmem (server/slotmem.c) and the associated ap_slotmem_*() wrapper functions. It's just an additional abstraction, agreed. I'm fine with removing it but got the impression that people *wanted* that abstraction. jean-frederic clere wrote: In mod_cluster

Re: slotmem API notes

2009-05-14 Thread Chris Darroch
Jim Jagielski wrote: But my personal preference would be to remove it and instead add an unsigned int flags field to ap_slotmem_provider_t, and define some flag values, such as AP_SLOTMEM_FLAG_NOTMPSAFE = 0x0001 (read not MP-safe) and AP_SLOTMEM_FLAG_PERSIST = 0x0002. Again, +1 for this

Re: slotmem API notes

2009-05-14 Thread Chris Darroch
Jim Jagielski wrote: At any rate, moving responsibility for locking up to the caller level, as the socache API does, I think makes a lot of sense. It means that a caller running in a single-process, single-threaded context can simply choose not to add the overhead of a global lock. Other

Re: slotmem API notes

2009-05-14 Thread Chris Darroch
jean-frederic clere wrote: It would be great to pass server_rec* and apr_pool_t* arguments to all the methods (except maybe num_slots() and slot_size()). Some providers may need to report error messages, and to do that they really need a server_rec*. They may also need to allocate data from

Re: slotmem API notes

2009-05-14 Thread Chris Darroch
Jim Jagielski wrote: On May 14, 2009, at 3:36 AM, jean-frederic clere wrote: Yeah... when a do is done, we want to ensure that none of the slots change since we are touching all slots. In general, we assume that with get and put, only one thread is touch any particular slot at one time.

Re: mod_fcgid support

2009-04-16 Thread Chris Darroch
William A. Rowe, Jr. wrote: Chris, I'm really confused. Are you asking to branch httpd trunk into a 2.4 branch (bad, we aren't there) or a 2.3 branch (overkill IMHO, if we don't have cycles to get to 2.4/3.0 with what's in trunk, we certainly don't have cycles to make the determinations of

mod_fcgid support

2009-04-10 Thread Chris Darroch
Hi -- Jeff Trawick wrote: Many people use mod_fcgid on Apache 2.0/2.2. The message should be that mod_fcgid development has moved to the ASF, and existing users are not being left behind in the transition. So a branch for mod_fcgid 2.x is maintained for httpd 2.0/2.2 users just as our own

Re: [PATCH] mod_dbd with more than one pool

2009-03-26 Thread Chris Darroch
Ronald Park wrote: I did have one minor nit to pick with the implementation of the DBDInitSQL command. A user might presume that the order of commands listed in the config file would be preserved when the commands are run. By using a hash table, you'll likely get a random order causing

Re: mod_fcgid

2009-03-18 Thread Chris Darroch
Roy T. Fielding wrote: I think most of the stuff in NOTICE is documentation that belongs in README. The only things we put in NOTICE files are copyright or attribution lines required by the original copyright owners. OK, thanks -- made a quick edit this morning. Makefile and .deps should

Re: [summary] accept mod_fcgid codebase into httpd project

2009-03-17 Thread Chris Darroch
Roy T. Fielding wrote: Done. I set all of Ryan Pan's commits to svn:author=pqf (for consistency), loaded the whole thing under httpd/mod_fcgid and fixed the eol-style to native. Please relicense the directory and files first before making any other changes. Thanks! I think the

Re: [PATCH] mod_dbd with more than one pool

2009-03-10 Thread Chris Darroch
Kevac Marko wrote: Prepared statements are not executed, just parsed (simplified), so no, it is not important for initialization statement to be before prepared statements. Right; what I wondered was whether you needed to execute some sort of magic initialization statement which would then

Re: [PATCH] mod_dbd with more than one pool

2009-03-10 Thread Chris Darroch
Kevac Marko wrote: It's great idea. But are you sure that it is good idea to change both main httpd.conf and VirtualHost for new DB connection to be added? These are separate things... It will introduce problems if, for example, httpd.conf is root writable and virtualhost-blabla.conf is user

Re: [PATCH] mod_dbd with more than one pool

2009-03-06 Thread Chris Darroch
Kevac Marko wrote: I'm not experienced in commiting patches to open source projects, so I am very thankful for your comments. No problem -- thanks for pushing this patch along! One thought I had overnight is that you might, if you like, want to tackle the init SQL patch first, which

Re: [summary] accept mod_fcgid codebase into httpd project

2009-03-05 Thread Chris Darroch
Chris Darroch wrote: Roy T. Fielding wrote: Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the other svnadmins) will have to massage it a bit to prefix the sourceforge ids, so just point us to the dump file when you

Re: [PATCH] mod_dbd with more than one pool

2009-03-05 Thread Chris Darroch
Kevac Marko wrote: Here I am again. The patch works well for us. Is there something else that I can do for now? I'm going to try to find some time to take a look -- thanks for the patch; it's good to see the DBDGroup idea being taken further than my initial notions. On an initial quick

Re: [summary] accept mod_fcgid codebase into httpd project

2009-02-18 Thread Chris Darroch
Roy T. Fielding wrote: I'd suggest that we import the code into SVN by starting not with this temporary package, but with a cvs2svn export of the SourceForge commit history. The relicensing can then follow as a single subsequent commit. Sound OK? Yes, that is what I prefer as well. All

Re: [summary] accept mod_fcgid codebase into httpd project

2009-02-12 Thread Chris Darroch
Roy T. Fielding wrote: I ended up fixing all website generation to utf-8 -- I am surprised that it lasted this long with just iso-8859-1. Thanks -- looks good! Yes, that is what I prefer as well. All paperwork is done, so please let us know when you have an export. I (or one of the

Re: [summary] accept mod_fcgid codebase into httpd project

2009-01-27 Thread Chris Darroch
Hi -- I wrote: The httpd-mod_fcgid.xml file is my first whack at the IP clearance template. I renamed this .xml.utf8 this morning because I realized it has some non-ASCII UTF-8 character sequences in it. I don't know if those will pass through the Incubator's XML-to-HTML transformation

Re: slotmen API thoughts

2009-01-26 Thread Chris Darroch
Jim Jagielski wrote: Work's been incredibly busy, so I haven't had time to do much on the refactoring of slotmem yet... Fair dos; no pressure from here, certainly. Glad to hear work's been busy! :-) Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3

Re: [summary] accept mod_fcgid codebase into httpd project

2009-01-26 Thread Chris Darroch
William A. Rowe, Jr. wrote: sounds great, the form is here; http://svn.apache.org/repos/asf/incubator/public/trunk/site-author/ip-clearance/ip-clearance-template.xml Good god is incubator/public/trunk/ a mess ;-) I've tried to wade through this and the results are here:

Re: [summary] accept mod_fcgid codebase into httpd project

2009-01-23 Thread Chris Darroch
William A. Rowe, Jr. wrote: sounds great, the form is here; http://svn.apache.org/repos/asf/incubator/public/trunk/site-author/ip-clearance/ip-clearance-template.xml Good god is incubator/public/trunk/ a mess ;-) OK, I'll take a whack at filling it out and post back the results -- might

Re: [summary] accept mod_fcgid codebase into httpd project

2009-01-22 Thread Chris Darroch
William A. Rowe, Jr. wrote: Sorry, let this thread continue too long, sorry I've been distracted. +1; wrowe, sctemme, issac, rjung, trawick, lars, niq, covener, fielding, jerenkrantz and chrisd. and the support of Albert Lash, Brian Akins and Brian McCallister. The vote passes; next step

Re: accept mod_fcgid codebase into httpd project

2009-01-16 Thread Chris Darroch
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote +/-1 [ ] Accept mod_fcgid into httpd Unless I missed a -1, that looked like a lot of +1s to me ... is there a standard length of

Re: accept mod_fcgid codebase into httpd project

2009-01-12 Thread Chris Darroch
William A. Rowe, Jr. wrote: Based on the enthusiasm of the module authors to adopt the AL and offer the mod_fcgid code to the httpd community, please vote [+1] Accept mod_fcgid into httpd And as others have already expressed, many thanks to Ryan and everyone else involved. Chris. -- GPG

Re: Transfer Patch Rights for mod_fcgid ASF

2009-01-09 Thread Chris Darroch
Tim Jensen wrote: I am new to the list. Love apache. It has served me well for over a decade. Keep up the great work. I had previously contributed a patch to the mod_fcgid module whose ownership is being transfered to ASF. As author of my minor little patch to mod_fcgid I gladly transfer

Re: Transfer Patch Rights for mod_fcgid ASF

2009-01-09 Thread Chris Darroch
pqf wrote: Now both authors have subscribe this maillist and claimed to transfer all rights to the patch to the Apache Software Foundation, is it OK? Can we move forward now? Excellent question -- it would seem we have resolved the outstanding issues here, so what is the next step? If

Re: slotmen API thoughts

2009-01-02 Thread Chris Darroch
Jim Jagielski wrote: - create() - takes num_items and item_size - to be called during initial config pass, providers should not initialize or create mutexes here, etc. should not?? That comes from writing mod_shmap which lets you load a bunch of socache

Re: mod_fcgid license questions

2009-01-02 Thread Chris Darroch
Piotr Gackiewicz wrote: Hi, my name is Piotr Gackiewicz and I am the autor of these patches. I confirm, that I personaly consider them as minor changes and agree, that you should put them into minor patch group. Without signing CLA and official Software Grant. I appreciate transferring this

Re: mod_fcgid license questions

2008-12-31 Thread Chris Darroch
Hi -- On 31 Dec 2008, at 05:48, Roy T. Fielding wrote: Foes anyone have a sense of whether these would indeed require a CLA and SGA? They look like simple repairs to me. More importantly, if he thinks they are simple repairs and he is happy to see them Apache Licensed, then there is no

slotmen API thoughts

2008-12-31 Thread Chris Darroch
Hi -- First of all, many thanks to Jim Jagielski, Jean-Frederic Clere, and Brian Akins for the slotmem API! Personally I think it would be great to see the mod_auth_digest and/or mod_proxy module gradually migrate toward using either the slotmem or socache APIs, as appropriate (and perhaps

Re: mod_fcgid license questions

2008-12-30 Thread Chris Darroch
pqf wrote: version 1.10 ( Jul 3rd 2006 ) 1. Use poll() instead of select() in UNIX. It becomes problematic on apache2 with large number of logfiles. Apache2 calls poll() (when OS supports it), and in that case it doesn't need to be recompiled with larger FD_SETSIZE. select() is still

Re: svn commit: r726113 - /httpd/httpd/trunk/server/mpm/worker/fdqueue.c

2008-12-30 Thread Chris Darroch
Hi -- I wrote: What we had before was: if (apr_atomic_casptr((volatile void**)(queue_info-recycled_pools), new_recycle, next) == next) { but also: if (apr_atomic_cas32((queue_info-idlers), prev_idlers + 1, prev_idlers) ==

Re: svn commit: r726113 - /httpd/httpd/trunk/server/mpm/worker/fdqueue.c

2008-12-29 Thread Chris Darroch
Basant Kumar kukreja wrote: Yes, unless until we clearly understand that volatile is not useful here, we should keep it. The thing that makes me reasonably sure this is OK (and this is for trunk/2.4 only) is that there are other apr_atomic_*() functions used in fdqueue.c without any

Re: mod_fcgid license questions

2008-12-19 Thread Chris Darroch
pqf wrote: Sorry for the delay, I have track down all patches base on my ChangeLog ( I keep my mail archive), so here is my brief: Minor patches ...Ignore here, I attach a file to show every modification to every ChangeLog entry. (If anyone think any change is major, please let me know)

Re: mod_fcgid license questions

2008-12-17 Thread Chris Darroch
William A. Rowe, Jr. wrote: How many are we talking about (in the significant category)? The easiest way probably depends on how many people, how easy they are to contact, etc. Ryan, do you have a rough sense of this? From my own review of the ChangeLog, it looks like there are roughly

Re: mod_fcgid license questions

2008-12-16 Thread Chris Darroch
pqf wrote: I have signed the two documents ( http://www.apache.org/licenses/software-grant.txt and http://www.apache.org/licenses/iclas), and emailed the scan version to secretary at apache.org. So what I should do next is? Should I contact all major contributors and ask for the agreement to

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Chris Darroch
Joe Orton wrote: Both modules look very neat! Are you going to commit them? I might debate the naming of mod_shmap ;) Heh, thanks. I don't know, I hadn't really thought about committing them ... maybe the shmap one is more useful to other folks? - have all providers consistently

Re: scoreboard.h/process_score question

2008-12-12 Thread Chris Darroch
Torsten Foertsch wrote: the struct process_score in scoreboard.h contains a sb_type member. Can anyone please explain what that item is for? I couldn't find any usage in the code. Looks like this was added back in r89115 along with a number of other things which were (mostly) quickly

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Chris Darroch
Joe Orton wrote: mod_shmap would be useful at least in modules/test so I can write some perl-framework tests for mod_socache! OK, I'll think about doing that. The m4/dsp/NWGNU wizardry required makes me tired just thinking about it, though. :-) In the meantime, I think they compile again

Re: svn commit: r726082 - /httpd/httpd/trunk/modules/aaa/mod_authz_core.c

2008-12-12 Thread Chris Darroch
Ruediger Pluem wrote: Sorry, but I currently don't get the reason for moving the negate check down in the code. So far as I'm aware, there's no functional or even performance difference at the moment (not that performance really matters here, since this function runs at configuration time).

Re: svn commit: r726113 - /httpd/httpd/trunk/server/mpm/worker/fdqueue.c

2008-12-12 Thread Chris Darroch
Ruediger Pluem wrote: Not quite sure if this is really correct because apr_atomic_casptr wants to have a (volatile void**) as first parameter. That's what made me less than sure ... but my gcc 4.1.2 -Wall definitely doesn't like that void** (dereferencing type-punned pointer ...). I

Re: mod_fcgid license questions

2008-12-12 Thread Chris Darroch
pqf wrote: When you wrote mod_fcgid, was there any code which you borrowed from mod_fastcgi? No. I didn't borrow any code from mod_fastcgi. Your current intention is for mod_fcgid to be available under the GPL version 2.0, correct? Could you confirm that you wanted the GPL to

mod_fcgid license questions

2008-12-11 Thread Chris Darroch
Hi -- I believe Pan Qingfeng (潘庆峰), the developer of mod_fcgid, has joined this list for the time being while the possibility of mod_fcgid becoming project in the Apache incubator is discussed. I'll use his English name of Ryan Pan from here on. I asked Ryan to join so that he could answer

Re: Authz directives

2008-12-11 Thread Chris Darroch
Roy T. Fielding wrote: I don't see a problem with RequireNone inverting the logic, and I think it would actually be useful for blocking a set of bad clients. Is it difficult to include that without MatchNotAny? Not at all difficult; trivial, in fact. The only reason I took it out as well

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-09 Thread Chris Darroch
Joe Orton wrote: * include/ap_socache.h: Use C++ safety wrappers, and rename -delete to -remove since the former is a C++ reserved word. Thanks again for the socache refactoring! I've been trying to keep these two modules up-to-date with both the socache stuff and Apache ZooKeeper

  1   2   >