@@ -114,6 +114,9 @@
goaltest/goal
/goals
configuration
+ includes
+
-Project project =
api.getProjectApi().get(Iterables.get(Splitter.on(@).split(in.identity),
0));
+String projectName =
Iterables.get(Splitter.on(@).split(in.identity), 0);
+projectName =
@@ -5,7 +5,7 @@ title: Logging
## Logging in Apache jcloudsreg;
-Logging in jclouds can save you time and effort when developing your code or
looking for help. If your code is not behaving how you expect it to, enabling
and configuring logging in jclouds can quickly give you valuable
-Project project =
api.getProjectApi().get(Iterables.get(Splitter.on(@).split(in.identity),
0));
+String projectName =
Iterables.get(Splitter.on(@).split(in.identity), 0);
+projectName =
Optional comment about a slight change to the splitting logic, but I think
there's actually a bug in the (unchanged) original code at
```
checkState(in.identity.indexOf(@) != 1, ...)
```
---
Reply to this email directly or view it on GitHub:
jclouds-pull-requests #366 UNSTABLE
Spurious [test
@@ -101,10 +101,20 @@ protected void bindErrorHandlers() {
return
MemoizedRetryOnTimeOutButNotOnAuthorizationExceptionSupplier.create(authException,
compose(new FunctionCredentials, String() {
public String apply(Credentials in) {
-
@abayer: Based on [this
comment](https://github.com/jclouds/jclouds-labs-google/pull/9/files#r7448227),
any thoughts on whether this restriction should actually be enforced..?
---
Reply to this email directly or view it on GitHub:
@@ -110,6 +112,41 @@ void testDescribe() {
}
@Test
+ void testFilter() {
[minor] `public void`, as for most tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/194/files#r7486520
Some repeated comments:
* use TestNG assertions only, at least in new test code (rather than Java
`assert`s)?
* plenty of cases where assertions in a test are surrounded by `if
(allResults.size() = 1) { ... }`. Are we legitimately expecting no responses
here? If so, at least throw a
he was joking, isn't he?
Yes, apologies if that wasn't clear! Both comments about the package rename
were jokes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/77#issuecomment-27960098
+1 - looks good to me! Thanks, @carlosgarciaibanez and @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/32#issuecomment-27960195
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=d9717a432fcd1a2512f4a5d121b9454822f928e7)
under [JCLOUDS-369](https://issues.apache.org/jira/browse/JCLOUDS-369)
---
Reply to this email directly or view it on GitHub:
Looks like this is [already
committed](https://github.com/jclouds/jclouds-site/commit/dcd24d0ca7a1acc5dc9aaf38305c6799b9d69cea).
Please reopen if not the case!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/23#issuecomment-27974381
Follow-on from dcd24d0
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-site remove-remaining-incubator
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/30
-- Commit Summary --
* HTML indenting
- if (operation.get().getHttpError().isPresent()) {
- HttpResponse response = operation.get().getHttpError().get();
- logger.warn(delete orphaned firewall failed. Http Error Code: +
response.getStatusCode() +
- HttpError: + response.getMessage());
@@ -108,6 +114,7 @@ public
GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api,
operationCompleteCheckInterval, TimeUnit.MILLISECONDS);
this.zones = checkNotNull(zones, zones);
this.hardwareMap = checkNotNull(hardwareMap, hardwareMap);
+
@@ -116,6 +123,8 @@ public
GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api,
checkNotNull(template, template);
+ final InstanceApi instanceApi =
api.getInstanceApiForProject(userProject.get());
+
Get `instanceApi` down where it's used?
---
Reply to this
@@ -166,14 +176,28 @@ public boolean apply(AtomicReferenceInstance input) {
retry(new PredicateAtomicReferenceInstance() {
@Override
public boolean apply(AtomicReferenceInstance input) {
-
+ */
+package org.jclouds.googlecomputeengine.compute.functions;
+
+import com.google.common.base.Predicate;
+import org.jclouds.compute.functions.GroupNamingConvention;
+
+import javax.inject.Inject;
+
+/**
+ * The convention for naming instance tags that firewall rules recognise.
+ *
+* @see #describeSnapshotsInRegion
+* @see #createSnapshotsInRegion
+* @see #deleteSnapshotInRegion
+* @see a
href=http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeSnapshots.html;
+* /
+ */
+
+* @see InstanceApi#describeInstances
+* @see #describeImageAttribute
+* @see a
href=http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeImages.html;
+* /
+* @see DescribeImagesOptions
+*/
+ @Named(DescribeImages)
+
+ public void testFilterWhenResponseIs2xx() throws Exception {
+
+ HttpResponse filterResponse = HttpResponse.builder().statusCode(200)
+
.payload(payloadFromResourceWithContentType(/describe_instances_running.xml,
text/xml)).build();
+
+
+ EC2Api apiWhenExist =
@@ -55,7 +59,41 @@ void testDescribeInstances() {
for (String region : ec2Api.getConfiguredRegions()) {
Set? extends Reservation? extends RunningInstance allResults =
client.describeInstancesInRegion(region);
assertNotNull(allResults);
- assert
}
}
-}
+
+ @Test
+ void testFilterInstances() {
+ for (String region :
view.unwrapApi(EC2Api.class).getAvailabilityZoneAndRegionApi().get().describeRegions().keySet())
{
+ Set? extends Reservation? extends RunningInstance allResults =
It seems that jclouds has stuff to clean up in the incubator.
Does anyone know what needs be cleaned up (and how to do it)? I can
help with that.
I'm assuming the tasks are as described here:
http://incubator.apache.org/guides/graduation.html#life-after-graduation
I haven't looked in detail
return input.get() != null;
}
}, operationCompleteCheckTimeout, operationCompleteCheckInterval,
MILLISECONDS).apply(instance);
}
- InstanceInZone instanceInZone = new InstanceInZone(instance.get(),
template.getLocation().getId());
+
- retry(operationDonePredicate, operationCompleteCheckTimeout,
operationCompleteCheckInterval,
- MILLISECONDS).apply(operation);
-
- checkState(!operation.get().getHttpError().isPresent(), Could not
create firewall, operation failed + operation);
+
@@ -266,6 +266,12 @@ public static IPProtocol fromValue(String protocol) {
private final IPProtocol ipProtocol;
private final RangeSetInteger ports;
+ /* Some handy shortcuts */
+ public static Rule permitTcpRule(Integer start, Integer end) { return
@@ -101,10 +101,20 @@ protected void bindErrorHandlers() {
return
MemoizedRetryOnTimeOutButNotOnAuthorizationExceptionSupplier.create(authException,
compose(new FunctionCredentials, String() {
public String apply(Credentials in) {
-
Dropping following comments by @abayer and in the [related
PR](https://github.com/jclouds/jclouds-labs-google/pull/9#discussion_r7443403).
The parsing will not break or do weird things if the
`@project.gserviceaccount.com` suffix is missing, so the check is not really
needed.
---
Reply to
Where is this configured?
I'm guessing, in Git? I hope it's a push whenever Git receives a
commit, rather than polling happening from JIRA..?
ap
Should we have some kind of prerequisite check here, or will things fail with
an obvious error message if we try to run Solo _without_ Chef now?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/196#issuecomment-28088996
Thanks for the prod, @spark404. I'd still like to see some input from somebody
else before making any decisions here.
It might be worth hopping on #jclouds at Freenode to see if someone can have a
look - good time, too, since the next couple of releases are coming up.
---
Reply to this email
This is something that will fail when running the bootstrap script with a
`Command not found: chef-solo.`
OK. I think that should be fine, but would it be easy to amend that to add
something like Unable to find chef-solo -please install Chef?
---
Reply to this email directly or view it on
Nope. I'm passing plain text credentials. The base64 encoding is done by
jclouds basic authentication.
Ah, OK (@Nirmal: there should be no implementation change there).
Still the same error, I take it?
ap
$Subject? When do you think someone should use one over the other? It's
kind of confusing as of now.
From what I know (and I'm hardly the expert here!), the vcloud API in
jclouds main is an implementation for the vCloud 1.0 API [1]. It's
older than the vcloud-director API in labs , which
@@ -29,7 +29,7 @@
* @author Nick Livens
* @see a
href=http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html;api
doc/a
*/
-public class AllocationPool {
+public final class AllocationPool {
Any reason for making this and the domain classes below final? This may
+ }
+
+ public Builder toBuilder() {
+ return new ConcreteBuilder().fromExternalGatewayInfo(this);
+ }
+
+ public static abstract class Builder {
+ protected abstract Builder self();
+
+ protected String networkId;
+
+ /**
+ * @see
@@ -37,10 +37,7 @@ public String getValue() {
}
public static NetworkType fromValue(String value) {
- for (NetworkType networkType : values()) {
- if (networkType.getValue().equalsIgnoreCase(value))
-return networkType;
- }
- return null;
+
+ */
+ public T state(State state) {
+ this.state = state;
+ return self();
+ }
+
+ /**
+ * @see Router#getExternalGatewayInfo()
+ */
+ public T externalGatewayInfo(ExternalGatewayInfo externalGatewayInfo) {
+
+
+ /**
+* Returns the list of all routers currently defined in Neutron for the
current tenant. The list provides the unique
+* identifier of each router configured for the tenant
+*
+* @return the list of all router references configured for the tenant.
+*/
+
+ @Path(/{id})
+ @SelectJson(router)
+ @Fallback(Fallbacks.NullOnNotFoundOr404.class)
+ Router get(@PathParam(id) String id);
+
+ /**
+* Create a new router
+*
+* @param options optional arguments
+* @return the newly created router
+*/
+
+import java.beans.ConstructorProperties;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static
org.jclouds.openstack.v2_0.options.PaginationOptions.Builder.marker;
+
+/**
+ * @author Nick Livens
+ */
+@Beta
+@Singleton
+public class ParseRouterDetails
+* @see InstanceApi#describeInstances
+* @see #describeImageAttribute
+* @see a
href=http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeImages.html;
+* /
+* @see DescribeImagesOptions
+*/
+ @Named(DescribeImages)
+
+ authenticatedGET().endpoint(endpoint +
/routers).addQueryParam(fields, id, tenant_id, name).build(),
+
HttpResponse.builder().statusCode(200).payload(payloadFromResourceWithContentType(/list_routers.json,
APPLICATION_JSON)).build())
+
assertTrue(subnetApi.delete(net.getId()));
}
assertTrue(networkApi.delete(networkId));
}
}
+
+ private PredicateSubnet createPredicate(final String subnetId) {
See above comment. And since we're using this in multiple places, move out to a
Hey guys. any reason this pull request is not accepted yet?
@iliapolo: Now that I see the main remaining TODO item has been resolved, there
should be no reason, no! I'll try to merge this in the course of the day...
---
Reply to this email directly or view it on GitHub:
jclouds » jclouds #591 UNSTABLE
Looks like an unrelated [test
Committed to
[1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=f278450355bbaa95c841c2f857a528091b90d723)
and updated [JCLOUDS-213](https://issues.apache.org/jira/browse/JCLOUDS-213).
Thanks, @andreaturli!
---
Reply to this email directly or view it on GitHub:
Just updated the DEV@cloud jobs to run of the jclouds-* repos rather
than incubator-jclouds-*. There might be some failures until the
cleanup is complete, so apologies in advance for multiple build
failure emails...
ap
Looks good - please squash'n'rebase!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/196#issuecomment-28258037
// 'bad' orders have no start cpu's and cause the order lookup to
fail.
if (guest.getStartCpus() 1)
return null;
- ProductOrder order =
client.getVirtualGuestClient().getOrderTemplate(guest.getId());
+ try {
+order =
@@ -64,6 +65,8 @@ public void handleError(HttpCommand command, HttpResponse
response) {
exception = new ResourceNotFoundException(message,
exception);
} else if (message.indexOf(currently an active
transaction) != -1) {
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the
@@ -66,8 +66,11 @@ protected void configure() {
}
/**
-* Provides a cache for tokens. Cache is time based and expires after 59
minutes (the maximum time a token is
-* valid is 60 minutes)
+* Provides a cache for tokens. Cache is time based and by default
expires
@@ -78,7 +81,7 @@ protected void configure() {
// bit before the deadline to make sure there aren't session
expiration exceptions
sessionIntervalInSeconds = sessionIntervalInSeconds 30 ?
sessionIntervalInSeconds - 30 :
sessionIntervalInSeconds;
- return
Should this be cherry-picked to master?
@nacx: I'd prefer to see a new PR with some successful PR builds and, if
possible, confirmation of a successful live test run..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/77#issuecomment-28287406
jclouds-java-7-pull-requests #844 UNSTABLE
Unrelated [test
@@ -945,6 +975,15 @@ public TemplateBuilder imageMatches(PredicateImage
condition) {
* {@inheritDoc}
*/
@Override
+ public TemplateBuilderImpl imageChooser(FunctionIterable? extends
Image,Image imageChooser) {
[minor] Missing space in `,Image`
---
Reply to this email
@@ -111,16 +147,12 @@ public void
testLocationPredicateWhenComputeMetadataIsNotLocationBound() {
}
@SuppressWarnings(unchecked)
- @Test
- public void testResolveImages() {
-
-
+ protected void doTestResolveImages(SupplierSet? extends Image images,
Image
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=69756496bdb9e49fb69e802d97eadc1c17bc2af5).
Thanks, @richardcloudsoft!
---
Reply to this email directly or view it on GitHub:
Closed #13.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/13
Committed to
[1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=53e63ab)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/34#issuecomment-28392439
Create a new PR to port #201 ported to master, merge that one, and rebase and
start working again in this one.
I would prefer this one, if possible?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28403709
@@ -16,7 +16,7 @@
*/
package org.jclouds.softlayer.exceptions;
-public class SoftLayerOrderItemDuplicateException extends RuntimeException {
+public class SoftLayerOrderItemDuplicateException extends
IllegalStateException {
Same question as before on this: the [Javadoc for
Where could you put a checkArgument? Can you give me an example?
I think @nacx was going down the same path here, but luckily he knew what the
actual way to have validation performed during the API call is ;-) I appreciate
your point that that moves the error into a less useful position from a
@@ -0,0 +1,97 @@
+---
+layout: jclouds
+title: Documentation
+---
+
+# How to Report a Bug to Apache jcloudsreg;
+
+If you run into a bug while using jclouds, we encourage you to report it. To
help you please collect as much of the following information as possible. If
you can't get
@@ -16,7 +16,7 @@
*/
package org.jclouds.softlayer.exceptions;
-public class SoftLayerOrderItemDuplicateException extends RuntimeException {
+public class SoftLayerOrderItemDuplicateException extends
IllegalStateException {
This is quite a relevant change, so I think it is a good
@@ -13,7 +13,8 @@ title: Getting Started - The Rackspace Cloud
1. [Your First Cloud Servers App](#servers)
1. [Working with Cloud Block Storage](#volumes)
1. [Working with Cloud Load Balancers](#loadbalancers)
-1. [Working with Cloud Databases](#databases)
+1. [Working with Cloud
@@ -276,6 +277,48 @@ Note: When providing a java classpath in Windows, the
path separator is ';' inst
In addition to the create database instance example, by going through the
clouddatabases example code, you will learn to create instances, databases,
and database users as well as
+1. You can find these APIs in the latest
[Javadoc](http://demobox.github.com/jclouds-maven-site/latest/apidocs).
+
+### a id=autoscale-source/aThe Source Code
+
+1. Create the directory hierarchy
org/jclouds/examples/rackspace/clouddatabases/ in your jclouds directory.
+1. Create Java
+### a id=autoscale-source/aThe Source Code
+
+1. Create the directory hierarchy
org/jclouds/examples/rackspace/clouddatabases/ in your jclouds directory.
+1. Create Java source files called CreateInstance.java and Constants.java in
the directory above.
+1. You should now have a directory
+1. Go to the example code
[Createpolicy.java](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/CreatePolicy.java),
read it over, and copy the code into your file.
+1. Open Constants.java for editing.
+1. Go to the
General question throughout the new text: since it's e.g. Cloud Load
Balancers and not Rackspace Cloud Load Balancers, should it be Autoscale
rather than Rackspace Autoscale?
---
Reply to this email directly or view it on GitHub:
@@ -97,19 +116,27 @@ public Builder age(int age) {
}
/**
- * @see Aged#created
+ * @see Aged#getCreated()
*/
public Builder created(Date created) {
this.created = created;
Fine (here and for the other ones)...thanks!
---
Reply to this
+ for ( GroupState state : groupApi.listGroupStates() ) {
+ Group g = groupApi.get(state.getId());
+ for ( ScalingPolicyResponse policy : g.getScalingPolicies() ) {
+if (policy.getName().equals(NAME)) return g.getId();
+ }
+ }
+
+ throw
This is what I'll do for now. I'll remove the properties but document it to
let know users know that such limits exist. If
users need this sort of thing, it can always be fixed in another PR.
Thanks, @everett-toews!
---
Reply to this email directly or view it on GitHub:
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=55b21b64494546d268df6044f5a5fecd23efba83)
and
[1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=844819d8b7fc674010952339ef1b26ed15d3c7cd).
Thanks, @andreaturli and @nacx!
---
Reply to
+ public StreamOptions nextStreamOptions() {
+ return StreamOptions.class.cast(nextMarker().get());
+ }
+
+ @Override
+ public OptionalObject nextMarker() {
+ for (Link link: getLinks()) {
+ if (Link.Relation.NEXT == link.getRelation()) {
+return
I think Rackspace Autoscale for now. Maybe they will rename it later.
OK, thanks for explaining, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/32#issuecomment-28513866
- protected QueueStats(MessagesStats messages) {
- this.messages = messages;
+ protected QueueStats(MessagesStats messageStats) {
+ this.messages = checkNotNull(messageStats);
[minor] `checkNotNull(messageStats, messageStats required);`?
---
Reply to this email directly or
Thanks for the updates! Something weird going on with the numbering now:
---
Reply to this email directly or view it on GitHub:
@@ -153,8 +154,10 @@ protected EC2ComputeService(ComputeServiceContext
context, MapString, Credentia
if (client.getTagApiForRegion(region).isPresent()) {
MapString, String common =
metadataAndTagsAsValuesOfEmptyString(template.getOptions());
- if (common.size()
+ requestResponseMap.put(authorizeSecurityGroupIngressRequestGroup,
authorizeSecurityGroupIngressResponse);
+ requestResponseMap.put(runInstancesRequest, runInstancesResponse);
+ requestResponseMap.put(describeInstanceRequest,
describeNamedInstanceResponse);
+
@@ -100,8 +100,12 @@ public NodeMetadata apply(ServerInZone serverInZone) {
builder.hostname(from.getName());
builder.location(from.getHostId() != null ? new
LocationBuilder().scope(LocationScope.HOST).id(from.getHostId())
@@ -362,6 +364,30 @@ public void testCreateTwoNodesWithRunScript() throws
Exception {
checkOsMatchesTemplate(node2);
}
+ @Test(enabled = true, dependsOnMethods =
testCreateTwoNodesWithRunScript)
+ public void testCreateTwoNodesWithOneSpecifiedName() throws Exception {
+
}
+ if (groupName.equals()) {
+ groupName =
nodeNamingConvention.groupInUniqueNameOrNull(from.getHostname());
+ }
+ builder.group(groupName);
See comment about perhaps initializing with `null` rather than the empty string
above?
---
Reply to this email
Applied to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=9a7336b)...thanks,
@ahgittin!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/207#issuecomment-28707445
Merged and deployed.
Thanks, @everett-toews! +1 - looks good to me
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/34#issuecomment-28809385
Commited to master.
Thanks for all the reviewing time, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28810371
Thanks, @ahgittin! Will try to get these in this evening...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/210#issuecomment-28842670
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=3ecbf9084762ef4c8b0f8c5beb8a161add1fb6bd)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/210#issuecomment-28843542
Closed #210.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/210
Reverted. Turns out you can't implement list messages with this refactoring.
Would it have been feasible to have a test case for list messages whose
failure could have caught this? Or is that (quite possibly!) an invalid
statement to make in this case..?
---
Reply to this email directly or
jclouds » jclouds #633 UNSTABLE
Looks like another timing-related [test
Just did a bit of cleanup on the 1.6.x branch of jclouds-labs-openstack to
get its versioning in a sane way - turns out the sane way was already in
place for 1.7.0 there, so woo. Checking the others now, but I think we're
ok with an extra step I specified on the release process wiki.
Do we need
@@ -153,8 +155,9 @@ protected EC2ComputeService(ComputeServiceContext
context, MapString, Credentia
if (client.getTagApiForRegion(region).isPresent()) {
MapString, String common =
metadataAndTagsAsValuesOfEmptyString(template.getOptions());
- if (common.size()
@@ -362,6 +364,30 @@ public void testCreateTwoNodesWithRunScript() throws
Exception {
checkOsMatchesTemplate(node2);
}
+ @Test(enabled = true, dependsOnMethods =
testCreateTwoNodesWithRunScript)
+ public void testCreateTwoNodesWithOneSpecifiedName() throws Exception {
+
1 - 100 of 1315 matches
Mail list logo
