Follow-up Comment #12, patch #2715 (project freeciv):

Well, I should have expected that - that corruption along shorelines came
from me being cargo cultist.

After a trivial adjustment, mask is drawn in the correct place, so the
corruption is gone.

Still working on the leaks.

Made a change to ai_level combobox, so that as in 2.3.0 first option is
initially selected at "New game".
Changed pango rectangle from ink to logical, as i.e. very long technology
names in Science tab were slightly truncated.

On a semi-related note: it would seem that adding a helper function like
gtk_image_from_cairo_sprite would be useful.
It would simply:
{
pix = sprite_get_pixbuf(sprite);
gtk_image_set_pixbuf(image, pix);
g_object_unref(pix);
}

as it seems that for the moment those new pixbufs leak, if created by
gtk_image_new_from_pixbuf(sprite_set_pixbuf(sprite)).

This time I've checked that the patches actually apply (earlier one of them
had a typo, that prevented it).


(file #14045, file #14046)
    _______________________________________________________

Additional Item Attachment:

File name: api-cleanup2.patch             Size:55 KB
File name: cairo-drawing.patch            Size:77 KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?2715>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to