[GitHub] ivankelly commented on issue #657: Use hash set with native ints for write set tracking

ivankelly commented on issue #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#issuecomment-339227896 Looking at this again, bringing in an outside library is overkill. I'm going to try it with just a raw int[]. The placement poli

[GitHub] ivankelly commented on issue #657: Use hash set with native ints for write set tracking

ivankelly commented on issue #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#issuecomment-339227896 Looking at this again, bringing in an outside library is overkill. I'm going to try it with just a raw int[]. The placement poli

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146763969 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146761311 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146758705 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146758311 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146756424 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146753653 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146714688 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712866 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java

[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712921 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.jav

[GitHub] sijie opened a new issue #659: Checkpoint logic is broken in SortedLedgerStorage

sijie opened a new issue #659: Checkpoint logic is broken in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/issues/659 *Problem* Currently SortedLedgerStorage doesn't maintain any checkpoint related information. It shares the same `checkpoint holder` with InterleavedL

[GitHub] asfgit commented on issue #658: Fail earlier when encountering DNS issues

asfgit commented on issue #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#issuecomment-339158066 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest

[GitHub] asfgit commented on issue #658: Fail earlier when encountering DNS issues

asfgit commented on issue #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#issuecomment-339153607 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest

[GitHub] merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking

merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146706531 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server ${pr

[GitHub] merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking

merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146706531 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server ${pr

[GitHub] sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking

sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146699495 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java ##

[GitHub] agresch opened a new pull request #658: Fail earlier when encountering DNS issues

agresch opened a new pull request #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658 We had some DNS issues today and various TestRegionAwareEnsemblePlacementPolicy tests were failing for me. The LOG warning in RackawareEnsemblePlace

[GitHub] sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking

sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146698783 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server ${proje

[GitHub] sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking

sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146696313 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LocalBookieEnsemblePlacementPol

[GitHub] asfgit commented on issue #657: Use hash set with native ints for write set tracking

asfgit commented on issue #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#issuecomment-339102463 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit

[GitHub] eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking

eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146650203 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server ${p

[GitHub] eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking

eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146650781 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LocalBookieEnsemblePlacemen

[GitHub] ivankelly opened a new pull request #657: Use hash set with native ints for write set tracking

ivankelly opened a new pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657 This avoids the autoboxing on Integers and allocations of cells for the hashset. This also implies using IntArrayList for the write set

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146627892 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@ -0,

Build failed in Jenkins: bookkeeper-master #1926

See Changes: [sijie] Fix a typo in PCBC logging [sijie] Pool the V2 keys [eolivelli] Pool AddCompletions -- [...truncated 321.39 KB...] Running org.apache.bookkeeper.cl

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146538874 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

Build failed in Jenkins: bookkeeper-postcommit-publish-website #128

See Changes: [eolivelli] Pool AddCompletions -- [...truncated 450.93 KB...] [INFO] Apache BookKeeper :: Stats Providers :: Twitter Science Stats SUCCES

[GitHub] eolivelli closed pull request #649: Pool AddCompletions

eolivelli closed pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146521260 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520915 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520352 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146491818 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message Requ

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #83

See

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146486343 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum Ope

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146036457 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146485874 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] asfgit commented on issue #649: Pool AddCompletions

asfgit commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338913081 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest-docker/141/

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483992 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483788 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483553 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482385 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@ message G

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482199 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message Requ

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146481976 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ## @@ -0,

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146480883 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146480717 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146480119 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum Ope

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146479924 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146479659 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKee

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146479494 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum Ope

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146477901 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146476915 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146476663 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146476218 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/Boo

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. In fact their was no conflicts, it rebased without issue. -

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. This is an automated messag

[GitHub] eolivelli commented on a change in pull request #649: Pool AddCompletions

eolivelli commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470714 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@

[GitHub] ivankelly commented on a change in pull request #649: Pool AddCompletions

ivankelly commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@