Re: svn commit: r1308751 - in /ofbiz/trunk/framework: images/webapp/images/selectall.js webapp/src/org/ofbiz/webapp/control/RequestHandler.java
+1.
--
Rishi Solanki
Manager, Enterprise Software Development
HotWax Media Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxmedia.com
On Tue, Apr 3, 2012 at 2:18 PM, Nicolas Malin malin.nico...@librenberry.net
wrote:
thanks Deepak Dixit for this improvement, end user will appreciate ;)
Nicolas
Le 03/04/2012 10:41, jler...@apache.org a écrit :
Author: jleroux
Date: Tue Apr 3 08:41:06 2012
New Revision: 1308751
URL:
http://svn.apache.org/viewvc?**rev=1308751view=revhttp://svn.apache.org/viewvc?rev=1308751view=rev
Log:
A patch from Deepak Dixit for Auto-completer request should be async.
https://issues.apache.org/**jira/browse/OFBIZ-4780https://issues.apache.org/jira/browse/OFBIZ-4780
Currently auto-completer uses sync call to prepare auto-completer source
(result list).
Due to this user can't perform any other operation on lookup field and
user should have to wait until response came.
In general, synchronous requests should never be used because they tend
to block the execution of anything else on the page (or even the entire
browser UI), which isn't good.
Also ajax-loader image not display on google chrome browser due to sync
request.
Need to use async request for auto-completer.
Modified:
ofbiz/trunk/framework/images/**webapp/images/selectall.js
ofbiz/trunk/framework/webapp/**src/org/ofbiz/webapp/control/**
RequestHandler.java
Modified: ofbiz/trunk/framework/images/**webapp/images/selectall.js
URL: http://svn.apache.org/viewvc/**ofbiz/trunk/framework/images/**
webapp/images/selectall.js?**rev=1308751r1=1308750r2=**
1308751view=diffhttp://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/selectall.js?rev=1308751r1=1308750r2=1308751view=diff
==**==**
==
--- ofbiz/trunk/framework/images/**webapp/images/selectall.js (original)
+++ ofbiz/trunk/framework/images/**webapp/images/selectall.js Tue Apr 3
08:41:06 2012
@@ -17,6 +17,9 @@
* under the License.
*/
+//Define global variable to store last auto-completer request object
(jqXHR).
+var LAST_AUTOCOMP_REF = null;
+
// Check Box Select/Toggle Functions for Select/Toggle All
function toggle(e) {
@@ -412,8 +415,15 @@ function ajaxAutoCompleter(**areaCsvString
jQuery.ajax({
url: url,
type: post,
-async: false,
data: {term : request.term},
+beforeSend: function (jqXHR, settings) {
+//If LAST_AUTOCOMP_REF is not null means an
existing ajax auto-completer request is in progress, so need to abort them
to prevent inconsistent behavior of autocompleter
+if (LAST_AUTOCOMP_REF != null) {
+var oldRef = LAST_AUTOCOMP_REF;
+oldRef.abort();
+}
+LAST_AUTOCOMP_REF= jqXHR;
+},
success: function(data) {
// reset the autocomp field
autocomp = undefined;
Modified: ofbiz/trunk/framework/webapp/**src/org/ofbiz/webapp/control/**
RequestHandler.java
URL: http://svn.apache.org/viewvc/**ofbiz/trunk/framework/webapp/**
src/org/ofbiz/webapp/control/**RequestHandler.java?rev=**
1308751r1=1308750r2=1308751**view=diffhttp://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java?rev=1308751r1=1308750r2=1308751view=diff
==**==**
==
---
ofbiz/trunk/framework/webapp/**src/org/ofbiz/webapp/control/**RequestHandler.java
(original)
+++
ofbiz/trunk/framework/webapp/**src/org/ofbiz/webapp/control/**RequestHandler.java
Tue Apr 3 08:41:06 2012
@@ -872,7 +872,14 @@ public class RequestHandler {
try {
resp.flushBuffer();
} catch (java.io.IOException e) {
-throw new RequestHandlerException(Error flushing response
buffer, e);
+/*If request is an ajax request and user calls abort()
method for on ajax request then skip throwing of RequestHandlerException .
+ Specially its done for async ajax auto completer call, if
we call abort() method on ajax request then its showing broken pipe
exception on console,
+ because request is aborted by client (browser).*/
+if (!XMLHttpRequest.equals(req.**
getHeader(X-Requested-With))**) {
+throw new RequestHandlerException(Error flushing
response buffer, e);
+} else {
+if (Debug.verboseOn()) Debug.logVerbose(Skip Request
Handler Exception for ajax request., module);
+}
}
String vname = (String) req.getAttribute(_CURRENT_**VIEW_);
--
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org
Re: Upgrading Freemarker in our release branches
I checked at the FreeMarker release, the new version is able to handle concurrent access of templates in multithreading environment. Which in turn gives significant performance improvement. So from my side Big +1 for upgrading the jars on release. Thanks! -- Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Thu, Apr 19, 2012 at 1:30 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: +0 As long as it's has been sufficiently tested I see no pb Jacques From: Jacopo Cappellato jacopo.cappellato@**hotwaxmedia.comjacopo.cappell...@hotwaxmedia.com Hi all, there are a few interesting bug fixes and performance improvements between Freemarker 2.3.10, currently used in our release branches, and 2.3.19, currently used in trunk. Is it ok if I upgrade 10.04 and 11.04to use freemarker-2.3.19.jar? Kind regards, Jacopo
Re: Inconsistency between StringToList and ListToString
Nicolas,
Please have a look into the method specified urlEncodeArgs() of UtilHttp
class. It takes the Map as argument and if while conversion it gives you '{
}' then it is fine. You just need to use map converter instead of list
converter.
It should works perfectly then. Assuming you are talking about the
StringUtil.toList method, and I'm redirecting to you to use
StringUtil.toMap method.
HTH!
--
Rishi Solanki
Manager, Enterprise Software Development
HotWax Media Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxmedia.com
On Fri, Apr 27, 2012 at 8:42 PM, Nicolas Malin
malin.nico...@librenberry.net wrote:
Hi, I would like to explain a little problem with OFBiz convert where I
don't found a clean solution.
To start : a search form with a multiple drop-down that call a perform
service with an attribute List
the form :
field name=**partyClassificationGroupId
drop-down allow-multiple=true size=20 allow-empty=true...
the service :
service ...
attribute name=**partyClassificationGroupId type=List mode=IN
optional=true/ ...
When I execute the research, the service get the list but the paginate
lost it.
On the queryString the list is encoded like this : {element1, element2},
but the service use Converter class to load it and search : [element1,
element2].
The queryString is encoded by UtilHttp.urlEncodeArgs :
if (value instanceof String) {
valueStr = (String) value;
} else {
valueStr = value.toString();
}
which generate {element1, element2}
And converter StringToList :
if (obj.startsWith([) obj.endsWith(])) {
return StringUtil.toList(obj);
Other point, converter ListToString use also value.toString();
Do you think it is better to extend StringToList to support {} or to
correct encode and convert process to use [] ?
Nicolas
-- Nicolas MALIN Consultant Tél : 06.17.66.40.06 Site projet :
http://www.neogia.org/ --- Société LibrenBerry Tél : 02.48.02.56.12
Site : http://www.librenberry.net/
Re: Error while creating new customer
Same here. Not able to create the customer. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Mon, Nov 23, 2009 at 2:11 PM, Deepak Dixit deepak.di...@hotwaxmedia.comwrote: I am getting following error while creating new customer. Error in Service [partyRolePermissionCheck]: You must be logged in to complete the [Party role permission logic] process. It is working fine for r883228 but not for r883229. Thanks Regards -- Deepak Dixit HotWax Media Pvt. Ltd. Website :- www.hotwaxmedia.com Contact :- +91-98267-54548
Re: Adding few more details for admin user (party) in demo data
IMO, adding additional information is good idea. Many Backend pages like Profile pafes in party component and ordermgr order entry process we uses admin. Might be there is no benefit of doing this but IMO adding more information will be of no harms. +1 for Ashish's idea. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Fri, Dec 4, 2009 at 3:43 PM, Vikas Mayur vikas.ma...@hotwaxmedia.comwrote: Hi Hans/Ashish, Where does admin require this additional information? DemoCustomer is in Customer role and is there to be used for eCommerce applications. If your intention is to use admin user for front end app then I think it is not a good idea. Vikas On Dec 4, 2009, at 3:10 PM, Hans Bakker wrote: +1 most of the time i use DemoCustomer because on admin this data is missing, so sure why not add it Regards, Hans On Fri, 2009-12-04 at 15:04 +0530, Ashish Vijaywargiya wrote: WDYT if we add Shipping, Billing, Phone Credit Card info to admin user in a demo data? So all this information will be loaded when you will run ant run-install target. Thoughts? -- Ashish -- Antwebsystems.com: Quality OFBiz services for competitive rates
Re: Adding few more details for admin user (party) in demo data
If this is the case then we should have one more PARTY_TYPE seed data as ACCT_ONLY or ACCOUNT or similar. In that case we do not need the demo data for admin as he will not be a Person. But if we are continue on the admin as Person then it should have the demo data. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Fri, Dec 4, 2009 at 8:10 PM, Jeroen van der Wal jvander...@stromboli.itwrote: If you want to set up demo data the best pratice is to use real names (over the past I've used cartoon characters, actors, presidents). It makes no sense to use the admin as it is not a person nor an organization but just an account to perfom admin tasks. Just my 2 cents -Jeroen On Fri, Dec 4, 2009 at 10:34 AM, Ashish Vijaywargiya vijaywargiya.ash...@gmail.com wrote: WDYT if we add Shipping, Billing, Phone Credit Card info to admin user in a demo data? So all this information will be loaded when you will run ant run-install target. Thoughts? -- Ashish
Re: Naming pattern of test definition files
+1. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Dec 29, 2009 at 6:24 PM, Vikas Mayur vikas.ma...@hotwaxmedia.comwrote: Hi, The test definition files name is not consistent throughout the project. Some of the files name is all lowercase and others have camel case pattern. I think we can follow the pattern used in service definition files. The files under accounting/testdef are accountingtests.xml invoicetests.xml paymenttests.xml fixedassettests.xml and would be (after this change) tests.xml (generic test) tests_invoice.xml (tests specific to invoices) tests_payment.xml (tests specific to payments) tests_fixedasset.xml (tests specific to fixed assets) etc.. Any thoughts? Vikas
Re: breadcrums dropdown scheme
To make the dropdown menu transparent go to style.css of bizznesstime theme and on line 556 change the css of #header-nav to ; background:transparent none repeat scroll 0 0; If we look at the particular applications menu in bizzness time theme it will be shown as transparent. May need to do some more fixes in css to better show it on UI. So it is possible but should not recommended as the underlying screen text overlapped on the menu links, in turn it will be a pain for user to select on the correct menu item. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 7:53 AM, Hans Bakker mailingl...@antwebsystems.comwrote: A question from one of my customers: the dropdown menu, is it possible to make this transparent so you can see the underlying screen? Thanks in advance for your answer, regards, Hans -- Antwebsystems.com: Quality OFBiz services for competitive rates
Re: breadcrums dropdown scheme
Sorry, I see you are asking for breadcrubs dropdown, for that I'm not able to figure out how it can be achieve. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 10:59 AM, Rishi Solanki rishisolan...@gmail.comwrote: To make the dropdown menu transparent go to style.css of bizznesstime theme and on line 556 change the css of #header-nav to ; background:transparent none repeat scroll 0 0; If we look at the particular applications menu in bizzness time theme it will be shown as transparent. May need to do some more fixes in css to better show it on UI. So it is possible but should not recommended as the underlying screen text overlapped on the menu links, in turn it will be a pain for user to select on the correct menu item. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 7:53 AM, Hans Bakker mailingl...@antwebsystems.com wrote: A question from one of my customers: the dropdown menu, is it possible to make this transparent so you can see the underlying screen? Thanks in advance for your answer, regards, Hans -- Antwebsystems.com: Quality OFBiz services for competitive rates
Re: breadcrums dropdown scheme
Hi Hans, breadcrumbs dropdown's style.css line 1080 of #main-navigation ul li ul, #app-navigation ul li ul make its background to transparent will solves the transparent background problem. But for sure it should not be recommended. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 11:32 AM, Rishi Solanki rishisolan...@gmail.comwrote: Sorry, I see you are asking for breadcrubs dropdown, for that I'm not able to figure out how it can be achieve. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 10:59 AM, Rishi Solanki rishisolan...@gmail.comwrote: To make the dropdown menu transparent go to style.css of bizznesstime theme and on line 556 change the css of #header-nav to ; background:transparent none repeat scroll 0 0; If we look at the particular applications menu in bizzness time theme it will be shown as transparent. May need to do some more fixes in css to better show it on UI. So it is possible but should not recommended as the underlying screen text overlapped on the menu links, in turn it will be a pain for user to select on the correct menu item. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Jan 6, 2010 at 7:53 AM, Hans Bakker mailingl...@antwebsystems.com wrote: A question from one of my customers: the dropdown menu, is it possible to make this transparent so you can see the underlying screen? Thanks in advance for your answer, regards, Hans -- Antwebsystems.com: Quality OFBiz services for competitive rates
Re: Split shipment feature is gone on current 9.04 checkout screen(s)
Ruth, The multiform checkout was implemented as per covering all the possible functionality which may be on any site, then quick checkout is encrypt its some of the functionality and finally the one page is the most encrypted demo to do checkout in which many functionality are not covered intentionally. From your email it seems you are looking for the split shipment in One page checkout which is not available at all there. If you want that functionality there then yes you should create a Jira for that but as it is a new feature then it won't be go into release 9.04 it will be new implementation for trunk only. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Feb 2, 2010 at 6:41 AM, Ruth Hoffman rhoff...@aesolves.com wrote: The subject says it all...I'll submit a JIRA...if it really is missing. FYI - this was never on the Quick Checkout form and only available on the multi-form checkout. Now that the multiple form checkout is gone (replaced by another single form checkout called One Page Checkout) so is this feature. Or am I missing something? Regards, Ruth
Re: How to fill values for DropDown dependent on another DropDown selected value?
Refer getAssociatedStateList function in geoAutoCompleter.js, it get the associated states on the basis of country. To see how it works go to OnePageCheckout in ecommerce. Better ask such questions on user list. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Feb 3, 2010 at 1:56 PM, Awdesh Parihar awdesh.hot...@gmail.comwrote: Hello Sara, On change of Drop-down1(Product Category) , send a Ajax request. Ajax request will fetch list of Product Name and populate returned lint in Drop-down 2 . -- -- Thanks Regards Awdesh Singh Parihar Hotwax Media http://www.hotwaxmedia.com awdesh.pari...@hotwaxmedia.com - direct: +91 - 989.335.1789
Re: ERROR: EditCategory screen
On line 45 change to line to; new FlexibleStringExpander.VarElem() or new FlexibleStringExpander.CurrElem() will fix the page rendering but not sure which is appropriate. Adrian can give more light on this. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Fri, Feb 5, 2010 at 2:12 PM, Chatree Srichart chatree.srich...@gmail.com wrote: Hi, All I found an error in latest version. When I go to Catalog Demo Catalog Demo Browse Root, I get error page like this: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://product/widget/catalog/CategoryScreens.xml#EditCategory]: org.ofbiz.base.util.GeneralException: Error running Groovy script at location [component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy] (Error loading Groovy script at [component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy]: org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy: 45: You cannot create an instance from the abstract class 'org.ofbiz.base.util.string.FlexibleStringExpander'. @ line 45, column 20. filenameExpander = new FlexibleStringExpander(imageFilenameFormat); ^ 1 error (startup failed: component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy: 45: You cannot create an instance from the abstract class 'org.ofbiz.base.util.string.FlexibleStringExpander'. @ line 45, column 20. filenameExpander = new FlexibleStringExpander(imageFilenameFormat); ^ . . . Can any one check it? Regards Chatree Srichart
Re: ERROR: EditCategory screen
This has been addressed and fix by Abdulah Shaikh in OFBIZ-3443. He uses FlexibleStringExpander.getInstance() for getting new instance. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Fri, Feb 5, 2010 at 2:12 PM, Chatree Srichart chatree.srich...@gmail.com wrote: Hi, All I found an error in latest version. When I go to Catalog Demo Catalog Demo Browse Root, I get error page like this: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://product/widget/catalog/CategoryScreens.xml#EditCategory]: org.ofbiz.base.util.GeneralException: Error running Groovy script at location [component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy] (Error loading Groovy script at [component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy]: org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy: 45: You cannot create an instance from the abstract class 'org.ofbiz.base.util.string.FlexibleStringExpander'. @ line 45, column 20. filenameExpander = new FlexibleStringExpander(imageFilenameFormat); ^ 1 error (startup failed: component://product/webapp/catalog/WEB-INF/actions/category/EditCategory.groovy: 45: You cannot create an instance from the abstract class 'org.ofbiz.base.util.string.FlexibleStringExpander'. @ line 45, column 20. filenameExpander = new FlexibleStringExpander(imageFilenameFormat); ^ . . . Can any one check it? Regards Chatree Srichart
Re: product store shipment meth
Hi Adam, Go to catalog stores select a store say 9000 Go to Shipping we can remove the product store shipping association which will not expires but delete the record. Go to Shipping Estimates will give you opportunity to change the estimates. I think these business process will be able to handle all the scenarios you are talking about. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Mar 9, 2010 at 5:25 AM, Adam Heath doo...@brainfood.com wrote: How can I do date-like filtering on ProductStoreShipmentMeth? I see no fromDate/thruDate fields in ProductStoreShipmentMeth, ShipmentCostEstimate, CarrierShipmentMethod, nor ShipmentMethodType. How can I handle the cost estimates changing in the future, how can I cycle out old values, while still maintaining any existing database references?
Re: product store shipment meth
There are several entities which have from and thru date attributes but they can be enable the record again in future. But once the shipment estimates is increase or company stop to use any shipment method due to any reason then record for them is none of use for the company. It is just my opinion because I'm not able to see the use of which shipment method company uses in past wanna to look at. I'm for the existing handling if it will change then also I do not have any problem, but I believe the OFBiz Data Model is design in such manner that all generic requirements can be handle using it. If we are changing it then it is our specific wish or requirement. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Mar 9, 2010 at 10:26 PM, Adam Heath doo...@brainfood.com wrote: Rishi Solanki wrote: Hi Adam, Go to catalog stores select a store say 9000 Go to Shipping we can remove the product store shipping association which will not expires but delete the record. Go to Shipping Estimates will give you opportunity to change the estimates. I think these business process will be able to handle all the scenarios you are talking about. Well, I'd like to see what the values were in the past, for historical reasons. This could be done like any other date-filter based entity. I do see that ProductStoreShipmentMeth(and it's ShipmentCostEstimate) is only used to provide a list of available shipment types, and once the order is created, it is never used again. OrderItemShipGroup just references CarrierShipmentMethod. I don't like deleting ProductStoreShipmentMeth.
Re: ProductStoreEmailSetting code duplication
+1. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Mar 10, 2010 at 5:31 AM, Adam Heath doo...@brainfood.com wrote: I was noticing several cases where code was fetching a ProductStoreEmailSetting, then doing various setup work, before calling sendEmailFromScreen. None of the setup blocks are the same, the set of features they support are not unified. I'd like to move all these separate calls into a single shared worker method. Then, the second phase, would add a feature that would call a service to send the email, instead of always forcing it to be a screen. Anyone else agree with this?
Re: [VOTE] [RELEASE] Apache OFBiz 10.04
+1. Recently use the 10.04 for development now issues are minimal. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Sat, Jan 15, 2011 at 10:10 AM, Ankit Jain ankit.j...@hotwaxmedia.comwrote: +1 -- Regards Ankit Jain On Friday 14 January 2011 06:34 PM, Jacopo Cappellato wrote: This is the vote thread to transform our release candidate 10.04 into an official release. This will be the first release of the 10.04 series (that contains the features up to 2010-04). The files can be downloaded from here: http://people.apache.org/~jacopoc/dist/ Vote: [ +1] release as Apache OFBiz 10.04 [ -1] do not release For more details about this process please read this http://www.apache.org/foundation/voting.html Kind Regards, Jacopo
Re: Use sequenceNum on EntityType ?
Hi Nicolas, Currently only StatusItem and may 1 or 2 entities have this ability i.e sequenceNum as a field to reorder the types in the drop-down. There is no way to reorder the types in the drop-down, we just arrange it by its id or description. I personally think its interesting and nice idea to have this ability in all the EntityType, but not sure that to have the reordering ability for types we should add the sequenceNum or sequenceId. Lets come some more thoughts on this. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Tue, Jul 12, 2011 at 2:41 PM, Nicolas Malin malin.nico...@librenberry.net wrote: Hi, On a project I have reordered the drop-down type (CustRequestType, CommEvenType, etc ...) depending on the client's functional priorities. I caught sight it is difficult to do without an inherited form. For easy customer setup, adding a sequenceNum field on all EntityType will be interesting (with an generci entity-order on sequenceNum)? Or Do you have a particular practice run for just such cases Nicolas
Re: Entity engine, sql functions: MAX() MIN() AVG() and etc.
Look into the entitymodel.xml view entities. You will see the alias entity-alias= name= and function=avg or count or max or min or sum. For this you need to set the flag group-by=true on field for which you want to see the max or min or avg. so that it will work on that set only. HTH! Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Tue, Aug 2, 2011 at 3:24 PM, biletnikov biletni...@gmail.com wrote: Hello, is it possible to use the sql functions : MAX() MIN() AVG() and etc. via the entity engine? And how to do that? Thanks. -- View this message in context: http://ofbiz.135035.n4.nabble.com/Entity-engine-sql-functions-MAX-MIN-AVG-and-etc-tp3711848p3711848.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Issue : with disable userLogin not working.
Thanks David for your reply, It would be very help ful for us. Thanks and Regards [Rishi Solanki] On Sat, Aug 30, 2008 at 2:07 PM, David E. Jones [EMAIL PROTECTED]wrote: This is actually how it is supposed to work. Accounts are generally disabled because the user enters the wrong password X number of times, and then the account is automatically re-enabled after Y number of minutes. This is all configurable in the security.properties file, and the behavior can be changed there. Also, if you want to permanently disable a UserLogin, even with the OOTB settings you can set the disabled date to far in the future, and 5 minutes after that won't come up for a long time. -David Sumit Pandit wrote: When we tried to disable(block) a user login with following route. https://demo.hotwaxmedia.com/partymgr/control/editlogin?partyId=DemoCustomer1userLoginId=DemoCustomer1 Now here Set enable = N and save. Now after 5 mins, on ecommerce when i tried to do login with same user name : DemoCustomer1 and password ofbiz then it logged in successfully. So here after 5 mins userlogin is not disable/blocked any more. NOTE : I chacked in database at UserLogin entity (after disable via partymgr, login via ecommerce) Before login : enabled = N after login : enabled = N logout : enabled = N login again : enabled = Y where enabled is attribute of UserLogin entity. -- Thanks and Regards Sumit Pandit Rishi Solanki HotWaxMedia, Inc http://www.hotwaxmedia.com
Re: svn commit: r712292 - /ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
I think we need to add one link so user may have the option to create his
profile.
I know there is a link for login is exists, but we should provide a link to
register who visited the site as guest.
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 3:55 AM, [EMAIL PROTECTED] wrote:
Author: mor
Date: Fri Nov 7 14:25:42 2008
New Revision: 712292
URL: http://svn.apache.org/viewvc?rev=712292view=rev
Log:
Few links on ecommerce header should be visible only to logged in user,
hiding them for guest users
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl?rev=712292r1=712291r2=712292view=diff
==
--- ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
(original)
+++ ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Fri Nov 7 14:25:42 2008
@@ -106,11 +106,13 @@
/ul
ul id=right-links
!-- NOTE: these are in reverse order because they are stacked
right to left instead of left to right --
-li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
-li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
-li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
-li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
-li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+#if userLogin?has_content userLogin.userLoginId !=
anonymous
+li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
+li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
+li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
+li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
+li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+/#if
#if catalogQuickaddUse
li id=header-bar-quickadda
href=@ofbizUrlquickadd/@ofbizUrl${uiLabelMap.CommonQuickAdd}/a/li
/#if
Re: svn commit: r712292 - /ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Hello Vikas/All,
If we notice that on any site for example yahoo/gmail or any e commerce
site. There are two links available for any guest user in two ways ;
1). log in | register
2). sign in | sign up
So that user can go for registration from the main page itself. It means
that it is the regular and accepted convention followed by most of the site
(In my view all sites).
Also if a user not having any userLoginId then why he/she bother to click on
login link, and will definitely search for a link through which he/she can
register on that site.
One more thing in the designing of sites the navigation rules it self says
that we should provide all links on main page which are valid for a user. In
our case it is guest user who can create profile on our site.
It is only known to us that we can create our profile after clicking on
login and then on create. But not to user of that site.
Thoughts are most welcome !!
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 11:50 AM, Vikas Mayur [EMAIL PROTECTED]wrote:
inline.
On Nov 8, 2008, at 11:45 AM, Rishi Solanki wrote:
I think we need to add one link so user may have the option to create his
profile.
I know there is a link for login is exists,
I guess this is sufficient to create a profile.
Vikas
but we should provide a link to
register who visited the site as guest.
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 3:55 AM, [EMAIL PROTECTED] wrote:
Author: mor
Date: Fri Nov 7 14:25:42 2008
New Revision: 712292
URL: http://svn.apache.org/viewvc?rev=712292view=rev
Log:
Few links on ecommerce header should be visible only to logged in user,
hiding them for guest users
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl?rev=712292r1=712291r2=712292view=diff
==
---
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
(original)
+++
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Fri Nov 7 14:25:42 2008
@@ -106,11 +106,13 @@
/ul
ul id=right-links
!-- NOTE: these are in reverse order because they are stacked
right to left instead of left to right --
-li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
-li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
-li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
-li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
-li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+#if userLogin?has_content userLogin.userLoginId !=
anonymous
+li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
+li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
+li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
+li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
+li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+/#if
#if catalogQuickaddUse
li id=header-bar-quickadda
href=@ofbizUrlquickadd/@ofbizUrl${uiLabelMap.CommonQuickAdd}/a/li
/#if
Re: svn commit: r712292 - /ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Hello Vikas,
Here is the link for the jira issue and I have attach the patch for the
same.
https://issues.apache.org/jira/browse/OFBIZ-2038
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 8:35 PM, Vikas Mayur [EMAIL PROTECTED]wrote:
Rishi, Please provide the steps for this process (and probably a patch on
Jira) and I will follow up from there.
Vikas
On Nov 8, 2008, at 2:28 PM, Rishi Solanki wrote:
Hello Vikas/All,
If we notice that on any site for example yahoo/gmail or any e commerce
site. There are two links available for any guest user in two ways ;
1). log in | register
2). sign in | sign up
So that user can go for registration from the main page itself. It means
that it is the regular and accepted convention followed by most of the
site
(In my view all sites).
Also if a user not having any userLoginId then why he/she bother to click
on
login link, and will definitely search for a link through which he/she can
register on that site.
One more thing in the designing of sites the navigation rules it self says
that we should provide all links on main page which are valid for a user.
In
our case it is guest user who can create profile on our site.
It is only known to us that we can create our profile after clicking on
login and then on create. But not to user of that site.
Thoughts are most welcome !!
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 11:50 AM, Vikas Mayur [EMAIL PROTECTED]
wrote:
inline.
On Nov 8, 2008, at 11:45 AM, Rishi Solanki wrote:
I think we need to add one link so user may have the option to create his
profile.
I know there is a link for login is exists,
I guess this is sufficient to create a profile.
Vikas
but we should provide a link to
register who visited the site as guest.
--
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Sat, Nov 8, 2008 at 3:55 AM, [EMAIL PROTECTED] wrote:
Author: mor
Date: Fri Nov 7 14:25:42 2008
New Revision: 712292
URL: http://svn.apache.org/viewvc?rev=712292view=rev
Log:
Few links on ecommerce header should be visible only to logged in user,
hiding them for guest users
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Modified:
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl?rev=712292r1=712291r2=712292view=diff
==
---
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
(original)
+++
ofbiz/trunk/applications/ecommerce/webapp/ecommerce/includes/header.ftl
Fri Nov 7 14:25:42 2008
@@ -106,11 +106,13 @@
/ul
ul id=right-links
!-- NOTE: these are in reverse order because they are stacked
right to left instead of left to right --
-li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
-li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
-li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
-li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
-li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+#if userLogin?has_content userLogin.userLoginId !=
anonymous
+li id=header-bar-viewprofilea
href=@ofbizUrlviewprofile/@ofbizUrl${uiLabelMap.CommonProfile}/a/li
+li id=header-bar-ListQuotesa
href=@ofbizUrlListQuotes/@ofbizUrl${uiLabelMap.OrderOrderQuotes}/a/li
+li id=header-bar-ListRequestsa
href=@ofbizUrlListRequests/@ofbizUrl${uiLabelMap.OrderRequests}/a/li
+li id=header-bar-editShoppingLista
href=@ofbizUrleditShoppingList/@ofbizUrl${uiLabelMap.EcommerceShoppingLists}/a/li
+li id=header-bar-orderhistorya
href=@ofbizUrlorderhistory/@ofbizUrl${uiLabelMap.OrderHistory}/a/li
+/#if
#if catalogQuickaddUse
li id=header-bar-quickadda
href=@ofbizUrlquickadd/@ofbizUrl${uiLabelMap.CommonQuickAdd}/a/li
/#if
Re: [ANNOUNCE] Apache OFBiz 12.04.01 released
Thanks Jacopo, Glad to be part of the community. Congratulations! Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Tue, Apr 2, 2013 at 2:54 PM, Jacopo Cappellato jaco...@apache.orgwrote: The Apache OFBiz community is pleased to announce the new release Apache OFBiz 12.04.01. Apache OFBiz is an open source enterprise automation software project (ERP, CRM, E-Business / E-Commerce, MRP, SCM, CMMS/EAM...): http://ofbiz.apache.org/ Apache OFBiz 12.04.01 is the first release of the 12.04 series and contains all the features of the trunk up to April 2012 and since then has been stabilized with bug fixes. It is the OFBiz current stable release and users of the 11.04 series are encouraged to migrate to it in order to get all the new features implemented from April 2011 and April 2012. The release file can be downloaded following the instructions in the OFBiz download page : http://ofbiz.apache.org/download.html The OFBiz Team.
Re: Dojo tree 1.4
+1 for JQuery, it might be pain to learn newer tech, but as we recently start looking into it, we found It has much more easy ways to handle things. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Wed, Jun 9, 2010 at 10:15 AM, Deepak Dixit deepak.di...@hotwaxmedia.comwrote: Good idea Sascha, Yes jQuery is much better then Dojo and much faster then Prototype. Thanks Regards -- Deepak Dixit HotWax Media Pvt. Ltd. Sascha Rodekamp wrote: Hey guys, i started the work to update the Dojo libary to the current version 1.4. And i have to say that it didn't satisfy me to work on every Dojo based JaveScript for a little version update. It will coast a lot of time to test and update all the JavaScript Code. And what we have at the end a new heavy Dojo libary which brings a lot of widget but it's hard to extend :-) So i have another (maybe better idea). Why we didn't set Dojo and Prototype as depricated and starting to use jQuerry. In my optinion jQuerry is a better invest in the future. There are a lot of Widget/ Plugin's too and it's much lighter than Dojo. Instead of spending my time with updating all the Dojo stuff, i could spend my time to migrate all Prototype / Dojo based Code to jQuerry. What do you think? Cheers Sascha 2010/6/5 Anil Patel anil.pa...@hotwaxmedia.com Looks like good plan. Overtime people might choose to replace prototype framework with similar thing from Dojo. Thanks and Regards Anil Patel HotWax Media Inc Find us on the web at www.hotwaxmedia.com or Google Keyword ofbiz On Jun 5, 2010, at 1:13 PM, Jacques Le Roux wrote: So far I have mostly used Dojo for its tree in a CMS tool, and some Prototype functions notably for layered lookups. I still see them as complementary (Dojo coming more complete but heavier, Prototype being mostly an API). I does do think it's necessary to make a choice. Jacques From: Adrian Crum adrian.c...@yahoo.com From what I recall, the two libraries were included in the project with the idea that the most popular one would get used. At the time, Dojo was a very heavy library and the first attempts to use it resulted in very slow page loads. I used Prototype in some initial Ajax work - mainly because it was pretty easy to use. Today, I have no preference for either one. -Adrian --- On Sat, 6/5/10, Anil Patel anil.pa...@hotwaxmedia.com wrote: From: Anil Patel anil.pa...@hotwaxmedia.com Subject: Re: Dojo tree 1.4 To: dev@ofbiz.apache.org Cc: Anil Patel anil.pa...@hotwaxmedia.com Date: Saturday, June 5, 2010, 7:00 AM I started using Dojo in Ofbiz long back and in six months because of issues faced we switched to using prototype. At that time there were few others in comunity who liked prototype better. But I really don't remember the reasons. Since then new checkout process was added that uses prototype for all javascript needs. But did not remove Dojo because i did not want to upset anybody in community. Thanks and Regards Anil Patel HotWax Media Inc Find us on the web at www.hotwaxmedia.com or Google Keyword ofbiz On Jun 5, 2010, at 9:47 AM, Jacques Le Roux wrote: I have created a branch http://svn.apache.org/repos/asf/ofbiz/branches/dojo1.4 Nothing else for now Jacques From: Sascha Rodekamp sascha.rodekamp.lynx...@googlemail.com Hi Jacques ... jep it's a lot of work but not impossible :) A brunch is a good idea to start working on this project. I think the reason for Antil was, that he isn't use to Dojo. But that shouldn't be a problem the syntax isn't complicated. And by the way, if this will work the new Dojo will bring us a big benefit (in my opinion). Cheers Sascha 2010/6/5 Jacques Le Roux jacques.le.r...@les7arts.com Sascha, We should rather use the dev ML for this thread. Maybe it's the reason why Anil was reluctant to use Dojo? Jacques Jacques Le Roux wrote: Sascha Rodekamp wrote: Hey, so i started upgrading to dojo 1.4. The good point is ... Dojo 1.4 has many really cool new Features which can help us to improve the UI. The Bad thing is, some parts of the syntax had changed. That effects many parts in OFBiz (OnePageCheckout, Trees, all Dojo features Scripts :-)). Arg, I did not thought it will be so much trouble :/ So that's a lot of work and i can't do it on my own ... who volunteer to help me ;) ?? I could help First Step is to collect all depending issues and than to fix them step by step. So if we do that we need a branch I guess... Jacques Have a nice day Sascha -- http://www.lynx.de
Re: Removing the ShoppingCart.containOnlyDigitalGoods
+1. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Wed, Jul 7, 2010 at 5:24 PM, Bilgin Ibryam bibr...@gmail.com wrote: + 1 Bilgin On Wed, Jul 7, 2010 at 11:39 AM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: What about removing the ShoppingCart.containOnlyDigitalGoods methods and use instead the public boolean shippingApplies() ? (We will also need a new shippingApplies method that takes as input the shipgroup). In fact the logic in shippingApplies is the one used in several other places to determine the shipping charges. Kind regards, Jacopo
Re: Edit Product store survey
Hi Santosh, On clicking on the surveyId you will navigate to - https://localhost:8443/content/control/EditSurvey?surveyId=1000 Here you can edit it. Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Thu, Jul 15, 2010 at 5:12 PM, Santosh Malviya santosh.of...@gmail.comwrote: Hello dev, Is there any specific reason for not providing updation of product store survey. To see this follow steps: - (1) Go to Catalog click on Store menu, then click on Ofbiz ecommerce store. (2) Click on Surveys tab, you'll see there, adding and deleting survey to product store but there is no option for edit. Thanks and Regards Santosh Malviya
Re: svn commit: r786786 - /ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml
+1. :) -- Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Sat, Jun 20, 2009 at 4:07 PM, Ashish Vijaywargiya vijaywargiya.ash...@gmail.com wrote: Interesting revision number .. isn't it Mridul? Happy to see that this number is assigned to me and you Mridul. -- Ashish On Sat, Jun 20, 2009 at 3:36 PM, ash...@apache.org wrote: Author: ashish Date: Sat Jun 20 10:06:34 2009 New Revision: 786786 URL: http://svn.apache.org/viewvc?rev=786786view=rev Log: Applied patch from jira issue OFBIZ-2639 (Replacement Order against Wait Replacement Reserved Return is not being shipped) Thanks Mridul for the contribution. Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml?rev=786786r1=786785r2=786786view=diff == --- ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml (original) +++ ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml Sat Jun 20 10:06:34 2009 @@ -901,6 +901,7 @@ if-compare field=orderHeader.statusId operator=equals value=ORDER_HOLD set field=changeOrderStatusMap.statusId value=ORDER_APPROVED/ set field=changeOrderStatusMap.orderId from-field=returnItemResponse.replacementOrderId/ +set field=changeOrderStatusMap.setItemStatus value=Y/ call-service service-name=changeOrderStatus in-map-name=changeOrderStatusMap/ /if-compare if-compare field=orderHeader.statusId operator=equals value=ORDER_CANCELLED
Problem in running -ant clean-all ant run-install - trunk rev 788950.
Steps to reproduce : I tried derby database for installing ofbiz on trunk revision 788950 and then ran command ant clean-all ant run-install. I observed following error (Same error coming for external db i.e postgres): [java] 2009-06-27 17:18:27,489 (main) [ DatabaseUtil.java:2754:INFO ] Created 2 declared indices for entity [MrpEventType] [java] 2009-06-27 17:18:27,511 (main) [ DatabaseUtil.java:2754:INFO ] Created 2 declared indices for entity [NeedType] [java] Exception in thread main java.lang.NullPointerException [java] at org.ofbiz.entity.jdbc.DatabaseUtil.makeIndexClause(DatabaseUtil.java:2811) [java] at org.ofbiz.entity.jdbc.DatabaseUtil.createDeclaredIndex(DatabaseUtil.java:2776) [java] at org.ofbiz.entity.jdbc.DatabaseUtil.createDeclaredIndices(DatabaseUtil.java:2742) [java] at org.ofbiz.entity.jdbc.DatabaseUtil.checkDb(DatabaseUtil.java:397) [java] at org.ofbiz.entity.jdbc.DatabaseUtil.checkDb(DatabaseUtil.java:125) [java] at org.ofbiz.entity.datasource.GenericDAO.checkDb(GenericDAO.java:1090) [java] at org.ofbiz.entity.datasource.GenericHelperDAO.checkDataSource(GenericHelperDAO.java:195) [java] at org.ofbiz.entity.GenericDelegator.init(GenericDelegator.java:288) [java] at org.ofbiz.entity.GenericDelegator.getGenericDelegator(GenericDelegator.java:141) [java] at org.ofbiz.entityext.data.EntityDataLoadContainer.start(EntityDataLoadContainer.java:227) [java] at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101) [java] at org.ofbiz.base.start.Start.startStartLoaders(Start.java:271) [java] at org.ofbiz.base.start.Start.startServer(Start.java:320) [java] at org.ofbiz.base.start.Start.start(Start.java:324) [java] at org.ofbiz.base.start.Start.main(Start.java:407) [java] 2009-06-27 17:18:27,658 (OFBiz_Shutdown_Hook) [ ContainerLoader.java:114:INFO ] Shutting down containers [java] Java Result: 1 Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd.
Re: svn commit: r814553 - /ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml
IMO, We should keep the both profiles as we keep all checkout and from a configuration screen go for one. If it takes time then we should go for the older style profile as Jacques says, and keep the old profile for now. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Thu, Sep 17, 2009 at 2:32 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi Vikas, I'm sorry but I disagree with this change. As this stage, I'd far prefer to keep the old profile wich has much more options and looks better. So I ask the community opinion about that. You can still see the old profile if you run an R9.04 version or at http://ofbiz-vm.apache.org/ ( http://demo904.ofbiz.org/ecommerce/control/main fails at the moment) You can see the new provilei if you run the trunk or at http://demo.ofbiz.org/ecommerce/control/main but it fails at the moment, you may try http://lamouline.myvnc.com:28080/ecommerce during Europe nights (GMT+2) Thanks Jacques From: m...@apache.org Author: mor Date: Mon Sep 14 10:08:27 2009 New Revision: 814553 URL: http://svn.apache.org/viewvc?rev=814553view=rev Log: Changed the new profiles pages added a year back as the default one. Modified: ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml Modified: ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml?rev=814553r1=814552r2=814553view=diff == --- ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml (original) +++ ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml Mon Sep 14 10:08:27 2009 @@ -39,7 +39,8 @@ /widgets /section /screen - +!-- To use conventional pages uncomment following screens i.e. newcustomer and viewprofile and comment new screens i.e. newcustomer and viewprofile screens below -- +!-- screen name=newcustomer section actions @@ -76,6 +77,7 @@ /widgets /section /screen +-- screen name=editcontactmech section actions @@ -518,8 +520,7 @@ /widgets /section /screen -!-- To use new pages uncomment following screens i.e. newcustomer and viewprofile and comment existing newcustomer and viewprofile screens above -- -!-- + screen name=newcustomer section actions @@ -563,7 +564,6 @@ /widgets /section /screen --- screen name=EditProfile section
Re: Create only HR Module
Hi Rakesh, Create a webapp in hot-deploy, setup your directory structure into it. In the directory structure add files controller.xml and web.xml files. Include the controller of parent application in you custom application controller. configure the build.xml and ofbiz-component.xml for custom application. Now you have the same application running for your custom project, which is ready for the more customization. By doing this way your application will be dynamic enough to easily upgrade the OFBiz instance for the same application. Removing other modules from OFBiz will not work at all as HR module itself depends upon other module. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Oct 27, 2009 at 9:16 PM, Rakesh rakesh.sahade...@gmail.com wrote: How to customize ofbiz in such way that I want to use only HR module. What I am expecting is to remove other modules from Ofbiz. Thanks in Advance Rakesh -- View this message in context: http://n4.nabble.com/Create-only-HR-Module-tp277258p277258.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Create only HR Module
Hi Rakesh, Please ask such questions on user list. To know more about mailing list purpose visit - http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Oct 28, 2009 at 11:23 AM, Rishi Solanki rishisolan...@gmail.comwrote: Hi Rakesh, Create a webapp in hot-deploy, setup your directory structure into it. In the directory structure add files controller.xml and web.xml files. Include the controller of parent application in you custom application controller. configure the build.xml and ofbiz-component.xml for custom application. Now you have the same application running for your custom project, which is ready for the more customization. By doing this way your application will be dynamic enough to easily upgrade the OFBiz instance for the same application. Removing other modules from OFBiz will not work at all as HR module itself depends upon other module. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Oct 27, 2009 at 9:16 PM, Rakesh rakesh.sahade...@gmail.comwrote: How to customize ofbiz in such way that I want to use only HR module. What I am expecting is to remove other modules from Ofbiz. Thanks in Advance Rakesh -- View this message in context: http://n4.nabble.com/Create-only-HR-Module-tp277258p277258.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Create only HR Module
+1. For sure it should use and we should recommend. ;-) Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Wed, Oct 28, 2009 at 2:48 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi Rishi, Can't the create-component ant target be used ? I did not try it yet, and I saw there is a small issue with it, but should we not recommend its usage ? BTW, thanks for the user ML advice ;o) Jacques From: Rishi Solanki rishisolan...@gmail.com Hi Rakesh, Create a webapp in hot-deploy, setup your directory structure into it. In the directory structure add files controller.xml and web.xml files. Include the controller of parent application in you custom application controller. configure the build.xml and ofbiz-component.xml for custom application. Now you have the same application running for your custom project, which is ready for the more customization. By doing this way your application will be dynamic enough to easily upgrade the OFBiz instance for the same application. Removing other modules from OFBiz will not work at all as HR module itself depends upon other module. Rishi Solanki Enterprise Software Developer HotWax Media Pvt. Ltd. On Tue, Oct 27, 2009 at 9:16 PM, Rakesh rakesh.sahade...@gmail.com wrote: How to customize ofbiz in such way that I want to use only HR module. What I am expecting is to remove other modules from Ofbiz. Thanks in Advance Rakesh -- View this message in context: http://n4.nabble.com/Create-only-HR-Module-tp277258p277258.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: ATP not automatic decrease when a order is created
Hoan dang van, As requested on original ticket where you shared this problem, could you please share the complete product store xml data you have setup. It will help us to diagnose the problem you are facing. I'm assuming you are using 13.07 or trunk to setup your store. Best Regards, Rishi Solanki Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Tue, Nov 25, 2014 at 1:01 PM, Hoan dang van hoand...@gmail.com wrote: Hi Scott Gray! I have set up reserve inventory is Y. On Tue, Nov 25, 2014 at 1:23 PM, Scott Gray scott.g...@hotwaxmedia.com wrote: Is your store configured to reserve inventory? It's that setting that causes reservations to be created which in turn to decreases ATP Regards Scott On Tue, Nov 25, 2014 at 6:05 PM, Hoan dang van hoand...@gmail.com wrote: When I configure store in catalog component and i selected Is Immediately Fulfilled Tab is N then i create a order by webpos. The order is completed but when i check this order in order, i appear that the product that i buy, have Qty Shipped status is 0 and Ship Request status is 2 (2 is quantity that i bought in this order) When i selected again Is Immediately Fulfilled Tab is Y , Qty Shipped status is 2 and Ship Request status is 0. Then i create a order by order component , Order is created but ATP of product that i bought with this order, not automatic decrease (equal before i bought ) Can everybody tell me where i do wrong and how to fix it Thanks
Add me as a contributor
Hello Team, Please add me as a contributor, below is my confluence user id I have created; user name: rishisolankii email address: rishisolan...@gmail.com -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com
Re: Add me as a contributor
Thank you Jacques. Yes I did (ICLA file) it on 29th-Nov-2014 on the date of requesting for adding. Thanks again! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Sat, Nov 29, 2014 at 4:34 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Done Rishi , did you fill a ICLA? Thanks Jacques Le 29/11/2014 10:15, Rishi Solanki a écrit : Hello Team, Please add me as a contributor, below is my confluence user id I have created; user name: rishisolankii email address: rishisolan...@gmail.com -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Media Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com
Re: [PROPOSAL] Move appserver component to OFBiz Attic
+1. Best Regards, -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Mar 17, 2015 at 5:46 PM, Deepak Dixit deepak.di...@hotwaxsystems.com wrote: +1 And I also agree with Adrian. Thanks Regards — Deepak Dixit On Mar 17, 2015, at 5:01 PM, Pierre Smits pierre.sm...@gmail.com wrote: *Rationale:* Back in the day (pre r11.x) we enabled users to have OFBiz working in external web containers, like Apache Tomcat, IBM Websphere and Jetty. However, focus of the community migrated away from that and improved the use of the internally used servlet solution (also Apache Tomcat). Since then the functionality of the component to have OFBiz work with these external web containers stopped working and in recent years no contributor felt the itch to correct/improve this situation. I therefor propose: - that we move the component from trunk to our attic, and - we don't include it in future releases (including the upcoming r14.x branch release r14.12.01) For this proposal the normal 72 hour rule applies. Best regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com
Re: Welcome to Deepak Dixit as new committer!
Many congratulations Deepak !!! :) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxmedia.com On Thu, Mar 12, 2015 at 5:04 PM, Nitesh Goyal nitesh.go...@hotwaxsystems.com wrote: Many congratulations Deepak! -- Thanks Regards Nitesh Goyal HotWax Systems Pvt. Ltd. www.hotwaxsystems.com On Thu, Mar 12, 2015 at 4:55 PM, Gavin Mabie kwikst...@gmail.com wrote: Congratulations Deepak On Thu, Mar 12, 2015 at 1:19 PM, Jacopo Cappellato jacopo.cappell...@hotwaxsystems.com wrote: The OFBiz PMC has invited Deepak Dixit to become a new committer and he has accepted the new role. Deepak, thank you for your continued commitment and valuable contributions. Welcome onboard! Jacopo
Re: Taher Alkhateeb joins the OFBiz PMC
Congratulations Taher !! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 10, 2016 at 3:51 PM, Swapnil Shah < swapnil.s...@hotwaxsystems.com> wrote: > Congratulations Taher !! > > Thanks & Regards, > Swapnil > > -Original Message- > From: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] > Sent: Friday, June 10, 2016 11:36 AM > To: dev@ofbiz.apache.org > Subject: Taher Alkhateeb joins the OFBiz PMC > > Welcome, Taher! Keep up the great work. > > Jacopo >
Re: Enforce noninstantiability with a private constructor
Team, We have started pushing changes into trunk, in case anyone would like to review then we are keeping it very simple; - For any class we have an sub ticket with class name. - On the ticket description we are posting the changes needs to be done, then discuss and finalize the changes. - Upload the patch with same finalized changes and edit the ticket's description accordingly. If you would like to review, then commit, patch and ticket description all are same so that can be reviewed easily. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Jun 18, 2016 at 7:56 PM, Rishi Solanki <rishisolan...@gmail.com> wrote: > Moving thread to dev list. > > All, we have started effort on this under OFBIZ-7272. In that effort we > found some classes isn't in use. Once completed this effort we will share > them for discussion so that we can decide weather to keep them in OFBiz or > we are good to remove them. > > > -- > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > ------ Forwarded message -- > From: Rishi Solanki <rishisolan...@gmail.com> > Date: Fri, Jun 10, 2016 at 7:40 PM > Subject: Re: Enforce noninstantiability with a private constructor > To: ofbizuser <u...@ofbiz.apache.org> > > > Taher, > > Thank you very much for your inputs. I was thinking to do the same to add > private constructors first then do other things. But after your reply I > think better to pick one class at a time, and check everything for that > class which includes removing public modifiers, method and fields. Marking > classes members as final and all your suggestions. > > We would start picking classes one by one, and check all its references > and finally make necessary changes for each class. In that way we would be > able to match the classes with purpose. This is better way to fix this > design flaw. > > Thanks! > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Fri, Jun 10, 2016 at 5:00 PM, Taher Alkhateeb < > slidingfilame...@gmail.com> wrote: > >> Hi Rishi, >> >> I would suggest when refactoring such classes to apply everything that has >> to do with visibility including: >> - Removing public modifiers if not needed on class, method, and field >> levels >> - adding private where appropriate >> - marking classes, methods and fields as final where appropriate >> - marking method arguments as final where appropriate >> >> So I would consider a private constructor to be just one of a suite of >> activites that I call them collectively as visibility and mutability which >> are important to provide real isolation between the components with >> minimal >> dependencies. >> >> My 2 cents >> >> Taher Alkhateeb >> >> On Fri, Jun 10, 2016 at 2:22 PM, Rishi Solanki <rishisolan...@gmail.com> >> wrote: >> >> > Dear All, >> > >> > In past we did same for CatalogWorker, ProductWorker, CategoryWorker, >> and >> > UtilMisc classed. Now I think for all the utility, worker, helper >> classes >> > having only static members are eligible to have an private constructor >> with >> > them to make them non instantiable from anywhere. >> > >> > We have log an JIra and added patch for the same. So requesting you to >> take >> > a look at OFBIZ-7272 for more details and share your feedback in case we >> > can do the same for more classes or if any classes we have added should >> not >> > be in list. >> > >> > Thanks for your help in advance. >> > >> > >> > Rishi Solanki >> > Manager, Enterprise Software Development >> > HotWax Systems Pvt. Ltd. >> > Direct: +91-9893287847 >> > http://www.hotwaxsystems.com >> > >> > > >
Re: Javascript clean up and improvements
+1. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 24, 2016 at 2:13 PM, Divesh Dutta < divesh.du...@hotwaxsystems.com> wrote: > +1 Amardeep. > > > Thanks > -- > Divesh Dutta. > > On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj < > amardeep.jh...@hotwaxsystems.com> wrote: > > > Hello everyone, > > > > Currently, OFBiz javascript code (except third party libraries) is not > > written with the best practices which can cause following problems - > > > > 1. Increases the code maintenance effort. > > 2. Impact page performance. > > 3. Present not good examples to new contributors which leads to C/P to > > various areas of js code. > > > > Here are things we should do for cleanup and improvements in js code. > > > > 1. Remove unused javascript code and files if any. > > 2. Use best practices for javascript coding to improve performance (I > have > > listed some of it below). > > 3. Move utility js functions to one js file. > > 4. Remove deprecated code and use latest. For ex: We are still using > > "language='javascript'" attribute at script tag which is deprecated a > years > > ago. > > 5. js should be loaded at bottom of the page, currently its in Header. > Its > > a tedious task now to move it into footer because we have lot of js code > > inline in ftls. > > 6. js should not be written inline, it should be enough generic to be in > > minimum number of files and have generic code for doing the common set of > > operations over DOM. > > 7. Currently our macros of rendering pages has inline scripts, they can > be > > moved to one macrorenderer.js with generic code as we can use classes, > ids > > and data-attributes for doing any operation over html DOM. > > 8. After all cleanup work, we can think of build tool (like grunt) for > > various javascript build tasks (minification, concatenation of files) if > > needed. Its just a thought. > > > > I know its a huge effort and need to be done carefully. So before doing > any > > major changes, I would like to start work with first 4 points. > > > > Here is the list of some best practices to start with: > > > > 1. Use [] Instead of New Array() > > 2. Long list of variables? Omit the "Var" keyword and use commas instead. > > 3. Reduce global variables > > 4. Use explicit blocks > > 5. Start blocks on the same line > > 6. Always, Always Use Semicolons - Having said that, this is a very bad > > practice that can potentially lead to much bigger, and harder to find, > > issues. > > 7. Optimize loops. Avoid calculating the length of array in for loop > > iteration. > > 8. Avoid multiple redundant jQuery DOM manupulation by saving reference > to > > any object. > > 9. Try to use meaningful comments. > > 10. Many more. > > > > Here are some links of best practices information- > > > > https://www.w3.org/wiki/JavaScript_best_practices > > http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices > > https://developer.yahoo.com/performance/rules.html > > > > If everyone agrees, I would like to start on this work. > > > > Please let me know your thoughts on it. > > > > Thanks and Regards > > -- > > Amardeep Singh Jhajj > > >
Re: Track user for status change
+1, Nameet. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain <nameet.j...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the > history for each status change made by user. > > I will recommend here to add 'changedByUserLoginId' field to track the > userlogin detail. Here is the list of entities with missing such type of > field. > > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus > > Please let me know your thoughts. If it looks good I will open a ticket for > the same. > > Thanks > > -- > Regards, > Nameet Jain >
Fwd: Enforce noninstantiability with a private constructor
Moving thread to dev list. All, we have started effort on this under OFBIZ-7272. In that effort we found some classes isn't in use. Once completed this effort we will share them for discussion so that we can decide weather to keep them in OFBiz or we are good to remove them. -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com -- Forwarded message -- From: Rishi Solanki <rishisolan...@gmail.com> Date: Fri, Jun 10, 2016 at 7:40 PM Subject: Re: Enforce noninstantiability with a private constructor To: ofbizuser <u...@ofbiz.apache.org> Taher, Thank you very much for your inputs. I was thinking to do the same to add private constructors first then do other things. But after your reply I think better to pick one class at a time, and check everything for that class which includes removing public modifiers, method and fields. Marking classes members as final and all your suggestions. We would start picking classes one by one, and check all its references and finally make necessary changes for each class. In that way we would be able to match the classes with purpose. This is better way to fix this design flaw. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 10, 2016 at 5:00 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Hi Rishi, > > I would suggest when refactoring such classes to apply everything that has > to do with visibility including: > - Removing public modifiers if not needed on class, method, and field > levels > - adding private where appropriate > - marking classes, methods and fields as final where appropriate > - marking method arguments as final where appropriate > > So I would consider a private constructor to be just one of a suite of > activites that I call them collectively as visibility and mutability which > are important to provide real isolation between the components with minimal > dependencies. > > My 2 cents > > Taher Alkhateeb > > On Fri, Jun 10, 2016 at 2:22 PM, Rishi Solanki <rishisolan...@gmail.com> > wrote: > > > Dear All, > > > > In past we did same for CatalogWorker, ProductWorker, CategoryWorker, and > > UtilMisc classed. Now I think for all the utility, worker, helper classes > > having only static members are eligible to have an private constructor > with > > them to make them non instantiable from anywhere. > > > > We have log an JIra and added patch for the same. So requesting you to > take > > a look at OFBIZ-7272 for more details and share your feedback in case we > > can do the same for more classes or if any classes we have added should > not > > be in list. > > > > Thanks for your help in advance. > > > > > > Rishi Solanki > > Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > >
Re: Javascript clean up and improvements
After merging the separate branch we may have regression, picking one item do regression testing over trunk will minimize the regression. +1 Amardeep, good way to go. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Jun 28, 2016 at 11:21 AM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello Jacques, > > Making branch is a good idea to handle regressions but I would prefer to > work in trunk itself. Here are the things we should consider before > creating new branch: > > 1. Branch can be abandoned, I would prefer to have code changes in trunk in > proper steps instead of merging the complete branch work later in trunk. > 2. Currently, lot of changes is coming in trunk, so different branch need > to updated regularly. Its also an additional work. > > To avoid regressions, we can do our work in granular level tasks for > various functionality (wherever needed) and proper testing steps will be > there. The code changes will only be committed after thorough testing. > > First, I would like to start with cleanup of inline javascripts so that all > javascript code will only in js files which helps us to follow best > practices of javascript. > Here is the steps can be taken to do it: > > 1. Start with one component. For example: Accounting. > 2. Pick its various functionality one by one where javascript is added > inline. > 3. Do cleanup in it. > 4. Do thorough testing for it with testing steps over ticket. > > Once the all cleanup (inline js cleanup) is done, we would have javascript > files for further work. We can further break the js work by functionality > (if needed) for improvements. > > The above process will assure us that nothing will break. I will not work > on this effort alone, the team of developers having two or more year > experience in javascript will work with me. > > I will create the parent ticket for selenium tests as well and we will see > how we can work on it. > > Thanks & Regards > -- > Amardeep Singh Jhajj > www.hotwaxsystems.com > > On Sat, Jun 25, 2016 at 1:06 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi Amardeep, > > > > What I mean is we should be cautious. Hence the suggestion to create a > > branch for the refactoring. And to benefit from this opportunity to put > > some Selenium tests related with js (eg: calendar - could also use HTML5 > > now -, autocompletion, lookups, dependent dropdowns). That would be a > start > > for Selenium, no needs to have tons of it. A Jira subtask would be > perfect. > > > > Hope I'm clearer > > > > Thanks > > > > Jacques > > > > > > > > Le 24/06/2016 à 15:53, Amardeep Singh Jhajj a écrit : > > > >> Thanks all for approval. > >> > >> Thanks Taher and Deepak for valuable suggestions. I will think on them. > >> > >> Jacques, > >> > >> I am bit confused by your reply, could you please elaborate your point. > >> > >> Regards, > >> -- > >> Amardeep Singh Jhajj > >> > >> > >> On Fri, Jun 24, 2016 at 4:17 PM, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >> Amardeep, > >>> > >>> I agree with your points, I'd just request that we do that in a branch > >>> with a load of UI tests (good occasion to use Selenium). > >>> Our js code is complex and fragile, I think notably at the global > >>> variables in fieldlookup.js and selectall.js which are maybe hard to > >>> avoid. > >>> IMO those files are the main pains. > >>> > >>> Thanks > >>> > >>> Jacques > >>> > >>> > >>> > >>> Le 24/06/2016 à 09:20, Amardeep Singh Jhajj a écrit : > >>> > >>> Hello everyone, > >>>> > >>>> Currently, OFBiz javascript code (except third party libraries) is not > >>>> written with the best practices which can cause following problems - > >>>> > >>>> 1. Increases the code maintenance effort. > >>>> 2. Impact page performance. > >>>> 3. Present not good examples to new contributors which leads to C/P to > >>>> various areas of js code. > >>>> > >>>> Here are things we should do for cleanup and improvements in js code. > >>>> > >>>> 1. Remove unused javascript code and files if any. > >>>> 2. Use best practices fo
Re: Showing Invoice address from PartyContactMech
Agree with overriding the method signature. Just one note is to keep the existing behavior as default. That means, if developer use the same method then it should behave how it behaves right now. Regards, -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, May 11, 2016 at 4:52 PM, Arun Patidar < arun.pati...@hotwaxsystems.com> wrote: > Hello All, > > In getInvoiceAddressByType() method of InvoiceWorker, it is fetching > address from PartyContactWithPurpose in case of empty InvoiceContactMech. > This method calls from two methods getBillToAddress() and > getSendFromAddress() of same class. > > Here, my concerns are: > - There is no way to check that returned address is invoice associated > address or party address. It is misleading. > - There is no control of user to get the address linked to invoice only. > > My proposals are: > 1). System should return party address only if user really demand for it. > We can override method and pass additional parameter for achieving this. > 2). We can remove PartyContactMech fetching logic from method by > considering that user don't want party addresses as Invoice address. > > This will help user to know the exact source of address. Please let me > know your thoughts on this. > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > HotWax Systems > www.hotwaxsystems.com > >
Re: Entity and Service definition
Thank you Taher, and yes I had the same concern for it, even when we are working on enforcing noninstantiability, but we will be able to achieve zero regression till now by doing internal multi-level QA. Thanks for pointing this, we will ensure before proceeding for any changes. :) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Jul 12, 2016 at 2:13 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Hi Rishi, > > Great Ideas, +1 for all suggestions. > > I only have one warning because this happened in the past: Do not switch > from Services to entity-auto without being 100% sure this is the right > thing to do. Sometimes you miss important logic that breaks things > elsewhere. > > Thank you for the initiative, I love this enthusiasm and energy :) > > Cheers! > > Taher Alkhateeb > > On Tue, Jul 12, 2016 at 11:31 AM, Rishi Solanki <rishisolan...@gmail.com> > wrote: > > > Dear Folks, > > > > While working/reviewing recent work in community, I observed some > > improvement/fixes required at entity and related service implementation. > > For few entities like InvoiceAttribute, InvoiceType, etc. no service > exists > > to create/update/delete. At the time of writing migration scripts I > always > > see lack of such services, which can be used to define new types or > > attributes. Also Many entities have some other problems in basic design > of > > CRUD operations and in definitions; > > > > On further look into this in detail found many such entities which do not > > have services. I would like to propose a refactoring at basic design > level > > which covers following which does not impact on functionality we have; > > > > 1) Many entity definitions having relationships with view-entities, like > > OrderHeader entity maintain relationship with OrderHeaderNoteView and > > OrderItemAndShipGroupAssoc. We should remove it, maintain the > relationship > > at view-entities level if required. Also change the code where this > > relation is in use. > > 2) Many entities having service implementation exists but they can be > > simply convert into entity-auto, that means can use the power OFBiz > > provides. > > 3) As mentioned initially many entities do not have CRUD services exists, > > we should implement or use entity-auto for them wherever applicable. Also > > remove direct use of delegator for them. > > 4) Many entities having from date and thru date, Or status Or Enumeration > > to manage the historical data, but services actually remove those entity > > data. We should change the service implementation to maintain the > > historical data. > > > > After this effort, OFBiz will have minimum direct use of delegator, > > enriched use of service engine, we would be able to established > > patterns/best practice to introduce a new entities, and writing new > > services. > > > > I would love to hear more improvements in this area from community. We > will > > add them in this effort only. > > > > > > Rishi Solanki > > Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > >
Entity and Service definition
Dear Folks, While working/reviewing recent work in community, I observed some improvement/fixes required at entity and related service implementation. For few entities like InvoiceAttribute, InvoiceType, etc. no service exists to create/update/delete. At the time of writing migration scripts I always see lack of such services, which can be used to define new types or attributes. Also Many entities have some other problems in basic design of CRUD operations and in definitions; On further look into this in detail found many such entities which do not have services. I would like to propose a refactoring at basic design level which covers following which does not impact on functionality we have; 1) Many entity definitions having relationships with view-entities, like OrderHeader entity maintain relationship with OrderHeaderNoteView and OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at view-entities level if required. Also change the code where this relation is in use. 2) Many entities having service implementation exists but they can be simply convert into entity-auto, that means can use the power OFBiz provides. 3) As mentioned initially many entities do not have CRUD services exists, we should implement or use entity-auto for them wherever applicable. Also remove direct use of delegator for them. 4) Many entities having from date and thru date, Or status Or Enumeration to manage the historical data, but services actually remove those entity data. We should change the service implementation to maintain the historical data. After this effort, OFBiz will have minimum direct use of delegator, enriched use of service engine, we would be able to established patterns/best practice to introduce a new entities, and writing new services. I would love to hear more improvements in this area from community. We will add them in this effort only. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com
Re: Entity and Service definition
Thank you everyone for your approval and suggestion. We would try to follow most, and log Jira accordingly. Soon will start on this. Nicolas, thanks for pointing expire action on entity-auto. Jacques, Pierre, thanks for suggestion on managing Jira tickets, and you guys anyways helped us in our last effort in managing Jira tickets and review. Thanks for that. Plan is something like this, we would pick the easy entities first where we found minimum changes. After delivering few we will be able to establish practice internally, on what items we should take care before fixing an entity/service. We would like to go slow initially, and as soon as we start on it delivery process will more clear. Thanks again for your help, and looking forward for same in the big effort planned. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Jul 13, 2016 at 2:36 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 13/07/2016 à 09:39, Pierre Smits a écrit : > >> At this moment in time, I can't fathom how much effort is involved in this >> factoring, but I suggest to break it down as much as possible into >> separate >> JIRA issues. For instance, the rework on the removal of the >> OrderHeaderNoteView >> and OrderItemAndShipGroupAssoc from the OrderHeader entity can be a >> separate issue. Please be aware, that this might have a big impact in >> various functions/services/etc. >> >> Best regards, >> >> Pierre Smits >> > That's a good advice Pierre, from what I have seen these last months from > the HW effort, I'm confident they are totally aware of what to do :) > > Jacques > >
Re: Entity and Service definition
Starter effort on this under - OFBIZ-7828. Community review / feedback / suggestion / concerns are welcome. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Jul 14, 2016 at 9:58 AM, Rishi Solanki <rishisolan...@gmail.com> wrote: > Thank you everyone for your approval and suggestion. We would try to > follow most, and log Jira accordingly. Soon will start on this. > > Nicolas, thanks for pointing expire action on entity-auto. > > Jacques, Pierre, thanks for suggestion on managing Jira tickets, and you > guys anyways helped us in our last effort in managing Jira tickets and > review. Thanks for that. > > Plan is something like this, we would pick the easy entities first where > we found minimum changes. After delivering few we will be able to establish > practice internally, on what items we should take care before fixing an > entity/service. We would like to go slow initially, and as soon as we start > on it delivery process will more clear. > > > Thanks again for your help, and looking forward for same in the big effort > planned. > > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Wed, Jul 13, 2016 at 2:36 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Le 13/07/2016 à 09:39, Pierre Smits a écrit : >> >>> At this moment in time, I can't fathom how much effort is involved in >>> this >>> factoring, but I suggest to break it down as much as possible into >>> separate >>> JIRA issues. For instance, the rework on the removal of the >>> OrderHeaderNoteView >>> and OrderItemAndShipGroupAssoc from the OrderHeader entity can be a >>> separate issue. Please be aware, that this might have a big impact in >>> various functions/services/etc. >>> >>> Best regards, >>> >>> Pierre Smits >>> >> That's a good advice Pierre, from what I have seen these last months from >> the HW effort, I'm confident they are totally aware of what to do :) >> >> Jacques >> >> >
Re: Token Based Authentication with Apache OfBiz
Rahul, Thanks for detailed proposal, I gone thru all the details. No changes in the current auth system, and achieving token based authentication looks a good idea to me. Agree on all the details provided and will try to participate in the reviewing the design/implementation. +1. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jun 20, 2016 at 2:24 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > We (I was then working with ilscipio) did something like that for a > client, and I agree it's the way to go. > > I mean that I agree with "We are not going to implement the Token Based > Authentication process at low level. Behind the scenes, we will be using > the current work flow as is" > > Disclaimer: I did not look into all details. Also we planned to use OpenId > but eventually the Token Based Authentication we used was specific and > proprietary to the client (this remembered me > http://markmail.org/message/7vtjvjomneimspvl) > > Jacques > > > > Le 18/06/2016 à 15:01, Rahul Bhooteshwar a écrit : > >> Hello All, >> Recently felt the need of Token Based Authentication process in Apache >> OfBiz while using OfBiz's business process offerings with standalone >> clients like Mobile Apps, Angular JS based apps running outside Apache >> OfBiz etc. >> >> What currently we are having in OfBiz is session based authentication >> process which is *stateful*. But while dealing with the independently >> running remote clients stateful authentication is not gonna work as we >> will >> not be using *server-browser session* anymore in those cases. >> >> Following are the initial draft & supporting documents to proceed further: >> >> - Token Based Authentication in Apache OfBiz >> < >> https://docs.google.com/document/d/1xbpjNWGZp8B_79YJmPxmSJqkx7Qo_EI7u_PE0WNt3B4/edit#heading=h.g14rrmsoijiv >> > >> - Token Based Authentication >> < >> https://docs.google.com/document/d/15QBV87vMD42QppCaHpxgcefcg_ac7HFeSQQnF_S50nk/edit#heading=h.mdriqalojfy4 >> > >> - JSON Web Tokens >> < >> https://docs.google.com/document/d/1wLfv8h_Kkd4iHBxW4Gkx987Q7KBocWAGvss2p4N4fIM/edit >> > >> - IETF's (Internet Engineering Task Force) Documentation for JSON Web >> Tokens >> < >> https://drive.google.com/file/d/0BzXOhs4-o0n9cHVGckgwUndsUGc/view?pref=2=1 >> > >> >> I would like to propose a requirement to implement this in OfBiz, & invite >> you all to provide valuable inputs to conclude the requirements & >> implementation plans. >> >> Thanks and Regards >> *Rahul Bhooteshwar* >> Enterprise Software Engineer >> HotWax Systems <http://www.hotwaxsystems.com/> - *Global leader in >> innovative enterprise commerce solutions **powered by Apache OFBiz.* >> >> >
Re: User Acceptance Test Cases For Ecommerce 14.12
Thanks Jacques for your reply and raising concerns. It seems that, I was not clear enough. Let me try to rephrase what we are doing. If you observe then Pranay has created new hierachy for each release like 14.12, 15.12 ... so on. For each release we have the user stories, and we are adding UATs for each user story. For each user story we are discussing the cases we should test manually and also try them to dicuss on the mailing list (user/dev). Once we are sure, we document and test the cases (manually) and put the results in the Actual results and Pass/Fail. Please note that, before documenting anything as Pass or Fail we are really running that scenario. The intention of doing this, we can say that the released branches of OFBiz are tested on certain scenarios and all get passed. After completing this activity, we as a community can say 14.12 branch tested for say 1000 user acceptance test cases and out of them 950 get passed and 50 are reported and fail for that branch. Once we complete this activity, we could start fixing them. For the same we have started multiple email threads to get the feedback from community, so that we could get more cases for the user stories. In other words, we have automated tests with us, but this time we are trying to add documents for the manual tests user could see and increase in faith on each relase. I hope I'm clear this time :-). And yes I agree on the fact that we should think on automating these tests to run them frequently. And I think for that we again need what to tests get documented. We can assume it as first step towards automation. PS: Team, please add more details if I miss something. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > This is interesting, do you envision a mean to automate these tests and > run them frequently? > > Say either on each build (using BuildBot for instance), or on another > frequency if they happens to be at term longer than our commit frequency > would support. > > So the question is do you plan to use a tool for that? I say that because > it seems to me that Cucumber (MIT license) could be used for that... > > Jacques > > > Le 21/01/2017 à 16:51, Rishi Solanki a écrit : > >> Devs, >> >> We have started working on few user stories mentioned at Ecommerce-14.12 >> <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and >> adding user acceptance test (UAT) cases for them. For now we have added >> test cases for two user stories as follows; >> - Login Page >> - Login and Update Personal Information >> >> We have updated the document with the identified UATs so that can get >> feedback from community on them. >> >> - For now we have added the UATs just below the user stories in the >> document. Please let us know if we are fine with this location? >> - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned two >> user stories. Please review and let us know your thoughts on it, so that >> we >> can follow one common pattern. >> >> Any other feedback in UATs are most welcome to improve the quality. Going >> forward we would follow the same practice. >> >> Thanks to Aman Mishra for providing the UATs for both stories. >> >> >> Best Regards, >> -- >> Rishi Solanki >> Sr. Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> >
Re: User Acceptance Test Cases For Ecommerce 14.12
Please use this link to access the mentioned page in original email - Ecommerce-14.12 <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> Thanks! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Jan 21, 2017 at 9:21 PM, Rishi Solanki <rishisolan...@gmail.com> wrote: > Devs, > > We have started working on few user stories mentioned at Ecommerce-14.12 > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and > adding user acceptance test (UAT) cases for them. For now we have added > test cases for two user stories as follows; > - Login Page > - Login and Update Personal Information > > We have updated the document with the identified UATs so that can get > feedback from community on them. > > - For now we have added the UATs just below the user stories in the > document. Please let us know if we are fine with this location? > - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned > two user stories. Please review and let us know your thoughts on it, so > that we can follow one common pattern. > > Any other feedback in UATs are most welcome to improve the quality. Going > forward we would follow the same practice. > > Thanks to Aman Mishra for providing the UATs for both stories. > > > Best Regards, > -- > Rishi Solanki > Sr. Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com >
User Acceptance Test Cases For Ecommerce 14.12
Devs, We have started working on few user stories mentioned at Ecommerce-14.12 <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and adding user acceptance test (UAT) cases for them. For now we have added test cases for two user stories as follows; - Login Page - Login and Update Personal Information We have updated the document with the identified UATs so that can get feedback from community on them. - For now we have added the UATs just below the user stories in the document. Please let us know if we are fine with this location? - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned two user stories. Please review and let us know your thoughts on it, so that we can follow one common pattern. Any other feedback in UATs are most welcome to improve the quality. Going forward we would follow the same practice. Thanks to Aman Mishra for providing the UATs for both stories. Best Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com
Re: Does the deleteWorkEffort really always works?
Agree on all points shared by Scott, Paul and Nicolas. Also valid concern raised in this thread by Jacques. Thanks! As described by Nicolas, that work_effort is complex entity and we should consider the functional context for it, if we wnat to delete a work_effort. Still I think, until business or dba not force we should maintain the historical data. I mean to say, we have date fileds and status fields in the work_effort the maintain/filter them. Also on closing/cancelling the workeffort case by case basis system clear them out from the system. So we need a delete service for work_effort which requires extra handling for date fields, status field with some better algorithm so that once business decided to remove it, system should always remove instead of sending exception on dependencies. Thanks! Kind Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jan 23, 2017 at 4:25 PM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > WorkEffort is a complexe entity as much technical aspect as functional > cover :) > > On the Jacques's case, the workEffort is used to follow jobSandox activity > after user command and in logical delete all older workEffort to minimize > the history (like jenkins with his scheduler). > > After your remarks, I think call deleteWorkEffort isn't logical without > functional context. If we want delete a WorkEffort, we need to understand > the this context and in this case prepare the deletion by a dedicate > service (remove all potential FK and so one) before call the standard > service. > > Nicolas > > > Le 23/01/2017 à 11:10, Paul Foxworthy a écrit : > >> Hi Jacques and Scott, >> >> On 23 January 2017 at 09:08, Scott Gray <scott.g...@hotwaxsystems.com> >> wrote: >> >> >> I can't think of any *good* reasons to remove a WorkEffort record. >>> >> >> Hear, hear. In general, OFBiz expires an entity by setting the thruDate. >> What's so special about WorkEffort? >> >> Cheers >> >> Paul >> >> >
Re: Improve FindGeneric on webtools
+1
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Feb 16, 2017 at 3:31 PM, Nicolas Malin <nicolas.ma...@nereide.fr>
wrote:
> Hello, I want just sharing a small improvement realized yesterday.
>
> During a travel, I was bored on the train I tried to replace the old ftl
> FindGeneric screen to display and search all entity by an xml form with
> auto-attribute-entity.
> The main problem came from it's impossible to create a xml file with use
> dynamiclay an entityName for the element (for
> cache/performance reason) so I tried to generate on the fly by groovy the
> xml flow, and call without cache the rendering, like this :
> *
> String dynamicAutoEntityFieldForm = ' encoding="UTF-8"?>http://www.w3.org/
> 2001/XMLSchema-instance" <http://www.w3.org/2001/XMLSchema-instance>
> xmlns="http://ofbiz.apache.org/Widget-Form;
> <http://ofbiz.apache.org/Widget-Form>
> xsi:schemaLocation="http://ofbiz.apache.org/Widget-Form
> http://ofbiz.apache.org/dtds/widget-form.xsd;
> <http://ofbiz.apache.org/Widget-Formhttp://ofbiz.apache.org/dtds/widget-form.xsd>>'
>
> '' +
> ' default-field-type="find"/>' +
> '' +
> '' +
> ' "FormFieldTitle_searchButton", locale) + '">' +
> ''
> Document dynamicAutoEntityFieldFormXml =
> UtilXml.readXmlDocument(dynamicAutoEntityFieldForm,
> true, true)
> [...]
> dynamicAutoEntitySearchFormRenderer.render(writer, context)
>
> and on the ftl
>
> ${dynamicAutoEntitySearchForm?string}
>
> I realized this on the search and list form so now I can use complex
> search operator and the performFind for all entity. What do you thinks
> about that ?
>
> I will open an issue.
>
> Nicolas
>
>
> --
> [image: logoNrd] <https://nereide.fr/>
> Nicolas Malin
> The apache way <http://theapacheway.com/> : *Openness* Technical
> decisions are made publicly
> informat...@nereide.fr
> 8 rue des Déportés 37000 TOURS, 02 47 50 30 54
> Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way
> <http://theapacheway.com/>|ofbiz-fr <http://www.ofbiz-fr.org/>|réseau LE
> <http://www.libre-entreprise.org/>
>
Re: User Acceptance Test Cases For Ecommerce 14.12
Folks, Added two more UAT as Category Navigation and Product Search <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I observe some scope of improvements like UAT writing aren't following common patterns, I'll review and fix them soon. Soon we would add remaining in the ecommerce area, looking for your feedback and suggestions on it. Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > Indeed I needed a clarification, sorry for that. > > It's a great initiative, OFBiz will then really be at professional > standards, and that's great! > > I agree that we have first to create and document these UAT and then think > about a tool to run them. > Cucumber seems the best tool for that to me. I also know that Gil > (Portenseigne) from Néréide has begun to use Cucumber for a custom project, > hence my haste :) > > Jacques > > > > Le 23/01/2017 à 08:05, Rishi Solanki a écrit : > >> Thanks Jacques for your reply and raising concerns. It seems that, I was >> not clear enough. Let me try to rephrase what we are doing. If you observe >> then Pranay has created new hierachy for each release like 14.12, 15.12 >> ... >> so on. >> >> For each release we have the user stories, and we are adding UATs for each >> user story. For each user story we are discussing the cases we should test >> manually and also try them to dicuss on the mailing list (user/dev). Once >> we are sure, we document and test the cases (manually) and put the results >> in the Actual results and Pass/Fail. >> >> Please note that, before documenting anything as Pass or Fail we are >> really >> running that scenario. The intention of doing this, we can say that the >> released branches of OFBiz are tested on certain scenarios and all get >> passed. After completing this activity, we as a community can say 14.12 >> branch tested for say 1000 user acceptance test cases and out of them 950 >> get passed and 50 are reported and fail for that branch. Once we complete >> this activity, we could start fixing them. >> >> For the same we have started multiple email threads to get the feedback >> from community, so that we could get more cases for the user stories. In >> other words, we have automated tests with us, but this time we are trying >> to add documents for the manual tests user could see and increase in faith >> on each relase. >> >> I hope I'm clear this time :-). And yes I agree on the fact that we should >> think on automating these tests to run them frequently. And I think for >> that we again need what to tests get documented. We can assume it as first >> step towards automation. >> >> PS: Team, please add more details if I miss something. >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Thanks Rishi, >>> >>> This is interesting, do you envision a mean to automate these tests and >>> run them frequently? >>> >>> Say either on each build (using BuildBot for instance), or on another >>> frequency if they happens to be at term longer than our commit frequency >>> would support. >>> >>> So the question is do you plan to use a tool for that? I say that because >>> it seems to me that Cucumber (MIT license) could be used for that... >>> >>> Jacques >>> >>> >>> Le 21/01/2017 à 16:51, Rishi Solanki a écrit : >>> >>> Devs, >>>> >>>> We have started working on few user stories mentioned at Ecommerce-14.12 >>>> <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and >>>> adding user acceptance test (UAT) cases for them. For now we have added >>>> test cases for two user stories as follows; >>>> - Login Page >>>> - Login and Update Personal Information >>>> >>>> We have updated the document with the identified UATs so that can get >>>> feedback from community on them. >>>> >>>> - For now we have added the UATs just below the user stories in the >>>> document. Please let us know if we are fine with this location? >>>> - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned >>>> two >>>> user stories. Please review and let us know your thoughts on it, so that >>>> we >>>> can follow one common pattern. >>>> >>>> Any other feedback in UATs are most welcome to improve the quality. >>>> Going >>>> forward we would follow the same practice. >>>> >>>> Thanks to Aman Mishra for providing the UATs for both stories. >>>> >>>> >>>> Best Regards, >>>> -- >>>> Rishi Solanki >>>> Sr. Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> >>>> >
Re: Welcome Deepak Dixit as a new PMC member
Congratulations Deepak!! :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Feb 24, 2017 at 7:42 PM, Julien NICOLAS <julien.nico...@nereide.fr> wrote: > Good news, congrats Deepak ! > > Julien. > > > > On 24/02/2017 14:08, Jacques Le Roux wrote: > >> The OFBiz PMC has invited Deepak Dixit to become a new member of the >> committee; and the committee members are happy to announce that he has >> accepted. >> >> Deepak has been involved in OFBiz for a long time now, and is a respected >> committer for 2 years. >> >> We are sure Deepak will help us to take good decisions in favour of a >> bright future for OFBiz! >> >> Please join me in welcoming and congratulating Deepak. >> >> Thanks >> >> Jacques >> PS: Deepak, I let you change your status on the wiki PMC page :) >> >> >> >
Re: Welcome Swapnil Shah as a New Committer!
Congratulations Swapnil !! :-) Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Feb 15, 2017 at 2:51 PM, Aman Mishra <aman.mis...@hotwaxsystems.com> wrote: > Many Congratulations Swapnil.! > > Thanks & Regards > -- > Aman Mishra > > On Wed, Feb 15, 2017 at 1:50 PM, Yashwant Dhakad < > yashwant.dha...@hotwaxsystems.com> wrote: > > > Many congratulations Swapnil! > > > > Thanks & Regards > > -- > > Yashwant Dhakad > > HotWax Systems > > http://www.hotwaxsystems.com/ > > > > On Wed, Feb 15, 2017 at 1:14 PM, Chandan Khandelwal < > > chandan.khandel...@hotwaxsystems.com> wrote: > > > > > Many congratulations Swapnil...! > > > > > > > > > -- > > > Chandan Khandelwal > > > > > > > > > > > > On Wed, Feb 15, 2017 at 11:59 AM, Deepak Dixit < > > > deepak.di...@hotwaxsystems.com> wrote: > > > > > > > Many Congrats Swapnil... > > > > > > > > Thanks & Regards > > > > -- > > > > Deepak Dixit > > > > www.hotwaxsystems.com > > > > > > > > On Wed, Feb 15, 2017 at 10:41 AM, Akash Jain < > > > akash.j...@hotwaxsystems.com > > > > > > > > > wrote: > > > > > > > > > Many congratulations Swapnil! > > > > > > > > > > Thanks and Regards > > > > > -- > > > > > Akash Jain > > > > > > > > > > On Tue, Feb 14, 2017 at 4:30 PM, Sharan Foga <sha...@apache.org> > > > wrote: > > > > > > > > > > > The OFBiz PMC has invited Swapnil Shah to become a new committer > > and > > > > are > > > > > > happy to announce that he has accepted. > > > > > > > > > > > > Swapnil has been involved in OFBiz for a few years and has been > > > active > > > > on > > > > > > both the development and user mailing lists responding to some > > quite > > > > > > technical functional questions. > > > > > > > > > > > > Some of the key factors considered for inviting him were as > > follows: > > > > > > > > > > > > - He has very good functional knowledge about OFBiz and this is a > > > > > valuable > > > > > > skill that is useful to developers and users > > > > > > - He is polite, positive, friendly and collaborative when dealing > > the > > > > > > community discussions on the mailings lists or Jira > > > > > > - He has raised Jiras, performed testing on patches and new other > > > > > > functionality > > > > > > - The PMC would like to see a wide range of people from the > > community > > > > > > (developers and non-developers) recognised for their > contributions > > to > > > > the > > > > > > project. > > > > > > > > > > > > Please join me in welcoming and congratulating Swapnil. > > > > > > > > > > > > Thanks > > > > > > Sharan > > > > > > > > > > > > > > > > > > > > >
Re: OFBIZ-3972
Interesting related blog - LINK <https://blog.sqlauthority.com/2014/02/14/mysql-when-to-use-timestamp-or-datetime-difference-between-timestamp-or-datetime/> One more conversation - http://stackoverflow.com/questions/5989539/when-to-use-datetime-or-timestamp It says it depends on the context of the field for which it is used. DATETIME seems to be good choice as we will be updating field type, and it may applicable to many places. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Feb 24, 2017 at 3:37 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > I think I would prefer DATETIME. Some reasons are found here -> > http://stackoverflow.com/questions/409286/should-i-use- > field-datetime-or-timestamp. > Given that OFBiz takes care of conversions, DATETIME seems like a more > appropriate choice > > On Fri, Feb 24, 2017 at 12:13 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi, > > > > At OFBIZ-3972 Deepak suggested > > > > < > As we have only DATETIME set as sql type and this does not support > > Milliseconds, we need to use DATETIME(3) or DATETIME(6).>> > > > > I suggested > > > > <https://dev.mysql.com/doc/ > refman/5.6/en/datetime.html > > >> > > > > Deepak rightly mentioned that in both cases we need to create an entry in > > "data migration" wiki page > > > > << we need to run alter query manually (if someone want to upgrade custom > > solution to latest)>> > > > > Please let know your thoughts and suggestions if any > > > > Jacques > > > > >
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
+1 for using the GenericEntityException, we did similar effort in
OFBIZ-7539.
Also agree on Jacques concern that, we should also fix the NPE for
delegator coming from HtmlFormMacroLibrary.ftl. So I think for now the fix
provided in the mentioned ticket is fine OFBIZ-9230 and we should also use
the GenericEntityException. Later we should try to figure out why and when
system lose the delegator which causes the NPE. Once we would fix the
reason we should remove the fix added in the EntityUtilProperties class
method.
New fix proposal:
Change method WidgetWorker.getDelegator with following code;
public static Delegator getDelegator(Map<String, Object> context) {
Delegator delegator = (Delegator) context.get("delegator");
if (delegator == null) {
delegator = DelegatorFactory.getDelegator(delegatorName);
}
return delegator;
}
Please see if this proposal looks fine then we could try and see if it
works to fix the original issue reported in the ticket.
Thanks!
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Tue, Feb 28, 2017 at 1:49 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Thanks Wei,
>
> Please All, refer to OFBIZ-9230 to see how I temporarily handled the issue.
>
> I also agree that using GenericEntityException is better than just a
> permissive Exception
>
> But I believe we should rather fix the underlying issue I reported there.
> So I was hesitant to agree with Wei though it's maybe a better way to get
> to really fix the issue because it shows it at the UI level and non only in
> logs.
>
> Jacques
>
>
>
> Le 28/02/2017 à 03:35, Wei Zhang a écrit :
>
>> Hi,
>>
>> I found there is a try/catch block to catch Exception in
>> EntityUtilProperties.getSystemPropertyValue(). Which will catche a NPE
>> (delegator is null) when this method is called in
>> framework/widget/templates/HtmlFormMacroLibrary.ftl but we only get a
>> waring
>> message in the log file.
>>
>> So I think we should catch GenericEntityException rather than Exception
>> here
>> to expose NPE or other runtime exceptions.
>>
>> Thanks,
>>
>> Wei
>>
>>
>>
>> -
>> 程序羊
>> --
>> View this message in context: http://ofbiz.135035.n4.nabble.
>> com/Should-not-catch-Exception-in-EntityUtilProperties-getSy
>> stemPropertyValue-tp4702833.html
>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>
>>
>>
>
Re: [PROPOSAL] deprecate mini lang
+1 Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Feb 28, 2017 at 2:53 PM, Julien NICOLAS <julien.nico...@nereide.fr> wrote: > +1 > > > > On 27/02/2017 13:44, Nicolas Malin wrote: > >> +1 >> >> I also agree to replace the minilang by groovy dsl for service. >> >> For screen a prefer wait a good equivalent solution for simple case. >> >> Nicolas >> >> >> Le 18/02/2017 à 10:17, Michael Brohl a écrit : >> >>> Hi everyone, >>> >>> we are currently working hard to make OFBiz a modern, quality, robust >>> and easy to use framework. >>> There are several ongoing initiatives like refactoring the core, UX, >>> changing the build and plugin system and cleaning up the javadocs, only to >>> mention a few. >>> >>> In mini lang I see another part of our project which needs a >>> refactoring/change. Here are some reasons: >>> >>> - Programming in XML is hard to deal with when it comes to refactoring. >>> >>> - The "code" cannot be debugged and is hard to review and maintain. >>> >>> - It is slower because of the overhead of parsing and processing XML >>> documents >>> >>> - It is highly verbose, even so more than Java! >>> >>> - It is difficult to reason about because everything appears as a string >>> (variables, maps, objects, etc ...) which makes it very difficult to know >>> where something was declared or modified >>> >>> - It is highly error prone and brittle (again due to string declarations) >>> >>> - It is not a full programming language (unlike groovy, or any other >>> language that supports a DSL). Thus it has many limitations that forces the >>> developer to write many more lines of code to achieve the same result. >>> >>> - The code is not reusable (limitation of the DSL) >>> >>> - The code is not composable (limitation of the DSL) >>> >>> - Minilang depends on a lot of Java constructs (implementations, not >>> interfaces) that require refactoring, making any improvements to the core >>> API more challenging >>> >>> - Minilang is used inconsistently (different DSL in widgets, services >>> and entities). Hence, we need to keep only a minimal DSL to declare things >>> only. >>> >>> >>> We already have Java based implementations for services and events and >>> there are ideas to implement a Groovy DSL which can be used as easy (or >>> easier) as mini lang and does not have the above mentioned flaws. >>> >>> I therefore like to propose to deprecate the mini lang implementation >>> which means: >>> >>> 1. there will be no new implementations based on mini lang accepted to >>> go into the code base. >>> >>> 2. mini lang and mini lang code will be maintained with bug and security >>> fixes for backwards compatibility and to support existing adopters relying >>> on mini lang. >>>There will be no new features though. >>> >>> 3. we will continously replace the mini lang implementations with Java >>> and/or Groovy code. This will be another good opportunity for contributors >>> to engage in the project. >>> >>> >>> This will certainly be a longer process and we will not stop support for >>> mini lang but I think we should avoid to add more mini lang implementations >>> to the project. >>> >>> What do you think? >>> >>> Regards, >>> >>> Michael >>> >>> >>> >>> >> >> >
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
Thank you Wei, Jacques for your reply. What I was proposing to change method of WidgetWorker.getDelegator() method. I see whenever any form render the fields and requires delegator then it always tries to get delegator from WidgetWorker's mentioned method. Please refer MacroFormRenederer class as mentioned in the OFBIZ-9230 by Jacques. If we fix that method, then I think we should be fine and while rendering system will always have the delegator and this issue should not appear. In that case we won't required extra delegaor checks in the EntityUtilProperties class for this particular issue. In case we requied this check from other place then we need to make sure delegator always passed to EntityUtilProperties methods, instead of adding condition in the EntityUtilProperties methods. Because many methods in that class uses the delegator as parameter. Finally we should catch the GenericEntityException instead of Exception. In a way #1 and #3 needs to be work on and for #2 we should let it be as is so that in future system will report if somewhere we are losing the delegator then we could take care. That means what Jacques did in his last fix should be fine, simply log delegator is missing on console. This is what I'm proposing, but I'm okay if we want to fix delegator issue in the EntityUtilProperties class, if so then I would say to fix it for all methods which uses delegator as parameter. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Mar 2, 2017 at 8:02 AM, Wei Zhang <zhangwei1...@outlook.com> wrote: > I think we need to do 3 things. > > 1. Catch GenericEntityException in > EntityUtilProperties.getSystemPropertyValue() > 2. Create a new Delegator if it is null in > EntityUtilProperties.getSystemPropertyValue() > 3. Find out how to get a delegator instance in > framework/widget/templates/HtmlFormMacroLibrary.ftl > > > > > - > 程序羊 > -- > View this message in context: http://ofbiz.135035.n4.nabble. > com/Should-not-catch-Exception-in-EntityUtilProperties- > getSystemPropertyValue-tp4702833p4702909.html > Sent from the OFBiz - Dev mailing list archive at Nabble.com. >
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
Thanks!
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Mar 2, 2017 at 3:10 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
>
>
> Le 02/03/2017 à 08:00, Rishi Solanki a écrit :
>
>> Thank you Wei, Jacques for your reply.
>>
>> What I was proposing to change method of WidgetWorker.getDelegator()
>> method. I see whenever any form render the fields and requires delegator
>> then it always tries to get delegator from WidgetWorker's mentioned
>> method.
>> Please refer MacroFormRenederer class as mentioned in the OFBIZ-9230 by
>> Jacques.
>>
>> If we fix that method, then I think we should be fine and while rendering
>> system will always have the delegator and this issue should not appear. In
>> that case we won't required extra delegaor checks in the
>> EntityUtilProperties class for this particular issue.
>>
> Actually no. EntityUtilProperties.getSystemPropertyValueI() I change in
> my patch is only used by EntityUtilProperties methods (getMessage, 2
> getPropertyValue, propertyValueEqualsIgnoreCase)
> But those are widely used in OFBiz, not only in the context of widget
>
>> In case we requied this check from other place then we need to make sure
>> delegator always
>> passed to EntityUtilProperties methods, instead of adding condition in the
>> EntityUtilProperties methods. Because many methods in that class uses the
>> delegator as parameter.
>>
> The EntityUtilProperties methods which needs a delegator are actually
> those above because they call getSystemPropertyValue() which needs the
> delegator, not for other reasons.
>
>> Finally we should catch the GenericEntityException instead of Exception.
>> In
>> a way #1 and #3 needs to be work on and for #2 we should
>> let it be as is so that in future system will report if somewhere we are
>> losing the delegator then we could take care. That means what Jacques did
>> in his last fix should be fine, simply log delegator is missing on
>> console.
>>
>
> So you propose not to use the "default" delegator but simply log the
> error. I agree this is better.
> But we will face issues in the UI like the one reported by 程序羊 in log (try
> replacing Exception by GenericEntityException and then get to
> https://localhost:8443/partymgr/control/main)
> And I don't see a simple and quick fix for the missing delegator :/
>
>> This is what I'm proposing, but I'm okay if we want to fix delegator issue
>> in the EntityUtilProperties class, if so then I would say to fix it for
>> all
>> methods which uses delegator as parameter.
>>
>
> If you mean EntityUtilProperties methods then my workaround is "OK".
> Actually there are 1 other places where we use
> delegator = DelegatorFactory.getDelegator("default");
> checkRhsType()
> (also one in tests with delegatorCreationUsingFactoryGetDelegator() that
> we can neglect)
>
> I attach in the Jira the patch I finally propose and we should continue to
> discuss there IMO
>
> Thanks
>
> Jacques
>
>
>
>
>> Thanks!
>>
>>
>>
>>
>>
>> Rishi Solanki
>> Sr. Manager, Enterprise Software Development
>> HotWax Systems Pvt. Ltd.
>> Direct: +91-9893287847
>> http://www.hotwaxsystems.com
>>
>> On Thu, Mar 2, 2017 at 8:02 AM, Wei Zhang <zhangwei1...@outlook.com>
>> wrote:
>>
>> I think we need to do 3 things.
>>>
>>> 1. Catch GenericEntityException in
>>> EntityUtilProperties.getSystemPropertyValue()
>>> 2. Create a new Delegator if it is null in
>>> EntityUtilProperties.getSystemPropertyValue()
>>> 3. Find out how to get a delegator instance in
>>> framework/widget/templates/HtmlFormMacroLibrary.ftl
>>>
>>>
>>>
>>>
>>> -
>>> 程序羊
>>> --
>>> View this message in context: http://ofbiz.135035.n4.nabble.
>>> com/Should-not-catch-Exception-in-EntityUtilProperties-
>>> getSystemPropertyValue-tp4702833p4702909.html
>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>>
>>>
>>
>
Re: Groovy and semicolon at EOL
Agreed on the fact that its an pain to backport the bug fixes to releases. Especially when we have to change something manually and it has been done with many files in last few months i.e bulk changes with all files of xType. I'm not sure, but what is the good time to do such changes (may be just before the next release?). Or we should port such changes which are for consistency to releases. Or may be its fine to keep it as is. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Sep 13, 2016 at 8:15 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Tue, Sep 13, 2016 at 4:36 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > ... > > Before applying a such change, I'd really like to know if everybody is > > aware of what that means when it comes to svn annotations. I repeat: we > > will then lose all the svn annotations history in all the Groovy files. > ... > > > > Jacques, are you aware that you can pass the -r argument to the > blame/annotate command? > > Jacopo >
Re: Groovy and semicolon at EOL
I remember the conversion of bsh to groovy was big one, and at that time in a conversation decided to keep the semicolon as is. For code consistency and for java based user of OFBiz. Even bsh/groovy help java based users to develop/understand OFBiz better. I tried but could not find the reference to that conversation in history. But yes we can address this code improvement and here I find something related on OFBiz wiki - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=6553850 So +1 for this effort and we should remove all semicolons from groovy files. Best Regards, -- Rishi Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Sep 12, 2016 at 10:29 PM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Agreed, I think it is better to remove semicolons for groovy files. In fact > our gradle scripts do not have semicolons. Perhaps people put them there > out of habit. > > On Sep 12, 2016 7:56 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> > wrote: > > > Hi > > > > While committing r1760406 I wondered if I should really put semicolons > at > > end of Groovy files lines. > > We know it's useless in Groovy. Should we continue to put them, and if > yes > > for which reasons? > > > > Thanks > > > > Jacques > > > > >
Re: Groovy and semicolon at EOL
Jacopo, I could recall after your reply, the semicolon kept in the groovy files for consistency only no other reason. Also, if we decide to remove it, then only thing we should consider if somewhere semicolon used as separator. Thanks! -- Rishi Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Sep 13, 2016 at 11:46 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > I don't have a strong opinion. But it would be nice to agreed upon one > style and then implement consistently. > > Jacopo > > On Mon, Sep 12, 2016 at 6:56 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi > > > > While committing r1760406 I wondered if I should really put semicolons > at > > end of Groovy files lines. > > We know it's useless in Groovy. Should we continue to put them, and if > yes > > for which reasons? > > > > Thanks > > > > Jacques > > > > >
Re: Groovy and semicolon at EOL
+1 Taher, until we will have complete switch to pure groovy we should keep the semicolon as practice. +1 Michael, for migrating to pure Groovy. We would try to assign dev for it and log Jira ticket accordingly. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Sep 13, 2016 at 6:28 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Okay, given the priorities and work we have at the moment, I suggest we > keep semicolons and use it as the standard unless someone volunteers to > make a full switch. WDYT? > > On Tue, Sep 13, 2016 at 3:52 PM, Jacopo Cappellato < > jacopo.cappell...@hotwaxsystems.com> wrote: > > > I agree with Rishi's remarks: also, if we follow this approach then > > functional changes will be buried in a bunch of non-functional changes. > > This could work if the two are committed into two separate commits. > > > > Jacopo > > > > On Tue, Sep 13, 2016 at 2:45 PM, Rishi Solanki <rishisolan...@gmail.com> > > wrote: > > > > > Fix as you edit, this is something like we are working on X > functionality > > > and to achieve that functionality if we want to edit an groovy file, > then > > > we will also remove/add semicolon to it. > > > > > > If I'm understanding it correctly, then -1 for it. As we have to ask > > > explicitly to every contributor/committer to follow this practice on > each > > > commit/ticket. > > > > > > I'm up for #1 or #2 to actively remove/add semicolon. That is do it in > > one > > > shot, not immediately but whenever we are ready to do it, otherwise > with > > > time we will have more inconsistency in groovy files on this parameter > as > > > semicolon. > > > > > > I'm not saying we must do it in one shot, but if community decides to > > > proceed with any approach to actively add/remove semicolon then we > (@HW) > > > can try to assign single dev as volunteer to provide patch for all the > > > files. > > > > > > Thanks! > > > > > > Best Regards, > > > -- > > > > > > Rishi Solanki > > > Manager, Enterprise Software Development > > > HotWax Systems Pvt. Ltd. > > > Direct: +91-9893287847 > > > http://www.hotwaxsystems.com > > > > > > On Tue, Sep 13, 2016 at 3:49 PM, Taher Alkhateeb < > > > slidingfilame...@gmail.com > > > > wrote: > > > > > > > Yup +1 for option 3, fix as you edit > > > > > > > > On Sep 13, 2016 1:16 PM, "Jacques Le Roux" < > > jacques.le.r...@les7arts.com > > > > > > > > wrote: > > > > > > > > > Le 13/09/2016 à 11:56, Michael Brohl a écrit : > > > > > > > > > >> Same here. I'm not even sure if we really have clean groovy in the > > > > >> project, I assume it is mixed up with Java code in some areas. > > > > >> > > > > >> But I agree to have a consistent style and we should use the > Groovy > > > > >> language as it shoul be used (even if I would have get used to it > > and > > > > like > > > > >> a a defined code line ending better). > > > > >> > > > > >> I see the following directions: > > > > >> > > > > >> 1. actively migrate to pure groovy and remove the semicolons > (where > > > > >> applicable, it seems there are some cases where you need them, see > > > > >> https://dzone.com/articles/groovy-sometimes-you-still) > > > > >> > > > > >> 2. activeley put semicolons everywhere for consistency > > > > >> > > > > >> 3. do 1., but only when a groovy file is edited anyway. This would > > > > slowly > > > > >> migrate groovy files. > > > > >> > > > > >> I'd be in favor for 3., as long as there are other more important > > > things > > > > >> to do or there is a volunteer to do it. > > > > >> > > > > > > > > > > This is what I somehow suggested, thanks for clarifying Michael! > > Better > > > > to > > > > > have consistent lines (with respect to semicolons) by file indeed. > > > > > > > > > > Jacques > > > > > > > > > > > > > > >> Am 13.09.16 um 08:49 schrieb Taher Alkhateeb: > > > > >> > > > > >>> Okay I missed the historical context. > > > > >>> > > > > >>> Like Jacopo I also do not have a strong opinion, if it is easier > > and > > > > >>> faster > > > > >>> to keep them, then keep them. The important thing is to take a > > > > direction > > > > >>> and stay with it. > > > > >>> > > > > >>> > > > > >>> > > > > >> > > > > >> > > > > > > > > > > > > > > >
Re: Groovy and semicolon at EOL
Fix as you edit, this is something like we are working on X functionality and to achieve that functionality if we want to edit an groovy file, then we will also remove/add semicolon to it. If I'm understanding it correctly, then -1 for it. As we have to ask explicitly to every contributor/committer to follow this practice on each commit/ticket. I'm up for #1 or #2 to actively remove/add semicolon. That is do it in one shot, not immediately but whenever we are ready to do it, otherwise with time we will have more inconsistency in groovy files on this parameter as semicolon. I'm not saying we must do it in one shot, but if community decides to proceed with any approach to actively add/remove semicolon then we (@HW) can try to assign single dev as volunteer to provide patch for all the files. Thanks! Best Regards, -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Sep 13, 2016 at 3:49 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Yup +1 for option 3, fix as you edit > > On Sep 13, 2016 1:16 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> > wrote: > > > Le 13/09/2016 à 11:56, Michael Brohl a écrit : > > > >> Same here. I'm not even sure if we really have clean groovy in the > >> project, I assume it is mixed up with Java code in some areas. > >> > >> But I agree to have a consistent style and we should use the Groovy > >> language as it shoul be used (even if I would have get used to it and > like > >> a a defined code line ending better). > >> > >> I see the following directions: > >> > >> 1. actively migrate to pure groovy and remove the semicolons (where > >> applicable, it seems there are some cases where you need them, see > >> https://dzone.com/articles/groovy-sometimes-you-still) > >> > >> 2. activeley put semicolons everywhere for consistency > >> > >> 3. do 1., but only when a groovy file is edited anyway. This would > slowly > >> migrate groovy files. > >> > >> I'd be in favor for 3., as long as there are other more important things > >> to do or there is a volunteer to do it. > >> > > > > This is what I somehow suggested, thanks for clarifying Michael! Better > to > > have consistent lines (with respect to semicolons) by file indeed. > > > > Jacques > > > > > >> Am 13.09.16 um 08:49 schrieb Taher Alkhateeb: > >> > >>> Okay I missed the historical context. > >>> > >>> Like Jacopo I also do not have a strong opinion, if it is easier and > >>> faster > >>> to keep them, then keep them. The important thing is to take a > direction > >>> and stay with it. > >>> > >>> > >>> > >> > >> > > >
Re: Groovy and semicolon at EOL
To summarize the overall conversation;
1) We have decided to bulk remove semicolons from groovy.
2) Until #1 is not complete, we would keep adding semicolon for consistency.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Actually I was wrong on this. Thanks to Jacopo I noticed that both
> Subclipse and Tortoise allow you to select a range of revisions when you
> look for annotations.
>
> So it's no longer an issue for me and we can bulk remove trailing
> semicolons in Groovy files if we want.
>
> Sorry for the confusion
>
> Jacques
>
>
>
> Le 14/09/2016 à 04:42, Scott Gray a écrit :
>
>> I don't particularly care one way or another if groovy files have a
>> semi-colon at the end. I don't even care about consistency because it is
>> such a minor thing.
>>
>> I say remove them if they're on a line you happen to be editing, otherwise
>> just leave them be.
>>
>> Regarding the annotations, there's plenty of ways to search commit logs
>> and
>> personally I've never found blame to be very useful. I don't think it
>> should be a reason to block any future bulk S/R cleanups. We've had
>> plenty
>> in the past (Double -> BigDecimal, Delegator -> EntityQuery, whitespace
>> removal, etc.) and we should continue to do it to keep things clean.
>>
>> For searching diffs, before using git-svn I used to use: svn log -diff
>> and then use the search in the terminal to find the string
>> I'm looking for.
>>
>> Regards
>> Scott
>>
>> On 14 September 2016 at 07:33, Jacques Le Roux <
>> jacques.le.r...@les7arts.com
>>
>>> wrote:
>>> Le 13/09/2016 à 21:28, Jacques Le Roux a écrit :
>>>
>>> OK found that the same than in Subclipse also exists in TortoiseSVN
>>>>
>>>> But you need to use a command line (weird for a GUI), eg (from
>>>> TortoiseSVN root folder)
>>>>
>>>> Actually wrong, simply pick a file in Windows file explorer using
>>> TortoiseSVN context menu, et voilà!
>>> I confirm, totally comparable to Subclipse annotations
>>>
>>> Jacques
>>>
>>>
>>>
>>> TortoiseProc.exe /command:blame /path:"C:\projectASF-Mars\ofbi
>>>> z\applications\product\src\main\java\org\apache\ofbiz\
>>>> product\catalog\CatalogWorker.java"
>>>>
>>>> All is explained here https://tortoisesvn.net/docs/r
>>>> elease/TortoiseSVN_en/tsvn-automation.html#tsvn-automation-basics
>>>>
>>>> From the resulting UI (comparable to Subclipse) I guess changing all
>>>> lines of a file will have the same effect.
>>>> Even if indeed the annotations are not lost, they are very hard to use
>>>> if
>>>> you need to compare revision by revision.
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 13/09/2016 à 20:21, Jacques Le Roux a écrit :
>>>>
>>>> BTW thinking about it, don't you have something similar in IntellIJ?
>>>>>
>>>>> I found an (old) image there https://markphip.blogspot.fr/2
>>>>> 006/12/subclipse-live-annotations.html
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 13/09/2016 à 20:16, Jacques Le Roux a écrit :
>>>>>
>>>>> Thanks Jacopo,
>>>>>>
>>>>>> I found how to use it in TortoiseSVN (it starts from the log view)
>>>>>> It's complementary to what Subclipse gives and so interesting but not
>>>>>> comparable.
>>>>>>
>>>>>> You don't have this global view Subclipse offers with each annotation
>>>>>> by line from start (r1) to HEAD.
>>>>>> Very useful with colored annotations in the same column than lines
>>>>>> numbers. But it unfortunately contains only the last revision if all
>>>>>> lines
>>>>>> have been modified together in that revision.
>>>>>> Note: to see it you need to use "Show Quick Diff" ("Revision" and
>>>>>> "Combined Colors" are then default options, hovering is enough for
>>>>>> me).
>>>>>> Same than you decide to show line numbers in this column... More for
>>>>>> those who are still using Eclipse...
>>>&
Re: Permission service not on the same transaction
Nicolas, "If you are dealing with money, or precision is a must, use BigDecimal. Otherwise Doubles tend to be good enough." That means, for quantity fields double should be fine. But within OFBiz, I see entities like OrderItem, OISGIR, and many other uses BigDecimal for quantity field. But I think that is because in orderred quantity due to Product.orderDecimalQuantity user may enter the decimal quantity. With all this said, if we think WorkEffortGoodStandard.estimatedQuantity may contains precision values in it in some business scenarios then we should go for the #3. Or simple conversion should work as you suggested in #1. My suggestion is to go with #1, as I couldn't think of scenario where precision required upto many decimal places for the WorkEffortGoodStandard.estimatedQuantity field. Hope its not too late for original topic in this thread, +1 for using the same transaction for the permission services. As whenever we call permission service in a wrapper service we always use the same transaction. Thanks! Best Regards, -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Sep 17, 2016 at 5:30 PM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > Hi all, I need some Help !! I put my arm in a gearing :( > > After refactor the permission service, I raise a silent problem that is > all call-service used on mini-lang test didn't passed to service validation. > > I correct some easier case like bad attribut passed but now rest some > complicate case like this : > > testProductionRunCreation : Type check failed for field > [createWorkEffortGoodStandard.estimatedQuantity]; expected type is > [Double]; actual type is [java.math.BigDecimal] > > The problem came from that : > > * Field has define as BigDecimal on mini-lang > > * The service definition use auto-attribute to resolve the java type > > * The field on the entity is define as floating-point and is converted by > fieldType as Double > > So to reallign this I have some possibility > > 1. Easy : test are wrong : convert field instantiation to Double instead > of BigDecimal for all tests failed > > 2. Medium : service need realign : I surcharge attribute definition to > accept BigDecimal for these service > > 3. Hard : Why Double for floating-point, I had in my mind that BigDecimal > would be preferred to Double if is the case, we can change all fieldType > conversion to BigDecimal instead of Double and realign all ofbiz code > related. > > Your suggest will be truly appreciated ;) > > Nicolas > > > Le 15/04/2016 à 08:23, Taher Alkhateeb a écrit : > >> Hi Nicolas, >> >> I have to note that in ModelPermission the same exact call is also made >> with a new transaction. I did not dig deep into it but I advice to at >> least >> check it over there as well. This makes me suspect that either both call >> are wrong or both calls are right. >> >> HTH >> >> Taher Alkhateeb >> >> On Fri, Apr 15, 2016 at 9:18 AM, Pranay Pandey < >> pranay.pan...@hotwaxsystems.com> wrote: >> >> Hi Nicolas, >>> >>> Calling it as permission service is tricky. I see the comment in >>> implementation above the simple method in ShipmentServices.xml- >>> >>> >>> >>> It was implemented with a purpose to be called inline, may be supporting >>> the traditional way of doing things. Reviewing at a complete patch with >>> all >>> the modifications you have done for making shipment CRUD operations can >>> help here getting the opinion. WDYT? >>> >>> Best regards, >>> >>> Pranay Pandey >>> HotWax Systems >>> http://www.hotwaxsystems.com/ >>> >>> On Thu, Apr 7, 2016 at 1:30 PM, Nicolas Malin <nicolas.ma...@nereide.fr> >>> wrote: >>> >>> Hello, >>>> >>>> Currently I continue the conversion on shipment crud service and I >>>> detected that many service use the same mini-lang call to check if the >>>> shipment status is ok for editing "checkCanChangeShipmentStatusPacked" >>>> >>>> I convert it on service to call it directly by the permission-service >>>> like that : >>>> >>>> >>> default-entity-name="ShipmentPackageContent" engine="entity-auto" >>>> invoke="create" auth="true">... >>>> >>> service-name="checkCanChangeShipmentStatusPacked" >>>> main-action="CREATE"/> >>>> .
Re: Groovy and semicolon at EOL
I was saying #2 as per the comment from Taher Quick Reference: One reply from Taher ... in the same thread. == Okay, given the priorities and work we have at the moment, I suggest we keep semicolons and use it as the standard unless someone volunteers to make a full switch. WDYT? == Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I guess you mean 2) by file, then it's OK with me. Though I'd no be > against having semicolon inconsistency in Groovy files, which was my > initial question. So no strong opinion about 2 here. > > Jacques > > > > Le 16/09/2016 à 11:31, Rishi Solanki a écrit : > >> To summarize the overall conversation; >> 1) We have decided to bulk remove semicolons from groovy. >> 2) Until #1 is not complete, we would keep adding semicolon for >> consistency. >> >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Actually I was wrong on this. Thanks to Jacopo I noticed that both >>> Subclipse and Tortoise allow you to select a range of revisions when you >>> look for annotations. >>> >>> So it's no longer an issue for me and we can bulk remove trailing >>> semicolons in Groovy files if we want. >>> >>> Sorry for the confusion >>> >>> Jacques >>> >>> >>> >>> Le 14/09/2016 à 04:42, Scott Gray a écrit : >>> >>> I don't particularly care one way or another if groovy files have a >>>> semi-colon at the end. I don't even care about consistency because it >>>> is >>>> such a minor thing. >>>> >>>> I say remove them if they're on a line you happen to be editing, >>>> otherwise >>>> just leave them be. >>>> >>>> Regarding the annotations, there's plenty of ways to search commit logs >>>> and >>>> personally I've never found blame to be very useful. I don't think it >>>> should be a reason to block any future bulk S/R cleanups. We've had >>>> plenty >>>> in the past (Double -> BigDecimal, Delegator -> EntityQuery, whitespace >>>> removal, etc.) and we should continue to do it to keep things clean. >>>> >>>> For searching diffs, before using git-svn I used to use: svn log -diff >>>> and then use the search in the terminal to find the >>>> string >>>> I'm looking for. >>>> >>>> Regards >>>> Scott >>>> >>>> On 14 September 2016 at 07:33, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com >>>> >>>> wrote: >>>>> Le 13/09/2016 à 21:28, Jacques Le Roux a écrit : >>>>> >>>>> OK found that the same than in Subclipse also exists in TortoiseSVN >>>>> >>>>>> But you need to use a command line (weird for a GUI), eg (from >>>>>> TortoiseSVN root folder) >>>>>> >>>>>> Actually wrong, simply pick a file in Windows file explorer using >>>>>> >>>>> TortoiseSVN context menu, et voilà! >>>>> I confirm, totally comparable to Subclipse annotations >>>>> >>>>> Jacques >>>>> >>>>> >>>>> >>>>> TortoiseProc.exe /command:blame /path:"C:\projectASF-Mars\ofbi >>>>> >>>>>> z\applications\product\src\main\java\org\apache\ofbiz\ >>>>>> product\catalog\CatalogWorker.java" >>>>>> >>>>>> All is explained here https://tortoisesvn.net/docs/r >>>>>> elease/TortoiseSVN_en/tsvn-automation.html#tsvn-automation-basics >>>>>> >>>>>> From the resulting UI (comparable to Subclipse) I guess changing all >>>>>> lines of a file will have the same effect. >>>>>> Even if indeed the annotations are not lost, they are very hard to use >>>>>> if >>>>>> you need to compare revision by revision. >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> Le 13/09/2
Re: svn commit: r1767965 - in /ofbiz/trunk: applications/content/servicedef/ applications/order/servicedef/ applications/product/servicedef/ applications/workeffort/servicedef/ framework/common/servic
Jacques, We mentioned this in the ticket details OFBIZ-8769 that is why dev didn't submit the update service for ProductStoreGroupRole. The reason was this entity will only have the PKs and no non-PKs exist for this entity. Thanks for checking it again and support. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Nov 7, 2016 at 1:47 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Arun, > > Is there a reason why we have no updateProductStoreGroupRole? > > Jacques > > > > Le 05/11/2016 à 06:59, Arun Patidar a écrit : > >> Hi Jacques, >> >> I moved service near to create and update at rev:1768152 >> >> >
Re: Ecommerce Portal Enhancement
All, Thank you for your reply and suggestions. We will discuss this and come up with summarized details from email thread, on which we can proceed further. Hopefully in start of next week or in this weekend. Jacques, I'll check the plugin mechanism and update in the same thread. I see one thread on this subject, will get back on this asap. Thanks again for your help. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Oct 20, 2016 at 12:21 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Forgot to suggest that the new plugin could simply start by using the same > webapp than ecomseo > > Jacques > > > > Le 19/10/2016 à 14:25, Jacques Le Roux a écrit : > >> Hi Rishi, >> >> I prefer we create a new plugin. For 2 reasons: >> >> 1. keep the ecomseo webapp as is >> 2. Review the new "create plugin" mechanism >> >> The ecomseo webapp serves 2 purposes. >> >> 1. To create a SEO friendly URLs >> 2. To demonstrate the controller include mechanism. If you look at the >> ecomseo webapp you will see there is nothing specific but the servlets from >>the product component >> >> That why I prefer to have a new plugin. We will then be sure that ecomseo >> will not be tainted by new things added. And it could be possibly reused in >> the new plugin simply as a webapp as it is now in ecommerce, it's not UI >> related at all, only SEO related. >> >> And it's also a good occasion to create a new component by using the new >> "create plugin" mechanism. Of course the new plugin will ultimately be a >> specialpurpose component, but in the meantime this will help to review the >> new "create plugin" mechanism and if necessary improve it. >> >> Jacques >> >> >> Le 17/10/2016 à 10:27, Rishi Solanki a écrit : >> >>> James, Paul, Pierre, >>> >>> Thank you for your response, inputs, ideas and references. We do agree to >>> have responsive UI/UX compatible to most devices especially mobile. Also >>> we >>> tried to inlist this point in our summary but not clearly. With all the >>> above mentioned points, we would include the responsive web design in the >>> list. >>> >>> Also if anyone can answer on the question, which webapp we should use to >>> implement all this would be great. *ecomseo* is one option, and adding >>> one >>> new webapp is another option. We just wated to make sure before >>> proceeding >>> because, we don't want to override the purpose of an app intended to >>> demonstrate very specific item. If we use *ecomseo *then we would like to >>> maintain the SEO and URLs purpose of that application. If not then we >>> will >>> go for new webapp. >>> >>> Please suggest. Thanks again for your help! >>> >>> >>> Rishi Solanki >>> Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> >>> On Mon, Oct 17, 2016 at 12:39 PM, Pierre Smits <pierre.sm...@gmail.com> >>> wrote: >>> >>> The *oshop* solution (and associated *ecbootstrap* theme) are a step in >>>> the >>>> direction of bringing ecommerce functions to mobile devices. See: >>>> >>>> - for the *oshop* component: >>>> https://oem.ofbizci.net/oci-2/products/ecommerce/p_orrtiz-oshop >>>> - for the *ecbootstrap* theme: >>>> https://oem.ofbizci.net/oci-2/products/themes/themes-front/ >>>> p_orrtiz-ecbootstrap >>>> >>>> From there on you can link through to the code repos on Github of each. >>>> >>>> Best regards, >>>> >>>> Pierre Smits >>>> >>>> ORRTIZ.COM <http://www.orrtiz.com> >>>> OFBiz based solutions & services >>>> >>>> OFBiz Extensions Marketplace >>>> http://oem.ofbizci.net/oci-2/ >>>> >>>> On Mon, Oct 17, 2016 at 2:10 AM, Paul Foxworthy <p...@cohsoft.com.au> >>>> wrote: >>>> >>>> On 16 October 2016 at 16:46, james_sg <snowme...@hotmail.com> wrote: >>>>> >>>>> >>>>> More people are shopping with their mobile phones; >>>>>> Would be good to have responsive web design for ecommerce. >>>>>> >>>>>> Yes, responsive web design would be a good idea. But it should be done >>>>> using theming, so it would be applicable to all of OFBiz and not just >>>>> ecommerce. >>>>> >>>>> Cheers >>>>> >>>>> Paul Foxworthy >>>>> >>>>> >> >> >
Re: Ecommerce Portal Enhancement
James, Paul, Pierre, Thank you for your response, inputs, ideas and references. We do agree to have responsive UI/UX compatible to most devices especially mobile. Also we tried to inlist this point in our summary but not clearly. With all the above mentioned points, we would include the responsive web design in the list. Also if anyone can answer on the question, which webapp we should use to implement all this would be great. *ecomseo* is one option, and adding one new webapp is another option. We just wated to make sure before proceeding because, we don't want to override the purpose of an app intended to demonstrate very specific item. If we use *ecomseo *then we would like to maintain the SEO and URLs purpose of that application. If not then we will go for new webapp. Please suggest. Thanks again for your help! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Oct 17, 2016 at 12:39 PM, Pierre Smits <pierre.sm...@gmail.com> wrote: > The *oshop* solution (and associated *ecbootstrap* theme) are a step in the > direction of bringing ecommerce functions to mobile devices. See: > >- for the *oshop* component: >https://oem.ofbizci.net/oci-2/products/ecommerce/p_orrtiz-oshop >- for the *ecbootstrap* theme: >https://oem.ofbizci.net/oci-2/products/themes/themes-front/ > p_orrtiz-ecbootstrap > > From there on you can link through to the code repos on Github of each. > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Mon, Oct 17, 2016 at 2:10 AM, Paul Foxworthy <p...@cohsoft.com.au> > wrote: > > > On 16 October 2016 at 16:46, james_sg <snowme...@hotmail.com> wrote: > > > > > > > More people are shopping with their mobile phones; > > > Would be good to have responsive web design for ecommerce. > > > > > > > Yes, responsive web design would be a good idea. But it should be done > > using theming, so it would be applicable to all of OFBiz and not just > > ecommerce. > > > > Cheers > > > > Paul Foxworthy > > >
Re: Business Process and Use Case Library for Ecommerce ERP
Agreed, +1 for proposed hierachy. Thanks Pranay! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Nov 15, 2016 at 6:08 PM, Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Thanks Rishi for the note, there is a reason why I wanted to name those > component document suffixed with Branch or Release number. For better > indexing of documents, a unique name will help. > > Best regards, > > Pranay Pandey > HotWax Systems > http://www.hotwaxsystems.com/ > > On Tue, Nov 15, 2016 at 4:40 PM, Rishi Solanki <rishisolan...@gmail.com> > wrote: > > > Just one suggestion in hierachy, I'm good with the proposed hierachy as > > well. > > > > - OFBiz 14.12 > > -- Ecommerce > > -- Order Manager > > ... > > ... > > ... > > - OFBiz 16.12 > > -- Ecommerce > > -- Order Manager > > > > Thanks for initiative. :-) > > > > > > Rishi Solanki > > Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > > > On Tue, Nov 15, 2016 at 12:31 PM, Pranay Pandey < > > pranay.pan...@hotwaxsystems.com> wrote: > > > > > Interestingly, there will be heavy updates to these documents and hence > > > will be updated rigorously. Going with links to history I think won't > > work > > > in this case. We'll need to create separate pages with tagging the name > > of > > > the branch or release int he document name itself e.g. > > > > > > - OFBiz 14.12 > > > -- Ecommerce 14.12 > > > -- Order Manager 14.12 > > > ... > > > ... > > > ... > > > - OFBiz 16.12 > > > -- Ecommerce 16.12 > > > -- Order Manager 16.12 > > > > > > > > > Best regards, > > > > > > Pranay Pandey > > > HotWax Systems > > > http://www.hotwaxsystems.com/ > > > > > > On Sun, Nov 13, 2016 at 3:31 PM, Jacques Le Roux < > > > jacques.le.r...@les7arts.com> wrote: > > > > > > > Hi Pranay, > > > > > > > > I like the idea, maybe you can use the same way I did it when I > updated > > > > the documentation for the Gradle move. > > > > > > > > I simply referenced with a link a previous version in history, eg: > "Pre > > > > Gradle version" notice at https://cwiki.apache.org/confl > > > > uence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz > > > > > > > > Jacques > > > > > > > > > > > > > > > > Le 09/11/2016 à 13:55, Pranay Pandey a écrit : > > > > > > > >> Thanks Taher for this note. Yes it is about document re-organisation > > and > > > >> will help users to locate right set of document whenever needed. > > > >> > > > >> I am getting your point on priorities, but at the same time think > that > > > >> fine > > > >> tuned user stories will older branch will help us building good set > of > > > QA > > > >> artefacts for OFBiz upcoming release as well. > > > >> > > > >> I have also worked with one of my team member(Swapnil M Mane) to > come > > up > > > >> with a renewed OFBiz tutorial for beginners. Very soon we'll add it > to > > > >> OFBiz Confluence. Then we can discuss to upgrade it as needed for > > making > > > >> it > > > >> more easy to understand and useful. > > > >> > > > >> Best regards, > > > >> > > > >> Pranay Pandey > > > >> HotWax Systems > > > >> http://www.hotwaxsystems.com/ > > > >> > > > >> On Tue, Nov 8, 2016 at 4:53 PM, Taher Alkhateeb < > > > >> slidingfilame...@gmail.com> > > > >> wrote: > > > >> > > > >> Hi Pranay, > > > >>> > > > >>> It is a good idea of course to keep multiple versions of > > documentation > > > >>> for > > > >>> multiple releases. > > > >>> > > > >>> Talking in terms of priority, however, I think perhaps we need to > > spend > > > >>> most of our energy into first organizing and cleaning up our > > > >>> documentation. > > > >&
Re: Business Process and Use Case Library for Ecommerce ERP
Just one suggestion in hierachy, I'm good with the proposed hierachy as well. - OFBiz 14.12 -- Ecommerce -- Order Manager ... ... ... - OFBiz 16.12 -- Ecommerce -- Order Manager Thanks for initiative. :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Nov 15, 2016 at 12:31 PM, Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Interestingly, there will be heavy updates to these documents and hence > will be updated rigorously. Going with links to history I think won't work > in this case. We'll need to create separate pages with tagging the name of > the branch or release int he document name itself e.g. > > - OFBiz 14.12 > -- Ecommerce 14.12 > -- Order Manager 14.12 > ... > ... > ... > - OFBiz 16.12 > -- Ecommerce 16.12 > -- Order Manager 16.12 > > > Best regards, > > Pranay Pandey > HotWax Systems > http://www.hotwaxsystems.com/ > > On Sun, Nov 13, 2016 at 3:31 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi Pranay, > > > > I like the idea, maybe you can use the same way I did it when I updated > > the documentation for the Gradle move. > > > > I simply referenced with a link a previous version in history, eg: "Pre > > Gradle version" notice at https://cwiki.apache.org/confl > > uence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz > > > > Jacques > > > > > > > > Le 09/11/2016 à 13:55, Pranay Pandey a écrit : > > > >> Thanks Taher for this note. Yes it is about document re-organisation and > >> will help users to locate right set of document whenever needed. > >> > >> I am getting your point on priorities, but at the same time think that > >> fine > >> tuned user stories will older branch will help us building good set of > QA > >> artefacts for OFBiz upcoming release as well. > >> > >> I have also worked with one of my team member(Swapnil M Mane) to come up > >> with a renewed OFBiz tutorial for beginners. Very soon we'll add it to > >> OFBiz Confluence. Then we can discuss to upgrade it as needed for making > >> it > >> more easy to understand and useful. > >> > >> Best regards, > >> > >> Pranay Pandey > >> HotWax Systems > >> http://www.hotwaxsystems.com/ > >> > >> On Tue, Nov 8, 2016 at 4:53 PM, Taher Alkhateeb < > >> slidingfilame...@gmail.com> > >> wrote: > >> > >> Hi Pranay, > >>> > >>> It is a good idea of course to keep multiple versions of documentation > >>> for > >>> multiple releases. > >>> > >>> Talking in terms of priority, however, I think perhaps we need to spend > >>> most of our energy into first organizing and cleaning up our > >>> documentation. > >>> We need an API section, a user manual, a developer manual, and a set of > >>> tutorials. All of these need to be categorized and point to each other > in > >>> hyperlinks. Right now, the documentation is heavily scattered in > >>> different > >>> and confusing sections. There is no "one location" for getting a piece > of > >>> information. So for example, the business processes could be maybe part > >>> of > >>> the "User Manual" right? We don't have such a categorization at the > >>> moment > >>> which dilutes value. > >>> > >>> Also if you think about it, good organization of this information would > >>> make it easier to create release-specific documentation because you're > >>> building on the same organized skeleton. So in short I agree with your > >>> approach but trying to convince you to perhaps try to focus your energy > >>> on > >>> organizing our documentation if you have the time for it. > >>> > >>> Thank you as always for your initiative. > >>> > >>> Cheers, > >>> > >>> Taher Alkhateeb > >>> > >>> On Tue, Nov 8, 2016 at 2:08 PM, Pranay Pandey < > >>> pranay.pan...@hotwaxsystems.com> wrote: > >>> > >>> Hello Everyone, > >>>> > >>>> I am thinking to make a change in document hierarchy for Business > >>>> Process > >>>> and Use Case Library for Ecommerce ERP > >>>> <https://cwiki.apache.org/confluence/x/1gm8Ag>.
Re: Groovy and semicolon at EOL
Jacques, Yes we would like to commit it as whole, but before commit for the same we have plan to test each component after applying the changes. Like browse to most pages and general work flows. We will post the updates on ticket something like; Test the party component; Pages/Work Flow tested: Find Party, Create Party, View Party, My Communications, Visits, Classification, Security, Invitation pages etc. The above is an example of how we will confirm everything is working properly, with some basic code review. We would follow the same steps for other components. Please let us know plan looks fine to you. Also in case you think we should take care anything else to minimize the possibility of regression Or may be if you think committing the changes per component will help in code review? Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > Will you commit as a whole? > > Jacques > > > > Le 28/10/2016 à 12:07, Rishi Solanki a écrit : > >> Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 >> >> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for >> testing. >> >> >> Thanks! >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Personally I will go this way: I will add or changes lines without putting >>> semicolons. >>> >>> I'm in favour of bulk changing files, but I'd prefer by component or >>> webapp to ease reviews. >>> >>> Jacques >>> >>> >>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : >>> >>> I was saying #2 as per the comment from Taher >>>> >>>> Quick Reference: >>>> >>>> One reply from Taher ... in the same thread. >>>> == >>>> >>>> Okay, given the priorities and work we have at the moment, I suggest we >>>> keep semicolons and use it as the standard unless someone volunteers to >>>> make a full switch. WDYT? >>>> == >>>> >>>> >>>> >>>> Rishi Solanki >>>> Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> I guess you mean 2) by file, then it's OK with me. Though I'd no be >>>> >>>>> against having semicolon inconsistency in Groovy files, which was my >>>>> initial question. So no strong opinion about 2 here. >>>>> >>>>> Jacques >>>>> >>>>> >>>>> >>>>> Le 16/09/2016 à 11:31, Rishi Solanki a écrit : >>>>> >>>>> To summarize the overall conversation; >>>>> >>>>>> 1) We have decided to bulk remove semicolons from groovy. >>>>>> 2) Until #1 is not complete, we would keep adding semicolon for >>>>>> consistency. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Rishi Solanki >>>>>> Manager, Enterprise Software Development >>>>>> HotWax Systems Pvt. Ltd. >>>>>> Direct: +91-9893287847 >>>>>> http://www.hotwaxsystems.com >>>>>> >>>>>> On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < >>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>> >>>>>> Actually I was wrong on this. Thanks to Jacopo I noticed that both >>>>>> >>>>>> Subclipse and Tortoise allow you to select a range of revisions when >>>>>>> you >>>>>>> look for annotations. >>>>>>> >>>>>>> So it's no longer an issue for me and we can bulk remove trailing >>>>>>> semicolons in Groovy files if we want. >>>>>>> >>>>>>> Sorry for the confusion >>>>>>> >>>>>>> Jacques >>>>&
Re: Groovy and semicolon at EOL
Thank you very much Jacques. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Nov 2, 2016 at 4:55 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > No need to do it by hand. I did it with regexp S/R in Eclipse and have > updated the patch at OFBIZ-8652, please check > > Thanks > > Jacques > > > > Le 02/11/2016 à 09:18, Rishi Solanki a écrit : > >> Yes we have noticed some semicolons, and it seems we need to replace them >> manually. Because in all groovy files we have seen the semicolon in the >> lincense text as well. >> >> Thank you for your help Jacques :-) >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Hi Rishi, >>> >>> It's not the first time we change a *simple thing* in all the source. I >>> can live with that, you seem well organised :) >>> >>> BTW after appling the patch at OFBIZ-8652 I still find 57 trailing >>> semicolons :) >>> >>> Thanks >>> >>> Jacques >>> >>> >>> >>> Le 01/11/2016 à 07:35, Rishi Solanki a écrit : >>> >>> Jacques, >>>> >>>> Yes we would like to commit it as whole, but before commit for the same >>>> we >>>> have plan to test each component after applying the changes. Like browse >>>> to >>>> most pages and general work flows. We will post the updates on ticket >>>> something like; >>>> >>>> Test the party component; >>>> Pages/Work Flow tested: Find Party, Create Party, View Party, My >>>> Communications, Visits, Classification, Security, Invitation pages etc. >>>> >>>> The above is an example of how we will confirm everything is working >>>> properly, with some basic code review. We would follow the same steps >>>> for >>>> other components. >>>> >>>> Please let us know plan looks fine to you. Also in case you think we >>>> should >>>> take care anything else to minimize the possibility of regression Or may >>>> be >>>> if you think committing the changes per component will help in code >>>> review? >>>> >>>> Thanks! >>>> >>>> >>>> >>>> Rishi Solanki >>>> Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> Hi Rishi, >>>> >>>>> Will you commit as a whole? >>>>> >>>>> Jacques >>>>> >>>>> >>>>> >>>>> Le 28/10/2016 à 12:07, Rishi Solanki a écrit : >>>>> >>>>> Started effort under - https://issues.apache.org/jira >>>>> /browse/OFBIZ-8652 >>>>> >>>>>> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days >>>>>> for >>>>>> testing. >>>>>> >>>>>> >>>>>> Thanks! >>>>>> >>>>>> Rishi Solanki >>>>>> Manager, Enterprise Software Development >>>>>> HotWax Systems Pvt. Ltd. >>>>>> Direct: +91-9893287847 >>>>>> http://www.hotwaxsystems.com >>>>>> >>>>>> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < >>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>> >>>>>> Personally I will go this way: I will add or changes lines without >>>>>> putting >>>>>> >>>>>> semicolons. >>>>>>> >>>>>>> I'm in favour of bulk changing files, but I'd prefer by component or >>>>>>> webapp to ease reviews. >>>>>>> >>>>>>> Jacques >>>>>>> >>>>>>> >>>>>>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : >>>>>>> >>>&g
Re: Creating a new release branch in preparation for the new release
Hi Jacopo,
We would like to have OFBIZ-7828 with this branch. And we would try to
complete the effort to have all entities crud services. After that we will
work on that ticket more but, we just want to have all the basic services
with entities.I think we would be able to complete it by 5th of November.
Just to be clear more on this effort, we will address the other things in
that ticket later and complete the missing services part for this release.
Thanks!
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Oct 27, 2016 at 5:50 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:
> Thank you Jacques, I agree that delaying of 1-2 weeks would not be a big
> deal.
> If anyone is planning to contribute improvements in the next 1-2 weeks then
> please speak up and we could definitely wait for them.
>
> Jacopo
>
> On Thu, Oct 27, 2016 at 1:40 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Jacopo, All.
> >
> > Are there no major improvements that we would wish to have before cutting
> > the branch?
> >
> > I personally don't remember any. But with the 6 last months turmoil we
> > increased from around 0 issues created vs resolved to 1840 created and
> 1447
> > resolved.
> > So we have now a differential of around 400 issues pending for
> resolution.
> > https://issues.apache.org/jira/secure/Dashboard.jspa?
> selectPageId=12310800
> > I know that most of them are minor subtasks, and it's hard to follow the
> > flow.
> >
> > Anyway if you wait for an improvement it's the moment to raise a hand
> >
> > Thanks
> >
> > Jacques
> >
> >
> >
> > Le 24/10/2016 à 10:40, Jacopo Cappellato a écrit :
> >
> >> Ok, it is probably time to proceed with this plan:
> >> 1) create a new release branch named "release16.10"
> >> 2) the target goal could be that of issuing a release out of it sometime
> >> in
> >> the next month ("Apache OFBiz 16.10.01")
> >>
> >> Jacopo
> >>
> >> On Wed, Sep 7, 2016 at 1:26 PM, Taher Alkhateeb <
> >> slidingfilame...@gmail.com>
> >> wrote:
> >>
> >> +1
> >>>
> >>> On Wed, Sep 7, 2016 at 2:07 PM, Sharan Foga <sharan.f...@gmail.com>
> >>> wrote:
> >>>
> >>> That's great news ! +1
> >>>>
> >>>> Thanks
> >>>> Sharan
> >>>>
> >>>>
> >>>> On 07/09/16 12:06, Jacopo Cappellato wrote:
> >>>>
> >>>> Hi all,
> >>>>>
> >>>>> I think it is the right time to create a new release branch out of
> the
> >>>>> trunk.
> >>>>>
> >>>>> According to our naming conventions the release will be named
> >>>>> "release16.09".
> >>>>>
> >>>>> Any objections or concerns? If not, I will create the branch later
> >>>>> today/tomorrow.
> >>>>>
> >>>>> After that we will start, in a separate thread, the discussion about
> >>>>> the
> >>>>> preparation of our first release out of this branch.
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Jacopo
> >>>>>
> >>>>>
> >>>>>
> >
>
Re: Groovy and semicolon at EOL
Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for testing. Thanks! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Personally I will go this way: I will add or changes lines without putting > semicolons. > > I'm in favour of bulk changing files, but I'd prefer by component or > webapp to ease reviews. > > Jacques > > > Le 16/09/2016 à 15:36, Rishi Solanki a écrit : > >> I was saying #2 as per the comment from Taher >> >> Quick Reference: >> >> One reply from Taher ... in the same thread. >> == >> >> Okay, given the priorities and work we have at the moment, I suggest we >> keep semicolons and use it as the standard unless someone volunteers to >> make a full switch. WDYT? >> == >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> I guess you mean 2) by file, then it's OK with me. Though I'd no be >>> against having semicolon inconsistency in Groovy files, which was my >>> initial question. So no strong opinion about 2 here. >>> >>> Jacques >>> >>> >>> >>> Le 16/09/2016 à 11:31, Rishi Solanki a écrit : >>> >>> To summarize the overall conversation; >>>> 1) We have decided to bulk remove semicolons from groovy. >>>> 2) Until #1 is not complete, we would keep adding semicolon for >>>> consistency. >>>> >>>> >>>> >>>> >>>> Rishi Solanki >>>> Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> On Thu, Sep 15, 2016 at 10:00 AM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> Actually I was wrong on this. Thanks to Jacopo I noticed that both >>>> >>>>> Subclipse and Tortoise allow you to select a range of revisions when >>>>> you >>>>> look for annotations. >>>>> >>>>> So it's no longer an issue for me and we can bulk remove trailing >>>>> semicolons in Groovy files if we want. >>>>> >>>>> Sorry for the confusion >>>>> >>>>> Jacques >>>>> >>>>> >>>>> >>>>> Le 14/09/2016 à 04:42, Scott Gray a écrit : >>>>> >>>>> I don't particularly care one way or another if groovy files have a >>>>> >>>>>> semi-colon at the end. I don't even care about consistency because it >>>>>> is >>>>>> such a minor thing. >>>>>> >>>>>> I say remove them if they're on a line you happen to be editing, >>>>>> otherwise >>>>>> just leave them be. >>>>>> >>>>>> Regarding the annotations, there's plenty of ways to search commit >>>>>> logs >>>>>> and >>>>>> personally I've never found blame to be very useful. I don't think it >>>>>> should be a reason to block any future bulk S/R cleanups. We've had >>>>>> plenty >>>>>> in the past (Double -> BigDecimal, Delegator -> EntityQuery, >>>>>> whitespace >>>>>> removal, etc.) and we should continue to do it to keep things clean. >>>>>> >>>>>> For searching diffs, before using git-svn I used to use: svn log -diff >>>>>> and then use the search in the terminal to find the >>>>>> string >>>>>> I'm looking for. >>>>>> >>>>>> Regards >>>>>> Scott >>>>>> >>>>>> On 14 September 2016 at 07:33, Jacques Le Roux < >>>>>> jacques.le.r...@les7arts.com >>>>>> >>>>>> wrote: >>>>>> >>>>>>> Le 13/09/2016 à 21:28, Jacques Le Roux a écrit : >>>>>>> >>
Re: Groovy and semicolon at EOL
Yes we have noticed some semicolons, and it seems we need to replace them manually. Because in all groovy files we have seen the semicolon in the lincense text as well. Thank you for your help Jacques :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Nov 2, 2016 at 2:36 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > It's not the first time we change a *simple thing* in all the source. I > can live with that, you seem well organised :) > > BTW after appling the patch at OFBIZ-8652 I still find 57 trailing > semicolons :) > > Thanks > > Jacques > > > > Le 01/11/2016 à 07:35, Rishi Solanki a écrit : > >> Jacques, >> >> Yes we would like to commit it as whole, but before commit for the same we >> have plan to test each component after applying the changes. Like browse >> to >> most pages and general work flows. We will post the updates on ticket >> something like; >> >> Test the party component; >> Pages/Work Flow tested: Find Party, Create Party, View Party, My >> Communications, Visits, Classification, Security, Invitation pages etc. >> >> The above is an example of how we will confirm everything is working >> properly, with some basic code review. We would follow the same steps for >> other components. >> >> Please let us know plan looks fine to you. Also in case you think we >> should >> take care anything else to minimize the possibility of regression Or may >> be >> if you think committing the changes per component will help in code >> review? >> >> Thanks! >> >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Fri, Oct 28, 2016 at 4:10 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Hi Rishi, >>> >>> Will you commit as a whole? >>> >>> Jacques >>> >>> >>> >>> Le 28/10/2016 à 12:07, Rishi Solanki a écrit : >>> >>> Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652 >>>> >>>> Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days >>>> for >>>> testing. >>>> >>>> >>>> Thanks! >>>> >>>> Rishi Solanki >>>> Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> On Sat, Sep 17, 2016 at 2:11 AM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> Personally I will go this way: I will add or changes lines without >>>> putting >>>> >>>>> semicolons. >>>>> >>>>> I'm in favour of bulk changing files, but I'd prefer by component or >>>>> webapp to ease reviews. >>>>> >>>>> Jacques >>>>> >>>>> >>>>> Le 16/09/2016 à 15:36, Rishi Solanki a écrit : >>>>> >>>>> I was saying #2 as per the comment from Taher >>>>> >>>>>> Quick Reference: >>>>>> >>>>>> One reply from Taher ... in the same thread. >>>>>> == >>>>>> >>>>>> Okay, given the priorities and work we have at the moment, I suggest >>>>>> we >>>>>> keep semicolons and use it as the standard unless someone volunteers >>>>>> to >>>>>> make a full switch. WDYT? >>>>>> == >>>>>> >>>>>> >>>>>> >>>>>> Rishi Solanki >>>>>> Manager, Enterprise Software Development >>>>>> HotWax Systems Pvt. Ltd. >>>>>> Direct: +91-9893287847 >>>>>> http://www.hotwaxsystems.com >>>>>> >>>>>> On Fri, Sep 16, 2016 at 3:14 PM, Jacques Le Roux < >>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>> >>>>>> I guess you mean 2) by file, then it's OK with me. Though I'd no be >>>>>> >>>>>> against having semicolon inconsistency in Groovy files, which was my >>>>>>> initial question. So no strong opinion about 2 here.
Re: Validation messages to auto-attributes of a service
Applying same to your example; Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Oct 13, 2016 at 1:46 PM, Rishi Solanki <rishisolan...@gmail.com> wrote: > Devanshu, > > You can simply try to use override to override the default behavior of > auto-attribute. For example; if you are working on PartyContanctMech and > you want partyId and contactMechId should return custom error message if > empty. Then use the following practice to do that; > > > > > > > > > > Override tag intended to override the default behavior set in the > auto-attributes. Simply using it suggested and implemented at service > defintion level. > > > HTH! > > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Thu, Oct 13, 2016 at 11:14 AM, Devanshu Vyas <vyas.devansh...@gmail.com > > wrote: > >> Hello Guys, >> >> I came across a situation where I tried to throw a custom >> (more user-friendly) validation message when a required field in a service >> is missing. And the service definition was written with auto-attributes, >> something like this: >> >> >> >> And I found myself stuck as I wanted to throw a custom message on a >> specific field among the PKs of the entity. >> >> I want you to suggest me a way to set validate message in such situation >> like we set on a single attribute like: >> >> > optional="false"> >> >> > property="checkhelper.select_shipping_destination"/> >> >> >> >> IMO, we can think of doing something like the exclude field inside the >> auto-attributes to define the validate messages on the fields. >> >> >> >> >> >> Something like this: >> >> >> > resource="OrderUiLabels" >> property="checkhelper.select_shipping_destination"/> >> >> >> Please share your thoughts. :) >> >> -- >> Thanks and Regards, >> Devanshu Vyas >> > >
Re: Validation messages to auto-attributes of a service
Devanshu, You can simply try to use override to override the default behavior of auto-attribute. For example; if you are working on PartyContanctMech and you want partyId and contactMechId should return custom error message if empty. Then use the following practice to do that; Override tag intended to override the default behavior set in the auto-attributes. Simply using it suggested and implemented at service defintion level. HTH! Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Oct 13, 2016 at 11:14 AM, Devanshu Vyas <vyas.devansh...@gmail.com> wrote: > Hello Guys, > > I came across a situation where I tried to throw a custom > (more user-friendly) validation message when a required field in a service > is missing. And the service definition was written with auto-attributes, > something like this: > > > > And I found myself stuck as I wanted to throw a custom message on a > specific field among the PKs of the entity. > > I want you to suggest me a way to set validate message in such situation > like we set on a single attribute like: > > optional="false"> > > property="checkhelper.select_shipping_destination"/> > > > > IMO, we can think of doing something like the exclude field inside the > auto-attributes to define the validate messages on the fields. > > > > > > Something like this: > > > resource="OrderUiLabels" > property="checkhelper.select_shipping_destination"/> > > > Please share your thoughts. :) > > -- > Thanks and Regards, > Devanshu Vyas >
Ecommerce Portal Enhancement
Devs, We would like to propose few enhancement over ecommerce portal in OFBiz. In other words we want to demonstrate how to use ecommerce portal for creating your own site. Regarding the same, we were looking at some wiki documents to browse the features already exists and demonstrated by Ecommerce portal. After browsing all the features we understand from ecommerce site OFBiz have, that, it covers all the aspects as a framework to demonstrate all the possible features OFBiz can support for Ecommerce. Also it demonstrate how these features uses the data model. So we were thinking to use ecommerce clone to demonstrate our purpose. That means, how an OFBiz user can create a modern Ecommerce site using the OFBiz Ecommerce portal. But on further diagnose we found that, the ecomclone have been removed in last month as result of email thread - *"Removing the ecomclone webapp from the ecommerce component"*. Also we gone thru the usage of *ecomseo* webapp and it also use the ecommerce to demonstarte its own seo related features metioned here <https://cwiki.apache.org/confluence/display/OFBIZ/Search+Engine+Optimisation%2C+SEO+in+ecommerce>. With all this said, we would like to use the *ecomseo* for our purpose or if community is not okay with it then we can add one more webapp parallel to ecommerce. We are fine in either way. Following are the enhancements we would like to propose for it, so that we can show an modern ecommerce site using OFBiz *ecomseo* or *new webapp*. - *ecomseo* or *new webapp* already cover the search engine friendly URLs using the SeoControlServlet and SeoCatalogUrlFilter. We just need to make sure all the features are working properly if we browse to *ecomseo*. As while browsing we have seen that the breadcrumbs are not working properly in all cases, also on changing catalogs page doesn't show the related data in *ecomseo*. So first we will fix all the related issue exists in *ecomseo* . - Like many modern ecommerce site, we would like show the catalogs as menu and category navigation in the menu bar. That means, if required we can set some data specific to *ecomseo *or* new webapp.* - *Category Navigation:* should shown from Solr instead of product and category data. - *Product Search Pages:* should shown from Solr instead of product keywords. With all the basic feature filtering criteria. - *Product Detail Page:* should show the minimum required fixed set of product features. That means, it does not cover all type of products like configurable products and other complex products. This also mean that, at some point we would like to narrow the ecommerce features and keep the general items required by mostly. - *Login and Registration:* We would like to add basic site registration process with minimum information. - *Shopping Cart:* Shopping cart will have all the basic functionality with fancy UI and JS support. - *Checkout:* Only one single page checkout with no steps. Fancy UI and JS support. It also includes the changes on assumption like by default billing and shipping address will be same and based on user action process will separate them. - *Overall Changes:* With the above basic flow changes on ecommerce, we would also override the decorators, UI, UX and add JS support to follow the latest standards. We would love to hear from community on this, and inputs on other areas if we missed something. Also if we do agree to do these changes, then we will start documenting the things one by one in detail on wiki probably with some wireframes to understand the things better. And after community agree on each item we can start on fixing the flows as per the final design. Thanks to Jacques and Pranay for the adding useful documents on wiki. It help us for identifying the work flows, the usage of apps, and preparing this basic plan. Thanks to Arun Patidar for discussion and planning. References: - https://cwiki.apache.org/confluence/display/OFBIZ/ Search+Engine+Optimisation%2C+SEO+in+ecommerce - https://cwiki.apache.org/confluence/display/OFBIZ/ Business+Process+Stories+and+Use+Cases+Library - https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce -- Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com
Re: Suggestion for Use Cases of Product Search in Ofbiz Ecommerce
- Rendering of products through the keyword passed in search context. - Advance search feature should run on the other parameters. - Product with basic informations. - Pagination. - Also on how we can validate if a product is searchable on specific keyword then how can be we sure that those products should come in a particular category. Some links like product link, other search pages related links etc should be there in the test case. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Dec 17, 2016 at 5:38 PM, Shubham Agrawal < shubham.agra...@hotwaxsystems.com> wrote: > Hello All, > > I am writing use cases of Product Search in OFBiz ecommerce, I would need > help of the community to find out all the possible scenarios those should > be taken in consideration. > > So please suggest me the use cases for the same. > > > *Thanks and Regards,* > *Shubham Agrawal* >
Re: Test cases for Category Navigation
I think you can include the number of products should display under one category, number of subcategories display under category. In case list of products have multiple pages then it should work properly. Also on how we can validate if a product/category is under specific category then how can be we sure that those products or catgories should come under the browsed category. Some links like product link, other category swithing links, catgory tree should be working etc should be there in the test case. I could recall only these, may be others from community could help more. -- Rishi Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Dec 17, 2016 at 4:59 PM, Ayushi Gupta < ayushi.gu...@hotwaxsystems.com> wrote: > Hello All, > > I want to write test cases for category navigation functionality of OFBiz. > I have listed out some test cases as follows: > > - Rendering of categories/sub-categories > - Rendering of products through categories/sub-categories > - Product with basic informations > > Please suggest any other possible test cases related to category navigation > in OFBiz. > > -- > > Thanks with regards, > > Aayushi Gupta >
Re: User Acceptance Test Cases For Ecommerce 14.12
Thanks Taher, Yes Jacques also push the similar idea in this thread, and we do agree with him to add automated tests to run them frequently. Adding UATs requires focus on the process with passion. Again I do agree here to add the selenium, soon we would try to plan this effort. Thanks again, Community please review and share your feedback so that we can improve and follow the practice in all other component documents. Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Apr 15, 2017 at 9:22 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Great work Rishi, keep them coming! > > I wonder if you can also create some selenium scripts to automate some of > these tests and add them to the wiki? > > On Sat, Apr 15, 2017 at 6:30 PM, Rishi Solanki <rishisolan...@gmail.com> > wrote: > > > Folks, > > > > We have completed the first draft of the document for the Ecommerce > > Component > > <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> and > > added UATs for all the user stories. Also we have follow the pattern to > use > > h4 h5 and h6 headings in the documents so that user can easily navigate > to > > the user story/ user acceptance test she wants. > > > > As a first draft we tried to cover all known possible tests, but it might > > be possible we missed something. We would like to get feedback from > > community so that we can make it better in terms of usability, > readability > > and number of items we have tested. > > > > Please review and share your feedback on each item, like language we use, > > document formation, use cases we covered etc. We would try to cover them > in > > our next draft and improve the document. And once finalize we would start > > using that pattern going forward for all such documents. > > > > Thanks! > > > > > > Rishi Solanki > > Sr. Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > > > On Sat, Feb 18, 2017 at 9:49 PM, Rishi Solanki <rishisolan...@gmail.com> > > wrote: > > > > > Folks, > > > > > > Added two more UAT as Category Navigation and Product Search > > > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I > > > observe some scope of improvements like UAT writing aren't following > > common > > > patterns, I'll review and fix them soon. > > > > > > Soon we would add remaining in the ecommerce area, looking for your > > > feedback and suggestions on it. > > > > > > > > > Rishi Solanki > > > Sr. Manager, Enterprise Software Development > > > HotWax Systems Pvt. Ltd. > > > Direct: +91-9893287847 > > > http://www.hotwaxsystems.com > > > > > > On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < > > > jacques.le.r...@les7arts.com> wrote: > > > > > >> Thanks Rishi, > > >> > > >> Indeed I needed a clarification, sorry for that. > > >> > > >> It's a great initiative, OFBiz will then really be at professional > > >> standards, and that's great! > > >> > > >> I agree that we have first to create and document these UAT and then > > >> think about a tool to run them. > > >> Cucumber seems the best tool for that to me. I also know that Gil > > >> (Portenseigne) from Néréide has begun to use Cucumber for a custom > > project, > > >> hence my haste :) > > >> > > >> Jacques > > >> > > >> > > >> > > >> Le 23/01/2017 à 08:05, Rishi Solanki a écrit : > > >> > > >>> Thanks Jacques for your reply and raising concerns. It seems that, I > > was > > >>> not clear enough. Let me try to rephrase what we are doing. If you > > >>> observe > > >>> then Pranay has created new hierachy for each release like 14.12, > 15.12 > > >>> ... > > >>> so on. > > >>> > > >>> For each release we have the user stories, and we are adding UATs for > > >>> each > > >>> user story. For each user story we are discussing the cases we should > > >>> test > > >>> manually and also try them to dicuss on the mailing list (user/dev). > > Once > > >>> we are sure, we document and test the cases (manually) and put the &
Re: User Acceptance Test Cases For Ecommerce 14.12
Folks, We have completed the first draft of the document for the Ecommerce Component <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> and added UATs for all the user stories. Also we have follow the pattern to use h4 h5 and h6 headings in the documents so that user can easily navigate to the user story/ user acceptance test she wants. As a first draft we tried to cover all known possible tests, but it might be possible we missed something. We would like to get feedback from community so that we can make it better in terms of usability, readability and number of items we have tested. Please review and share your feedback on each item, like language we use, document formation, use cases we covered etc. We would try to cover them in our next draft and improve the document. And once finalize we would start using that pattern going forward for all such documents. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Feb 18, 2017 at 9:49 PM, Rishi Solanki <rishisolan...@gmail.com> wrote: > Folks, > > Added two more UAT as Category Navigation and Product Search > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I > observe some scope of improvements like UAT writing aren't following common > patterns, I'll review and fix them soon. > > Soon we would add remaining in the ecommerce area, looking for your > feedback and suggestions on it. > > > Rishi Solanki > Sr. Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Thanks Rishi, >> >> Indeed I needed a clarification, sorry for that. >> >> It's a great initiative, OFBiz will then really be at professional >> standards, and that's great! >> >> I agree that we have first to create and document these UAT and then >> think about a tool to run them. >> Cucumber seems the best tool for that to me. I also know that Gil >> (Portenseigne) from Néréide has begun to use Cucumber for a custom project, >> hence my haste :) >> >> Jacques >> >> >> >> Le 23/01/2017 à 08:05, Rishi Solanki a écrit : >> >>> Thanks Jacques for your reply and raising concerns. It seems that, I was >>> not clear enough. Let me try to rephrase what we are doing. If you >>> observe >>> then Pranay has created new hierachy for each release like 14.12, 15.12 >>> ... >>> so on. >>> >>> For each release we have the user stories, and we are adding UATs for >>> each >>> user story. For each user story we are discussing the cases we should >>> test >>> manually and also try them to dicuss on the mailing list (user/dev). Once >>> we are sure, we document and test the cases (manually) and put the >>> results >>> in the Actual results and Pass/Fail. >>> >>> Please note that, before documenting anything as Pass or Fail we are >>> really >>> running that scenario. The intention of doing this, we can say that the >>> released branches of OFBiz are tested on certain scenarios and all get >>> passed. After completing this activity, we as a community can say 14.12 >>> branch tested for say 1000 user acceptance test cases and out of them 950 >>> get passed and 50 are reported and fail for that branch. Once we complete >>> this activity, we could start fixing them. >>> >>> For the same we have started multiple email threads to get the feedback >>> from community, so that we could get more cases for the user stories. In >>> other words, we have automated tests with us, but this time we are trying >>> to add documents for the manual tests user could see and increase in >>> faith >>> on each relase. >>> >>> I hope I'm clear this time :-). And yes I agree on the fact that we >>> should >>> think on automating these tests to run them frequently. And I think for >>> that we again need what to tests get documented. We can assume it as >>> first >>> step towards automation. >>> >>> PS: Team, please add more details if I miss something. >>> >>> >>> Rishi Solanki >>> Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> >>> On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < >>> jacques.le.r...@le
Re: Should be keep the multitenant feature even if broken?
I dig into the issue and proposed one solution in the same Jira ticket OFBIZ-9230. Please see if it looks fine or may be we can proceed in that direction. Quick Reference from ticket: "In the template/FTL context or in the screen context whenever we get the delegator as null we can use this delegatorName first from session and if it is empty then we could try to use default delegator." Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Mar 4, 2017 at 1:13 AM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > All good points Michael. Replacing is neither short term nor easy as many > places in the code base depend on this feature, not to mention the need for > community approval too. I just mentioned this as an alternative solution > from a technical standpoint. > > So our best bet is to fix the issue mentioned by Jacques. > > On Mar 3, 2017 9:16 PM, "Michael Brohl" <michael.br...@ecomify.de> wrote: > > > Hi Taher, > > > > I don't think that this is a valid short-term approach. > > > > As far as I know, there are users and also service providers relying on > > the multi-tenant feature and we should have a mid- to long-term roadmap > for > > a migration to other solutions. > > > > It would be really helpful to have some opinions by users of the > > multi-tenancy feature. > > > > Best regards, > > > > Michael > > > > > > Am 03.03.17 um 13:22 schrieb Taher Alkhateeb: > > > >> In my opinion, the multi-tenancy feature can be reasonably replaced with > >> non-java databases like mysql and postgres combined with docker. Both > >> instances share the same code base but with two different runtime > volumes > >> and two databases. This would actually reduce the complexity of the code > >> base, especially the entity engine. > >> > >> On Mar 3, 2017 10:39 AM, "Jacques Le Roux" < > jacques.le.r...@les7arts.com> > >> wrote: > >> > >> Hi, > >>> > >>> After my analysis at https://s.apache.org/hvR9 if we don't fix the > >>> issues > >>> reported there I wonder if we don't need to remove the multitenant > >>> feature, > >>> better not to propose a broken solution! > >>> > >>> Jacques > >>> > >>> > >>> > > > > >
Re: Documentation by Release / Version
See if this effort can be part of - https://cwiki.apache.org/confluence/display/OFBIZ/Business+Process+Stories+and+Use+Cases+Library For more details please refer the email thread - ofbiz.markmail.org/search/?q=User+Acceptance+Test+Cases+For+Ecommerce+14.12 Or you would like to do it as completely separate effort and document will target completely different audiance/purpose? Thanks! Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Mar 10, 2017 at 4:05 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > Jacques > > > Le 10/03/2017 à 02:45, james yong a écrit : > >> Hi Jacques, >> >> I like your approach too. I propose creating a Tour page in Confluence. >> This tour page will have a direct child page for the recent OFBiz >> releases, >> like the following menu structure: >> >> Tour >> -> Release 13.7 >> -> Release 16.11 >> >> Each of the Release xx.x page is a Table of Content that links to other >> existing pages. >> The tour is meant for beginner and they are expected to go through the >> topics from top to bottom. >> With this approach, there will not be direct child page under each >> Release >> xx.x page. Existing documentation isn’t affected. >> >> Regards, >> James >> >> >> >> Jacques Le Roux wrote >> >> Hi James, >>> >>> I'm all for it. >>> >>> Note that I already used another strategy by referring to the history of >>> few major pages[1] while documenting the Gradle from Ant. It though was a >>> more an expedient than a structured way as you are proposing. But it >>> could >>> still be used when referring to old pages... >>> >>> [1] These pages contain the sentence "the pre-Gradle documentation is >>> here", eg >>> https://cwiki.apache.org/confluence/display/OFBIZ/Demo+and+ >>> Test+Setup+Guide >>> >>> Jacques >>> >>> >>> Le 08/03/2017 à 18:05, james yong a écrit : >>> >>>> Hi all, >>>> >>>> I am planning to add some new documentation in Confluence but will have >>>> them >>>> placed/linked under the affected OFBiz release / version. For a user >>>> navigating the documentation, the user can click on a particular OFBiz >>>> release on the menu tree to display the list of topic for that OFBiz >>>> version. >>>> >>>> What do you think of this approach? Are there better ways to structure >>>> the >>>> menu items? >>>> >>>> Cheers, >>>> James Yong >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://ofbiz.135035.n4.nabble.com/Documentation-by-Release-V >>>> ersion-tp4703069.html >>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >>>> >>>> >> >> >> >> -- >> View this message in context: http://ofbiz.135035.n4.nabble. >> com/Documentation-by-Release-Version-tp4703069p4703111.html >> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >> >> >> >
Re: Should be keep the multitenant feature even if broken?
Thanks Jacques! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Mar 8, 2017 at 3:37 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks for your ideas Rishi, > > Fixed with OFBIZ-9230 > > I had a look at checkRhsType() but that's another beast. Because AFAIK the > delegator only misses when checkRhsType is called indirectly from the > JobPoller. > > It begins to miss in this line in selectCountByCondition() > > makeConditionWhereString(sqlBuffer, " WHERE ", modelEntity, > whereEntityCondition, viewWhereConditions, whereEntityConditionParams); > > I have created OFBIZ-9249, it's minor but not trivial! > > Jacques > > > > Le 04/03/2017 à 15:07, Rishi Solanki a écrit : > >> I dig into the issue and proposed one solution in the same Jira ticket >> OFBIZ-9230. Please see if it looks fine or may be we can proceed in that >> direction. >> >> Quick Reference from ticket: "In the template/FTL context or in the screen >> context whenever we get the delegator as null we can use this >> delegatorName >> first from session and if it is empty then we could try to use default >> delegator." >> >> Thanks! >> >> >> Rishi Solanki >> Sr. Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sat, Mar 4, 2017 at 1:13 AM, Taher Alkhateeb < >> slidingfilame...@gmail.com> >> wrote: >> >> All good points Michael. Replacing is neither short term nor easy as many >>> places in the code base depend on this feature, not to mention the need >>> for >>> community approval too. I just mentioned this as an alternative solution >>> from a technical standpoint. >>> >>> So our best bet is to fix the issue mentioned by Jacques. >>> >>> On Mar 3, 2017 9:16 PM, "Michael Brohl" <michael.br...@ecomify.de> >>> wrote: >>> >>> Hi Taher, >>>> >>>> I don't think that this is a valid short-term approach. >>>> >>>> As far as I know, there are users and also service providers relying on >>>> the multi-tenant feature and we should have a mid- to long-term roadmap >>>> >>> for >>> >>>> a migration to other solutions. >>>> >>>> It would be really helpful to have some opinions by users of the >>>> multi-tenancy feature. >>>> >>>> Best regards, >>>> >>>> Michael >>>> >>>> >>>> Am 03.03.17 um 13:22 schrieb Taher Alkhateeb: >>>> >>>> In my opinion, the multi-tenancy feature can be reasonably replaced with >>>>> non-java databases like mysql and postgres combined with docker. Both >>>>> instances share the same code base but with two different runtime >>>>> >>>> volumes >>> >>>> and two databases. This would actually reduce the complexity of the code >>>>> base, especially the entity engine. >>>>> >>>>> On Mar 3, 2017 10:39 AM, "Jacques Le Roux" < >>>>> >>>> jacques.le.r...@les7arts.com> >>> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>>> After my analysis at https://s.apache.org/hvR9 if we don't fix the >>>>>> issues >>>>>> reported there I wonder if we don't need to remove the multitenant >>>>>> feature, >>>>>> better not to propose a broken solution! >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> >>>>>> >>>> >
Re: Remove as much as possible delete and remove services
+1 for the proposal with some caution (as suggested by Paul) on picking an entity as candidate which won't have the delete service with it. Some basic steps I could think of we should follow in the effort. Please feel free to add more check points. 1) Identify such entities, where we have to remove the delete/remove services. 1.1) To make an entity as candidate to fall under this, it should maintain the status or manage from date and thru date. Like Party and WorkEffort will have enable/disable flag and statuses. So we can consider them to follow the pattern mentioned in this thread. May be other entities which won't have these attributes could fall, but I think it is easiest way to count any entity IN. 2) Check all occurrences and check what could be the side effect in the process/workflow and how we can handle them. 3) Once we remove/change all occurrences, remove/change the delete/remove service for the entity. Just FYI all, Related discussion started by Suraj in other thread as "Proper record maintenance in marketing component" which tells we should add from date and thru date in some entities. So if community agree on that point then we could consider those entities as well for improvement. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Aug 2, 2017 at 11:33 AM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > +1 for using 'expire' service for all the possible places. > > IMO, In ERP systems, we should not delete any information/data. Because > data is the real asset for the any organization. Helping in taking the > business decision. > > Thanks, Jacques and Deepak for sharing this. > > > - Best Regards, > Swapnil M Mane > www.hotwaxsystems.com > www.hotwax.co > > On Tue, Aug 1, 2017 at 8:04 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi, > > > > After a 1st discussion with Deepak at OFBIZ-9185, we had another at > > OFBIZ-9543. > > > > We claim that we should not remove entities records because of auditing. > > But we have at 157 services with names starting with "remove" and 538 > > starting with "delete" > > > > I suggest that we remove as much as possible of these services and have > > only expire services for those which support expire (ie have from and > thru > > dates). > > > > For instance I was curious about deleteParty, but what it currently does > > is only returning the "partyservices.cannot_delete_ > party_not_implemented" > > label. This is pre Apache era (ie there for 10+ years)! > > > > In OFBIZ-9543 Deepak rightly suggested that we keep delete services for > > Assoc kind of entities. But definitely remove delete service for entity > > like Party, WorkEffort, Product, etc those have n number of foreign key > > constraints... > > > > What do you think, other ideas? > > > > Jacques > > > > >
Re: Remove as much as possible delete and remove services
Taher, Are you proposing to move only crud services or crud and basic services or all. Asking this to understand the exact proposal. +1 Deepak to keep the work independent. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Aug 2, 2017 at 2:22 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > Jacques > > > > Le 02/08/2017 à 10:44, Deepak Dixit a écrit : > >> Hi Taher, >> >> I think we can keep both work independent, as it will be very messy if we >> do renaming/cleaning and movement in single shot. >> >> Thanks & Regards >> -- >> Deepak Dixit >> www.hotwaxsystems.com >> www.hotwax.co >> >> On Wed, Aug 2, 2017 at 1:44 PM, Taher Alkhateeb < >> slidingfilame...@gmail.com> >> wrote: >> >> Hi Paul, no what I meant is a new single component where move all >>> services to it. The reason I suggested that is to reduce "mass >>> operations" and make them into one. >>> >>> Our services require a lot of cleanup, renaming, fixing, etc ... so I >>> guess I just rushed an email which I wanted to carefully write in a >>> more comprehensive thread, but I'm just not sure if people are >>> interested in going that route >>> >>> On Wed, Aug 2, 2017 at 10:24 AM, Paul Foxworthy <p...@cohsoft.com.au> >>> wrote: >>> >>>> On 2 August 2017 at 16:37, Taher Alkhateeb <slidingfilame...@gmail.com> >>>> wrote: >>>> >>>> If you are willing to make the effort towards >>>>> naming all these services then you might as well consider unifying >>>>> them. >>>>> >>>> >>>> Hi Taher, >>>> >>>> Are you proposing one expire service for all entities, which sets the >>>> thruDate attribute? >>>> >>>> If I understand you right, what would we do for entities without a >>>> thruDate? How would we define the expected paramaters, when primary keys >>>> vary between the different entities? >>>> >>>> Cheers >>>> >>>> Paul >>>> >>>> -- >>>> Coherent Software Australia Pty Ltd >>>> PO Box 2773 >>>> Cheltenham Vic 3192 >>>> Australia >>>> >>>> Phone: +61 3 9585 6788 >>>> Web: http://www.coherentsoftware.com.au/ >>>> Email: i...@coherentsoftware.com.au >>>> >>> >
Re: Welcome Akash Jain as a New Committer!
Congratulations Akash! :-) Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Aug 11, 2017 at 1:01 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Welcome to the team, Akash! > > Regards, > > Michael > > Am 09.08.17 um 10:58 schrieb Sharan Foga: > > The OFBiz PMC has invited Akash Jain to become a new committer and are >> happy to announce that he has accepted. >> >> Some of the key factors considered for inviting him were as follows: >> >> - He has been involved with the OFBiz project for quite a while which >> shows his dedication and commitment >> - He has a lot of good knowledge (both functional and technical) that he >> is happy to share which shows he is a good team player >> - He is very active, positive and respectful to others in the community >> - He has contributed patches and shows a willingness to learn which is >> really important as the project continues to go through changes >> >> Please join me in welcoming and congratulating Akash. >> >> Thanks >> Sharan >> > > >
Re: Welcome Rishi Solanki as a New Committer!
Thanks to all for the wonderful wishes and support. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Aug 11, 2017 at 1:01 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Welcome to the team, Rishi! > > Regards, > > Michael > > Am 09.08.17 um 10:56 schrieb Sharan Foga: > > The OFBiz PMC has invited Rishi Solanki to become a new committer and are >> happy to announce that he has accepted. >> >> Some of the key factors considered for inviting him were as follows: >> >> - He has been involved with the OFBiz project for quite a while which >> shows dedication and commitment >> - He has a lot of good knowledge that he is happy to share which shows he >> is a good team player >> - His work is consistent, has good code quality and he has provided a >> range of patches >> - He is friendly, respectful and keen to help out others in the community >> >> Please join me in welcoming and congratulating Rishi! >> >> Thanks >> Sharan >> > > >
Re: OFBiz Sanity Test Document
Thanks Sanjay for great effort, Moving this thread to dev list for better handling of feedback. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sun, Jul 9, 2017 at 3:46 PM, Sanjay Yadav <sanjay.ya...@hotwaxsystems.com > wrote: > Hello Everyone, > > I've created OFBiz Sanity Test document at below location - > > <http://goog_291272848> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test > > Please have a look and let me know your feedback. Thanks! > > > Best Regards, > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems > <http://www.hotwaxsystems.com/> > 80, Scheme No. 78, Part II, Indore, M.P. 452010, India > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav > <https://www.linkedin.com/in/sanjay-yadav/> > > HotWax Systems recently received 8 mentions in *The Gartner Digital > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT > research and advisory company. Learn more about our research here > <https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html> > . > [image: Inline image 1] > > >
Re: [Discussion] Failing the build if data loading fails
I'm good to go with option #3 and continue-on-failure. Just wanted to mention one thing here; for which type of data we will be failing build. That means, we have several options seed, ext, demo. Do we need to discuss these points or we are fine for all type of data. Like demo data fails only affect a process for that data set only, and for that failing build is okay or not (as on data load we get logs if any file didn't load). Btw, I'm good with the proposal, just sharing a thought in case we should discuss or may be we can simply ignore if we are good with that. Thaks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > > Historically the data loader boolean props are false if ommitted and the > > code expects that, but you have a point about the double negative. We can > > instead call it "continue-on-failure" for example. > > > > +1 continue-on-failure with default value false > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > > > > > > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" <p...@cohsoft.com.au> wrote: > > > > Hi all, > > > > I agree with option 3. I recall in my own work I once needed to add a > throw > > where there was none to track down a problem. > > > > However ignore-failure leads to a double negative. How about > > "stop-on-failure", default value true? > > > > Cheers > > > > Paul Foxworthy > > > > > > On 10 July 2017 at 05:27, Taher Alkhateeb <slidingfilame...@gmail.com> > > wrote: > > > > > Correction: on item (2) in my post: fail immediately, not after > > > loading all files, otherwise there's no point. > > > > > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb > > > <slidingfilame...@gmail.com> wrote: > > > > Hello Everyone, > > > > > > > > For a long time I was annoyed by something in OFBiz: the build system > > > > does not fail if data loading fails for some files. I spend hours > > > > hunting bugs only to discover that the data simply did not load. > > > > > > > > Given that I'm working on refactoring the data loading container, I > > > > believe this issue should resolved. However, I'm not sure if the > > > > community is interested in making such a change. > > > > > > > > So I list below 3 options to select from: > > > > > > > > 1- Leave it as is, do not fail the build if some files do not load > > > > 2- Continue loading until all files are done and then fail the build > > > > 3- Provide a flag e.g. ignore-failure that tells the system whether > to > > > > fail or not with a default value of "false". > > > > > > > > My personal preference is for (3) > > > > > > > > WDYT? > > > > > > > > > > > -- > > Coherent Software Australia Pty Ltd > > PO Box 2773 > > Cheltenham Vic 3192 > > Australia > > > > Phone: +61 3 9585 6788 > > Web: http://www.coherentsoftware.com.au/ > > Email: i...@coherentsoftware.com.au > > >
Re: Document Location
Thanks all, in case no objection in a day or two we will do the changes in structure. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav < sanjay.ya...@hotwaxsystems.com> wrote: > +1 > > Best Regards, > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems > <http://www.hotwaxsystems.com/> > 80, Scheme No. 78, Part II, Indore, M.P. 452010, India > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav > <https://www.linkedin.com/in/sanjay-yadav/> > > HotWax Systems recently received 8 mentions in *The Gartner Digital > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT > research and advisory company. Learn more about our research here > <https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html> > . > [image: Inline image 1] > > > > On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey < > pranay.pan...@hotwaxsystems.com> wrote: > >> +1 >> >> Best regards, >> Pranay Pandey >> www.hotwaxsystems.com >> >> >> On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki <rishisolan...@gmail.com> >> wrote: >> >> > Hi Pierre Smits/All, >> > >> > I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz >> at a >> > small or medium sized brewery <https://cwiki.apache.org/ >> > confluence/x/64HoAg> >> > >> > I see this is good case study thanks Pierre for that. The only concern I >> > have is this is under the 'Business Process Stories and Use Cases >> Library' >> > as parent. I would propose new location for the document. >> > >> > Current Location: Document > Business Process Stories and Use Cases >> Library >> > > Brewing with OFBiz at a small or medium sized brewery >> > >> > Proposed Location: Document > Case Study > Brewing with OFBiz at a >> small or >> > medium sized brewery >> > >> > >> > Proposing this so that in case other wanted to add case study then all >> can >> > be found at one place. >> > >> > If everyone agree then we can move this to new location. >> > >> > >> > Thanks! >> > >> > Rishi Solanki >> > Sr Manager, Enterprise Software Development >> > HotWax Systems Pvt. Ltd. >> > Direct: +91-9893287847 >> > http://www.hotwaxsystems.com >> > >> > >
Re: [Discussion] Failing the build if data loading fails
Thanks Taher for your reply. I was just pushing the types to set some type of data as in ignoring. But, now I am completely agree with you on point "The data will automatically get cleaned by committers because no failing data will be committed to the code base". Again +1 for #3 with option continue-on-failure with default false, with no confusion in thread from my side. :-) -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Hi Rishi, > > So my suggestion is that if anything does not load, then immediately fail. > > Why am I suggesting this? > - You have to intentionally ignore data failure after being aware of > it (it does not slip between the cracks) > - The data will automatically get cleaned by committers because no > failing data will be committed to the code base. > > I suspect we will actually catch some data loading failures that exist > in the code base and we are maybe unaware of. > > On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki <rishisolan...@gmail.com> > wrote: > > I'm good to go with option #3 and continue-on-failure. > > > > Just wanted to mention one thing here; for which type of data we will be > > failing build. That means, we have several options seed, ext, demo. Do we > > need to discuss these points or we are fine for all type of data. Like > demo > > data fails only affect a process for that data set only, and for that > > failing build is okay or not (as on data load we get logs if any file > > didn't load). > > > > > > Btw, I'm good with the proposal, just sharing a thought in case we should > > discuss or may be we can simply ignore if we are good with that. > > > > Thaks! > > > > > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > > > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit < > > deepak.di...@hotwaxsystems.com> wrote: > > > >> > Historically the data loader boolean props are false if ommitted and > the > >> > code expects that, but you have a point about the double negative. We > can > >> > instead call it "continue-on-failure" for example. > >> > > >> > >> +1 continue-on-failure with default value false > >> > >> Thanks & Regards > >> -- > >> Deepak Dixit > >> www.hotwaxsystems.com > >> www.hotwax.co > >> > >> > >> > >> > > >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" <p...@cohsoft.com.au> > wrote: > >> > > >> > Hi all, > >> > > >> > I agree with option 3. I recall in my own work I once needed to add a > >> throw > >> > where there was none to track down a problem. > >> > > >> > However ignore-failure leads to a double negative. How about > >> > "stop-on-failure", default value true? > >> > > >> > Cheers > >> > > >> > Paul Foxworthy > >> > > >> > > >> > On 10 July 2017 at 05:27, Taher Alkhateeb <slidingfilame...@gmail.com > > > >> > wrote: > >> > > >> > > Correction: on item (2) in my post: fail immediately, not after > >> > > loading all files, otherwise there's no point. > >> > > > >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb > >> > > <slidingfilame...@gmail.com> wrote: > >> > > > Hello Everyone, > >> > > > > >> > > > For a long time I was annoyed by something in OFBiz: the build > system > >> > > > does not fail if data loading fails for some files. I spend hours > >> > > > hunting bugs only to discover that the data simply did not load. > >> > > > > >> > > > Given that I'm working on refactoring the data loading container, > I > >> > > > believe this issue should resolved. However, I'm not sure if the > >> > > > community is interested in making such a change. > >> > > > > >> > > > So I list below 3 options to select from: > >> > > > > >> > > > 1- Leave it as is, do not fail the build if some files do not load > >> > > > 2- Continue loading until all files are done and then fail the > build > >> > > > 3- Provide a flag e.g. ignore-failure that tells the system > whether > >> to > >> > > > fail or not with a default value of "false". > >> > > > > >> > > > My personal preference is for (3) > >> > > > > >> > > > WDYT? > >> > > > >> > > >> > > >> > > >> > -- > >> > Coherent Software Australia Pty Ltd > >> > PO Box 2773 > >> > Cheltenham Vic 3192 > >> > Australia > >> > > >> > Phone: +61 3 9585 6788 > >> > Web: http://www.coherentsoftware.com.au/ > >> > Email: i...@coherentsoftware.com.au > >> > > >> >
