[Freeciv-Dev] [patch #3471] Set S2_4 "beta bit" on before actual beta1 release

[Marko Lindqvist]

URL:
  

 Summary: Set S2_4 "beta bit" on before actual beta1 release
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 01 Aug 2012 06:37:57 AM EEST
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0-beta1

___

Details:

Would it make sense to switch IS_BETA_VERSION 'on' (and IS_DEVEL_VERSION
'off') in S2_4 already, with version number being something like -beta0 or
just to remain -alpha, so beta-style builds would be somewhat tested before
first actual beta release?

I don't think we've ever done that, and there has been no problems (but one
close call when it occurred to me to locally test beta build just before
release to find out that it didn't compile).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3457] Set estimated release month for 2.4.0 to February

[Marko Lindqvist]

Update of patch #3457 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20015] Initial default_metaserver value is not magic value "default" but explicit value

[Marko Lindqvist]

Update of bug #20015 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.3.3, 2.4.0, 2.5.0

___

Follow-up Comment #1:

Fixes

(file #16264, file #16265)
___

Additional Item Attachment:

File name: DefaultDefaultMeta.patch   Size:0 KB
File name: DefaultDefaultMeta-S2_3.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20002] x.m4 uses "==" instead of "=" for comparison

[Marko Lindqvist]

Update of bug #20002 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20015] Initial default_metaserver value is not magic value "default" but explicit value

[Marko Lindqvist]

URL:
  

 Summary: Initial default_metaserver value is not magic value
"default" but explicit value
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 01 Aug 2012 05:48:14 AM EEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

>From bug #20014

Newly installed client does not use magic metaserver value "default", but
saves explicit URL.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20014] References to metaserver.phtml

[Marko Lindqvist]

Follow-up Comment #2, bug #20014 (project freeciv):

> The metaserver.phtml URL is also going to persist in people's
> config files for a long time, unless we do something special to
> rewrite it to the magic value "default".

Indeed, there seems to be bug in setting magic value "default" for new
installations. I got client listing (and saving) actual
"http://meta.freeciv.org/metaserver.php"; after I had removed entry completely
from config file. However, when I manually set it to value "default" it kept
that value over config load/save.

It seems that new installations done even after magic value was introduced
have got explicit URL to their config.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3470] Document use of --with-followtag in README.packaging

[Marko Lindqvist]

Follow-up Comment #2, patch #3470 (project freeciv):

(Previous comment brought to you by frustation of porting patch to S2_0 where
separate builddirs are broken and one has to use builddir == srcdir)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3470] Document use of --with-followtag in README.packaging

[Marko Lindqvist]

Follow-up Comment #1, patch #3470 (project freeciv):

Nitpick: Could you avoid "./configure", i.e., giving example of running
configure in srcdir. While we are not even recommending (some gnu packages
even force) use of separate builddir(s), could we at least not to recommend
the opposite.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

[Marko Lindqvist]

Update of bug #20003 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

[Marko Lindqvist]

Follow-up Comment #10, bug #20003 (project freeciv):

> I see two possible ways to fix this.

Well, third one is what I've planned to do for a long time*: give
dio_get_xxx() functions return values telling if they succeeded or failed.
Patch attached.

*) According to very old TODO I had actually foreseen possibility of infinite
loop somewhere when I first came across the dio_get_xxx() functions and
noticed their lack of return value.

Any volunteers to do throughout checking of all dio_get_xxx() callers in case
there's other places where return values (added by this patch) should be
checked.

(file #16260, file #16261, file #16262, file #16263)
___

Additional Item Attachment:

File name: RetvalForDioGet.patch  Size:14 KB
File name: RetvalForDioGet-S2_3.patch Size:12 KB
File name: RetvalForDioGet-S2_2.patch Size:13 KB
File name: RetvalForDioGet-S2_0.patch Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3456] Add language names list

[Marko Lindqvist]

Follow-up Comment #4, patch #3456 (project freeciv):

> Is omission of nb = "Norwegian Bokmål" deliberate?

Not intentional. I just listed .po files from svn and forgot that nb.po gets
generated (=is not in svn) by a ugly hack. Do we want it listed? And as
language names are currently in English, what it should be called? ("Standard
Norwegian"? (my Swedish just barely passed equivalent of Highschool, but 'bok'
means 'book' and 'mål' language))

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

[RafałMużyło]

Follow-up Comment #3, patch #3469 (project freeciv):

Also, there's a little thing I've missed in the initial port (mainly cause it
was still hybrid then) - except for most gdk_window_get_pointer calls, those
calls can be made far more simple via the content of events they handle.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3456] Add language names list

[Jacob Nevins]

Follow-up Comment #3, patch #3456 (project freeciv):

Sorry late comments but:
* Typo "Czesh" should be "Czech"
* Is omission of nb = "Norwegian Bokmål" deliberate? I'm guessing so given
the arrangements in patch #3463, which only include languages on this list in
the Windows installer; I think nb.po (= no.po) is a hack so that language
detection does the Right Thing on Linux, and is thus irrelevant to Windows?
But thought I should check.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20006] Server option "-a" help says "-D" required, but omitting one is not considered error

[Jacob Nevins]

Update of bug #20006 (project freeciv):

 Planned Release: => 2.4.0,2.5.0

___

Follow-up Comment #1:

True. On the other hand, it's useless to specify -a without -D, because
there's nowhere to get credentials from. We should probably make it fail.

(Which makes it look a bit silly that we moved from "-a file" in the first
place, but I guess that maybe fcdb was intended to have uses other than
authentication.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20007] script_fcdb_init() calls luascript_destroy(NULL)

[Jacob Nevins]

Follow-up Comment #1, bug #20007 (project freeciv):

Probably related thing I noticed a while ago: if fcdb is compiled in but not
enabled, a command like "/fcdb lua print('Hello')" causes the server to
segfault. '/fcdb reload' is not particularly happy either. I looked briefly at
fixing it but it was tangled.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Ancients modpack (was: [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org)

[Marko Lindqvist]

On 1 August 2012 02:14, Jacob Nevins
<0jacobnk.fc...@chiark.greenend.org.uk> wrote:
> Marko Lindqvist writes:
>> I actually would like to hear opinions about Ancients ruleset's
>> status. Should it be in default modpack list?
>
> I've been meaning to ask about that. READMEs that are around
> 
> suggest that Daniel used to look after it around 2.0/2.1. I guess
> you've been caretaking for 2.2/2.3 and would like to know if it's
> worth it? I guess the original author(s) are long gone.

 I've been keeping it compatible with ruleset format, almost nothing
more. I plan to continue that in any case - we don't have too many
different rulesets to use as testcases (not that I've been playing it
as human player, but crashing autogame is quite a good indication of
bug somewhere)

 I updated version available with TRUNK freeciv-modpack just today (r21666)

 What I would like to know if it's of any use to any player's in it's
current state. I'm worried that we may just waste people's time by
keeping it in such an high profile slot as in default modpack list so
people reasonably assume it to be worth testing.

> I don't know about the default modpack list, but it looks functional
> and even has its own tileset, which is more than most of the available
> modpacks. On the other hand, I haven't tried actually playing it to
> see if it still plays well.

 It actually had two tilesets, of which I've maintained only one
(enough for me, and I hoped to ampcients to blow both of these away
anyway). That easier to maintain one is based on trident (actually
uses trident, and adds just some units) and another one is isometric.

> If we are keeping it around, perhaps we should also rescue the
> Ampcients tileset (well, unit set) from
> 
> assuming the licensing works out (it's derived from Amplio which is
> GPL, so it's also GPL, right?) and turn it into a modpack download (or
> just include it with Ancients).

 No, unsolved licensing is the reason ampcients is not used. Last time
(years ago) I asked Daniel, he was trying to get contact to gfx
authors for licensing them under GPL.

 Ampcient is *not* Amplio derivative, rather its sibling. Both are
collected from gfx of Scenario League, with Amplio gfx succesfully
(re)licensed under GPL.

 (Ok, maybe Amcients is Amplio derivative in that it uses something
from Amplio, but then it's not legal one)


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

[Jacob Nevins]

Update of bug #20005 (project freeciv):

 Planned Release: => 2.4.0,2.5.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3470] Document use of --with-followtag in README.packaging

[Jacob Nevins]

Update of patch #3470 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-followtag-doc.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20014] References to metaserver.phtml

[Jacob Nevins]

Follow-up Comment #1, bug #20014 (project freeciv):

The metaserver.phtml URL is also going to persist in people's config files for
a long time, unless we do something special to rewrite it to the magic value
"default".

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20014] References to metaserver.phtml

[Jacob Nevins]

Update of bug #20014 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-metaserver-phtml-references.patch Size:2 KB
File name: S2_4-metaserver-phtml-references.patch Size:2 KB
File name: S2_3-metaserver-phtml-references.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3470] Document use of --with-followtag in README.packaging

[Jacob Nevins]

URL:
  

 Summary: Document use of --with-followtag in README.packaging
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed Aug  1 01:28:38 2012
Category: docs
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0,2.5.0

___

Details:

Attached patch describes the new version notification mechanism, and offers
the possibility to third parties.

I'm in two minds about this; the people who can update the metaserver are busy
enough as it is; but I want it written down somewhere in case e.g. a new Mac
volunteer comes out of the woodwork.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3462] Separate metaserver version tag for Windows installer builds

[Marko Lindqvist]

Follow-up Comment #2, patch #3462 (project freeciv):

I think single "win32" should mean latest stable release(1). If we had 2.4
releases following 2.4 specific tag, they would never inform users about 2.5
series existence.

I have added branch specific "S2_4" and "S2_5" tags to metaserver side, but I
don't plan to using them in any builds we do - they are just an option for
those people who make their own builds and want to follow specific branch (so
that if 2.5.0 is released before 2.4.3, 2.4.2 user will get notification about
2.4.3)

(1) Tag "win32" should inform users of stable releases about stable releases
only. But I still think we should use it for *2.4* betas. There's no earlier
users of the tag, so listing betas there would not inform any stable users,
only those of earlier 2.4 betas. So using it for betas would not only provide
beta testing for the feature, but also be service to users.


Have to think about the translation thing. I think it would be doable by
adding file containing string(s) that is used only as POTFILES.in source.
Presumably these strings need to qualified ones, so some code magic is needed
too. Ah, stuff for new ticket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20014] References to metaserver.phtml

[Jacob Nevins]

URL:
  

 Summary: References to metaserver.phtml
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed Aug  1 01:23:54 2012
Category: docs
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:

There are some references to metaserver.phtml in docs, etc.
As of patch #3453 we prefer .php suffix.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

[Marko Lindqvist]

Follow-up Comment #9, bug #20003 (project freeciv):

> (What seems odd is that the exploit seems to send many 0xff's,
> and I would have expected the opposite)

Problem is that in error situation - when there's no more data -
dio_get_uint8() returns 0, not 255. So if there's not enough data, it will try
to read it in infinite loop.

I see two possible ways to fix this. I have to investigate consequences to
other parts of the code more to decide better one.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3462] Separate metaserver version tag for Windows installer builds

[Jacob Nevins]

Follow-up Comment #1, patch #3462 (project freeciv):

Do we want a "win32-S2_4" tag for 2.4.0-betaX/rcX, rather than plain "win32"?

When 2.5.0-beta1 comes round, we presumably want all the 2.4.x Windows builds
to display the current stable Win32 release, not the betas. Is that what
"win32" will mean -- _stable_ win32 release?

(Also, I notice that the "There is no newer %s release of freeciv available"
is i18n'd, but the tag "stable" of course is not. Not sure we can reasonably
fix that, so perhaps need translators to add scare quotes '%s'.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17175] Tileset priority not respected

[Jacob Nevins]

Update of bug #17175 (project freeciv):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Same issue as bug #20008. Also the other one is the newer ticket, it has an
explanation, so I'll close this older one as a duplicate.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20008] Tileset priority not respected

[Jacob Nevins]

Follow-up Comment #2, bug #20008 (project freeciv):

See also bug #17175.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Ancients modpack (was: [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org)

[Jacob Nevins]

Marko Lindqvist writes:
> I actually would like to hear opinions about Ancients ruleset's
> status. Should it be in default modpack list?

I've been meaning to ask about that. READMEs that are around 

suggest that Daniel used to look after it around 2.0/2.1. I guess
you've been caretaking for 2.2/2.3 and would like to know if it's
worth it? I guess the original author(s) are long gone.

I don't know about the default modpack list, but it looks functional
and even has its own tileset, which is more than most of the available
modpacks. On the other hand, I haven't tried actually playing it to
see if it still plays well.

If we are keeping it around, perhaps we should also rescue the
Ampcients tileset (well, unit set) from

assuming the licensing works out (it's derived from Amplio which is
GPL, so it's also GPL, right?) and turn it into a modpack download (or
just include it with Ancients).
(It needs Amplio and we don't have dependencies for modpacks... yet...
but if we just make it download Amplio files to Amplio locations, you
should be able to install either or both of Amplio and Ampcients and
everything will probably Just Work with just one copy of the files on
the user's disc... right? Or we could just make it use Amplio2 tiles
which are guaranteed to be installed.)

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

[RafałMużyło]

Follow-up Comment #2, patch #3469 (project freeciv):

Thank you, but I'd rather not.

First of all, the list of deprecation warnings is a bit incomplete, as we're
targeting 3.4 and the list covers only 3.2 (due to a quirk of how are bounds
for those warnings defined).

Second, related to first, with gtk2 cleanup I was already planing to go grid
crazy and one of those missing warning sets regards GtkTable -> GtkGrid.

I'm already working on it, but there's quite a bit of it and I still haven't
decided just how grid-crazy should I go.

While I (most likely) won't be touching scrollbars, scales, etc. in a more
than trivial way, the boxes are a quite different matter.

I'll probably need an extra set of eyes or two for testing how the gui changes
look (margins, padding, etc.), though.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

[mir3x]

Follow-up Comment #1, patch #3469 (project freeciv):

I missed something before gdk_device_ungrab in 2 occurences.


(file #16255)
___

Additional Item Attachment:

File name: get_rid_gtk3_deprecated.patch.gz Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3456] Add language names list

[Marko Lindqvist]

Update of patch #3456 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

[mir3x]

URL:
  

 Summary: Get rid of most deprecated warning
 Project: Freeciv
Submitted by: mir3x
Submitted on: Wed 01 Aug 2012 12:22:57 AM CEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Changed to gtk3 functions all remaining except styles 
( it looks like some rc files are needed )

( network page looks strange now - I checked create_start_page function but
haven't figured why, there were only hboxes and vboxes changed,but correctly )



___

File Attachments:


---
Date: Wed 01 Aug 2012 12:22:57 AM CEST  Name: get_rid_gtk3_deprecated.patch.gz
 Size: 13kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org

[David Lowe]

On 2012 Jul 31, at 2:38 PM, Marko Lindqvist wrote:

> I actually would like to hear opinions about Ancients ruleset's status. Should
> it be in default modpack list?

In my extremely personal opinion, i didn't enjoy it when i tried.  Most 
likely it came down to the tech tree being so very different from what i'm used 
to.  In any case, the wiki mentions that it has no maintainer AND it still 
needs play testing and balancing.

sent from Lion

Mal: "Next time you want to stab me in the back, have the guts to do it to my 
face."
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20013] utility/support.c:688:7: warning: variable 'r' set but not used

[Marko Lindqvist]

URL:
  

 Summary: utility/support.c:688:7: warning: variable 'r' set
but not used
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 01 Aug 2012 01:21:27 AM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 2.3.3, 2.4.0, 2.5.0

___

Details:

Windows build warns:

../utility/support.c: In function 'fc_vsnprintf':
../utility/support.c:688:7: warning: variable 'r' set but not used
[-Wunused-but-set-variable]

Fix attached.



___

File Attachments:


---
Date: Wed 01 Aug 2012 01:21:27 AM EEST  Name: VsnprintfUnusedR.patch  Size:
967B   By: cazfi


---
Date: Wed 01 Aug 2012 01:21:27 AM EEST  Name: VsnprintfUnusedR-S2_3.patch 
Size: 949B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build

[Marko Lindqvist]

Update of patch #3468 (project freeciv):

 Planned Release: => 2.5.0  

___

Follow-up Comment #1:

I don't think anybody wants to fight warnings from lua-5.1 and friends when we
hopefully get lua-5.2 to use before 2.5 (another release goal?)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build

[Marko Lindqvist]

URL:
  

 Summary: Metaticket: Clang clean build
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 01 Aug 2012 12:59:27 AM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Clang warnings came too late to be considered for systematic fixing in S2_3.
However, getting all of them resolved should be release goal at some point. At
least for 2.5, 2.4 would be nice, but I don't want to add new goals this late
if they end postponing the release - I think that we should commit any fixes
to S2_4 too (those that turn out to be real bugs naturally even to S2_3) but
accept the fact if they are not all fixed by the time 2.4.0 is otherwise
ready.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org

[Marko Lindqvist]

Follow-up Comment #2, task #7606 (project freeciv):

modpack.list and .modpack files are already on modpack.freeciv.org, but latter
still point to actual files elsewhere. I hope to move those currently hosted
at cazfi.net to modpack.freeciv.org before beta1 - but that's not a blocker as
everything works, including the fact that .modpack file downloads can be seen
from modpack.freeciv.org logs. :-)

I've left Alien out from stable release modpack list. I don't think it's yet
ready for average user use. I'll keep it in third tier of modpacks once we
have forums back (1. Those included in freeciv proper, 2. Those in default
freeciv-modpack list. 3. Those for which freeciv-modpack URL is mentioned in
forums, wiki etc. 4. Those downloadable as .zip or tarball. 5. Those you have
to ask from the author)
Given that freeciv-modpack in 2.4 has option to select modpack list with "-L
http://www.cazfi.net/freeciv/modinst/2.4/modpack.list";, I'm probably going to
maintain alternative modpack list for those modpacks that do not make it to
default (every user's) list.

I actually would like to hear opinions about Ancients ruleset's status. Should
it be in default modpack list?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7606] Setup freeciv 2.4 files in modpack.freeciv.org

[Jacob Nevins]

Follow-up Comment #1, task #7606 (project freeciv):

Is there much to do here? I see Alien isn't on modpack.freeciv.org; anything
else?

(BTW, I changed the "version" of the 2.4 Amplio modpack on modpack.freeciv.org
from "2.3.99-alpha" to "2.4-svn", since it always points directly into the
latest version in svn, and is thus not usefully versioned. Hope that's OK.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3467] README.rulesets: Do not claim already lifted limitations to exist

[Marko Lindqvist]

URL:
  

 Summary: README.rulesets: Do not claim already lifted
limitations to exist
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 31 Jul 2012 10:33:29 PM EEST
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

As I noticed that README.rulesets still mentioned to old "No_Land_Attack" unit
type flag, my intention was simply to fix that. Attached patch also removes
claims of couple of limitations I know for sure to be lifted. I have not done
any investigative work for the rest though I suspect there would be more to
fix here.



___

File Attachments:


---
Date: Tue 31 Jul 2012 10:33:29 PM EEST  Name: DocumentLiftedLimits.patch 
Size: 2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17843] City radius effects work only with city size requirements

[Marko Lindqvist]

Follow-up Comment #10, bug #17843 (project freeciv):

> Did you test if the savegame still varies if you do a second
> load/save cycle?

It's not temporary difference at saving time - same autogame run 200 turns
longer with the patch.
Still, I don't think this is necessarily a bug. Since city gets refreshed more
frequently, other parts of the code will now use already refreshed city state
where old version relied in old city state to be "close enough"

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3466] Include direct.h to shared.c for _mkdir() for Windows builds

[Marko Lindqvist]

URL:
  

 Summary: Include direct.h to shared.c for _mkdir() for
Windows builds
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 31 Jul 2012 06:17:14 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.3, 2.4.0, 2.5.0

___

Details:

Windows compilation warns:

../utility/shared.c: In function 'make_dir':
../utility/shared.c:1769:5: warning: implicit declaration of function '_mkdir'
[-Wimplicit-function-declaration]
../utility/shared.c:1769:5: warning: nested extern declaration of '_mkdir'
[-Wnested-externs]

Including direct.h while compiling for Windows fixes this.



___

File Attachments:


---
Date: Tue 31 Jul 2012 06:17:14 PM EEST  Name: _MkdirHdr.patch  Size: 346B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3356] --enable-crosser

[Marko Lindqvist]

Update of patch #3356 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20003] Security advisory

[Patrick Welche]

Follow-up Comment #3, bug #20003 (project freeciv):

Thank you for your patch which fixes part A].

As to part B], it seems that the infinite loop comes from this part of
common/generate_packets.py:

   544  else:
   545  return '''
   546  for (;;) {
   547int i;
   548  
   549dio_get_uint8(&din, &i);
   550if(i == 255) {
   551  break;
   552}
   553if(i > %(array_size_u)s) {
   554  log_error("packets_gen.c: WARNING: ignoring intra array diff");
   555} else {
   556  %(c)s
   557}
   558  }'''%self.get_dict(vars())


The only way out of the for(;;) is if we manage to read 255.
(What seems odd is that the exploit seems to send many 0xff's, and I would
have expected the opposite)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3449] "Nation sets": initial cut-down implementation for 2.4.x

[Jacob Nevins]

Update of patch #3449 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #11:

Try declaring this done again...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20001] Some colours (e.g., border colours on map) are wrong

[Jacob Nevins]

Update of bug #20001 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev