Re: "There was an error displaying this diff"

2020-05-06 Thread Christian Hammond
Hi Illya,

Hmm, that's an interesting one. This is coming from within Python itself,
and I've never seen it before. It almost seems like it wasn't able to get a
file handle, or keep it open, for reading/writing.

I just checked online, and it looks to be a bug in Python 2.6, which is
horribly end-of-lifed (so is Python 2.7, but you can't run Review Board on
Python 3 *yet*):

https://access.redhat.com/errata/RHSA-2011:0027

"Prior to Python 2.7, programs that used "ulimit -n" to enable
communication with large numbers of subprocesses could still monitor only
1024 file descriptors at a time, which caused an exception: ValueError:
filedescriptor out of range in select()"

Review Board 2.5 is also end-of-life'd, by the way. I'd suggest moving to
Python 2.7 and Review Board 3.0.x, if possible. Review Board 3.0.x requires
Python 2.7.

Review Board 4 is entering beta soon, and will be compatible with Python
2.7 and 3.6+.

Christian

On Sun, May 3, 2020 at 10:15 AM Illya Broder  wrote:

> HI.
>
> I'm getting this error along with "filedescriptor out of range in select()
> "
>
> If I click on the "details" option it displays the following
>
> How do I solve this.
>
> Regards,
> Illya
>
> raceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/reviews/views.py",
>  line 179, in build_diff_comment_fragments
> comment.interfilediff)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 497, in get_last_line_number_in_diff
> f = get_file_from_filediff(context, filediff, interfilediff)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 481, in get_file_from_filediff
> request=request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 429, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 107, in get_chunks
> large_data=True)
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 295, in cache_memoize
> compress_large_data))
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 232, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 147, in patch
> stdout, stderr = p.communicate(diff)
>   File "/usr/lib64/python2.6/subprocess.py", line 691, in communicate
> return self._communicate(input)
>   File "/usr/lib64/python2.6/subprocess.py", line 1211, in _communicate
> rlist, wlist, xlist = select.select(read_set, write_set, [])
> ValueError: filedescriptor out of range in select(
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/46025f9b-e476-4c9d-9fd2-0b1458c8ed8e%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review 

"There was an error displaying this diff"

2020-05-03 Thread Illya Broder
HI.

I'm getting this error along with "filedescriptor out of range in select()"

If I click on the "details" option it displays the following 

How do I solve this.

Regards,
Illya

raceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/reviews/views.py",
 line 179, in build_diff_comment_fragments
comment.interfilediff)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 497, in get_last_line_number_in_diff
f = get_file_from_filediff(context, filediff, interfilediff)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 481, in get_file_from_filediff
request=request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 429, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 107, in get_chunks
large_data=True)
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
 line 295, in cache_memoize
compress_large_data))
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
 line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
 line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 232, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 147, in patch
stdout, stderr = p.communicate(diff)
  File "/usr/lib64/python2.6/subprocess.py", line 691, in communicate
return self._communicate(input)
  File "/usr/lib64/python2.6/subprocess.py", line 1211, in _communicate
rlist, wlist, xlist = select.select(read_set, write_set, [])
ValueError: filedescriptor out of range in select(

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/46025f9b-e476-4c9d-9fd2-0b1458c8ed8e%40googlegroups.com.


Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

2019-10-07 Thread Adam Myers
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

So just to reiterate, the problem appears to be, RB is not fetching the 
left-hand-side file contents correctly.

RB *should be able* to fetch the left-hand-side file contents correctly. 
The files were deleted in SVN and don't exist at HEAD revision, but they do 
exist at the revision specified in the patch file.

E.g.:
```
$ svn cat $NETREPO/espresso/trunk/product-spec.json
svn: warning: W160013: File not found: revision 1887978, path 
'/espresso/trunk/product-spec.json'
svn: E29: Could not cat all targets because some targets don't exist
svn: E29: Illegal target for the requested operation

# If I download the diff from the RB, the 1st line for each file-entry 
reads like:
#"--- espresso/trunk/product-spec.json  (revision 1695130)"
# ... which tells me the left-hand-side file contents should be fetched 
from revision 1695130
$ svn cat $NETREPO/espresso/trunk/product-spec.json@1695130 | tail -5
"databases": {},
"repo_name": "DDS"
  },
  "description": "Elastic, Scalable, Performant, Reliable, Extensible, 
Stable, Speedy, and Operational"
}
```
As you can see, it *is* possible to fetch the correct left-hand-side file 
contents, given the correct revision, but for whatever reason reviewboard 
doesn't seem to be doing that - it is failing out due to the fact that the 
files no longer exist at the specified location.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20191007234208.18042.89425%40ip-10-1-54-209.ec2.internal.


Re: "There was an error displaying this diff" when diffing a file that contains a "#" in the filename.

2019-08-27 Thread Rob Petti
Hey Folks,

I've managed to narrow it down some more. It appears to be a problem in 
scmtools/svn/pysvn.py.

def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
# path == 
"src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws"
normpath = self.normalize_path(path)
# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws;

# SVN expects to have URLs escaped. Take care to only
# escape the path part of the URL.
if self.client.is_url(normpath):
pathtuple = urlsplit(normpath)
path = pathtuple[2]
if isinstance(path, six.text_type):
path = path.encode('utf-8', 'ignore')
normpath = urlunsplit((pathtuple[0],
   pathtuple[1],
   quote(path),
   '', ''))

# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase;
normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


As you can see, it combines the path naively into a URL without escaping 
any characters, then tries to parse it as a URL to URL-escape the path 
portion of it, which obviously won't work.

I was able to fix my problem by changing the code as below. It didn't make 
any sense to me that it would parse it as a URL before escaping it, so I 
removed that whole section of the code and just encoded the file path 
before normalizing it.
def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
normpath = self.normalize_path(quote(path.encode('utf-8', 
'ignore')))

normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


If this makes sense, should I open a review with my proposed changes?

On Thursday, 22 August 2019 13:34:16 UTC-6, Rob Petti wrote:
>
> Hi Folks,
>
> We're having an issue with one of our SVN repositories right now. It 
> appears almost as if ReviewBoard can't handle files that contain "#" in 
> their names. I've attached a screenshot of the error. Of particular note is 
> that the error seems to suggest that it's truncating the filename from '#' 
> and erroneously trying to use that to locate the file in the repository.
>
> Would anyone know how to overcome this problem? Obviously we could work 
> around it by changing the file names, but this is a naming convention 
> that's required by our product and cannot be changed.
>
> Thanks!
> ~Rob
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/533d838b-61ab-4263-a1c6-2dbd3a0b61e7%40googlegroups.com.


"There was an error displaying this diff" when diffing a file that contains a "#" in the filename.

2019-08-22 Thread Rob Petti
Hi Folks,

We're having an issue with one of our SVN repositories right now. It 
appears almost as if ReviewBoard can't handle files that contain "#" in 
their names. I've attached a screenshot of the error. Of particular note is 
that the error seems to suggest that it's truncating the filename from '#' 
and erroneously trying to use that to locate the file in the repository.

Would anyone know how to overcome this problem? Obviously we could work 
around it by changing the file names, but this is a naming convention 
that's required by our product and cannot be changed.

Thanks!
~Rob

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/9c1c7ba7-0581-4bd2-98b0-d6d584241c7f%40googlegroups.com.


Re: There was an error displaying this diff.

2019-07-25 Thread David Trowbridge
Bitbucket recently turned off a bunch of old APIs without any notice,
including one that Review Board used. We put out an update that fixes this
in Review Board 3.0.15:
https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0.15/

David

On Thu, Jul 25, 2019 at 8:47 AM Birendra Rawat 
wrote:

> Resource removed
>
> This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.
>
> Please try again, and if you still have trouble, contact support.
>
> Details
>
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/views.py",
> line 300, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",
> line 669, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 786, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 792, in get_chunks_uncached
> self.encoding_list)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",
> line 199, in get_original_file
> request=request)
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 362, in get_file
> large_data=True)[0]
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 361, in 
> request)],
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 543, in _get_file_uncached
> base_commit_id=base_commit_id)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 306, in get_file
> base_commit_id)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 608, in _api_get_src
> return self._api_get(url, raw_content=True)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 687, in _api_get
> self._check_api_error(e)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 724, in _check_api_error
> rsp=e)
> HostingServiceAPIError: Resource removed
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> 

There was an error displaying this diff.

2019-07-25 Thread Birendra Rawat
Resource removed

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

Please try again, and if you still have trouble, contact support.

Details

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/views.py", 
line 300, in get
response = renderer.render_to_response(request)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", 
line 74, in render_to_string
large_data=True)
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
298, in cache_memoize
compress_large_data))
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
252, in cache_memoize_iter
items = items_or_callable()
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
295, in 
lambda: [lookup_callable()],
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py", 
line 669, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", 
line 786, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", 
line 107, in get_chunks
large_data=True)
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
298, in cache_memoize
compress_large_data))
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
252, in cache_memoize_iter
items = items_or_callable()
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
295, in 
lambda: [lookup_callable()],
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", 
line 792, in get_chunks_uncached
self.encoding_list)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py", 
line 199, in get_original_file
request=request)
  File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", 
line 362, in get_file
large_data=True)[0]
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
298, in cache_memoize
compress_large_data))
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
252, in cache_memoize_iter
items = items_or_callable()
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 
295, in 
lambda: [lookup_callable()],
  File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", 
line 361, in 
request)],
  File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", 
line 543, in _get_file_uncached
base_commit_id=base_commit_id)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py", 
line 306, in get_file
base_commit_id)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py", 
line 608, in _api_get_src
return self._api_get(url, raw_content=True)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py", 
line 687, in _api_get
self._check_api_error(e)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py", 
line 724, in _check_api_error
rsp=e)
HostingServiceAPIError: Resource removed

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/bba923f2-12a6-4af7-a36f-7c997791e795%40googlegroups.com.


Re: There was an error displaying this diff.

2019-05-08 Thread Thomas McLeod
Ok, so apparently I have to give the full path of each file that I want to
include in the diff, is that correct? How do I ignore whitespace in the
diff?
T McLeod

On Tue, May 7, 2019 at 5:45 PM Thomas McLeod  wrote:

> I created the diff. I can't get rbtools to create a diff between two
> revisions AND limit the review files. When I tell I give git hashes rbt
> post always creates a diff for the entire repository, though I want to
> review only a small part of it. Furthermore rbt post always creates diffs
> with significant white space. this occurs even though the debug output
> shows the correct git command with a file spec following "--".
>
> Thomas McLeod
>
>
> On Tue, May 7, 2019 at 5:38 PM David Trowbridge 
> wrote:
>
>> What is "review_diff.diff" and how did you create it? Is there a reason
>> why you're creating the diff beforehand instead of just letting rbtools
>> make the diff between the specified revisions?
>>
>> -David
>>
>> On Tue, May 7, 2019 at 2:34 PM  wrote:
>>
>>> I'm just trying to post a diff to a review. But the error I get is
>>>
>>>
>>>  There was an error displaying this diff.
>>>  The patch to ' didn't apply cleanly. The temporary files have
>>> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
>>> `patch` returned:
>>>
>>>  This may be a bug in the software, a temporary outage, or an issue
>>>  with the format of your diff.
>>>
>>>  Please try again, and if you still have trouble,
>>>  contact support.
>>>
>>>
>>> Kinda disappointing
>>>
>>>
>>> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
>>> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
>>> 1.0.2
>>> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
>>> [GCC 5.4.0 20160609]
>>> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
>>> >>> Home = /home/tmcleod
>>> >>> Current directory =
>>> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
>>> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
>>> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
>>> >>> Running: tf vc help
>>> >>> Checking for a Git repository...
>>> >>> Running: git rev-parse --git-dir
>>> >>> Running: git config core.bare
>>> >>> Running: git rev-parse --show-toplevel
>>> >>> Running: git symbolic-ref -q HEAD
>>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
>>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
>>> >>> Running: git config --get remote.origin.url
>>> >>> Repository info: Path: , Base path: , Supports changesets:
>>> False
>>> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
>>> modified
>>> >>> Making HTTP POST request to
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>>> expired and was not modified
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>>> expired and was modified
>>> >>> Making HTTP POST request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>>> expired and was not modified

Re: There was an error displaying this diff.

2019-05-07 Thread Thomas McLeod
I created the diff. I can't get rbtools to create a diff between two
revisions AND limit the review files. When I tell I give git hashes rbt
post always creates a diff for the entire repository, though I want to
review only a small part of it. Furthermore rbt post always creates diffs
with significant white space. this occurs even though the debug output
shows the correct git command with a file spec following "--".

Thomas McLeod


On Tue, May 7, 2019 at 5:38 PM David Trowbridge  wrote:

> What is "review_diff.diff" and how did you create it? Is there a reason
> why you're creating the diff beforehand instead of just letting rbtools
> make the diff between the specified revisions?
>
> -David
>
> On Tue, May 7, 2019 at 2:34 PM  wrote:
>
>> I'm just trying to post a diff to a review. But the error I get is
>>
>>
>>  There was an error displaying this diff.
>>  The patch to ' didn't apply cleanly. The temporary files have
>> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
>> `patch` returned:
>>
>>  This may be a bug in the software, a temporary outage, or an issue
>>  with the format of your diff.
>>
>>  Please try again, and if you still have trouble,
>>  contact support.
>>
>>
>> Kinda disappointing
>>
>>
>> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
>> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
>> 1.0.2
>> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
>> [GCC 5.4.0 20160609]
>> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
>> >>> Home = /home/tmcleod
>> >>> Current directory =
>> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
>> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
>> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
>> >>> Running: tf vc help
>> >>> Checking for a Git repository...
>> >>> Running: git rev-parse --git-dir
>> >>> Running: git config core.bare
>> >>> Running: git rev-parse --show-toplevel
>> >>> Running: git symbolic-ref -q HEAD
>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
>> >>> Running: git config --get remote.origin.url
>> >>> Repository info: Path: , Base path: , Supports changesets:
>> False
>> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
>> modified
>> >>> Making HTTP POST request to
>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>> expired and was not modified
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>> expired and was modified
>> >>> Making HTTP POST request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>> expired and was not modified
>> Review request #1382 posted.
>>
>> https://reviews.s2sys.com/reviews/r/1382/
>> https://reviews.s2sys.com/reviews/r/1382/diff/
>>
>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review B

Re: There was an error displaying this diff.

2019-05-07 Thread David Trowbridge
What is "review_diff.diff" and how did you create it? Is there a reason why
you're creating the diff beforehand instead of just letting rbtools make
the diff between the specified revisions?

-David

On Tue, May 7, 2019 at 2:34 PM  wrote:

> I'm just trying to post a diff to a review. But the error I get is
>
>
>      There was an error displaying this diff.
>  The patch to ' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
> `patch` returned:
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
>
> Kinda disappointing
>
>
> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
> 1.0.2
> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
> [GCC 5.4.0 20160609]
> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
> >>> Home = /home/tmcleod
> >>> Current directory =
> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
> >>> Running: tf vc help
> >>> Checking for a Git repository...
> >>> Running: git rev-parse --git-dir
> >>> Running: git config core.bare
> >>> Running: git rev-parse --show-toplevel
> >>> Running: git symbolic-ref -q HEAD
> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
> >>> Running: git config --get remote.origin.url
> >>> Repository info: Path: , Base path: , Supports changesets:
> False
> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/validation/diffs/
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
> modified
> >>> Making HTTP POST request to
> https://reviews.s2sys.com/reviews/api/validation/diffs/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
> expired and was not modified
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
> expired and was modified
> >>> Making HTTP POST request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
> expired and was not modified
> Review request #1382 posted.
>
> https://reviews.s2sys.com/reviews/r/1382/
> https://reviews.s2sys.com/reviews/r/1382/diff/
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com
> <https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com?utm_medium=email_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAFS3VNU%2BQ25B%3DWokdeFQDw%3Do0yjiD_Ku3m0bQ9UiM%3DvZ4excoA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


There was an error displaying this diff.

2019-05-07 Thread tmcleod
I'm just trying to post a diff to a review. But the error I get is 


 There was an error displaying this diff.
 The patch to ' didn't apply cleanly. The temporary files have 
been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
`patch` returned: 

 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.

 Please try again, and if you still have trouble,
 contact support.


Kinda disappointing


$ rbt post -r=1382 --submit-as=tmcleod --diff-only 
--diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools 
1.0.2
>>> Python 2.7.12 (default, Nov 12 2018, 14:36:49) 
[GCC 5.4.0 20160609]
>>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/tmcleod
>>> Current directory = 
/home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
>>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only 
--diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
>>> Running: tf vc help
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
>>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
>>> Running: git config --get remote.origin.url
>>> Repository info: Path: , Base path: , Supports changesets: 
False
>>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
>>> Making HTTP GET request to 
https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> Cached response for HTTP GET 
https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was 
modified
>>> Making HTTP POST request to 
https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> Making HTTP GET request to 
https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>>> Cached response for HTTP GET 
https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
 
expired and was not modified
>>> Making HTTP GET request to 
https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>>> Cached response for HTTP GET 
https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields= 
expired and was modified
>>> Making HTTP POST request to 
https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
>>> Making HTTP GET request to 
https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>>> Cached response for HTTP GET 
https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
 
expired and was not modified
Review request #1382 posted.

https://reviews.s2sys.com/reviews/r/1382/
https://reviews.s2sys.com/reviews/r/1382/diff/



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

2019-02-25 Thread Adam Myers
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

We use an in-house product which runs RBTools "under the hood".

It looks like SVN recognizes the base revision - see attached screenshot.


Files:
- Screenshot from 2019-02-25 16-05-07.png
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

2019-02-22 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

How's the diff being generated? Is this `svn diff`, RBTools, or an in-house 
product?


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

2019-02-22 Thread Adam Myers
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New ticket #4798 by a-dogg
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
"There was an error displaying this diff." for any SVN file that no longer 
exists at its former location
==

# What version are you running?
3.0.5

# What's the URL of the page containing the problem?
https://rb.corp.linkedin.com/r/1197363/diff/3/

# What steps will reproduce the problem?
1. Create a review-request for an SVN repository
2. Move or delete one or more of the files that were in the diff, in the SVN 
repository

# What is the expected output? What do you see instead?
Expect to see a diff rendered.
Instead:
```
   There was an error displaying this diff.
  
  The file '("'", ...)' could not be found in the repository

   This may be a bug in the software, a temporary outage, or an issue
   with the format of your diff.

   Please try again, and if you still have trouble,
   contact support.
```

# What operating system are you using? What browser?
N/A

# Please provide any additional information below.
The folder exists at the revision specified in the diff, as seen in `$ svn ls 
-r${REVISION}` output.

Also `svn cat ${PATH}@${REVISION}` outputs the file contents.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff.

2018-08-01 Thread huangminzh
Hi Michal,

Did you fix this issue? I came across the same problem.

Thanks,
Min

On Tuesday, July 31, 2018 at 1:19:47 AM UTC-7, Michał Pieniak wrote:
>
> Christian,
>
> Thanks for response.
>
> I removed original post because of the naming our projects and renamed it:
>
> *"Hello,*
>
> *I have a problem with my RB diff. *
>
> *The patch to '...' didn't apply cleanly. The temporary files have 
> been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
> *`patch` returned: *
>
> 
>
> * This may be a bug in the software, a temporary outage, or an issue*
> * with the format of your diff.*
>
> 
> 
>
>
> * Please try again, and if you still have trouble*
>
>
> *Traceback (most recent call last):*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
>  
> line 299, in get*
> *response = renderer.render_to_response(request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response*
> *return HttpResponse(self.render_to_string(request))*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string*
> *large_data=True)*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 295, in cache_memoize*
> *compress_large_data))*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 249, in cache_memoize_iter*
> *items = items_or_callable()*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 292, in *
> *lambda: [lookup_callable()],*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 73, in *
> *lambda: self.render_to_string_uncached(request),*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 87, in render_to_string_uncached*
> *request=request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 667, in populate_diff_chunks*
> *chunks = list(generator.get_chunks())*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 756, in get_chunks*
> *for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 107, in get_chunks*
> *large_data=True)*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 295, in cache_memoize*
> *compress_large_data))*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 249, in cache_memoize_iter*
> *items = items_or_callable()*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 292, in *
> *lambda: [lookup_callable()],*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 106, in *
> *lambda: list(self.get_chunks_uncached()),*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 763, in get_chunks_uncached*
> *new = get_patched_file(old, self.filediff, self.request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 233, in get_patched_file*
> *return patch(diff, buffer, filediff.dest_file, request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 169, in patch*
> *'output': stderr,*
> *Exception: The patch to '.' didn't apply cleanly. The temporary 
> files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
> *`patch` returned: *
>
> *Its happen only for 1 revision. When i move to revision number of 2 
> problem does not exist."*
>
>
> Returning to our topic we will try check to our Unicode BOM on the 
> perforce and upgrade our RB version to latest. I will let you know.
>
> Thanks a lot !
> Michal
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff.

2018-07-31 Thread Michał Pieniak
Christian,

Thanks for response.

I removed original post because of the naming our projects and renamed it:

*"Hello,*

*I have a problem with my RB diff. *

*The patch to '...' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *



* This may be a bug in the software, a temporary outage, or an issue*
* with the format of your diff.*





* Please try again, and if you still have trouble*


*Traceback (most recent call last):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get*
*response = renderer.render_to_response(request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response*
*return HttpResponse(self.render_to_string(request))*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in *
*lambda: self.render_to_string_uncached(request),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached*
*request=request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks*
*chunks = list(generator.get_chunks())*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks*
*for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in *
*lambda: list(self.get_chunks_uncached()),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached*
*new = get_patched_file(old, self.filediff, self.request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file*
*return patch(diff, buffer, filediff.dest_file, request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch*
*'output': stderr,*
*Exception: The patch to '.' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *

*Its happen only for 1 revision. When i move to revision number of 2 
problem does not exist."*


Returning to our topic we will try check to our Unicode BOM on the perforce 
and upgrade our RB version to latest. I will let you know.

Thanks a lot !
Michal

-- 





--

The contents of this e-mail and any attachments hereto
are intended solely 
for the person or entity to which they are addressed to and
contain the 
sender's confidential information, and/or legally privileged
information. 
Any disclosure, dissemination, copying, printing and forwarding to

unauthorized persons or other misuse of this e-mail which is not compliant 
with
its purpose is prohibited and may be against the law. If you have 
received this
e-mail by accident, please immediately contact the sender and 
delete the message
in its entirety.

--

Treść tej wiadomości wraz z załącznikami jest przeznaczona wyłącznie dla

jej adresata i zawiera poufne informacje nadawcy i/lub informacje prawnie

chronione. Udostępnianie, rozpowszechnianie, kopiowanie i 

Re: There was an error displaying this diff.

2018-07-31 Thread Michał Pieniak
Christian,

Thanks for response.

I removed original post because of the naming our projects and renamed it:

*"Hello,*

*I have a problem with my RB diff. *

*The patch to '...' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *



* This may be a bug in the software, a temporary outage, or an issue*
* with the format of your diff.*





* Please try again, and if you still have trouble*


*Traceback (most recent call last):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get*
*response = renderer.render_to_response(request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response*
*return HttpResponse(self.render_to_string(request))*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in *
*lambda: self.render_to_string_uncached(request),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached*
*request=request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks*
*chunks = list(generator.get_chunks())*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks*
*for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in *
*lambda: list(self.get_chunks_uncached()),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached*
*new = get_patched_file(old, self.filediff, self.request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file*
*return patch(diff, buffer, filediff.dest_file, request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch*
*'output': stderr,*
*Exception: The patch to '.' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *

*Its happen only for 1 revision. When i move to revision number of 2 
problem does not exist."*


Returning to our topic we will try check to our Unicode BOM on the perforce 
and upgrade our RB version to latest. I will let you know.

Thanks a lot !
Michal

W dniu poniedziałek, 30 lipca 2018 22:25:53 UTC+2 użytkownik Christian 
Hammond napisał:
>
> Is this a Perforce repository?
>
> I'd need to see the actual source code and reject files to know more 
> (which I'm sure can't be made public), but any number of things could have 
> caused that. If this is a Perforce repository, you might have hit an issue 
> with a conflict involving a Unicode BOM marker in the file. Perforce went 
> through a series of regressions at one point involving these markers, and 
> depending on the versions of p4d and p4python and the metadata state of the 
> file, you could hit this scenario. We'd done work in more recent versions 
> in the 3.0.x releases to try to work around this better.
>
> Christian
>
> On Mon, Jul 30, 2018 at 8:43 AM Michał Pieniak  > wrote:
>
>> Hello,
>>
>> I have a problem with my RB diff. 
>>
>> The patch to 
>> 

Re: There was an error displaying this diff.

2018-07-30 Thread Christian Hammond
Is this a Perforce repository?

I'd need to see the actual source code and reject files to know more (which
I'm sure can't be made public), but any number of things could have caused
that. If this is a Perforce repository, you might have hit an issue with a
conflict involving a Unicode BOM marker in the file. Perforce went through
a series of regressions at one point involving these markers, and depending
on the versions of p4d and p4python and the metadata state of the file, you
could hit this scenario. We'd done work in more recent versions in the
3.0.x releases to try to work around this better.

Christian

On Mon, Jul 30, 2018 at 8:43 AM Michał Pieniak 
wrote:

> Hello,
>
> I have a problem with my RB diff.
>
> The patch to
> '//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.4L2LuH' for debugging purposes.
> `patch` returned:
>
>
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>
>
>
>
>  Please try again, and if you still have trouble
>
>
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
> line 299, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 667, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 233, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 169, in patch
> 'output': stderr,
> Exception: The patch to
> '//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.4L2LuH' for debugging purposes.
> `patch` returned:
>
> Its happen only for 1 revision. When i move to revision number of 2
> problem does not exist.
>
>
> 
>
>
>
> What is that mean?
>
> Thanks
> Michał
>
> --
>
> 
> --
> The contents of this e-mail and any 

There was an error displaying this diff.

2018-07-30 Thread Michał Pieniak
Hello,

I have a problem with my RB diff. 

The patch to 
'//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
 
didn't apply cleanly. The temporary files have been left in 
'/tmp/reviewboard.4L2LuH' for debugging purposes.
`patch` returned: 



 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.





 Please try again, and if you still have trouble


Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get
response = renderer.render_to_response(request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize
compress_large_data))
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter
items = items_or_callable()
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize
compress_large_data))
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter
items = items_or_callable()
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch
'output': stderr,
Exception: The patch to 
'//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
 
didn't apply cleanly. The temporary files have been left in 
'/tmp/reviewboard.4L2LuH' for debugging purposes.
`patch` returned: 

Its happen only for 1 revision. When i move to revision number of 2 problem 
does not exist.





What is that mean?

Thanks
Michał

-- 





--

The contents of this e-mail and any attachments hereto
are intended solely 
for the person or entity to which they are addressed to and
contain the 
sender's confidential information, and/or legally privileged
information. 
Any disclosure, dissemination, copying, printing and forwarding to

unauthorized persons or other misuse of this e-mail which is not compliant 
with
its purpose is prohibited and may be against the law. If you have 
received this
e-mail by accident, please immediately contact the sender and 
delete the message
in its entirety.

--

Treść tej wiadomości wraz z załącznikami jest przeznaczona wyłącznie dla

jej adresata i zawiera poufne informacje nadawcy i/lub informacje prawnie

chronione. Udostępnianie, rozpowszechnianie, kopiowanie i przekazywanie 
osobom nieupoważnionym,
a 

Re: There was an error displaying this diff

2018-01-23 Thread David Trowbridge
Power Pack is supported on Review Board 2.0+, though we of course recommend
updating if you can. There should be no specific RBTools requirements,
assuming you're on a relatively modern version (0.7.x).

If you e-mail us at supp...@beanbaginc.com, I can get you set up with a
beta build. You'll want to request a trial key at
https://www.reviewboard.org/powerpack/trial/

-David

On Wed, Jan 10, 2018 at 7:43 AM  wrote:

> Hi,
> That sounds interesting.
> Are there any version requirements for RBTools or Reviewboard?
>
> On Monday, January 8, 2018 at 9:16:28 PM UTC+2, David Trowbridge wrote:
>
>> Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're
>> actively working on adding support in Power Pack. If you'd like to help us
>> test it out, I can get you a beta build.
>>
>> -David
>>
>> On Mon, Jan 8, 2018 at 8:29 AM  wrote:
>>
> Hello,
>>>
>>> I'm trying to post review from our hosted Bitbucket, to hosted
>>> Reviewboard using the RBTools.
>>> The Reviewboard version is 2.0.11
>>> The RBTools version is 0.7.2
>>> It seems to have some issue with the diff of the files but I can't
>>> figure out what it is.
>>> Is there any place I can check the reason of the failure?
>>>
>>> I configured a new repository in reviewboard as a custom git repository
>>> with a matching raw url mask.
>>>
>>> I use the following command to send the review:
>>>
>>> */usr/local/bin/rbt post -d -p --repository-type git --server
>>> http://rb.server.com  --repository my-test-repo
>>> --username post-commit-user --password  post-commit-user --tracking-branch
>>> origin/master --submit-as myuser --guess-summary --guess-description
>>> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>>>
>>> And I'm getting a msg that the review was posted.
>>> The STDERR is:
>>> * RBTools 0.7.2*
>>> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
>>> *[GCC 4.8.4]*
>>> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
>>> *>>> Home = /my_home*
>>> *>>> Current directory = /my_home/shared/data/repositories/902*
>>> *>>> Checking for a Git repository...*
>>> *>>> Running: git rev-parse --git-dir*
>>> *>>> Running: git config core.bare*
>>> *>>> Running: git symbolic-ref -q HEAD*
>>> *>>> Running: git config --get branch.master.merge*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> u'branch.master.merge']*
>>> *---*
>>> *>>> Running: git config --get branch.master.remote*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> u'branch.master.remote']*
>>> *---*
>>> *>>> Running: git config --get remote.origin.url*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> 'remote.origin.url']*
>>> *---*
>>> *>>> Running: git config --get remote.origin.url*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> 'remote.origin.url']*
>>> *---*
>>> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base
>>> path: , Supports changesets: False*
>>> *>>> Making HTTP GET request to http://rb.server.com/api/
>>> *
>>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
>>> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
>>> master*
>>> *>>> Running: git rev-parse --git-dir*
>>> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff
>>> --no-color --full-index --ignore-submodules -M --no-ext-diff
>>> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Running: git log --reverse --pretty=format:%s%n%n%b
>>> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
>>> c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Making HTTP GET request to
>>> http://rb.server.com/api/review-requests/?only-links=create=
>>> *
>>> *>>> Making HTTP POST request to http://rb
>>> . server.com/api/review-requests/
>>> *
>>> *>>> Making HTTP GET request to http://rb
>>> . server.com/api/review-requests/304341/diffs/?only-fields=
>>> *
>>> *>>> Making HTTP POST request to http://rb
>>> . server.com/api/review-requests/304341/diffs/
>>> *
>>> *>>> Making HTTP GET request to http://rb
>>> . 
>>> server.com/api/review-requests/304341/draft/?only-fields=commit_id
>>> *
>>> *>>> Making HTTP PUT request to http://rb
>>> . server.com/api/review-requests/304341/draft/
>>> *
>>>
>>> The diff in the review showing the following:
>>> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files
>>> have been left in 

Re: There was an error displaying this diff

2018-01-09 Thread akarasik
Hi,
That sounds interesting.
Are there any version requirements for RBTools or Reviewboard?

On Monday, January 8, 2018 at 9:16:28 PM UTC+2, David Trowbridge wrote:
>
> Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're 
> actively working on adding support in Power Pack. If you'd like to help us 
> test it out, I can get you a beta build.
>
> -David
>
> On Mon, Jan 8, 2018 at 8:29 AM  wrote:
>
>> Hello,
>>
>> I'm trying to post review from our hosted Bitbucket, to hosted 
>> Reviewboard using the RBTools.
>> The Reviewboard version is 2.0.11
>> The RBTools version is 0.7.2
>> It seems to have some issue with the diff of the files but I can't figure 
>> out what it is.
>> Is there any place I can check the reason of the failure?
>>
>> I configured a new repository in reviewboard as a custom git repository 
>> with a matching raw url mask.
>>
>> I use the following command to send the review:
>>
>> */usr/local/bin/rbt post -d -p --repository-type git --server 
>> http://rb.server.com  --repository my-test-repo 
>> --username post-commit-user --password  post-commit-user --tracking-branch 
>> origin/master --submit-as myuser --guess-summary --guess-description 
>> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>>
>> And I'm getting a msg that the review was posted.
>> The STDERR is:
>> * RBTools 0.7.2*
>> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
>> *[GCC 4.8.4]*
>> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
>> *>>> Home = /my_home*
>> *>>> Current directory = /my_home/shared/data/repositories/902*
>> *>>> Checking for a Git repository...*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git config core.bare*
>> *>>> Running: git symbolic-ref -q HEAD*
>> *>>> Running: git config --get branch.master.merge*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.merge']*
>> *---*
>> *>>> Running: git config --get branch.master.remote*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.remote']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base 
>> path: , Supports changesets: False*
>> *>>> Making HTTP GET request to http://rb.server.com/api/ 
>> *
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
>> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> master*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
>> --no-color --full-index --ignore-submodules -M --no-ext-diff 
>> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git log --reverse --pretty=format:%s%n%n%b 
>> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Making HTTP GET request to 
>> http://rb.server.com/api/review-requests/?only-links=create= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . server.com/api/review-requests/304341/diffs/?only-fields= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/304341/diffs/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . 
>> server.com/api/review-requests/304341/draft/?only-fields=commit_id 
>> *
>> *>>> Making HTTP PUT request to http://rb 
>> . server.com/api/review-requests/304341/draft/ 
>> *
>>
>> The diff in the review showing the following:
>> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files 
>> have been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
>> *`patch` returned: *
>> *This may be a bug in the software, a temporary outage, or an issue with 
>> the format of your diff.*
>>
>> And the tmp folder contains following files:
>>
>> *testfile.sh.diff*
>> *diff --git a/testfile.sh b/testfile.sh*
>> *index 
>> 083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
>>  
>> 100644*
>> *--- a/testfile.sh*
>> *+++ b/testfile.sh*
>> *@@ -1,4 +1,3 @@*
>> * #!/bin/bash*
>>
>> * echo "test"*
>> 

Re: There was an error displaying this diff

2018-01-08 Thread David Trowbridge
Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're
actively working on adding support in Power Pack. If you'd like to help us
test it out, I can get you a beta build.

-David

On Mon, Jan 8, 2018 at 8:29 AM  wrote:

> Hello,
>
> I'm trying to post review from our hosted Bitbucket, to hosted Reviewboard
> using the RBTools.
> The Reviewboard version is 2.0.11
> The RBTools version is 0.7.2
> It seems to have some issue with the diff of the files but I can't figure
> out what it is.
> Is there any place I can check the reason of the failure?
>
> I configured a new repository in reviewboard as a custom git repository
> with a matching raw url mask.
>
> I use the following command to send the review:
>
> */usr/local/bin/rbt post -d -p --repository-type git --server
> http://rb.server.com  --repository my-test-repo
> --username post-commit-user --password  post-commit-user --tracking-branch
> origin/master --submit-as myuser --guess-summary --guess-description
> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>
> And I'm getting a msg that the review was posted.
> The STDERR is:
> * RBTools 0.7.2*
> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
> *[GCC 4.8.4]*
> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
> *>>> Home = /my_home*
> *>>> Current directory = /my_home/shared/data/repositories/902*
> *>>> Checking for a Git repository...*
> *>>> Running: git rev-parse --git-dir*
> *>>> Running: git config core.bare*
> *>>> Running: git symbolic-ref -q HEAD*
> *>>> Running: git config --get branch.master.merge*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.merge']*
> *---*
> *>>> Running: git config --get branch.master.remote*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.remote']*
> *---*
> *>>> Running: git config --get remote.origin.url*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> 'remote.origin.url']*
> *---*
> *>>> Running: git config --get remote.origin.url*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> 'remote.origin.url']*
> *---*
> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base
> path: , Supports changesets: False*
> *>>> Making HTTP GET request to http://rb.server.com/api/
> *
> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
> master*
> *>>> Running: git rev-parse --git-dir*
> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff
> --no-color --full-index --ignore-submodules -M --no-ext-diff
> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Running: git log --reverse --pretty=format:%s%n%n%b
> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
> c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Making HTTP GET request to
> http://rb.server.com/api/review-requests/?only-links=create=
> *
> *>>> Making HTTP POST request to http://rb
> . server.com/api/review-requests/
> *
> *>>> Making HTTP GET request to http://rb
> . server.com/api/review-requests/304341/diffs/?only-fields=
> *
> *>>> Making HTTP POST request to http://rb
> . server.com/api/review-requests/304341/diffs/
> *
> *>>> Making HTTP GET request to http://rb
> . 
> server.com/api/review-requests/304341/draft/?only-fields=commit_id
> *
> *>>> Making HTTP PUT request to http://rb
> . server.com/api/review-requests/304341/draft/
> *
>
> The diff in the review showing the following:
> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
> *`patch` returned: *
> *This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.*
>
> And the tmp folder contains following files:
>
> *testfile.sh.diff*
> *diff --git a/testfile.sh b/testfile.sh*
> *index
> 083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
> 100644*
> *--- a/testfile.sh*
> *+++ b/testfile.sh*
> *@@ -1,4 +1,3 @@*
> * #!/bin/bash*
>
> * echo "test"*
> *-echo "another test"*
>
> *tmplt0vvX*
> *#!/bin/bash*
>
> *echo "test"*
>
> *tmplt0vvX-new* - empty file
>
> *tmplt0vvX-new.rej*
> *--- testfile.sh*
> *+++ testfile.sh*
> *@@ -1,4 +1,3 @@*
> * #!/bin/bash*
>
> * echo "test"*
> *-echo "another test"*
>
>
>
> The above terms reflect a potential business arrangement, are provided 

There was an error displaying this diff

2018-01-08 Thread akarasik
Hello,

I'm trying to post review from our hosted Bitbucket, to hosted Reviewboard 
using the RBTools.
The Reviewboard version is 2.0.11
The RBTools version is 0.7.2
It seems to have some issue with the diff of the files but I can't figure 
out what it is.
Is there any place I can check the reason of the failure?

I configured a new repository in reviewboard as a custom git repository 
with a matching raw url mask.

I use the following command to send the review:

*/usr/local/bin/rbt post -d -p --repository-type git --server 
http://rb.server.com --repository my-test-repo --username post-commit-user 
--password  post-commit-user --tracking-branch origin/master --submit-as 
myuser --guess-summary --guess-description --branch master 
c19f372a155993747a9206f0c8fe0085d02acb2b*

And I'm getting a msg that the review was posted.
The STDERR is:
* RBTools 0.7.2*
*>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
*[GCC 4.8.4]*
*>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
*>>> Home = /my_home*
*>>> Current directory = /my_home/shared/data/repositories/902*
*>>> Checking for a Git repository...*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git config core.bare*
*>>> Running: git symbolic-ref -q HEAD*
*>>> Running: git config --get branch.master.merge*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
u'branch.master.merge']*
*---*
*>>> Running: git config --get branch.master.remote*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
u'branch.master.remote']*
*---*
*>>> Running: git config --get remote.origin.url*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
'remote.origin.url']*
*---*
*>>> Running: git config --get remote.origin.url*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
'remote.origin.url']*
*---*
*>>> repository info: Path: /my_home/shared/data/repositories/902, Base 
path: , Supports changesets: False*
*>>> Making HTTP GET request to http://rb.server.com/api/*
*>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
*>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
master*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Running: git log --reverse --pretty=format:%s%n%n%b 
^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Making HTTP GET request to 
http://rb.server.com/api/review-requests/?only-links=create=*
*>>> Making HTTP POST request to http://rb. server.com/api/review-requests/*
*>>> Making HTTP GET request to 
http://rb. server.com/api/review-requests/304341/diffs/?only-fields=*
*>>> Making HTTP POST request to 
http://rb. server.com/api/review-requests/304341/diffs/*
*>>> Making HTTP GET request to 
http://rb. server.com/api/review-requests/304341/draft/?only-fields=commit_id*
*>>> Making HTTP PUT request to 
http://rb. server.com/api/review-requests/304341/draft/*

The diff in the review showing the following:
*The patch to 'testfile.sh' didn't apply cleanly. The temporary files have 
been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
*`patch` returned: *
*This may be a bug in the software, a temporary outage, or an issue with 
the format of your diff.*

And the tmp folder contains following files:

*testfile.sh.diff*
*diff --git a/testfile.sh b/testfile.sh*
*index 
083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
 
100644*
*--- a/testfile.sh*
*+++ b/testfile.sh*
*@@ -1,4 +1,3 @@*
* #!/bin/bash*

* echo "test"*
*-echo "another test"*

*tmplt0vvX*
*#!/bin/bash*

*echo "test"*

*tmplt0vvX-new* - empty file

*tmplt0vvX-new.rej*
*--- testfile.sh*
*+++ testfile.sh*
*@@ -1,4 +1,3 @@*
* #!/bin/bash*

* echo "test"*
*-echo "another test"*



-- 
The above terms reflect a potential business arrangement, are provided solely 
as a basis for further discussion, and are not intended to be and do not 
constitute a legally binding obligation. No legally binding obligations will 
be created, implied, or inferred until an agreement in final form is executed 
in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. 
 If you received this communication by mistake, please don't forward it to 
anyone else, please erase all copies and attachments, and please let me 
know that it has gone to the wrong person. Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group 

Re: Review Board Ticket #4598: There was an error displaying this diff

2017-12-22 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4598/
--

New update by slog2
For Beanbag, Inc. > Review Board > Ticket #4598


Reply:

You'll need to look at the rejects listed in the temporary directory to 
help debug what's going wrong. If you can attach them here that's even more 
helpful to us (but don't include any proprietary information--this is a public 
server).


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4598: There was an error displaying this diff

2017-09-26 Thread JaeWon Lee
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4598/
--

New ticket #4598 by slog2
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
There was an error displaying this diff
==

# What version are you running?
2.5.16

# What's the URL of the page containing the problem?
/r/101/diff/2#index_header

# What steps will reproduce the problem?
1. Create a new review request with SVN diff file
2. Open the diff tab

# What is the expected output? What do you see instead?
Some files diff are not showing with this error
-> There was an error displaying this diff.

I think this problem is related with SVN file encoding 

# What operating system are you using? What browser?
Windows 10, Chrome

# Please provide any additional information below.
```
 There was an error displaying this diff.


The patch to 'branches/ss-mds/web/common/chart.cls.php' didn't apply 
cleanly. The temporary files have been left in '/tmp/reviewboard.W7wEsH' for 
debugging purposes.
`patch` returned: 



 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.





 Please try again, and if you still have trouble,
 contact support.


   
  

  
   

Details
   
  
  
   
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/views.py",
 line 300, in get
response = renderer.render_to_response(request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 74, in render_to_string
large_data=True)
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 298, in cache_memoize
compress_large_data))
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 252, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 295, in 
lambda: [lookup_callable()],
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/renderers.py",
 line 87, in render_to_string_uncached
request=request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 669, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 786, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 107, in get_chunks
large_data=True)
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 298, in cache_memoize
compress_large_data))
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 252, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/lib/python2.6/site-packages/Djblets-0.9.9-py2.6.egg/djblets/cache/backend.py",
 line 295, in 
lambda: [lookup_callable()],
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
 line 793, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 233, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/lib/python2.6/site-packages/ReviewBoard-2.5.16-py2.6.egg/reviewboard/diffviewer/diffutils.py",
 line 169, in patch
'output': stderr,
Exception: The patch to 'branches/ss-mds/web/common/chart.cls.php' didn't apply 
cleanly. The temporary files hav

How to fix and/or avoid the error "There was an error displaying this diff"

2017-09-18 Thread Rodolfo Gomes Dias
Hi,

I have been using reviewboard for a couple of months and during this time I 
have faced some encoding problems when posting my reviews. 
My currenty problem is the following. Sometimes code is posted with a 
different encoding, I have noticed it by checking the encoding of the files 
on the temporary folder (c:/windows/temp/reviewboard.??). In my case, 
sometimes a file is encoded in ANSI and its new version in UTF-8 and the 
other way around. This scenario gives me an error when posting a review 
with the message, "There was an error displaying this diff".
I must say that, I cannot avoid the current enconding mess as it is today. 
As the time goes on, all project's code will be using UTF-8 because we have 
defined it as the unique encoding of the project.

My questions are.
1. Am I right in assume that the diff error "There was an error displaying 
this diff" is caused by the difference in encodings?
2. Is there a way to force a conversion of the files inside the reviewboard 
domain. I mean, whatever the encoding, reviewboard will handle the files in 
a specified encoding and perform the conversion and the diff, even ignoring 
characters when the conversions isn't possible.
3. Is it possible to tell me where in the reviewboard's source code can I 
implement a behaviour like the one suggested in item 2?
4. Is there a simple way to fix this issue and I can forget all I have said 
on items 1, 2, and 3?

The reviewboard admin option:
Advanced Settings > Encoding
Is what I am looking for?

I am using:
> xampp win32 5.6.28
> reviewboard 2.5.7-2 installed via bitnami

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: "There was an error displaying this diff" when config rb via gitweb configuration

2017-08-30 Thread Zizou Fablenas
Hi Christian,

Exciting. Look forward to get it.
Thanks

On Thursday, 31 August 2017 12:06:28 UTC+8, Christian Hammond wrote:
>
> Hi Zizou,
>
> Subgroups aren't supported today, but we should have support in next 
> week's release (aiming for Tuesday).
>
> Christian
>
> On Wed, Aug 30, 2017 at 7:00 PM, Zizou Fablenas  > wrote:
>
>> Hi christian,
>> Thanks for you reply.
>> We've configured the repo as a GitLab repository before, but when we 
>> started to use 'subgroup's on Gitlab, the reviewboard can not locate the 
>> repo. In the GitLab subgroup context, the repository is under the path 
>> '://' while it seems that repository 
>> doesn't have knowledge about ''. There comes we tried the plain 
>> repository. 
>> Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I 
>> get it?
>> I appreciate your help.
>>
>> On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>>>
>>> Hi,
>>>
>>> You'll need to configure the repository as a GitLab repository. A plain 
>>> Git repository won't work. Review Board must talk to the GitLab API in 
>>> order to access files, correctly validate diffs, and display the diff 
>>> viewer.
>>>
>>> You'll also want to grab a newer 2.5.x release for some other GitLab 
>>> fixes. Some more fixes for GitLab are coming in the next 2.5.x release, 
>>> which should be out next Tuesday.
>>>
>>> Christian
>>>
>>> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  
>>> wrote:
>>>
 hi guys,

 to support gitlab subgroup configurations, we had configured rb as 
 follows,


 

 when posted via "rbt post -g", we got errors as follows,


 




 the version of reviewboard is 2.5.9.
 Could you help me to resolve such a problem, please?

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: "There was an error displaying this diff" when config rb via gitweb configuration

2017-08-30 Thread Christian Hammond
Hi Zizou,

Subgroups aren't supported today, but we should have support in next week's
release (aiming for Tuesday).

Christian

On Wed, Aug 30, 2017 at 7:00 PM, Zizou Fablenas  wrote:

> Hi christian,
> Thanks for you reply.
> We've configured the repo as a GitLab repository before, but when we
> started to use 'subgroup's on Gitlab, the reviewboard can not locate the
> repo. In the GitLab subgroup context, the repository is under the path
> '://' while it seems that
> repository doesn't have knowledge about ''. There comes we tried
> the plain repository.
> Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I
> get it?
> I appreciate your help.
>
> On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>>
>> Hi,
>>
>> You'll need to configure the repository as a GitLab repository. A plain
>> Git repository won't work. Review Board must talk to the GitLab API in
>> order to access files, correctly validate diffs, and display the diff
>> viewer.
>>
>> You'll also want to grab a newer 2.5.x release for some other GitLab
>> fixes. Some more fixes for GitLab are coming in the next 2.5.x release,
>> which should be out next Tuesday.
>>
>> Christian
>>
>> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas 
>> wrote:
>>
>>> hi guys,
>>>
>>> to support gitlab subgroup configurations, we had configured rb as
>>> follows,
>>>
>>>
>>> 
>>>
>>> when posted via "rbt post -g", we got errors as follows,
>>>
>>>
>>> 
>>>
>>>
>>>
>>>
>>> the version of reviewboard is 2.5.9.
>>> Could you help me to resolve such a problem, please?
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: "There was an error displaying this diff" when config rb via gitweb configuration

2017-08-30 Thread Zizou Fablenas
Hi christian,
Thanks for you reply.
We've configured the repo as a GitLab repository before, but when we 
started to use 'subgroup's on Gitlab, the reviewboard can not locate the 
repo. In the GitLab subgroup context, the repository is under the path 
'://' while it seems that repository 
doesn't have knowledge about ''. There comes we tried the plain 
repository. 
Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I 
get it?
I appreciate your help.

On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>
> Hi,
>
> You'll need to configure the repository as a GitLab repository. A plain 
> Git repository won't work. Review Board must talk to the GitLab API in 
> order to access files, correctly validate diffs, and display the diff 
> viewer.
>
> You'll also want to grab a newer 2.5.x release for some other GitLab 
> fixes. Some more fixes for GitLab are coming in the next 2.5.x release, 
> which should be out next Tuesday.
>
> Christian
>
> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  > wrote:
>
>> hi guys,
>>
>> to support gitlab subgroup configurations, we had configured rb as 
>> follows,
>>
>>
>> 
>>
>> when posted via "rbt post -g", we got errors as follows,
>>
>>
>> 
>>
>>
>>
>>
>> the version of reviewboard is 2.5.9.
>> Could you help me to resolve such a problem, please?
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: "There was an error displaying this diff" when config rb via gitweb configuration

2017-08-30 Thread Christian Hammond
Hi,

You'll need to configure the repository as a GitLab repository. A plain Git
repository won't work. Review Board must talk to the GitLab API in order to
access files, correctly validate diffs, and display the diff viewer.

You'll also want to grab a newer 2.5.x release for some other GitLab fixes.
Some more fixes for GitLab are coming in the next 2.5.x release, which
should be out next Tuesday.

Christian

On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  wrote:

> hi guys,
>
> to support gitlab subgroup configurations, we had configured rb as follows,
>
>
> 
>
> when posted via "rbt post -g", we got errors as follows,
>
>
> 
>
>
>
>
> the version of reviewboard is 2.5.9.
> Could you help me to resolve such a problem, please?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


"There was an error displaying this diff" when config rb via gitweb configuration

2017-08-30 Thread Zizou Fablenas
hi guys,

to support gitlab subgroup configurations, we had configured rb as follows,



when posted via "rbt post -g", we got errors as follows,






the version of reviewboard is 2.5.9.
Could you help me to resolve such a problem, please?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff.

2017-04-26 Thread Christian Hammond
Hi Stephen,

This looks like a bug we fixed in 2.5.8. (2.5.10 is the latest version.) I
believe if you upgrade, it should be fixed.

See https://hellosplat.com/s/beanbag/tickets/4472/ for info on that bug
report.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Apr 26, 2017 at 12:49 AM, Stephen Lee 
wrote:

> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/views.py", line 275, in get
> response = renderer.render_to_response(request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 56, in
> render_to_response
> return HttpResponse(self.render_to_string(request))
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 74, in
> render_to_string
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 87, in
> render_to_string_uncached
> request=request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 422, in
> populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 756, in
> get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 107, in
> get_chunks
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 106, in
> 
> lambda: list(self.get_chunks_uncached()),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 762, in
> get_chunks_uncached
> self.encoding_list)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 198, in
> get_original_file
> request=request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 359, in get_file
> large_data=True)[0]
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 358, in 
> request)],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 534, in
> _get_file_uncached
> base_commit_id=base_commit_id)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 170, in get_file
> raw_content=True)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 505, in _api_get
> 'PRIVATE-TOKEN': self._get_private_token(),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/service.py", line 55, in http_get
> return self.http_request(url, method='GET', 

There was an error displaying this diff.

2017-04-26 Thread Stephen Lee
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 275, in get
response = renderer.render_to_response(request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 422, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 762, in get_chunks_uncached
self.encoding_list)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 198, in get_original_file
request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/scmtools/models.py",
 
line 359, in get_file
large_data=True)[0]
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/scmtools/models.py",
 
line 358, in 
request)],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/scmtools/models.py",
 
line 534, in _get_file_uncached
base_commit_id=base_commit_id)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py",
 
line 170, in get_file
raw_content=True)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py",
 
line 505, in _api_get
'PRIVATE-TOKEN': self._get_private_token(),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/hostingsvcs/service.py",
 
line 55, in http_get
return self.http_request(url, method='GET', **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/hostingsvcs/service.py",
 
line 79, in http_request
u = urlopen(r)
  File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen
return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 401, in open
response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 419, in _open
'_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
result = func(*args)
  File 

Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-23 Thread Ariel Cassan

Thank you so much, Christian! It has worked like a charm!
If we create the diffs with git and then post the diffs with "rbt post 
--diff-filename=file.diff", ReviewBoard show them properly and let 
reviewers add comments directly on them.

Just a note for other Windows server users: the local path has to be 
configured with "file://" as protocol, like 
"file://C:/whatever/myrepo/.git".


Thanks again.
Regards,


On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our 
> project, which uses Gitblit as the manager of the git repository, 
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and 
> we have used "rbt post" or "rbt post *hash*" for creating the review 
> requests.
>
> However, the "There was an error displaying this diff." is displayed for 
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with 
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason 
> is that either ReviewBoard or GitBlit are trying to use a branch with the 
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*
> /raw/.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a 
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when 
> configuring the raw URL mask as:  http://:<PORT*>*
> /raw/.git//.4
> But of course, it fails anyway as that URL is not returned successfully by 
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-22 Thread Christian Hammond
Hi Ariel,

What you'd do is set the Path to point to .git, optionally set the Mirror
Path to your standard Git clone URL (this is only used for lookup
purposes), and use the repository's name when referencing it in RBTools
(preferably by setting it in .reviewboardrc). Review Board will talk to the
local Git (from the server's perspective) for any changes you post.

Christian

On Wed, Feb 22, 2017 at 01:21 Ariel Cassan <arielcas...@gmail.com> wrote:

>
> Hi Christian,
>
> Thanks again for the response.
> We can do both things you have suggested, but the one would be actually
> easier. So, if you look at the first screenshot I've attached (Repository
> configuration.PNG) and assuming that the repo is in a path like
> C:\repository\.git (yes, it's a Windows server), how should we configure
> ReviewBoard to make diffs work?
>
>
> Thanks!
> Regards.
>
> Ariel C.
>
>
> On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our
> project, which uses Gitblit as the manager of the git repository,
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and
> we have used "rbt post" or "rbt post *hash*" for creating the review
> requests.
>
> However, the "There was an error displaying this diff." is displayed for
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason
> is that either ReviewBoard or GitBlit are trying to use a branch with the
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*
> /raw/.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when
> configuring the raw URL mask as:  http://:<PORT*>*
> /raw/.git//.4
> But of course, it fails anyway as that URL is not returned successfully by
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-22 Thread Ariel Cassan

Hi Christian,

Thanks again for the response.
We can do both things you have suggested, but the one would be actually 
easier. So, if you look at the first screenshot I've attached (Repository 
configuration.PNG) and assuming that the repo is in a path like 
C:\repository\.git (yes, it's a Windows server), how should we configure 
ReviewBoard to make diffs work?


Thanks!
Regards.

Ariel C.


On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our 
> project, which uses Gitblit as the manager of the git repository, 
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and 
> we have used "rbt post" or "rbt post *hash*" for creating the review 
> requests.
>
> However, the "There was an error displaying this diff." is displayed for 
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with 
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason 
> is that either ReviewBoard or GitBlit are trying to use a branch with the 
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*
> /raw/.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a 
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when 
> configuring the raw URL mask as:  http://:<PORT*>*
> /raw/.git//.4
> But of course, it fails anyway as that URL is not returned successfully by 
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-21 Thread Christian Hammond
Hi Ariel,

Unfortunately, we don't otherwise have a way to get data out of GitBlit
today. If they don't expose that feature, we can't get the data needed to
perform code reviews, and other code review tools and services are going to
have the same problem. Git's protocol just doesn't have the kind of
fine-grained access that a code review tool needs, so we depend on the APIs
provided by services like GitBlit.

If you have Review Board running on the same server as GitBlit and can
point Review Board to the local ".git" directory on the filesystem, then
you can do that. Alternatively, you can set up a Git clone that's
constantly in sync, and use that instead.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Tue, Feb 21, 2017 at 7:30 AM, Ariel Cassan <arielcas...@gmail.com> wrote:

>
> Hi again Christian,
>
> James Morger from Gitblit has replied: "At the moment you are stuck as
> Gitblit doesn't have a way to expose blobs referenced by their ids.  We'd
> have to add a new route handler to accommodate that use-case.  This is not
> difficult, just not presently a feature."
>
> So, can you think of any other way to get the diff feature working on our
> ReviewBoard installation?
> This tool is basic when performing code reviews, so this would actually
> mean we should change ReviewBoard for an alternative tool, with the
> consequent effort.
>
>
> Thanks again for your collaboration.
> Kind regards,
>
> Ariel C.
>
>
> On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>>
>> Hi guys,
>>
>> We've started trying out ReviewBoard 2.5.7 as the code review tool for
>> our project, which uses Gitblit as the manager of the git repository,
>> everything on the same server (ReviewBoard + Gitblit + the repo itself)
>> We have configured the repository on ReviewBoard (see attached image) and
>> we have used "rbt post" or "rbt post *hash*" for creating the review
>> requests.
>>
>> However, the "There was an error displaying this diff." is displayed for
>> every file in the request, every time we try it on.
>> We have tried also to create the diff file in local and upload it with
>> "rbt post --diff-filename=" with the same unsuccessful results.
>>
>> When we take a look at the rejection file in the temp folder, the reason
>> is that either ReviewBoard or GitBlit are trying to use a branch with the
>> name of the raw url's revision!
>> So, the raw URL for Gitblit looks as: http://:<PORT*>*/raw/> po_name>.git//.
>> An the error in the rejection file is:
>> ErrorSorry, the repository .git does not have a
>> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>>
>> We understand it takes it from the raw URL because the error changes when
>> configuring the raw URL mask as:  http://:<PORT*>*/raw/> name>.git//.4
>> But of course, it fails anyway as that URL is not returned successfully
>> by Gitblit.
>>
>> Please, can you help us to fix this issue?
>>
>>
>> Thanks in advance.
>> Kind regards,
>>
>> Ariel
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-21 Thread Ariel Cassan

Hi again Christian,

James Morger from Gitblit has replied: "At the moment you are stuck as 
Gitblit doesn't have a way to expose blobs referenced by their ids.  We'd 
have to add a new route handler to accommodate that use-case.  This is not 
difficult, just not presently a feature."

So, can you think of any other way to get the diff feature working on our 
ReviewBoard installation?
This tool is basic when performing code reviews, so this would actually 
mean we should change ReviewBoard for an alternative tool, with the 
consequent effort.


Thanks again for your collaboration.
Kind regards,

Ariel C.


On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our 
> project, which uses Gitblit as the manager of the git repository, 
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and 
> we have used "rbt post" or "rbt post *hash*" for creating the review 
> requests.
>
> However, the "There was an error displaying this diff." is displayed for 
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with 
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason 
> is that either ReviewBoard or GitBlit are trying to use a branch with the 
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*
> /raw/.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a 
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when 
> configuring the raw URL mask as:  http://:<PORT*>*
> /raw/.git//.4
> But of course, it fails anyway as that URL is not returned successfully by 
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-20 Thread Ariel Cassan

Thanks for the prompt response, Christian.

I have created a related issue in Gitblit's 
forum: https://groups.google.com/forum/#!topic/gitblit/VHu7Ym_2j1c
Unfortunately, we don't have too much knowledge in any of both tools to 
solve it by ourselves, thus that's why we asking your help.


Thanks again.
Kind regards,


On Thursday, February 16, 2017 at 5:52:59 PM UTC, Ariel Cassan wrote:
>
>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our 
> project, which uses Gitblit as the manager of the git repository, 
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and 
> we have used "rbt post" or "rbt post *hash*" for creating the review 
> requests.
>
> However, the "There was an error displaying this diff." is displayed for 
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with 
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason 
> is that either ReviewBoard or GitBlit are trying to use a branch with the 
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*
> /raw/.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a 
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when 
> configuring the raw URL mask as:  http://:<PORT*>*
> /raw/.git//.4
> But of course, it fails anyway as that URL is not returned successfully by 
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Yet another "There was an error displaying this diff." issue on ReviewBoard 2.5.7 with GitBlit local server

2017-02-16 Thread Christian Hammond
Hi Ariel,

The SHA being passed in is a blob SHA, and it's possible that that URL on
GitBlit requires a commit SHA, which won't be available. Whether GitBlit
offers a version of this URL that supports blobs, I don't know, but that
would either need to exist or direct support for GitBlit as a service would
need to be written.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Thu, Feb 16, 2017 at 9:39 AM, Ariel Cassan <arielcas...@gmail.com> wrote:

>
> Hi guys,
>
> We've started trying out ReviewBoard 2.5.7 as the code review tool for our
> project, which uses Gitblit as the manager of the git repository,
> everything on the same server (ReviewBoard + Gitblit + the repo itself)
> We have configured the repository on ReviewBoard (see attached image) and
> we have used "rbt post" or "rbt post *hash*" for creating the review
> requests.
>
> However, the "There was an error displaying this diff." is displayed for
> every file in the request, every time we try it on.
> We have tried also to create the diff file in local and upload it with
> "rbt post --diff-filename=" with the same unsuccessful results.
>
> When we take a look at the rejection file in the temp folder, the reason
> is that either ReviewBoard or GitBlit are trying to use a branch with the
> name of the raw url's revision!
> So, the raw URL for Gitblit looks as: http://:<PORT*>*/raw/<
> repo_name>.git//.
> An the error in the rejection file is:
> ErrorSorry, the repository .git does not have a
> 65c87f4f676953cb12770a50af3cd405bcb86863 branch!
>
> We understand it takes it from the raw URL because the error changes when
> configuring the raw URL mask as:  http://:<PORT*>*/raw/ name>.git//.4
> But of course, it fails anyway as that URL is not returned successfully by
> Gitblit.
>
> Please, can you help us to fix this issue?
>
>
> Thanks in advance.
> Kind regards,
>
> Ariel
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff

2016-08-27 Thread Christian Hammond
Hi Igor,

I'm sorry I haven't been able to get to this yet. Been busy with some
customers with support contracts lately, and my backlog's been growing.

What I have noticed is that the reject file's showing a different encoding
than the source file, indicating that maybe the patch in question isn't
properly UTF-8 (or the code fetched from the repository isn't UTF-8).

Is there a way I could also get the patch in question? (Remember that these
are publicly indexed -- private support is something we offer, but only
with a support contract.)

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Aug 15, 2016 at 11:52 PM, Igor Zilberman  wrote:

>
> Hi,
>
> Attached.
> Thanks.
>
> понедельник, 15 августа 2016 г., 22:45:18 UTC+3 пользователь Christian
> Hammond написал:
>>
>> Can you zip up those files and send them that way? Encodings can be
>> messed with when transmitting over e-mail.
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Mon, Aug 15, 2016 at 1:08 AM, Igor Zilberman 
>> wrote:
>>
>>> Hi Christian,
>>>
>>> Thank you for your reply!
>>>
>>> I am using 2.5.3 with RBTools 0.7.5.
>>> Repository type is ClearCase.
>>> Ive attached part of the xml file and the rej file.
>>>
>>> Regarding the last q I am not sure, but in the advanced settings of this
>>> repository, Encoding field is empty.
>>>
>>> Thanks.
>>>
>>> понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian
>>> Hammond написал:

 Hi Igor,

 What version of Review Board are you using, and what type of repository?

 Would it be possible to get a sample of one of the files that is
 failing, along with the matching section from the reject file in that temp
 directory?

 Are the special characters indeed UTF-8 in the repository, or is the
 repository converting them to UTF-8 on checkout?

 Christian

 --
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

 On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman 
 wrote:

> I am getting error trying to see the diff:
>
> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
> for debugging purposes.
> `patch` returned:
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
> This file contains unicode characters.
>
> I had an issue to post this file:
> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298:
> ordinal not in range(128)
>
> So after adding sitecustomize.py:
>
> # encoding=utf8
> import sys
>
> reload(sys)
> sys.setdefaultencoding('utf8')
>
>
> I was able to post but now I cant see the diff in reviewboard.
>
> Thanks.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff

2016-08-15 Thread Christian Hammond
Can you zip up those files and send them that way? Encodings can be messed
with when transmitting over e-mail.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Aug 15, 2016 at 1:08 AM, Igor Zilberman  wrote:

> Hi Christian,
>
> Thank you for your reply!
>
> I am using 2.5.3 with RBTools 0.7.5.
> Repository type is ClearCase.
> Ive attached part of the xml file and the rej file.
>
> Regarding the last q I am not sure, but in the advanced settings of this
> repository, Encoding field is empty.
>
> Thanks.
>
> понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian
> Hammond написал:
>>
>> Hi Igor,
>>
>> What version of Review Board are you using, and what type of repository?
>>
>> Would it be possible to get a sample of one of the files that is failing,
>> along with the matching section from the reject file in that temp directory?
>>
>> Are the special characters indeed UTF-8 in the repository, or is the
>> repository converting them to UTF-8 on checkout?
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman 
>> wrote:
>>
>>> I am getting error trying to see the diff:
>>>
>>> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
>>> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
>>> for debugging purposes.
>>> `patch` returned:
>>>  This may be a bug in the software, a temporary outage, or an issue
>>>  with the format of your diff.
>>>
>>>  Please try again, and if you still have trouble,
>>>  contact support.
>>>
>>> This file contains unicode characters.
>>>
>>> I had an issue to post this file:
>>> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal
>>> not in range(128)
>>>
>>> So after adding sitecustomize.py:
>>>
>>> # encoding=utf8
>>> import sys
>>>
>>> reload(sys)
>>> sys.setdefaultencoding('utf8')
>>>
>>>
>>> I was able to post but now I cant see the diff in reviewboard.
>>>
>>> Thanks.
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff

2016-08-15 Thread Igor Zilberman
Hi Christian,

Thank you for your reply!

I am using 2.5.3 with RBTools 0.7.5.
Repository type is ClearCase.
Ive attached part of the xml file and the rej file.

Regarding the last q I am not sure, but in the advanced settings of this 
repository, Encoding field is empty.

Thanks.

понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian 
Hammond написал:
>
> Hi Igor,
>
> What version of Review Board are you using, and what type of repository?
>
> Would it be possible to get a sample of one of the files that is failing, 
> along with the matching section from the reject file in that temp directory?
>
> Are the special characters indeed UTF-8 in the repository, or is the 
> repository converting them to UTF-8 on checkout?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman  > wrote:
>
>> I am getting error trying to see the diff:
>>
>> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply 
>> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z' 
>> for debugging purposes.
>> `patch` returned: 
>>  This may be a bug in the software, a temporary outage, or an issue
>>  with the format of your diff.
>>
>>  Please try again, and if you still have trouble,
>>  contact support.
>>
>> This file contains unicode characters.
>>
>> I had an issue to post this file:
>> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal 
>> not in range(128)
>>
>> So after adding sitecustomize.py:
>>
>> # encoding=utf8  
>> import sys  
>>
>> reload(sys)  
>> sys.setdefaultencoding('utf8')
>>
>>
>> I was able to post but now I cant see the diff in reviewboard.
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


tmpex08zZ-new.rej
Description: Binary data


RetCodesQuotaDir.xml
Description: XML document


Re: There was an error displaying this diff

2016-08-14 Thread Christian Hammond
Hi Igor,

What version of Review Board are you using, and what type of repository?

Would it be possible to get a sample of one of the files that is failing,
along with the matching section from the reject file in that temp directory?

Are the special characters indeed UTF-8 in the repository, or is the
repository converting them to UTF-8 on checkout?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman  wrote:

> I am getting error trying to see the diff:
>
> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
> for debugging purposes.
> `patch` returned:
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
> This file contains unicode characters.
>
> I had an issue to post this file:
> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal
> not in range(128)
>
> So after adding sitecustomize.py:
>
> # encoding=utf8
> import sys
>
> reload(sys)
> sys.setdefaultencoding('utf8')
>
>
> I was able to post but now I cant see the diff in reviewboard.
>
> Thanks.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


There was an error displaying this diff

2016-08-14 Thread Igor Zilberman
I am getting error trying to see the diff:

The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply 
cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z' 
for debugging purposes.
`patch` returned: 
 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.

 Please try again, and if you still have trouble,
 contact support.

This file contains unicode characters.

I had an issue to post this file:
CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal not 
in range(128)

So after adding sitecustomize.py:

# encoding=utf8  
import sys  

reload(sys)  
sys.setdefaultencoding('utf8')


I was able to post but now I cant see the diff in reviewboard.

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-06 Thread Supraja Kumaravel
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

Is there a way to delete that request and create a new one?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-06 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

Please use the community mailing list for questions. This bug tracker is an 
inappropriate place for it.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-06 Thread Supraja Kumaravel
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

If I am not publishing a review request and creating a new nequest for the 
same number will the older one be replaced?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-06 Thread Supraja Kumaravel
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

Hi,

   I dont have administration tab in my organization's review board page. 
   I will give you details of how I had set up the repository.
   I cloned it from the main url:  git clone  
   Sunced from another branch:  git checkout 
   git pull
   Created a local branch:  git checkout -b 
   Then edited some of the exixting files and added new files.
   For the first time without staging the newly added files I committed the 
edited ones and posted a review.
   Then again adding the newly added files I commited and got a new commit 
id and posted the review for that.
   Then there was corrections to be made to those files.So I edited those 
files and committed. But now when I post review using commands, post-review 
 or post-review  -r  there was 
an error in displaying the diff.
   So now I get this error only when i edit those existing files and if I 
add a new file it is diaplyed correctly.
   Can you please provide me a solution for this?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-06 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

In the Review Board administration page, click the repository 
configuration. Take a screenshot of that, and send it to the community mailing 
list (https://www.reviewboard.org/mailing-lists/). If possible, please also 
share the contents of the temporary directory listed in the error output.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-05 Thread Supraja Kumaravel
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

Really sorry I am a fresher in working with review board so I dont know how 
to get these details.Can you please help me with it?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purpo

2016-07-05 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New update by skumaravel
For Beanbag, Inc. > Review Board > Ticket #4439


Reply:

This is almost always a configuration problem with the repository. Can you 
send us details of how it's set up in the Review Board admin site on the 
community mailing list?


Status:
- New
+ SetupIssue

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4439: There was an error displaying this diff. The patch to 'pom.xml' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.5kc5pw' for debugging purposes.

2016-07-05 Thread Supraja Kumaravel
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4439/
--

New ticket #4439 by skumaravel
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * bug.png
   <https://hellosplat.com/s/beanbag/attachments/1196/>



--
There was an error displaying this diff.   The patch to 'pom.xml' 
didn't apply cleanly. The temporary files have been left in 
'/tmp/reviewboard.5kc5pw' for debugging purposes. `patch` returned: 
 This may be a bug in the software, a temporary outage, or an issue  with 
the form
==

# What version are you running?


# What's the URL of the page containing the problem?


# What steps will reproduce the problem?
1. 
2. 
3. 


# What is the expected output? What do you see instead?


# What operating system are you using? What browser?


# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff.

2016-06-29 Thread tiger . peng
Hello All,

We run into similar issue. After spend some time, I identified the cause: 
the svnlook diff converted string "\t" to tab charter and cause patch 
command failure

Anyone have suggestion on how to solve the issue: (The svnlook is quite old 
and I cannot perform upgrade at this time.)

svnlook --version

 

svnlook, version 1.5.1 (r32289) 

   compiled Jul 31 2008, 09:45:17 


 

Copyright (C) 2000-2008 CollabNet.





The diff command used in pre-commit hook:
$SVNLOOK diff -x -u -t "$TXN" "$REPOS"

Thanks in advance,


Tiger




On Thursday, February 4, 2016 at 9:09:13 AM UTC-6, Waqar Ali Khan wrote:
>
> Hello everyone,
> I am using Reviewboard 2.5.2 on Ubuntu and on client side using latest 
> version of RBTools which is 0.7.5.
> When i am trying to post review for some files the diff is not showing 
> giving following error. My repository is CVS based. I have attached the 
> temporary files referenced in the error.
> My guess is that either CVS is not generating diff correctly or Review 
> Board cannot read some of the diff files.
>
>  There was an error displaying this diff.
> The patch to 
> 'stencils/jasperReports/quickReports/AP/form1099Report.jrxml' didn't apply 
> cleanly. The temporary files have been left in '/tmp/reviewboard.W0_4Ee' 
> for debugging purposes.
> `patch` returned: patch:  malformed patch at line 8499: 
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>  Please try again, and if you still have trouble,
>  contact support.
>
> Traceback (most recent call last):
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/views.py",
>  
> line 275, in get
> response = renderer.render_to_response(request)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string
> large_data=True)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 295, in cache_memoize
> compress_large_data))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 87, in render_to_string_uncached
> request=request)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 107, in get_chunks
> large_data=True)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 295, in cache_memoize
> compress_large_data))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py&qu

Re: Review Board Ticket #4191: "Error displaying this diff" for most files that are posted.

2016-06-14 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4191/
--

New update by gdgray
For Beanbag, Inc. > Review Board > Ticket #4191


Reply:

This is usually an issue with fetching the original version of the files. 
If you look at the temporary files, check the orig versions to see that they 
match your expectation. If they don't, it's probably a misconfiguration of the 
repository in the Review Board admin.

Since this is (almost) always an error in configuration or set-up, I'm 
going to close this. We can continue to assist you on the community mailing 
list (https://groups.google.com/forum/#!forum/reviewboard)


Status:
- New
+ SetupIssue

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4191: "Error displaying this diff" for most files that are posted.

2016-06-14 Thread VJ Ash
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4191/
--

New update by gdgray
For Beanbag, Inc. > Review Board > Ticket #4191


Reply:

I also have the same error. There are no problems with the diffs. I am able 
to patch the diff perfectly without any errors. But there is an error whiel 
displaying the diff on reviewboard. How to go about it?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: There was an error displaying this diff.

2016-02-04 Thread Christian Hammond
Hi,

Your diff appears to have a bad mixture of line endings. Some lines use \n
(everything but the diff content), whereas the diff content uses \r\n. This
mixture is what's causing the parsing errors, as patch (and anything else)
will see extra newlines in the diff content.

This might be something you'd need to fix in the repository in this case,
but can you show me the full command you used to post the diff, along with
the --debug flag?

Was the source tree checked out on the Ubuntu system, or was it copied over
from another system?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Thu, Feb 4, 2016 at 3:00 AM, Waqar Ali Khan <waqar.kha...@gmail.com>
wrote:

> Hello everyone,
> I am using Reviewboard 2.5.2 on Ubuntu and on client side using latest
> version of RBTools which is 0.7.5.
> When i am trying to post review for some files the diff is not showing
> giving following error. My repository is CVS based. I have attached the
> temporary files referenced in the error.
> My guess is that either CVS is not generating diff correctly or Review
> Board cannot read some of the diff files.
>
>  There was an error displaying this diff.
> The patch to
> 'stencils/jasperReports/quickReports/AP/form1099Report.jrxml' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.W0_4Ee'
> for debugging purposes.
> `patch` returned: patch:  malformed patch at line 8499:
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>  Please try again, and if you still have trouble,
>  contact support.
>
> Traceback (most recent call last):
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/views.py",
> line 275, in get
> response = renderer.render_to_response(request)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
&

Re: There was an error displaying this diff.

2015-12-01 Thread Jerzy Lasyk
Thank you for response.
Unfortunately still doesn't work. Error is the same.
I have put in Raw File URL 
mask: 
http://plmaaa02.*:8080/gitweb?p=SW_TestTool.git;a=blob;f=;h=
When I put instead of filename and revision, data from diff file and open 
url, correct file from gitweb is visible. 
I have no idea what is still wrong.

-Jerzy

W dniu poniedziałek, 30 listopada 2015 23:55:41 UTC+1 użytkownik David 
Trowbridge napisał:
>
> The Raw File URL mask needs to be a template URL, not just the path to the 
> gitweb server.
>
> See 
> https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
>  for 
> examples.
>
> -David
>
> On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk <jerzy...@gmail.com 
> > wrote:
>
>> The RAW file URL mask : http://plmaaa02
>> :8080/p/SW_TestTool.git
>> Path field is same: http://plmaaa02
>> ***:8080/p/SW_TestTool.git
>>
>>
>> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David 
>> Trowbridge napisał:
>>
>>> What is the raw file URL set to?
>>>
>>> -David
>>>
>>> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk <jerzy...@gmail.com> wrote:
>>>
>> I have a problem with error: "There was an error displaying this diff." I 
>>>> was searching for solution in this group, but didn't find helpful answer.
>>>> This error occurs for all generated diffs, created using command : 
>>>> "rbt post"
>>>> I am using git repository. In reviewboard configuration I have put 
>>>> gitweb address in Path and Raw URL field. Whole error log is.
>>>>
>>>> Traceback (most recent call last):
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>  
>>>> line 275, in get
>>>> response = renderer.render_to_response(request)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>  
>>>> line 56, in render_to_response
>>>> return HttpResponse(self.render_to_string(request))
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>  
>>>> line 74, in render_to_string
>>>> large_data=True)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>  
>>>> line 295, in cache_memoize
>>>> compress_large_data))
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>  
>>>> line 249, in cache_memoize_iter
>>>> items = items_or_callable()
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>  
>>>> line 292, in 
>>>> lambda: [lookup_callable()],
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>  
>>>> line 73, in 
>>>> lambda: self.render_to_string_uncached(request),
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>  
>>>> line 87, in render_to_string_uncached
>>>> request=request)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>  
>>>> line 422, in populate_diff_chunks
>>>> chunks = list(generator.get_chunks())
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>  
>>>> line 756, in get_chunks
>>>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>  
>>>> line 107, in get_chunks
>>>> large_data=True)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djbl

Re: There was an error displaying this diff.

2015-12-01 Thread Christian Hammond
Try clearing memcached. There may be some stale state there.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Tue, Dec 1, 2015 at 1:41 AM, Jerzy Lasyk <jerzyla...@gmail.com> wrote:

> Thank you for response.
> Unfortunately still doesn't work. Error is the same.
> I have put in Raw File URL mask: http://plmaaa02.
> *:8080/gitweb?p=SW_TestTool.git;a=blob;f=;h=
> When I put instead of filename and revision, data from diff file and open
> url, correct file from gitweb is visible.
> I have no idea what is still wrong.
>
> -Jerzy
>
> W dniu poniedziałek, 30 listopada 2015 23:55:41 UTC+1 użytkownik David
> Trowbridge napisał:
>>
>> The Raw File URL mask needs to be a template URL, not just the path to
>> the gitweb server.
>>
>> See
>> https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
>>  for
>> examples.
>>
>> -David
>>
>> On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk <jerzy...@gmail.com> wrote:
>>
>>> The RAW file URL mask : http://plmaaa02
>>> :8080/p/SW_TestTool.git
>>> Path field is same: http://plmaaa02
>>> ***:8080/p/SW_TestTool.git
>>>
>>>
>>> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David
>>> Trowbridge napisał:
>>>
>>>> What is the raw file URL set to?
>>>>
>>>> -David
>>>>
>>>> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk <jerzy...@gmail.com> wrote:
>>>>
>>> I have a problem with error: "There was an error displaying this diff."
>>>>> I was searching for solution in this group, but didn't find helpful 
>>>>> answer.
>>>>> This error occurs for all generated diffs, created using command :
>>>>> "rbt post"
>>>>> I am using git repository. In reviewboard configuration I have put
>>>>> gitweb address in Path and Raw URL field. Whole error log is.
>>>>>
>>>>> Traceback (most recent call last):
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>>>> line 275, in get
>>>>> response = renderer.render_to_response(request)
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>> line 56, in render_to_response
>>>>> return HttpResponse(self.render_to_string(request))
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>> line 74, in render_to_string
>>>>> large_data=True)
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>> line 295, in cache_memoize
>>>>> compress_large_data))
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>> line 249, in cache_memoize_iter
>>>>> items = items_or_callable()
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>>>> line 292, in 
>>>>> lambda: [lookup_callable()],
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>> line 73, in 
>>>>> lambda: self.render_to_string_uncached(request),
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>>>> line 87, in render_to_string_uncached
>>>>> request=request)
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>>>> line 422, in populate_diff_chunks
>>>>> chunks = list(generator.get_chunks())
>>>>>   File
>>>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>>>> line 756, in get_chunks
>>

Re: There was an error displaying this diff.

2015-11-30 Thread David Trowbridge
The Raw File URL mask needs to be a template URL, not just the path to the
gitweb server.

See
https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
for
examples.

-David

On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk <jerzyla...@gmail.com> wrote:

> The RAW file URL mask : http://plmaaa02
> :8080/p/SW_TestTool.git
> Path field is same: http://plmaaa02
> ***:8080/p/SW_TestTool.git
>
>
> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David
> Trowbridge napisał:
>
>> What is the raw file URL set to?
>>
>> -David
>>
>> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk <jerzy...@gmail.com> wrote:
>>
> I have a problem with error: "There was an error displaying this diff." I
>>> was searching for solution in this group, but didn't find helpful answer.
>>> This error occurs for all generated diffs, created using command : "rbt
>>> post"
>>> I am using git repository. In reviewboard configuration I have put
>>> gitweb address in Path and Raw URL field. Whole error log is.
>>>
>>> Traceback (most recent call last):
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>> line 275, in get
>>> response = renderer.render_to_response(request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 56, in render_to_response
>>> return HttpResponse(self.render_to_string(request))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 74, in render_to_string
>>> large_data=True)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 73, in 
>>> lambda: self.render_to_string_uncached(request),
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 87, in render_to_string_uncached
>>> request=request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>> line 422, in populate_diff_chunks
>>> chunks = list(generator.get_chunks())
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 756, in get_chunks
>>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 107, in get_chunks
>>> large_data=True)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 106, in 
>>> lambda: list(self.get_chunks_uncached()),
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 763, in get_chunks_uncached
>>> new = get_patched_file

Re: There was an error displaying this diff.

2015-11-29 Thread Jerzy Lasyk
The RAW file URL mask 
: http://plmaaa02:8080/p/SW_TestTool.git
Path field is 
same: http://plmaaa02***:8080/p/SW_TestTool.git

W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David 
Trowbridge napisał:
>
> What is the raw file URL set to?
>
> -David
>
> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk <jerzy...@gmail.com 
> > wrote:
>
>> I have a problem with error: "There was an error displaying this diff." I 
>> was searching for solution in this group, but didn't find helpful answer.
>> This error occurs for all generated diffs, created using command : "rbt 
>> post"
>> I am using git repository. In reviewboard configuration I have put gitweb 
>> address in Path and Raw URL field. Whole error log is.
>>
>> Traceback (most recent call last):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>  
>> line 275, in get
>> response = renderer.render_to_response(request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 56, in render_to_response
>> return HttpResponse(self.render_to_string(request))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 74, in render_to_string
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 73, in 
>> lambda: self.render_to_string_uncached(request),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 87, in render_to_string_uncached
>> request=request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 422, in populate_diff_chunks
>> chunks = list(generator.get_chunks())
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 756, in get_chunks
>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 107, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 106, in 
>> lambda: list(self.get_chunks_uncached()),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 763, in get_chunks_uncached
>> new = get_patched_file(old, self.filediff, self.request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 232, in get_patched_file
>> return patch(diff, buffer, filediff.dest_file, request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer

Re: There was an error displaying this diff.

2015-11-28 Thread David Trowbridge
What is the raw file URL set to?

-David

On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk <jerzyla...@gmail.com> wrote:

> I have a problem with error: "There was an error displaying this diff." I
> was searching for solution in this group, but didn't find helpful answer.
> This error occurs for all generated diffs, created using command : "rbt
> post"
> I am using git repository. In reviewboard configuration I have put gitweb
> address in Path and Raw URL field. Whole error log is.
>
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
> line 275, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 232, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 168, in patch
> 'output': stderr,
> Exception: The patch to
> 'AP_NavServerTest/AppBase/source/TestServerMain.cpp' didn't apply cleanly.
> The temporary files have been left in '/tmp/reviewboard.dQtcK8' for
> debugging purposes.
> `patch` returned:
>
>
> Erro occures for all .cpp, .gitignore, .h files.
> Please Help.
>
> Jerzy
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe

There was an error displaying this diff.

2015-11-27 Thread Jerzy Lasyk
I have a problem with error: "There was an error displaying this diff." I 
was searching for solution in this group, but didn't find helpful answer.
This error occurs for all generated diffs, created using command : "rbt 
post"
I am using git repository. In reviewboard configuration I have put gitweb 
address in Path and Raw URL field. Whole error log is.

Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 275, in get
response = renderer.render_to_response(request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 422, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 232, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 168, in patch
'output': stderr,
Exception: The patch to 
'AP_NavServerTest/AppBase/source/TestServerMain.cpp' didn't apply cleanly. 
The temporary files have been left in '/tmp/reviewboard.dQtcK8' for 
debugging purposes.
`patch` returned: 


Erro occures for all .cpp, .gitignore, .h files.
Please Help.

Jerzy

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2015-02-26 Thread reviewboard


Comment #9 on issue 3398 by sachin.g...@gmail.com: Error displaying this  
diff

https://code.google.com/p/reviewboard/issues/detail?id=3398

We also face the same issue in our organization. When the patch is  
downloaded and is applied, it gets applied correctly but reviewboard shows  
the error message 'There was an error displaying this diff'.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Getting an error There was an error displaying this diff while doing diff in review request.

2015-01-29 Thread Rich Viola
Hello - did you ever resolve this?  Seeing the same, there is no mirror 
path, but there is a repo that is a subdirectory of another repo:

There was an error displaying this diff. 

The patch to '.gitignore' didn't apply cleanly. The temporary files have 
been left in '/tmp/reviewboard._taeVS' for debugging purposes. `patch` 
returned:

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

Please try again, and if you still have trouble, contact support
On Tuesday, July 8, 2014 at 6:33:31 AM UTC-4, Nitish Gangal wrote:

 Hi All,

 I am using reviewboard-2.0.2. I have added one gitlab repository for my 
 project.
 Now, I am creating a diff file on my cloned code repository, using 
 following command:

 git diff --full-index  master6.patch

 This, master6.patch file, I am uploading while creating review request. In 
 this case, my review request gets created successfully.
 Now, when I click on 'view diff' link, then I am getting following error 
 continuously:

 There was an error displaying this diff. 

 The patch to 'abcProject/d.rb' didn't apply cleanly. The temporary files 
 have been left in '/tmp/reviewboard.RHA9Qh' for debugging purposes. `patch` 
 returned: 

 This may be a bug in the software, a temporary outage, or an issue with 
 the format of your diff. 

 Please try again, and if you still have trouble, contact support 
 http://10.0.14.29/support/.

 I am struggling to resolve this issue since long.

 Request you to please provide me some pointers in order to resolve the 
 issue.

 Awaiting for your positive reply,

 Thanks,

 Nitish Gangal





-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: view difff generates error: There was an error displaying this diff.

2014-09-15 Thread ch . jeskiran
Thanks David for the reply.
stopping memchaed service helped.
Also fixed the issue with customized module.

Now diff is working fine.
Thanks,
Jes.

On Monday, September 15, 2014 2:52:29 AM UTC+5:30, David Trowbridge wrote:

 Are you doing this with a development install or in production? If the 
 latter, you'll need to reload the web server and clear your cache (probably 
 memcached) before running with new code.

 -David

 On Sep 14, 2014, at 1:27 PM, ch.je...@gmail.com javascript: wrote:

 Thanks David,

 I did more debugging.
 cmvc.py has the function:

 def get_file(self, path, revision=HEAD):
 logging.debug(CMVC File invoked  %s %s % (filename, 
 revision ))
 if not path:
 raise FileNotFoundError(path, revision)
 return self.client.cat_file(path, revision)


 I also added debug statement, but the log file is not having any custom 
 defined debug entries. Does it mean that function is not invoked?
 At line, 100 od diffutils.py code is related to old file
 (fd, oldfile) = tempfile.mkstemp(dir=tempdir)
 f = os.fdopen(fd, w+b)
 f.write(convert_line_endings(file))
 f.close()

 But here, I dont see in the logs related to custom module debug messages.
 Next to that, it is doing patch and then expetion is raised.

 Logs:
 2014-09-13 01:57:14,292 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - Generating diff file info for diffset id 5, 
 filediff 5 took 0.003863 seconds
 2014-09-13 01:57:14,292 - DEBUG -  - Cache miss for key 
 diff-sidebyside-hl-5-en.
 2014-09-13 01:57:14,295 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - Begin: Patching file testfile
 2014-09-13 01:57:14,308 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - End: Patching file testfile
 2014-09-13 01:57:14,308 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - Patching file testfile took 0.012399 seconds
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - Begin: Generating diff file info for diffset id 
 5, filediff 5
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - End: Generating diff file info for diffset id 5, 
 filediff 5
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - 
 /r/7/diff/1/fragment/5/ - Generating diff file info for diffset id 5, 
 filediff 5 took 0.000472 seconds


 Pls. help to resolve the issue.

 Thanks,
 Jes






 On Sunday, September 14, 2014 11:48:20 PM UTC+5:30, David Trowbridge wrote:

 You should not be looking at the RBTools code for this. RBTools is for 
 the client-side command line tools.

 The server-side code for communicating with repositories lives in 
 reviewboard/scmtools. The function for returning the original version of 
 the file is called get_file().

 -David



 On Sun, Sep 14, 2014 at 11:15 AM, ch.je...@gmail.com wrote:

 Thanks David.
 I tried to go through all supported clients like CVS/ClearCase(class 
 CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)

 Which function in this class is really returning the original version or 
 modified version of file.
 From all the Client classes, I could see that diff function is 
 overwitten and it is returing the difference between files.
 But which is the function that returns the original/modified file?

 Also post-review or rbt post is not used with revisions in the 
 customnized CMVC client, hence no need to have parse_revision_spec and
 need not consider revisions right? It would also have revisions as zero.

 Pls. help, which class can be taken as a reference to fix issues with 
 customized class.
 tmppg8GFU should contain original file and tmppg8GFU.new should contain 
 modified file?

 Thanks,
 Jes. 
  

 On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge 
 wrote:

 The tmppg8GFU file should be the original version of the file being 
 patched. Given that this is empty, I believe that there is a bug in your 
 cvmc SCMTool implementation.

 -David

 On Sat, Sep 13, 2014 at 10:23 AM, ch.je...@gmail.com wrote:

 Hi David,
 IT is a customized control system, cmvc.

 Diff is properly generated in the debug files. tmppg8GFU-new.rej file 
 and test.diff.

 But it is unable to post the diff to server. Screen is showing 
 following error:


 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in 

Re: view difff generates error: There was an error displaying this diff.

2014-09-14 Thread ch . jeskiran
Thanks David.
I tried to go through all supported clients like CVS/ClearCase(class 
CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)

Which function in this class is really returning the original version or 
modified version of file.
From all the Client classes, I could see that diff function is overwitten 
and it is returing the difference between files.
But which is the function that returns the original/modified file?

Also post-review or rbt post is not used with revisions in the customnized 
CMVC client, hence no need to have parse_revision_spec and
need not consider revisions right? It would also have revisions as zero.

Pls. help, which class can be taken as a reference to fix issues with 
customized class.
tmppg8GFU should contain original file and tmppg8GFU.new should contain 
modified file?

Thanks,
Jes. 
 

On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge wrote:

 The tmppg8GFU file should be the original version of the file being 
 patched. Given that this is empty, I believe that there is a bug in your 
 cvmc SCMTool implementation.

 -David

 On Sat, Sep 13, 2014 at 10:23 AM, ch.je...@gmail.com javascript: 
 wrote:

 Hi David,
 IT is a customized control system, cmvc.

 Diff is properly generated in the debug files. tmppg8GFU-new.rej file and 
 test.diff.

 But it is unable to post the diff to server. Screen is showing following 
 error:


 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 152, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 160, in _get_chunks_uncached
 new = get_patched_file(old, self.filediff, self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 201, in get_patched_file
 return patch(diff, buffer, filediff.dest_file, request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 139, in patch
 'output': stderr,
 Exception: The patch to 'test' didn't apply cleanly. The temporary files 
 have been left in '/tmp/reviewboard.axR11W' for debugging purposes.
 `patch` returned: 


 what is the meaning of patch error?
 How to resolve this?
 tmppg8GFU and tmppg8GFU-new files are empty in the debug directory.
 what supposed be contents of these files?
 Pls. help

 Thanks,
 Jes .


 On Saturday, September 13, 2014 3:25:42 AM UTC+5:30, David Trowbridge 
 wrote:

 Is the tmppg8GFU file what you'd expect? (the pre-patched file contents)

 What version control system?

 -David

 On Fri, Sep 12, 2014 at 11:25 AM, ch.je...@gmail.com wrote:

 Hi,
 Using reviewboard 2.0.6 and RBTools 0.6.2.
 post-review worked fine and generated a new request.
 When I looked into view diff for the request, it is failing.

 details error:

 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 

Re: view difff generates error: There was an error displaying this diff.

2014-09-14 Thread David Trowbridge
You should not be looking at the RBTools code for this. RBTools is for the
client-side command line tools.

The server-side code for communicating with repositories lives in
reviewboard/scmtools. The function for returning the original version of
the file is called get_file().

-David



On Sun, Sep 14, 2014 at 11:15 AM, ch.jeski...@gmail.com wrote:

 Thanks David.
 I tried to go through all supported clients like CVS/ClearCase(class
 CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)

 Which function in this class is really returning the original version or
 modified version of file.
 From all the Client classes, I could see that diff function is overwitten
 and it is returing the difference between files.
 But which is the function that returns the original/modified file?

 Also post-review or rbt post is not used with revisions in the customnized
 CMVC client, hence no need to have parse_revision_spec and
 need not consider revisions right? It would also have revisions as zero.

 Pls. help, which class can be taken as a reference to fix issues with
 customized class.
 tmppg8GFU should contain original file and tmppg8GFU.new should contain
 modified file?

 Thanks,
 Jes.


 On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge wrote:

 The tmppg8GFU file should be the original version of the file being
 patched. Given that this is empty, I believe that there is a bug in your
 cvmc SCMTool implementation.

 -David

 On Sat, Sep 13, 2014 at 10:23 AM, ch.je...@gmail.com wrote:

 Hi David,
 IT is a customized control system, cmvc.

 Diff is properly generated in the debug files. tmppg8GFU-new.rej file
 and test.diff.

 But it is unable to post the diff to server. Screen is showing following
 error:


 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 152, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 160, in _get_chunks_uncached
 new = get_patched_file(old, self.filediff, self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 201, in get_patched_file
 return patch(diff, buffer, filediff.dest_file, request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 139, in patch
 'output': stderr,
 Exception: The patch to 'test' didn't apply cleanly. The temporary files 
 have been left in '/tmp/reviewboard.axR11W' for debugging purposes.
 `patch` returned:


 what is the meaning of patch error?
 How to resolve this?
 tmppg8GFU and tmppg8GFU-new files are empty in the debug directory.
 what supposed be contents of these files?
 Pls. help

 Thanks,
 Jes .


 On Saturday, September 13, 2014 3:25:42 AM UTC+5:30, David Trowbridge
 wrote:

 Is the tmppg8GFU file what you'd expect? (the pre-patched file contents)

 What version control system?

 -David

 On Fri, Sep 12, 2014 at 11:25 AM, ch.je...@gmail.com wrote:

 Hi,
 Using reviewboard 2.0.6 and RBTools 0.6.2.
 post-review worked fine and generated a new request.
 When I looked into view diff for the request, it is failing.

 details error:

 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   

Re: view difff generates error: There was an error displaying this diff.

2014-09-14 Thread ch . jeskiran
Thanks David,

I did more debugging.
cmvc.py has the function:

def get_file(self, path, revision=HEAD):
logging.debug(CMVC File invoked  %s %s % (filename, 
revision ))
if not path:
raise FileNotFoundError(path, revision)
return self.client.cat_file(path, revision)


I also added debug statement, but the log file is not having any custom 
defined debug entries. Does it mean that function is not invoked?
At line, 100 od diffutils.py code is related to old file
(fd, oldfile) = tempfile.mkstemp(dir=tempdir)
f = os.fdopen(fd, w+b)
f.write(convert_line_endings(file))
f.close()

But here, I dont see in the logs related to custom module debug messages.
Next to that, it is doing patch and then expetion is raised.

Logs:
2014-09-13 01:57:14,292 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Generating diff file info for diffset id 5, filediff 5 took 0.003863 
seconds
2014-09-13 01:57:14,292 - DEBUG -  - Cache miss for key 
diff-sidebyside-hl-5-en.
2014-09-13 01:57:14,295 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Begin: Patching file testfile
2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- End: Patching file testfile
2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Patching file testfile took 0.012399 seconds
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Begin: Generating diff file info for diffset id 5, filediff 5
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- End: Generating diff file info for diffset id 5, filediff 5
2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ 
- Generating diff file info for diffset id 5, filediff 5 took 0.000472 
seconds


Pls. help to resolve the issue.

Thanks,
Jes






On Sunday, September 14, 2014 11:48:20 PM UTC+5:30, David Trowbridge wrote:

 You should not be looking at the RBTools code for this. RBTools is for the 
 client-side command line tools.

 The server-side code for communicating with repositories lives in 
 reviewboard/scmtools. The function for returning the original version of 
 the file is called get_file().

 -David



 On Sun, Sep 14, 2014 at 11:15 AM, ch.je...@gmail.com javascript: 
 wrote:

 Thanks David.
 I tried to go through all supported clients like CVS/ClearCase(class 
 CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)

 Which function in this class is really returning the original version or 
 modified version of file.
 From all the Client classes, I could see that diff function is overwitten 
 and it is returing the difference between files.
 But which is the function that returns the original/modified file?

 Also post-review or rbt post is not used with revisions in the 
 customnized CMVC client, hence no need to have parse_revision_spec and
 need not consider revisions right? It would also have revisions as zero.

 Pls. help, which class can be taken as a reference to fix issues with 
 customized class.
 tmppg8GFU should contain original file and tmppg8GFU.new should contain 
 modified file?

 Thanks,
 Jes. 
  

 On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge wrote:

 The tmppg8GFU file should be the original version of the file being 
 patched. Given that this is empty, I believe that there is a bug in your 
 cvmc SCMTool implementation.

 -David

 On Sat, Sep 13, 2014 at 10:23 AM, ch.je...@gmail.com wrote:

 Hi David,
 IT is a customized control system, cmvc.

 Diff is properly generated in the debug files. tmppg8GFU-new.rej file 
 and test.diff.

 But it is unable to post the diff to server. Screen is showing 
 following error:


 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data 

Re: view difff generates error: There was an error displaying this diff.

2014-09-14 Thread David Trowbridge
Are you doing this with a development install or in production? If the latter, 
you'll need to reload the web server and clear your cache (probably memcached) 
before running with new code.

-David

 On Sep 14, 2014, at 1:27 PM, ch.jeski...@gmail.com wrote:
 
 Thanks David,
 
 I did more debugging.
 cmvc.py has the function:
 
 def get_file(self, path, revision=HEAD):
 logging.debug(CMVC File invoked  %s %s % (filename, 
 revision ))
 if not path:
 raise FileNotFoundError(path, revision)
 return self.client.cat_file(path, revision)
 
 
 I also added debug statement, but the log file is not having any custom 
 defined debug entries. Does it mean that function is not invoked?
 At line, 100 od diffutils.py code is related to old file
 (fd, oldfile) = tempfile.mkstemp(dir=tempdir)
 f = os.fdopen(fd, w+b)
 f.write(convert_line_endings(file))
 f.close()
 
 But here, I dont see in the logs related to custom module debug messages.
 Next to that, it is doing patch and then expetion is raised.
 
 Logs:
 2014-09-13 01:57:14,292 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 Generating diff file info for diffset id 5, filediff 5 took 0.003863 seconds
 2014-09-13 01:57:14,292 - DEBUG -  - Cache miss for key 
 diff-sidebyside-hl-5-en.
 2014-09-13 01:57:14,295 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 Begin: Patching file testfile
 2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 End: Patching file testfile
 2014-09-13 01:57:14,308 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 Patching file testfile took 0.012399 seconds
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 Begin: Generating diff file info for diffset id 5, filediff 5
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 End: Generating diff file info for diffset id 5, filediff 5
 2014-09-13 01:57:14,309 - DEBUG - None - testuser - /r/7/diff/1/fragment/5/ - 
 Generating diff file info for diffset id 5, filediff 5 took 0.000472 seconds
 
 
 Pls. help to resolve the issue.
 
 Thanks,
 Jes
 
 
 
 
 
 
 On Sunday, September 14, 2014 11:48:20 PM UTC+5:30, David Trowbridge wrote:
 You should not be looking at the RBTools code for this. RBTools is for the 
 client-side command line tools.
 
 The server-side code for communicating with repositories lives in 
 reviewboard/scmtools. The function for returning the original version of the 
 file is called get_file().
 
 -David
 
 
 
 On Sun, Sep 14, 2014 at 11:15 AM, ch.je...@gmail.com wrote:
 Thanks David.
 I tried to go through all supported clients like CVS/ClearCase(class 
 CVSClient(SCMClient): , class ClearCaseClient(SCMClient):)
 
 Which function in this class is really returning the original version or 
 modified version of file.
 From all the Client classes, I could see that diff function is overwitten 
 and it is returing the difference between files.
 But which is the function that returns the original/modified file?
 
 Also post-review or rbt post is not used with revisions in the customnized 
 CMVC client, hence no need to have parse_revision_spec and
 need not consider revisions right? It would also have revisions as zero.
 
 Pls. help, which class can be taken as a reference to fix issues with 
 customized class.
 tmppg8GFU should contain original file and tmppg8GFU.new should contain 
 modified file?
 
 Thanks,
 Jes. 
  
 
 On Sunday, September 14, 2014 1:41:14 AM UTC+5:30, David Trowbridge wrote:
 The tmppg8GFU file should be the original version of the file being 
 patched. Given that this is empty, I believe that there is a bug in your 
 cvmc SCMTool implementation.
 
 -David
 
 On Sat, Sep 13, 2014 at 10:23 AM, ch.je...@gmail.com wrote:
 Hi David,
 IT is a customized control system, cmvc.
 
 Diff is properly generated in the debug files. tmppg8GFU-new.rej file and 
 test.diff.
 
 But it is unable to post the diff to server. Screen is showing following 
 error:
 
 
 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = 

Re: view difff generates error: There was an error displaying this diff.

2014-09-13 Thread David Trowbridge
The tmppg8GFU file should be the original version of the file being
patched. Given that this is empty, I believe that there is a bug in your
cvmc SCMTool implementation.

-David

On Sat, Sep 13, 2014 at 10:23 AM, ch.jeski...@gmail.com wrote:

 Hi David,
 IT is a customized control system, cmvc.

 Diff is properly generated in the debug files. tmppg8GFU-new.rej file and
 test.diff.

 But it is unable to post the diff to server. Screen is showing following
 error:


 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 152, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 160, in _get_chunks_uncached
 new = get_patched_file(old, self.filediff, self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 201, in get_patched_file
 return patch(diff, buffer, filediff.dest_file, request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 139, in patch
 'output': stderr,
 Exception: The patch to 'test' didn't apply cleanly. The temporary files have 
 been left in '/tmp/reviewboard.axR11W' for debugging purposes.
 `patch` returned:


 what is the meaning of patch error?
 How to resolve this?
 tmppg8GFU and tmppg8GFU-new files are empty in the debug directory.
 what supposed be contents of these files?
 Pls. help

 Thanks,
 Jes .


 On Saturday, September 13, 2014 3:25:42 AM UTC+5:30, David Trowbridge
 wrote:

 Is the tmppg8GFU file what you'd expect? (the pre-patched file contents)

 What version control system?

 -David

 On Fri, Sep 12, 2014 at 11:25 AM, ch.je...@gmail.com wrote:

 Hi,
 Using reviewboard 2.0.6 and RBTools 0.6.2.
 post-review worked fine and generated a new request.
 When I looked into view diff for the request, it is failing.

 details error:

 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 152, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 160, in _get_chunks_uncached
 new = get_patched_file(old, self.filediff, 

view difff generates error: There was an error displaying this diff.

2014-09-12 Thread ch . jeskiran
Hi,
Using reviewboard 2.0.6 and RBTools 0.6.2.
post-review worked fine and generated a new request.
When I looked into view diff for the request, it is failing.

details error:

Traceback (most recent call last):
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
 line 236, in get
renderer = self.create_renderer(context, *args, **kwargs)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
 line 1088, in create_renderer
*args, **kwargs)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
 line 328, in create_renderer
self.diff_file = self._get_requested_diff_file()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
 line 369, in _get_requested_diff_file
request=self.request)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 373, in populate_diff_chunks
chunks = generator.get_chunks()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 153, in get_chunks
large_data=True)
  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
 line 109, in cache_memoize
data = lookup_callable()
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 152, in lambda
lambda: list(self._get_chunks_uncached()),
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
 line 160, in _get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 201, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
 line 139, in patch
'output': stderr,
Exception: The patch to 'test' didn't apply cleanly. The temporary files have 
been left in '/tmp/reviewboard.axR11W' for debugging purposes.
`patch` returned: 


ls /tmp/reviewboard.axR11W
tmppg8GFU  tmppg8GFU-new  tmppg8GFU-new.rej test.diff

diff is generated properly in the files. tmppg8GFU-new.rej file and 
test.diff has proper differences.

Pls. help.

Thanks,
Jes 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: view difff generates error: There was an error displaying this diff.

2014-09-12 Thread David Trowbridge
Is the tmppg8GFU file what you'd expect? (the pre-patched file contents)

What version control system?

-David

On Fri, Sep 12, 2014 at 11:25 AM, ch.jeski...@gmail.com wrote:

 Hi,
 Using reviewboard 2.0.6 and RBTools 0.6.2.
 post-review worked fine and generated a new request.
 When I looked into view diff for the request, it is failing.

 details error:

 Traceback (most recent call last):
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 236, in get
 renderer = self.create_renderer(context, *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py,
  line 1088, in create_renderer
 *args, **kwargs)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 328, in create_renderer
 self.diff_file = self._get_requested_diff_file()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py,
  line 369, in _get_requested_diff_file
 request=self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 373, in populate_diff_chunks
 chunks = generator.get_chunks()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 153, in get_chunks
 large_data=True)
   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py,
  line 109, in cache_memoize
 data = lookup_callable()
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 152, in lambda
 lambda: list(self._get_chunks_uncached()),
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,
  line 160, in _get_chunks_uncached
 new = get_patched_file(old, self.filediff, self.request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 201, in get_patched_file
 return patch(diff, buffer, filediff.dest_file, request)
   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py,
  line 139, in patch
 'output': stderr,
 Exception: The patch to 'test' didn't apply cleanly. The temporary files have 
 been left in '/tmp/reviewboard.axR11W' for debugging purposes.
 `patch` returned:


 ls /tmp/reviewboard.axR11W
 tmppg8GFU  tmppg8GFU-new  tmppg8GFU-new.rej test.diff

 diff is generated properly in the files. tmppg8GFU-new.rej file and
 test.diff has proper differences.

 Pls. help.

 Thanks,
 Jes

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-07-10 Thread reviewboard


Comment #7 on issue 3398 by trowb...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

Are the contents of the file that it's trying to patch what you expect?  
Sometimes hosting services will return an HTTP 200 but the contents will be  
a random HTML page with errors, rather than the desired file.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Getting an error There was an error displaying this diff while doing diff in review request.

2014-07-09 Thread Nitish Gangal
Hi Christian,

Thanks for your reply.
As you suggested I tried using RBtools and post command to create a review 
request like:

rbt post --server=http://10.0.14.29 -d

But, I got 500 as a response.
Detailed error is as follows:

 Got HTTP error: 500: !DOCTYPE html

html
 head
  title500 - Internal Server Error | Review Board/title
 /head
 body
  h1Something broke! (Error 500)/h1
  p
   It appears something broke when you tried to go to here. This is either
   a bug in Review Board or a server configuration error. Please report
   this to your administrator.
  /p
 /body
/title

Traceback (most recent call last):
  File /usr/local/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
  File 
/usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/main.py,
 
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/__init__.py,
 
line 416, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
 
line 784, in main
submit_as=self.options.submit_as)
  File 
/usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
 
line 507, in post_request
raise CommandError(Error creating review request: %s % e)
rbtools.commands.CommandError: Error creating review request: HTTP 500


I also, tried to look at files inside temp directory.
But, no error log was seen there.

Request you to please help me out as I am completely stuck with it.

Thanks,
Nitish Gangal


On Tuesday, July 8, 2014 11:46:29 PM UTC+5:30, Christian Hammond wrote:

 Hi Nitish,

 Can you try using RBTools to post the diff?

 Also, look in that temp directory for the source file and .rej file, see 
 if anything stands out.

 Christian


 On Tuesday, July 8, 2014, Nitish Gangal nitish...@gmail.com javascript: 
 wrote:

 Hi All,

 I am using reviewboard-2.0.2. I have added one gitlab repository for my 
 project.
 Now, I am creating a diff file on my cloned code repository, using 
 following command:

 git diff --full-index  master6.patch

 This, master6.patch file, I am uploading while creating review request. 
 In this case, my review request gets created successfully.
 Now, when I click on 'view diff' link, then I am getting following error 
 continuously:

 There was an error displaying this diff. 

 The patch to 'abcProject/d.rb' didn't apply cleanly. The temporary files 
 have been left in '/tmp/reviewboard.RHA9Qh' for debugging purposes. `patch` 
 returned: 

 This may be a bug in the software, a temporary outage, or an issue with 
 the format of your diff. 

 Please try again, and if you still have trouble, contact support 
 http://10.0.14.29/support/.

 I am struggling to resolve this issue since long.

 Request you to please provide me some pointers in order to resolve the 
 issue.

 Awaiting for your positive reply,

 Thanks,

 Nitish Gangal



  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 -- 
 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Getting an error There was an error displaying this diff while doing diff in review request.

2014-07-09 Thread Nitish Gangal
Hey Christian,

I resolved the issue mentioned in my previous comment. It was because I had 
two repositories added with same mirror path. I rectified it.

So, now using rbt post --server=http://10.0.14.29 -d, I am able to 
successfully create a review request. 

Still, when I click on 'view diff' link, I get the same error mentioned in 
my first post as:
There was an error displaying this diff. 
Also, in my logs folder of reviewboard site, logs are not getting 
generated. So, I am not able to see any error log.

Please advise.

Thanks,
Nitish Gangal
 


On Wednesday, July 9, 2014 5:08:07 PM UTC+5:30, Nitish Gangal wrote:

 Hi Christian,

 Thanks for your reply.
 As you suggested I tried using RBtools and post command to create a review 
 request like:

 rbt post --server=http://10.0.14.29 -d

 But, I got 500 as a response.
 Detailed error is as follows:

  Got HTTP error: 500: !DOCTYPE html

 html
  head
   title500 - Internal Server Error | Review Board/title
  /head
  body
   h1Something broke! (Error 500)/h1
   p
It appears something broke when you tried to go to here. This is either
a bug in Review Board or a server configuration error. Please report
this to your administrator.
   /p
  /body
 /title

 Traceback (most recent call last):
   File /usr/local/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
   File 
 /usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/main.py,
  
 line 134, in main
 command.run_from_argv([RB_MAIN, command_name] + args)
   File 
 /usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/__init__.py,
  
 line 416, in run_from_argv
 exit_code = self.main(*args) or 0
   File 
 /usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
  
 line 784, in main
 submit_as=self.options.submit_as)
   File 
 /usr/local/lib/python2.7/dist-packages/RBTools-0.6.2-py2.7.egg/rbtools/commands/post.py,
  
 line 507, in post_request
 raise CommandError(Error creating review request: %s % e)
 rbtools.commands.CommandError: Error creating review request: HTTP 500


 I also, tried to look at files inside temp directory.
 But, no error log was seen there.

 Request you to please help me out as I am completely stuck with it.

 Thanks,
 Nitish Gangal


 On Tuesday, July 8, 2014 11:46:29 PM UTC+5:30, Christian Hammond wrote:

 Hi Nitish,

 Can you try using RBTools to post the diff?

 Also, look in that temp directory for the source file and .rej file, see 
 if anything stands out.

 Christian


 On Tuesday, July 8, 2014, Nitish Gangal nitish...@gmail.com wrote:

 Hi All,

 I am using reviewboard-2.0.2. I have added one gitlab repository for my 
 project.
 Now, I am creating a diff file on my cloned code repository, using 
 following command:

 git diff --full-index  master6.patch

 This, master6.patch file, I am uploading while creating review request. 
 In this case, my review request gets created successfully.
 Now, when I click on 'view diff' link, then I am getting following error 
 continuously:

 There was an error displaying this diff. 

 The patch to 'abcProject/d.rb' didn't apply cleanly. The temporary files 
 have been left in '/tmp/reviewboard.RHA9Qh' for debugging purposes. `patch` 
 returned: 

 This may be a bug in the software, a temporary outage, or an issue with 
 the format of your diff. 

 Please try again, and if you still have trouble, contact support 
 http://10.0.14.29/support/.

 I am struggling to resolve this issue since long.

 Request you to please provide me some pointers in order to resolve the 
 issue.

 Awaiting for your positive reply,

 Thanks,

 Nitish Gangal



  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 -- 
 -- 
 Christian Hammond - chri...@beanbaginc.com
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Getting an error There was an error displaying this diff while doing diff in review request.

2014-07-08 Thread Nitish Gangal
Hi All,

I am using reviewboard-2.0.2. I have added one gitlab repository for my 
project.
Now, I am creating a diff file on my cloned code repository, using 
following command:

git diff --full-index  master6.patch

This, master6.patch file, I am uploading while creating review request. In 
this case, my review request gets created successfully.
Now, when I click on 'view diff' link, then I am getting following error 
continuously:

There was an error displaying this diff. 

The patch to 'abcProject/d.rb' didn't apply cleanly. The temporary files 
have been left in '/tmp/reviewboard.RHA9Qh' for debugging purposes. `patch` 
returned: 

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff. 

Please try again, and if you still have trouble, contact support 
http://10.0.14.29/support/.

I am struggling to resolve this issue since long.

Request you to please provide me some pointers in order to resolve the 
issue.

Awaiting for your positive reply,

Thanks,

Nitish Gangal



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Getting an error There was an error displaying this diff while doing diff in review request.

2014-07-08 Thread Christian Hammond
Hi Nitish,

Can you try using RBTools to post the diff?

Also, look in that temp directory for the source file and .rej file, see if
anything stands out.

Christian


On Tuesday, July 8, 2014, Nitish Gangal nitishgan...@gmail.com wrote:

 Hi All,

 I am using reviewboard-2.0.2. I have added one gitlab repository for my
 project.
 Now, I am creating a diff file on my cloned code repository, using
 following command:

 git diff --full-index  master6.patch

 This, master6.patch file, I am uploading while creating review request. In
 this case, my review request gets created successfully.
 Now, when I click on 'view diff' link, then I am getting following error
 continuously:

 There was an error displaying this diff.

 The patch to 'abcProject/d.rb' didn't apply cleanly. The temporary files
 have been left in '/tmp/reviewboard.RHA9Qh' for debugging purposes. `patch`
 returned:

 This may be a bug in the software, a temporary outage, or an issue with
 the format of your diff.

 Please try again, and if you still have trouble, contact support
 http://10.0.14.29/support/.

 I am struggling to resolve this issue since long.

 Request you to please provide me some pointers in order to resolve the
 issue.

 Awaiting for your positive reply,

 Thanks,

 Nitish Gangal



  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com
 javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');
 .
 For more options, visit https://groups.google.com/d/optout.



-- 
-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-06-16 Thread reviewboard


Comment #6 on issue 3398 by nick.ind...@gmail.com: Error displaying this  
diff

http://code.google.com/p/reviewboard/issues/detail?id=3398

Issue resolved: I included the original diff as the parent diff, and  
suddenly everything worked.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-06-07 Thread reviewboard

Updates:
Status: NeedInfo

Comment #4 on issue 3398 by trowb...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3398 in reviewboard: Error displaying this diff

2014-06-04 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3398 by hith...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

What version are you running? 2,0,1


What's the URL of the page containing the problem? r/218/diff/#


What steps will reproduce the problem?
1. Manually upload a diff
2. Go to diff section in review request
3. See There was an error displaying this diff.
Traceback (most recent call last):
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,  
line 236, in get

renderer = self.create_renderer(context, *args, **kwargs)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py,  
line 1102, in create_renderer

*args, **kwargs)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,  
line 326, in create_renderer

self.diff_file = self._get_requested_diff_file()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py,  
line 367, in _get_requested_diff_file

request=self.request)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,  
line 373, in populate_diff_chunks

chunks = generator.get_chunks()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,  
line 148, in get_chunks

large_data=True)
   
File /usr/local/lib/python2.7/dist-packages/Djblets-0.8-py2.7.egg/djblets/cache/backend.py,  
line 109, in cache_memoize

data = lookup_callable()
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,  
line 147, in lambda

lambda: list(self._get_chunks_uncached()),
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py,  
line 155, in _get_chunks_uncached

new = get_patched_file(old, self.filediff, self.request)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,  
line 201, in get_patched_file

return patch(diff, buffer, filediff.dest_file, request)
   
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py,  
line 139, in patch

'output': stderr,
Exception: The patch  
to 'python/biicode/client/test/integration/publish/simple_publish_test.py'  
didn't apply cleanly. The temporary files have been left  
in '/tmp/reviewboard.eEHskq' for debugging purposes.

`patch` returned:

What is the expected output? What do you see instead? The diff I uploaded,  
as it is



What operating system are you using? Ubuntu 12.04 for the server, accessing  
from Mac or win  What browser? Chrome



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-06-04 Thread reviewboard


Comment #1 on issue 3398 by chip...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

You'll need to talk to your administrator about this. There's nothing we  
can do without the diff.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-06-04 Thread reviewboard


Comment #2 on issue 3398 by hith...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

I'm my administrator, I don't know whats speciall about that diff and is  
happening with others as well


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3398 in reviewboard: Error displaying this diff

2014-06-04 Thread reviewboard


Comment #3 on issue 3398 by chip...@gmail.com: Error displaying this diff
http://code.google.com/p/reviewboard/issues/detail?id=3398

Okay, my apologies. We get these questions a lot on here and they're  
usually from general users on a server.


First thing to check is the files in the temp directory provided in that  
error. See if the diff looks correct, and whether the source file looks  
correct. Check the .rej file to see what failed to patch. You can also copy  
those files and attempt to patch the source file with the patch in the  
directory and see what patch says.


These issues are often things like mixed line endings or some strangely  
generated patch, or sometimes an issue with what's returned from the  
repository (depending on how it's accessed and what type of repository).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.