Re: Review Request 47053: Windows: [2/2] Used `os::random`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47053/
---

(Updated May 12, 2016, 5:56 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [2/2] Used `os::random`.


Diffs (updated)
-

  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/log/consensus.cpp 67bd30b2abcefa0c598c54311bf8659ed4afa0c2 
  src/log/recover.cpp eaa001e1284efdbb2c7a2a6cc94496992555fd24 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/slave/slave.cpp feb9f291b4188aac1a63ab9cfae8349a048663b1 

Diff: https://reviews.apache.org/r/47053/diff/


Testing
---

OSX: make
Windows: msbuild


Thanks,

Daniel Pravat

Re: Review Request 47198: Added labels to docker v1 spec config.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47198/#review132823
---




include/mesos/docker/v1.proto (lines 53 - 54)


I don't think you need this comment. To me `mesos` labels are completely 
independent from `docker` labels (even though they happen to have similar 
signatures).



include/mesos/docker/v1.proto (lines 60 - 63)


I still don't understand this comment.

Are you saying that all of the other fields in this protobuf can be parsed 
automatically, but this field is special and cannot?

If so, what makes it special, and why can't it be parsed automatically like 
the others?  That's what would be more interesting to me in the comment.


- Kevin Klues


On May 12, 2016, 3:56 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47198/
> ---
> 
> (Updated May 12, 2016, 3:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
> Klues.
> 
> 
> Bugs: MESOS-5272
> https://issues.apache.org/jira/browse/MESOS-5272
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added labels to docker v1 spec config.
> 
> 
> Diffs
> -
> 
>   include/mesos/docker/v1.proto ff18f8cadfce3315467f194d50d3469fa839f686 
> 
> Diff: https://reviews.apache.org/r/47198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47287: Fixed compilation error caused by prctl and recent subprocess change.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47287/#review132820
---


Ship it!




Ship It!

- Alex Clemmer


On May 12, 2016, 5:12 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47287/
> ---
> 
> (Updated May 12, 2016, 5:12 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Added missing `#include sys/prctl.h`.
> - Replaced `close` with `::close`.
> - Fixed sign-mismatch comparison.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 
> 70794926a99ca0eccebfe01106cc0f11c842ca58 
> 
> Diff: https://reviews.apache.org/r/47287/diff/
> 
> 
> Testing
> ---
> 
> Local build succeeds.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 47287: Fixed compilation error caused by prctl and recent subprocess change.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47287/
---

Review request for mesos, Alex Clemmer and Michael Park.


Repository: mesos


Description
---

- Added missing `#include sys/prctl.h`.
- Replaced `close` with `::close`.
- Fixed sign-mismatch comparison.


Diffs
-

  3rdparty/libprocess/include/process/posix/subprocess.hpp 
70794926a99ca0eccebfe01106cc0f11c842ca58 

Diff: https://reviews.apache.org/r/47287/diff/


Testing
---

Local build succeeds.


Thanks,

Kapil Arya

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 12, 2016, 1:05 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 604
> > 
> >
> > This test may fail on CentOS 7, please refer to 
> > https://reviews.apache.org/r/44985/ and 
> > https://issues.apache.org/jira/browse/MESOS-4810
> 
> Shuai Lin wrote:
> It's a bit awkward to use redirection if I use shell=false for the 
> `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it 
> would work. Can you give it a try on centos?
> 
> Guangya Liu wrote:
> It will not work if you do not set shell as false, the reason is that 
> your command will be run as `sh -c command` and `sh` cannot be found.
> 
> I did some test with your patch on centos 7, failed as expected.
> 
> I0512 00:05:14.570722  2907 exec.cpp:535] Executor sending status update 
> TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
> cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
> 3d0009ac-5e31-41eb-a98a-db83e50a30bc-
> I0512 00:05:14.571805  2838 slave.cpp:3221] Handling status update 
> TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
> cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
> 3d0009ac-5e31-41eb-a98a-db83e50a30bc- from executor(1)@9.21.51.124:54983
> sh -c '/bin/echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt'
> Failed to exec: No such file or directory

Thanks, I'll fix it then.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
---


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 604
> > 
> >
> > This test may fail on CentOS 7, please refer to 
> > https://reviews.apache.org/r/44985/ and 
> > https://issues.apache.org/jira/browse/MESOS-4810
> 
> Shuai Lin wrote:
> It's a bit awkward to use redirection if I use shell=false for the 
> `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it 
> would work. Can you give it a try on centos?

It will not work if you do not set shell as false, the reason is that your 
command will be run as `sh -c command` and `sh` cannot be found.

I did some test with your patch on centos 7, failed as expected.

I0512 00:05:14.570722  2907 exec.cpp:535] Executor sending status update 
TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc-
I0512 00:05:14.571805  2838 slave.cpp:3221] Handling status update TASK_RUNNING 
(UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc- from executor(1)@9.21.51.124:54983
sh -c '/bin/echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt'
Failed to exec: No such file or directory


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
---


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47199/
---

(Updated May 11, 2016, 8:56 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-5272
https://issues.apache.org/jira/browse/MESOS-5272


Repository: mesos


Description
---

Implemented parsing docker labels in v1 spec.


Diffs (updated)
-

  src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 

Diff: https://reviews.apache.org/r/47199/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47198: Added labels to docker v1 spec config.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47198/
---

(Updated May 11, 2016, 8:56 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-5272
https://issues.apache.org/jira/browse/MESOS-5272


Repository: mesos


Description
---

Added labels to docker v1 spec config.


Diffs (updated)
-

  include/mesos/docker/v1.proto ff18f8cadfce3315467f194d50d3469fa839f686 

Diff: https://reviews.apache.org/r/47198/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47200: Modified docker spec test for docker label support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47200/
---

(Updated May 11, 2016, 8:56 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-5272
https://issues.apache.org/jira/browse/MESOS-5272


Repository: mesos


Description
---

Modified docker spec test for docker label support.


Diffs (updated)
-

  src/tests/containerizer/docker_spec_tests.cpp 
796b020f58f8451362bc1357ab6d7ceb4e946b3c 

Diff: https://reviews.apache.org/r/47200/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 47285: CMake:[2/2] Added support for new `3rdparty/` directory structure.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47285/
---

Review request for mesos, Joris Van Remoortere, Kapil Arya, and Michael Park.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

CMake:[2/2] Added support for new `3rdparty/` directory structure.


Diffs
-

  3rdparty/CMakeLists.txt 7ff10d52c99a796f6286d3e70e77afbdb6a1e5e8 
  CMakeLists.txt a5f7da7048e890894d11ad16ff96018b37643a16 
  src/slave/cmake/FindCurl.cmake df81fd538b06bf0c3e842a502bd5ef4083d897b5 

Diff: https://reviews.apache.org/r/47285/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 47284: CMake:[1/2] Added support for new `3rdparty/` directory structure.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47284/
---

Review request for mesos, Joris Van Remoortere, Kapil Arya, and Michael Park.


Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250


Repository: mesos


Description
---

CMake:[1/2] Added support for new `3rdparty/` directory structure.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
3b0c7eddf31ccd257a98e04d0cf81b89188c8371 
  3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
ac75baf3c660f2bdda308f4eaa856f44d80f1ea1 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
83afd2514e706f48039cad0af98038d3cd3c48bc 
  3rdparty/libprocess/cmake/macros/External.cmake 
e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/47284/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47266/#review132806
---



Patch looks great!

Reviews applied: [47265, 47266]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 10:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47266/
> ---
> 
> (Updated May 11, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-5277
> https://issues.apache.org/jira/browse/MESOS-5277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented provisioner removing docker whitelist files.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
> 
> Diff: https://reviews.apache.org/r/47266/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tested with docker image containing `.wh.` files.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 47281: Mesos::master::allocation namespace removed.

[Jose Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/
---

Review request for mesos.


Bugs: MESOS-2516
https://issues.apache.org/jira/browse/MESOS-2516


Repository: mesos


Description
---

To keep consistence with the rest of the codebase, the allocation
namespace has been removed from mesos::master namespace. To not
pollute the master namespace, sorters have been moved to the new
mesos::master::sorter namespace

MESOS-2516


Diffs
-

  docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
51125bac62735879f66234765dad92a759f6724b 
  src/master/allocator/mesos/metrics.hpp 
06fdd1633f63c005230e1cc5fafdad358a0ac254 
  src/master/allocator/mesos/metrics.cpp 
a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
c793f3216287fd40998a1d4aab016d55aa1ac151 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
  src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
  src/tests/fault_tolerance_tests.cpp c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
  src/tests/hierarchical_allocator_tests.cpp 
e6101fdffe5e340619d79d821a2f5f891cb2dec7 
  src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
  src/tests/master_authorization_tests.cpp 
804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
  src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 

Diff: https://reviews.apache.org/r/47281/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 12, 2016, 1:42 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

address review comments


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132207
---


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On May 9, 2016, 5:59 a.m., Guangya Liu wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1065
> > 
> >
> > s/SandboxEnv/ContainerSandboxEnv ?

I prefer `MesosSandboxEnv`, since that's what's being tested.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132207
---


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated May 12, 2016, 1:38 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 1:37 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
  3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46622: Added tests for flag aliases.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/
---

(Updated May 12, 2016, 1:36 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

added a test case for alias usage.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added tests for flag aliases.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
66e16abe914e2a1ee7599bab857ff478b7ec20dc 

Diff: https://reviews.apache.org/r/46622/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46621: Added alias support for flags.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/
---

(Updated May 12, 2016, 1:36 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

mpark's and greg's comments. NNFR.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

This lets a user to load a flag either by the original name or an
alias.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46621/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/
---

(Updated May 12, 2016, 1:33 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

mpark's comments. NNFR.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

This sets up the stage to add metadata to the name (e.g., deprecated).
This will be used to add deprecation support subsequently.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/46620/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47274/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Authorize what quota can be seen by GET_QUOTA_BY_ROLE.


Diffs
-

  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
  src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 

Diff: https://reviews.apache.org/r/47274/diff/


Testing
---

Unit test.


Thanks,

Zhitao Li

Re: Review Request 47200: Modified docker spec test for docker label support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47200/#review132798
---



Patch looks great!

Reviews applied: [47198, 47199, 47200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 4:29 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47200/
> ---
> 
> (Updated May 11, 2016, 4:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
> Klues.
> 
> 
> Bugs: MESOS-5272
> https://issues.apache.org/jira/browse/MESOS-5272
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified docker spec test for docker label support.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> 796b020f58f8451362bc1357ab6d7ceb4e946b3c 
> 
> Diff: https://reviews.apache.org/r/47200/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47028: Fixed a confusing log line in the allocator.

[Jiang Yan Xu]

> On May 11, 2016, 5 p.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1488
> > 
> >
> > How about "No allocations performed"? It is a bit odd to refer to 
> > offers here since we don't know about offers in the allocator currently.

Will use yours. My goal is for it to not say "no resources available". :)


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47028/#review132795
---


On May 11, 2016, 10:58 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47028/
> ---
> 
> (Updated May 11, 2016, 10:58 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When there is no offer to send out at the end of an allocation run it
> could be entirely possible that it's because all framworks have
> suppressed or filtered offers. "No offers to send out!" simply states
> the case.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 0de03c7347e01fde2b42f5ec38a34a62edf642a1 
> 
> Diff: https://reviews.apache.org/r/47028/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/
---

(Updated May 12, 2016, 12:19 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Libprocess: Implemented `subprocess_windows.cpp`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46608/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47028: Fixed a confusing log line in the allocator.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47028/#review132795
---


Ship it!





src/master/allocator/mesos/hierarchical.cpp (line 1488)


How about "No allocations performed"? It is a bit odd to refer to offers 
here since we don't know about offers in the allocator currently.


- Ben Mahler


On May 11, 2016, 5:58 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47028/
> ---
> 
> (Updated May 11, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When there is no offer to send out at the end of an allocation run it
> could be entirely possible that it's because all framworks have
> suppressed or filtered offers. "No offers to send out!" simply states
> the case.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 0de03c7347e01fde2b42f5ec38a34a62edf642a1 
> 
> Diff: https://reviews.apache.org/r/47028/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 47001: Fix race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47001/#review132792
---


Ship it!




Ship It!

- Jiang Yan Xu


On May 4, 2016, 9:15 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47001/
> ---
> 
> (Updated May 4, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5308
> https://issues.apache.org/jira/browse/MESOS-5308
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are two race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.
> The first is when we were checking the disk resources consumed
> without knowing whether the dd command had completed. We can just
> eliminate this check since other tests cover the resource usage
> case. The second race was installing the
> MesosContainerizerProcess::___recover expectation after starting
> the slave. We need to install this before starting.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 61ea2e55e5c71cb10f6c84d23c205169567e8c96 
> 
> Diff: https://reviews.apache.org/r/47001/diff/
> 
> 
> Testing
> ---
> 
> Fedora 23.
> 
> $ mesos-tests --gtest_filter=ROOT_XFS_QuotaTest.NoCheckpointRecovery 
> --gtest_repeat=1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47260/#review132788
---




src/tests/hierarchical_allocator_tests.cpp (line 2311)


s/ReviveAndSuppress/SuppressAndReviveOffers



src/tests/hierarchical_allocator_tests.cpp (line 2348)


I think this comments is not needed as the function is self explained.



src/tests/hierarchical_allocator_tests.cpp (line 2363)


You did not `active` a framework but only `revive` offers.

s/after getting activated/after reviving offers


- Guangya Liu


On May 11, 2016, 9:15 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47260/
> ---
> 
> (Updated May 11, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos and Dario Rexin.
> 
> 
> Bugs: MESOS-5279
> https://issues.apache.org/jira/browse/MESOS-5279
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'ReviveAndSuppress' test for the allocator.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> e6101fdffe5e340619d79d821a2f5f891cb2dec7 
> 
> Diff: https://reviews.apache.org/r/47260/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 46038: Added recommended production config to the docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/#review132777
---


Ship it!




Ship It!

- Vinod Kone


On April 11, 2016, 10:57 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46038/
> ---
> 
> (Updated April 11, 2016, 10:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provided information in the operational guide on what
> configuration options are advisable for production
> environments.
> 
> 
> Diffs
> -
> 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46038/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container:
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46104: Made use of random container IDs in tests.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/#review132775
---


Ship it!




Ship It!

- Vinod Kone


On April 12, 2016, 5:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46104/
> ---
> 
> (Updated April 12, 2016, 5:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos containerizer tests previously used a fixed
> container ID; this patch makes use of a random UUID
> instead.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
> 
> Diff: https://reviews.apache.org/r/46104/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review132774
---


Ship it!




Ship It!

- Vinod Kone


On May 7, 2016, 1:29 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated May 7, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent
> with the `work_dir` located in a subdirectory of `/tmp`. This patch
> adds language to the `work_dir` help strings and configuration docs
> advising users to avoid the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46004: Updated master '--work_dir' help string.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46004/#review132772
---


Ship it!




Ship It!

- Vinod Kone


On May 7, 2016, 1:29 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46004/
> ---
> 
> (Updated May 7, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds language to the master's `--work_dir` help string which advises
> users to avoid locations in '/tmp' when setting the work directory.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46004/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46003: Removed the default value for agent work_dir.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46003/#review132771
---




src/local/local.cpp (line 348)


s/workDirTry/mkdir/



src/tests/containerizer/mesos_containerizer_tests.cpp (lines 115 - 122)


it would be nice to create the temp directory inside the sandbox.

Try workDirectory = os::mkdir("./work_dir");

alternatively, we can add a mkdtemp() method to the TemporaryDirectoryTest 
fixture that gives us a temporary directory inside the sandbox.



src/tests/containerizer/mesos_containerizer_tests.cpp (line 410)


ditto. create temp inside sandbox. see above.


- Vinod Kone


On May 7, 2016, 1:28 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46003/
> ---
> 
> (Updated May 7, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The default value for the agent's `--work_dir` flag was removed, the
> type of the parameter was changed to `Option`, and code was
> added to explicitly set the work directory when necessary.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
> 
> Diff: https://reviews.apache.org/r/46003/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 47265: Fixed provisioner parameter naming.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47265/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed provisioner parameter naming.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 

Diff: https://reviews.apache.org/r/47265/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 47266: Implemented provisioner removing docker whitelist files.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47266/
---

Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
Timothy Chen.


Bugs: MESOS-5277
https://issues.apache.org/jira/browse/MESOS-5277


Repository: mesos


Description
---

Implemented provisioner removing docker whitelist files.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 

Diff: https://reviews.apache.org/r/47266/diff/


Testing
---

make check

Tested with docker image containing `.wh.` files.


Thanks,

Gilbert Song

Re: Review Request 47268: Introduced timeout for docker volume driver client mount/unmount.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47268/#review132770
---


Ship it!




Ship It!

- Gilbert Song


On May 11, 2016, 3:32 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47268/
> ---
> 
> (Updated May 11, 2016, 3:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Guangya Liu.
> 
> 
> Bugs: MESOS-5365
> https://issues.apache.org/jira/browse/MESOS-5365
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced timeout for docker volume driver client mount/unmount.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> 9329a9b8bbdd60e11a25e87dab50ec80ea522c1b 
> 
> Diff: https://reviews.apache.org/r/47268/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 47078: Added checking for required flags to FlagsBase.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47078/#review132768
---



Can you add a test for this?

- Vinod Kone


On May 7, 2016, 1:27 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47078/
> ---
> 
> (Updated May 7, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checking for required flags to FlagsBase.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/47078/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47078: Added checking for required flags to FlagsBase.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47078/#review132766
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 149)


make this `const Option&` instead?



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 237)


ditto. use option here.


- Vinod Kone


On May 7, 2016, 1:27 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47078/
> ---
> 
> (Updated May 7, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added checking for required flags to FlagsBase.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/47078/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 47268: Introduced timeout for docker volume driver client mount/unmount.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47268/
---

Review request for mesos, Gilbert Song and Guangya Liu.


Bugs: MESOS-5365
https://issues.apache.org/jira/browse/MESOS-5365


Repository: mesos


Description
---

Introduced timeout for docker volume driver client mount/unmount.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
9329a9b8bbdd60e11a25e87dab50ec80ea522c1b 

Diff: https://reviews.apache.org/r/47268/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 46621: Added alias support for flags.

[Vinod Kone]

> On April 30, 2016, 6:29 a.m., Greg Mann wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 841
> > 
> >
> > Why the raw pointer here?

as opposed to keeping it a const ref? because i want to set flag->loaded_name 
variable.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review131245
---


On April 30, 2016, 3:43 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> ---
> 
> (Updated April 30, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This lets a user to load a flag either by the original name or an
> alias.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46621: Added alias support for flags.

[Vinod Kone]

> On May 5, 2016, 10:12 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 828-830
> > 
> >
> > ```cpp
> >auto iter = aliases.count(flag_name) ? 
> > flags_.find(aliases[flag_name])
> >  : flags_.find(flag_name);
> > ```

that looks too jagged, no? i looked around in the code base and the most common 
style seem to indent "?" and ":" by 2 spaces from the start of the expression. 
will do the same here.


> On May 5, 2016, 10:12 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 841
> > 
> >
> > Why not just an lvalue-reference?

IIRC, we prefer pointers to do non-const access instead of l-value reference in 
our code base. Has that changed?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review131951
---


On April 30, 2016, 3:43 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> ---
> 
> (Updated April 30, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This lets a user to load a flag either by the original name or an
> alias.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47258/#review132764
---



Patch looks great!

Reviews applied: [47258]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 9:15 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47258/
> ---
> 
> (Updated May 11, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos and Dario Rexin.
> 
> 
> Bugs: MESOS-5279
> https://issues.apache.org/jira/browse/MESOS-5279
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make sure 'activate' is a no-op if the client is already active.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
> 
> Diff: https://reviews.apache.org/r/47258/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Vinod Kone]

> On May 5, 2016, 9:45 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 40
> > 
> >
> > (1) Can we make this `private` and add a `const std::string& get() 
> > const { return value; }`
> > (2) `s/value/value_/`

I wanted Name to be a simple struct which encapsulates some information (just 
like Flags below). So didn't add any getter etc. Do you feel strongly about the 
getter?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131946
---


On April 30, 2016, 1:56 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> ---
> 
> (Updated April 30, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

[Vinod Kone]

> On May 5, 2016, 9:45 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 40
> > 
> >
> > (1) Can we make this `private` and add a `const std::string& get() 
> > const { return value; }`
> > (2) `s/value/value_/`
> 
> Vinod Kone wrote:
> I wanted Name to be a simple struct which encapsulates some information 
> (just like Flags below). So didn't add any getter etc. Do you feel strongly 
> about the getter?

also note that get() that retuns the value is a bit weird because in a later 
patch this struct will also contain a deprecated boolean flag.


> On May 5, 2016, 9:45 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, lines 34-38
> > 
> >
> > `s/_value/value/`

see below.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46620/#review131946
---


On April 30, 2016, 1:56 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46620/
> ---
> 
> (Updated April 30, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This sets up the stage to add metadata to the name (e.g., deprecated).
> This will be used to add deprecation support subsequently.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

> On May 11, 2016, 9:09 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/windows/subprocess.hpp, lines 122-181
> > 
> >
> > Follow-up to https://reviews.apache.org/r/46608/#comment195141: Since 
> > you say that we don't need to escape quotes, let's change `const 
> > vector& argv` to `vector argv` and all of this can be 
> > replaced with:
> > 
> > ```
> > string program = "\"" + argv[0] + "\"";
> > argv.erase(argv.begin());
> > string args = strings::join(" ", argv);
> > string cmd = strings::join(" ", program, args);
> > 
> > BOOL createProcessResult = CreateProcess(
> >   NULL,
> >   cmd.data(),
> >   ...);
> > ```

Talked with Michael and dpravat a bit offline. For the time being, we are going 
to expect that `argv` and `path` are correctly quoted when they are passed to 
the `subprocess` call. It might not be a permanent solution, but the naive 
solution of wrapping `argv[0]` in quotes is not going to cover all the corner 
cases. (For example, the path `C:\"Program Files"\foo.exe`.)

Our plan is to (1) just `strings::join(" ", argv)` and pass that as the command 
to `::CreateProcess`, (2) leave a `NOTE` on this code explaining that if you 
want to pass a binary with a space in it to `subprocess`, you get to quote that 
yourself for the time being, and (3) revisit this when we touch the executor, 
which will give us the opportunity to figure out how `subprocess` is being 
called, which will then help us decide how to handle this correctly, with 
minimum complexity -- our goal here is to _not_ reimplement the CLI parser.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review132623
---


On May 10, 2016, 11:44 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> ---
> 
> (Updated May 10, 2016, 11:44 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review132753
---




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 146)


i see that you made all `add`s protected here.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 147 - 
179)


do we even need these overloads anymore? can't we just use the below 
overloads that use 'Flags' as a template parameter?



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 181 - 
188)


why did you move this overload? makes is really hard to understand what 
changed. :(



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 286 - 
287)


this comment needs to be updated.


- Vinod Kone


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> ---
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk 
> since copying of the `map` inside `FlagsBase` reference random memory leading 
> to `SEGFAULTs`. With these patches all of `stout-tests` and 
> `libprocess-tests` can be executed, but some remaining failures persist in 
> `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review132750
---




src/examples/test_http_framework.cpp (line 381)


2 blank lines.



src/local/main.cpp (lines 52 - 53)


why the need for "::" prefix here?



src/master/main.cpp (line 127)


If `add` should be only called by derived classes, should `add` method be 
protected instead of public?



src/master/main.cpp (lines 207 - 223)


where is this code moved from and why?



src/slave/main.cpp (line 97)


why "::" prefix?


- Vinod Kone


On May 11, 2016, 12:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated May 11, 2016, 12:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
>   src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/long_lived_framework.cpp 
> 1740d7cb747d179d06e75153aa334b29e9cdf3c0 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/http_command_executor.cpp 
> c62fe3ee6ae06536cbb89ea208b669790efe4b39 
>   src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
>   src/slave/containerizer/mesos/launch.cpp 
> e22106b014c871e2184a15c2ab154a0674874e47 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 47257: Fixed an unassigned member variable in DRF sorter.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47257/#review132751
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 11, 2016, 9:09 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47257/
> ---
> 
> (Updated May 11, 2016, 9:09 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-5279
> https://issues.apache.org/jira/browse/MESOS-5279
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an unassigned member variable in DRF sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
> 
> Diff: https://reviews.apache.org/r/47257/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46823/#review132748
---



Can you expand the description about why we should only be adding member 
variables for correct copy semantics?


3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 519 - 526)


I was expecting the Flags::add() overload to only accept member variables. 
Why do you need to change the call site instead?


- Vinod Kone


On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46823/
> ---
> 
> (Updated April 29, 2016, 9:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/46823/diff/
> 
> 
> Testing
> ---
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47258/
---

(Updated May 11, 2016, 2:15 p.m.)


Review request for mesos and Dario Rexin.


Bugs: MESOS-5279
https://issues.apache.org/jira/browse/MESOS-5279


Repository: mesos


Description
---

Make sure 'activate' is a no-op if the client is already active.


Diffs
-

  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 

Diff: https://reviews.apache.org/r/47258/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47260/
---

(Updated May 11, 2016, 2:15 p.m.)


Review request for mesos and Dario Rexin.


Bugs: MESOS-5279
https://issues.apache.org/jira/browse/MESOS-5279


Repository: mesos


Description
---

Added 'ReviveAndSuppress' test for the allocator.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
e6101fdffe5e340619d79d821a2f5f891cb2dec7 

Diff: https://reviews.apache.org/r/47260/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47258/
---

Review request for mesos and Dario Rexin.


Repository: mesos


Description
---

Make sure 'activate' is a no-op if the client is already active.


Diffs
-

  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 

Diff: https://reviews.apache.org/r/47258/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47260/
---

Review request for mesos and Dario Rexin.


Repository: mesos


Description
---

Added 'ReviveAndSuppress' test for the allocator.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
e6101fdffe5e340619d79d821a2f5f891cb2dec7 

Diff: https://reviews.apache.org/r/47260/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Review Request 47257: Fixed an unassigned member variable in DRF sorter.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47257/
---

Review request for mesos.


Bugs: MESOS-5279
https://issues.apache.org/jira/browse/MESOS-5279


Repository: mesos


Description
---

Fixed an unassigned member variable in DRF sorter.


Diffs
-

  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 

Diff: https://reviews.apache.org/r/47257/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 46822: Avoided slicing of flags in subprocess.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46822/#review132744
---



the summary and description in the review are incorrect. can you please update?


src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1272)


why do you need to do this namespacing? doesn't seem related to the rest of 
the patch?


- Vinod Kone


On May 11, 2016, 12:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46822/
> ---
> 
> (Updated May 11, 2016, 12:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Michael 
> Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While `FlagsBase` internally stores just maps of names and
> flags, the functions stored in a `Flag` rely on the original type of
> the `Flags` containing them (e.g., we perform dynamic casts to detect
> their types).
> 
> Since `Option` stores `T` as a value (i.e., it cannot contain
> reference types) any interface taking an `Option` cannot rely on
> polymorphic behavior of `T`. To make use of polymorphism we should
> instead store e.g., a pointer type to avoid slicing.
> 
> Here we change `Flags` arguments of `subprocess` to allow preserving
> the original type so `Flag` function can work reliably. We do this by
> passing a `Shared` so we do not restrict copying; not that it
> would also be possible to use an `Owned`, but this would
> require an audit of all sites where the arguments are used as
> `Owned` should not be copied, but do not prevent that on their own.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> dae369aadb940150aa806b28d9269e3d88cf57ed 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
>   src/slave/containerizer/mesos/linux_launcher.hpp 
> 89bb2958a41dffe4ade9c2492b9a7412f90a432d 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 5028854fa003615f158120e030866b7ec4402b66 
>   src/tests/containerizer/launch_tests.cpp 
> 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
>   src/tests/containerizer/launcher.hpp 
> c352634c4766d289706c7cc738677619d7d02ccd 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
> 
> Diff: https://reviews.apache.org/r/46822/diff/
> 
> 
> Testing
> ---
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

[Joseph Wu]

> On May 11, 2016, 12:26 p.m., Benjamin Bannier wrote:
> > src/docker/executor.hpp, line 120
> > 
> >
> > Any reason we wouldn't use an unordered map like e.g., a stout 
> > `hashmap` here and as function argument elsewhere in this patch?

This is meant to match the argument type of `docker->run`, which expects a 
`std::map`.


> On May 11, 2016, 12:26 p.m., Benjamin Bannier wrote:
> > src/docker/executor.cpp, line 502
> > 
> >
> > stout `hashmap`?

Same reason as above.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47205/#review132731
---


On May 11, 2016, 11:56 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47205/
> ---
> 
> (Updated May 11, 2016, 11:56 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag opens up a way for hooks to specify environment variables for
> docker tasks.  Existing hooks can only affect the environment variables
> of docker executors.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
> 
> Diff: https://reviews.apache.org/r/47205/diff/
> 
> 
> Testing
> ---
> 
> See later reviews in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47205/
---

(Updated May 11, 2016, 1:03 p.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Changes
---

Add some missing includes.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
---

This flag opens up a way for hooks to specify environment variables for
docker tasks.  Existing hooks can only affect the environment variables
of docker executors.


Diffs (updated)
-

  src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 

Diff: https://reviews.apache.org/r/47205/diff/


Testing
---

See later reviews in chain.


Thanks,

Joseph Wu

Re: Review Request 47216: Wired up the new docker environment hook.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47216/
---

(Updated May 11, 2016, 12:30 p.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Changes
---

Fixed a bug earlier in the chain.  Now fully ready for review.


Summary (updated)
-

Wired up the new docker environment hook.


Bugs: MESOS-5350
https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description (updated)
---

Modifies the code path for docker command executors. (Custom 
executors are not supported because they may break if exposed to an
unfamiliar flag.)

Docker command executors are now launched with an additional flag
that is filled in by a hook.  The --task_environment flag tells the
command executor to pass some specified mapping of environment
variables to the task.


Diffs
-

  src/slave/containerizer/docker.hpp fac26a239e9981e5b1c2f2f90b52785819492c2a 
  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 

Diff: https://reviews.apache.org/r/47216/diff/


Testing (updated)
---

sudo make check


Thanks,

Joseph Wu

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47205/#review132731
---




src/docker/executor.hpp (line 27)


`#include `



src/docker/executor.hpp (line 74)


Just as a note, since you call `add` with `_environment` instead of 
`::task_environment` you explicitly (and consistently with the other 
invocations here) select an overload of `FlagsBase::add` which will make this 
class non-copyable, see MESOS-3335. This will need to be cleaned up as part of 
MESOS-3335.



src/docker/executor.hpp (line 120)


Any reason we wouldn't use an unordered map like e.g., a stout `hashmap` 
here and as function argument elsewhere in this patch?



src/docker/executor.cpp (line 502)


stout `hashmap`?


- Benjamin Bannier


On May 11, 2016, 8:56 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47205/
> ---
> 
> (Updated May 11, 2016, 8:56 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag opens up a way for hooks to specify environment variables for
> docker tasks.  Existing hooks can only affect the environment variables
> of docker executors.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
> 
> Diff: https://reviews.apache.org/r/47205/diff/
> 
> 
> Testing
> ---
> 
> See later reviews in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47246: Windows: Fixed type in `WWINDOWS` define.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47246/#review132732
---


Ship it!




Ship It!

- Michael Park


On May 11, 2016, 6:13 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47246/
> ---
> 
> (Updated May 11, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed type in `WWINDOWS` define.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> 3f4e4b12d9bb8309baa505aea68275c9dce55fae 
> 
> Diff: https://reviews.apache.org/r/47246/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/execute
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 46524: Sanitized src/Makefile.am.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46524/#review132708
---


Fix it, then Ship it!





src/Makefile.am (line 1186)


alignment (and elsewhere)


- Joris Van Remoortere


On May 10, 2016, 9:44 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46524/
> ---
> 
> (Updated May 10, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sanitized src/Makefile.am.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
> 
> Diff: https://reviews.apache.org/r/46524/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46518: Sorted option checks for top-level configure.ac.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46518/#review132701
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:42 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46518/
> ---
> 
> (Updated May 10, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sorted option checks for top-level configure.ac.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46522/#review132705
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/Makefile.am (line 269)


alignment (and elsewhere)


- Joris Van Remoortere


On May 10, 2016, 9:43 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46522/
> ---
> 
> (Updated May 10, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sanitized libprocess/3rdparty/Makefile.am.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e944463aad69c70a2563b424f0b80f3e7f66b5aa 
> 
> Diff: https://reviews.apache.org/r/46522/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46526/#review132711
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:46 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46526/
> ---
> 
> (Updated May 10, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated 3rdparty paths in Python build scripts.
> 
> 
> Diffs
> -
> 
>   src/examples/python/test-containerizer.in 
> 1516fd1fa02bafab502b185df9da63cfd6e10e5e 
>   src/examples/python/test-executor.in 
> 93fd1756fdea09cb9efc4a7005d03c15683c2d70 
>   src/examples/python/test-framework.in 
> 22301fae22e25fbddb63d08bfe824fdd29c74637 
>   src/python/native_common/ext_modules.py.in 
> 4fd328fdbeb68ea2eeb464b6df552e0ef33d6ea9 
> 
> Diff: https://reviews.apache.org/r/46526/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46532/#review132717
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46532/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated LDADD flags for libprocess tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
> 
> Diff: https://reviews.apache.org/r/46532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46529/#review132714
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46529/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved stout from libprocess/3rdparty/ to 3rdparty/.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e944463aad69c70a2563b424f0b80f3e7f66b5aa 
>   3rdparty/libprocess/3rdparty/stout/LICENSE  
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> d523fb0a212228cc47537dc6e444be51941573cc 
>   3rdparty/libprocess/3rdparty/stout/README.md  
>   3rdparty/libprocess/3rdparty/stout/bootstrap  
>   3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake  
>   3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake  
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake  
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake  
>   3rdparty/libprocess/3rdparty/stout/configure.ac 
> a1f86d0f943bbff91a8b021046eb66d624df7896 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am  
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/adaptor.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp  
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp  
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>   
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
>  
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp  
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chdir.hpp  
>   

Re: Review Request 46516: Sorted option checks for libprocess configure.ac.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46516/#review132699
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:40 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46516/
> ---
> 
> (Updated May 10, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sorted option checks for libprocess configure.ac.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
> 
> Diff: https://reviews.apache.org/r/46516/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46514/#review132696
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:37 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46514/
> ---
> 
> (Updated May 10, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Sorted configure.ac AC_ARG_{ENABLE,WITH} entries.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
> 
> Diff: https://reviews.apache.org/r/46514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46515/#review132698
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:38 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46515/
> ---
> 
> (Updated May 10, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, Timothy 
> St. Clair, and Vinod Kone.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Renamed --without-zlib to --disable-zlib.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
> 
> Diff: https://reviews.apache.org/r/46515/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review132725
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46535: Updated stout path for doxygen main page.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46535/#review132720
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46535/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated stout path for doxygen main page.
> 
> 
> Diffs
> -
> 
>   src/main.dox a6765f6f1535146b76488464e674f8d86f5835ba 
> 
> Diff: https://reviews.apache.org/r/46535/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46539/#review132722
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46539/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed libprocess/3rdparty references from misc files.
> 
> 
> Diffs
> -
> 
>   LICENSE 4426b1ebf057fbba2c4007134b0c23935462da21 
>   Makefile.am 2b43854b0d36e4ee9c24a0c6f67480c697b8684a 
>   mpi/mpiexec-mesos.in 3bdd683ba1915cada5cf7c2761a3b25526c5db49 
>   support/coverage.sh 8a3d75dc931fc7273bec1d1e3c698c39f63bfa0a 
>   support/tag.sh 3136abe894bbb80754f68ce883c224280f9383de 
>   support/vote.sh 04bfc09f94aa8ac9418e77db5e99874a60f6d3de 
> 
> Diff: https://reviews.apache.org/r/46539/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46533/#review132718
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46533/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead, we now use top-level configure script directly to generate
> libprocess/stout Makefiles.  As a result, all configure flags are
> handled at one place to generate appropriate Makefiles.
> 
> With this approach, we need to explicitly ask libprocess Makefile to
> generate a static library instead of a shared one. Previously, this
> was done via libprocess' configure script.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46533/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46537: Added --enable-install-module-dependencies.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46537/#review132723
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46537/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --enable-install-module-dependencies.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46537/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46534: Updated stout path for mesos_split.py.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46534/#review132719
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46534/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated stout path for mesos_split.py.
> 
> 
> Diffs
> -
> 
>   support/mesos_split.py be30bd59a951483846dc2314606d1c7a6a019729 
> 
> Diff: https://reviews.apache.org/r/46534/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46536: Updated stout path in newbie-guide.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46536/#review132721
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46536/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated stout path in newbie-guide.
> 
> 
> Diffs
> -
> 
>   docs/newbie-guide.md 5375fb0598766c1c8bcba39ce552df1405f94a39 
> 
> Diff: https://reviews.apache.org/r/46536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46538: Install module dependencies in build/3rdparty as well.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46538/#review132724
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46538/
> ---
> 
> (Updated May 10, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If configured with --enable-install-module-dependencies, install
> 3rdparty dependencies in build/3rdparty.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 
> 
> Diff: https://reviews.apache.org/r/46538/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46530/#review132715
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46530/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The variable $(top_srcdir) causes compilation failure if the Makefile is
> generated by top-level configure script instead of libprocess-specific
> configure script.
> 
> Also replaced ${abs_top_builddir} with ${abs_builddir}. This is used to
> compute path to ssl-client binary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
> 
> Diff: https://reviews.apache.org/r/46530/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46531/#review132716
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46531/
> ---
> 
> (Updated May 10, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added explicit ldflags '-static -fpic' to libprocess.la.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
> 
> Diff: https://reviews.apache.org/r/46531/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46527/#review132712
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:47 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46527/
> ---
> 
> (Updated May 10, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help getting us closer to a standalone stout library.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 
> a1f86d0f943bbff91a8b021046eb66d624df7896 
>   3rdparty/libprocess/3rdparty/stout/m4/ax_compare_version.m4 PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_version.m4 PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46527/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46521/#review132704
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:43 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46521/
> ---
> 
> (Updated May 10, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added --with-{libproces,stout} flags to top-level configure.ac.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
> 
> Diff: https://reviews.apache.org/r/46521/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46523: Sanitized libprocess/Makefile.am.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46523/#review132706
---


Fix it, then Ship it!





3rdparty/libprocess/Makefile.am (lines 223 - 224)


alignment (and elsewhere)


- Joris Van Remoortere


On May 10, 2016, 9:43 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46523/
> ---
> 
> (Updated May 10, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sanitized libprocess/Makefile.am.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
> 
> Diff: https://reviews.apache.org/r/46523/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46525/#review132709
---


Fix it, then Ship it!





3rdparty/Makefile.am (line 97)


alignment (and elsewhere)



src/Makefile.am (line 2045)


spaces?


- Joris Van Remoortere


On May 10, 2016, 9:45 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46525/
> ---
> 
> (Updated May 10, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e944463aad69c70a2563b424f0b80f3e7f66b5aa 
>   3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz  
>   3rdparty/libprocess/3rdparty/glog-0.3.3.patch  
>   3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz  
>   3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz  
>   3rdparty/libprocess/3rdparty/gmock_sources.cc.in  
>   3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz  
>   3rdparty/libprocess/3rdparty/http-parser-2.6.2.patch  
>   3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz  
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template  
>   3rdparty/libprocess/3rdparty/libev-4.22.patch  
>   3rdparty/libprocess/3rdparty/libev-4.22.tar.gz  
>   3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz  
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch  
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz  
>   3rdparty/libprocess/3rdparty/versions.am 
> 4699543557df4cb818bad8d61b5706c061beb0f5 
>   3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 
>   3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 
>   3rdparty/versions.am a00c3b0f14bb8c805545471ef9b6eb633f515d05 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
> 
> Diff: https://reviews.apache.org/r/46525/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46517/#review132700
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:39 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46517/
> ---
> 
> (Updated May 10, 2016, 9:39 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sorted top-level configure.ac AC_ARG_{ENABLE,WITH} entries.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46517/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46519/#review132702
---


Ship it!




- Joris Van Remoortere


On May 10, 2016, 9:43 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46519/
> ---
> 
> (Updated May 10, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copied libprocess-specific configure options to top-level configure.ac.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
> 
> Diff: https://reviews.apache.org/r/46519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 47249: Added watchdog for docker volume driver client subprocess.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47249/
---

Review request for mesos, Gilbert Song and Guangya Liu.


Bugs: MESOS-5360
https://issues.apache.org/jira/browse/MESOS-5360


Repository: mesos


Description
---

This is to ensure that the subprocess is killed when slave terminates
or crashes.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
ef43c566a51d748cca318a7578db62ee3475656d 

Diff: https://reviews.apache.org/r/47249/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132707
---



Patch looks great!

Reviews applied: [46965]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 9:16 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 11, 2016, 9:16 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Review Request 47246: Windows: Fixed type in `WWINDOWS` define.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47246/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Fixed type in `WWINDOWS` define.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
3f4e4b12d9bb8309baa505aea68275c9dce55fae 

Diff: https://reviews.apache.org/r/47246/diff/


Testing
---

Windows: build/execute


Thanks,

Daniel Pravat

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47056/#review132697
---


Ship it!




Ship It!

- Jiang Yan Xu


On May 5, 2016, 11:26 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47056/
> ---
> 
> (Updated May 5, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5287
> https://issues.apache.org/jira/browse/MESOS-5287
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove python-boto since 'mesos-ec2' has been removed.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/47056/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 47028: Fixed a confusing log line in the allocator.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47028/
---

Review request for mesos.


Repository: mesos


Description
---

When there is no offer to send out at the end of an allocation run it
could be entirely possible that it's because all framworks have
suppressed or filtered offers. "No offers to send out!" simply states
the case.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
0de03c7347e01fde2b42f5ec38a34a62edf642a1 

Diff: https://reviews.apache.org/r/47028/diff/


Testing
---


Thanks,

Jiang Yan Xu

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

[Kapil Arya]

> On May 4, 2016, 11:33 a.m., James Peach wrote:
> > configure.ac, line 591
> > 
> >
> > So in practice, libraries would be installed in either 
> > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both?
> > 
> > Is there a libtool or autoconf variable to figure that out?
> 
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either 
> :-(. I believe there might be a way to figure it out but I am not so sure 
> given that we are talking about 3rdparty software (with their own configure 
> scripts) here. I'll try to think of a better alternative.
> 
> James Peach wrote:
> Another question ... I don't recall whether you actually need the link 
> flags for modules? all the 3rdparty libraries should already be present in 
> the mesos process by the time module are loaded, so you wouldn't need them at 
> link time. Right?

If someone wants to generate a binary file, say as a helper process for the 
module, they'll need the libraries.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46540/#review131691
---


On May 10, 2016, 5:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
> ---
> 
> (Updated May 10, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and 
> Timothy St. Clair.
> 
> 
> Bugs: MESOS-5250
> https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated pkg-config file to include module dependency info.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 
> 
> Diff: https://reviews.apache.org/r/46540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated May 11, 2016, 5 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47222: Add authorization to /quota endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47222/#review132675
---



Patch looks great!

Reviews applied: [47222]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 6:14 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47222/
> ---
> 
> (Updated May 11, 2016, 6:14 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add authorization to /quota endpoint.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
>   src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 
> 
> Diff: https://reviews.apache.org/r/47222/diff/
> 
> 
> Testing
> ---
> 
> Adding tests in MasterQuotaTest.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Jie Yu]

> On May 6, 2016, 5:34 p.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 42
> > 
> >
> > Instead of using a script here, can we use code to get ip network and 
> > name server information?
> > 
> > You can take a look at `links()` and `IPNetwork::fromLinkDevice(..)` in 
> > stout.
> > 
> > I would suggest that we define a test fixture for the isolator tests 
> > and get the ip network and nameserver address in the SetUp function. We can 
> > also put the helpers to create plugin/config in the test fixture.
> 
> Qian Zhang wrote:
> I see `link::eth0()` and `IPNetwork::fromLinkDevice(..)` can be used to 
> get the IP of host public interface which is good, but how can we use code to 
> get name server? It seems we do not have existing method to do so.
> 
> What about I put creating plugin/config in `static void SetUpTestCase()` 
> but still use script to get IP and name server?
> 
> Qian Zhang wrote:
> I tried to use code to get IP and name servers rather than script, but I 
> found it will be hard to combine with C++ literal which may make the code 
> hard to read, like this:
> ```cpp
> Result hostIPNetwork =
> net::IPNetwork::fromLinkDevice(eth0.get(), AF_INET);
> 
> const string cniMockPlugin = R"~(
>   #!/bin/sh
>   echo "{"
>   echo "  \"ip4\": {"
>   echo "\"ip\": \")~" + hostIPNetwork.get().address() + "/" +
>   hostIPNetwork.get().prefix() +
>   R"~(\""
>   echo "  }"
>   echo "}"
>   )~";
> ```
> Please note, I have not included name servers in the above code. There 
> can be multiple name servers, if we include them, it will make the above code 
> more complex, I think the current patch (do everything in a script) has 
> better readability. Or if we really want to do it in this way, can we just 
> include the first name server in the above code?

You can take a look at strings::format (similar to printf)


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review132084
---


On May 6, 2016, 2:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> ---
> 
> (Updated May 6, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount 
> --help=false --operation=make-rslave --path=/
> + grep+  -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/.+ 
> /proc/self/mountinfo
> + grepcut -v -d  -f5
>  d06b117d-518b-41e2-b8e0-62a12083773c
> + xargs --no-run-if-empty umount -l
> + mount -n --rbind 
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/provisioner/containers/d06b117d-518b-41e2-b8e0-62a12083773c/backends/copy/rootfses/7ea27011-cd3a-43b0-8301-b0b94d9f9b47
>  
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/slaves/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0/frameworks/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-/executors/60e6d35d-6d33-47ae-9c23-d2e5c913c892/runs/d06b117d-518b-41e2-b8e0-62a12083773c/.rootfs
> I0420 22:26:00.924844  9305 exec.cpp:150] Version: 0.29.0
> I0420 22:26:00.942319  9375 exec.cpp:225] Executor registered on agent 
> 18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0
> Registered executor on mesos
> Starting task 60e6d35d-6d33-47ae-9c23-d2e5c913c892
> Forked command at 9382
> sh -c 'ls /'
> bin  dev  etc  home lib  linuxrc  mediamnt  proc  
>root run  sbin sys  tmp  usr  var
> Command exited with status 0 (pid: 9382)
> I0420 22:26:01.098331  9380 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_LaunchCommandTask (42603 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

[Alex Clemmer]

> On May 11, 2016, 9:11 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/Makefile.am, line 48
> > 
> >
> > This should be `process/posix/subprocess.hpp`

Huh. I wonder how this happened.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review132625
---


On May 5, 2016, 3:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> ---
> 
> (Updated May 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6ce1a827e36e0c65985e3928c89f51561fdd70cd 
>   3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION 
>   3rdparty/libprocess/src/CMakeLists.txt 
> a8379d323f30037bdd15e151957f885664b5e242 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/#review129838
---



Looks like the SHARE and UNSHARE operations are not in this patch?


include/mesos/resources.hpp (lines 424 - 430)


See my comment at the definition.



include/mesos/resources.hpp (lines 513 - 518)


See my comment at the definition.



include/mesos/v1/resources.hpp (lines 424 - 431)


Ditto.



include/mesos/v1/resources.hpp (lines 513 - 518)


Ditto.



src/common/resources.cpp (line 1169)


Chatted offline but I think we do need to `clear_shared()` and 
`clear_disk()` for shared resources here. 

The problem here is that only quantities can be aggregated across slaves 
and if `clear_shared()` and `clear_disk()` are not called, the resources have 
identities and cannot be aggregated across slaves. e.g., different slaves can 
have persistent volumes with the same size and ID but are actually different.



src/common/resources.cpp (lines 1311 - 1316)


Chatted about removing `destroyAllowed` method but here an additional point 
is that: determining if a shared resource is no longer used and thus can be 
destroyed is the responsiblity of the master (more specifically the 
valication.cpp file in it and not the Resource abstraction. 

Here the concern should be: if the resource is in there, destroy it, return 
Error otherwise. Therefore the original code is still correct.



src/common/resources.cpp (line 1328)


Should we require persistent volumes to be unshared before we destroy them?

Here the concern is that we are clearing things in DESTROY that are not 
added by its pairing operation CREATE.



src/common/resources.cpp (lines 1464 - 1496)


This concept of weightedGet tightly couples with the sorter logic which is 
not used elsewhere so it shouldn't be pulled out.

Here to have something that's more easily explainable in a generic way, 
perhaps we can introduce something like

```
// Returns the count of the target Resource in the Resources.
size_t Resources::count(const Resource& target) const
{
  // Search the list of resources in the collection.
  // For shared resources, return the Resource_::sharedCount but because 
this
  // is strictly an internal optimzation, the caller just needs to refer to 
this
  // as "the count".
  // For nonshared resources, given how we collapse addable resources, the 
result
  // is at most 1.
}
```

I feel API is easiler to explain in a general sense for the callers and the 
implementation is easy to explain for readers of the cpp file without going to 
through the DRF logic.

Chatted with Anindya offline and we are still debating whether we can avoid 
even having `count` altogether but I am writing down my thoughts here.

As to whether we are leaking internal information, I don't feel like this 
is the case: we are not asking the caller to carefully manipulating the 
internal state in order to use share resource arithmetics correctly but rather 
this provides additional information for logic that doesn't deal with resource 
arithmetic. Therefore I don't think we are breaking abstractions but merely 
exposing a const `count` method.



src/common/resources.cpp (lines 1613 - 1635)


If we don't need `weightedGet` we don't need this either.



src/common/resources.cpp (line 1980)


I understand that there are cases where we call `<<` on the Resource 
directly so the `Resource_` version doesn't get called, but perhaps `` 
pairs better with the shared count `<6>`?



src/common/resources_utils.hpp (lines 41 - 45)


The comments at the definitions.



src/common/resources_utils.cpp (lines 71 - 74)


Do we need `Resources::isShared(resource)`?

If we don't need that method, here we can actually just 
`stripped.clear_shared()`.



src/common/resources_utils.cpp (lines 88 - 119)


In the most recent iteration we can just -= from the call sites right?



src/common/resources_utils.cpp (lines 122 - 139)


This method is basically `Resources& Resources::operator+=(const 

Review Request 47238: Shifted from a cpu-core model of selection to processing unit model.

[Chris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47238/
---

Review request for mesos.


Repository: mesos


Description
---

Shifted from a cpu-core model of selection to processing unit model.


Diffs
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/ProcessBinder.cpp 
PRE-CREATION 
  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/hwloc.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47238/diff/


Testing
---


Thanks,

Chris

Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

[Chris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47126/
---

(Updated May 11, 2016, 3:43 p.m.)


Review request for mesos.


Repository: mesos


Description (updated)
---

The algorithm is maximizing when it may need have a constrained maximization.


Diffs
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47126/diff/


Testing
---


Thanks,

Chris

Re: Review Request 47126: Changed the submodular scheduler to constrained maximization.

[Chris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47126/
---

(Updated May 11, 2016, 3:42 p.m.)


Review request for mesos.


Summary (updated)
-

Changed the submodular scheduler to constrained maximization.


Repository: mesos


Description (updated)
---

Forgot the algorithm is maximizing when it needs to minimize.


Diffs (updated)
-

  
src/slave/containerizer/mesos/isolators/cgroups/devices/hwloc/SubmodularScheduler.cpp
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47126/diff/


Testing
---


Thanks,

Chris