Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133037
---



Patch looks great!

Reviews applied: [47329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 13, 2016, 5:39 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated May 13, 2016, 5:39 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133036
---


Ship it!




Ship It!

- Guangya Liu


On 五月 13, 2016, 5:39 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated 五月 13, 2016, 5:39 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Gilbert Song]

> On May 12, 2016, 6:57 p.m., Guangya Liu wrote:
> > Do you want to update the configuration.md?
> 
> Jie Yu wrote:
> Good catch. @gilbert, can you follow up with a patch?

@Guangya, thanks!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133017
---


On May 12, 2016, 10:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated May 12, 2016, 10:39 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Jie Yu]

> On May 13, 2016, 1:57 a.m., Guangya Liu wrote:
> > Do you want to update the configuration.md?

Good catch. @gilbert, can you follow up with a patch?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133017
---


On May 13, 2016, 1:34 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated May 13, 2016, 1:34 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47324: Update leveldb.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133030
---



Bad patch!

Reviews applied: [47324]

Failed command: ./support/apply-review.sh -n -r 47324

Error:
2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ 
[4739/4739] -> "47324.patch" [1]
error: missing binary patch data for '3rdparty/leveldb-1.18.tar.gz'
error: binary patch does not apply to '3rdparty/leveldb-1.18.tar.gz'
error: 3rdparty/leveldb-1.18.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13038/console

- Mesos ReviewBot


On May 12, 2016, 8:46 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 12, 2016, 8:46 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update leveldb to 1.18.
> Remove patch that is already included in latest leveldb release.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 13, 2016, 4:09 a.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 13, 2016, 4:09 a.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

No functional changes.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
---

(Updated May 13, 2016, 4:08 a.m.)


Review request for mesos and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 13, 2016, 4:08 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 47168: Windows: Implemented `kill`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47168/
---

(Updated May 13, 2016, 4:01 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5375
https://issues.apache.org/jira/browse/MESOS-5375


Repository: mesos


Description
---

Windows: Implemented `kill`.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/kill.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/kill.hpp PRE-CREATION 
  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 

Diff: https://reviews.apache.org/r/47168/diff/


Testing
---

Windows: build/test w/ Marathon


Thanks,

Daniel Pravat

Re: Review Request 47169: Windows: Impemented `killtree` using NT job objects.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47169/
---

(Updated May 13, 2016, 4 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3639
https://issues.apache.org/jira/browse/MESOS-3639


Repository: mesos


Description
---

Windows: Impemented  `killtree` using NT job objects.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/killtree.hpp 
b075d625541ed6c10192e3e98bf399b38b69cdc5 
  3rdparty/stout/include/stout/windows/os.hpp 
261768eace6ab09956f4a80e1ec5dba988d831e1 

Diff: https://reviews.apache.org/r/47169/diff/


Testing
---

Windows: build/test with Marathon


Thanks,

Daniel Pravat

Re: Review Request 47209: Establish TCP connection after backing off.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133025
---


Ship it!




Ship It!

- Ben Mahler


On May 13, 2016, 3:37 a.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> ---
> 
> (Updated May 13, 2016, 3:37 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review133024
---



Patch looks great!

Reviews applied: [46242]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 13, 2016, 12:25 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> ---
> 
> (Updated May 13, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
>   src/tests/master_validation_tests.cpp 
> 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp 
> f014290ed9f279df4c774aeb7ce7bd38fd1cc854 
> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47209: Establish TCP connection after backing off.

[David Robinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/
---

(Updated May 13, 2016, 3:37 a.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.


Bugs: MESOS-5330
https://issues.apache.org/jira/browse/MESOS-5330


Repository: mesos


Description
---

Establish TCP connection after backing off.


Diffs (updated)
-

  src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 

Diff: https://reviews.apache.org/r/47209/diff/


Testing
---

make check

Also started a master and agent and captured a tcpdump to verify the connection 
is only established _after_ the registration backoff.


Thanks,

David Robinson

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

[Guangya Liu]

> On 五月 12, 2016, 10:47 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 217-233
> > 
> >
> > Do we have a way to optimize the logic here?

Did not found a good way to optimize the logic here, but I think that current 
logic is good enough to understand, what do you think?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/#review132995
---


On 四月 18, 2016, 8:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44839/
> ---
> 
> (Updated 四月 18, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for appc.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
> 
> Diff: https://reviews.apache.org/r/44839/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/
---

(Updated 五月 13, 2016, 3:30 a.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
---

Enabled mesos containerizer force_pull_image for appc.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 

Diff: https://reviews.apache.org/r/44839/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47303/
---

(Updated May 13, 2016, 3:29 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3783
https://issues.apache.org/jira/browse/MESOS-3783


Repository: mesos


Description
---

Rename 'slave' in documentations with 'agent'. However, not all of
them are renamed due to stickiness of class name, json response,
endpoint, etc.


Diffs (updated)
-

  docs/architecture.md 3eff931a9ebb91ae06c0c7bab6c6a17d5fdb8743 
  docs/attributes-resources.md 7d687ffcba2bc4c9cc6d83172ac852abe4174c88 
  docs/authentication.md 1084e638c913878de6742fcd459792272689b8e1 
  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  docs/c++-style-guide.md fdd765e8a56974b25849a3509cbf99fa57fc7e27 
  docs/committers.md 0ae0e920ab9e09ff985fd77eb5b3092b8499a3d7 
  docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
  docs/container-image.md a7659de7a08d7badd185dac6bb43fb1fb6fbf5c8 
  docs/containerizer-internals.md 6d050b9bb0c6f564e2fad83859a177bc8d742474 
  docs/deploy-scripts.md af83d28e26b133bbf6b4fe821cb468c9d373bd57 
  docs/docker-containerizer.md 6ec1cecd2e39bc4737688d8c4f6fc05e82c92023 
  docs/documentation-guide.md 8239dcd908e2509797d7881d080ccbcf56f8fe4e 
  docs/doxygen-style-guide.md 1817aa0ac7ac7dd15a3d77fcab3451c874d1ef98 
  docs/executor-http-api.md 2b362f616d02611a8eea37b88c60aabdbca8bfd4 
  docs/external-containerizer.md 07a795f2352a169488400c948d6bc0501e01dc5e 
  docs/fetcher-cache-internals.md 7863fd2fc2b7ff8f45ad553b2764677ebec8a67d 
  docs/fetcher.md b23fdf2e7ae55cc807cd2ddb3b8dc4a7d3a79eb8 
  docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 
  docs/high-availability-framework-guide.md 
d5949508dafdf1a6e515663fa1524a81fe4ffba4 
  docs/high-availability.md a8b4fce5e1bfcaec719ac7379dfc19e0ae43a928 
  docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
  docs/mesos-containerizer.md 6f40c576e8402db1f56238e6a9cbacda0e166bac 
  docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 
  docs/monitoring.md 69d0f9848dcfed7069a8b25039cc3262bf406994 
  docs/network-monitoring.md 1e503753a0aef127b555f072a4c8fb4768418e67 
  docs/operational-guide.md 193cf0adf956ab9c32140875ad7434067da871b7 
  docs/oversubscription.md 51eefb63da87607f991d7b10d6282dd73b3b092a 
  docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
  docs/reconciliation.md 83cf15d1d188fc9c3a2a5b7cd1c8c8ec30c3fc6c 
  docs/release-guide.md 69b0a0f06574fea5ec6576325698068870306ae8 
  docs/replicated-log-internals.md a04e774e12ee411beae84ef8c739e083f3469c25 
  docs/slave-recovery.md ff584f0bd8b25421ce50c6fdaa38f5b98d93ff69 
  docs/ssl.md d0fcd536a4d7fb86a9f80dfe4629c22df50686b2 
  docs/testing-patterns.md 360d1c29e3ac0e4e99dcbcabdb2204e04eda7cea 
  docs/tools.md 11c8122ae61cb5788b2204a548a9a26650a26b97 
  docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 

Diff: https://reviews.apache.org/r/47303/diff/


Testing
---

Draft patch. Not going to be committed until flags being renamed.


Thanks,

Jay Guo

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
---

(Updated 五月 13, 2016, 3:26 a.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
---

Enabled mesos containerizer force_pull_image for docker.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
137af502a66e6a65773c00eaacbe392576376284 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
cf630cc0b67a325529fa04ad2b1708e013b9596a 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
eeec94326a4fd67675df10e0b6a32267e555fa96 

Diff: https://reviews.apache.org/r/44838/diff/


Testing
---

make
make check

It is difficult to test this with unit test, but just test with mesos execute 
by setting `force_pull_image` as true and found that the iamge was always 
pulled when `force_pull_image` is true.


Thanks,

Guangya Liu

Re: Review Request 44837: Added force_pull_image to Image protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44837/
---

(Updated 五月 13, 2016, 3:26 a.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
---

Added force_pull_image to Image protobuf.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 

Diff: https://reviews.apache.org/r/44837/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review133020
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46863, 
46818, 46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated May 12, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `--authenticate` is made a deprecated alias for
> `--authenticate_frameworks` master flag. Also updated the example tests
> to use the new flag.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/examples/docker_no_executor_framework.cpp 
> 2b82b4f0e2424b98ea29fb08b21993b1713b364e 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/java/TestExceptionFramework.java 
> 12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
>   src/examples/java/TestFramework.java 
> 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/python/test_framework.py 
> 5f8e470721b303a60797c41db3c5587b89b5cf58 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[Guangya Liu]

> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, 
> > lines 169-176
> > 
> >
> > btw, I would prefer check forcepulling after storedImages.contains, 
> > which may be more logical.

I discussed this with @haosdent, if we put `forcePullImage` first, then we 
don't need search storedImages if forcePullImage is true.


> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, line 
> > 174
> > 
> >
> > since you already have the check above, why dont you return None() 
> > there to avoid checking `forcepull` again?

if (forcePullImage) {
  VLOG(1) << "The mesos containerizer is trying to force pull image '"
  << imageReference << "' from registry";
}
//The above check is mainly for logging.

if (forcePullImage || !storedImages.contains(imageReference)) {
  return None();
}


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review132994
---


On 四月 18, 2016, 8:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated 四月 18, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47168: Windows: Implemented `kill`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47168/
---

(Updated May 13, 2016, 2:18 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5375
https://issues.apache.org/jira/browse/MESOS-5375


Repository: mesos


Description
---

Windows: Implemented `kill`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/kill.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp 
PRE-CREATION 
  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 

Diff: https://reviews.apache.org/r/47168/diff/


Testing
---

Windows: build/test w/ Marathon


Thanks,

Daniel Pravat

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

[Jay Guo]

> On May 12, 2016, 5:08 p.m., Vinod Kone wrote:
> > docs/configuration.md, line 1545
> > 
> >
> > just to confirm, all the text here is going to match the --help output 
> > after the flags patch lands?

Yes, I'm thinking to have 'agent' in all description, regardless of aliases of 
the flags.


> On May 12, 2016, 5:08 p.m., Vinod Kone wrote:
> > docs/architecture.md, line 12
> > 
> >
> > mention that in slaveID is sent for driver based frameworks 
> > (deprecated) and agentID is sent for HTTP API based fraemworks.

OK


- Jay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47303/#review132944
---


On May 12, 2016, 11:29 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47303/
> ---
> 
> (Updated May 12, 2016, 11:29 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3783
> https://issues.apache.org/jira/browse/MESOS-3783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rename 'slave' in documentations with 'agent'. However, not all of
> them are renamed due to stickiness of class name, json response,
> endpoint, etc.
> 
> 
> Diffs
> -
> 
>   docs/architecture.md 3eff931a9ebb91ae06c0c7bab6c6a17d5fdb8743 
>   docs/attributes-resources.md 7d687ffcba2bc4c9cc6d83172ac852abe4174c88 
>   docs/authentication.md 1084e638c913878de6742fcd459792272689b8e1 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/c++-style-guide.md fdd765e8a56974b25849a3509cbf99fa57fc7e27 
>   docs/committers.md 0ae0e920ab9e09ff985fd77eb5b3092b8499a3d7 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   docs/container-image.md a7659de7a08d7badd185dac6bb43fb1fb6fbf5c8 
>   docs/containerizer-internals.md 6d050b9bb0c6f564e2fad83859a177bc8d742474 
>   docs/deploy-scripts.md af83d28e26b133bbf6b4fe821cb468c9d373bd57 
>   docs/docker-containerizer.md 6ec1cecd2e39bc4737688d8c4f6fc05e82c92023 
>   docs/documentation-guide.md 8239dcd908e2509797d7881d080ccbcf56f8fe4e 
>   docs/doxygen-style-guide.md 1817aa0ac7ac7dd15a3d77fcab3451c874d1ef98 
>   docs/executor-http-api.md 2b362f616d02611a8eea37b88c60aabdbca8bfd4 
>   docs/external-containerizer.md 07a795f2352a169488400c948d6bc0501e01dc5e 
>   docs/fetcher-cache-internals.md 7863fd2fc2b7ff8f45ad553b2764677ebec8a67d 
>   docs/fetcher.md b23fdf2e7ae55cc807cd2ddb3b8dc4a7d3a79eb8 
>   docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 
>   docs/high-availability-framework-guide.md 
> d5949508dafdf1a6e515663fa1524a81fe4ffba4 
>   docs/high-availability.md a8b4fce5e1bfcaec719ac7379dfc19e0ae43a928 
>   docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
>   docs/mesos-containerizer.md 6f40c576e8402db1f56238e6a9cbacda0e166bac 
>   docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 
>   docs/monitoring.md 69d0f9848dcfed7069a8b25039cc3262bf406994 
>   docs/network-monitoring.md 1e503753a0aef127b555f072a4c8fb4768418e67 
>   docs/operational-guide.md 193cf0adf956ab9c32140875ad7434067da871b7 
>   docs/oversubscription.md 51eefb63da87607f991d7b10d6282dd73b3b092a 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
>   docs/reconciliation.md 83cf15d1d188fc9c3a2a5b7cd1c8c8ec30c3fc6c 
>   docs/release-guide.md 69b0a0f06574fea5ec6576325698068870306ae8 
>   docs/replicated-log-internals.md a04e774e12ee411beae84ef8c739e083f3469c25 
>   docs/slave-recovery.md ff584f0bd8b25421ce50c6fdaa38f5b98d93ff69 
>   docs/ssl.md d0fcd536a4d7fb86a9f80dfe4629c22df50686b2 
>   docs/testing-patterns.md 360d1c29e3ac0e4e99dcbcabdb2204e04eda7cea 
>   docs/tools.md 11c8122ae61cb5788b2204a548a9a26650a26b97 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47303/diff/
> 
> 
> Testing
> ---
> 
> Draft patch. Not going to be committed until flags being renamed.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

(Updated 五月 13, 2016, 2 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page.


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/
---

(Updated 五月 13, 2016, 1:59 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

summary statement update


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using the summary attribute of the table element.


Diffs (updated)
-

  src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d 
  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46964/diff/


Testing
---

Have checked with the patch by firebug, each table should have summary 
attribute.

For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html


Thanks,

Chen Nan Li

Re: Review Request 47209: Establish TCP connection after backing off.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133016
---




src/slave/slave.cpp (line 996)


Whoops, this will crash when master is None. How about you move it down to 
where we've decided we need to authenticate (below the LOG(INFO)). This makes 
it a bit more symmetric with the registration path).

Also could you include the following?

```
// Ensure there is a link to the master before we start communicating with 
it.
```


- Ben Mahler


On May 12, 2016, 6:18 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> ---
> 
> (Updated May 12, 2016, 6:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133017
---



Do you want to update the configuration.md?

- Guangya Liu


On 五月 13, 2016, 1:34 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated 五月 13, 2016, 1:34 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133014
---



Bad patch!

Reviews applied: [46498]

Failed command: ./support/apply-review.sh -n -r 46498

Error:
2016-05-13 01:39:51 URL:https://reviews.apache.org/r/46498/diff/raw/ 
[25311/25311] -> "46498.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:246
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13034/console

- Mesos ReviewBot


On May 12, 2016, 9:23 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> ---
> 
> (Updated May 12, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1e1a36903f4377497bb72b69e4ead63675d453c0 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/#review133012
---


Ship it!




Ship It!

- Jie Yu


On May 13, 2016, 1:34 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47329/
> ---
> 
> (Updated May 13, 2016, 1:34 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent flag 'docker_volume_checkpoint_dir'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
>   src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
> 1aff0d40e5ae83dbc87230099f3081ec7890e897 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
> 
> Diff: https://reviews.apache.org/r/47329/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47329/
---

Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu.


Repository: mesos


Description
---

Added agent flag 'docker_volume_checkpoint_dir'.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
  src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp 
1aff0d40e5ae83dbc87230099f3081ec7890e897 
  src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 

Diff: https://reviews.apache.org/r/47329/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47259/#review133010
---



Patch looks great!

Reviews applied: [47258, 47259]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47259/
> ---
> 
> (Updated May 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos and Dario Rexin.
> 
> 
> Bugs: MESOS-5279
> https://issues.apache.org/jira/browse/MESOS-5279
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CHECK if DRFSorter::add() would introduce a duplicate.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
> 
> Diff: https://reviews.apache.org/r/47259/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46798/
---

(Updated May 13, 2016, 12:50 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description (updated)
---

This change introduces linux capability based security for unified
containerizer. A new agent flag \`allowed_capabilities\` has been
introduced to override the default capabilities of the user or the
capabilities requested by the user.

This feature is only available on linux.


Diffs (updated)
-

  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/slave/containerizer/mesos/containerizer.hpp 
a1a00020668f6da8d611f26e5637afffc87d09ba 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/launch.hpp 
c716e0396736d1f2f60ec31540f12f4f7597d081 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
  src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
4293416ac8434e9eb7e80724480a54936a2fe24a 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46798/diff/


Testing
---

make check; used mesos cli to test end to end functionality.


Thanks,

Jojy Varghese

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/
---

(Updated May 13, 2016, 12:50 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change introduces two flags: `user` and `capabilities`.

   user:  used to specify the user name for the command.
   capabilities: comma separated list of capabilities the task
 requires.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 

Diff: https://reviews.apache.org/r/46799/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46370/
---

(Updated May 13, 2016, 12:45 a.m.)


Review request for mesos, Jie Yu and Kevin Klues.


Bugs: MESOS-5051
https://issues.apache.org/jira/browse/MESOS-5051


Repository: mesos


Description
---

This change introduces basic API for linux capabilities. This is not a
comprehensive API but is strictly limited to the need for securing Mesos
containers using linux capabilities.


Diffs (updated)
-

  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/linux/capabilities.hpp PRE-CREATION 
  src/linux/capabilities.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46370/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46242: Removed a check in Reserve operation validation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
---

(Updated May 13, 2016, 12:25 a.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212


Repository: mesos


Description
---

When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.


Diffs (updated)
-

  src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
  src/tests/master_validation_tests.cpp 
8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
  src/tests/reservation_endpoints_tests.cpp 
f014290ed9f279df4c774aeb7ce7bd38fd1cc854 

Diff: https://reviews.apache.org/r/46242/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review133005
---


Fix it, then Ship it!





src/master/flags.cpp (lines 18 - 23)


Mind committing this bit separately? You also need duration.hpp, error.hpp, 
none.hpp, stringify.hpp.


- Ben Mahler


On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated May 12, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `--authenticate` is made a deprecated alias for
> `--authenticate_frameworks` master flag. Also updated the example tests
> to use the new flag.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/examples/docker_no_executor_framework.cpp 
> 2b82b4f0e2424b98ea29fb08b21993b1713b364e 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/java/TestExceptionFramework.java 
> 12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
>   src/examples/java/TestFramework.java 
> 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/python/test_framework.py 
> 5f8e470721b303a60797c41db3c5587b89b5cf58 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/#review133003
---


Fix it, then Ship it!





src/cli/execute.cpp (line 644)


`->` here and everywhere else


- Ben Mahler


On May 12, 2016, 10:43 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46815/
> ---
> 
> (Updated May 12, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In addition to updating the code for the new signature, deprecation
> warnings are also printed when loading deprecated flag names/aliases.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
>   src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
>   src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/long_lived_framework.cpp 
> 1740d7cb747d179d06e75153aa334b29e9cdf3c0 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
>   src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
>   src/launcher/http_command_executor.cpp 
> c62fe3ee6ae06536cbb89ea208b669790efe4b39 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
>   src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
>   src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
>   src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
>   src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/container_loggers/logrotate.cpp 
> 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
>   src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
>   src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
>   src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
> 
> Diff: https://reviews.apache.org/r/46815/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133004
---



Srinivas, thanks for taking this on. It looks like you combined your previous 
patches (https://reviews.apache.org/r/46107) here. I would advice you to split 
this patch into 2:
 - Protobuf changes
 - Other changes
 

-jojy

- Jojy Varghese


On May 12, 2016, 9:23 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> ---
> 
> (Updated May 12, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1e1a36903f4377497bb72b69e4ead63675d453c0 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/#review133002
---


Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 613)


Can you add an expectation that there are no warnings?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46818/
> ---
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> No functional changes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/46818/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/#review132999
---


Fix it, then Ship it!





3rdparty/stout/include/stout/flags/flags.hpp (lines 661 - 663)


// TODO(vinod): Reject flags with an unknown name if `unknowns` is false.
// This will break backwards compatibility however!



3rdparty/stout/include/stout/flags/flags.hpp (lines 664 - 665)


How about strings::remove with PREFIX?



3rdparty/stout/include/stout/flags/flags.hpp (line 690)


Since this ends up holding both command and environment values, how about 
just 'values' now?



3rdparty/stout/include/stout/flags/flags.hpp (lines 728 - 729)


How about:

```
// Merge in flags from the environment. Command-line
// flags take precedence over environment flags.
```



3rdparty/stout/include/stout/flags/flags.hpp (line 750)


Don't need this?



3rdparty/stout/include/stout/flags/flags.hpp (line 751)


s/cmdValues/values/



3rdparty/stout/include/stout/flags/flags.hpp (lines 797 - 798)


// Merge in flags from the environment. Command-line
// flags take precedence over environment flags.



3rdparty/stout/include/stout/flags/flags.hpp (line 831)


can you suffix with _ on the second instance?



3rdparty/stout/include/stout/flags/flags.hpp (lines 835 - 836)


Could we wrap at the paren?



3rdparty/stout/include/stout/flags/flags.hpp (line 844)


How about _ as a suffix on the second instance?



3rdparty/stout/include/stout/flags/flags.hpp (line 862)


Could we wrap at the paren?



3rdparty/stout/include/stout/flags/flags.hpp (lines 883 - 884)


Shouldn't this print the `name` being looped over here so that we can see 
the two clashing names?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46863/
> ---
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logic is now moved to Flag::load() keep the duplicate checking logic
> for names and aliases in one place.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 02584e28b938bba738c2e32b3cb7a04a47693853 
> 
> Diff: https://reviews.apache.org/r/46863/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46923: Added framework failover timeout validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review133000
---



Patch looks great!

Reviews applied: [46923]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 3:47 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 11, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47168: Windows: Implemented `kill`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47168/
---

(Updated May 12, 2016, 11:16 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5375
https://issues.apache.org/jira/browse/MESOS-5375


Repository: mesos


Description
---

Windows: Implemented `kill`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/kill.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp 
PRE-CREATION 
  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 

Diff: https://reviews.apache.org/r/47168/diff/


Testing
---

Windows: build/test w/ Marathon


Thanks,

Daniel Pravat

Re: Review Request 46669: Added deprecation support to Flag name.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review132997
---


Fix it, then Ship it!





3rdparty/stout/include/stout/flags/flag.hpp (line 23)


whoops?



3rdparty/stout/include/stout/flags/flag.hpp (lines 52 - 57)


Maybe `s/name_/name/` and `s/name/n/` or `s/name/name_`?



3rdparty/stout/include/stout/flags/flags.hpp (line 899)


Past tense since the caller will log the warning after load completes?



3rdparty/stout/tests/flags_tests.cpp (lines 271 - 272)


Can you update all of these existing tests to expect no warnings?



3rdparty/stout/tests/flags_tests.cpp (line 502)


Can you use the `->` operator here?

EXPECT?

Also can you add an expectation on the message?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> ---
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows callers of Flag to explicitly specify a flag name or its
> alias as deprecated. Loading of deprecated flag name will result in a
> deprecation warning being returned.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
>   3rdparty/stout/include/stout/flags/flag.hpp 
> d869904d13301fd4b3fdb037e6279d3a4018ac1e 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 02584e28b938bba738c2e32b3cb7a04a47693853 
>   3rdparty/stout/include/stout/subcommand.hpp 
> 4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
>   3rdparty/stout/tests/flags_tests.cpp 
> a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 
> 
> Diff: https://reviews.apache.org/r/46669/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/#review132995
---




src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 69)


ditto.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 217 - 233)


Do we have a way to optimize the logic here?


- Gilbert Song


On April 18, 2016, 1:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44839/
> ---
> 
> (Updated April 18, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for appc.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
> 
> Diff: https://reviews.apache.org/r/44839/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 10:42 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

No functional changes.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 12, 2016, 10:43 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 10:42 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated May 12, 2016, 10:38 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description (updated)
---

`--authenticate` is made a deprecated alias for
`--authenticate_frameworks` master flag. Also updated the example tests
to use the new flag.


Diffs (updated)
-

  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/examples/docker_no_executor_framework.cpp 
2b82b4f0e2424b98ea29fb08b21993b1713b364e 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/java/TestExceptionFramework.java 
12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
  src/examples/java/TestFramework.java 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/python/test_framework.py 
5f8e470721b303a60797c41db3c5587b89b5cf58 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
  src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
  src/tests/test_http_framework_test.sh 
3a2b24cd5017f3535340cb8ade13b34e341cd7ce 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review132994
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp (line 93)


ditto.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 67)


since a protobuf optional field should have a default value, so this one 
will always be overrided.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (lines 
169 - 176)


btw, I would prefer check forcepulling after storedImages.contains, which 
may be more logical.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 174)


since you already have the check above, why dont you return None() there to 
avoid checking `forcepull` again?


- Gilbert Song


On April 18, 2016, 1:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated April 18, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
---

(Updated May 12, 2016, 10:31 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-5373
https://issues.apache.org/jira/browse/MESOS-5373


Repository: mesos


Description
---

Windows: Added Console Ctrl handling in `slave.cpp`.


Diffs (updated)
-

  src/slave/posix_signalhandler.hpp PRE-CREATION 
  src/slave/slave.cpp feb9f291b4188aac1a63ab9cfae8349a048663b1 
  src/slave/windows_ctrlhandler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
---

OSX: make check
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/
---

(Updated May 12, 2016, 10:22 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5373
https://issues.apache.org/jira/browse/MESOS-5373


Repository: mesos


Description
---

Windows: Removed `Zookeeper's` NTDDI_VERSION.


Diffs (updated)
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 

Diff: https://reviews.apache.org/r/47054/diff/


Testing
---

OSX: make
Windows: msbuild


Thanks,

Daniel Pravat

Re: Review Request 44837: Added force_pull_image to Image protobuf.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44837/#review132992
---


Fix it, then Ship it!





include/mesos/mesos.proto (line 1575)


Understand it defaults to be false. Could we make it explicit here?

Thanks!



include/mesos/v1/mesos.proto (line 1574)


ditto.


- Gilbert Song


On April 18, 2016, 1:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44837/
> ---
> 
> (Updated April 18, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force_pull_image to Image protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
> 
> Diff: https://reviews.apache.org/r/44837/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47221: Windows: Used `os::random` in libprocess.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47221/
---

(Updated May 12, 2016, 10:19 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5372
https://issues.apache.org/jira/browse/MESOS-5372


Repository: mesos


Description
---

Windows: Used `os::random` in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/sequence_tests.cpp 
566393fbf3f19644b86843f07194d1de36a2015e 

Diff: https://reviews.apache.org/r/47221/diff/


Testing
---

OSX: make ckeck


Thanks,

Daniel Pravat

Re: Review Request 47053: Windows: [2/2] Used `os::random`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47053/
---

(Updated May 12, 2016, 10:19 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5372
https://issues.apache.org/jira/browse/MESOS-5372


Repository: mesos


Description
---

Windows: [2/2] Used `os::random`.


Diffs (updated)
-

  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/log/consensus.cpp 67bd30b2abcefa0c598c54311bf8659ed4afa0c2 
  src/log/recover.cpp eaa001e1284efdbb2c7a2a6cc94496992555fd24 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/slave/slave.cpp feb9f291b4188aac1a63ab9cfae8349a048663b1 

Diff: https://reviews.apache.org/r/47053/diff/


Testing
---

OSX: make
Windows: msbuild


Thanks,

Daniel Pravat

Re: Review Request 47052: Windows: [1/2] Added `os::random`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47052/
---

(Updated May 12, 2016, 10:18 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5372
https://issues.apache.org/jira/browse/MESOS-5372


Repository: mesos


Description
---

Windows: [1/2] Added `os::random`.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/os.hpp 
0f71f66d3efed7513ce407dde5b56368747c8e70 
  3rdparty/stout/include/stout/windows.hpp 
a7a59e78575e1456b4e14d18ac97f51dd23d794e 
  3rdparty/stout/include/stout/windows/os.hpp 
261768eace6ab09956f4a80e1ec5dba988d831e1 

Diff: https://reviews.apache.org/r/47052/diff/


Testing
---

OSX: make 
Windows: build


Thanks,

Daniel Pravat

Re: Review Request 44837: Added force_pull_image to Image protobuf.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44837/#review132991
---


Ship it!




Ship It!

- Gilbert Song


On April 18, 2016, 1:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44837/
> ---
> 
> (Updated April 18, 2016, 1:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force_pull_image to Image protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
> 
> Diff: https://reviews.apache.org/r/44837/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47266/#review132778
---




src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 312)


Maybe add a comment over here as to what the .wh. files are meant for? I 
think for someone who does not have that context it will be hard to understand 
what the .wh. files are used for.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 319)


s/one-layer image/single-layered images
s/exclude/excludes
s/using bind/using the bind



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 334 - 353)


Just a thought, this looks like a `find` function that might be very useful 
in stout? Should we implement a `find` in stout using fts and wrap this code 
into a function that returns a `Result` ?



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 348)


I think this should be:
Failure(
  "Failed to .



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 364)


Ditto on code style.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 370)


Ditto on code-style.


- Avinash sridharan


On May 11, 2016, 10:46 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47266/
> ---
> 
> (Updated May 11, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-5277
> https://issues.apache.org/jira/browse/MESOS-5277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented provisioner removing docker whitelist files.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
> 
> Diff: https://reviews.apache.org/r/47266/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tested with docker image containing `.wh.` files.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47314: Add authentication documentation to authenticated endpoints.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47314/#review132990
---



Patch looks great!

Reviews applied: [47313, 47314]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 1:55 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47314/
> ---
> 
> (Updated May 12, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add authentication documentation to authenticated endpoints.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> ee2f48fa03f8125565c3c066c9b416ddb5fe8498 
>   docs/endpoints/files/browse.md 3060c5b8ea2814a53b80c2c2641673363d16cb12 
>   docs/endpoints/files/debug.json.md 7e367b342879632331853040971666d0f09b2f68 
>   docs/endpoints/files/debug.md 31d344637c751dd649cd068361e7abb26f457101 
>   docs/endpoints/files/download.json.md 
> 6b73f296d381ced21804bb915e9868afaf655d39 
>   docs/endpoints/files/download.md 17cdb2686ead95924266519924ad3db8073c7f54 
>   docs/endpoints/files/read.json.md c4d59679c6c52ad723204a119f17ec0cdfa8f913 
>   docs/endpoints/files/read.md 2e1ffac7fd7d0008b14047366bebb1a3a8454384 
>   docs/endpoints/logging/toggle.md f76accd1e2e0208cd991e4fb6e54f0ff0bf0d8b0 
>   docs/endpoints/metrics/snapshot.md 7d3a7ef810a6f28f9101b35241737bac59fed965 
>   docs/endpoints/profiler/start.md 36bd0b6d661692db930723e8385a9da593e98c53 
>   docs/endpoints/profiler/stop.md 085b8523e3ccc03cae971d9ce1d8e2ef6a47a411 
>   docs/endpoints/registrar/registry.md 
> b3697a6107d45d5c99c57b6e293ef4cb29dc73ba 
>   src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
>   src/master/registrar.cpp a509f45e094abdfcef71914058611ecaa5d6448e 
> 
> Diff: https://reviews.apache.org/r/47314/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang-trunk, w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 8:54 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated description.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

No functional changes.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 12, 2016, 8:54 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
---

(Updated May 12, 2016, 8:54 p.m.)


Review request for mesos and Michael Park.


Changes
---

updated description.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 8:53 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated description.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47061/#review132974
---



Could you please update `Slave::Http::CONTAINERS_HELP()` as well?

- Alexander Rukletsov


On May 6, 2016, 9:50 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47061/
> ---
> 
> (Updated May 6, 2016, 9:50 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5316
> https://issues.apache.org/jira/browse/MESOS-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds HTTP Authentication to '/containers' endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
>   src/slave/slave.hpp b72438033708de473046d321c493d9fbcd7a9b43 
>   src/slave/slave.cpp 5aa1530a3f6b2fdb7196fc65b133ab6afaaa6a53 
> 
> Diff: https://reviews.apache.org/r/47061/diff/
> 
> 
> Testing
> ---
> 
> Testing is done when testcases are modified in the next patch 
> https://reviews.apache.org/r/47062/ .
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 8:46 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 47324: Update leveldb.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/
---

Review request for mesos, Bing Li, Ben Mahler, Zhiwei Chen, and haosdent huang.


Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970


Repository: mesos


Description
---

Update leveldb to 1.18.
Remove patch that is already included in latest leveldb release.


Diffs
-

  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
  3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
  3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
  src/python/native_common/ext_modules.py.in 
2d4a45efa224b32f80ace4542a00062c5ccb06d5 

Diff: https://reviews.apache.org/r/47324/diff/


Testing
---

Tested on Ubuntu amd_64 need to test on PPC


Thanks,

Tomasz Janiszewski

Re: Review Request 46669: Added deprecation support to Flag name.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
---

(Updated May 12, 2016, 8:45 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Added deprecation support to Flag name.


Diffs (updated)
-

  3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp 
d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 
4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 

Diff: https://reviews.apache.org/r/46669/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
---

(Updated May 12, 2016, 8:46 p.m.)


Review request for mesos and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/flags.hpp 
02584e28b938bba738c2e32b3cb7a04a47693853 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 47292: Update docs to reflect contender and detector modules.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47292/#review132970
---



Patch looks great!

Reviews applied: [47292]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 11:19 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47292/
> ---
> 
> (Updated May 12, 2016, 11:19 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-5366
> https://issues.apache.org/jira/browse/MESOS-5366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'Master contender and detector' section to 'Mesos Modules' doc.
> 
> 
> Diffs
> -
> 
>   docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 
> 
> Diff: https://reviews.apache.org/r/47292/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46392/
---

(Updated May 12, 2016, 6:54 p.m.)


Review request for mesos.


Summary (updated)
-

Windows: Added stub implementations of `fcntl.hpp` functions.


Repository: mesos


Description
---

This commit introduces temporary versions of 2 important functions:
`os::nonblock` and `os::cloexec`. We put them here in a placeholder
commit so that reviewers can make progress on subprocess. In the
immediate term, the plan is to figure out on a callsite-by-callsite
basis how to work around the functionality of `os::cloexec`. When we
collect more data, we will be in a better position to offer a way
forward here.


Diffs (updated)
-

  3rdparty/stout/include/stout/os.hpp 25e93200cf8b95f57931771073f3b6e34fff061b 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
14734317d7fb40053ee808745ac3ba8c706a7669 

Diff: https://reviews.apache.org/r/46392/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47169: Windows: Impemented `killtree` using NT job objects.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47169/#review132960
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp (lines 
22 - 75)


I don't understand why this is:
1) Implemented here
2) Different from the pstree in os/pstree.hpp



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp (line 
80)


Missing period `.`.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 668)


2 lines between functions.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 669 - 
673)


Grammar. Whitespace.



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 709)


2 lines between functions



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 710 - 
714)


Grammar.


- Joris Van Remoortere


On May 10, 2016, 9:57 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47169/
> ---
> 
> (Updated May 10, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Impemented  `killtree` using NT job objects.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killtree.hpp 
> b075d625541ed6c10192e3e98bf399b38b69cdc5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 261768eace6ab09956f4a80e1ec5dba988d831e1 
> 
> Diff: https://reviews.apache.org/r/47169/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/test with Marathon
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47168: Windows: Implemented `kill`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47168/#review132957
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp (lines 24 
- 25)


Missing periods `.`.



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 18 - 19)


Alphabetize.


- Joris Van Remoortere


On May 10, 2016, 11:34 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47168/
> ---
> 
> (Updated May 10, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `kill`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9b39ce32c0269479066cf7991afaeed65d8ab547 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/kill.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/kill.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/kill.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> a7a59e78575e1456b4e14d18ac97f51dd23d794e 
> 
> Diff: https://reviews.apache.org/r/47168/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/test w/ Marathon
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47209: Establish TCP connection after backing off.

[David Robinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/
---

(Updated May 12, 2016, 6:18 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.


Bugs: MESOS-5330
https://issues.apache.org/jira/browse/MESOS-5330


Repository: mesos


Description
---

Establish TCP connection after backing off.


Diffs (updated)
-

  src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 

Diff: https://reviews.apache.org/r/47209/diff/


Testing
---

make check

Also started a master and agent and captured a tcpdump to verify the connection 
is only established _after_ the registration backoff.


Thanks,

David Robinson

Re: Review Request 47209: Establish TCP connection after backing off.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review132956
---




src/slave/slave.cpp (line 966)


Why not call `link` inside the `authenticate()` function in a similar 
manner to how you've called it within `doReliableRegistration()`?



src/slave/slave.cpp (line 1361)


How about the following comment here:

```
  // Ensure there is a link to the master before we start
  // communicating with it. We want to `link` after the
  // initial registration backoff in order to avoid all
  // of the agents establishing connections with the
  // master at once. See MESOS-5330.
```


- Ben Mahler


On May 11, 2016, 12:58 a.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> ---
> 
> (Updated May 11, 2016, 12:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47259/
---

Review request for mesos and Dario Rexin.


Bugs: MESOS-5279
https://issues.apache.org/jira/browse/MESOS-5279


Repository: mesos


Description
---

CHECK if DRFSorter::add() would introduce a duplicate.


Diffs
-

  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 

Diff: https://reviews.apache.org/r/47259/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 46923: Added framework failover timeout validation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review132958
---


Ship it!




Ship It!

- Vinod Kone


On May 11, 2016, 3:47 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 11, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47219: Used `collect` for waiting on establishing connection.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47219/#review132954
---


Ship it!




Ship It!

- Vinod Kone


On May 11, 2016, 5 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47219/
> ---
> 
> (Updated May 11, 2016, 5 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change replaces the previous nested lambda logic
> with `process::collect`.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
> 
> Diff: https://reviews.apache.org/r/47219/diff/
> 
> 
> Testing
> ---
> 
> make check, need to make a similar change for the executor library too.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46624: Added support to mesos to work with flag alias.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46624/#review132949
---


Ship it!




Ship It!

- Michael Park


On April 30, 2016, 3:43 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46624/
> ---
> 
> (Updated April 30, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support to mesos to work with flag alias.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46624/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46623: Updated libprocess to work with flag alias.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46623/#review132948
---


Ship it!




Ship It!

- Michael Park


On April 30, 2016, 3:43 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46623/
> ---
> 
> (Updated April 30, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated libprocess to work with flag alias.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
> 
> Diff: https://reviews.apache.org/r/46623/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46622: Added tests for flag aliases.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46622/#review132947
---


Ship it!




Ship It!

- Michael Park


On May 12, 2016, 1:36 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46622/
> ---
> 
> (Updated May 12, 2016, 1:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for flag aliases.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 66e16abe914e2a1ee7599bab857ff478b7ec20dc 
> 
> Diff: https://reviews.apache.org/r/46622/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46621: Added alias support for flags.

[Michael Park]

> On May 5, 2016, 10:12 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 
> > 828-830
> > 
> >
> > ```cpp
> >auto iter = aliases.count(flag_name) ? 
> > flags_.find(aliases[flag_name])
> >  : flags_.find(flag_name);
> > ```
> 
> Vinod Kone wrote:
> that looks too jagged, no? i looked around in the code base and the most 
> common style seem to indent "?" and ":" by 2 spaces from the start of the 
> expression. will do the same here.

Sounds good.


> On May 5, 2016, 10:12 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 841
> > 
> >
> > Why not just an lvalue-reference?
> 
> Vinod Kone wrote:
> IIRC, we prefer pointers to do non-const access instead of l-value 
> reference in our code base. Has that changed?

Certainly true that we don't take lvalue function parameters, but rather take 
pointers instead.
I suppose you could extend that rule here.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review131951
---


On May 12, 2016, 1:36 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> ---
> 
> (Updated May 12, 2016, 1:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This lets a user to load a flag either by the original name or an
> alias.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47303/#review132944
---




docs/architecture.md (line 12)


mention that in slaveID is sent for driver based frameworks (deprecated) 
and agentID is sent for HTTP API based fraemworks.



docs/configuration.md (line 1545)


just to confirm, all the text here is going to match the --help output 
after the flags patch lands?



docs/executor-http-api.md (line 327)


s/_agent_/_AGENT_/

s/agent/Agent/



docs/executor-http-api.md (line 347)


s/agent/Agent/



docs/external-containerizer.md (line 463)


s/slave/agent/

this won't be changed anytime soon.



docs/monitoring.md (line 331)


metrics names in the old operator API endpoints will still have "slave" in 
them.

s/agent/slave/ for all metric names in this file.



docs/upgrades.md (line 318)


the flag names here should still have 'slave' in them because they are 
referring to older versions of Mesos.


- Vinod Kone


On May 12, 2016, 11:29 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47303/
> ---
> 
> (Updated May 12, 2016, 11:29 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3783
> https://issues.apache.org/jira/browse/MESOS-3783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rename 'slave' in documentations with 'agent'. However, not all of
> them are renamed due to stickiness of class name, json response,
> endpoint, etc.
> 
> 
> Diffs
> -
> 
>   docs/architecture.md 3eff931a9ebb91ae06c0c7bab6c6a17d5fdb8743 
>   docs/attributes-resources.md 7d687ffcba2bc4c9cc6d83172ac852abe4174c88 
>   docs/authentication.md 1084e638c913878de6742fcd459792272689b8e1 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/c++-style-guide.md fdd765e8a56974b25849a3509cbf99fa57fc7e27 
>   docs/committers.md 0ae0e920ab9e09ff985fd77eb5b3092b8499a3d7 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   docs/container-image.md a7659de7a08d7badd185dac6bb43fb1fb6fbf5c8 
>   docs/containerizer-internals.md 6d050b9bb0c6f564e2fad83859a177bc8d742474 
>   docs/deploy-scripts.md af83d28e26b133bbf6b4fe821cb468c9d373bd57 
>   docs/docker-containerizer.md 6ec1cecd2e39bc4737688d8c4f6fc05e82c92023 
>   docs/documentation-guide.md 8239dcd908e2509797d7881d080ccbcf56f8fe4e 
>   docs/doxygen-style-guide.md 1817aa0ac7ac7dd15a3d77fcab3451c874d1ef98 
>   docs/executor-http-api.md 2b362f616d02611a8eea37b88c60aabdbca8bfd4 
>   docs/external-containerizer.md 07a795f2352a169488400c948d6bc0501e01dc5e 
>   docs/fetcher-cache-internals.md 7863fd2fc2b7ff8f45ad553b2764677ebec8a67d 
>   docs/fetcher.md b23fdf2e7ae55cc807cd2ddb3b8dc4a7d3a79eb8 
>   docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 
>   docs/high-availability-framework-guide.md 
> d5949508dafdf1a6e515663fa1524a81fe4ffba4 
>   docs/high-availability.md a8b4fce5e1bfcaec719ac7379dfc19e0ae43a928 
>   docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
>   docs/mesos-containerizer.md 6f40c576e8402db1f56238e6a9cbacda0e166bac 
>   docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 
>   docs/monitoring.md 69d0f9848dcfed7069a8b25039cc3262bf406994 
>   docs/network-monitoring.md 1e503753a0aef127b555f072a4c8fb4768418e67 
>   docs/operational-guide.md 193cf0adf956ab9c32140875ad7434067da871b7 
>   docs/oversubscription.md 51eefb63da87607f991d7b10d6282dd73b3b092a 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
>   docs/reconciliation.md 83cf15d1d188fc9c3a2a5b7cd1c8c8ec30c3fc6c 
>   docs/release-guide.md 69b0a0f06574fea5ec6576325698068870306ae8 
>   docs/replicated-log-internals.md a04e774e12ee411beae84ef8c739e083f3469c25 
>   docs/slave-recovery.md ff584f0bd8b25421ce50c6fdaa38f5b98d93ff69 
>   docs/ssl.md d0fcd536a4d7fb86a9f80dfe4629c22df50686b2 
>   docs/testing-patterns.md 360d1c29e3ac0e4e99dcbcabdb2204e04eda7cea 
>   docs/tools.md 11c8122ae61cb5788b2204a548a9a26650a26b97 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47303/diff/
> 
> 
> Testing
> ---
> 
> Draft patch. Not going to be committed until flags being renamed.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47313/#review132941
---




3rdparty/libprocess/src/logging.cpp (line 97)


Strictly speaking, libprocess endpoints can be both authentication-enabled 
and not. This depends on how libprocess is initialized.


- Alexander Rukletsov


On May 12, 2016, 1:55 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47313/
> ---
> 
> (Updated May 12, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add authentication documentation to authenticated libprocess endpoints.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/logging.cpp 
> ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 65b58433158c51cebace9b591d4121e8d9a59ecc 
>   3rdparty/libprocess/src/profiler.cpp 
> 9b2f106cc7db1ff0b94c72ed55188d94799cf7df 
> 
> Diff: https://reviews.apache.org/r/47313/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang-trunk, w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 47222: Add authorization to /quota endpoint.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47222/
---

(Updated May 12, 2016, 4:21 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Update test method name.


Bugs: MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Add authorization to /quota endpoint.


Diffs (updated)
-

  src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
  src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 

Diff: https://reviews.apache.org/r/47222/diff/


Testing
---

Adding tests in MasterQuotaTest.


Thanks,

Zhitao Li

Re: Review Request 47217: Deprecate 'slave' in CLI.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47217/#review132937
---


Ship it!




Ship It!

- Vinod Kone


On May 11, 2016, 2:52 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47217/
> ---
> 
> (Updated May 11, 2016, 2:52 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3784
> https://issues.apache.org/jira/browse/MESOS-3784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Hide 'slave' in help message and produce deprecation warning
> when command invoked with 'slave' subcommand.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos.cpp f76d3edac0082d6a4fc41bb7cbdeee1a895ac3f1 
> 
> Diff: https://reviews.apache.org/r/47217/diff/
> 
> 
> Testing
> ---
> 
> `slave` does not appear in help message when run `./mesos help`.
> 
> `./messos slave` produces a deprecation warning at beginning.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Jan Schlicht]

> On May 12, 2016, 5:30 p.m., Alexander Rukletsov wrote:
> > src/tests/master_authorization_tests.cpp, line 1030
> > 
> >
> > Now this is not symmetrical to `SlaveAuthorizationTest`.

Yes, `MasterAuthorizationTest` was already taken.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review132896
---


On May 12, 2016, 11:25 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated May 12, 2016, 11:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47260/
---

(Updated May 12, 2016, 4:01 p.m.)


Review request for mesos and Dario Rexin.


Changes
---

removed the unpublished dependency review to unstuck reviewbot -- @vinodkone


Bugs: MESOS-5279
https://issues.apache.org/jira/browse/MESOS-5279


Repository: mesos


Description
---

Added 'ReviveAndSuppress' test for the allocator.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
e6101fdffe5e340619d79d821a2f5f891cb2dec7 

Diff: https://reviews.apache.org/r/47260/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46438/#review132927
---



Patch looks great!

Reviews applied: [46096, 46097, 46435, 46436, 46438]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 8:14 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46438/
> ---
> 
> (Updated May 12, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_SlaveRecovery".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46438/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_SlaveRecovery
> I0420 22:36:44.632558 10440 exec.cpp:150] Version: 0.29.0
> I0420 22:36:44.655817 10456 exec.cpp:225] Executor registered on agent 
> 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> Registered executor on mesos
> Starting task 190bb5f3-c917-4848-820b-bf76d9251cf6
> sh -c 'sleep 5'
> Forked command at 10463
> I0420 22:36:44.856591 10455 exec.cpp:271] Received reconnect request from 
> agent 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> I0420 22:36:44.859297 10455 exec.cpp:248] Executor re-registered on agent 
> 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> Re-registered executor on mesos
> Command exited with status 0 (pid: 10463)
> I0420 22:36:49.796159 10456 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_SlaveRecovery (6436 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review132896
---




src/tests/master_authorization_tests.cpp (line 1030)


Now this is not symmetrical to `SlaveAuthorizationTest`.



src/master/http.cpp (line 861)


We should also update a help string saying that authz can be enabled. I'll 
take it in a separate patch.



src/master/http.cpp (lines 872 - 881)


This snippet relies on the fact, that the endpoint being hit is from the 
"delegated" actor. See https://issues.apache.org/jira/browse/MESOS-5369 for 
details. We should mention the ticket here and rephrase the TODO.


- Alexander Rukletsov


On May 12, 2016, 9:25 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> ---
> 
> (Updated May 12, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
>   src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
> 
> Diff: https://reviews.apache.org/r/46784/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46888: Documented that `slaveLost` and `executorLost` are unreliable.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46888/#review132923
---


Ship it!




Ship It!

- Till Toenshoff


On May 12, 2016, 1:36 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46888/
> ---
> 
> (Updated May 12, 2016, 1:36 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented that `slaveLost` and `executorLost` are unreliable.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 7a5f065695c483bacec664bf36c483604ac2a6a1 
>   include/mesos/scheduler.hpp 859edd2f8b6b13b4a9848e557e2732291e2d4c8b 
>   src/java/src/org/apache/mesos/Scheduler.java 
> c7917d43f4a94fd644ab77bfdf9290fa9984f4c6 
>   src/python/interface/src/mesos/interface/__init__.py 
> 1da76ebe577639e8161b16a48a503aa76d568789 
> 
> Diff: https://reviews.apache.org/r/46888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46869/#review132919
---


Ship it!




Ship It!

- Alexander Rojas


On May 10, 2016, 10:36 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46869/
> ---
> 
> (Updated May 10, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test cluster initialization code was altered
> to enable authorization of libprocess-level HTTP
> endpoints when a master or agent is launched
> with authorization enabled.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
>   src/tests/cluster.cpp db7262868164b1966a9824b8aa53dbe9c5af7c2f 
> 
> Diff: https://reviews.apache.org/r/46869/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47115: Fixed some issues in newbie-guide.md.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47115/#review132914
---


Ship it!




Ship It!

- Till Toenshoff


On May 9, 2016, 9:56 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47115/
> ---
> 
> (Updated May 9, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-5292
> https://issues.apache.org/jira/browse/MESOS-5292
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review fixes some formating issues with the newbie-guide
> including removing a reference to a non-existent image
> (see Mesos-5292 for details).
> 
> 
> Diffs
> -
> 
>   docs/newbie-guide.md 5375fb0598766c1c8bcba39ce552df1405f94a39 
> 
> Diff: https://reviews.apache.org/r/47115/diff/
> 
> 
> Testing
> ---
> 
> viewed via docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46883/#review132913
---




src/common/http.cpp (line 592)


Although we have some instances of `std::make_pair` (two in the source code 
and 8 in tests), I think a more common patter is to use either initialization 
lists, e.g.

```c++
callbacks.insert({
"/metrics/snapshot",
[authorizer](…) {…}});
```

or

```c++
callbacks["/metrics/snapshot"] = [authorizer](…){
  …
}});
```



src/common/http.cpp (line 594)


Do you really need to define the return type here? since the function only 
has one `return` and it is already a `Future` I would have expected C++ 
to be able to deduce it.


- Alexander Rojas


On May 10, 2016, 10:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46883/
> ---
> 
> (Updated May 10, 2016, 10:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a callback to the generating
> function `CreateAuthorizationCallbacks` for the
> '/metrics/snapshot' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
> 
> Diff: https://reviews.apache.org/r/46883/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46392/#review132906
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 12, 2016, 6:04 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46392/
> ---
> 
> (Updated May 12, 2016, 6:04 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit introduces temporary versions of 2 important functions:
> `os::nonblock` and `os::cloexec`. We put them here in a placeholder
> commit so that reviewers can make progress on subprocess. In the
> immediate term, the plan is to figure out on a callsite-by-callsite
> basis how to work around the functionality of `os::cloexec`. When we
> collect more data, we will be in a better position to offer a way
> forward here.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os.hpp 
> 25e93200cf8b95f57931771073f3b6e34fff061b 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> 14734317d7fb40053ee808745ac3ba8c706a7669 
> 
> Diff: https://reviews.apache.org/r/46392/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46867/#review132904
---


Ship it!




Ship It!

- Alexander Rojas


On May 10, 2016, 10:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46867/
> ---
> 
> (Updated May 10, 2016, 10:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Code is added to the common headers and the
> master/agent executables which sets authorization
> callbacks for libprocess-level HTTP endpoints.
> This allows these endpoints to be authorized.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 6c6f2840bbf49d198b1db876cdf4af5ef49b0e27 
>   src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/46867/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47313/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Add authentication documentation to authenticated libprocess endpoints.


Diffs
-

  3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 
  3rdparty/libprocess/src/profiler.cpp 9b2f106cc7db1ff0b94c72ed55188d94799cf7df 

Diff: https://reviews.apache.org/r/47313/diff/


Testing
---

make check (OS X, clang-trunk, w/o optimizations)


Thanks,

Benjamin Bannier

Review Request 47314: Add authentication documentation to authenticated endpoints.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47314/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Add authentication documentation to authenticated endpoints.


Diffs
-

  docs/endpoints/files/browse.json.md ee2f48fa03f8125565c3c066c9b416ddb5fe8498 
  docs/endpoints/files/browse.md 3060c5b8ea2814a53b80c2c2641673363d16cb12 
  docs/endpoints/files/debug.json.md 7e367b342879632331853040971666d0f09b2f68 
  docs/endpoints/files/debug.md 31d344637c751dd649cd068361e7abb26f457101 
  docs/endpoints/files/download.json.md 
6b73f296d381ced21804bb915e9868afaf655d39 
  docs/endpoints/files/download.md 17cdb2686ead95924266519924ad3db8073c7f54 
  docs/endpoints/files/read.json.md c4d59679c6c52ad723204a119f17ec0cdfa8f913 
  docs/endpoints/files/read.md 2e1ffac7fd7d0008b14047366bebb1a3a8454384 
  docs/endpoints/logging/toggle.md f76accd1e2e0208cd991e4fb6e54f0ff0bf0d8b0 
  docs/endpoints/metrics/snapshot.md 7d3a7ef810a6f28f9101b35241737bac59fed965 
  docs/endpoints/profiler/start.md 36bd0b6d661692db930723e8385a9da593e98c53 
  docs/endpoints/profiler/stop.md 085b8523e3ccc03cae971d9ce1d8e2ef6a47a411 
  docs/endpoints/registrar/registry.md b3697a6107d45d5c99c57b6e293ef4cb29dc73ba 
  src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
  src/master/registrar.cpp a509f45e094abdfcef71914058611ecaa5d6448e 

Diff: https://reviews.apache.org/r/47314/diff/


Testing
---

make check (OS X, clang-trunk, w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review132894
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 5:05 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 12, 2016, 5:05 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46888: Documented that `slaveLost` and `executorLost` are unreliable.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46888/
---

(Updated May 12, 2016, 1:36 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Tweak summary, description.


Summary (updated)
-

Documented that `slaveLost` and `executorLost` are unreliable.


Repository: mesos


Description (updated)
---

Documented that `slaveLost` and `executorLost` are unreliable.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
7a5f065695c483bacec664bf36c483604ac2a6a1 
  include/mesos/scheduler.hpp 859edd2f8b6b13b4a9848e557e2732291e2d4c8b 
  src/java/src/org/apache/mesos/Scheduler.java 
c7917d43f4a94fd644ab77bfdf9290fa9984f4c6 
  src/python/interface/src/mesos/interface/__init__.py 
1da76ebe577639e8161b16a48a503aa76d568789 

Diff: https://reviews.apache.org/r/46888/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review132893
---


Ship it!




Ship It!

- Alexander Rojas


On May 10, 2016, 10:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> ---
> 
> (Updated May 10, 2016, 10:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 3b7e2c42d4ac3d1e38e1ac82ddb58ff6dc8ad0af 
>   3rdparty/libprocess/src/process.cpp 
> a9bb27f034fc3795674d44b58bf4d3f5e92ee67c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47199/#review132880
---




src/docker/spec.cpp (line 171)


s/'Labels'/`Labels`

Ditto as following where you are using '' but not ``



src/docker/spec.cpp (lines 226 - 230)


Does there are any possiblity that there are duplicat labels in `config` 
and `container_config`? If so, how to handle the case if there are duplicate 
labels with `config`?


- Guangya Liu


On 五月 12, 2016, 3:56 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47199/
> ---
> 
> (Updated 五月 12, 2016, 3:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
> Klues.
> 
> 
> Bugs: MESOS-5272
> https://issues.apache.org/jira/browse/MESOS-5272
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented parsing docker labels in v1 spec.
> 
> 
> Diffs
> -
> 
>   src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 
> 
> Diff: https://reviews.apache.org/r/47199/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>