Re: SVN::GetRootAndHead

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sahlberg:

Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
tortois...@googlegroups.com>:

would it work if we do both?

rev = cachedProperties.GetHeadRevision(uuid, path);
if ((rev == NO_REVISION) || (m_err != nullptr))
{
svn_error_clear(m_err);
rev = cachedProperties.GetHeadRevision(uuid, url);
}
I don't have a setup ready to test this. At least it would be better than 
before:
- if the path doesn't exist anymore, we try again with the root
- if root works, fine
- if root doesn't work either, it's no worse than before


Stefan


Agree with you that it's no worse than before. It seems to work in my 
testing. I've committed as r29691.

I've also asked on the subversion dev@ mailing list.

Kind regards,
Daniel


Turned out to be my fault altogether, based in r29499. I've reverted 
everything and will circle back to the original project monitor issue. 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegroups.com.

Re: To not delete the pathfile

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 1 maj 2024 kl. 19:57:34 UTC+2 skrev Stefan:

if you set the registry DWORD value
HKCU\Software\TortoiseSVN\Debug
to 1, then TortoiseProc will show a message box on startup with the command 
line. While that message box is shown you can make a copy of the pathfile.


Clever trick, works perfectly. Thanks! 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/15a0e301-73dc-4c16-9c84-a97109a674c5n%40googlegroups.com.

To not delete the pathfile

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I'm looking at the bug report that Win11 context menu only processes a 
subset of the selected items 
(https://groups.google.com/g/tortoisesvn/c/tXskNbYHCAQ/m/rIbHwMoTAgAJ?utm_medium=email_source=footer).
 
I'm leaning towards a Win11 bug but to prove it I'd like to keep the path 
file created by the context menu handler.

I'm looking for a way to ignore the "deletepathfile" argument, or for the 
context menu to NOT add it to the command line, a kind of debugging option. 
Any advice?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/f193a6cc-43f5-4b01-b82c-5bd26d0a4a05n%40googlegroups.com.

Re: SVN::GetRootAndHead

[Daniel Sahlberg via TortoiseSVN-dev]

So. That didn't turn out well at all 
(https://groups.google.com/g/tortoisesvn/c/IJuG6WvHTds). I've successfully 
reproduced the error.

Some quick debugging indicate that svn_client_open_ra_session2() now barf 
if the user doesn't have read access to the repository root. I've 
reproduced this using VisualSVN Server (it has an "implicit list folder 
permissions for parents of readable paths" that has to be disabled). I 
didn't dig all the way down to the server but I'm quite sure the server is 
returning a 403 on the root but a valid return code on the actual 
subdirectory.

I'm a bit at loss what to do here since we send the URL when establishing 
the ra session. If the URL doesn't exist anymore, we get an error. If we 
send in the root, we get another error. Any ideas?

Kind regards,
Daniel

söndag 10 mars 2024 kl. 09:16:48 UTC+1 skrev Daniel Sahlberg:

> Thanks! Committed in r29682
>
> lördag 9 mars 2024 kl. 21:11:08 UTC+1 skrev Stefan:
>
>> no objections from me.
>> The revision for the repo root is the same as for the path, but of course 
>> works for non-existing paths as well since the root is never deleted.
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/493f39bf-e45c-4c61-87f6-dd692a0174a5n%40googlegroups.com.

Re: Add modern authentication (OAuth 2.0 + OIDC) to TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

fredag 29 mars 2024 kl. 10:02:33 UTC+1 skrev Thomas Åkesson:

Hi Jon and Daniel,

Sorry about the late response. 

We are running TSVN with OpenIDC authenticating with Entra ID (Azure AD), 
not through the Microsoft Azure Application Proxy though.

Server-side, we have Apache httpd as usual but we add the open-source 
mod_openidc module (instead of basic auth). In addition, some rewrites and 
other config that allows us to tunnel the session token in basic auth 
(which TSVN supports). 

We currently have an installed application that performs the OpenIDC 
authentication and then inserts the session token in the svn auth cache as 
a basic authentication. In order to achieve a cleaner implementation that 
can also work with Microsoft Azure Application Proxy the session token must 
be sent as a cookie.

We would be interested in contributing experience, specifications and 
server setups if we can get the following stars aligned:
 - Financial / developer contributions 
 - Subversion core committer interest 
 - TSVN committer interest


Hi,

This sounds really interesting. I'm committer in both Subversion and TSVN 
(and in Serf, if that would be necessary) and as long as things are 
discussed in the appropriate -dev lists, I can sponsor the commits. 
Unfortunately I'm not in a position to contribute very much code, simply 
because of a lack of time.

 
We also need to reach consensus in primarily the Subversion project but 
there is relatively limited amounts of changes that must happen there. 
 - Sending cookie header with session token instead of basic auth. 
 - Capture set-cookie response headers related to refresh of the session 
cookie.
 - "svn auth" support for storing session token, very similar to basic auth 
(cookie name and the token). 


These things doesn't sound all that complicated, but should probably be 
discussed on d...@subversion.apache.org. Would you like to bring this 
discussion over there?
 

 - maybe something related to handling redirect to ensure that TSVN can act 
on that


I presume we need to have a notification callback function in Subversion 
that TSVN can catch to show the authentication webpage, much like any other 
OAuth2 compatible application does, is this correct?
 


When that is in place, I believe it would be possible to have a standalone 
helper application that performs the authentication and stores it using the 
"svn auth" subcommand (or equivalent). Alternatively add this support in 
TSVN which would be the ideal UX.

Best regards,
Thomas Å.


On 20 Mar 2024, at 08:28, Daniel Sahlberg via TortoiseSVN-dev <
tortois...@googlegroups.com> wrote:

>From what I understand, OAuth2 requires both server- and clientside 
support. So any solution would need to involve both TortoiseSVN and the 
Subversion project (or VisualSVN). I think it is a great idea but I think 
some additional development resources would be required to make this 
happen. Any chance that you (or your company) can get involved in making 
this happen?

Kind regards,
Daniel

onsdag 20 mars 2024 kl. 08:11:28 UTC+1 skrev j...@parabilis-space.com:

We have run into a problem trying to implement SVN on our secure cloud 
platform.  Is it possible to pay someone to add modern authentication to 
TortoiseSVN?

 Specifically we wish to use TortoiseSVN client to access VisualSVN Server 
via Microsoft Azure Application Proxy.  This requires TSVN to be conversant 
in "OAuth 2.0 with OpenID Connect (OIDC)".  See 
https://auth0.com/docs/authenticate/protocols/openid-connect-protocol

You can see the error we get by using TortoiseSVN to open this test 
repository https://visualsvn.parabilis-space.com/svn/test/ 
Error: Repository moved temporarily to ...Oath2/authorize...

Thank You,

--Jon


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to tortoisesvn-d...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4dc5d482-62d0-4c7d-b375-9e1b5e467baan%40googlegroups.com
 
<https://groups.google.com/d/msgid/tortoisesvn-dev/4dc5d482-62d0-4c7d-b375-9e1b5e467baan%40googlegroups.com?utm_medium=email_source=footer>
.


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/00eb0964-485a-4c49-a73d-522745766195n%40googlegroups.com.

Re: Add modern authentication (OAuth 2.0 + OIDC) to TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

>From what I understand, OAuth2 requires both server- and clientside 
support. So any solution would need to involve both TortoiseSVN and the 
Subversion project (or VisualSVN). I think it is a great idea but I think 
some additional development resources would be required to make this 
happen. Any chance that you (or your company) can get involved in making 
this happen?

Kind regards,
Daniel

onsdag 20 mars 2024 kl. 08:11:28 UTC+1 skrev j...@parabilis-space.com:

We have run into a problem trying to implement SVN on our secure cloud 
platform.  Is it possible to pay someone to add modern authentication to 
TortoiseSVN?

 Specifically we wish to use TortoiseSVN client to access VisualSVN Server 
via Microsoft Azure Application Proxy.  This requires TSVN to be conversant 
in "OAuth 2.0 with OpenID Connect (OIDC)".  See 
https://auth0.com/docs/authenticate/protocols/openid-connect-protocol

You can see the error we get by using TortoiseSVN to open this test 
repository https://visualsvn.parabilis-space.com/svn/test/ 
Error: Repository moved temporarily to ...Oath2/authorize...

Thank You,

--Jon

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4dc5d482-62d0-4c7d-b375-9e1b5e467baan%40googlegroups.com.

Re: SVN::GetRootAndHead

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks! Committed in r29682

lördag 9 mars 2024 kl. 21:11:08 UTC+1 skrev Stefan:

> no objections from me.
> The revision for the repo root is the same as for the path, but of course 
> works for non-existing paths as well since the root is never deleted.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8aecee7a-1133-4bd4-968e-cc2038796a4fn%40googlegroups.com.

SVN::GetRootAndHead

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In the users group, a user reported an error when starting View log from 
the repobrowser using a peg revision if the file had subsequently been 
deleted, see [1].

I have investigated and it seems SVN::GetRootAndHead is 
calling GetHeadRevision with a path (which potentially is deleted and thus 
the repository will return an error). A few lines above, the code has 
retrieved the root URL.

I've tried the following patch which seems to resolve the issue.

[[[
Index: SVN/SVN.cpp
===
--- SVN/SVN.cpp (revision 29681)
+++ SVN/SVN.cpp (working copy)
@@ -2806,7 +2806,7 @@
 }
 else
 {
-rev = cachedProperties.GetHeadRevision(uuid, path);
+rev = cachedProperties.GetHeadRevision(uuid, url);
 if ((rev == NO_REVISION) && (m_err == nullptr))
 {
 CHooks::Instance().PreConnect(CTSVNPathList(path));
]]]

Any comments?

Kind regards,
Daniel


[1] https://groups.google.com/g/tortoisesvn/c/N2bp4hyLRI8/m/8MlT8yJ_AAAJ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0f43666c-e282-480f-a77e-161d6ad5a871n%40googlegroups.com.

Re: Nightly builds fail

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 4 mars 2024 kl. 18:56:31 UTC+1 skrev Stefan:

I think the build machine might have the hiccups.
When I check now, the 32-bit build succeeds, but a few language packs fail 
because* '..\bin\Release\bin\restext.exe' failed to start.*
but the restext.exe must be ok because the language packs before that error 
are build correctly.
The x64 build fails now because the TortoiseSVN32_static.dll 
and TortoiseStub32.dll are missing, however looking at the 32-bit build log 
those are properly built.

Let's wait a few days, maybe the hiccups go away.


Nightly builds are back up again. Big thanks to Doug et al for sorting this 
out!

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/df681eb8-24e2-4b68-b5e0-e51bda43be7bn%40googlegroups.com.

Nightly builds fail

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I noticed that the nightly builds have started failing. In the win32 builds 
the build seems to succeed but the MSI generation fails:

[[[
msi: [nant] C:\TSVN\tortoisesvn\src\TortoiseSVNSetup\setup.build setup 
Buildfile: file:///C:/TSVN/tortoisesvn/src/TortoiseSVNSetup/setup.build 
Target framework: Microsoft .NET Framework 4.0 Target(s) specified: setup 
versioninfo: [nant] C:\TSVN\tortoisesvn\versioninfo.build versioninfo 
Buildfile: file:///C:/TSVN/tortoisesvn/versioninfo.build Target framework: 
Microsoft .NET Framework 4.0 Target(s) specified: versioninfo versioninfo: 
[copy] Copying 1 file to 'C:\TSVN\tortoisesvn\src\version.h'. [exec] 
Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET Framework 
[exec] Copyright (C) Microsoft Corporation. All rights reserved. [exec] 
[exec] stdafx.cpp [exec] PathUtils.cpp [exec] Registry.cpp [exec] 
StringUtils.cpp [exec] status.cpp [exec] SubWCRev.cpp [exec] 
UnicodeUtils.cpp [exec] Generating code [exec] Finished generating code 
[exec] SubWCRev.vcxproj -> C:\TSVN\tortoisesvn\bin\Release\bin\SubWCRev.exe 
BUILD FAILED C:\TSVN\tortoisesvn\versioninfo.build(37,8): External Program 
Failed: C:\TSVN\tortoisesvn\bin\release\bin\SubWCRev.exe (return code was 
-1073741515) Total time: 92.8 seconds. BUILD FAILED Nested build failed. 
Refer to build log for exact reason. Total time: 92.9 seconds. BUILD FAILED 
- 0 non-fatal error(s), 3 warning(s)
]]] 

The x64 build in turn fails because of missing file from the win32 build.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/daf70004-3767-4e16-ab7d-d4ef37fb745cn%40googlegroups.com.

Re: Drop translated documentation

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 20 november 2023 kl. 19:23:55 UTC+1 skrev Stefan:

On Monday, November 20, 2023 at 10:56:49 AM UTC+1 daniel.l...@gmail.com 
wrote:

Hi,

A little over two years ago Stefan sent a message on the user list [1] 
about usage of the translated documentation. It only got a single response 
(from me).

The translation of the documentation is done using a Python2 script with a 
script that seems obsolete (xml2po, depending on an external library libxml 
that doesn't seem to exist in Python3). It is non-trivial to rewrite the 
script to Python3 using the available XML processing modules (etree, 
minidom, sax).

This script keeps us from migrating the build tool chain to Python3.

Since there seems to be limited interest in the translated documentation, 
I'm proposing:
- To drop translated documentation from the build scripts.
- To delete the translated docs from the repository: 
Languages/[langcode]/TortoiseDoc.po and doc/images/[langcode] comes to 
mind, possibly others.


doc/xsl/[langcode]

 

- To remove the "Manual" translations from Transiffex
- To reorganise the website and move the translated manuals to a separate 
"translated manuals for older versions".


I suggest to update the website with the next release. No need to remove 
the translated docs now between releases.

And once that's done, don't forget to migrate to python3 :)


Thanks for going ahead with this, I've checked and all looks good to me. I 
updated build.txt as well.

A few nits:

r29640 removed the call to unix2dos from doc.build. I can't find it being 
used elsewhere, unless I'm missing something we could probably remove that 
EXE from the repo.

r29641 removed the includes of translations-docs.html except for one 
instance in the support.zh.html. Was that intentional? I can find no other 
reference to that file so if the last include is removed, the file can 
probably go as well.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e5388bc1-1bb6-4ecc-8c6a-d2d28d2808b3n%40googlegroups.com.

Drop translated documentation

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

A little over two years ago Stefan sent a message on the user list [1] 
about usage of the translated documentation. It only got a single response 
(from me).

The translation of the documentation is done using a Python2 script with a 
script that seems obsolete (xml2po, depending on an external library libxml 
that doesn't seem to exist in Python3). It is non-trivial to rewrite the 
script to Python3 using the available XML processing modules (etree, 
minidom, sax).

This script keeps us from migrating the build tool chain to Python3.

Since there seems to be limited interest in the translated documentation, 
I'm proposing:
- To drop translated documentation from the build scripts.
- To delete the translated docs from the repository: 
Languages/[langcode]/TortoiseDoc.po and doc/images/[langcode] comes to 
mind, possibly others.
- To remove the "Manual" translations from Transiffex
- To reorganise the website and move the translated manuals to a separate 
"translated manuals for older versions".

Anything else to be done?

Kind regards,
Daniel Sahlberg


[1] https://groups.google.com/g/tortoisesvn/c/XJJ473UgSIQ/m/NFhtJguSAgAJ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/764786c1-046f-4903-94af-de787767b843n%40googlegroups.com.

Re: r29635

[Daniel Sahlberg via TortoiseSVN-dev]

söndag 19 november 2023 kl. 20:40:31 UTC+1 skrev Stefan:

On Sunday, November 19, 2023 at 8:19:02 PM UTC+1 daniel.l...@gmail.com 
wrote:

Nit, but why the added ) in line 794 
of /trunk/src/SVN/SVNStatusListCtrlHelpers.cpp?


That's an accident ;)


Was afraid it was a test to see if anyone reviews the commits ;-)

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/27ced97d-2806-4ba8-a6e9-654e44e7f84fn%40googlegroups.com.

Re: "Edit Conflicts" for Excel Files

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 18 november 2023 kl. 22:13:20 UTC+1 skrev Ömer GÜNDÜZ:

Hello again,
Thank you very much for your answer, Daniel. 
After facing challenges in finding an effective conflict resolution method, 
I have opted to utilize my workspace within the OneDrive folder. This 
approach allows us to collaborate on a shared file, with the file owner 
handling the commits for the team. I am curious if there are potential 
issues associated with this method. Has anyone encountered challenges using 
this approach (i.e. TSVN icons will not show up)? Additionally, do you 
recommend employing TSVN within the OneDrive environment?
Thank you in advance for your help


Just so I understand, have you put the complete working copy on OneDrive? I 
have not tried, but if several persons performing SVN actions on that 
folder, I would imagine that OneDrive will encounter conflicts on the 
databases and files within the .svn administrative folder. That is probably 
a BAD idea.

The Subversion approach to non-mergeable binary files is to use locking, 
see the description of svn lock in the svn book [1]. This can be enforced 
by the svn:needs-lock property, see [2]. That way you don't have any merge 
conflicts, at the cost of only one person being able to work on a 
particular file at each time.

Kind regards,
Daniel

[1] https://svnbook.red-bean.com/en/1.7/svn.advanced.locking.html
[2] 
https://svnbook.red-bean.com/en/1.7/svn.ref.properties.html#svn.ref.properties.versioned-props



-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/5b0818c3-5f72-4031-ad61-b35734fcc545n%40googlegroups.com.

r29635

[Daniel Sahlberg via TortoiseSVN-dev]

Nit, but why the added ) in line 794 
of /trunk/src/SVN/SVNStatusListCtrlHelpers.cpp?

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0897ec47-3cbf-45b9-899f-46a1c895b60en%40googlegroups.com.

Re: debugging TSVN in Visual Studio 2022

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 16 november 2023 kl. 14:47:03 UTC+1 skrev Stefan Sperling:

On Wed, Nov 15, 2023 at 10:45:46AM -0800, Stefan via TortoiseSVN-dev wrote: 
> [image: Screenshot 2023-11-15 194517.png] 

Thank you both, Daniel and Stefan. 

I see how this works now. TortoiseProc takes an argument which specifies 
a subcommand to run, which spawns a specific TSVN dialog, which can then 
be debugged. 
This wasn't clear from the description in debug hints. I wasn't sure what 
"createpatch" was referring to. I assumed it was something related to 
patching the real .dll file over the stub .dll, but this not the case. 

I can now step through the debugger during operations like 
"command:update". 
So that goal has been reached :) 

Next, I need to figure out an issue where the Explorer context menu takes 
a long time to appear after right-click on a working copy folder, but 
comes up instantly on other folders. Any hints where a suitable breakpoint 
location might be that would allow me to understand what the extra time 
is being spent on? In any case, I'll keep looking.


Doh. Context menu is a pain. Is it the new one (Win 11) or the classic (Win 
10 and below)? Is it consistent? I have a feeling the new context menu 
sometimes takes forever to load (this is not only TSVN but for all programs 
that add their own entry); after right click there is a "Loading..." text 
that is replaced by "Open in Terminal", "TortoiseSVN" etc. after some delay.

Building support for the new context menu is a PITA. I assume you saw the 
section "digitally signing the binaries and installers". I don't have an 
official code signing cert and I couldn't find the tools indicated by 
build.txt. After some significant searching I've made the following notes 
to myself:

[[[
New-SelfSignedCertificate: https://go.microsoft.com/fwlink/?LinkId=386828.
Timestamp server: http://timestamp.comodoca.com/authenticode

PS C:\Users\danie> $cert = New-SelfSignedCertificate -Subject 
"CN=dsahlberg" -CertStoreLocation "Cert:\CurrentUser\My" -KeyExportPolicy 
Exportable -KeySpec Signature -KeyLength 2048 -KeyAlgorithm RSA 
-HashAlgorithm SHA256 -Type CodeSigningCert
PS C:\Users\danie> Export-PfxCertificate -cert 
"Cert:\CurrentUser\My\$($cert.Thumbprint)" -FilePath 
c:\devel\codesigning.pfx -Password $(ConvertTo-SecureString -String 
"mypassword" -Force -AsPlainText)
]]]

"PS" indicates that this is run under PowerShell. I wasn't sure enough to 
know if it was only me or build.txt should be updated to those utilities so 
I left that for another day.

I think the context menu is implemented in the TortoiseShell/TortoiseStub 
projects and I don't think they are called by a /command: in TortoiseProc 
but rather loaded directly to the Explorer process as a DLL.

I'd probably start by adding some profiling to whatever Explorer calls to 
create the context menu (CShellExt::InsertSVNMenu?) and start from there. 
There is some profiling in the class ProfileTimer (in Utils\DebugOutput.h) 
that can probably help. I'm not so sure how easy it would be to connect to 
the running Explorer process but that might be possible if you can 
reproduce the issue.

Good luck!

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/28a0f666-5f0c-4fa8-a347-4993b5152427n%40googlegroups.com.

Re: debugging TSVN in Visual Studio 2022

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 15 november 2023 kl. 16:17:26 UTC+1 skrev Stefan Sperling:

I am trying to follow the file notes/Debug-Hints.txt in order to set 
breakpoints in TortoiseSVN. 

I am stuck at the following step: 

- Start VS.NET and load the TortoiseSVN 
solution file. Set the TortoiseProc 
project as "startup project". 
In the properties page of the project, 
add the following command line: 
/command:createpatch /path:"path/to/wc" 
(substitute "path/to/wc" with a path 
to an existing working copy). 

Which properties page is this referring to exactly? 
When I right-click on TortoiseProc I see a 'Properties' item at the very 
bottom 
of the menu. This opens a dialog called 'TortoiseProc Property Pages' which 
has 
a nested menu of Configuration Properties: General, Advanced, Debugging, 
VC++ 
Directories, C/C++ etc. etc.


If I remember correctly, you should find the command line setting under 
Debugging. 
However 
https://stackoverflow.com/questions/4791140/how-do-i-start-a-program-with-arguments-when-debugging
 
suggest this might be slightly different in Visual Studio 2022. 
Unfortunately I'm not on my Win dev machine right now so I can't provide 
screenshots.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/c8b86a11-8366-4d34-99f1-e557bee1c96dn%40googlegroups.com.

Re: "Edit Conflicts" for Excel Files

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 8 november 2023 kl. 11:47:13 UTC+1 skrev Ömer GÜNDÜZ:

Hello,
I am searching for an effective solution to edit conflicts in Excel files. 
So, I've installed the "Spreadsheet Compare" add-ins owned by Stevetowner (
https://sourceforge.net/projects/spreadshcompare/) to my Excel. It is 
successful in visualizing the differences between two Excel files. However, 
I cannot integrate and use it for edit conflicts with TSVN. Would you 
happen to have any suggestions? Is it possible to call add-ins with TSVN 
scripts?
Thnx in advance.


Have you checked the user manual section on how to configure external diff 
/ merge tools? 

https://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-settings.html#tsvn-dug-settings-progs
 

You might have to write a custom wrapper (the existing ones for merging 
Word documents should be a good starting point) to open Excel and configure 
the addin.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2727efbc-3662-4719-b4f8-4506138f385bn%40googlegroups.com.

Re: Add additional information to the Windows Explorer Title Bar - SVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 17 oktober 2023 kl. 01:25:04 UTC+2 skrev arathb...@gmail.com:

I found this info in the documentation:
https://tortoisegit.org/docs/tortoisegit/tgit-dug-settings.html

ModifyExplorerTitle

When using the status cache, the title bar of explorer windows are modified 
to include the branch name, stash count and if an upstream is set also the 
outgoing and incoming commits. Set this to false if you don't want this or 
if you have other tools which already do that. The default is true.
Best regards.
On Monday, October 16, 2023 at 4:19:47 PM UTC-7 Arath Burgos Hernandez 
wrote:

Hi Everyone,

I saw this interesting feature in TortoiseGit (attached 
as currentBranchInTittle.png).
Which can be enabled as follow (attached 
as currentBranchInTittle_TGit_Setting.png).
The feature basically integrates the current branch in Windows Explorer 
Title when it is a Git repo.

I saw that it was developed in this commit:
https://github.com/TortoiseGit/TortoiseGit/commit/2871c9646ef0931c955ef1617a6e7db00e0e43ad

However, this feature is not available for TortoiseSvn. I know that Git is 
better than Svn. Unfortunately, I have to continue using SVN yet. It would 
be great to have this feature.


I tried to download an re-compile the project but I had some issues. Do you 
know if is it too complicated integrate that change on TortoiseSvn?


A difference between Git and SVN is that a branch in Git is something that 
applies to a whole repository. In SVN, a branch is only a certain directory 
within the tree, copied from some other directory. By convention, branches 
live in /branches but there is nothing in the SVN design enforcing this. A 
repository can also contain multiple projects where each project has its 
own directory (with "branches" below). Finally, the equivalent of the Git 
Master/Main branch is the directory /trunk, which doesn't live beneath 
/branches at all.

So the problem to solve is how to figure out the branch name. The only way 
is to have some heuristics that look at the path name, but that is bound to 
fail sooner or later depending on the repository layout.

What was the problem compiling? Can we help with that?

Kind regards,
Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ebb28d0b-ca83-41f0-9cdf-c5fecbd2aab1n%40googlegroups.com.

1.10.x EOL

[Daniel Sahlberg via TortoiseSVN-dev]

As the Subversion project just announced 1.10.x as EOL (in reality it has 
been EOL since April last year), I've removed the download links from the 
website. I couldn't find a news article from other EOLs so I didn't add 
anything.

On the Download page, there is a section on the "Context menu in 
file-open/save dialogs" there is a reference to Windows 7 / Windows 8. Do 
we still support those or should this section be removed?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/de2dbc8f-c47a-41bd-8433-9e44e711eab3n%40googlegroups.com.

r29609

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In r29609 there is a text "based upon their visit to www.website.com". 
Looks like boilerplate text where the URL should be replaced with the 
actual URL that should be replaced with "www.tortoisesvn.net"`, or is this 
intentional?

Kind regards,
/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d9b2334f-4c66-4cc8-8c24-3eb34cb55c82n%40googlegroups.com.

Re: Merge fail and call to GenerateMergeLogMessage()

[Daniel Sahlberg via TortoiseSVN-dev]

söndag 6 augusti 2023 kl. 18:56:39 UTC+2 skrev Stefan:


agreed.


Thanks for the suggestions. All done in r29601 and r29602.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e8621f03-7708-4b2f-adae-60a9d75fde6bn%40googlegroups.com.

Merge fail and call to GenerateMergeLogMessage()

[Daniel Sahlberg via TortoiseSVN-dev]

Prompted by the discussion in the users group [1], I've been investigating 
why the prompt to merge doesn't appear sometimes.

When merging with a specified range, CSVNProgressDlg::CmdMerge() is used 
while merging without a range (or All revisions) is 
using CSVNProgressDlg::CmdMergeAll().

CSVNProgressDlg::CheckUpdateAndRetry() should check if an update is 
required:
if (GetSVNError() && GetSVNError()->apr_err == 
SVN_ERR_CLIENT_MERGE_UPDATE_REQUIRED)
... prompt the user to update or cancel ...

In CmdMerge, the call to GenerateMergeLogMessage() (line 3384) seems to 
reset the latest error (SVNBase::m_err) so GetSVNError() will return false.

A naive fix would be to condition the call to GenerateMergeLogMessage() 
with if (!bFailed), however that is a direct revert of r27728 "Generate the 
merge log message even if the merge returned with an error: a merge 
conflict also returns an error.".

I'm instead considering to check GetSVNError() and the actual error message 
but I don't have enough knowledge about the different error messages that 
could appear.

Ideally, I'd like to do check for a list of error messages that indicate a 
merge failure and create a log message in these cases (it seems unneccesary 
to create a log message in case of a network failure). Unfortunately I 
don't know how to figure out this list of error messages.

Another option would be to check for only 
SVN_ERR_CLIENT_MERGE_UPDATE_REQUIRED. That would solve the current bug but 
could open up for other bugs in the future if/when we want to look for 
other error messages later in the code.

Any opinion on this?

On a side note, CmdMergeReintegrate() (and CmdMergeReintegrateOldStyle() 
and  CmdMergeReintegrateOldStyle()) should probably also be changed to run 
GenerateMergeLogMessage() in case of a merge conflict to give similar 
behaviour in all kind of merges.

Kind regards,
Daniel



[1] https://groups.google.com/g/tortoisesvn/c/i15g_7BYhgI

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d1608ebc-829c-42d7-bf37-d1a7d69539f4n%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 29 juli 2023 kl. 07:27:47 UTC+2 skrev Stefan:

On Friday, July 28, 2023 at 10:43:06 PM UTC+2 daniel.l...@gmail.com wrote:

If there's anything I missed, just shout.


 Looks good I think.

How about updating https://openhub.net/p/tortoisesvn?


updated the url yesterday, but the status is still "Step 1 of 3: 
Downloading source code history (Waiting in queue)". Well, the stability of 
openhub is almost as bad as osdn.net :(


The job was subsequently flagged as "do not fetch". I sent a mail to them 
and they say they restarted the sync job so now it is back in queue. Let's 
hope for the best.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/488ef9d9-b139-4b5f-9dc6-18c856fefbd9n%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

If there's anything I missed, just shout.


 Looks good I think.

How about updating https://openhub.net/p/tortoisesvn?

I saw that the issue tracker is active. I have mixed feelings about issue 
trackers, they often tend to be a dump of things which no-one care about 
enough to fix. Maybe hide it in the menu?

/Daniel



-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/860dff17-a629-4507-b97f-cf4a0e20f470n%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

Now even the OSDN Subversion repository seems to be offline (don't know if 
that was intentional or not).

$ svn ls https://svn.osdn.net/svnroot/tortoisesvn/trunk
svn: E170013: Unable to connect to a repository at URL 
'https://svn.osdn.net/svnroot/tortoisesvn/trunk'
svn: E02: Could not find the requested SVN filesystem

It seems that the repository on Sourceforge is already up to date:

$ svn info https://svn.code.sf.net/p/tortoisesvn/code
Path: code
URL: https://svn.code.sf.net/p/tortoisesvn/code
Relative URL: ^/
Repository Root: https://svn.code.sf.net/p/tortoisesvn/code
Repository UUID: cc8e0003-5e82-43e2-9771-63201f7d8d9c
Revision: 29592
Node Kind: directory
Last Changed Author: danielsahlberg
Last Changed Rev: 29592
Last Changed Date: 2023-07-07 12:24:13 +0200 (Fri, 07 Jul 2023)

Shall we announce that all commits from now go to SourceForge? (Sorry for 
being explicit about that but I wanted to make sure we are all on the same 
page). I noticed that the repository UUID is different on SourceForge so 
some manual work is required to connect an existing WC to the new 
repository (delete .svn, checkout again).

We then also need to switch the project status from "moved to" to "active".

I can prepare to write something on the website. Shall we also in the same 
time look at migrating the website to SourceForge?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/30195e18-de82-40e5-8276-912375b9e2d2n%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

The offer from VisualSVN is very generous, however considering the recent 
development of the EU CRA regulations, see for example [1], and the 
uncertainty of wether accepting recurring donations from a commercial 
entity would would make the whole project "commercial" (=> ie, bringing in 
a significant bit of paperwork for each release), I would kindly say "no" 
at the moment.

That leaves Sourceforge as the only reasonable alternative at the moment. 
I'm fine with that (and I already have an account).

Kind regards,
Daniel Sahlberg


[1] 
https://news.apache.org/foundation/entry/save-open-source-the-impending-tragedy-of-the-cyber-resilience-act


tisdag 25 juli 2023 kl. 19:54:36 UTC+2 skrev Stefan:

> So no objections to move everything (back) to sourceforge?
> If not, I'll first mark the osdn.net repo as readonly, then get the sf 
> repo working and finally adjust all links of the website and everywhere 
> else to sf.
> I think all people who have commit access to the osdn.net repo also have 
> commit access to the sf.net repo? If not, give me a shout.
>
> Stefan
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4afff71a-de52-416e-b0d8-d31763536662n%40googlegroups.com.

editorconfig built twice

[Daniel Sahlberg via TortoiseSVN-dev]

I'm trying to understand the build system.

editorconfig seems to be built twice when building the "binaries" target 
through different dependencies:
* Via TortoiseSVN => editorconfig
* Via Subversion => build target in ext\build\default.build.

It adds "only" about a second to the builds,  but it seems unneccesary. May 
I suggest that we remove the target in ext\build\default.build?

/Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/260d5468-c237-4031-92b5-0b12d1891a66n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 12 juni 2023 kl. 20:24:38 UTC+2 skrev Stefan:

On Saturday, June 10, 2023 at 6:27:59 PM UTC+2 daniel.l...@gmail.com wrote:

I can reproduce this by:
* deleting %appdata%\TortoiseSVN\logcache
* doing Show log *and clicking a few different revisions*
* Settings, Log Caching, Cached Repositories now show 4 items for the 
repository
* repeating steps 2 and 3 seems to add 4 items to the list per iteration


I still can't reproduce this.


I can reproduce this only with a nightly build (I can even load the EXE in 
Visual Studio, add the PDBs and debug from there). No luck reproducing with 
my own build.
 

Also, I can't see why clicking on revisions in the log dialog would ADD 
something to the cache. I also don't see where this would even touch the 
cache?

 
That was a red herring, sorry. It is enough to just show the log.

Another thing:
The CRepositoryInfo::CData::Add() method is only called from code where 
a CRepositoryInfo::CData::Lookup() is called before. So it should not be 
possible to add entries that already exist.

I'm out of ideas 


I believe the additional entries in the log cache are added from for 
example CRepositoryInfo::GetRepositoryRootAndUUID. It seems like 
CRepositoryInfo::CData::Lookup() fail to find the existing entries.

I have a feeling something goes bad in TFullIndex::const_iterator iter = 
fullIndex.find(std::make_pair(uuid, root)). I can't really find any 

In the nightly builds, Visual Studio claim that fullIndex is "optimized 
away" so I can't really see that it contains, therefor making it difficult 
to debug further. 

I've tried to switch the nightly builds to use the debug target in r29586, 
hoping to see more debugging info in the next nightly build.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/614f9958-ba16-4a9a-9eff-5369e1739cf9n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 8 juni 2023 kl. 19:23:42 UTC+2 skrev Stefan:

I had that situation too, then I added the logic that caused the crashes.
But now I can't get it to show the duplicate entries anymore! I deleted my 
old cache. And showing logs for different repos just don't get me to where 
duplicate entries are shown.


I can reproduce this by:
* deleting %appdata%\TortoiseSVN\logcache
* doing Show log *and clicking a few different revisions*
* Settings, Log Caching, Cached Repositories now show 4 items for the 
repository
* repeating steps 2 and 3 seems to add 4 items to the list per iteration

When checking %appdata%\TortoiseSVN\logcache, it seems only 
Repositories.dat is actually changed by steps 2 and 3 (at least as long as 
I'm clicking the same revisions).

I'm out of time right now (and away from my main dev machine) so I can't 
debug any further, but I hope this can give a few more ideas. I'd start 
looking in the Show log code next, specifically when things are added to 
the data vector.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8bd4e30a-c86e-44c7-a994-959151d0632cn%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

- Good news: No more crasches.

- Bad news: Logcache shows a lot of duplicates. There seems to be only one 
file in %appdata%\TortoiseSVN\logcache.

So something should probably be done to the logcache "add to cache" logic. 
I'm favoring letting Add() have the same functionality as AutoInsert 
already has (and getting rid of the latter). However no time to look at the 
code before next week (probably not before next weekend).

/Daniel
tisdag 6 juni 2023 kl. 19:59:36 UTC+2 skrev Stefan:

> you're right. The problem is the == operator. To work properly it would 
> require to know the settings allowAmbiguousUrl/Uuid and act accordingly.
> While that could be done, it would make for very ugly code.
>
> I added the 'avoid duplicate' code because my local cache showed 10 
> entries for the same repo in the settings dialog. But maybe my cache was 
> just corrupted.
> So I reverted that commit for now. If I ever get those multiple entries 
> again, I'll try to come up with a solution that works.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/be411ccb-02e1-446b-b2ab-3e844f0ec7fan%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks! I'll test the nightly build tomorrow.

Any idea why only the nightly build would fail and not when I built it 
myself? The settings should have been the same...

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/b48f40a7-54d7-46ab-9d34-c9e769aa6882n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

I really need some help with this...

My understanding is as follows:
CRepositoryInfo::CData::AutoInsert() is called to find/add an 
SPerRepositoryInfo() object (basically a {uuid, root} tuple) to data (and 
urlIndex, uuidIndex, fullIndex). 
It will first call CRepositoryInfo::CData::Lookup() to see if there already 
exists an object with the key {uuid, root} by searching fullIndex (and 
possibly uuidIndex, urlIndex, depending on the AllowAmbiguousUUID and 
AllowAmbiguousURL settings). If it finds something it will return a 
pointer, otherwise nullptr.
If Lookup() returns a nullptr, CRepositoryInfo::CData::Add() is called to 
create a new SPerRepositoryInfo and to add it to data (and urlIndex, 
uuidIndex, fullIndex).
However Add() will "avoid duplicate entries" by searching data 
with std::ranges::find_if() and checking for equality using 
SPerRepositoryInfo::operator==(). If it finds a duplicate, it will not add 
anything to the data/indicies.
AutoInsert() will then try the Lookup() again to find the newly added 
object and assumes success since the object was just Add()ed.

Only in my test case the object was NOT added by Add(), since Add() hits 
line 176 and returns "to avoid duplicate entries".

I believe there is a difference between the code in Lookup() (using 
fullIndex.find(std::make_pair(uuid, root))) and the code in Add() 
(using std::ranges::find_if(data, [&](auto* i) { return (*i) == info; }) 
where the code in Lookup() fail to find an object that is later found by 
Add().

However I'm not clever enough to figure out what the difference is. I was 
first suspecting that SPerRepositoryInfo::operator==() was too sensitive, 
but I figure if that was the case objects would be added even though they 
are "duplicate".

I'm currently leaning towards changing CRepositoryInfo::CData::Add(const 
SPerRepositoryInfo& info) to return a pointer to the newInfo object, to let 
AutoInsert return this instead of doing another Lookup(), but I feel this 
would only plaster over the difference between the code in Lookup() and 
Add().

I'm also considering reverting r29558 (which added the "avoid duplicate 
entries" in Add()) but I'm assuming it was added for good reasons.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/48e3e330-85ca-4299-9488-8d0a01e15a3fn%40googlegroups.com.

Re: build.txt

[Daniel Sahlberg via TortoiseSVN-dev]

I did a followup in r29578 to update the 'cross' option to only support 
ARM64. I hope I got it right. I suppose it would be possible to 
crosscompile for x86/x64 on ARM-VS, but I have no way of testing.

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/eb04eb85-7f8b-480e-8f12-cd0f5162ca09n%40googlegroups.com.

Re: Enable asm for OpenSSL

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 3 juni 2023 kl. 18:48:01 UTC+2 skrev Stefan:

good idea, haven't thought of the "schedule" action :)


Learnt about it from the best in r29552 ;-)

I've tried to come up with something useful in r29579, let's hope I didn't 
screw up too badly.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ca84e556-af5c-410b-b3e0-e8b822faee54n%40googlegroups.com.

Re: Enable asm for OpenSSL

[Daniel Sahlberg via TortoiseSVN-dev]

I can ask Ian to install nasm on the build machine, but I have no idea how 
long that will take.
Could you maybe add a nant target that enables the asm build and still use 
no-asm if the nant target was not called? That way the nightly builds would 
still run through with no-asm. And users who don't have nasm installed can 
also build without changes.


That is a good idea, although I'd rather prefer to make it asm by default 
and have a no-asm target since that matches the default in OpenSSL. We can 
always have the "schedule" target add the no-asm option.

/Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6bc68eb7-cf59-4f90-b17f-bedd6c200279n%40googlegroups.com.

Re: build.txt

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks. r29576. I also added instructions for building the ARM 64 version 
in Win64. I'd love to test building natively on ARM but I don't have such a 
machine...

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/907bc50f-f721-4ae9-b120-58aeee56b767n%40googlegroups.com.

build.txt

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Since Visual Studio 2022 doesn't install on 32-bit operating systems[1], we 
could simplify build.txt by removing the section "build64cross Building 64 
bit packages on win32 (cross-compile)".

Is this ok or am I missing something?

Kind regards,
Daniel Sahlberg


[1] 
https://learn.microsoft.com/en-us/troubleshoot/developer/visualstudio/general/visual-studio-2022-unsupported-operating-systems

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/80996ea8-7306-41dd-857b-f4b3e1ca4847n%40googlegroups.com.

Re: osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

I'm also aware of the story of SourceForge and I feel reluctant suggesting 
to go back there.
Github seems like a solid choice if it wasn't for the Git part (I'm not 
against Git as such but using Git for TortoiseSVN seems wrong). I've heard 
about some interesting build automation workflows but I'm also not aware of 
their features and exact terms.
Otherwise there are a few companies making business based on Subversion 
hosting / products that might be interested in sponsoring at least the 
source code hosting.

Maybe a combination of repository hosting at some "closely related company" 
and website / release artifacts on Github.

Kind regards,
Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/dfb96be9-6a86-4123-9ee6-528dc30a25c6n%40googlegroups.com.

osdn.net longterm stability

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

osdn.net seems to have issues [1] and I'd like to bring it up to make sure 
that we don't end up in a situation where it starts affecting TortoiseSVN.

* Nobody seems to monitor the issue tracker [1] anymore - it is full of 
spam and no-one seems to respond to issues. It is mentioned in one of the 
issues [2] that "there is no more support here".
* Several different errors occur throughout the site: Accessing the source 
code through the web interface [3] only report an error message.
* The commit notify e-mail contain a link [4] to the web page, however the 
link give the same error message as elsewhere in the web interface.

As far as I know we use osdn.net for the source code repository and for 
hosting release artifacts (installers and documentation).

So far I've seen no negative effects on development and/or distribution 
workflows but as the support is not there anymore I think we need to think 
about a backup plan.

I've personally configured an svnsync mirroring of the repository to have a 
backup in place - I know there is also a mirror in Github so we should not 
risk loosing source or history. The release artifacts also seem easy enough 
to mirror, but I havn't done that yet.

- Does anyone know more about what is going on with osdn.net?
- Did I miss any useage of osdn.net above?
- Does it make sense to make a contingency plan or even migrate away from 
osdn.net? The list of free hosting is rather thin (except Github, but 
migrating the repository to git would be.. should I say against the spirit 
of the project).

Kind regards,
Daniel Sahlberg

[1] https://osdn.net/projects/support/ticket/
[2] https://osdn.net/projects/support/ticket/47324
[3] https://osdn.net/projects/tortoisesvn/scm/svn/tree/head/
[4] https://osdn.net/projects/tortoisesvn/scm/svn/commits/29571

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1d3cb951-2fe0-4fcb-b06e-3387171c989fn%40googlegroups.com.

Re: Enable asm for OpenSSL

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 juni 2023 kl. 20:11:11 UTC+2 skrev Denis Kovalchuk:

> Very interesting results. Did you run this on a build from /trunk/ -
> ie with OpenSSL 3.1?

Yes, these results were from trunk with OpenSSL 3.1. However, I believe that
they should be similar with OpenSSL 1.1.x as well.


Thanks for confirming.

> The reason for the no-asm option was that the asm code often (it felt like
> every other release) was broken. Either with the asm that comes with VS,
> or later with MASM as well: When they switched to requiring MASM I thought
> the build problems were solved, but the second version after the switch
> failed again.
>
> So I had enough and used the no-asm switch.

Let me try to summarize and list a few more reasons on why I think that
switching to the default OpenSSL build could be beneficial for the project:

1. The improvement comes from using AES-NI instructions for HTTPS.

So this should reduce the CPU usage for all network operations. Perhaps, it
could be especially visible on low-tier hardware.


I doubt there will in average be much gain by handoptimizing ASM code 
compared to a modern compiler. But if it is required to get access to 
AES-NI and similar specialized instructions, it make sense.

2. Spending less CPU on common operations means more laptop battery time
and more CPU available for other tasks, in all setups.

For example, here are a couple of additional benchmarks performed over
typical 1Gb LAN that illustrate the overall CPU time reduction:

Null-export of Subversion root dir, 1Gb LAN:
CPU time: 130 sec  8 sec (16x less CPU used)
Total time: 175 sec  175 sec
Avg CPU load: 74%  4%

Null-export of .iso file, 1Gb LAN:
CPU time: 13 sec  1 sec (13x less CPU used)
Total time: 63 sec  63 sec
Avg CPU load: 20%  2%


If I understand the figures, the total time doesn't change, ie the CPU is 
quick enough to decrypt the traffic in either case. But the CPU spends more 
time idling with the ASM optimized code. (With a faster network, the CPU 
will of course be the bottleneck).

The improvement on the export of the Subversion root dir is even more 
impressive.

Power consumption is a valid argument, although I doubt that the power 
consumption from SVN usage will make a noticeable difference in total 
battery life - I assume `svn up` (or `svn export`) is a relatively 
infrequent operation for the average developer. Still, if it doesn't have 
negative side effects why not use it.

3. Building OpenSSL with assembler support is the current default.

Multiple known projects such as Node.js seem to use and regularly test this
configuration on different platforms and provide additional test coverage.
Compared to that, I think that the `no-asm` build falls into the group of
non-standard configurations (maybe even not intended for production use),
and therefore it could be far less tested in practice.


I agree the no-asm seems to be the less supported option. Quoting again 
from the OpenSSL INSTALL.md: "This should be viewed as 
debugging/troubleshooting option rather than for production use."

4. Perhaps you are right about the real setups/throughput, but SVN is good
at handling large files and so there might be users that have multi-terabyte
repositories containing assets and other large binaries.


The large file handling has been a motivation for a recent development of 
Subversion, the "pristine-less working copy" concept. Yet to be released, 
but it is part of Subversion /trunk.

To summarize: I'm +0 to removing the no-asm. I'd like to build it myself 
before upgrading to +1, we also need to figure out a plan to update the 
nightly build servers so we don't break the nightly builds again. (I 
believe the nightly builds are provided by a third party, with Stefan being 
the only one in contact with them).

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d7617d8d-6a18-4e16-8a3d-45d989a5792fn%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 31 maj 2023 kl. 22:05:23 UTC+2 skrev Evgeny Kotkov:

Daniel Sahlberg  writes: 

> Evgeny, 
> 
> Since r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be 
> using the 1.3.x branch. Builds seems fine, I've been using them for a 
> few days. 

Serf 1.3.10 with support for OpenSSL 3 has been officially released [1], so 
I'm guessing that TortoiseSVN can now be switched to the official version. 

(And thanks for giving the pre-release version a spin, it was useful to 
know 
that there are no problems related to serf/OpenSSL 3.) 

[1] https://lists.apache.org/thread/59sfvyv1c8oovxt73pb86foc7jgrcl25


Thank you Evgeny for pushing the Serf 1.3.10 release!

I've changed the svn:external to point to the 1.3.10 tag in r29571. I will 
check the nightly builds tomorrow and switch to it on my dev machine. 

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/9e222a89-b681-43e6-904b-7964dea756edn%40googlegroups.com.

Re: Enable asm for OpenSSL

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 29 maj 2023 kl. 16:39:28 UTC+2 skrev Denis Kovalchuk:

Hi!

I am wondering if there are any reasons to build OpenSSL with the

'-no-asm' [1][2] option?

 


Below are the results of synthetic benchmarks for Subversion, depending on

whether OpenSSL is built with or without asm support:

1) OpenSSL is built with the ‘-no-asm’ option.

svnbench null-export https://localhost/svn/iso/~7GB.iso

0 directories

1 files

7,395,016,704 bytes in files

0 properties

0 bytes in properties

50.812102 seconds taken

7,404,963,366 bytes transferred over network

2) OpenSSL is built without the ‘-no-asm’ option.

svnbench null-export https://localhost/svn/iso/~7GB.iso

0 directories

1 files

7,395,016,704 bytes in files

0 properties

0 bytes in properties

17.406729 seconds taken

7,404,963,353 bytes transferred over network

This ~3x improvement is well observed when dealing with localhost, where the

network bandwidth is high enough.


Very interesting results. Did you run this on a build from /trunk/ - ie 
with OpenSSL 3.1?

The no-asm seems to be added in r18542 (2010-02-06), with the comment 
"Update to OpenSSL 1.0.0 beta 5". I've searched the mailing lists 
(https://svn.haxx.se/tsvn/) and couldn't find a motivation why no-asm was 
required. 

The OpenSSL INSTALL.md notes:

[[[
### no-asm

Do not use assembler code.

This should be viewed as debugging/troubleshooting option rather than for
production use.  On some platforms a small amount of assembler code may 
still
be used even with this option.
]]]

So I would like to suggest enabling asm support for OpenSSL, unless of 
course
there is a reason to build OpenSSL with the '--no-asm' option. Note that 
this
change requires NASM [3] to build TortoiseSVN.


Considering the OpenSSL documentation suggest that no-asm is a debug-ish 
option, I'm +0 for removing it.

I didn't try to build it yet, but I will do this as time permits.

I'd like to note that we need to get NASM installed on the nightly-build 
machines.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ea5ffbc9-60be-493d-a44a-6bd9efecb7ddn%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 27 maj 2023 kl. 07:38:48 UTC+2 skrev Stefan:

and I still don't see the crash on my machine.
Tried showing log for several working copies, single files in them. Even 
showed the log for urls instead of local paths.
I don't get any crashes or error messages about illegal repo urls.

Also deleted the whole log cache and tried everything again. Still, no 
crash for me :(


It is a bit strange; I can't reproduce the issue under Visual Studio or 
even with my own builds. However with the nightly builds there is a crash. 
I downloaded the nightly builds and the debug symbols and I believe I have 
a trace.

In CLogCachePool::GetCache

repositoryInfo->data.AutoInsert(uuid, root)

return a nullptr. This seems to come from CRepositoryInfo::CData::Lookup 
not finding hitting a suitable record.

There is also a call to CRepositoryInfo::CData::Add that hits the new 
"avoid duplicate entries" check - I don't know if that would have made the 
call to AutoInsert succeed if Lookup didn't find a record.

I noticed that I only get the crasch if I uncheck the "Allow ambiguous 
URLs" and "Allow ambiguous UUIDs" in the settings.

Hopefully this may add some more information.

Kind regards,
Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/37add1ec-7d3d-463f-bc26-b01a0702a658n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 24 maj 2023 kl. 21:52:29 UTC+2 skrev Daniel Sahlberg:

I've reverted this in r29564 and the crash seems to be gone.


Unfortunately it was not enough, the log still crash (I've also seen the 
same error as in Pavel's screen shot "Illegal repository URL 
'[gibberish]'". I'll try to take a second look.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/5b8e4c65-0a54-4384-97ec-667615e91c24n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 19 maj 2023 kl. 11:12:15 UTC+2 skrev Evgeny Kotkov:

Daniel Sahlberg writes: 

> - Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 
compatibility, 
> I'm hoping for a new release of Serf before the next Subversion/TSVN 
> release, otherwise there is a simple patch we can apply in the build 
> process). 

With the recent backports on the branch, serf 1.3.x should work fine with 
OpenSSL 3. There is no release yet, but perhaps it would be nice to switch 
TSVN externals to the current state of the serf 1.3.x branch, to ensure 
that 
everything works as expected.


Evgeny,

Since  r29562 (nightly builds 2023-05-21 and later) TortoiseSVN should be 
using the 1.3.x branch. Builds seems fine, I've been using them for a few 
days. Please be aware of a regression in the LogCache, hopefully fixed in 
r29564 (nightly builds 2023-05-25 and later).

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn-dev/c/lTyZdQwpvGo

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/3b7d4218-2936-4f2d-850d-f34c6b7403a2n%40googlegroups.com.

Re: Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 23 maj 2023 kl. 18:53:06 UTC+2 skrev Stefan:

I made a few changes to the log caching, but those changes are mostly 
refactoring.
Unfortunately, I can't reproduce a crash of the error message on my machine 
here.

Maybe you guys can debug the problem on your machine?'


I found a way to reproduce it: when I deleted the log cache, the error also 
occured within Visual Studio.

I believe the error is the following change. Please note the comment, it 
was added in r14384 when the arguments was changed from const CString& to 
CString (ie, the opposite of the change below). I'm supporting the analysis 
that the parameters may come from a cache entry being deleted, in this case 
from a call in CLogCachePool::AutoRemoveUnused() where the 
repositoryInfo->data object is iterated and then the very same object is 
deleted by DropEntry. Suddenly the uuid and urls are unreachable.

[[[
Index: src/LogCache/RepositoryInfo.h
===
--- src/LogCache/RepositoryInfo.h (revision 29553)
+++ src/LogCache/RepositoryInfo.h (revision 29554)
[...]
@@ -232,27 +232,27 @@
 /// Parameters must be copied because they may stem from the
 /// info object being deleted.
 
-void DropEntry(CString uuid, CString url);
+void   DropEntry(const CString& uuid, const CString& 
url);
 ]]]

I've reverted this in r29564 and the crash seems to be gone.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0e750ce8-a193-446f-be55-2c34f9578552n%40googlegroups.com.

Re: Automated retrieval of SVN comments for documentation purpose

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 23 maj 2023 kl. 09:43:46 UTC+2 skrev socrat...@gmail.com:

Hello Daniel,

Thank you for the details you gave. I really appreciate them.

Another couple.of questions:
1. If ever we use command lines to.instruct SVN to retrieve comments for a 
specified date, how do we produce the code and where do we write them? In a 
notepad file.that can be run in SVN?
2. Is it possible that programming languages (Python, JAVA, etc.) could be 
used to prohram SVN to do something similar like.comments retrieval?


The command line client is a standalone EXE file that should be called 
using whatever means your programming language provides. Python for example 
provide a few different ways in the os and subprocess modules. Exactly how 
you do this is probably out of scope for this forum.

 Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/41d13759-2dd5-4248-9ba1-7401746b468bn%40googlegroups.com.

Nightly build crash on SVN Log with log cache enabled

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I'm experiencing crashes in the TortoiseSVN, Show log command 
(tortoiseproc.exe /command:log ...) with the latest nightly builds. If I 
disable the log cache the crashes go away.

Other commands, for example Update, works fine so I don't think it is 
related to the OpenSSL or Serf changes I've been working on.

I'm not able to reproduce it with a source build from /trunk under Visual 
Studio, no idea why. That also makes it a bit hard to bisect.. I will find 
some more time to look at it but the days ahead are quite full already.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2000b98f-c01b-4164-b37a-8b187ae85700n%40googlegroups.com.

Re: No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 5 maj 2023 kl. 14:53:41 UTC+2 skrev Pavel Lyalyakin:

It appears that the issue is still there:
[[[
 [exec] app_libctx.c
 [exec] ..\apps\lib\app_libctx.c(9): fatal error C1083: 
Cannot open include file: 'app_libctx.h': No such file or directory
 [exec] NMAKE : fatal error U1077: '"c:\Program 
Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\cl.EXE"' : 
return code '0x2'
 [exec] Stop.
 [exec] NMAKE : fatal error U1077: '"c:\Program 
Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\nmake.exe"' 
: return code '0x2'
 [exec] Stop.
]]]

And there are no new nightly builds. T_T


Stefan made a cleaver fix in the build script which resolved the conflict 
that prevented a successful build.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4435e3e5-1194-40e7-bf28-9b9e3d5cf00bn%40googlegroups.com.

Re: Automated retrieval of SVN comments for documentation purpose

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 17 maj 2023 kl. 07:00:07 UTC+2 skrev socrat...@gmail.com:

Hello Tortoise Dev Team,

We in our team wanted to create a documentation based on the comments that 
the members of the development team give each time they commit a code 
change to SVN.

Currently, we have set a standard format on how the development team should 
put their comments into SVN upon commit:







My question now are:
1. Would it be possible to develop an automated way where SVN retrieves all 
comments from a date range that we would define?


Try the command line client: svn log
(It is included with TortoiseSVN but you must select it in the installer)
Please check the SVN book at:
https://svnbook.red-bean.com/en/1.7/svn.ref.svn.c.log.html

The --xml argument might be useful if you prefer to parse XML rather than 
plain text. 

2. Once the comments from the date range have been gathered, is there a way 
where SVN can make a file containing the same details as the format of the 
comment I mentioned above.


A few examples can be found in the Subversion project:
https://svn.apache.org/repos/asf/subversion/trunk/tools/dev/gnuify-changelog.pl
https://svn.apache.org/repos/asf/subversion/trunk/tools/examples/svnlog2html.rb
https://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/svn2cl/
The last one is rather advanced and can handle filtering, sorting and 
formatting.

3. Relative to question # 2, is there a way we can customize the contents 
of the file according to our needs. Then, once the file has been created, 
would we be able to save it in our local folders or directories?


Yes, see the examples in #2.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7f1c33e4-b475-490a-b197-c37243c314ean%40googlegroups.com.

Re: No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 22 april 2023 kl. 07:13:50 UTC+2 skrev Stefan:

I've mailed Ian, and he deleted the include folder and ran an 'svn up', so 
there should not be any more conflicts.
But the build still fails...


Sorry it took a while for me to circle back to this - I looked quickly and 
everything seemed fine and it took some time to take a closer look.

I believe 'svn up' might not be enough if there is already a tree conflict. 
I think I reproduced the issue by updating to r29539, building, then trying 
to update to HEAD. I had do 'svn resolve' (selecting r to Mark as resolved) 
and 'svn revert ext\openssl\apps\include --depth=infinity' followed by 'svn 
up'. After this I had a clear 'svn st' and the build succeeded.

/Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/0b8263ce-4876-4239-a6a6-4ef5134134afn%40googlegroups.com.

Re: Windows Search stopped indexing folders containing .svn and .git subfolders

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 28 april 2023 kl. 10:14:16 UTC+2 skrev i.ku...@soton.ac.uk:

The above is a major pain! I am very remote from software development, but 
how difficult would it be to add an option to give those folders different 
names in local copies when TortoiseSVN is installed? - Ilya


There is an option to ask Subversion to use the directory name "_svn" 
instead of ".svn", see the SVN Book: 
https://svnbook.red-bean.com/en/1.7/svn-book.html#svn.basic.in-action.wc

I'm not sure if/how well it works with TortoiseSVN but since it is done in 
the Subversion library, I assume it should work.

Towards the end of this superuser.com article, there is a suggestion to 
exclude .git folders making the indexer work again, maybe the same works 
with .svn folders:

https://superuser.com/questions/1540945/how-to-stop-windows-search-from-auto-excluding-repository-folders

Kind regards,
Daniel Sahlberg
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/c513afa9-b468-4992-a6b3-a15a88fe8235n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 12 april 2023 kl. 16:59:15 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 22:47:54 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.


There was a quick response on the Subversion dev mailing list [1] and a fix 
has already been committed in the APR tree. It should be possible to switch 
to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.


APR will shortly release 1.7.4 with the above fix as the only change. The 
1.7.4 tag already exists and it builds fine and the error is gone.

Any objections to switch to 1.7.4?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/07c6b646-4c40-4773-acaa-f061cda4850dn%40googlegroups.com.

No nightly builds

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Nightly builds currently fail with:

[[[
[exec] Microsoft (R) Program Maintenance Utility Version 14.30.30706.0 
[exec] Copyright (C) Microsoft Corporation. All rights reserved. [exec] 
[exec] "cl" /Zi /Fdossl_static.pdb /MD /Zl /Gs0 /GF /Gy /W3 /wd4090 /nologo 
/O2 -I"." -I"include" -I"apps\include" -I".." -I"..\include" 
-I"..\apps\include" -D"L_ENDIAN" -D"OPENSSL_PIC" 
-D"OPENSSLDIR=\"C:\\Program Files (x86)\\Common Files\\SSL\"" 
-D"ENGINESDIR=\"C:\\TSVN\\tortoisesvn\\ext\\build\\ext\\openssl\\out32\\lib\\engines-3\""
 
-D"MODULESDIR=\"C:\\TSVN\\tortoisesvn\\ext\\build\\ext\\openssl\\out32\\lib\\ossl-modules\""
 
-D"OPENSSL_BUILDING_OPENSSL" -D"OPENSSL_SYS_WIN32" -D"WIN32_LEAN_AND_MEAN" 
-D"UNICODE" -D"_UNICODE" -D"_CRT_SECURE_NO_DEPRECATE" 
-D"_WINSOCK_DEPRECATED_NO_WARNINGS" -D"NDEBUG" 
-DOPENSSL_SSL_CLIENT_ENGINE_AUTO=capi -DOPENSSL_CAPIENG_DIALOG -c 
/Foapps\lib\libapps-lib-app_libctx.obj "..\apps\lib\app_libctx.c" [exec] 
app_libctx.c [exec] ..\apps\lib\app_libctx.c(9): fatal error C1083: Cannot 
open include file: 'app_libctx.h': No such file or directory [exec] NMAKE : 
fatal error U1077: '"c:\Program Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX86\x86\cl.EXE"' : 
return code '0x2' [exec] Stop. [exec] NMAKE : fatal error U1077: 
'"c:\Program Files\Microsoft Visual 
Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX86\x86\nmake.exe"' 
: return code '0x2' [exec] Stop.
]]]

I assume the missing header file was my mistake on the OpenSSL 3 upgrade. 
However, I added those in r29540 and I can't figure out why this isn't 
picked up by the nightly builds.

"openssl/apps/include" was previously an ignored folder (r29014), could it 
be that the build host is stuck on a tree conflict from r29540?

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/872a077a-15b4-4bea-88d0-a50cb4c8d862n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 11 april 2023 kl. 22:47:54 UTC+2 skrev Daniel Sahlberg:

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.


There was a quick response on the Subversion dev mailing list [1] and a fix 
has already been committed in the APR tree. It should be possible to switch 
to https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x for verification.

Kind regards,
Daniel


[1] https://lists.apache.org/thread/56gnyc3tc0orjh5mfsqo9gpq1br59b01


 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1543d411-52d5-4f54-9d1b-2642b1c4ab19n%40googlegroups.com.

Re: Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 11 april 2023 kl. 19:33:37 UTC+2 skrev Stefan:

yep, it's the new apr version.
I'll go back to apr 1.7.2 - this needs to be fixed either in apr or the svn 
lib.


Doh. That is rather stupid. I'm sending this upstream, first to the 
Subversion project but I have a feeling it is a problem in APR.

+1 on reverting to 1.7.2.

Kind regards,
Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/66f0e4cb-d0d3-4de6-8b46-9d3067b1c497n%40googlegroups.com.

Updated dependencies for TortoiseSVN

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've spent the weekend updating several dependencies for TortoiseSVN:
- APR: 1.7.2 to 1.7.3
- OpenSSL: 1.1.1t to 3.1.0 (the 1.1 series is EOL on 11th September 2023).
- Serf: 1.3.9 to current trunk version (needed for OpenSSL 3 compatibility, 
I'm hoping for a new release of Serf before the next Subversion/TSVN 
release, otherwise there is a simple patch we can apply in the build 
process).
- Zlib: 1.2.11 to 1.2.13.

Nightly builds should be available from tomorrow (the nightly builds today 
failed because of a missing buildstep).

The update to OpenSSL 3 should solve a problem with building the ARM 
version (unfortunately there is no nightly build for ARM).

Please feel free to test!

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/608a1f0f-b183-4662-9189-19a0f62bb7b5n%40googlegroups.com.

Re: Hardware question

[Daniel Sahlberg via TortoiseSVN-dev]

fredag 31 mars 2023 kl. 05:09:47 UTC+2 skrev Shiko Emiya:

Good day
My company wants to build a server that allows about 50 people use it in 
the same time. 
Could you please give me some suggestions about what kind of hardware 
should I use?
Thank you very much.


Hi,

You need to provide a lot more details than the above to get a reasonably 
accurate answer. For example, what is the intended use for the server, what 
kind of OS and software will you run?

Since you are asking in the TortoiseSVN forum, I'm assuming you are looking 
for a server providing some sort of virtual desktops. TortoiseSVN will not 
require much in resources in excess of what you need for your other use 
cases. If you scale your server for your main use case it will cope easily 
with TortoiseSVN.

If you are thinking about building an SVN server (ie, hosting repositories) 
you can probably get better answers on us...@subversion.apache.org or by 
asking the vendor providing your Subversion server (if you run one of the 
commercial distributions). The answer will depend a lot on the amount of 
data you plan to store and how you plan to use SVN, however my gut feeling 
is that for 50 developers committing normal source code, almost any server 
produced within the last 10 years should cope easily.

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/3f6c9a77-4f0c-4048-b0c0-625d109da48cn%40googlegroups.com.

Re: CVE-2019-14422 Vulnerability

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 22 mars 2023 kl. 15:53:04 UTC+1 skrev F Technologies:

Good day all.

My organization is trying to use TortoiseSVN as a version control client. 
In researching, from the user group, it looks as though this may not be 
accepted as a vulnerability by TortoiseSVN.

The concern is that a macro can be executed which might harm a network. It 
appears that there are a number of steps to get there. 

1. Can someone please advise if this was addressed? 

2. If addressed, where might I find documentation on the resolution?

3. If not are there plans to?

4. If no plans requesting explanation why so I can present to organization.

I am hoping to obtain answer by end of day Thursday as I have a meeting to 
rebut objections.

Thanks.

https://www.cvedetails.com/cve/CVE-2019-14422/


Please check r28647 of the diff script at 
https://svn.osdn.net/svnroot/tortoisesvn/trunk/contrib/diff-scripts/, it 
adds a protection layer by disabling macros:

// disable all macros
objExcelApp.AutomationSecurity = 3; //msoAutomationSecurityForceDisable

Based on the date it seems to be in reaction to the CVE. It should have 
been included in the 1.13 release, it certainly is included as installed in 
1.14.5.

Kind regards,
Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/55f3c4f1-4ef4-4841-82e5-ebc33ee9c599n%40googlegroups.com.

Re: CVE-2007-3846 Vunerability

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 22 mars 2023 kl. 15:53:09 UTC+1 skrev F Technologies:

Good day all.

My organization is trying to use TortoiseSVN as a version control client. 
In researching, from the user group, it looks as though this may not be 
accepted as a vulnerability by TortoiseSVN.

The concern is that a macro can be executed which might harm a network. It 
appears that there are a number of steps to get there. 

1. Can someone please advise if this was addressed? 

2. If addressed, where might I find documentation on the resolution?

3. If not are there plans to?

4. If no plans requesting explanation why so I can present to organization.

I am hoping to obtain answer by end of day Thursday as I have a meeting to 
rebut objections.

Thanks.

https://www.cvedetails.com/cve/CVE-2019-14422/


In the title you mention CVE-2007-3846 but the link is something else. I 
assume this is a case of copy-paste error and assume it is CVE-2007-3846 
you refer to.

Please see the Apache Subversion advisory:
https://subversion.apache.org/security/CVE-2007-3846-advisory.txt

The version numbers for TortoiseSVN and Apache Subversion are in general 
the same. Exceptions exist, for example within the 1.14 line, TortoiseSVN 
in general have a higher version number than the Apache Subversion library 
version.

Thus I'm sure TortoiseSVN version 1.14.5 are not affected by CVE-2007-3846.

Kind regards
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/601a953a-5a53-40ff-8fff-b6faea1ac731n%40googlegroups.com.

TortoiseSVN Book link on https://tortoisesvn.net/support.html

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I was looking at the TortoiseSVN book and found out that the link sort of 
broken. It still works, but it is not possible to access the book at the 
packtpub.com website (even when creating an account, the book is not 
available and packtpub support says "it was pulled for unknown reasons").

It seems to be available through a few other distributors, for example 
https://www.scribd.com/book/253046905/TortoiseSVN-1-7-Beginner-s-Guide

Would it make sense to replace the link (and is there another preferred 
vendor)? (In such case also the /beginnersguide.html should be updated, I 
didn't check if there are even more ).

Kind regards,
/Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6361387d-faf2-4d78-b7cc-0a34c8b6ffaan%40googlegroups.com.

Re: needed manual refresh after moving beween monit with different monitor

[Daniel Sahlberg via TortoiseSVN-dev]

@Ot(ik): Stefan made a fix yesterday and the nightly builds seems to be 
back. Can you check again? 

/Daniel

måndag 19 december 2022 kl. 11:55:33 UTC+1 skrev Daniel Sahlberg:

> måndag 19 december 2022 kl. 11:38:17 UTC+1 skrev Ot(ik):
>
>> I have reported this some time ago. I suspect after WM_DPICHANGED 
>> T-Merge should drop line cache.
>> I§ve tried to do local build and fix it, but I was not successful in 
>> setting enviroment - I plan to try later.
>>
>
> Anything in particular causing trouble for you with the build environment? 
> For me it was slightly confusing at first, you need to follow the steps in 
> build.txt very carefully and do the build on the command line (for ALL 
> configurations you plan to run in Visual Studio!) before you can open the 
> Visual Studio solution.
>
> > Trying last nightly build was not possible as there no actual build 
> available.
>
> @Stefan: The addition of WinMain in plink.c? It already exists in 
> TortoisePlink.c - or maybe this file should have been deleted?
>
> /Daniel
>  
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fcdf0014-2317-4be8-bc48-4c4990cb10b7n%40googlegroups.com.

Re: needed manual refresh after moving beween monit with different monitor

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 19 december 2022 kl. 11:38:17 UTC+1 skrev Ot(ik):

> I have reported this some time ago. I suspect after WM_DPICHANGED T-Merge 
> should drop line cache.
> I§ve tried to do local build and fix it, but I was not successful in 
> setting enviroment - I plan to try later.
>

Anything in particular causing trouble for you with the build environment? 
For me it was slightly confusing at first, you need to follow the steps in 
build.txt very carefully and do the build on the command line (for ALL 
configurations you plan to run in Visual Studio!) before you can open the 
Visual Studio solution.

> Trying last nightly build was not possible as there no actual build 
available.

@Stefan: The addition of WinMain in plink.c? It already exists in 
TortoisePlink.c - or maybe this file should have been deleted?

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/94e58092-e6d8-410c-837b-31c93a4c68c3n%40googlegroups.com.

Re: GetHEADRevision with illegal URL

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks, r29499.

onsdag 14 december 2022 kl. 17:38:41 UTC+1 skrev Stefan:

> I think this should be ok. Please commit.
>
> Stefan
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2a3509e0-ea82-4d6e-b3c8-d9a2bb91489an%40googlegroups.com.

GetHEADRevision with illegal URL

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

Once again double checking my assumptions regarding the code. In the user 
group there [1] is a discussion where I believe the error is caused by 
GetHEADRevision returning a revision even when the URL is invalid.

The following patch is using svn_ra_stat to check if the path exists and it 
seems to do what it is supposed to do.

[[[
--- C:/Users/danie/AppData/Local/Temp/SVN.cpp-revBASE.svn005.tmp.cpptis 
jun  7 17:38:11 2022
+++ C:/Devel/tortoisesvn_trunk/src/SVN/SVN.cppsön dec 11 17:34:23 2022
@@ -2733,0 +2734,13 @@ svn_revnum_t SVN::GetHEADRevision(const CTSVNPath&
+
+/* Check if path actually exist */
+svn_dirent_t *dirent;
+SVNTRACE(
+svn_ra_stat(raSession, "", rev, , localPool),
+urla);
+if (dirent == nullptr)
+{
+CString 
message(MAKEINTRESOURCE(IDS_SVN_URL_NONEXISTENT_IN_REV));
+m_err = svn_error_createf(SVN_ERR_RA_ILLEGAL_URL, NULL, 
CUnicodeUtils::GetUTF8(message).GetString(), urla, rev);
+return -1;
+}
+
]]]

Will this break any other assumptions, where GetHEADRevision is assumed to 
return HEAD for an arbitrary path within the repository? I checked quickly 
in RepoBrowser but that seemed to work fine.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/5juHVu4tioQ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e907d55a-3521-41d2-b996-30cbbbdf2995n%40googlegroups.com.

Re: Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 5 december 2022 kl. 18:49:13 UTC+1 skrev Stefan:

> On Sunday, December 4, 2022 at 11:23:50 AM UTC+1 daniel.l...@gmail.com 
> wrote:
>
>> lördag 3 december 2022 kl. 20:38:35 UTC+1 skrev Daniel Sahlberg:
>> [...]
>>
>>> +if ((pItem->lastHead != item.lastHead) || 
>>> (pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
>>>
>>
>> On second thoughts, this is probably not the best solution. If there was 
>> an old error message and another error occurs, it will not be updated. Thus 
>> it should probably be
>> [[[
>> +if ((pItem->lastHead != item.lastHead) || 
>> (pItem->lastErrorMsg != item.lastErrorMsg))
>> ]]]
>>
>
> this looks very good! Please commit.
>

Thanks. I was mostly worried there was a design decision not to remove the 
error status. Committed as r29490.
 

> It seems I can retire now :)
>

Please don't!  I'm sure you've forgotten more about Subversion than I will 
ever learn. :-)

Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a4d6b5bc-8cb5-4adb-b829-86bfba147d3bn%40googlegroups.com.

Re: Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 3 december 2022 kl. 20:38:35 UTC+1 skrev Daniel Sahlberg:
[...]

> +if ((pItem->lastHead != item.lastHead) || 
> (pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
>

On second thoughts, this is probably not the best solution. If there was an 
old error message and another error occurs, it will not be updated. Thus it 
should probably be
[[[
+if ((pItem->lastHead != item.lastHead) || 
(pItem->lastErrorMsg != item.lastErrorMsg))
]]]

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/8bb648fc-86da-4c94-b48f-153d2afb83b3n%40googlegroups.com.

Project monitor, not updating the "failed" overlay even when the fail disappear

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've been observing that Project monitor display a "failed" overlay in the 
tree after intermittent failures, even when the failure has disappeared. 
This has also been discussed in the groups previously, for example [1]. 
I've been trying to reproduce this and I believe I've found the root cause.

High level description:
- Setup monitoring a project.
- On checking the projects (timer or Check now), there is an error. For 
example due to missing network connectivity. The project is now marked as 
failed and error is stored in MonitoringData.ini.
- Later network connectivity is restored. The check will succeed, however 
this is not stored in MonitoringData.ini. Thus, the project still has the 
"failed" overlay and you have to manually clear errors and check again.

An easy way to reproduce this is to enter a fake entry in the 
%systemroot%\System32\drivers\etc\hosts overriding DNS lookup for the 
Subversion server and then remove the same entry again for the second 
update.

I would prefer that intermittent failures clear themselves.

As far as I understand, monitoring is performed by a separate thread. This 
is using a separate vector of items to check. After check is completed, the 
data is copied back to the main list in OnMonitorThreadFinished().

The current implementation is to only update the main list if the lastHead 
has changed or if the item *currently* has an error message. Ie: If there 
previously was an error message but it has now disappeared, the update will 
not happen (unless there was a new revision). I would propose to change 
this to lastHead has changed or the error message has changed, as follows:

[[[
--- C:/Users/danie/AppData/Local/Temp/LogDlg.cpp-revBASE.svn001.tmp.cpp   
 lör dec  3 17:51:45 2022
+++ C:/Devel/tortoisesvn_trunk/src/TortoiseProc/LogDialog/LogDlg.cpplör 
dec  3 20:09:59 2022
@@ -9436 +9440 @@ void CLogDlg::OnMonitorThreadFinished()
-if ((pItem->lastHead != item.lastHead) || 
(!item.lastErrorMsg.IsEmpty()))
+if ((pItem->lastHead != item.lastHead) || 
(pItem->lastErrorMsg.IsEmpty() != item.lastErrorMsg.IsEmpty()))
]]]

I believe the same root cause is also relevant in another thread [2] 
claiming that url changes doens't always work - but MonitoringData snippet 
it seems the error message is not related to the current URL.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/fvLiiJl4-iI/m/9ZCXFwutAQAJ
[2] https://groups.google.com/g/tortoisesvn/c/5juHVu4tioQ/m/3YUVFfJ9AgAJ

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1e428447-901d-4d48-9d5e-916a7b05f830n%40googlegroups.com.

Re: Project Monitor, assert if logcache disabled and monitoring an unaccessible url

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 december 2022 kl. 19:19:47 UTC+1 skrev Stefan:

>
>> I don't fully understand how the logcache works, but it seems the cache 
>> variable is not initialized with log caching turned off (which sounds 
>> reasonable!), however there should be no calls to the logcache objects. Or 
>> they should handle a NULL cache properly.
>>
>>
> The log cache is always used, even if disabled. But if disabled, the data 
> in the cache is not saved to disk or loaded from it. Then the 'cache' just 
> holds all the log info in memory.
>
> the assertion is fixed in r29488
>

Thanks both for the fix and the explaination. Seems to work now =) 

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/42fd045f-cca1-44ac-84a0-4129b4132ab5n%40googlegroups.com.

Re: svn commit issue

[Daniel Sahlberg via TortoiseSVN-dev]

Can you describe in more detail what happens? Error messages are always 
helpful. Pictures as well.

Kind regards,
Daniel

torsdag 1 december 2022 kl. 17:37:42 UTC+1 skrev shawn_...@cox.net:

> is there a way to troubleshoot commit issues?
>
> some items checkout fine  some commit fin others will not commit.
>
> thanks for any help!
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/60441c88-a562-4a9e-933e-a38940ad202bn%40googlegroups.com.

Re: Abridged summary of tortoisesvn-dev@googlegroups.com - 2 updates in 2 topics

[Daniel Sahlberg via TortoiseSVN-dev]

Let's stick to the original topic, please.

fredag 2 december 2022 kl. 01:40:34 UTC+1 skrev shawn_...@cox.net:

> What would be the first steps to check?
>
> Thanks,
> Shawn
>  
> --
> *From:* TortoiseSVN-dev 
> *Sent:* Thursday, December 1, 2022 7:36 PM
> *To:* Abridged recipients 
> *Subject:* Abridged summary of tortois...@googlegroups.com - 2 updates in 
> 2 topics
>  
> tortois...@googlegroups.com Google Groups 
> 
>  
> 
>  
> Today's topic summary 
> View all topics 
>
>- Project Monitor, assert if logcache disabled and monitoring an 
>unaccessible url <#m_-7600060390020144987_group_thread_0> - 1 Update 
>- svn commit issue <#m_-7600060390020144987_group_thread_1> - 1 Update 
>
> Project Monitor, assert if logcache disabled and monitoring an 
> unaccessible url 
> 
>  
> Stefan: Dec 01 10:19AM -0800 
>
> > variable is not initialized with log caching turned off (which sounds 
> > reasonable!), however there should be no calls to the logcache objects 
> Or 
> > they should handle a NULL cache properly.
> ...more 
> 
>  
> Back to top <#m_-7600060390020144987_digest_top> 
> svn commit issue 
> 
>  
> tortois...@googlegroups.com: Dec 01 08:37AM -0800 
>
> is there a way to troubleshoot commit issues?
>  
> some items checkout fine some commit fin others will not commit.
>  
> thanks for any help!
> ...more 
> 
>  
> Back to top <#m_-7600060390020144987_digest_top> 
> You received this digest because you're subscribed to updates for this 
> group. You can change your settings on the group membership page.
> To unsubscribe from this group and stop receiving emails from it send an 
> email to tortoisesvn-d...@googlegroups.com. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/6932dd0c-1ff9-4d70-a061-8e140c856d78n%40googlegroups.com.

Project Monitor, assert if logcache disabled and monitoring an unaccessible url

[Daniel Sahlberg via TortoiseSVN-dev]

  Hi,

I'm getting an assert in CCacheLogQuery::GetCache(). I believe it is 
reproducible:

- Disable log caching in the TortoiseSVN settings
- Setup two projects to monitor, one functional 
(eg https://svn.osdn.net/svnroot/tortoisesvn/) and one where you don't have 
access (I'm using https://svn.apache.org/repos/private/pmc/)
- Start Project Monitor
- Click on the functional project, then on the non-functional project, then 
on the functional project again. The assert in GetCache() triggers.

I don't fully understand how the logcache works, but it seems the cache 
variable is not initialized with log caching turned off (which sounds 
reasonable!), however there should be no calls to the logcache objects. Or 
they should handle a NULL cache properly.

Anyone?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/21fe6318-278f-4d33-a8c8-e348df872dacn%40googlegroups.com.

Re: TortoiseMerge, paste multiline + undo doesn't restore line numbers correctly

[Daniel Sahlberg via TortoiseSVN-dev]

Thanks. Committed r29487.
/Daniel

tisdag 29 november 2022 kl. 17:14:56 UTC+1 skrev Stefan:

> this patch looks fine. 
> I prefer this solution, because adding another SaveUndoStep() would cause 
> quite a few other problems.
>
> Stefan
>

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ee223d55-8a21-408c-957c-f2e912b81efdn%40googlegroups.com.

TortoiseMerge, paste multiline + undo doesn't restore line numbers correctly

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In TortoiseMerge:
- Look at a diff of a changed file, for example from double click in the 
commit dialog.
- Paste a few lines (it doesn't have to be related to the changed lines, in 
the attached image I pasted a few lines in the beginning of the file). 
*TortoiseMerge 
correctly renumbers all lines.*
- Undo (Ctrl-Z). *TortoiseMerge removes the pasted lines but doesn't 
renumber the following lines.* See attached picture with lines 1 5 6 7 etc.

If I understand the code correctly, the line numbering is stored in the 
undo list so I propose to move the call to UpdateViewLineNumbers() above 
SaveUndoStep(), as follows.

[[[
Index: BaseView.cpp
===
--- BaseView.cpp(revision 29481)
+++ BaseView.cpp(working copy)
@@ -6765,9 +6765,9 @@
 {
 m_pwndBottom->InsertViewEmptyLines(nViewLine + 1, 
nLinesToPaste - 1);
 }
+UpdateViewLineNumbers();
 SaveUndoStep();
 
-UpdateViewLineNumbers();
 CUndo::GetInstance().EndGrouping();
 
 ptCaretViewPos = SetupPoint(lines[nLinesToPaste - 
1LL].GetLength(), nInsertLine);
]]]

Another solution would be to add another SaveUndoStep() after 
UpdateViewLineNumbers().

Is this analysis correct or do I miss something? Which version is preferred?

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/dc65329b-f756-4eaf-8fec-0ebda5ea2118n%40googlegroups.com.

Re: CLogDlg::MonitorEditProject remove \r and \n from encrypted username/password

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 22 november 2022 kl. 18:36:08 UTC+1 skrev Stefan:

> Now that we don't support WinXP anymore, the string operations to 
> remove/replace newlines can be removed. But for XP it was necessary because 
> the CRYPT_STRING_NOCRLF option doesn't work on XP, which means there the 
> CryptBinaryToStringW API always appended a newline.
>
> Stefan
>

Thanks, committed r29483.
/Daniel 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d250c9e7-a2cf-4938-8987-9ad2e6432d0cn%40googlegroups.com.

Re: "You have to update your working copy" doesn't offer to update

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 22 november 2022 kl. 18:31:53 UTC+1 skrev Stefan:

> yes, please commit.
>

Thanks for the review. Committed r29482.

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/cf5cf058-4747-4467-8e87-ed87f6d98c2fn%40googlegroups.com.

CLogDlg::MonitorEditProject remove \r and \n from encrypted username/password

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

While investigating another issue in the Project Monitor, I saw the 
following code in MonitorEditProject:

[[[
pEditProject->username = CStringUtils::Encrypt(dlg.m_sUsername);
pEditProject->password = CStringUtils::Encrypt(dlg.m_sPassword);
pEditProject->username.Remove('\r');
pEditProject->password.Remove('\r');
pEditProject->username.Replace('\n', ' ');
pEditProject->password.Replace('\n', ' ');
]]]

Is there a guarantee that CryptBinaryToStringW (called by Encrypt) cannot 
return \r or \n in the encrypted (and formatted) data?

The code was added in r25576. In r25909, the flag CRYPT_STRING_NOCRLF was 
added in the call to CryptBinaryToStringW.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7c0a7ba6-57a2-4021-bc60-c1340a370f0dn%40googlegroups.com.

"You have to update your working copy" doesn't offer to update

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

There has been reports about commits (and merge?) failing with "You have to 
update your working copy first" but without the subsequent offer to update.

Today I stumbled on one such case. I traced it 
to CommitCommand::IsOutOfDate not checking for error 155011 
(SVN_ERR_WC_NOT_UP_TO_DATE).

Is there a particular reason not to include this in "IsOutOfDate"?

I'm suggesting a simple patch:

[[[
Index: src/TortoiseProc/Commands/CommitCommand.cpp
===
--- src/TortoiseProc/Commands/CommitCommand.cpp(revision 29480)
+++ src/TortoiseProc/Commands/CommitCommand.cpp(working copy)
@@ -62,6 +62,7 @@
 const apr_status_t errorStatus = pErr->apr_err;
 if ((errorStatus == SVN_ERR_FS_TXN_OUT_OF_DATE) ||
 (errorStatus == SVN_ERR_RA_OUT_OF_DATE) ||
+(errorStatus == SVN_ERR_WC_NOT_UP_TO_DATE) ||
 (errorStatus == SVN_ERR_FS_CONFLICT))
 {
 return true;
]]]

(And yes, I've got commit bits and can do this myself, but on the principle 
of knowing what I don't know, I'm asking before committing something 
stupid).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7c66d4ee-0957-41d5-bb93-47c1661a1f31n%40googlegroups.com.

Listing at openhub.net

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I stumbled upon openhub.net when checking the donation web page 
(https://tortoisesvn.net/donate.html)

There is a link "...you can look at some _statistics_ ..." pointing at 
https://www.openhub.net/p/tortoisesvn/contributors

That page complain about "no recognizable code" which led me to look the 
"code locations" where the svn repo is listed as failed and the github repo 
is "waiting in queue".

While looking at the project, I saw that most links are 404. It seems to be 
enough to add .html to the links (ie change https://tortoisesvn.net/faq 
to https://tortoisesvn.net/faq.html).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/e0efd709-5992-4358-b583-c074c23a594en%40googlegroups.com.

tsvn r29468

[Daniel Sahlberg via TortoiseSVN-dev]

Meta question: I'm getting notified by the mail from osdn.net about 
commits. Is this the best way to provide feedback on commits? It isn't 
clear to me if I can reply to the mail and have it distributed to all 
committers.

[[[
Modified: trunk/src/TortoiseShell/ContextMenu.cpp
===
--- trunk/src/TortoiseShell/ContextMenu.cpp 2022-09-26 17:17:51 UTC 
(rev 29467)
+++ trunk/src/TortoiseShell/ContextMenu.cpp 2022-10-04 18:00:51 UTC 
(rev 29468)

]]] ... [[[
@@ -1222,9 +1222,9 @@
 }
 }

-//add sub menu to main context menu
-//don't use InsertMenu because this will lead to multiple menu entries 
in the explorer file menu.
-//see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for 
details of that.
+// add sub menu to main context menu
+// don't use InsertMenu because this will lead to multiple menu 
entries in the explorer file menu.
+// see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for 
details of that.
 MAKESTRING(IDS_MENUSUBMENU);
 if (!g_shellCache.HasShellMenuAccelerators())
 {
]]]

I got curious and checked the link, but Microsoft seems to be deprecating 
old KB articles and I can't find the article on microsoft.com. 

Archive.org seems to have it: 
http://web.archive.org/web/20090728090357/http://support.microsoft.com:80/kb/214477

Does it seem reasonable to update these kind of links to archive.org (or 
does someone else know where to find it on microsoft.com)? I can do it, 
time permitting...

Kind regards,
Daniel


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/809bd0a2-60d9-4a0d-a893-e0814fd2d1b5n%40googlegroups.com.

Re: tsvn r29449

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 20 september 2022 kl. 16:46:27 UTC+2 skrev Stefan:

> I don't see anything removed in the diff:


You are right of course. My e-mail client removed the leading spaces in the 
diff which lead me to see the "-" in the bullet points as the removal of 
lines and not part of the context. My bad, sorry!

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/08aa12b2-a3e8-4471-8750-cde157ce2aefn%40googlegroups.com.

tsvn r29449

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

In the recent commit r29449 there were some items removed from 
Changelog.txt.

Was this intentional or accidental?

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/46233e16-6b93-40f5-9e4b-b0e46329580bn%40googlegroups.com.

Re: my notes to TortoiseSVN 1.14.3, Build 29387 @ windows 11 insider

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 1 september 2022 kl. 11:19:20 UTC+2 skrev Ot(ik):

> Hi guys long time no talk, 
>
> I just did some more extensive work in TortoiseSVN and found this things:
>
> 1. link to translation status on https://tortoisesvn.net/translation.html 
> pointing to Translation status page (
> https://www.transifex.com/projects/p/tortoisesvn) seems to be 
> broken/outdated it should be update to 
> https://explore.transifex.com/luebbe/tortoisesvn/
>

Thanks for reporting this. I've committed a change to the website code, but 
as far as I understand there is some manual process that has to be done by 
someone to actually update the website.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/cf18306f-cfd6-435f-b907-ab986c945e73n%40googlegroups.com.

Re: Assistance migrating our portable *ampp stack to tortoise

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 9 augusti 2022 kl. 16:49:39 UTC+2 skrev tr...@hallhome.us:

> Hello.  I apologize if this is the wrong place to ask this question.
> We've taken over an abandoned variant of wamp that is totally portable.
> We're having issues with svn and websvn not working fully and not at all 
> with php 8.
> Seems to be a long standing issue with them.
> I'd like to move svn & websvn over to tortoisesvn but we would need a lot 
> of help making that happen.
> http://github/Bearsampp is our organization page.
> Needless to say we're fully FOSS and will remain that way forever.
>
> Is there anyone on the team that would be willing to help us get our feet 
> under us in the migration?
>

Hi,

I'm not sure I understand what you are trying to accomplish.

Websvn seems to be a web based frontend for accessing Subversion. 
TortoiseSVN is a Windows based software.

I saw that Websvn is using the svn command line client to access the 
repository. TortoiseSVN does compile and include this in the MSI 
installation file, but I'm not sure if you were just looking for a new 
command line executable or if you want to replace Websvn completely.

If you want to replace websvn with another web viewer of an SVN repository, 
I'd suggest to look at https://viewvc.org/. It is written by C. Michael 
Pilato of Subversion fame.

(There are also project management applications, Redmine and Trac comes to 
mind, but these may be overkill depending on what you are looking for).

Kind regards,
Daniel Sahlberg

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a8242466-8db1-44d3-af5f-f4093d3f9070n%40googlegroups.com.

Nightlies build failure

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The nightly builds are currently failing with the following message:

[exec] C:\TSVN\tortoisesvn\ext\TortoisePlink\defs.h(22,1): fatal error 
C1189: #error: Do not compile this code base with NDEBUG defined! 
[C:\TSVN\tortoisesvn\ext\TortoisePlink\windows\TPlink\TortoisePlink.vcxproj] 
[exec] TortoisePlink.c

I believe this is caused by a change to defs.h in r29425 which adds a 
change from upstream (97f7a7cb4deacbc92a9dbdc1b9394e4e1358e47a) enforcing 
that NDEBUG is not defined.

As far as I can see this code was added upstream in PuTTY 0.75 (which was 
added to TSVN in r29211), but I assume that code was manually deleted from 
defs.h before committing r29211.

I don't know enough about NDEBUG to dare touching this part of the code. I 
guess we should either remove the #error from defs.h via 
TortoisePlink.patch or change something to not compile TortoisePlink with 
NDEBUG.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/04b4abb2-15c9-46ea-b139-e16a045b5293n%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

onsdag 15 juni 2022 kl. 18:01:14 UTC+2 skrev Stefan:

> On Tuesday, June 14, 2022 at 11:14:13 PM UTC+2 daniel.l...@gmail.com 
> wrote:
>
>> tisdag 14 juni 2022 kl. 20:48:00 UTC+2 skrev Stefan:
>>
>>> I know the problem :(
>>> That's why I thought of discontinuing the translated docs and only use 
>>> docs in English.
>>>
>>
>> Now that you mention. Did you get any feedback on this question 
>> out-of-band (I was the only one to respond on the group)? Did you come to a 
>> decision on this?
>>
>
> not really. You were as you've noticed the only one to respond.
> I've decided to keep them for now, but if we can't get it to work with 
> python3 then I'll drop the doc translations for the next svn/tsvn release.
>

Sounds good.

I /think/ I have manage to do a naive conversion of the scripts to the 
point where they at least run under Linux. I've also tried it under Python2 
on Windows to make sure it is backwards compatible. Please check!

My next problem is to find a libxml2 distribution. Even on Python3, it 
seems hard to get working. I think it should be possible using the Anaconda 
Python distribution (at least I get all the DLL files) but I can't get it 
to run, and I have to call it a night now.

The story will continue.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/1d3f0054-74e9-47aa-917f-62a356279317n%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

torsdag 16 juni 2022 kl. 11:28:16 UTC+2 skrev Bruce C:

> I too recently tried to create the build environment for TortoiseSVN. I 
> had some teething problems that I've not yet reported but I've been 
> interested to see that you've apparently not had those issues.
>
> With respect to the libxml2 library, it seems to me that there are two 
> issues. The first is trying to get a copy of the library that's currently 
> being used. The second, as you've been discussing, is a replacement for the 
> library that is now difficult to obtain. I have nothing to contribute to 
> the latter.
>

I think we should start by dropping Python2 support, hoping that the 
library is more readily available for Python3.

For comparison, the policy of the Subversion project is to support Python2 
for the remainder of 1.14 "unless an unreasonable burden". That policy 
mainly applies to using Subversion but I think there was some work also on 
the build system to support old platforms where Python3 might not be 
available.

In our case, we have good support for Python3 on our build platform (we 
already require Visual Studio 2022 and Windows 10, so no-one should be 
building on old Windows versions where Python 3 isn't available) so it 
should not cause trouble for anyone.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ae833294-21d3-4e66-bdbb-125e1a282052n%40googlegroups.com.

Re: libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 14 juni 2022 kl. 20:48:00 UTC+2 skrev Stefan:

> I know the problem :(
> That's why I thought of discontinuing the translated docs and only use 
> docs in English.
>

Now that you mention. Did you get any feedback on this question out-of-band 
(I was the only one to respond on the group)? Did you come to a decision on 
this?

As you've noticed I've already tried switching to python3, but I don't know 
> python so I couldn't get the py3 version of xml2po to work.
> If you know python well enough, you could give it a try though.
>

I can see what I can do, but it won't go to the top of the list.

Or: the [3] link mentions itstool ( https://itstool.org/ ). I haven't tried 
> this yet. Not sure if that tool would work with our docs - the output 
> should not be different that what the xml2po script does now, or we would 
> lose a lot of translations - and then we can just drop them and only use 
> English docs...
>

I will also investigate this route.

there are one or two other python scripts in the TSVN source tree, but 
> they're not really in use anymore (TranslationStatus.py was used to 
> generate a report that was sent to the mailing list, and chkidd.py was used 
> to check whether a TSVN dialog has a corresponding doc entry)
>

Just for the fun of it, I tried to convert TranslationStatus.py, see 
r29419. chkidd.py you did yourself in 29299 (I didn't test it, just saw the 
log entry).

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/d271e623-79b9-4ec7-9815-c0dea5084fffn%40googlegroups.com.

libxml2 python bindings

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

The download site for libxml2 python bindings (http://users.skynet.be, see 
build.txt and doc/readme.txt) seems to be discontinued, reference [1]. 

I have tried to find another distribution but only found another site that 
is due to be discontinued [2].

Any ideas on how to proceed from here? I guess moving to Python3 would be a 
good step and there has been some commits (r29299) however xml2po still 
seems to require Python2 (the original script is "obsolete" according to 
[3] but there seems to be a Py3 version, however our script is heavily 
modified). Any other scripts that are not Py3 compatible?

/Daniel

[1] 
https://nl.forum.proximus.be/internet-10/users-skynet-be-xxx-werkt-niet-meer-sinds-3juni-53672?postid=683135#post683135
[2] https://www.lfd.uci.edu/~gohlke/pythonlibs/
[3] https://gitlab.gnome.org/Infrastructure/damned-lies/-/issues/228

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/fec5d713-e351-4a78-add3-d3985cb35872n%40googlegroups.com.

Re: Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 7 juni 2022 kl. 17:34:23 UTC+2 skrev Stefan:

> +1
> please merge
>

I added a Changelog entry to the branch (r29413).

Then merged everything to trunk (r29414) excluding the BRANCH-README.

What is the policy for deleting feature branches? I can see that the shelve 
and tortoisemerge-native-ribbon branches were handled differently, where 
the first one still exists (although it was completely merged to trunk) and 
the second one deleted. Personally I believe there is little use in keeping 
the feature branches after merge to trunk, it is always possible to go back 
in time to check the logs if needed.

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/47ff1835-0b99-4082-8725-fc95e1041709n%40googlegroups.com.

Re: Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 6 juni 2022 kl. 07:12:07 UTC+2 skrev Stefan:

> looks good to me.
> I made two small changes on your branch. If you're ok with that then 
> please merge it back to trunk.
>

+1 on the refactoring. This is what I wanted to do as well but I didn't 
really know where to place the function.

-1 on reusing GetAppDirectory() via the appDir variable. GetAppDirectory() 
!= GetAppDataDirectory(). (Otherwise no point in calling ParseSnippetFile 
twice). I have reverted this part of r29410.

L/_T. +0 (C++ is not my primary language, learning it is part of my 
motivation to contribute to TSVN) but I suppose TSVN is always compiled in 
Unicode so it doesn't matter.

+1 on const auto &.

I have changed CCommitDlg::GetAutocompletionList to include the last two 
changes as well.

Kind regards,
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/9a80f9b2-0ebd-4c4c-9065-e5b2d93b4caen%40googlegroups.com.

Autocompletion in the CInputLogDlg

[Daniel Sahlberg via TortoiseSVN-dev]

Based on the question in the users group about the name of the [deleted] 
file as a suggestion in the log message ([1]) , I have created a branch 
/branches/autocomplete_in_repobrowser_logdlg

Please check if this is reasonable / functional and if it should be merged 
to trunk. From my point of view it is feature complete but it might benefit 
from some code cleanup and possibly refactoring some of the duplicated code 
from CCommitDlg.

Kind regards,
Daniel

[1] https://groups.google.com/g/tortoisesvn/c/m1VpvqoSQTI


-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/4abd3264-ea49-4c49-b03e-e9067720837an%40googlegroups.com.

Re: ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

tisdag 31 maj 2022 kl. 17:33:46 UTC+2 skrev Stefan:

> I guess that's one solution. When I first created that script I though 
> maybe users would like to keep the file.
> But maybe it's really better to just delete it - users can always zip the 
> unzipped folder again...
>

r29405. Let's see how that works out. 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/ea0fa404-aa1b-4faf-836c-88c4807a99d0n%40googlegroups.com.

Re: ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

måndag 30 maj 2022 kl. 21:04:58 UTC+2 skrev Stefan:

> you can of course add it to svn:ignore.
> But since it's not used after the download/unzip anymore, I usually just 
> delete it.
>

I'm lazy enough to forget about such things.

Better to have the build script delete the file?

[[[
Index: default.build
===
--- default.build(revision 29403)
+++ default.build(working copy)
@@ -545,6 +545,7 @@
   https://osdn.net/frs/redir.php?m=accf=%2Fstorage%2Fg%2Ft%2Fto%2Ftortoisesvn%2Fbuild+tools%2FTools-1.8.0.zip;
 
dest="tools.zip" />
   
   
+  
 
   
]]]

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/2a55a9e8-14fe-440f-a855-14cd46b01500n%40googlegroups.com.

ignore tools.zip in tortoisesvn/trunk

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,
nant init seems to leave the tools.zip in the wc. Any particular reason why 
it is not in svn:ignore? Otherwise I'll add it there to remove at least one 
small thing from "Check for modifications".
/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/43892494-e218-4746-818e-10230aa2b44dn%40googlegroups.com.

Preparing for the Multi-format-WC feature in Subversion 1.15

[Daniel Sahlberg via TortoiseSVN-dev]

Hi,

I've started to look at the Multi-format-WC feature that is expected to be 
part of Subversion 1.15.

Summary for those not reading the d...@subversion.apache.org mailing list; 
Previously, each release of Subversion was tied to a specific working copy 
format number. Between some client versions (latest by the release of 
1.8.0) changes were made to the layout of the working copy (placement and 
content of the .svn folder). A particular WC could only be operated on by a 
client of the correct version, so using a 1.7 client (for example an IDE 
integrated client) and a 1.8 client (for example TortoiseSVN) on the same 
working copy would not work. There is an expectation that Subversion 1.15 
will introduce a new WC format with some additional features (most 
prominent the ability to remove the "pristine" copy of each file, basically 
dividing the space requirement for a working copy in half at the expense of 
some additional network traffic). Since there is a trade-off in the new WC 
format it is expected that not everyone want to update, and even then some 
might be locked in to old clients that *cannot* be updated. Therefor, 
Subversion 1.15 will introduce a possibility to work with multiple WC 
formats within the same client.

There is a more in-depth description in the Subversion 1.15 release notes, 
draft version at [1].

I have started to look at implementing support for this feature in 
TortoiseSVN.

1. Is there someone else looking at it as well, so we can cooperate?
2. I would propose to create a /branches/multi-format-wc based on current 
/trunk. Any opinions?

Kind regards,
Daniel

[1] https://subversion-staging.apache.org/docs/release-notes/1.15.html

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/17c8ccd7-d089-4434-b6fa-c41862a78822n%40googlegroups.com.

Re: [PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 20:45:42 UTC+2 skrev Stefan:

>
>> Just one more thing .  In MergeWizardTree.cpp, you first check the 
>> URL using GetWindowText but when setting the m_urlFrom and m_urlTo you 
>> still get the URL using GetString(). So I would re-order things as in patch 
>> [1]. 
>>
>
> nice catch!
> You can commit the patch now yourself.
>

r29402
 

> I will have a second look at TortoiseProc (as mentioned in the previous 
>> message) to see if I can make it emit a path base in to WC root instead of 
>> just the file name. I guess it might be difficult to do with TortoiseMerge 
>> since it basically compares two different files on the computer. It could, 
>> possibly, emit a path based in the WC root if either file is in a WC (in 
>> the patches in the first message, C:/Devel/tortoisesvn is a WC), but it 
>> will be impossible to do with the file from %TEMP%.
>>
>
> That would be good, yes.
> However, it is usually enough to emit the filename: when applying a patch, 
> TMerge automatically searches for a path that matches the paths/names in 
> the patchfile.
>

That's clever.

The command line 'svn diff' is basing the file names on the current working 
directory and not the WC root.

After some basic checks, it seems TortoiseProc is being fed a list of full 
paths without a notion for "working directory" and it bases the patch in 
the lowest common denominator of these paths.

Since there are already some differences and TMerge is clever enough to 
work them out I will probably ignore it (I've got other itches to scratch, 
more in a new thread).

If you would register at osdn.net I can give you commit access so you can 
>>> commit your fixes yourself :)
>>>
>>
>> Login: danielsahlberg
>>
>> Appreciate your confidence :-)
>>
>
> You now have full access.
>

Thanks!

/Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/50320682-9647-4c91-8d4d-4def12175432n%40googlegroups.com.

Re: [PATCH] URL copied via "Copy URL to clipboard" results in error when pasted into Merge dialog

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 19:18:22 UTC+2 skrev Stefan:

> On Saturday, May 28, 2022 at 4:18:44 PM UTC+2 daniel.l...@gmail.com wrote:
>
>> lördag 28 maj 2022 kl. 10:24:21 UTC+2 skrev Stefan:
>>
>>> thanks for all your patches!
>>> I went with option 4, I agree that's the best solution.
>>>
>>
>> (y), LGTM.
>>
>> I realise you reworked the patch a bit and removed GetWindowText 
>> altogether (I thought about it but figured there was probably a reason it 
>> was used). For the matter of consistency, should the same be applied to 
>> MergeWizardTree? Something along the lines of [1]?
>>
>
> now that you mention it: yes there was (and is) a reason for using 
> GetWindowText: GetString can return an empty string sometimes (e.g. when 
> using up/down to select from the history without hitting return). Not 
> always, but sometimes.
>

Oh.  Sometimes is never nice.

So I'm going to change this back to using GetWindowText again and then trim 
> the string from newlines.
>

LGTM, again.

Just one more thing .  In MergeWizardTree.cpp, you first check the URL 
using GetWindowText but when setting the m_urlFrom and m_urlTo you still 
get the URL using GetString(). So I would re-order things as in patch [1]. 

TortoiseMerge seems to look at Software\TortoiseMerge\ContextLines (from 
>> the settings dialog), which I havn't set, and thus gets a default value of 
>> 0 from src/TortoiseMerge/MainFrm.cpp line 2950. I'm attaching a proposed 
>> patch [2] to change this to three, which seems a better default. There were 
>> a few additional places in the code looking at the above reg key, but with 
>> a default value of 1 that I didn't change. I'm not sure if it makes sense 
>> to have different default values for the same registry key. The attached 
>> patch [3] should change the default setting in the Settings dialog to 3 as 
>> well. 
>>
>
> Thanks!
> I've applied your patches.
>

LGTM.

I will have a second look at TortoiseProc (as mentioned in the previous 
message) to see if I can make it emit a path base in to WC root instead of 
just the file name. I guess it might be difficult to do with TortoiseMerge 
since it basically compares two different files on the computer. It could, 
possibly, emit a path based in the WC root if either file is in a WC (in 
the patches in the first message, C:/Devel/tortoisesvn is a WC), but it 
will be impossible to do with the file from %TEMP%.
 

> If you would register at osdn.net I can give you commit access so you can 
> commit your fixes yourself :)
>

Login: danielsahlberg

Appreciate your confidence :-)
 
Kind regards,
Daniel

[1] MergeWizardTree_DontUseGetString.txt
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/7d17d20f-ea96-411a-a5c3-4c51a6bf986fn%40googlegroups.com.
Index: MergeWizardTree.cpp
===
--- MergeWizardTree.cpp (revision 29401)
+++ MergeWizardTree.cpp (working copy)
@@ -202,6 +202,7 @@
 }
 
 CString sUrl;
+
 m_urlCombo.GetWindowText(sUrl);
 auto newlinePos = sUrl.FindOneOf(L"\r\n");
 if (newlinePos >= 0)
@@ -212,6 +213,10 @@
 ShowComboBalloon(_urlCombo, IDS_ERR_MUSTBEURL, IDS_ERR_ERROR, 
TTI_ERROR);
 return FALSE;
 }
+
+m_urlCombo.SaveHistory();
+m_urlFrom = sUrl;
+
 m_urlCombo2.GetWindowText(sUrl);
 newlinePos = sUrl.FindOneOf(L"\r\n");
 if (newlinePos >= 0)
@@ -223,11 +228,8 @@
 return FALSE;
 }
 
-m_urlCombo.SaveHistory();
-m_urlFrom = m_urlCombo.GetString();
-
 m_urlCombo2.SaveHistory();
-m_urlTo = m_urlCombo2.GetString();
+m_urlTo = sUrl;
 
 CStringsRegKeyFrom = 
L"Software\\TortoiseSVN\\History\\repoURLS\\MergeURLForFrom" + 
static_cast(GetParent())->m_wcPath.GetSVNPathString();
 CRegString regMergeUrlForWCFrom(sRegKeyFrom);

Re: [PATCH] Website, Status page, Upcoming point to 1.15

[Daniel Sahlberg via TortoiseSVN-dev]

lördag 28 maj 2022 kl. 10:10:11 UTC+2 skrev Stefan:

> can't find an attached patch.


Google Groups and I are not friends when it comes to attachments. Sorry.

But I just removed the whole "upcoming milestone" since it's hard to 
> predict the next releases.
>

I know. Let's hope it is not too long until 1.15 and the performance and WC 
size fixed.

There is still a reference to 1.13.x as the "stable branch", attached. 
(This time I'm sure the attachment is there..)

/Daniel
 

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn-dev/a2a175d9-2399-49c3-b2ba-c4535f7a1ebbn%40googlegroups.com.
Index: status.html
===
--- status.html (revision 29397)
+++ status.html (working copy)
@@ -18,7 +18,7 @@
 {% include adsense_inpage.html %}
 
 What we are currently working on
-Apart from fixing bugs for the stable branch (1.13.x)
+Apart from fixing bugs for the stable branch (1.14.x)
 there are some new features and enhancements to existing
 features we are currently discussing and even already working on.