Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

, Prasanta Sadhukhan wrote: Hi Phil, Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8165947/webrev.01/ Regards Prasanta On 9/22/2016 11:10 PM, Prasanta Sadhukhan wrote: On 9/22/2016 11:09 PM, Philip Race wrote: OK I see now. The comment should be updated to remo

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

PING .. any takers on this two week old RFR ? -phil. On 9/8/16, 1:12 PM, Philip Race wrote: [Fix i18n-dev address] -phil. On 9/8/16, 1:10 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

h the suffixes is needed, that's another question... ...jim On 9/22/16 10:56 AM, Philip Race wrote: The method getImageUsingNamingSchemes(String fileName, MediaResolutionNamingScheme... namingSchemes) works for any scheme not only for the default one. I'm sure it does. My point

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

.5f), new Toolkit.MediaResolutionNamingScheme("foo", 2f) to load files "img.png", "imgabc.png", and "imgfoo.png" That doesn't look like a consistent scheme at all ... so give up on that and just have them list the full names and get rid of the unneeded API. -

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

:47 PM, Philip Race wrote: Hi, When the application is specifying the set of images from which to build the MRI you ask the app to specify a "schema" (probably not the right name given that it is per-file), and a floating point scale. I don't see why we need to ask the app to name the fil

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

out how to notify an observer of incoming information. So, lazy loading may make this approach infeasible. Alexandr? ...jim On 9/21/16 11:47 AM, Philip Race wrote: Hi, When the application is specifying the set of images from which to build the MRI you ask the app to specify

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

OK I see now. The comment should be updated to remove mention of the dialog and explain that instead. But in that case do you still need the "else" in setAttributes? -phil. On 9/22/16, 10:32 AM, Prasanta Sadhukhan wrote: On 9/22/2016 10:59 PM, Philip Race wrote: Your comment r

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

that user's selection is not overridden. I put a comment regarding that in the fix. Regards Prasanta On 9/22/2016 10:38 PM, Philip Race wrote: What happens if the application does not display a dialog but instead the application code explicitly does this: aset.add(JobSheets.STANDARD); print(aset

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

the PrintService.getDefaultAttributeValue(JobSheets.class) and if IPP returns "none", I change the default noJobSheet to true so that no banner page is printed (to honor system default). Regards Prasanta On 9/22/2016 10:16 PM, Philip Race wrote: This looks wrong to me. Shouldn't the logic look like the one you ha

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

This looks wrong to me. Shouldn't the logic look like the one you have earlier in the file ? ie this : 1271 JobSheets jobSheets = (JobSheets)attributes.get(JobSheets.class); 1272 if (jobSheets != null) { 1273 noJobSheet = jobSheets == JobSheets.NONE; 1274 }

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

I see this is mostly what I approved for JDK9 but I noticed you made a change after I approved it and I did not see or approve the updated version. I am concerned about this comment you posted for the JDK 9 webrev : >Regarding "2856 RELEASE_ARRAYS(env, data, (const JOCTET

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

01 The fix includes support for resolution variants loading by getImage() method for built-in toolkits using the following media resolution naming scheme (qualifier, scale): ("@125pct", 1.25), ("@150pct", 1.5), ("@200pct" or "@2x", 2), ("@250pct", 2.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-7064425: PageFormat Dialog has no owner window to reactivate

Sorry, right that won't work .. this is an expression evaluation and the compiler needs to determine the return type which is going to end up back as Window as the most-specific super-type. Details in 15.25.3 http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.25 So it won't

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

I think this bug should be downgraded to P4 and deferred. Put a link in the bug report to the fix so we can revive it later. -phil. On 9/9/16, 6:55 AM, Semyon Sadetsky wrote: On 9/9/2016 4:08 PM, Vadim Pakhnushev wrote: On 09.09.2016 15:58, Semyon Sadetsky wrote: On 09.09.2016 14:45, Vadim

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

, neither in JIRA nor in the review on the alias, for the 803944 resolution that d3d should be disabled for all Intel video cards. Why? It may be disabled by default, but at least the sun.java2d.d3d=true option could enable it, no? --Semyon On 9/9/2016 4:58 AM, Philip Race wrote: Please consider

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

with d3d normally. Some visual defects will be corrected after this fix. And I didn't get why d3d is disabled for all Intel without possibility to switch it on? --Semyon On 09.09.2016 02:10, Philip Race wrote: The following is just for testing right ? It should not be in this webrev as part

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

ky/8146042/webrev.05/ --Semyon On 9/9/2016 12:20 AM, Semyon Sadetsky wrote: On 08.09.2016 22:57, Philip Race wrote: Can you provide something like a rationale for why these particular values might work ? Otherwise this seems like a fix that can't be reviewed, only tested. So th

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

or we can use http://cr.openjdk.java.net/~jdv/8162461/webrev.01/ having RELEASE/GET_ARRAYS change in sun_jpeg_output_message() for future proofing. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Thursday, September 08, 2016 7:21 PM To: Philip Race; 2d-dev Subject: Re: [OpenJDK 2D-Dev]

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

e. Also I have removed processImageProgress(0.0f) call which I feel is not needed as we have processImageStarted() which will take care of it(Also to maintain callbacks at same intervals as they are in other readers). Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, Septem

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

[Fix i18n-dev address] -phil. On 9/8/16, 1:10 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10 is not supported by JDK 9. This updates the fontconfig file to focus on the default set of fonts installed

[OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

Bug: https://bugs.openjdk.java.net/browse/JDK-8162531 Webrev: http://cr.openjdk.java.net/~prr/8162531/ Solaris 10 is not supported by JDK 9. This updates the fontconfig file to focus on the default set of fonts installed on Solaris 11 as part its desktop. Preference is given to the Arial, Times

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

Can you provide something like a rationale for why these particular values might work ? Otherwise this seems like a fix that can't be reviewed, only tested. So that testing will be important. If you can be sure it passes on ATI, Nvidia, and Intel then we can take it .. otherwise we should

[OpenJDK 2D-Dev] RFR: 8165345: JDK macro definition re-defined by MacOS core framework

Bug: https://bugs.openjdk.java.net/browse/JDK-8165345 Webrev: http://cr.openjdk.java.net/~prr/8165345/ MacOS has its own definition of FloatToFixed, so changing the name of the JDK one. More details in the bug. -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

- From: Sergey Bylokhov Sent: Wednesday, August 31, 2016 4:22 PM To: Jayathirth D V; Philip Race Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG I have only one question: should we call the new

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160327: Support for thumbnails present in APP1 marker for JPEG

imageCreationTime = LocalDateTime.parse(dateTime, formatter); Seems like it may throw DateTimeParseException - a subtype of RuntimeException https://docs.oracle.com/javase/8/docs/api/java/time/LocalDateTime.html#parse-java.lang.CharSequence-java.time.format.DateTimeFormatter- I think in the

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

case is shift-negative-value a new warning in GCC >> 6? If that's the case it doesn't actually hurt adding it since GCC is >> nice enough to not complain about unknown warning tags. If we do, >> just make sure to specify in a comment that it's specific to GCC >> version 6+. >> &g

[OpenJDK 2D-Dev] RFR: 8164818: Reg. test java/awt/font/TextLayout/VisibleAdvance.java fails

bug: https://bugs.openjdk.java.net/browse/JDK-8164818 webrev: http://cr.openjdk.java.net/~prr/8164818/ 26.6 fixed point was being used in harfbuzz interface code and 16.16 elsewhere so we had a precision mismatch. More details in the bug report. -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

Media out2 = (Media)aset.get(in.getClass()); System.out.println("Class="+in.getClass()+" in="+in+ " out="+out2); } } On 8/18/2016 11:20 PM, Prasanta Sadhukhan wrote: On 8/19/2016 3:36 AM, Philip Race wrote: Oh .. right un

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

:24 PM, Philip Race wrote: Alexander, Were the existing Toolkit.getImage(String/URL) APIs not enhanced to do this for you automatically ? I suppose I thought they were but they can't be since you are using getImage(String) here. IMO that would be more important than this. And in any case I

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

Alexander, Were the existing Toolkit.getImage(String/URL) APIs not enhanced to do this for you automatically ? I suppose I thought they were but they can't be since you are using getImage(String) here. IMO that would be more important than this. And in any case I don't see why this is solved

Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

to change it back. Regards Prasanta On 8/24/2016 10:26 PM, Philip Race wrote: Why does the test look like this ? 157 @Override 158 public int getNumberOfPages() { 159 return 0; 160 } -phil. On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix

Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageable

Why does the test look like this ? 157 @Override 158 public int getNumberOfPages() { 159 return 0; 160 } -phil. On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix whereby it is seen that Page Ranges fields in the "cross-platform" dialog does

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154218: Non-usage of owner Frame when Frame object is passed to getPrintJob()

+1 Some day we should still consider an API that lets the application pass in an owner. -phil. On 8/24/16, 3:39 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that the Frame object passed to Toolkit.getPrintJob() is not used when cross platform

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

Please note that, this fix fixes the crash. The behavioral change in AffineTransformOp for such inputs will be fixed under JDK-8164729. Please review the updated webrev. http://cr.openjdk.java.net/~aghaisas/8158356/webrev.01/ Regards, Ajit -Original Message----- From: Philip

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

Still fine with me. -phil. On 8/23/16, 4:18 PM, Brian Burkhalter wrote: Hi Sergey, I have added some comments in both the source and the test: http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ Please indicate whether you think this

Re: [OpenJDK 2D-Dev] RFR: JDK-8164628: update copyright header in java.awt.font.JavaAWTFontAccessImpl class

Approved -phil. On 8/23/16, 3:08 PM, Yuka Kamiya wrote: Hi, https://bugs.openjdk.java.net/browse/JDK-8164628 Please review the following fix in JDK9. A comma was missing in the fix for https://bugs.openjdk.java.net/browse/JDK-8163362. ---

Re: [OpenJDK 2D-Dev] [REGRESSION?] Build warnings at jdhuff.c with GCC 6

Erik .. please chime in if you disagree with the following The goal here is to have no warnings with the *official* compilers. If you are using something else and get warnings then either fix the *source* or else you need to use --disable-warning-as-errors. Otherwise we'll be suppressing the

Re: [OpenJDK 2D-Dev] RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

This looks fine. I am just puzzled why reflection was used to begin with. What am I missing ? Was this future proofing against new constants being added ? -phil. On 8/22/16, 7:40 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

Thanks Sergey .. I am still waiting for a 2nd +1 from someone else. -phil. On 8/12/16, 12:28 PM, Sergey Bylokhov wrote: Looks fine. On 12.08.16 20:15, Philip Race wrote: Updated test : http://cr.openjdk.java.net/~prr/8139176.1/ -phil. On 8/12/16, 10:11 AM, Philip Race wrote: On 8/12/16

Re: [OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

Anyone ? -phil. On 8/11/16, 3:27 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145901 Webrev: http://cr.openjdk.java.net/~prr/8145901/ As per the evaluation in the bug this is an issue with the device scale being applied to the kerning adjustments made by the layout

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

sun/print/RasterPrinterJob.java#l688 http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ That does not seem to be the same case as this. -phil. Regards Prasanta Regards Prasanta On 8/4/2016 2:32 AM, Philip Race wrote: High-level question. Why is th

Re: [OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

On 8/17/16, 6:33 AM, Sergey Bylokhov wrote: Tested on solarisX64/solarisSparc/linuxX64 no issues were found(SwingSet2/Java2Demo). Sounds good. +1 But I wonder why the text on solarissparc filled by yellow shadow(Is it a known issue)? Yes there is an open bug. I believe it is a SPARC (or

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

+1 -phil On 8/18/16, 9:12 AM, Jayathirth D V wrote: Hi Prasanta, Changes are working fine. Thanks, Jay *From:*Prasanta Sadhukhan *Sent:* Thursday, August 18, 2016 5:30 PM *To:* Jayathirth D V; Philip Race; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163258 : Getting NullPointerException from ImageIO.getReaderWriterInfo due to failure to check for null

+1 -phil On 8/18/16, 9:04 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8163258 Webrev : http://cr.openjdk.java.net/~jdv/8163258/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

This all looks fine although this can be a simple call to attributes.get(CustomMediaTray.class) can't it ? 502 for (int i=0; i< attrs.length; i++) { 503 Attribute attr = attrs[i]; 504 try { 505 if (attr instanceof CustomMediaTray) { 506

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

+1 with the caveat that I am assuming you tested this did not regress anything else .. -phil. On 8/11/16, 10:22 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that Print-to-File option is disabled even for SERVICE_FORMATTED DocFlavor after

Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded logical fonts

-essential if I make the above change - Probably the correct location of the test is java/awt/font/TextLayout/? OK. I will tweak the test and resubmit shortly. On 11.08.16 0:15, Philip Race wrote: Equals was returning true because the full name is the same for all members of the family. That

[OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

Bug: https://bugs.openjdk.java.net/browse/JDK-8145901 Webrev: http://cr.openjdk.java.net/~prr/8145901/ As per the evaluation in the bug this is an issue with the device scale being applied to the kerning adjustments made by the layout engine. The fix builds cleanly in JPRT and has been tested

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8145014: "IIOException: Couldn't seek!" when calling TIFFImageReader.getNumImages()

+1 -phil. On 8/10/16, 7:36 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8145014 Patch: http://cr.openjdk.java.net/~bpb/8145014/webrev.00/ In the locateImage() method handle zero-entry IFDs and EOFExceptions, hopefully

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

Agreed, I had previously asked for that too (off-line). ie. root cause why a NaN would cause a crash .. -phil. On 8/10/16, 2:47 PM, Jim Graham wrote: This does address the specific test case directly, but I'd be happier if we dug down and figured out where it went wrong in trying to transform

Re: [OpenJDK 2D-Dev] RFR: 8163238: Upgrade to harfbuzz 1.3.0 in JDK 9

Yes. I saw that (I reviewed the list of fixes that were made after the 1.3.0 release) but JDK9 won't be supporting 10.9 so I figured it was not critical. But also the function that is fixed is not used in our current code. We do use hb_coretext_face_create but that is implemented differently.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8150154: AIOOB Exception during sequential write of TIFF images

+1 -phil. On 8/5/16, 4:45 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8150154 Patch: http://cr.openjdk.java.net/~bpb/8150154/ Needed to reset the ‘isRescaling’ instance variable when resetting the TIFF ImageWriter. Also,

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160455 : KSS : class.forName issue in TIFFImageMetadata.java

That would not have worked anyway, would it ? Class.forName(String) was searching using the bootstrap class loader. It presumably also would not have worked when the plugin was (in the past) loaded as a standard extension either. -phil. On 8/4/16, 9:01 AM, Brian Burkhalter wrote: That was the

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160455 : KSS : class.forName issue in TIFFImageMetadata.java

+1 -phil On 8/4/16, 4:55 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160455 Webrev : http://cr.openjdk.java.net/~jdv/8160455/webrev.00/

Re: [OpenJDK 2D-Dev] RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010

We need to ensure it always builds with the "official" compiler of the day, but at the same time, it should also build with the widest possible array of compilers. Not just on Windows. So fixes like this are welcome. -phil. On 8/4/16, 7:04 AM, Langer, Christoph wrote: Thanks Prahalad and

Re: [OpenJDK 2D-Dev] RFR: JDK-8155960: TIFF javadoc contains HTML entities inside {@code} tags

+1 (and one reviewer is enough for this minor doc fix). -phil. On 8/3/16, 3:58 PM, Brian Burkhalter wrote: Please review at your convenience. Issue:https://bugs.openjdk.java.net/browse/JDK-8155960 Patch:[1] Note that the portion of this issue in javax.imageio.plugins.tiff was resolved as

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

High-level question. Why is this not an over-ride in PSPrinterJob ? I'm afraid I did not get much past the first line of the change : 1662 MediaPrintableArea mpa = 1663 (MediaPrintableArea)getPrintService(). 1664

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160456 : KSS : resource loading issue in TIFFMetadataFormat.java

+1 -phil On 8/3/16, 7:38 AM, Brian Burkhalter wrote: Hi Jay, This looks good to me. Thanks, Brian On Aug 3, 2016, at 5:00 AM, Jayathirth D V > wrote: Hi, Please review the following fix in JDK 9 at your convenience: Bug

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

n 8/1/2016 10:43 PM, Phil Race wrote: Looking for another "+1" ... -phil. On 07/29/2016 10:13 PM, Vadim Pakhnushev wrote: Looks good! Vadim On 30.07.2016 6:49, Philip Race wrote: See http://cr.openjdk.java.net/~prr/8074843.1/ Also passes JPRT -phil. On 7/29/16, 7:35 AM, Vadim Pakhn

Re: [OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

I have not yet looked at everything but no issues except that I find checking in the shell script a bit weird. Not to mention its technically a "source file" so should have a license. -phil. On 8/2/16, 2:56 PM, Jim Graham wrote: Thanks Laurent, On 08/02/2016 05:57 AM, Laurent Bourgès wrote:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for Non serv-formatted flvrs

+1 -phil On 7/28/16, 10:28 PM, Prasanta Sadhukhan wrote: Yes, right. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/ Regards Prasanta On 7/28/2016 7:10 PM, Philip Race wrote: This can now be written more succinctly (and clearly

Re: [OpenJDK 2D-Dev] [9] Fix for JDK-6427331 : NullPointerException in LookupOp.filter(Raster, WritableRaster)

+1. -phil. On 8/2/16, 2:01 AM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6427331 Issue : If destination raster is provided as null to java.awt.image.LookupOp.filter(Raster src, WritableRaster dest), according to Javadoc, a new raster

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

, and it was closed as a duplicate, because another bug provided a way to use LCD rendering on OSX to opaque surface + workaround in swing, fixed the bug of the submitter. Probably we should file another bug as a replacement of 8078516. On 01.08.16 18:03, Philip Race wrote: Transparency

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

+1 -phil On 8/1/16, 9:13 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience : Bug : https://bugs.openjdk.java.net/browse/JDK-8160736 Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/

Re: [OpenJDK 2D-Dev] Fwd: JDK bug 8078516

Transparency of the surface has always disabled LCD sub-pixel in Java 2D. Same happens on windows. The labels at the bottom are drawn in greyscale. -phil. On 8/1/16, 7:55 AM, Torgeir Veimo wrote: Ok, am asking since subpixel rendering works and is usable in most situations, except for the odd

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8160943 : skipImage() in JPEGImageReader class throws IIOException if we have gaps between markers in Jpeg image

+1 - assuming you have run the jtreg tests for imageio .. -phil. On 8/1/16, 1:26 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8160943 Webrev : http://cr.openjdk.java.net/~jdv/8160943/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

P response, I think we should not change default value of JobSheets to STANDARD. Do you think otherwise? In the modified webrev, I have made the jobsheet default value STANDARD, only when IPP does not report any default value. http://cr.openjdk.java.net/~psadhukhan/6575247/webrev.03/ Tested in ub

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

On 7/29/16, 7:00 AM, Vadim Pakhnushev wrote: On 29.07.2016 16:28, Philip Race wrote: On 7/29/16, 3:23 AM, Vadim Pakhnushev wrote: Phil, I guess you wanted to remove the lines in the Awt2dLibraries.gmk? Ah, yes. Not just disable them Do you think it's worth it to rewrite

Re: [OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

eturn". If you don't have that "if" then the compiler would have objected to that too ! Thanks, Vadim On 29.07.2016 2:31, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8074843 Fix: http://cr.openjdk.java.net/~prr/8074843/ Here's a sampling of the warnings that I thi

[OpenJDK 2D-Dev] RFR: 8074843: Resolve disabled warnings for libmlib_image and libmlib_image_v

Bug: https://bugs.openjdk.java.net/browse/JDK-8074843 Fix: http://cr.openjdk.java.net/~prr/8074843/ Here's a sampling of the warnings that I think covers most, maybe all, of the cases LINUX mlib_ImageAffine_NN_Bit.c:87:81: error: suggest parentheses around '-' in operand of '&'

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for Non serv-formatted flvrs

This can now be written more succinctly (and clearly) as : prPgRngSupported = psCurrent.isAttributeValueSupported(prAll, docFlavor,asCurrent); -phil. On 7/28/16, 3:27 AM, Prasanta Sadhukhan wrote: Trying to be extra cautious. Please find modified webrev:

Re: [OpenJDK 2D-Dev] RFR: 8148477: Native memory leak in font layout subsystem

There's usually some fairly lengthy processing going on in the layout code so I think it would be too long to hold a critical lock and not likely to show a detectable benefit. Also I think it possible we may make some Java upcalls there .. -phil. On 7/28/16, 5:41 AM, Sergey Bylokhov wrote:

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

Tested on ubuntu and solaris 11 with the fix and banner page is printed with the fix. In mac, cover page gets printed without any change. http://cr.openjdk.java.net/~psadhukhan/6575247/webrev.01/ Regards Prasanta On 7/20/2016 8:56 PM, Philip Race wrote: In my evaluation of that bug (which was 9

Re: [OpenJDK 2D-Dev] RFR: 8162488: JDK should be updated to use LittleCMS 2.8

On 7/25/16, 10:51 PM, Prasanta Sadhukhan wrote: Just curious, cmscgats.c#why snprintf(Buffer, 1023,...) is used for a buffer of 1024 bytes. snprintf says, The generated string has a length of at most n-1, leaving space for the additional terminating null character so if we specify 1023,

[OpenJDK 2D-Dev] RFR: 8074827: Resolve disabled warnings for libjavajpeg

https://bugs.openjdk.java.net/browse/JDK-8074827 http://cr.openjdk.java.net/~prr/8074827/ Passes JPRT. gcc clobbered is left since that seems to be a gcc bug fixed in a later gcc -phil.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

In my evaluation of that bug (which was 9 yrs ago so I do not have any memory of it :-)), I note that we first need to check that job-sheets is supported .. you are not doing that .. what happens if we pass an unsupported option ? "-o foobar" ?? This needs testing on Linux, OS X, and Solaris 11.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8161264: RasterPrinterJob.updateAttributesWithPageFormat does redundant check

which is consumed and thereafter this invalid mpa value is not propagated anymore and we will fallback to Java default paper margin of 1". So, there is no need of checking for iw/ih for negative and set it to 0 . Regards Prasanta On 6/22/2016 9:07 PM, Philip Race wrote: +1 .. they won't ge

Re: [OpenJDK 2D-Dev] RFR: 8054991 : sun.font.GlyphList uses broken double-checked locking

It was a reminder that there is some optimisation we can do here so I chose to leave it rather than delete it. -phil On 7/15/16, 4:04 AM, Prasanta Sadhukhan wrote: +1. But one thing, is there any need of public static GlyphList getInstance(int sz) which is commented out. I guess we can

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-5080830: SheetCollate is not handled properly by the cross platform print dlg

+1 .. although the pattern used in the test to signal test completion is not one I've seen used before. Did you copy it from some other test ? On 7/7/16, 3:58 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that SheetCollate option is enabled for

Re: [OpenJDK 2D-Dev] Review Request for JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

Whilst looking at the reason this test was originally created https://bugs.openjdk.java.net/browse/JDK-4958271 it started to look likely that the image was (as I sort of suspected) was generated by IIO itself. I think there a couple of things we can do here 1) Open up the test (and image -

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

Updated webrev link: http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.03/ Thank you for your time& effort in review Have a good day Prahalad N. ------ -- From: Philip Race Sent: Wednesday, June 29, 2016 10:48 PM To: Pra

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

("null attribute"); } - before updateInfo() will be called so I guess null check is redundant there. Anyways, I have added the check back just to be safe http://cr.openjdk.java.net/~psadhukhan/5049012/webrev.01/ Regards Prasanta On 6/29/2016 11:59 PM, Philip Race wrote:

Re: [OpenJDK 2D-Dev] JDK 9 build with GCC 6.1.1

Hi, Not just yet. Whilst I am OK with it ... 1) We like 2 (two) reviewers to approve. 2) I would like Kim to reply to the questions so I understand his concerns first. -phil. On 6/29/16, 4:30 PM, Yasumasa Suenaga wrote: Hi Kim, Phil, Can I push this patch? It has been reviewed.

Re: [OpenJDK 2D-Dev] [9] RFR JDK-5049012: PrintToFile option is not disabled for flavors that do not support destination

--- https://docs.oracle.com/javase/8/docs/api/javax/print/PrintService.html#isAttributeValueSupported-javax.print.attribute.Attribute-javax.print.DocFlavor-javax.print.attribute.AttributeSet- Throws: NullPointerException - (unchecked exception) if attrval is null. -- So why did you remove

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6789262: getPageFormat doesn't apply PrintRequestAttributeSet specified

This is actually a little subtle. The check you are deleting has been there since 2000 .. and it can't just be removed. But it need adjusting. This is the subtlety. Most of the attribute checks are yes/no. I think for this one we need to look at the actual dimensions and return true if it is

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

PM, prasanta sadhukhan wrote: Modified webrev to close output stream. http://cr.openjdk.java.net/~psadhukhan/6218397/webrev.01/ Regards Prasanta On 6/15/2016 9:52 PM, Philip Race wrote: If this is executed on Windows (shared Postscript stream printer could do this) then since the output stream

Re: [OpenJDK 2D-Dev] [9] Review Request- JDK-8152971- JNI Warning with -Xcheck:jni

nience & provide the suggestions. Thank you for your review Have a good day Prahalad N. From: Prasanta Sadhukhan Sent: Monday, June 27, 2016 11:51 AM To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net Cc: Philip Race; Jayathirth D V; Praveen Srivastava Subject: Re: [9] Rev

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

net/~jdv/8152672/webrev.02/ Thanks, Jay -Original Message- From: Jim Graham Sent: Tuesday, June 14, 2016 12:44 AM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JP

Re: [OpenJDK 2D-Dev] RFR: JDK-8160294: Some client libraries cannot be bult with GCC 6

Could you share all warning messages that you received ? Adding them to the bug report is probably best. I feel much better reviewing these kinds of changes when I can see for myself what the issue is. -phil. On 6/25/16, 6:40 AM, Yasumasa Suenaga wrote: > Hi all, > > This review request relates

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

/16/2016 5:11 AM, Philip Race wrote: I did say so long as the "ix/iy" are also valid. Which means not just positive but that they are not too large. Consider if (iw<= 0) iw = (float)(page.getPaper().getWidth()/DPI) - (ix*2); if we have ix = 500 and iw = -20 for a paper w

Re: [OpenJDK 2D-Dev] Review Request: JDK-6457721: Stroke width incorrect while printing

For a different situation, PathGraphics does this :- if ((getTransform().getType() & ~( AffineTransform.TYPE_UNIFORM_SCALE | AffineTransform.TYPE_TRANSLATION | AffineTransform.TYPE_QUADRANT_ROTATION )) != 0) { return

[OpenJDK 2D-Dev] RFR: 4497648: TextLayout equals method is not implemented

Bug: https://bugs.openjdk.java.net/browse/JDK-4497648 Webrev : http://cr.openjdk.java.net/~prr/4497648/ TextLayout is a final class that derives directly from Object. It defines boolean equals(TextLayout) and over-rides boolean equals(Object) int hashCode(); The hashCode() delegates to the

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

able width/height is invalid we should make the entire paper as the imageable area.For invalid x,y we were making it to paper's top/left. Else what option do we have, should we calculate width[height]=abs(image[width][height]) instead? Regards Prasanta On 5/25/2016 10:07 PM, Philip Race wro

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

On 6/14/16, 10:09 PM, prasanta sadhukhan wrote: Hi Phil, On 6/15/2016 12:21 AM, Phil Race wrote: This sound fishy. "2" does not sound like a valid value per the Microsoft spec but this driver is apparently considering it as something like a multiplier although presumably not to the actual

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not throw a PrinterException if the file cannot be created

If this is executed on Windows (shared Postscript stream printer could do this) then since the output stream is still open I expect the delete will fail. Attempt to close the open stream first (in a try .. catch I suppose). -phil. On 6/15/16, 3:25 AM, prasanta sadhukhan wrote: Hi All, Bug:

[OpenJDK 2D-Dev] RFR: 8158408: Font2DTest demo needs to use FontPanel resolution matching the screen

Bug: https://bugs.openjdk.java.net/browse/JDK-8158408 Webrev: http://cr.openjdk.java.net/~prr/8158408/ At 125% scaling on JDK 9 Font2DTest looks horrid since its BufferedImage is scaled to the screen. Fix is to not use a BufferedImage, just use the Swing back buffer. -phil.

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Please post the updated webrev. -phil. On 6/1/16, 12:02 AM, Jayathirth D V wrote: Hi Phil& Jim, Collating all the changes needed: 1) I have removed both equals()& hashCode() in CCM but forgot to add the file while creating webrev. I will include changes in CCM in updated webrev. 2) Caching

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6842011: StackOverflowError printing landscape with scale and transform

: On 05/26/2016 03:49 AM, prasanta sadhukhan wrote: Hi Phil, On 5/25/2016 10:10 PM, Philip Race wrote: I am OK with committing the clarifying javadoc as part of this fix and filing a new RFE for the new method - to be fixed at some later date. However before this fix can be committed you

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6842011: StackOverflowError printing landscape with scale and transform

I am OK with committing the clarifying javadoc as part of this fix and filing a new RFE for the new method - to be fixed at some later date. However before this fix can be committed you need to make sure we have consistent behaviour across platforms and we do not have that yet -phil. On

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

It seems to me that you are using the wrong units. You have not divided by DPI to get inches. Also I am not sure that the *entire* width/height of the paper is what you want here but that is secondary to the first issue -phil On 5/19/16, 2:59 AM, prasanta sadhukhan wrote: Hi All, Please

<    1   2   3   4   5   6   7   >