[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Amanda Walker
On Wed, Oct 28, 2009 at 1:39 PM, Jens Alfke s...@google.com wrote: Unfortunately, it's nearly impossible to continue a forked process on OS X if it uses any higher-level (above POSIX) APIs. Nothing says we have to use fork(). Always having a renderer process started and waiting for

[chromium-dev] Re: Mac renderer launch (Was: Why is Linux Chrome so fast?)

2009-10-28 Thread Amanda Walker
On Wed, Oct 28, 2009 at 3:12 PM, Jens Alfke s...@google.com wrote: Not on a cold launch, since the renderer uses a lot of code (like WebCore) that the browser doesn't, and will be paging that stuff in. We'll need to benchmark both scenarios. Indeed. Proof of concept code that we can compare

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

2009-10-09 Thread Amanda Walker
On Fri, Oct 9, 2009 at 5:01 AM, Jickae Davis jick...@gmail.com wrote: Well, I agree with PhistucK. I think a progress bar may help though it's not so accurate. By the way, if I want to add such a bar with chromium, how should I start? Is there a method that tells the size of the resources to

[chromium-dev] Re: Does Chromium MacOSX always create NSButtonCell for each html input submit button

2009-10-09 Thread Amanda Walker
On Fri, Oct 9, 2009 at 7:02 PM, hap 497 hap...@gmail.com wrote: Sorry, maybe I used a wrong term in asking my question. I think I am looking for the code which chormium create a native UI widget for each html input submit button in the html source. I assume chromium needs to use 1 native UI

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

2009-10-09 Thread Amanda Walker
On Fri, Oct 9, 2009 at 10:28 PM, Jickae Davis jick...@gmail.com wrote: No--there is in fact no way to determine that in advance. Each resource can reference other resources, and even for a single resource we often don't know what size it is until we finish loading it. We could provide a

[chromium-dev] Re: [LTTF] Flaky tests and setTimeout

2009-10-09 Thread Amanda Walker
Most awesome. Very good catch. On Fri, Oct 9, 2009 at 9:52 PM, Julie Parent jpar...@chromium.org wrote: For those of you looking into flaky tests - I've found a surprising number of tests that are flaky because they use a setTimeout to guarantee that a resource (usually an iframe) has

[chromium-dev] Re: build time speed improvement with solid state drive?

2009-10-05 Thread Amanda Walker
On Mon, Oct 5, 2009 at 2:08 PM, Marshall Greenblatt magreenbl...@gmail.comwrote: I'm putting together a new computer and I'd like to optimize my chromium build times :-) Is anyone currently building chromium using a solid state drive? Have you noticed any compile or link time speed

[chromium-dev] Re: Unimplemented GraphicsContextSkia functions

2009-09-30 Thread Amanda Walker
Could you do some of this with a canvas (app/gfx/canvas.h)? It's supported on all platforms, though it's not heavily used. The sad plugin code is an example. Right now it only handles rects, images, and text, but adding path drawing to it shouldn't be difficult... --Amanda On Wed, Sep 30, 2009

[chromium-dev] Re: Question about UI and classic views

2009-09-25 Thread Amanda Walker
On Thu, Sep 24, 2009 at 3:11 AM, Darin Fisher da...@chromium.org wrote: Do websites provide users with previous versions after overhauling their UX? Some do (gmail seems to), but most do not. You just get to surf the latest. Hopefully, the website changes for the better. That's our burden

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-25 Thread Amanda Walker
On Tue, Sep 22, 2009 at 9:06 PM, Dimitri Glazkov dglaz...@google.comwrote: This all means that we have to be a bit more diligent. We shouldn't be paying these unnecessary costs. So, from now on, I propose a fairly simple set of new rules: 1) if you write a Chromium patch for WebKit, you must

[chromium-dev] Re: Question about UI and classic views

2009-09-25 Thread Amanda Walker
On Fri, Sep 25, 2009 at 1:11 PM, Peter Kasting pkast...@google.com wrote: All software, and all browsers, change their UI and capabilities as they release new versions. Look at how Firefox 1.0, 2.0, 3.0, and 3.5 all had different main window themes (and not just cosmetically; they moved

[chromium-dev] Re: Webkit merges and tree closures

2009-09-23 Thread Amanda Walker
On Tue, Sep 22, 2009 at 8:40 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Oh, and, if your change turned the tree red for 3 hours, don't be mad at the sheriff when he pings you repeatedly about the status of the fix. His job is to keep the tree green and running. He does not care about

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Amanda Walker
On Thu, Sep 10, 2009 at 2:05 PM, Jacob Mandelson ja...@mandelson.org wrote: It was more surprised that I was expected to have built chrome at home under multiple platforms. I wouldn't say that we expect people to build chrome at home under multiple platforms. We expect patches not to break

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
On Thu, Sep 10, 2009 at 1:03 PM, Dan Kegel d...@kegel.com wrote: An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
I blogged about that when we kicked off the additional platform efforts, though it's probably a good idea to say something about it on the site as well. --Amanda On Thu, Sep 10, 2009 at 1:20 PM, Nico Weber tha...@chromium.org wrote: An external contributor was recently surprised that a

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Amanda Walker
Sure. I'd run anything I write up past Ben, brian, etc. first before posting anything. --Amanda On Thu, Sep 10, 2009 at 3:07 PM, Peter Kasting pkast...@google.com wrote: On Thu, Sep 10, 2009 at 10:20 AM, Nico Weber tha...@chromium.org wrote: While you're on it, could you add something like

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
The main problem is that it doesn't work through NAT routers or firewalls, since it relies on the remote end opening a connection back to the client. There's no big advantage unless you're talking to an old FTP server that doesn't support passive FTP. --Amanda On Wed, Sep 9, 2009 at 1:53 PM,

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
On Wed, Sep 9, 2009 at 1:56 PM, Peter Kasting pkast...@google.com wrote: I can't think of any.  It would be nice to have active support.  I'm not sure how easy it is to auto-detect which one we should use (since all the FTP clients I've ever used have forced me to specify manually). It should

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
On Wed, Sep 9, 2009 at 4:02 PM, Michal Zalewski lcam...@gmail.com wrote: My reading of the bug is the former, since the latter would be fairly astonishing.  Passive FTP does not require any special inspection by NAT, while active does. Likewise, passive mode requires inspection on client

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
On Wed, Sep 9, 2009 at 3:52 PM, Michal Zalewski lcam...@gmail.com wrote: Are we trying to solve the problem of the server having no passive FTP support (how common would that be?), or of the server's firewall / NAT device not having FTP traffic inspection helpers? My reading of the bug is the

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
On Wed, Sep 9, 2009 at 4:11 PM, Michal Zalewski lcam...@gmail.com wrote: Err, the other way round obviously (passive requires server-side support to rewrite IP and port data in FTP command responses behind NAT, and punch a temporary hole in the firewall allowing the client to connect back to

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Amanda Walker
On Wed, Sep 9, 2009 at 4:31 PM, Michal Zalewski lcam...@gmail.com wrote: Well, let's say the server has an internal IP of 1.2.3.4, and along with several other nodes in its cluster, is publicly NATed to 4.3.2.1. The client says PASV, and the server, unless explicitly aware of its current

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-04 Thread Amanda Walker
On Fri, Sep 4, 2009 at 10:55 AM, Jóijoi.sigurds...@gmail.com wrote: At least on Windows, the NPAPI plug-in would be loaded into the Chrome process, so there would need to be a flag to select between 32-bit and 64-bit versions of the plug-in if Chrome starts being available as a native 64-bit

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-04 Thread Amanda Walker
On Fri, Sep 4, 2009 at 1:52 PM, Aaron Boodmana...@chromium.org wrote: Ok, but does it always have the same structure, and is there a naming convention? Yes. The top level folder is always named the plugin name + .plugin, and always has a file Info.plist inside with all of the metadata, names

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-04 Thread Amanda Walker
On Fri, Sep 4, 2009 at 1:34 PM, Aaron Boodmana...@chromium.org wrote: Yeah, I am kinda curious whether this approach can work generically without adding anything to the manifest. Particularly since there is a naming convention for shared libraries on all platforms. Plugins aren't even always

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-04 Thread Amanda Walker
On Fri, Sep 4, 2009 at 1:09 PM, Jóijoi.sigurds...@gmail.com wrote: Yes, you're right, Chrome's multi-process architecture would let you host the plug-in in a 32-bit process even if the rest of Chrome is 64- bit.  However, if the extension author wants to provide both 32-bit and 64-bit

[chromium-dev] Re: Long (exciting?) writeup on improving Mac New Tab Performance (not entirely Mac-specific)

2009-08-31 Thread Amanda Walker
Great writeup. There's definitely too much going on in the UI thread. Even after the page paints, I'm seeing multi-second pauses while additional stuff comes in, where the browser process is unresponsive (example: iGoogle with a bunch of gadgets). It's not clear to me why any http resource

[chromium-dev] Re: Long (exciting?) writeup on improving Mac New Tab Performance (not entirely Mac-specific)

2009-08-31 Thread Amanda Walker
On Mon, Aug 31, 2009 at 12:12 PM, Mark Mentovai m...@chromium.org wrote: HTTP resource loading shouldn't be on the browser's main thread. This only applies to DOM UI resource loading, chrome: and chrome-internal:. That stuff gets funneled through the browser's main thread for things like

[chromium-dev] Re: Loading problems chromium on mac os x

2009-08-26 Thread Amanda Walker
If you are running Chromium from inside Xcode, make sure that you turn off the Stop on Debugger()/DebugStr() option in the Run menu. The Flash plugin makes a call to Debugger() when it starts up--normally this is harmless, but if you are running from Xcode instead of the Finder, it will cause

[chromium-dev] Re: FreeBSD port and ifdefs

2009-08-20 Thread Amanda Walker
On Thu, Aug 20, 2009 at 6:06 AM, Ben Laurieb...@chromium.org wrote: I'd be happy to do that. When I do, there's something that's already puzzling me, and that's OS_POSIX. I don't have a copy of the POSIX standard, at least not a recent one, so its hard to know what is or isn't POSIX, and I

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-20 Thread Amanda Walker
Oops, didn't see how long the thread was :-). On Thu, Aug 20, 2009 at 7:10 PM, Amanda Walkerama...@chromium.org wrote: Safari does not.  Single click sets the text caret where you click. On Thu, Aug 20, 2009 at 4:56 PM, Peter Kastingpkast...@chromium.org wrote: On Thu, Aug 20, 2009 at 1:36

[chromium-dev] Re: WebKit API guidance?

2009-08-20 Thread Amanda Walker
On Thu, Aug 20, 2009 at 9:17 PM, Drew Wilsonatwil...@chromium.org wrote: I have to admit I'm somewhat fuzzy on the motivation behind our webkit API, although I gather the plan is to eventually upstream it to WebKit, and use it as our abstraction layer instead of using the (more mutable)

[chromium-dev] Re: browser/sync is moving in

2009-08-19 Thread Amanda Walker
Being dismissive and sarcastic will do that, yes. --Amanda On Wednesday, August 19, 2009, codfather swcodfat...@gmail.com wrote: Hmm, have I touched a nerve. On Aug 19, 5:32 pm, PhistucK phist...@gmail.com wrote: In order to add the new features to a version, first, you have a (stable)

[chromium-dev] Re: Plugin control flow and race conditions

2009-08-18 Thread Amanda Walker
On Mon, Aug 17, 2009 at 2:43 PM, bsmedbergbsmedb...@gmail.com wrote: The most obvious problem is that both processes may send a synchronous IPC message at the same time. Assuming that these don't deadlock, the native stack for the two calls would end up interleaved. While there may be a

[chromium-dev] Re: Tree hygiene

2009-08-14 Thread Amanda Walker
While bot health is separate from tree health, I'm not sure we really want to tolerate redness because a bot is sick--it'll still keep us from noticing regressions or bustage in a timely fashion. However, a way to visually distinguish between build failure and bot failure would be nice. out of

[chromium-dev] Re: Clobbering

2009-08-11 Thread Amanda Walker
I agree. Every clobber means we have a dependency bug. I would prefer that we track and fix those bugs than get desensitized to them. --Amanda On Tue, Aug 11, 2009 at 1:45 AM, Aaron Boodman a...@chromium.org wrote: Such a system does not help when people sync your change. We should invest

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-10 Thread Amanda Walker
On Mon, Aug 10, 2009 at 12:32 AM, PhistucK phist...@chromium.org wrote: Obviously, but since there is a website (what started this thread) and people do run into issues (Help forums) with such a thing, is a specific solution for Flash, at least, coming up soon? People getting infected while

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-09 Thread Amanda Walker
We've already started to tackle the issue (see the existing code that is turned on with --safe-plugins), we just haven't solved it. As several of us have said in the thread, we'd welcome additional contributions towards a robust plugin sandbox. However, if someone doesn't believe us when we (a)

[chromium-dev] Re: Trick question: Who is responsible for repairing a red tree?

2009-08-05 Thread Amanda Walker
Very much agreed. If anything is red, and it's not immediately clear that someone's on it, close the tree. The burden should be on whoever is explaining why the tree is open but red, not why it's closed, especially for the sheriff. --Amanda On Wednesday, August 5, 2009, Peter Kasting

[chromium-dev] Re: Mozilla design challenge

2009-07-21 Thread Amanda Walker
On Tue, Jul 21, 2009 at 12:32 PM, Erik Kayerik...@chromium.org wrote: In my use case, 80% of my tabs could easily be killed / suspended (or even hidden altogether) without any downside to me.  The problem is that there isn't a way to automatically figure out which ones are which.  Which ones

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
On Tue, Jul 14, 2009 at 3:40 AM, Adam Barthaba...@chromium.org wrote: Wow, there are even more on Mac: Expected to fail, but passed (39) If some of those are plugin related, it's because I didn't remember last night that the --enable-plugins flag I checked in didn't affect test shell, so many

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
On Tue, Jul 14, 2009 at 3:38 AM, Adam Barthaba...@chromium.org wrote: Expected to crash, but passed (9):  LayoutTests/fast/dom/offset-parent-positioned-and-inline.html  LayoutTests/fast/events/message-channel-gc-2.html  LayoutTests/fast/events/message-channel-gc-4.html  

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlowjor...@chromium.org wrote: I think we should re-enable them ASAP unless there's some good reason why you want to wait. They've been stable and passing all morning, so that works for me. --Amanda

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Amanda Walker
And as soon as I took them out, they started failing again. We're reverting. --Amanda On Tue, Jul 14, 2009 at 12:08 PM, Amanda Walkerama...@chromium.org wrote: On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlowjor...@chromium.org wrote: I think we should re-enable them ASAP unless there's some

[chromium-dev] Re: middle click on home

2009-07-13 Thread Amanda Walker
On Fri, Jun 26, 2009 at 8:22 PM, Peter Kastingpkast...@google.com wrote: Given that there are a large number of ways to open the home page in a new foreground tab (e.g. ctrl-t + click, shift-middle click, etc.), there are a very large number of other places in the UI where middle-click opens a

[chromium-dev] Re: Theme re-encoding

2009-07-10 Thread Amanda Walker
On Fri, Jul 10, 2009 at 3:54 PM, Avi Drissmana...@google.com wrote: Two things. First, this doesn't happen on Windows. Second, how do you get an image shifted one pixel to the right? On the Mac, ImageDecoder::Decode uses the webkit decoders which on the Mac return a CGImage, and then

[chromium-dev] Re: How does chromium use SkCanvas

2009-06-29 Thread Amanda Walker
Sorry for the typos--I'm still working on my first coffee of the day :-). On Mon, Jun 29, 2009 at 7:47 AM, Amanda Walkerama...@chromium.org wrote: There are no active plans at the moment, but it could be done if a strong reason to arose. to - to do so code charing with Apple. charing -

[chromium-dev] Re: 3.0.190.4 Dev Release Release Notes

2009-06-29 Thread Amanda Walker
3.0.190 is the current developer channel build. Its release notes are at http://dev.chromium.org/getting-involved/dev-channel/release-notes as usual. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives,

[chromium-dev] Re: How does chromium use SkCanvas

2009-06-28 Thread Amanda Walker
The Mac OS X port uses CoreGraphics to render page contents rather than Skia (it shares most of the rendering code with Apple's mac port, though Skia is used elsewhere in Mac Chrome for a variety of purposes). If you are trying to learn more about Skia, I would suggest trying the Linux version

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Amanda Walker
This is a great overview! Thanks for writing this up. I wonder if it's worth giving some more guidance about when to use #ifdef vs. say splitting out a couple of methods into a platform-specific file. For example: if you find yourself wrapping the entire body of a function in platform #ifdefs,

[chromium-dev] Re: RE : chrome's testing

2009-06-08 Thread Amanda Walker
It does not depend on scope. By default, every change that is uploaded by a committer for code review gets built on all three platforms by Google's try servers. --Amanda 2009/6/7 PhistucK phist...@gmail.com I forgot about the cross platform compiling stuff. I do not think every change is

[chromium-dev] Re: RE : chrome's testing

2009-06-07 Thread Amanda Walker
Anyone ccould set one up for their own use, or even public use if they wanted to--the ones Google has set up are just a convenience provided to committers that may not have a machine of each platform available. --Amanda 2009/6/7 PhistucK phist...@gmail.com A Try Bot is a machine that gets sent

[chromium-dev] Re: Is there any way to profile chromium on MacOS?

2009-06-02 Thread Amanda Walker
TestShell does not use a separate renderer process. --Amanda On Tue, Jun 2, 2009 at 12:25 PM, Lucius Fox lucius.fo...@gmail.com wrote: I can build and debug TestShell project. But can you please tell me how to attach appropriate renderer with Shark? What is an appropriate renderer? On Mon,

[chromium-dev] Re: confused with chrome's version control

2009-06-02 Thread Amanda Walker
There is only one form of version control, which is the Subversion repository. For convenience, we provide a few alternatives to checking out a source tree from subversion and building it: tarballs: a tarball is a tar format archive of a complete source tree that has been checked out from the

[chromium-dev] Re: Does anyone have objections to adding a GetSwitchValues() accessor to CommandLine?

2009-06-02 Thread Amanda Walker
Would an iterator method on CommandLine serve the same purpose? It seems like that could work without having to make a copy... --Amanda On Wed, Jun 3, 2009 at 12:06 AM, Book'em Dano daniel.c...@gmail.com wrote: Does anyone have objections to including such a function? It would just return a

[chromium-dev] Re: Where is the integration point betwee chromium and V8

2009-05-29 Thread Amanda Walker
Xcode can have problems properly setting breakpoints in subprojects. There are two ways to work around this: - Uncheck the Load *symbols lazily option in Xcode's debugging preferences.* - Open up the gdb console window and set breakpoints from the gdb command line --Amanda 2009/5/29 Lucius Fox

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Amanda Walker
On Tue, May 26, 2009 at 11:31 PM, Brett Wilson bre...@chromium.org wrote: Don't bother doing an assertion when the next line will crash anyway: DCHECK(foo); foo-DoSomething(); will normally crash pretty obviously dereferencing a NULL pointer (even though it will be inside DoSomething).

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-27 Thread Amanda Walker
On Wed, May 27, 2009 at 3:20 PM, Darin Fisher da...@chromium.org wrote: I think if we require everyone to handle every failed DCHECK, then what we will really do is compel people to write fewer DCHECKs, which means that we will lose some of the documentation benefits. That seems undesirable

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-22 Thread Amanda Walker
I'm pretty happy with it. It would be nice to polish things like the missing shadow, but that shouldn't stop us from landing it or adding it to GTM. --Amanda On Fri, May 22, 2009 at 10:16 AM, Avi Drissman a...@google.com wrote: On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai m...@chromium.org

[chromium-dev] Re: Mac History Menu Implementation

2009-05-22 Thread Amanda Walker
On Fri, May 22, 2009 at 7:22 PM, Robert Sesek rse...@gmail.com wrote: I think that Firefox's implemntation makes the most sense from a usability perspective. Those long menus in Safari are next to worthless if you have a decent-sized browsing history and really just clutter things up.

[chromium-dev] Re: Mac History Menu Implementation

2009-05-22 Thread Amanda Walker
On Sat, May 23, 2009 at 12:22 AM, Mark Larson (Google) m...@chromium.org wrote: Just so it's clear to me... why do we need a History menu? There's a link to history from the wrench menu/Ctrl+H and also from the New Tab page. The back button provides at least 12 entries from the back 

[chromium-dev] Re: Drawing code on Mac

2009-05-20 Thread Amanda Walker
On Wed, May 20, 2009 at 9:22 AM, Marc-Andre Decoste m...@google.com wrote: I don't think I can do the save/restore trick in PlatformDeviceMac::LoadClippingRegionToCGContext(), because this a static method with no context... But I noticed that it is only called at one place, within

[chromium-dev] Re: [linux] green flashes in page content

2009-05-20 Thread Amanda Walker
The mac build does something like this: the background color of all the windows is actually magenta, which makes it very obvious when something's not getting painted or the process isn't responding to events. --Amanda 2009/5/20 Linus Upson li...@google.com: I think it would be great if I

[chromium-dev] Re: Drawing code on Mac

2009-05-16 Thread Amanda Walker
, Amanda Walker awal...@google.com wrote: Hmm.  Marc, your change looks OK to me at first glance--how does it fail? --Amanda On Wed, May 13, 2009 at 12:10 PM, Avi Drissman a...@google.com wrote: I'm view meister, not render meister. Amanda is IIRC backing store/canvas meister. Avi

[chromium-dev] Re: Drawing code on Mac

2009-05-16 Thread Amanda Walker
the host to only paint a set of sub-rectangle from that bitmap. Do I explain it clearly enough? Thanks BYE MAD On Wed, May 13, 2009 at 1:16 PM, Amanda Walker awal...@google.com wrote: Hmm.  Marc, your change looks OK to me at first glance--how does it fail? --Amanda On Wed, May 13, 2009

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Amanda Walker
Perhaps what we need is a companion to FilePath. For example: FilePath: much as it is now, lightweight, alternative to string manipulation. FileReference: heavierweight, can talk to the file system and have carnal knowledge of platform specifics for things like resolving / canonicalizing

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Amanda Walker
On Wed, May 13, 2009 at 7:07 PM, Brett Wilson bre...@chromium.org wrote: On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote: Perhaps what we need is a companion to FilePath.  For example: FilePath: much as it is now, lightweight, alternative to string manipulation

[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Amanda Walker
On Tue, May 12, 2009 at 10:16 AM, Nicolas Sylvain nsylv...@chromium.org wrote: It's why we have checkin notification emails. http://groups.google.com/group/chromium-checkins?pli=1 I also like the RSS feeds, especially on a mobile device: http://groups.google.com/group/chromium-checkins/feeds

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-08 Thread Amanda Walker
Yeah. And I have to say, the tab-modal file sheet is very, very cool. It would be a shame to lose that capability. --Amanda On Fri, May 8, 2009 at 3:58 PM, Avi Drissman a...@google.com wrote: The problem with that approach is that you can't cleanly close a sheet in the general case. If

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-07 Thread Amanda Walker
That's cleaner than I expected, and the behavior looks right. Nice job! I vote for continuing with this approach. --Amanda On Thu, May 7, 2009 at 12:17 AM, Avi Drissman a...@google.com wrote: OK, so attached is my proof of concept. The code is pretty clear, though if you have questions,

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-06 Thread Amanda Walker
2009/5/6 Andrew Scherkus scher...@chromium.org: We'll ping WebKit to find out the reasoning behind passing in a GraphicsContext.  Probably for performance reasons and reducing extra blits/copies, but still worth investigating. Probably that and preserving any active transforms, as Brett

[chromium-dev] Re: Does chrome has an add-on preference system?

2009-05-06 Thread Amanda Walker
Hmm. Rather than an idle event, how about a general way to notify on machine state changes? idle / busy, ac / battery, willsleep / didwake, etc. all seem to have the same usage pattern. Apps could then key off of the notification to start/stop workers or timers for idle processing, etc.

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Amanda Walker
to duplicate it. --Amanda On Tue, May 5, 2009 at 12:27 PM, Никита Офицеров himi...@gmail.com wrote: I'm sorry for the late response, I've been quite busy last week. 2009/4/27 Amanda Walker ama...@chromium.org: Hacky is fairly subjective: are there particular things about the existing

[chromium-dev] Re: Tab-modal dialogs on the Mac

2009-05-05 Thread Amanda Walker
I'd be worried about flashing/jankiness using a real sheet, but a child window pinned to the top edge of the tab with the right transitions might work nicely. There's also some stuff Jeremy was doing in Gears that involved doing interesting things with login prompts that may (or may not) be

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
That would be pretty clean--or perhaps wrap it in a PlatformCanvas instead of a bare PlatformGraphicsContext? I haven't looked at the media code yet, so I'm not familiar with what it's actually trying to do. --Amanda On Tue, May 5, 2009 at 10:08 PM, Brett Wilson bre...@chromium.org wrote: On

[chromium-dev] Re: Passing PlatformGraphicsContext from WebKit to Chrome code

2009-05-05 Thread Amanda Walker
Ah, I see. Hmm, going in that direction (from a GraphicsContext back up to the PlatformCanvas that wraps it) is an interesting question (the rest of our rendering code goes in the other direction). And as Brett can attest, this isn't the first time that PLATFORM(CG) has caused a headache--we

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
The Mac needs something morally equivalent to #2 (with plugins as the current forcing function--there's no cross-process window handle we can use, so we need to track them ourselves anyway). I also strongly agree that the browser needs to be able to validate which window(s) a renderer can ask

[chromium-dev] Re: Plugin painting and deadlock

2009-05-04 Thread Amanda Walker
The only thing I can thing of that involves a client-server-client-server-client world tour in X is selection handling, but that's asynchronous. Querying window properties only looks at server state (also true for the Mac's window server--there's no such thing as a synchronous call from the

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
is, which sounds similar to gtk_native_view_id_manager... Adam On Mon, May 4, 2009 at 5:55 AM, Amanda Walker ama...@chromium.org wrote: The Mac needs something morally equivalent to #2 (with plugins as the current forcing function--there's no cross-process window handle we can use, so we need

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
Hmm. Would it be even cleaner for nothing but the plugin host process to care about the NativeViewId, since it's what has to provide it to the plugin via NPAPI? For everything else, either we're windowless and just shipping bitmaps around (no need for a window reference at all except to keep

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-04 Thread Amanda Walker
. -Darin On Mon, May 4, 2009 at 1:37 PM, Amanda Walker ama...@chromium.org wrote: Hmm.  Would it be even cleaner for nothing but the plugin host process to care about the NativeViewId, since it's what has to provide it to the plugin via NPAPI?  For everything else, either we're windowless

[chromium-dev] Re: Changes to FilePath?

2009-04-28 Thread Amanda Walker
On Tue, Apr 28, 2009 at 4:39 PM, Greg Spencer gspen...@google.com wrote: 1) I'd like to add some explicit routines for converting to/from UTF8 and UTF16.  While it's nice (and important) that FilePath uses the platform's native string, we've found that many third party libraries have made

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-27 Thread Amanda Walker
pinker...@chromium.org wrote: On Sun, Apr 26, 2009 at 5:50 PM, Amanda Walker ama...@chromium.org wrote: Application startup is one of the areas where we count every millisecond, and try to touch the disk as little as possible.  I don't think it's safe to assume that the cost of creating

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-04-26 Thread Amanda Walker
On Thu, Apr 23, 2009 at 4:35 PM, Nikita Ofitserov himi...@gmail.com wrote: Currently there are different implementations of ProcessSingleton and ChromeBrowserProcessId() on Windows, Linux and Mac. Most of them are quite hacky, so there should be a better way. I think current IPC system with

[chromium-dev] Re: Mac/Linux heads-up: RenderWidgetHostView changes needed

2009-04-13 Thread Amanda Walker
On Mon, Apr 13, 2009 at 12:13 PM, Darin Fisher da...@chromium.org wrote: The Mac implementation is wrong.  On a single core machine, the renderer could starve the UI thread of the browser, preventing any pixels from ever being updated on the screen. That seems wrong--the OS-prompted draw

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe to open a new tab.  This is the standard way of doing it on Windows, but I don't know how Mac/Linux apps enforce single-instance semantics.  

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
On Tue, Mar 24, 2009 at 1:06 PM, John Abd-El-Malek j...@chromium.org wrote: A lot of the code that touches databases/files in the user-data-dir assume they're the only ones accessing them.  If multiple instances use the data, there could be corruption. Makes sense. But multiple instances

[chromium-dev] Re: porting chrome_process_filter

2009-03-24 Thread Amanda Walker
, 2009 at 1:06 PM, Thomas Van Lenten thoma...@chromium.org wrote: On Tue, Mar 24, 2009 at 1:00 PM, Amanda Walker ama...@chromium.org wrote: 2009/3/24 John Abd-El-Malek j...@chromium.org: Right, this is used so that if the user starts Chrome a second time, it tells the currently running exe

[chromium-dev] Re: Rendering issues in chromium with theme applied

2009-03-22 Thread Amanda Walker
On Sat, Mar 21, 2009 at 6:54 PM, Robert Dailey rcdai...@gmail.com wrote: This issue is really quite serious for me as I am unable to use chromium on certain websites. I have hacked my uxtheme.dll on Windows XP so that I may apply third party visual themes to windows. Chromium does not yet

[chromium-dev] Re: Rendering issues in chromium with theme applied

2009-03-22 Thread Amanda Walker
with the code changes. On Sun, Mar 22, 2009 at 1:57 PM, Amanda Walker ama...@chromium.org wrote: On Sat, Mar 21, 2009 at 6:54 PM, Robert Dailey rcdai...@gmail.com wrote: This issue is really quite serious for me as I am unable to use chromium on certain websites. I have hacked my uxtheme.dll on Windows XP

[chromium-dev] Re: New waterfall Developer View.

2009-03-16 Thread Amanda Walker
Nicolas, I like this a *lot*--it makes it much easier to see which build or test failures resulted from a particular commit. Very nice job! --Amanda On Sun, Mar 15, 2009 at 9:54 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hello!   A lot of people told me that they did not like the

[chromium-dev] Re: Status Bubble GTK?

2009-03-13 Thread Amanda Walker
On Fri, Mar 13, 2009 at 8:17 AM, Dean McNamee de...@chromium.org wrote: I wonder if the situation is at all similar on Mac. The Mac is pretty flexible in this regard--we can create arbitrarily shaped windows that are grouped/stacked with existing windows however we want (or put another way,

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 10:45 AM, Thomas Van Lenten thoma...@chromium.org wrote: What happens when we want to paste into an html edit area? Well, at least last time I looked at editable areas, they weren't handled via NSStrings, so I don't think we'd run into this problem there. Do we need to

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
Do we know it's obj-c collision? Or is it C++ types that are typedefed differently for us, but conveniently named-mangled the same so they link? --Amanda On Wed, Mar 11, 2009 at 10:49 AM, Mark Mentovai mmento...@google.com wrote: Avi Drissman wrote: 4. Figure out why system WebKit doesn't

[chromium-dev] Re: Copy/Paste, Cocoa, and you

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 10:55 AM, Mark Mentovai mmento...@google.com wrote: Binding C++ shouldn't be nearly as painful on the Mac: stuff is bound into a two-level namespace at link time. Ah, excellent point.  The smart money's on Obj-C which binds at runtime every time, but in today's

[chromium-dev] Re: Thoughts on copy/paste

2009-03-11 Thread Amanda Walker
On Wed, Mar 11, 2009 at 2:07 PM, Brett Wilson bre...@chromium.org wrote: Do you mean when you click on the menu, blocking the browser until the renderer responds with whether the menus can be enabled? I would be opposed to that. So are we, but that's what WebKit currently assumes. That's why

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Amanda Walker
Because we don't see the mouse click for the main menu bar the same way we do for a context menu. Normally, we just get called back after a menu item has been selected. It's possible to update state while the menu is down, but that brings in the possibility of flashing/etc. as the menu changes

[chromium-dev] Re: [chromium-checkins] r10972 - in trunk/src: chrome/browser/renderer_host chrome/common net/base net/http net/url_request webkit/glue

2009-03-05 Thread Amanda Walker
On Thu, Mar 5, 2009 at 12:38 PM, Alpha (Hin-Chung) Lam hc...@google.com wrote: everytime I do a checkin I do a sync and send it to the try server, which really takes me a lot of time, but still try server is showing me green light to check in, am I suppose to not trust the try server and rely

[chromium-dev] Re: how keyboard input works

2009-02-19 Thread Amanda Walker
IMEs on the Mac even further decouple keystrokes from input characters, and we're going to need explicit support for them (since they will probably have to live in the browser process in order to put up windows, etc.). There will probably be a level at which we'll have to write some glue to feed

[chromium-dev] Re: What is the app\theme\chromium\chromium.icns file used for?

2009-02-17 Thread Amanda Walker
It is the Chromium application icon for the Mac. On Tue, Feb 17, 2009 at 10:36 PM, Daniel dpc...@hotmail.com wrote: Does anyone know what is the app\theme\chromium\chromium.icns file is used for? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

  1   2   >