apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r313212202
##
File path: src/c_api/c_api.cc
##
@@ -562,6 +580,23 @@ int MXNDArrayGetShapeEx(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312339191
##
File path: python/mxnet/ndarray/ndarray.py
##
@@ -105,6 +107,8 @@
_NDARRAY_BASIC_INDEXING = 0
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312266063
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -708,6 +781,31 @@ int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312265776
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -585,76 +585,149 @@ int MXSymbolInferShape(SymbolHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312264156
##
File path: python/mxnet/runtime.py
##
@@ -69,12 +69,18 @@ def feature_list():
features =
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312261064
##
File path: src/c_api/c_api.cc
##
@@ -537,20 +557,18 @@ int MXNDArrayGetShape(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312252386
##
File path: src/c_api/c_api.cc
##
@@ -537,20 +557,18 @@ int MXNDArrayGetShape(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r312251629
##
File path: python/mxnet/runtime.py
##
@@ -69,12 +69,18 @@ def feature_list():
features =
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311864007
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311863890
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -528,7 +528,7 @@ int MXSymbolInferShape(SymbolHandle sym,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311863514
##
File path: python/mxnet/symbol/symbol.py
##
@@ -52,6 +52,7 @@
"ones", "full", "arange",
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311863319
##
File path: include/mxnet/c_api.h
##
@@ -1582,6 +1660,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311862760
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -585,6 +585,78 @@ int MXSymbolInferShape(SymbolHandle sym,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311862462
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -585,6 +585,78 @@ int MXSymbolInferShape(SymbolHandle sym,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311859584
##
File path: src/c_api/c_api_common.h
##
@@ -57,6 +57,7 @@
using namespace mxnet;
/*! \brief entry to
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311859462
##
File path: src/c_api/c_api.cc
##
@@ -537,20 +557,18 @@ int MXNDArrayGetShape(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311859169
##
File path: src/c_api/c_api.cc
##
@@ -537,20 +557,18 @@ int MXNDArrayGetShape(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311858351
##
File path: src/c_api/c_api.cc
##
@@ -174,48 +174,68 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311798249
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311797917
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311797867
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311693364
##
File path: include/mxnet/tuple.h
##
@@ -366,7 +366,6 @@ class Tuple {
}
};
-
Review comment:
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311693093
##
File path: include/mxnet/c_api.h
##
@@ -565,6 +567,13 @@ MXNET_DLL int MXNDArrayCreateEx(const mx_uint
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310783434
##
File path: src/c_api/c_api.cc
##
@@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782505
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -585,6 +586,96 @@ int MXSymbolInferShape(SymbolHandle sym,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782296
##
File path: src/c_api/c_api_common.h
##
@@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry {
/*! \brief
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782321
##
File path: src/c_api/c_api_common.h
##
@@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry {
/*! \brief
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781490
##
File path: python/mxnet/ndarray/ndarray.py
##
@@ -131,14 +133,24 @@ def _new_alloc_handle(shape, ctx,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781096
##
File path: include/mxnet/tuple.h
##
@@ -366,7 +366,6 @@ class Tuple {
}
};
-
Review comment:
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310780707
##
File path: include/mxnet/c_api.h
##
@@ -55,7 +55,9 @@ extern "C" {
#endif
/*! \brief manually
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r307650435
##
File path: include/mxnet/c_api.h
##
@@ -802,6 +837,11 @@ MXNET_DLL int MXNDArrayReshape64(NDArrayHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r307115989
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,358 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r307116067
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,358 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r307115927
##
File path: tests/nightly/test_large_vector.py
##
@@ -0,0 +1,358 @@
+# Licensed to the Apache Software
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306929066
##
File path: tests/nightly/test_large_array.py
##
@@ -157,8 +157,8 @@ def test_take():
def
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306929196
##
File path: tests/nightly/test_large_array.py
##
@@ -157,8 +157,8 @@ def test_take():
def
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306929196
##
File path: tests/nightly/test_large_array.py
##
@@ -157,8 +157,8 @@ def test_take():
def
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306929066
##
File path: tests/nightly/test_large_array.py
##
@@ -157,8 +157,8 @@ def test_take():
def
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306928408
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -658,6 +658,85 @@ int MXSymbolInferShapeEx(SymbolHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306927462
##
File path: src/c_api/c_api.cc
##
@@ -550,6 +566,34 @@ int MXNDArrayGetShapeEx(NDArrayHandle handle,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306642142
##
File path: src/c_api/c_api.cc
##
@@ -188,13 +188,29 @@ int MXNDArrayCreate(const mx_uint *shape,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306638983
##
File path: include/mxnet/c_predict_api.h
##
@@ -42,7 +42,9 @@ extern "C" {
#endif
/*! \brief
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306638346
##
File path: include/mxnet/c_api.h
##
@@ -1575,6 +1653,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306638313
##
File path: include/mxnet/c_api.h
##
@@ -1575,6 +1653,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306637960
##
File path: include/mxnet/c_api.h
##
@@ -596,6 +605,19 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306141292
##
File path: src/c_api/c_api.cc
##
@@ -205,17 +221,17 @@ int MXNDArrayCreateEx(const mx_uint *shape,
}
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139918
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139963
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306140023
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139778
##
File path: include/mxnet/c_api.h
##
@@ -1653,6 +1764,21 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306140056
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139685
##
File path: include/mxnet/c_api.h
##
@@ -1653,6 +1764,21 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139883
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306141324
##
File path: src/c_api/c_api.cc
##
@@ -188,13 +188,29 @@ int MXNDArrayCreate(const mx_uint *shape,
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306141665
##
File path: include/mxnet/c_api.h
##
@@ -565,6 +567,13 @@ MXNET_DLL int MXNDArrayCreateEx(const mx_uint
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139811
##
File path: include/mxnet/c_api.h
##
@@ -1653,6 +1764,21 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306142121
##
File path: src/c_api/c_api_symbolic.cc
##
@@ -658,6 +658,85 @@ int MXSymbolInferShapeEx(SymbolHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139867
##
File path: include/mxnet/c_api.h
##
@@ -1694,6 +1820,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138330
##
File path: include/mxnet/c_api.h
##
@@ -596,6 +605,19 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139670
##
File path: include/mxnet/c_api.h
##
@@ -1653,6 +1764,21 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139657
##
File path: include/mxnet/c_api.h
##
@@ -1653,6 +1764,21 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139499
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139534
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139514
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139473
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139322
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139407
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139374
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139438
##
File path: include/mxnet/c_api.h
##
@@ -1612,6 +1706,23 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139223
##
File path: include/mxnet/c_api.h
##
@@ -1575,6 +1653,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139203
##
File path: include/mxnet/c_api.h
##
@@ -1575,6 +1653,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139090
##
File path: include/mxnet/c_api.h
##
@@ -1575,6 +1653,22 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306139002
##
File path: include/mxnet/c_api.h
##
@@ -1504,6 +1577,11 @@ MXNET_DLL int MXSymbolGetOutput(SymbolHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138918
##
File path: include/mxnet/c_api.h
##
@@ -1447,6 +1511,11 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138901
##
File path: include/mxnet/c_api.h
##
@@ -1458,14 +1527,18 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138763
##
File path: include/mxnet/c_api.h
##
@@ -895,6 +940,10 @@ MXNET_DLL int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138626
##
File path: include/mxnet/c_api.h
##
@@ -802,6 +837,11 @@ MXNET_DLL int MXNDArrayReshape64(NDArrayHandle
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138503
##
File path: include/mxnet/c_api.h
##
@@ -596,6 +605,19 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306138330
##
File path: include/mxnet/c_api.h
##
@@ -596,6 +605,19 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int
apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r305538372
##
File path: include/mxnet/c_api.h
##
@@ -548,15 +549,14 @@ MXNET_DLL int MXNDArrayCreate(const mx_uint
80 matches
Mail list logo
