[GitHub] [incubator-pinot] kishoreg commented on issue #4941: Restructure pinot plugin-modules

kishoreg commented on issue #4941: Restructure pinot plugin-modules URL: https://github.com/apache/incubator-pinot/issues/4941#issuecomment-568154288 @Jackie-Jiang @mcvsubbu @mayankshriv and I discussed and came up with the following structure - pinot-plugins -

[GitHub] [incubator-pinot] jackjlli merged pull request #4934: Clean up BitmapInvertedIndexReader

jackjlli merged pull request #4934: Clean up BitmapInvertedIndexReader URL: https://github.com/apache/incubator-pinot/pull/4934 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pinot] branch master updated: Clean up BitmapInvertedIndexReader (#4934)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b4cd708 Clean up

[incubator-pinot] branch master updated: Adding basic null predicate support (#4943)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 09db4d9 Adding basic null predicate

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4943: Adding basic null predicate support

Jackie-Jiang merged pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4942: Refactor SegmentFetcher to handle retry for all URIs

Jackie-Jiang merged pull request #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch master updated (0826de5 -> 8619391)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0826de5 Implement GcsPinotFS (#4911) add 8619391 Refactor SegmentFetcher to handle retry for all

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs

codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-568131589 > Can you add some more details in your design doc? Specifically: I will add these details to the

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360612396 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360612329 ## File path:

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360612358 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360612301 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/IsNullPredicateAstNode.java

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360610944 ## File path:

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360610807 ## File path:

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360610172 ## File path:

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360609559 ## File path:

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360609441 ## File path:

[GitHub] [incubator-pinot] chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-568125831 > Left some comments. My main concern is that in a lot of places we resort to WARN instead of aborting

[GitHub] [incubator-pinot] chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion

chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-568125409 > Looking at the POC so far, I think we might need to start a doc to discuss what's the best approach

[GitHub] [incubator-pinot] jenniferdai commented on issue #4737: Druid-Pinot Segment Converter Tool

jenniferdai commented on issue #4737: Druid-Pinot Segment Converter Tool URL: https://github.com/apache/incubator-pinot/pull/4737#issuecomment-568124960 Can you rebase on master? I will continue reviewing in the meantime This

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs

codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360602472 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360602726 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360600932 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4942: Refactor SegmentFetcher to handle retry for all URIs

Jackie-Jiang commented on a change in pull request #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942#discussion_r360600702 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs

codecov-io edited a comment on issue #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4942: Refactor SegmentFetcher to handle retry for all URIs

mcvsubbu commented on a change in pull request #4942: Refactor SegmentFetcher to handle retry for all URIs URL: https://github.com/apache/incubator-pinot/pull/4942#discussion_r360596149 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4943: Adding basic null predicate support

kishoreg commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360597013 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360596600 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4943: Adding basic null predicate support

kishoreg commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360596039 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360594862 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360594167 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] jamesyfshao commented on issue #4941: Pinot module re-structure

jamesyfshao commented on issue #4941: Pinot module re-structure URL: https://github.com/apache/incubator-pinot/issues/4941#issuecomment-568105551 one small recommendation is that we might want to rename the two pinot-hadoop model because they might be confusing. Maybe pinot-hdfs (for

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360590839 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4943: Adding basic null predicate support

codecov-io edited a comment on issue #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#issuecomment-567776681 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4943: Adding basic null predicate support

kishoreg commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360588163 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4943: Adding basic null predicate support

kishoreg commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360587208 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4943: Adding basic null predicate support

codecov-io edited a comment on issue #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#issuecomment-567776681 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4943?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #4943: Adding basic null predicate support

jamesyfshao commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360582910 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360580010 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360574352 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4737: Druid-Pinot Segment Converter Tool

codecov-io edited a comment on issue #4737: Druid-Pinot Segment Converter Tool URL: https://github.com/apache/incubator-pinot/pull/4737#issuecomment-554538606 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4737?src=pr=h1) Report > :exclamation: No coverage uploaded for

[GitHub] [incubator-pinot] codecov-io commented on issue #4944: Add documentation for the pinot-gcs-filesystem

codecov-io commented on issue #4944: Add documentation for the pinot-gcs-filesystem URL: https://github.com/apache/incubator-pinot/pull/4944#issuecomment-568078825 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4944?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360560846 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360552202 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360548796 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360551112 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support

Jackie-Jiang commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360552026 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -111,6

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4942: Refactor SegmentFetcher into FileFetcher to handle more generic file and embed retry logic

codecov-io edited a comment on issue #4942: Refactor SegmentFetcher into FileFetcher to handle more generic file and embed retry logic URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 #

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4942: Refactor SegmentFetcher into FileFetcher to handle more generic file and embed retry logic

codecov-io edited a comment on issue #4942: Refactor SegmentFetcher into FileFetcher to handle more generic file and embed retry logic URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 #

[GitHub] [incubator-pinot] elonazoulay opened a new pull request #4944: Add documentation for the pinot-gcs-filesystem

elonazoulay opened a new pull request #4944: Add documentation for the pinot-gcs-filesystem URL: https://github.com/apache/incubator-pinot/pull/4944 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4943: Adding basic null predicate support

icefury71 commented on a change in pull request #4943: Adding basic null predicate support URL: https://github.com/apache/incubator-pinot/pull/4943#discussion_r360535885 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/IsNullPredicateAstNode.java

[GitHub] [incubator-pinot] chenboat commented on issue #3420: Deep Storage Support for Realtime

chenboat commented on issue #3420: Deep Storage Support for Realtime URL: https://github.com/apache/incubator-pinot/issues/3420#issuecomment-568031620 @jenniferdai can you close this issue since it is done by now? This is an

[GitHub] [incubator-pinot] kishoreg commented on issue #4941: Pinot module re-structure

kishoreg commented on issue #4941: Pinot module re-structure URL: https://github.com/apache/incubator-pinot/issues/4941#issuecomment-568024274 @elonazoulay Decoders and record readers are typically associated with format of the input data (avro, parquet, thrift etc). RecordReader work on

[GitHub] [incubator-pinot] elonazoulay commented on issue #4941: Pinot module re-structure

elonazoulay commented on issue #4941: Pinot module re-structure URL: https://github.com/apache/incubator-pinot/issues/4941#issuecomment-568020009 Had a question about the pinot-input-format, why not keep the name pinot-record-readers since that is what those modules do?

[GitHub] [incubator-pinot] elonazoulay commented on issue #4941: Pinot module re-structure

elonazoulay commented on issue #4941: Pinot module re-structure URL: https://github.com/apache/incubator-pinot/issues/4941#issuecomment-568019569 Add pinot-gcs under pinot-file-system. What do you think about renaming pinot-connector-kafka-base to

[incubator-pinot] branch master updated: Implement GcsPinotFS (#4911)

This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0826de5 Implement GcsPinotFS

[GitHub] [incubator-pinot] kishoreg merged pull request #4911: Implement GcsPinotFS

kishoreg merged pull request #4911: Implement GcsPinotFS URL: https://github.com/apache/incubator-pinot/pull/4911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360458689 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360459465 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360464006 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion

mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360461138 ## File path: