On 02/04/2019 13:54, Baesken, Matthias wrote:
Hi Alan, here is a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/
re-formatted the comment in java_md.cto avoid VERY LONG lines
adjusted test/jdk/tools/launcher/Arrrghs.java
Best regards, Matthias
Using
Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Alan, here is a new webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.3/webrev/
>
> re-formatted the comm
ateman
> Sent: Samstag, 30. März 2019 10:04
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
On 29/03/2019 12:36, Baesken, Matthias wrote:
Thanks. Alan, are you fine with the current webrev, if yes may I add you as
reviewer ?
The update to java_md.c looks okay, I probably would re-format the
comment to void the line longs but it is otherwise okay.
I think the new test needs a of
t; Alan Bateman
>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Matthias,
>
> this looks good to me now. Let's wait for another rev
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hello here is another webrev , I adjusted
> test/jdk/tools/launcher/Arrrghs.java a bit taking your
59
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Matthias
Matthias
> Sent: Mittwoch, 27. März 2019 18:05
> To: Langer, Christoph
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifes
y JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hello here is an updated webrev :
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.1/webrev/
>
>
>
> >
, 25. März 2019 10:48
> To: Langer, Christoph
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Ch
nntag, 24. März 2019 07:14
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
&g
FR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 22/03/2019 14:37, Baesken, Matthias wrote:
> > Hello, here is the new webrev .
> >
> > I
On 22/03/2019 14:37, Baesken, Matthias wrote:
Hello, here is the new webrev .
I took over and adjusted coding from os::open + create_unc_path
functions in os_windows.cpp in hotspot :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/
This looks quite good. For
sily reuse the HS coding, so the have
> to
> take it over to jli .
>
> Best regards, Matthias
>
>
>
> > -Original Message-
> > From: Baesken, Matthias
> > Sent: Mittwoch, 6. Februar 2019 09:56
> > To: Langer, Christoph
> > Cc: Chris Hega
ristoph
> Cc: Chris Hegarty ; core-libs-
> d...@openjdk.java.net; Alan Bateman (alan.bate...@oracle.com)
>
> Subject: RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Christoph+Alan, I opened
>
>
> https://bugs.op
019 10:08
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net; Alan Bateman
>
> Subject: RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Matthias,
>
> thanks for opening the bug. I refined its description a lit
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
>
> On 29/01/2019 08:58, Langer, Christoph wrote:
> > Hi Matthias,
> >
> >>> New webrev :
> >>>
> >>>
> >>> http://cr.openjd
On 29/01/2019 08:58, Langer, Christoph wrote:
Hi Matthias,
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.4/
This is the one. Looks good ( and clean ).
I agree, this version would be ok for me to be pushed. It would be good
,though, if there was a test for this (long
; From: Langer, Christoph
> Sent: Dienstag, 29. Januar 2019 09:59
> To: Baesken, Matthias
> Cc: Chris Hegarty ; core-libs-
> d...@openjdk.java.net
> Subject: RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Matthias,
>
> >
Hi Matthias,
> > New webrev :
> >
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.4/
>
> This is the one. Looks good ( and clean ).
I agree, this version would be ok for me to be pushed. It would be good
,though, if there was a test for this (long paths on Windows).
I also like
On 28/01/2019 16:09, Baesken, Matthias wrote:
you should think of a JLI_open function and then you can
put its implementation into the Windows version of java_md.c.
Hi Christoph, I like this idea .
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.4/
This is the one.
core-libs-dev@openjdk.java.net
> Subject: RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hi Matthias,
>
> thanks for the update.
>
> I still think you should avoid introducing a file parse_manifest_md.c. As per
> my previous mail,
gt; To: Alan Bateman ; core-libs-
> d...@openjdk.java.net
> Cc: Langer, Christoph
> Subject: RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> Hello Alan / Christoph,
> new webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/821709
rds, Matthias
> -Original Message-
> From: Alan Bateman
> Sent: Sonntag, 27. Januar 2019 16:57
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Cc: Langer, Christoph
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windo
On 24/01/2019 16:19, Baesken, Matthias wrote:
Did you consider adding a Unix version of open_jarfile to avoid #ifdef
WIN32 ?
Hi Alan, do you mean , adding a separate c-file for UNIX containing the
function open_jarfile ?
I considered this, but did not like the idea to add a separate file for
his, second webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.2/
>
>
> Best Regards, Matthias
>
>
> > -Original Message-
> > From: Alan Bateman
> > Sent: Donnerstag, 24. Januar 2019 13:04
> > To: Baesken, Matthias ; core-libs-
&g
4
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 23/01/2019 08:29, Baesken, Matthias wrote:
> > Hello Alan, here is a second webrev :
> >
> > htt
On 23/01/2019 08:29, Baesken, Matthias wrote:
Hello Alan, here is a second webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.1/
I moved the Windows-only code into a new file
src/java.base/windows/native/libjli/parse_manifest_md.c
Did you consider adding a Unix version of
Mittwoch, 16. Januar 2019 16:43
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 14:43, Baesken, Matthias wrote:
> > Hi Alan , do you
On 16/01/2019 14:43, Baesken, Matthias wrote:
Hi Alan , do you think it is good to start a UNIX parse_manifest_md.c too
with just a one-liner in it ?
Or do you prefer only having the windows - file with the Windows coding and
keeping the UNIX one-linerfor open_jarfile in
> -Original Message-
> From: Alan Bateman
> Sent: Mittwoch, 16. Januar 2019 10:37
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 09:07, Baes
On 16/01/2019 09:07, Baesken, Matthias wrote:
Hi Alan, I thought having UNIX+Windows code in this case together at one
place would be okay .
However, if you prefer separating it, should I put it here ?
src/java.base/windows/native/libjli/java_md.c
Or do you have a better suggestion ?
man
> Sent: Mittwoch, 16. Januar 2019 09:51
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 08:42, Baesken, Matthias wrote:
> > Hello, please
On 16/01/2019 08:42, Baesken, Matthias wrote:
Hello, please review this small adjustment to parse_manifest.c .
It adds support for extended - length paths (on Window) .
(see
https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation
For
34 matches
Mail list logo
