Hi Michael,
>
>>>
>>> I’m not real familiar with the build process. But would it be possible for
>>> the user to build their own jdk that substitutes something else for the
>>> colliding identifier that gets embedded?
>> Yes, it should be possible and in theory such JDK with native commands
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Joe Wang has updated the pull request incrementally with one additional commit
since the last
On Mon, 16 May 2022 21:54:52 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provider description
>
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 48:
>
>> 46: */
>> 47: public
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
Generic repositories, the implementation detail for generic information in core
reflection, can be updated to use the `@Stable` annotation to replace their
`volatile` access. Their existing accessor code is already safe, reading the
cache fields only once.
In addition, fixed potentially
> On May 16, 2022, at 7:09 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
>>
I’m not real familiar with the build process. But would it be possible for
the user to build their own jdk that substitutes something else for the
colliding identifier that gets embedded?
On Tue, 26 Apr 2022 21:17:34 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Thanks
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/8584
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind of issue.
Ichiroh Takiguchi has updated the pull request
On Mon, 16 May 2022 21:29:22 GMT, Brian Burkhalter wrote:
> Add constant `java.math.BigDecimal.TWO`.
Looks fine.
-
Marked as reviewed by darcy (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8735
On Thu, 12 May 2022 11:02:02 GMT, Magnus Ihse Bursie wrote:
>> Thanks for all to review this PR! I think we should separate this issue as
>> following:
>>
>> * Suppress warnings
>> * make/modules/java.desktop/lib/Awt2dLibraries.gmk
>> * src/hotspot/share/classfile/bytecodeAssembler.cpp
On Thu, 12 May 2022 18:28:02 GMT, Kim Barrett wrote:
>> Thanks for all to review this PR! I think we should separate this issue as
>> following:
>>
>> * Suppress warnings
>> * make/modules/java.desktop/lib/Awt2dLibraries.gmk
>> * src/hotspot/share/classfile/bytecodeAssembler.cpp
>>
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
You forced me to look at this in depth. The values are set via the build
system. In the build system it is impossible to get just -J because the -J is
only added as a prefix for an existing string. So
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Thu, 12 May 2022 18:09:40 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>>
Hi Michael,
I filed following enhancement for signing user provided app image and yes it
will be two step process. Invoke jpackage to generate image, then user can
modified it and then invoke jpackage again to sign it.
https://bugs.openjdk.java.net/browse/JDK-8286850
For JDK-8286122, I will
On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader.
On Mon, 16 May 2022 17:53:17 GMT, Alan Bateman wrote:
> thanks for the updates.
Updated the CSR to match this version.
-
PR: https://git.openjdk.java.net/jdk/pull/8717
On Fri, 13 May 2022 14:17:44 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the failure
> handler command `dmesg` on macOS?
>
> As noted in the JBS issue, the command currently fails with permission error.
> The commit in this PR uses `sudo` as
On Mon, 16 May 2022 22:06:25 GMT, Leonid Mesnik wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Looks reasonable.
Thank you @lmesnik for the review.
-
PR:
On Mon, 16 May 2022 13:20:49 GMT, David Holmes wrote:
>> GCC 12 reports as following:
>
> I don't recall what "builtin arguments" means. Can you tell me how we would
> actually hit this conditions such that we string dup and the null string? Or
> are you saying this is actually an unreachable
On Mon, 16 May 2022 07:21:27 GMT, Ningsheng Jian wrote:
> This is the REDO of JDK-8269559 and JDK-8275448. Those two backouts finally
> turned to be some system zlib issue in AArch64 macOS, and is not related to
> the patch itself. See [1][2] for details.
>
> This patch is generally the same
> Add constant `java.math.BigDecimal.TWO`.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last
On Tue, 17 May 2022 03:05:09 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/opto/memnode.cpp line 1413:
>
On Tue, 10 May 2022 09:57:48 GMT, Jan Lahoda wrote:
>> 8262889: Compiler implementation for Record Patterns
>>
>> A first version of a patch that introduces record patterns into javac as a
>> preview feature. For the specification, please see:
>>
On Thu, 12 May 2022 15:56:51 GMT, Severin Gehwolf wrote:
>> xpbob has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> rename method
>
> LGTM.
Thanks @jerboaa and @iklam . :)
-
PR: https://git.openjdk.java.net/jdk/pull/8285
This is the REDO of JDK-8269559 and JDK-8275448. Those two backouts finally
turned to be some system zlib issue in AArch64 macOS, and is not related to the
patch itself. See [1][2] for details.
This patch is generally the same as JDK-8275448, which uses SVE to optimize
string_compare
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
Simply considering the compiler warning shouldn't `(arg+2) == NULL` actually be
`arg[2] = '\0'` ? as we are looking to see if this arg is only three
characters: '-', 'J' and '\0'
-
PR:
On Mon, 11 Apr 2022 16:37:03 GMT, Jan Lahoda wrote:
> This is a (preliminary) patch for javac implementation for the third preview
> of pattern matching for switch (type patterns in switches).
>
> Draft JLS:
>
On Wed, 27 Apr 2022 09:13:34 GMT, Jie Fu wrote:
>> Hi all,
>>
>> According to the Vector API doc, the `LSHR` operator computes
>> `a>>>(n&(ESIZE*8-1))`.
>> However, current implementation is incorrect for negative bytes/shorts.
>>
>> The background is that one of our customers try to
> 8262889: Compiler implementation for Record Patterns
>
> A first version of a patch that introduces record patterns into javac as a
> preview feature. For the specification, please see:
>
On Mon, 16 May 2022 06:58:22 GMT, David Holmes wrote:
> Simply considering the compiler warning shouldn't `(arg+2) == NULL` actually
> be `arg[2] == '\0'` ? as we are looking to see if this arg is only three
> characters: '-', 'J' and '\0'
Yeah, I thought that first, but I think better of
On Mon, 16 May 2022 07:54:09 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Thank you Daniel and Lance for the reviews.
>
> Would anyone from the build team like to provide
On Sun, 17 Apr 2022 14:35:14 GMT, Jie Fu wrote:
> Hi all,
>
> According to the Vector API doc, the `LSHR` operator computes
> `a>>>(n&(ESIZE*8-1))`.
> However, current implementation is incorrect for negative bytes/shorts.
>
> The background is that one of our customers try to vectorize
On Wed, 27 Apr 2022 09:13:34 GMT, Jie Fu wrote:
>> Hi all,
>>
>> According to the Vector API doc, the `LSHR` operator computes
>> `a>>>(n&(ESIZE*8-1))`.
>> However, current implementation is incorrect for negative bytes/shorts.
>>
>> The background is that one of our customers try to
On Fri, 13 May 2022 10:04:36 GMT, Jorn Vernee wrote:
> Address possible lossy conversion warning in `ProgrammableInvoker`.
>
> Testing: `run-test-jdk_foreign`, testing with patch from
> https://github.com/openjdk/jdk/pull/8599 to see if the warning is gone.
This pull request has now been
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
src/java.base/share/native/libjli/java.c line 1632:
> 1630: if (JLI_IsTraceLauncher()) {
> 1631: printf("Empty option: jargv[%d]\n", i);
> 1632: }
I'd
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
I don't recall what "builtin arguments" means. Can you tell me how we would
actually hit this conditions such that we string dup and the null string? Or
are you saying this is actually an unreachable
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
Please review these simple changes in jdk.internal.math.[Double|Float]Consts
-
Commit messages:
- 8286810: Use public [Double|Float].PRECISION fields in
jdk.internal.math.[Double|Float]Consts
Changes: https://git.openjdk.java.net/jdk/pull/8729/files
Webrev:
On Mon, 16 May 2022 16:35:16 GMT, Shruthi wrote:
> `/integrate`
There may be sth. with your input, it's not recognized as Git command. Try
again, or copy this command instead.
-
PR: https://git.openjdk.java.net/jdk/pull/8318
On Thu, 12 May 2022 18:02:26 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request,
On Mon, 16 May 2022 18:23:23 GMT, Naoto Sato wrote:
> Do not enclose the skara command within backquotes.
Thanks Naoto! I didn't realize that's what he did :-)
-
PR: https://git.openjdk.java.net/jdk/pull/8318
> Make the javadoc in the InputStream and OutputStream subclasses in core libs
> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
> client libs will be done another a separate bug.) When the time comes, will
> do any necessary merging for the changes in[JDK-8286200.
>
> Make the javadoc in the InputStream and OutputStream subclasses in core libs
> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
> client libs will be done another a separate bug.) When the time comes, will
> do any necessary merging for the changes in[JDK-8286200.
>
On Fri, 13 May 2022 18:29:56 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
>
On Thu, 12 May 2022 19:00:05 GMT, Roger Riggs wrote:
> In the throws clauses, I think I would have put the additional conditional at
> the end of the sentence since the existing throws text corresponds to the
> exception. But the logic is correct as is.
I put it at the beginning as that is
On Wed, 11 May 2022 20:47:52 GMT, Brian Burkhalter wrote:
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
This pull request has now been integrated.
Changeset: dbd37370
Author:
On Mon, 9 May 2022 18:59:43 GMT, Naoto Sato wrote:
> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
> Corresponding CSR is also being drafted.
This pull request has now been integrated.
On Mon, 16 May 2022 15:43:45 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8286810: Use public [Double|Float].PRECISION fields in
>> jdk.internal.math.[Double|Float]Consts
>
>
On Mon, 16 May 2022 14:48:43 GMT, Raffaello Giulietti
wrote:
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
Adjusted
-
PR: https://git.openjdk.java.net/jdk/pull/8729
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8286810: Use public [Double|Float].PRECISION fields in
jdk.internal.math.[Double|Float]Consts
On Mon, 16 May 2022 15:51:43 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
On Mon, 16 May 2022 15:54:25 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
On Mon, 16 May 2022 15:54:25 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Mon, 16 May 2022 14:52:04 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
On Fri, 13 May 2022 13:36:52 GMT, ExE Boss wrote:
> So if anything, the List.of(…) call should be moved into the ProxyMethod
> constructor. And maybe the call to Method.getExceptionTypes() should be
> changed to Method.getSharedExceptionTypes()
Makes sense. Do you want me to do this within
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
This pull request has now been integrated.
Changeset: c044cb83
Author:Naoto Sato
URL:
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Mon, 16 May 2022 15:54:25 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8286810: Use public [Double|Float].PRECISION fields in
jdk.internal.math.[Double|Float]Consts
On Mon, 16 May 2022 14:48:43 GMT, Raffaello Giulietti
wrote:
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
src/java.base/share/classes/jdk/internal/math/DoubleConsts.java line 28:
> 26: package jdk.internal.math;
> 27:
> 28: import static java.lang.Double.*;
On Fri, 13 May 2022 21:17:22 GMT, Joe Darcy wrote:
> Update reference to the latest "Effective Java" version and switch to cite
> tags.
This pull request has now been integrated.
Changeset: 4bc7b7df
Author:Joe Darcy
URL:
On Thu, 12 May 2022 18:02:26 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request,
On Fri, 13 May 2022 18:51:47 GMT, Joe Wang wrote:
>> Shruthi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since
> This patch makes MemorySegment::ofBuffer more general, by allowing clients to
> pass *any* `Buffer` instance, not just `ByteBuffer`.
> This allows us to match expressiveness of JNI API, where JNI clients can
> obtain the address of any direct buffer instance, using the
>
On Fri, 13 May 2022 15:48:29 GMT, Maurizio Cimadamore
wrote:
> This simple patch regularizes some of the foreign API benchmarks. Some of the
> changes are:
>
> * use of capital names for var handle and layout constants
> * move shared layout and var handle constants in a new superclass,
>
On Mon, 16 May 2022 17:29:16 GMT, Joe Darcy wrote:
>> Make the javadoc in the InputStream and OutputStream subclasses in core libs
>> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
>> client libs will be done another a separate bug.) When the time comes, will
>> do
On Fri, 13 May 2022 12:33:10 GMT, Maurizio Cimadamore
wrote:
> This patch makes MemorySegment::ofBuffer more general, by allowing clients to
> pass *any* `Buffer` instance, not just `ByteBuffer`.
> This allows us to match expressiveness of JNI API, where JNI clients can
> obtain the address
On Mon, 16 May 2022 16:26:41 GMT, Shruthi wrote:
> `integrate`
I think you missed slash, it's slash integrate.
-
PR: https://git.openjdk.java.net/jdk/pull/8318
On Thu, 12 May 2022 18:02:26 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request,
On Fri, 13 May 2022 15:48:29 GMT, Maurizio Cimadamore
wrote:
> This simple patch regularizes some of the foreign API benchmarks. Some of the
> changes are:
>
> * use of capital names for var handle and layout constants
> * move shared layout and var handle constants in a new superclass,
>
On Sun, 15 May 2022 21:16:53 GMT, Pavel Rappo wrote:
> 1. One the one hand, it's not clear to me what criterion was used for adding
> `@Override` annotations. On the other hand, the more `@Override` annotations
> a codebase has, the better.
>
> 2. Have you compared the resulting
On Mon, 16 May 2022 16:56:00 GMT, Joe Darcy wrote:
> I added the `@Override` annotations to methods I reviewed and/or updated; it
> was not necessarily an exhaustive process.
Yeah, there are inconsistencies as a result and I think we should go the extra
mile and add to the methods such as
> Make the javadoc in the InputStream and OutputStream subclasses in core libs
> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
> client libs will be done another a separate bug.) When the time comes, will
> do any necessary merging for the changes in[JDK-8286200.
>
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
> adds freeing of downcall stubs, since those changes were
On Thu, 12 May 2022 18:15:54 GMT, liach wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> test/micro/org/openjdk/bench/java/lang/foreign/LinkUpcall.java line
On Mon, 16 May 2022 17:16:31 GMT, Ichiroh Takiguchi
wrote:
> The 1st word changed from Return to Returns.
Is it OK ?
That's more of plain English to me. Maybe some natives can correct it if needed.
> And it seems @return is translated to Japanese on Japanese environment.
Yes. I believe
On Fri, 13 May 2022 10:02:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Thu, 12 May 2022 00:26:41 GMT, Yasumasa Suenaga wrote:
>> I don't understand what the actual warning is getting at .. can anyone
>> explain it ?
>>
>> FWIW the code is still the same in upstream harfbuzz
>> https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-font.cc
>
> I've pasted a part
Update to Xerces 2.12.2.
The update also fixes JDK-8144117. Added a test.
Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this
update. See related issue report.
-
Commit messages:
- 8282280: Update Xerces to Version 2.12.2
Changes:
On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader.
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 running. Two JCK tests failed with this
> update. See related issue report.
Hi Joe,
I think your changes are ok
Are
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Thanks Lance.
Yes, I've notified the JCK
Add constant `java.math.BigDecimal.TWO`.
-
Commit messages:
- 8213045: Add commonly used symbolic math constants to the JDK
Changes: https://git.openjdk.java.net/jdk/pull/8735/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8735=00
Issue:
On Mon, 16 May 2022 19:34:11 GMT, Joe Wang wrote:
> Update to Xerces 2.12.2.
>
> The update also fixes JDK-8144117. Added a test.
>
> Tests: local XML tests passed. Tier2 passed. Two JCK tests failed with this
> update. See related issue report.
Changes look good to me. Some minor nits
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as
92 matches
Mail list logo
