ot;SUCCESS", "remarks":
"{\"termGuid\":\"30728c5b-99f6-4f69-a54a-2b0d4d49acef\",\"qualifiedName\":\"term_5@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"b075398a-f845-42ca-90b0-e1362c5757c4\",\"qualifiedName\":\"term_6@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"0c75f006-9d29-49db-96bb-b9c7738eb155\",\"qualifiedName\":\"term_7@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_8",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"e3cee557-1017-44ed-bfd1-fa42bf9f2b51\",\"qualifiedName\":\"term_8@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_9",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"63635428-a966-4843-b8c8-97576fa349da\",\"qualifiedName\":\"term_9@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_10",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"44cbaf67-9d66-42ad-b339-c97804b5980d\",\"qualifiedName\":\"term_10@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_11",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"df8216f9-bbdb-4264-91f2-b3ed50870a15\",\"qualifiedName\":\"term_11@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_12",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"9275a2e1-ff61-4276-bee2-882c133404bd\",\"qualifiedName\":\"term_12@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_13",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"c76091e9-db22-40e4-8c7b-8fc52e08706f\",\"qualifiedName\":\"term_13@dharshmk_11\"}
"
}
]
}
Thanks,
Sidharth Mishra
as expected.
org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
as expected.
org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
as expected.
org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
.
org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
dc39fd29e
Diff: https://reviews.apache.org/r/73330/diff/1/
Testing
---
Manually tested Re-importing glossary after deleting existing glossary and it
works.
Thanks,
Sidharth Mishra
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks":
"{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks":
"{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks":
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks":
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
> On April 28, 2021, 1:02 p.m., Dharshana MK wrote:
> > Thanks Sidharth Mishra
> > We can obtain the qualified name from the input but getting the guid is
> > tricky
> > Can we also pass the guid of the term created in the response "remarks"?
> >
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks":
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}
Thanks,
Sidharth Mishra
eviews.apache.org/r/73304/#review222891
---
On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To re
ot;importStatus": "SUCCESS",
"remarks": "Payable@Banking4"
},
{
"parentObjectName": "Auto4",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks": "Steering@Auto4"
},
{
"parentObjectName": "Auto4",
"childObjectName": "Paint",
"importStatus": "SUCCESS",
"remarks": "Paint@Auto4"
}
]
}
Thanks,
Sidharth Mishra
the previous response data.
> > Also displayText is not updated withing the relationship
> >
> > One more suggestion, it will be good to display only the non null values
>
> Sidharth Mishra wrote:
> Changed the response to include
uot;,\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
ot;: "Steering",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
},
{
"parentObjectName": "Auto2",
"childObjectName": "Transmission",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
}
]
}
Thanks,
Sidharth Mishra
ot;,
"childObjectName": "Steering",
"importStatus": "SUCCESS",
"remarks":
"{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Aut
urce='null', status=null}],
TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
urce='null', status=null}],
TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
urce='null', status=null}],
TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
ERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}],
TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
/EntityDiscoveryService.java
Line 58 (original), 58 (patched)
<https://reviews.apache.org/r/73271/#comment312003>
Please avoid using import *. Revert the changes
- Sidharth Mishra
On April 14, 2021, 4:10 a.m., Pinal Shah
.
- Sidharth Mishra
On April 14, 2021, 4:10 a.m., Pinal Shah wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 706 (patched)
<https://reviews.apache.org/r/73271/#comment311998>
nit: Please add one space after searchResult.getSearchResults(). Similarly
please do other places.
- Sidharth Mishra
On April 8, 2
the glossary with circular reference
Thanks,
Sidharth Mishra
this
- Sidharth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222766
---
On April 2, 2021, 6:49 p.m., Sidharth Mishra wrote:
>
> ---
&g
/resources/excelFiles/invalid_xls.xls PRE-CREATION
Diff: https://reviews.apache.org/r/73218/diff/3/
Changes: https://reviews.apache.org/r/73218/diff/2-3/
Testing
---
Manually tested importing the glossary with circular reference
Thanks,
Sidharth Mishra
,
Sidharth Mishra
Diff: https://reviews.apache.org/r/73257/diff/4/
Changes: https://reviews.apache.org/r/73257/diff/3-4/
Testing
---
Manually tested if the patch application is successful and entity creation is
working.
Thanks,
Sidharth Mishra
eviews.apache.org/r/73261/#review222753
---
On March 30, 2021, 11:37 p.m., Sidharth Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To re
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/73257/#review222741
---
On March 31, 2021, 12:09 a.m., Sidharth Mishra wrote:
>
> ---
> This is an automati
Diff: https://reviews.apache.org/r/73257/diff/3/
Changes: https://reviews.apache.org/r/73257/diff/2-3/
Testing
---
Manually tested if the patch application is successful and entity creation is
working.
Thanks,
Sidharth Mishra
/AtlasPathExtractorUtil.java
81f847e75
common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java
dbc500043
Diff: https://reviews.apache.org/r/73261/diff/1/
Testing
---
UT updated and manually tested if the GCP entities are created appropriately.
Thanks,
Sidharth Mishra
common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java
dbc500043
Diff: https://reviews.apache.org/r/73261/diff/1/
Testing
---
UT updated and manually tested if the GCP entities are created appropriately.
Thanks,
Sidharth Mishra
Diff: https://reviews.apache.org/r/73257/diff/2/
Changes: https://reviews.apache.org/r/73257/diff/1-2/
Testing
---
Manually tested if the patch application is successful and entity creation is
working.
Thanks,
Sidharth Mishra
/1/
Testing
---
Manually tested if the patch application is successful and entity creation is
working.
Thanks,
Sidharth Mishra
/FileUtils.java 57df9abeb
Diff: https://reviews.apache.org/r/73218/diff/1/
Testing
---
Manually tested importing the glossary with circular reference
Thanks,
Sidharth Mishra
details (except the hive_db)
Thanks,
Sidharth Mishra
"numFilesErasureCoded": "0",
"transactional": "true"
},
"retention": 0
},
"guid": "-73293807317085526",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"sd": {
"guid": "-73293807317085527",
"typeName": "hive_storagedesc",
"uniqueAttributes": {
"qualifiedName": "default.test_1@cm_storage"
},
"relationshipType": "hive_table_storagedesc"
},
"columns": [
{
"guid": "-73293807317085528",
"typeName": "hive_column",
"uniqueAttributes": {
"qualifiedName": "default.test_1.id@cm"
},
"relationshipType": "hive_table_columns"
}
],
"partitionKeys": [],
"db": {
"guid": "-73293807317085525",
"typeName": "hive_db",
"uniqueAttributes": {
"qualifiedName": "default@cm"
},
"relationshipType": "hive_table_db"
}
},
"proxy": false
},
"-73293807317085525": {
"typeName": "hive_db",
"attributes": {
"owner": "public",
"ownerType": "ROLE",
"managedLocation":
"hdfs://secure-2.secure.root.hwx.site:8020/warehouse/tablespace/managed/hive",
"qualifiedName": "default@cm",
"clusterName": "cm",
"name": "default",
"description": "Default Hive database",
"location":
"hdfs://secure-2.secure.root.hwx.site:8020/warehouse/tablespace/external/hive",
"parameters": {}
},
"guid": "-73293807317085525",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"proxy": false
}
},
"entities": [
{
"typeName": "hive_process",
"attributes": {
"recentQueries": [
"create materialized view test_mv_ctas_1 as select
* from test_1"
],
"qualifiedName":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000",
"clusterName": "cm",
"name":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000",
"queryText": "",
"operationType": "CREATE_MATERIALIZED_VIEW",
"startTime": 1612317051380,
"queryPlan": "Not Supported",
"endTime": 1612317051380,
"userName": "",
"queryId": ""
},
"guid": "-73293807317085532",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"outputs": [
{
"guid": "-73293807317085529",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_1@cm"
},
"relationshipType": "process_dataset_outputs"
}
],
"inputs": [
{
"guid": "-73293807317085526",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_1@cm"
},
"relationshipType": "dataset_process_inputs"
}
]
},
"proxy": false
},
{
"typeName": "hive_process_execution",
"attributes": {
"hostName": "secure-2.secure.root.hwx.site",
"qualifiedName":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000:1612317032474:1612317051380",
"name":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000:1612317032474:1612317051380",
"queryText": "create materialized view test_mv_ctas_1
as select * from test_1",
"startTime": 1612317032474,
"queryPlan": "Not Supported",
"endTime": 1612317051380,
"userName": "admin",
"queryId":
"hive_20210203015032_7bef0f08-bddf-4992-b761-97aa261be104"
},
"guid": "-73293807317085533",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"process": {
"guid": "-73293807317085532",
"typeName": "hive_process",
"relationshipType":
"hive_process_process_executions"
}
},
"proxy": false
}
]
}
}
}
Thanks,
Sidharth Mishra
t;,
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"sd": {
"guid": "-73293807317085527",
"typeName": "hive_storagedesc",
"uniqueAttributes": {
"qualifiedName": "default.test_1@cm_storage"
},
"relationshipType": "hive_table_storagedesc"
},
"columns": [
{
"guid": "-73293807317085528",
"typeName": "hive_column",
"uniqueAttributes": {
"qualifiedName": "default.test_1.id@cm"
},
"relationshipType": "hive_table_columns"
}
],
"partitionKeys": [],
"db": {
"guid": "-73293807317085525",
"typeName": "hive_db",
"uniqueAttributes": {
"qualifiedName": "default@cm"
},
"relationshipType": "hive_table_db"
}
},
"proxy": false
},
"-73293807317085525": {
"typeName": "hive_db",
"attributes": {
"owner": "public",
"ownerType": "ROLE",
"managedLocation":
"hdfs://sarath-secure-2.sarath-secure.root.hwx.site:8020/warehouse/tablespace/managed/hive",
"qualifiedName": "default@cm",
"clusterName": "cm",
"name": "default",
"description": "Default Hive database",
"location":
"hdfs://sarath-secure-2.sarath-secure.root.hwx.site:8020/warehouse/tablespace/external/hive",
"parameters": {}
},
"guid": "-73293807317085525",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"proxy": false
}
},
"entities": [
{
"typeName": "hive_process",
"attributes": {
"recentQueries": [
"create materialized view test_mv_ctas_1 as select
* from test_1"
],
"qualifiedName":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000",
"clusterName": "cm",
"name":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000",
"queryText": "",
"operationType": "CREATE_MATERIALIZED_VIEW",
"startTime": 1612317051380,
"queryPlan": "Not Supported",
"endTime": 1612317051380,
"userName": "",
"queryId": ""
},
"guid": "-73293807317085532",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"outputs": [
{
"guid": "-73293807317085529",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_1@cm"
},
"relationshipType": "process_dataset_outputs"
}
],
"inputs": [
{
"guid": "-73293807317085526",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_1@cm"
},
"relationshipType": "dataset_process_inputs"
}
]
},
"proxy": false
},
{
"typeName": "hive_process_execution",
"attributes": {
"hostName":
"sarath-secure-2.sarath-secure.root.hwx.site",
"qualifiedName":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000:1612317032474:1612317051380",
"name":
"CREATE_MATERIALIZED_VIEW:default.test_1@cm:161231452->:default@cm:default.test_mv_ctas_1@cm:1612317049000:1612317032474:1612317051380",
"queryText": "create materialized view test_mv_ctas_1
as select * from test_1",
"startTime": 1612317032474,
"queryPlan": "Not Supported",
"endTime": 1612317051380,
"userName": "admin",
"queryId":
"hive_20210203015032_7bef0f08-bddf-4992-b761-97aa261be104"
},
"guid": "-73293807317085533",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"process": {
"guid": "-73293807317085532",
"typeName": "hive_process",
"relationshipType":
"hive_process_process_executions"
}
},
"proxy": false
}
]
}
}
}
Thanks,
Sidharth Mishra
and precommit will be run
Thanks,
Sidharth Mishra
Diff: https://reviews.apache.org/r/73140/diff/1/
Testing
---
Already tested manually and precommit will be run
Thanks,
Sidharth Mishra
Diff: https://reviews.apache.org/r/73093/diff/1/
Testing
---
Thanks,
Sidharth Mishra
/patches/005-azure_adls_add_attributes.json
PRE-CREATION
Diff: https://reviews.apache.org/r/73091/diff/1/
Testing
---
Applied the patch to my cluster successfully
Thanks,
Sidharth Mishra
=AtlasGlossaryTerm"} is been thrown and Status Code:
403 Forbidden
- Sidharth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/#review222345
-------
,
Sidharth Mishra
f needed)
client/client-v2/src/main/python/atlas_client/discovery_model.py
Lines 145 (patched)
<https://reviews.apache.org/r/72730/#comment310607>
Please remove if not needed
- Sidharth Mishra
On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/#review221369
---
Ship it!
Ship It!
- Sidharth Mishra
On July 23, 2020, 6:10
in/java/org/apache/atlas/AtlasClientBaseExample.java
Lines 140 (patched)
<https://reviews.apache.org/r/72698/#comment310199>
Please use Console.readPassword instead
- Sidharth Mishra
On July 21, 2020, 4:24 p.m., Jyoti Singh wrote:
>
> --
* use below:
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.fail;
import static org.testng.Assert.assertNull;
import static org.testng.Assert.assertEquals;
- Sidharth Mishra
On July 10, 2020, 12:05 a.m., Jyoti
e any v2 API at AtlasBaseClient. Could you please move this to
AtlasClientV2.
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 489 (patched)
<https://reviews.apache.org/r/72638/#comment310040>
Please move this as well to v2 as this is the base client.
- Sidhart
dMap queryParams = new MultivaluedMapImpl();
queryParams.add("name", name);
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Lines 650 (patched)
<https://reviews.apache.org/r/72638/#comme
+1 for Apache Atlas 2.1 rc3
Validated the following:
- Verified the MD5/sha512 hash
- Verified PGP signature
- No binaries in extracted source
- Verified the build with embedded-hbase and solr
- Ran quick start and tested some sanity test cases - Basic/advanced
search, Classification, Glossary,
ot;:[],\"removePropagationsOnEntityDelete\":false},{\"typeName\":\"PARENT\",\"entityGuid\":\"73cc5730-494b-4313-8747-9ccf8a1b0227\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"validityPeriods\":[],\"removePropagationsOnEntityDelete\":false}],\"meanings\":[],\"proxy\":false}","eventKey":"def375bd-9bad-42f3-9fa7-9edc1c7d8d96:1594191071761:3:1594191103634","entity":null
,"type":null}]
//Deny
curl --location --request GET
'http://sid-ycloud-atlas1-2.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/def375bd-9bad-42f3-9fa7-9edc1c7d8d96/audit?count=1=ENTITY_PURGE'
\
-u sid:sid
Response:
{"errorCode":"ATLAS-403-00-001","errorMessage":"sid is not authorized to
perform read entity audit: guid=def375bd-9bad-42f3-9fa7-9edc1c7d8d96"}
Thanks,
Sidharth Mishra
ot;,\"entityGuid\":\"73cc5730-494b-4313-8747-9ccf8a1b0227\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"validityPeriods\":[],\"removePropagationsOnEntityDelete\":false}],\"meanings\":[],\"proxy\":false}","eventKey":"def375bd-9bad-42f3-9fa7-9edc1c7d8d96:1594191071761:3:1594191103634","entity":null
,"type":null}]
//Deny
curl --location --request GET
'http://sid-ycloud-atlas1-2.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/def375bd-9bad-42f3-9fa7-9edc1c7d8d96/audit?count=1=ENTITY_PURGE'
\
-u sid:sid
Response:
{"errorCode":"ATLAS-403-00-001","errorMessage":"sid is not authorized to
perform read entity audit: guid=def375bd-9bad-42f3-9fa7-9edc1c7d8d96"}
Thanks,
Sidharth Mishra
+1 for Apache Atlas 2.1 RC1
Validated the following items.
1. Verified the md5/sha512 checksum of source bundle
2. Packaging with -Pdist,embedded-hbase-solr works fine
3. Starting Atlas server works fine
4. quick_start.py works fine and all the entities and tags get created
;operationType": "CLASSIFICATION_ADD",
"eventTime": 1590181673717
}
}
{
"version": {
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NO
;operationType": "CLASSIFICATION_ADD",
"eventTime": 1590181673717
}
}
{
"version": {
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NO
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NONE",
"msgSplitIdx": 1,
"msgSplitCount": 1,
"msgSourceIP": "172.27.168.128",
"msgCreatedBy": "",
"msgCreationTime": 1590181680714,
"message": {
"type": "ENTITY_NOTIFICATION_V2",
"entity": {
"typeName": "hive_table",
"attributes": {
"owner": "anonymous",
"createTime": 1590120919000,
"qualifiedName": "sid_hive_db.sid_hive_table_ctas3@bulk",
"name": "sid_hive_table_ctas3"
},
"guid": "ab302745-a843-4164-8166-017f85c7e15e",
"status": "ACTIVE",
"displayText": "sid_hive_table_ctas3",
"classificationNames": [
"ETL",
"PII",
"Fact"
],
"classifications": [
{
"typeName": "ETL",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
},
{
"typeName": "PII",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
},
{
"typeName": "Fact",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
}
]
},
"operationType": "CLASSIFICATION_ADD",
"eventTime": 1590181673717
}
}
Thanks,
Sidharth Mishra
ropagatedEntities
when we call fullTextMapperV2.getAndCacheEntity(guid) we still get the old one
without classification. So along with this change I added code to
constructHeader so that it will set classification to entity from entityHeader.
Now the updated solution works.
- S
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NONE",
"msgSplitIdx": 1,
"msgSplitCount": 1,
"msgSourceIP": "172.27.168.128",
"msgCreatedBy": "",
"msgCreationTime": 1590181680714,
"message": {
"type": "ENTITY_NOTIFICATION_V2",
"entity": {
"typeName": "hive_table",
"attributes": {
"owner": "anonymous",
"createTime": 1590120919000,
"qualifiedName": "sid_hive_db.sid_hive_table_ctas3@bulk",
"name": "sid_hive_table_ctas3"
},
"guid": "ab302745-a843-4164-8166-017f85c7e15e",
"status": "ACTIVE",
"displayText": "sid_hive_table_ctas3",
"classificationNames": [
"ETL",
"PII",
"Fact"
],
"classifications": [
{
"typeName": "ETL",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
},
{
"typeName": "PII",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
},
{
"typeName": "Fact",
"entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
}
]
},
"operationType": "CLASSIFICATION_ADD",
"eventTime": 1590181673717
}
}
Thanks,
Sidharth Mishra
)
-
addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json 676a2237c
Diff: https://reviews.apache.org/r/72515/diff/2/
Changes: https://reviews.apache.org/r/72515/diff/1-2/
Testing
---
Manually added to my cluster
Thanks,
Sidharth Mishra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72512/#review220776
---
Ship it!
Ship It!
- Sidharth Mishra
On May 14, 2020, 10:41
-aws_s3_v2_typedefs.json 676a2237c
Diff: https://reviews.apache.org/r/72515/diff/1/
Testing
---
Manually added to my cluster
Thanks,
Sidharth Mishra
iews.apache.org/r/72512/#comment309463>
Just to avoid two returns statement as we do other places in atlas, we can
do something like:
Initialize variable AtlasEdge ret = null;
At 192 line: ret = GraphDbObjectFactory.createEdge(this, ret);
At the end return ret;
- Sidhart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72464/#review220605
---
Ship it!
Ship It!
- Sidharth Mishra
On May 3, 2020, 11:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72452/#review220604
---
Ship it!
Ship It!
- Sidharth Mishra
On April 30, 2020, 4:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72452/#review220557
---
Ship it!
Ship It!
- Sidharth Mishra
On April 29, 2020, 9:17
;
ret = getActiveEdgeFromList(toVertex.getId(),
edgesIterator);
}
}
RequestContext.get().endMetricRecord(metric);
return ret;
- Sidharth Mishra
On April 29, 2020, 5:51 p.
f times, I was not able to run
EntityV2JerseyResourceIT. precommit run will ensure if this passes.
Thanks,
Sidharth Mishra
'["bd7262f6-fed5-40f3-9f72-f57fba6b1193",
"24c4df6e-b27a-4c60-b85a-67ed20210446", "24c4df6e-b27a-4c60-b85a-67ed20210446"]'
Note: As local jetty was failing for couple of times, I was not able to run
EntityV2JerseyResourceIT. precommit run will ensure if this passes.
Thanks,
Sidharth Mishra
will ensure if this passes.
Thanks,
Sidharth Mishra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72367/#review220328
---
Ship it!
Ship It!
- Sidharth Mishra
On April 15, 2020, 5:22
hanges. toEntityAuditActionV2() should return proper
state which can be used to get more details from entity audit - HBase)
- Sidharth Mishra
On April 7, 2020, 6:22 a.m., Mandar Ambawane wrote:
>
> ---
> This is an automatically generated e
-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE'
Thanks,
Sidharth Mishra
777b6b",
"entityStatus": "PURGED",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
},
{
"typeName": "TEST_TAG_1",
"entityGuid": "a2d1cad9-d2a1-4fe4-8570-2e58e16877ca",
"entityStatus": "ACTIVE",
"propagate": true,
"validityPeriods": [],
"removePropagationsOnEntityDelete": false
}
]
Thanks,
Sidharth Mishra
:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE'
Thanks,
Sidharth Mishra
be always to a const value.
- Sidharth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/#review220287
---
On April
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
--header 'Content-Type: application/json'
Thanks,
Sidharth Mishra
'Content-Type: application/json'
Thanks,
Sidharth Mishra
: Basic YWRtaW46YWRtaW4xMjM='
Thanks,
Sidharth Mishra
tartTime",
"operator": "gte",
"attributeValue": "1575958152162"
},
{
"attributeName": "endTime",
"operator": "gte",
"att
attributeValue": "1575958152162"
},
{
"attributeName": "endTime",
"operator": "gte",
"attributeValue": "1575958152184"
},
{
"attributeName": "resultCount",
"operator": "eq",
"attributeValue": "4"
}
]
},
"limit": 15,
"offset": 0,
"sortBy": "resultCount",
"sortOrder": "DESCENDING"
}'
Thanks,
Sidharth Mishra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/#review220236
---
Ship it!
Ship It!
- Sidharth Mishra
On April 7, 2020, 6:20
w
'{"excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"includeClassificationAttributes":true,"limit":25,"offset":0,"typeName":null,"classification":"BEFORE_DEMO","termName":null}'
Thanks,
Sidharth Mishra
e need to stop by
adding the check. To keep the hard delete and purge code same we are still
using the requestContext deletedEntities instead of having separate one for
purge.
- Sidharth
---
This is an automatically generated e-mail. To
/glossary/GlossaryService.java
d630f669e
repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java
bee88c61f
Diff: https://reviews.apache.org/r/72265/diff/1/
Testing
---
Manually tested
Thanks,
Sidharth Mishra
'
\
--header 'Authorization: Basic YWRtaW46YWRtaW4='
Thanks,
Sidharth Mishra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72268/#review220081
---
Ship it!
Ship It!
- Sidharth Mishra
On March 25, 2020, 7:35
/AbstractGlossaryDTO.java
bee88c61f
Diff: https://reviews.apache.org/r/72265/diff/1/
Testing
---
Manually tested
Thanks,
Sidharth Mishra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review220048
---
Ship it!
Ship It!
- Sidharth Mishra
On March 20, 2020, 2:06
> On March 18, 2020, 11:55 p.m., Sidharth Mishra wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
> > Lines 570 (patched)
> > <https://reviews.apache.org/r/71482/diff/18/?file=2213646#file2213646line570>
> >
> >
nst for 0 explaining what does the position contains
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
Lines 960 (patched)
<https://reviews.apache.org/r/71482/#comment308228>
Please remove the extra space:
assertEquals(e.getMessage(), "No Data found in the u
blank lines like this even other places.
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 558 (patched)
<https://reviews.apache.org/r/71482/#comment308150>
Remove the extra blank line
- Sidharth Mishra
On March 12, 2020, 10:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/#review219788
---
- Sidharth Mishra
On March 4, 2020, 10:07 a.m., mayank jain
d)
<https://reviews.apache.org/r/71482/#comment308010>
Please take care of indentation at most of the places in your patchl. Like
space before and after '+' etc.
- Sidharth Mishra
On March 4, 2020, 10:07 a.m., mayank jain wrote:
>
>
ews/glossary/ImportGlossaryLayoutView.js
Lines 53 (patched)
<https://reviews.apache.org/r/71482/#comment307987>
This comment is not adding any useful information as the initialize block
is self explanatory.
- Sidharth Mishra
On March 4, 2020, 10:07 a.m.,
://reviews.apache.org/r/71791/diff/18/
Changes: https://reviews.apache.org/r/71791/diff/17-18/
Testing
---
Two UT and one IT has been added to test functionality like:
1. Atlas Audit entry save and retrive
2. Atlas Purge Audit store, retrive and search (UT and IT)
Thanks,
Sidharth Mishra
101 - 200 of 252 matches
Mail list logo
