GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/586
Conveniences for yaml
A few conveniences to make it easier to write my yaml blueprints! See
individual commits for details.
If anything in here looks controversial to you
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/565
@neykov you beat me to replying - agreed :-)
@ahgittin to give some more background, the original use-case for
"immediate" stemmed from a failure in clocker:
https://
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/581
Jenkins failed with an unrelated test:
`HttpCommandEffectorYamlRebindTest.testRebindWhenHealthy:64->runRebindWhenIsUp:81`.
I'll do a `git commit --amend; git push -f` to kick-off jenk
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/565#discussion_r104391702
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
@@ -139,17 +132,19 @@ public T call
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/581
EntityConfigTest: add tests for ImmediateSupplier
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
tests
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/571
@ahgittin bump: see previous comment - how can we tell it's a badRequest
that caused the exception?
To force a rebuild by jenkins, you can do `git commit --amend; git push -f
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/565
@ahgittin can you rebase this against master please, now that #480 is merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/480
Excellent, thanks @ahgittin - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
LGTM as well; merging now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/516#discussion_r103745402
--- Diff: karaf/pom.xml ---
@@ -34,21 +34,29 @@
+6.0.0
5.0.0
-
+
1.0.0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/516#discussion_r103744978
--- Diff: karaf/pom.xml ---
@@ -34,21 +34,29 @@
+6.0.0
5.0.0
-
+
1.0.0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/516#discussion_r103744542
--- Diff: core/pom.xml ---
@@ -60,6 +60,7 @@
com.hierynomus
sshj
+${sshj.version
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/516
@googlielmo (cc @m4rkmckenna) given Marks' comment about seeing value in
this, then I'm fine with us merging it and then iterating on it to add more
assertions (as we find time to do
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/485
@ahgittin (cc @neykov @geomacy) I've kicked off the REST api discussion
again on the dev@brooklyn mailing list ("subject "Re: Uploading ZIPs for a
better dev workflow")
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/480
@ahgittin agreed - we should not cancel the task, so "leaking" it is right
behaviour.
The build failure is real, until we commit to switching to Java 8 - please
give yo
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/155
On balance, I agree with @ahgittin that we should revert this, and first
merge https://github.com/apache/brooklyn-server/pull/480
The changes in this PR were suggested
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Wow, I wasn't expecting to see this set of commits of file-edits based on
the name of the PR and the description!
It would be great to review + merge your improvements for non
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/574
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/571#discussion_r103570592
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java
---
@@ -374,7 +378,13 @@ public Response
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/485
@ahgittin (cc @neykov @geomacy) see
https://github.com/apache/brooklyn-server/pull/576, for the part of this PR
that adds the `BundleMaker` (without the REST api changes). What do you
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/576
BundleMaker (part1)
This is extracted from https://github.com/apache/brooklyn-server/pull/485 -
it excludes the changes to the REST api; it improves test coverage and fixes a
couple
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/485
@ahgittin agree there is 100% support on the direction.
There was push-back on what exactly the REST API piece should look like:
* @geomacy suggested that we should only support
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/558
Docs PR now merged - https://github.com/apache/brooklyn-docs/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/151
BROOKLYN-433: docs for yaml config key constraints
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs BROOKLYN-433
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103454836
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -352,33 +357,73 @@ public T get
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103446823
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java
---
@@ -96,7 +98,50 @@ public ExecutionManager
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103439058
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -554,15 +562,55
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103455566
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -512,6 +559,24 @@ public Object call() throws Exception
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103448474
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java
---
@@ -96,7 +98,50 @@ public ExecutionManager
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103452425
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -352,33 +357,73 @@ public T get
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103455943
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -512,6 +559,24 @@ public Object call() throws Exception
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r103447467
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java
---
@@ -96,7 +98,50 @@ public ExecutionManager
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/148
@neykov's comment addressed; @drigodwin deferred for a future PR. Merging
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/148#discussion_r103166453
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
`$brooklyn:root()`.
* `$brooklyn:formatString
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/148#discussion_r103165332
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
`$brooklyn:root()`.
* `$brooklyn:formatString
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101853047
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/InterruptingImmediateSupplier.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101790138
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101864959
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101855532
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/InterruptingImmediateSupplier.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101836841
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101851346
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
---
@@ -753,7 +753,10 @@ protected void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101847631
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
@@ -146,7 +146,6 @@ public T call
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101836610
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
@@ -91,6 +96,62 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101868849
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/exceptions/Exceptions.java
---
@@ -263,8 +264,41 @@ public static Throwable
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101868262
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101849614
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntityConfigTest.java ---
@@ -244,59 +252,152 @@ public void
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101782727
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java ---
@@ -64,4 +65,6 @@
boolean isShutdown
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101789828
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -539,8 +550,9 @@ protected
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101862310
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -352,33 +357,51 @@ public T get
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
@neykov I like your idea of something like:
`$brooklyn:urlBuilder("http://host/path.to.jar;).userInfo(external("artifactory.credentials")).build()`.
Or perhap
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/558
@tbouron It's validated server-side. Longer term, we should improve the
validation errors + warnings that the server-side sends back, along with the
info needed for content-assist. That's
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/558
BROOKLYN-433: regex/obj config key constraint in yaml
Docs PR will follow, to update the constraints section in
https://github.com/apache/brooklyn-docs/blob/master/guide/yaml/yaml
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/556
Speed up tests
Starting an embedded OSGi container is slow - over half a second per
`setUp()` call (and thus per test method) that uses it. It will likely be
considerably slower
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/480
@ahgittin This is way too hard to review until #462 is merged (which
requires rebasing and a bunch of PR comments to be addressed; as I asked there,
will you have time to address those
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100509692
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -28,51 +32,188 @@
import
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100509157
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -28,51 +32,188 @@
import
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100507371
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java
---
@@ -170,12 +324,103 @@ public String
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100370235
--- Diff:
api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
@@ -147,27 +147,28 @@ public SpecT tagsReplace
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100523726
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/BrooklynObjectInternal.java ---
@@ -152,8 +152,8 @@
/** This is currently
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100361187
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -99,48 +99,81 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
@neykov agreed - I stayed well clear of `URLEncoder` originally for that
reason, and tried to use guava's
https://google.github.io/guava/releases/18.0/api/docs/com/google/common/net
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/148
Adds doc for urlEncode DSL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs doc-for-urlEncode
Alternatively you
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/554
FYI I tried this:
```
tee file1 <<-EOF
line1
line2
EOF
MYVAR=`cat file1`
echo $MYVAR
# shows "line1 line2" - note the special cha
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/552
Adds DynamicCluster.testClustersHaveIndependentCounters
@drigodwin mentioned that DynamicCluster's memberIds seemed to keep
incrementing up when a second cluster was provisioned (i.e
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/546#discussion_r99815295
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/stock/SequenceEntity.java ---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/546#discussion_r99814504
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/SequenceGroupTest.java ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/546#discussion_r99813663
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/SequenceGroupTest.java ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/551
BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(...)
As stated in the comments within the code, the url encoding is based on
"x-www-form-urlencoded". Therefore care mus
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/544#discussion_r99424592
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java
---
@@ -128,15 +128,18 @@ public double
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/82
@googlielmo @neykov thanks; I've changed this PR so it only modifies the
comment explaining why we're including BouncyCastle (I think it's very useful
to know that it causes the refresh
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/334
I've created https://issues.apache.org/jira/browse/INFRA-13436 to ask for
the mirroring to be triggered.
---
If your project is set up for it, you can reply to this email and have your
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/334
This was merged 94 minutes ago (see
https://git-wip-us.apache.org/repos/asf?p=brooklyn-server.git), but is not
sync'ing to github to show here that it's merged.
---
If your project
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/80
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/334
Thanks @neykov @googlielmo - merging this and the accompanying
https://github.com/apache/brooklyn-dist/pull/48
---
If your project is set up for it, you can reply to this email and have
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/48
This has been tested (in combination with
https://github.com/apache/brooklyn-server/pull/334) by @googlielmo. I've also
tested it in combination with
https://github.com/apache/brooklyn
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/547
I've changed this to upgrade to cxf 3.1.10 (released yesterday!), and to
point at winrm4j 0.5.0 which should be released soon, I hope!
---
If your project is set up for it, you can reply
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/547
I just tested this with cxf 3.1.10 (released today - thanks for pointing me
at that @neykov). It seems to work well:
* Successfully deployed a windows VM in aws, with it executing
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-dist/pull/82
Avoid sshd.core bundle rewiring on startup
This builds on Svet's https://github.com/apache/brooklyn-dist/pull/48 (so
should be rebased once that is merged first).
It avoids
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/547
[WIP] CXF upgrade
This upgrade CXF to 3.1.9.
It also bumps httpcomponents to 4.4.4 (thus replacing
https://github.com/apache/brooklyn-server/pull/362)
It cherry-picks
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/90
Delete EntityFactory
Please first review + merge
https://github.com/apache/brooklyn-server/pull/545 (which gives some more
background for this change).
You can merge this pull request
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/545
Delete EntityFactory
One should instead always use `EntitySpec`, e.g. with `DynamicCluster`
memberSpec config.
This PR also:
* refactors tests so that they use memberSpec
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/544
See `JcloudsImageChoiceStubbedLiveTest` and
`JcloudsAwsImageChoiceStubbedLiveTest`. I suspect those will need fixed, and
perhaps we could extend their coverage (or would that be brittle
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/544#discussion_r98661586
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java
---
@@ -135,10 +135,14 @@ public double
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/89
Remove uses of EntityLocal
Please first review and merge
https://github.com/apache/brooklyn-server/pull/543 (which also gives the
justification for these changes!)
You can merge
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/543
Remove uses of EntityLocal
Deletes usage of the deprecated `EntityLocal` (folk should just use
`Entity` wherever possible, as it's a lot simpler to explain/understand
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/531#discussion_r98362353
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/CompositeEffector.java ---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/531
And rebind tests would be very good (e.g. see
https://github.com/apache/brooklyn-server/blob/master/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/531
It would be good to also have some yaml-based tests (e.g. see
https://github.com/apache/brooklyn-server/blob/master/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/531#discussion_r98362160
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorIntegrationTest.java
---
@@ -0,0 +1,125
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/531#discussion_r98362129
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorIntegrationTest.java
---
@@ -0,0 +1,125
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/540
LGTM; merging now.
Jenkins build failure is unrelated (so we should fix that separately) -
failure is `ServiceFailureDetectorYamlRebindTest.testRebindWhenHealthy`:
```
2017
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/539
Thanks @neykov - LGTM; merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/541
Fix ReachableSocketFinderTest (so not time-sensitive)
Tests sometimes failed on apache Jenkins, because 100ms wasnât long
enough for the other thread(s) to complete.
e.g
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/537
Thanks @alasdairhodge - LGTM
FYI the code in master was changed in
https://github.com/apache/brooklyn-server/commit/c2669da89c79ff62cfb0082b040274494e59170f#diff
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/536
LGTM - this now matches the code in master. Merging into `0.9.x` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/539#discussion_r98187655
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
@@ -75,7 +89,11 @@ public void acquire(Entity caller
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/539#discussion_r98187488
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
@@ -56,8 +60,11 @@
}
private
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/539#discussion_r98187291
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/ReleaseableLatch.java ---
@@ -66,6 +73,13 @@ public MaxConcurrencyLatch(int permits
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/538
Thanks @neykov - LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/535
The test failure is unrelated, and should be investigated/fixed separately:
```
java.lang.AssertionError: entity=Application[802qtu86]; attribute=Sensor:
service.state
801 - 900 of 1967 matches
Mail list logo
