Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/535
Thanks @tbouron - LGTM. Once jenkins has finished running the tests, I'll
merge this.
I've created https://issues.apache.org/jira/browse/BROOKLYN-430 to track
this in brooklyn
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/534
BROOKLYN-425: softwareProcess.rebind execs with entity context
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-client/pull/38
Thanks @Graeme-Miller - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-client/pull/38
Exclude cli/.glide/* (cache) from rat + git
Without this, the build fails for me: the many files created in
cli/.glide/cache fail the rat check.
You can merge this pull request into a Git
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/533
Thanks @neykov - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/533
I tested this manually in karaf, in three ways:
1. started brooklyn-latest karaf, deployed an app, stopped and restarted
(confirming that rebind worked)
2. started an older brooklyn
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/533
persistence: include bundle-prefix for whitelisted classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/528
BROOKLYN-426: avoid propagating NoClassDefFoundError
See https://issues.apache.org/jira/browse/BROOKLYN-426 for details.
Tested this with a badly behaving bundle, and confirmed
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/527
Adds test for catalog-effector from OSGi bundle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
test-rebind
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/139
BROOKLYN-359: fix softlayer swift example for jclouds2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs BROOKLYN
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/525
Thanks @tbouron - unused imports removed, rebased against master, and
waiting for jenkins to re-run the tests. Then will merge.
---
If your project is set up for it, you can reply
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/525
openstack-swift support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
openstack-swift-support
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/522
Thinking about this more, given that brooklyncentral/advanced-networking is
not part of Apache Brooklyn, maybe these renames should not be included in core
brooklyn. It could
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/522
Class renames for advanced-networking vcloud-director
See https://github.com/brooklyncentral/advanced-networking/pull/116
You can merge this pull request into a Git repository by running
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/518
LGTM. Longer term, it would be nice to generalise this (e.g. should we
apply it for all clouds, or would that break some if they use "zone" instead of
"regi
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/79
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-dist/pull/79
Add version marker to karaf/config/pom.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-dist add-version-marker
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/515
Fix+test rename-jclouds-provider
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
fix-jcloudsProvider-rename
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/510
LGTM - thanks @sjcorbett; merging.
It looks like we'll no longer log the `setup.getDescription()` when it's
non-null, but that's fine. It's pretty much always null in the logs I've
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/513
LGTM; merging - thanks @bostko
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/513
@bostko see https://github.com/bostko/brooklyn-server/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/513#discussion_r95593265
--- Diff:
utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
@@ -75,6 +76,20
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/513#discussion_r95590807
--- Diff:
utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
@@ -75,6 +76,20
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/513
@bostko I'm reviewing this now, and will submit an additional commit on top
of this PR shortly. I think a lot of things can be improved by instead calling
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/491
I started looking into why `testSshExecScript()` was failing. First quick
comment: you need to enable the feature:
```
@BeforeMethod(alwaysRun=true)
public void setUp
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/75
@m4rkmckenna @neykov as per the comment
https://github.com/apache/brooklyn-server/pull/504#issuecomment-271535835, I'd
appreciate your comments as to whether this looks right to you now
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/504
I take it we're happy to leave the itests (e.g.
https://github.com/apache/brooklyn-dist/blob/master/karaf/itest/src/test/java/org/apache/brooklyn/core/catalog/internal
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/504#discussion_r95331819
--- Diff: karaf/config/pom.xml ---
@@ -0,0 +1,74 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/75#discussion_r95331050
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -55,7 +55,12 @@
mvn:javax.annotation/javax.annotation-api
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/75#discussion_r95330574
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -55,7 +55,12 @@
mvn:javax.annotation/javax.annotation-api
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/504#discussion_r95330255
--- Diff:
karaf/config/src/main/resources/org.apache.brooklyn.core.catalog.bomscanner.cfg
---
@@ -0,0 +1,27
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/508
Thanks @drigodwin - LGTM; merging.
Not sure why jenkins is still showing "validating", 20 hours later. The
link is to https://builds.apache.org/job/brooklyn-server-pul
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
@drigodwin looks good. In what way is this still "work in progress"?
Looking at how features are defined in
https://github.com/jclouds/jclouds-karaf/blob/master/featur
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r95156115
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java
---
@@ -0,0 +1,43
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94984349
--- Diff:
karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/ClasspathOsgiConfigLoader.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94982693
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java
---
@@ -0,0 +1,43
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983917
--- Diff:
karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/ClasspathOsgiConfigLoader.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983722
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/PropertiesConfigLoader.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94982414
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingJcloudsRenamesProvider.java
---
@@ -0,0 +1,43
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983344
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/JcloudsProviderRenameConfigLoader.java
---
@@ -0,0 +1,30
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94984056
--- Diff:
karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/JcloudsProviderRenameOsgiConfigLoader.java
---
@@ -0,0 +1,57
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983575
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingProvider.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94981908
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
@@ -43,49 +37,30 @@
* See
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94984944
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsProviderAndApiLoaderTest.java
---
@@ -68,6 +69,35 @@ public
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983260
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/ClasspathConfigLoader.java
---
@@ -18,55 +18,17 @@
*/
package
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94982612
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
@@ -43,49 +37,30 @@
* See
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/508
@drigodwin can you kick off the jenkins build again please (e.g. by making
a change to the commit id by running `git commit --ammend; git push -f`).
The jenkins test failure looks
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/362
Trying to test this (including the cxf upgrade to 3.1.9), it is failing
when starting karaf with:
```
2017-01-06 15:29:40,191 ERROR 11 o.a.k.f.i.s.BootFeaturesInstaller
[pool-7
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/362#discussion_r94937432
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -51,8 +51,8 @@
mvn:commons-codec/commons-codec/${commons-codec.version
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/477
Thanks @neykov - incorporated those changes and rebased; merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/493
@grkvlt I agree with @neykov's concern about thread usage. Maybe we could
make it configurable, so the default is the existing behaviour (which would use
a guava
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/494
@grkvlt can you respond to @neykov's question "can you confirm signed vs
unsigned shift", and then good to merge.
---
If your project is set up for it, you can reply to
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/503
LGTM; merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/135
Thanks @ajs6f - LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/136
Thanks - changes incorporated. Merging now, and will cherry-pick into
0.10.0 branch (to push these changes to the live docs site).
---
If your project is set up for it, you can reply
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/136
Default is no credentials required
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs fix/no-creds-by-default
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/492
Thanks @tbouron Failing test `DslYamlTest.testDslAttributeWhenReady` looks
unrelated (we should look into that in a separate PR). You can kick off jenkins
again by running `git commit
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/72
This depends on https://github.com/apache/brooklyn-server/pull/492 being
merged first, I presume.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/474
Thanks @sjcorbett - rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/334
@neykov karaf 4.0.8 was released on 14th December:
http://search.maven.org/#artifactdetails%7Corg.apache.karaf%7Ckaraf%7C4.0.8%7Cpom
According to https://issues.apache.org/jira
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/492
LGTM - would be nice to delete the unused `Compat.getConfigurationAdmin()`,
which is being added in this PR.
---
If your project is set up for it, you can reply to this email and have
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/492#discussion_r93688090
--- Diff: karaf/init/src/main/resources/OSGI-INF/blueprint/blueprint.xml ---
@@ -47,10 +47,23 @@ limitations under the License
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/492#discussion_r93687950
--- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/Compat.java
---
@@ -39,15 +40,19 @@ public static Compat getInstance
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/497
LGTM. It's slightly concerning that `JcloudsUtil.getFirstReachableAddress`
might now block until the reachability check on the VM's private (unreachable)
address times out. But I presume
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/501
I've changed the null check, and squashed it into one commit. I've re-run
all the (Live) tests in `JcloudsGceHardwareProfilesStubbedLiveTest` - they
passed for me locally.
Once
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/501#discussion_r93615497
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1484,6 +1493,48 @@ public Template
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/500
@bostko see http://freemarker.org/docs/versions_2_3_25.html, in the section
"changes on the FTL side":
```
Extended the list directive to support listing hashes (suc
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/500#discussion_r93614889
--- Diff: pom.xml ---
@@ -137,7 +137,7 @@
3.1.M0
0.6
2012
-2.3.22
+2.3.25
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/502
BROOKLYN-421: add tests for catalog library loading
This PR only improves test coverage, and adds a failing test for
BROOKLYN-421 (marked as `groups="Broken"`). It does not atte
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/501
JCLOUDS-1108 workaround: GCE hardwareId short-form
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
jclouds
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/500
Upgrade free marker to 2.3.25 (from 2.3.22)
Freemarker 2.3.25 adds support for iterating over map entries, which will
be useful for some entity implementations.
@ygy could you
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/499
Thanks @sjcorbett, I can confirm they both pass for me. Merging now, and
will cherry-pick into the 0.10.0 branch.
---
If your project is set up for it, you can reply to this email
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/498#discussion_r93445832
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/lifecycle/ScriptHelperIntegrationTest.java
---
@@ -0,0 +1,176
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/499
BROOKLYN-417: default to no-auth
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-417
Alternatively
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/490
I've rebased (having merged #489). Once jenkins has run the tests, I'll
merge - unless there are any other comments from anyone.
---
If your project is set up for it, you can reply
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/489
Thanks @neykov - changes incorporated, and squashed into single commit.
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Thanks @sjcorbett - looks great. Unfortunately there are merge conflicts
again (probably due to https://github.com/apache/brooklyn-server/pull/496).
Once those are resolved
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/484#discussion_r93065657
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/templates/customize/CustomizeTemplateOptions2.java
---
@@ -0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/484#discussion_r93063249
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/Strings.java ---
@@ -827,6 +828,33 @@ public static String ies(Iterator x
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/484#discussion_r93061840
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/RebindToMachinePredicate.java
---
@@ -0,0 +1,85
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/496
Tests: adds more jclouds live tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
tests/jclouds-live
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Thanks @sjcorbett - great to separate out this huge class, and improve this
code!
I haven't had a proper chance to review yet. Does it change the names of
any classes that might
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/485
@ahgittin (cc @neykov) I've only had a quick look, but a few initial
comments:
1. Discuss on dev@brooklyn the idea of deploying blueprints via a
directory/zip (rather than a user
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/491#discussion_r92647257
--- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshFeed.java ---
@@ -270,6 +270,7 @@ private SshPollValue exec(String command,
Map<Str
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/491
@bostko there are merge conflicts.
Could you add a test to `SshMachineLocationIntegrationTest`, and maybe also
`SshMachineLocationTest`, for use of async? See existing tests
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/491#discussion_r92645673
--- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshFeed.java ---
@@ -270,6 +270,7 @@ private SshPollValue exec(String command,
Map<Str
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/492
Given the class is static, I wondered about Brooklyn's startup injecting
the karaf config via some static method call. But I prefer @neykov's suggestion
that we get the karaf config admin
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/487
@neykov @drigodwin for VMs being "orphaned", not managed by Brooklyn, I
think it's good enough for now. The only times I know of it happening are:
1. When Brooklyn was termina
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/492#discussion_r92641835
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/DeserializingClassRenamesProvider.java
---
@@ -72,7 +81,7
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/487
@drigodwin interesting. I'm not sure who we should optimise for though,
with the defaults.
The problem is if someone has misconfigured their location. For example,
we'll wait
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/490
Fix BROOKLYN-410: rebind locations from bundles
Builds on https://github.com/apache/brooklyn-server/pull/489 - please
review and merge that first; then I'll rebase (which will make
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/488#discussion_r92266653
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -486,8 +486,8 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/409
@andreaturli This was merged as part of
https://github.com/apache/brooklyn-server/pull/481, I believe. If that is
correct, then can you close this PR please? If not, can you rebase it so
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-dist/pull/70
LGTM - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/481
LGTM - merging. Thanks @googlielmo @andreaturli @m4rkmckenna
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/481
I ran the live tests listed below. Based on that, I'm happy for this to be
merged (we can deal with Windows @ GCE later, which might be fixed with
configuration
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/481
@googlielmo (cc @andreaturli) to fix `SshjToolIntegrationTest` (the
`testAsync.*` tests), you'll need this fix:
```
diff --git
a/core/src/main/java/org/apache/brooklyn/util
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/131
@bostko A couple of minor rewords. Other than that, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/131#discussion_r91709250
--- Diff: guide/ops/troubleshooting/increase-entropy.md ---
@@ -4,24 +4,52 @@ title: Increase Entropy
toc: /guide/toc.json
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/131#discussion_r91709128
--- Diff: guide/ops/troubleshooting/increase-entropy.md ---
@@ -4,24 +4,52 @@ title: Increase Entropy
toc: /guide/toc.json
901 - 1000 of 1967 matches
Mail list logo
