Dan Hecht has posted comments on this change.
Change subject: IMPALA-3611: track unused Disk IO buffer memory
..
Patch Set 9:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/3246/9/be/src/runtime/disk-io-mgr.cc
File
Hi Tim,
Thank you for the insight on the issues.
1. BE test -issue: benchmark-test hangs
As you suggested, I increased the "batch_size" value to upto 12500,
however, the sw.ElapsedTime() does not increase inside the while and again
gets caught up in an infinite loop. The optimization
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3664
To unsubscribe, visit
With my Cloudera hat on, I noticed that I can't share docs with the
whole world from my cloudera.com Google account. It's possible others
are in the same boat and will need to make special Google accounts
just to comment on docs even when contributing under the umbrella of
their employer. However,
By developer documentation I meant anything that is currently under the
"For Developers" section in the wiki (
https://github.com/cloudera/Impala/wiki).
Dimitris
On Wed, Jul 20, 2016 at 4:40 PM, Jim Apple wrote:
> I think it is reasonable for contributors to use Google
Michael Ho has posted comments on this change.
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
..
Patch Set 5: Code-Review+2
Mostafa Mokhtar has posted comments on this change.
Change subject: Enable TPC-H workload for Kudu tables
..
Patch Set 5:
(1 comment)
Mostafa Mokhtar has posted comments on this change.
Change subject: Enable TPC-H workload for Kudu tables
..
Patch Set 5:
(3 comments)
Why add tpch-kudu-q*.test?
The queries should be identical to the already existing TPC-H
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3220
To unsubscribe,
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
IMPALA-3674: Lazy materialization of LLVM module bitcode.
Previously, each fragment
Michael Ho has posted comments on this change.
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG
Commit Message:
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3630
to look at the new patch set (#5).
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 6:
(4 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3664
To unsubscribe, visit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3664
to look at the new patch set (#5).
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 6:
(2 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-3336: qgen: do not randomly generate query options
(workaround)
..
Patch Set 1:
I tested that disabling this a while back allows the query generator to
Michael Brown has posted comments on this change.
Change subject: IMPALA-3892: qgen: always run Impala with
-convert_legacy_hive_parquet_utc_timestamps=true
..
Patch Set 1:
I've been using this patch locally for months.
--
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3713
Change subject: IMPALA-3892: qgen: always run Impala with
-convert_legacy_hive_parquet_utc_timestamps=true
..
IMPALA-3892: qgen: always
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3712
Change subject: IMPALA-3336: qgen: do not randomly generate query options
(workaround)
..
IMPALA-3336: qgen: do not randomly generate
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Patch Set 4:
(1 comment)
I think it is reasonable for contributors to use Google Docs for
coordinating short-lived, heavily commented documents.
However, I don't think Dimitris was referring to those sort of things.
On Wed, Jul 20, 2016 at 4:18 PM, Marcel Kornacker wrote:
> I meant this really for
Kathy Sun has posted comments on this change.
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.cc
Henry Robinson has posted comments on this change.
Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
..
Patch Set 2:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
..
Patch Set 2:
(2 comments)
Google docs only work in my opinion if the following are true:
1. People who want to read and comment on them can do so without requesting
permission
2. Ownership is not tied to one person, so that if someone stops
contributing to Impala, the rest of the contributors can still make changes
to the
I meant this really for documents where we expect a good amount of
discussion. Design docs and proposals are certainly in that category.
Is there anything in that category that you would like to exclude?
On Wed, Jul 20, 2016 at 3:35 PM, Jim Apple wrote:
> I think that's
Matthew Jacobs has posted comments on this change.
Change subject: Adjust ASF push script names to match our repo setup.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3702/1/bin/push_to_asf.py
File
Hello David Knupp, Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3385
to look at the new patch set (#9).
Change subject: IMPALA-1683: Allow REFRESH on a single partition
Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-1683: Allow REFRESH on a single partition
..
Patch Set 8:
(1 comment)
Carrying forward David's +1
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
..
Patch Set 2:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
..
Patch Set 3:
Ok, so I tried to refactor the exit/cleanup logic to be a bit more sane. The
Hello David Ribeiro Alves,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3637
to look at the new patch set (#3).
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
Oh, and, FWIW, I think Google docs are reasonable for design
proposals, because I expect those to be somewhat short-lived: once the
proposal is accepted, the design may very well stray from it based on
unforeseen implementation constraints, and we probably don't expect
contributors who do the
Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3875: Set thrift socket timeout before any connection
..
Patch Set 1:
I think we should add timeout for server transport here,
I think that's overkill. There are few documents that don't need
comments (I really tried to come up with one. Something written in
Linear A?)
I also don't think Google docs are really ideal for a shared,
long-lived document managed by a diverse community.
1. The revision history tooling is
How about we scope that to everything that needs revisions/comments?
On Wed, Jul 20, 2016 at 3:23 PM, Henry Robinson wrote:
> Seems reasonable, but I propose we scope that only to design documents
> (which require revisions and comments).
>
> FWIW, Kudu includes
Seems reasonable, but I propose we scope that only to design documents
(which require revisions and comments).
FWIW, Kudu includes building-from-source instructions on their website
(which I think is nicely done):
http://kudu.apache.org/docs/installation.html#_build_from_source
I'm happy with
Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3875: Set thrift socket timeout before any connection
..
Patch Set 1:
this is client side.. will look at server side as well
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12:
GVM preemptively aborted due to hitting IMPALA-3470
--
To view, visit
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12:
Build failed:
Huaisi Xu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3707
Change subject: IMPALA-3875: Set thrift socket timeout before any connection
..
IMPALA-3875: Set thrift socket timeout before any connection
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3716: Add Memory Tab in query's Details page
..
Patch Set 4:
(2 comments)
anujphadke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3703
Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into
text tables
..
IMPALA-2700: ASCII NUL characters are doubled
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3702
Change subject: Adjust ASF push script names to match our repo setup.
..
Adjust ASF push script names to match our repo setup.
Our gerrit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
..
Patch Set 2:
(1 comment)
I spent a while coming up with something that is OK for factoring
Henry Robinson has posted comments on this change.
Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
..
Patch Set 2:
(5 comments)
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12:
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3764: fuzz test HDFS scanners
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3448/6/tests/query_test/test_scanners_fuzz.py
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3764: fuzz test HDFS scanners
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3448/6/tests/query_test/test_scanners_fuzz.py
File
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-3764: fuzz test HDFS scanners
..
IMPALA-3764: fuzz test HDFS scanners
This adds a test that performs some simple fuzz testing of HDFS
scanners. It creates
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN
certificates
..
Patch Set 8: Code-Review+2
Still lgtm. Anything else holding this up?
--
To view,
We have got to fix the second one, since gerrit is what our "First
Steps" document said to name the existing gerrit remote, and git is
not great at remotes with the same name and different locations.
On Wed, Jul 20, 2016 at 12:07 PM, Sailesh Mukil wrote:
> On Wed, Jul 20,
On Wed, Jul 20, 2016 at 11:54 AM, Jim Apple wrote:
> Today, Impala's official source is at
> https://github.com/cloudera/Impala/. As of Monday, July 25, it will be
> at
> https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git.
>
> Unfortunately, for all of your
Today, Impala's official source is at
https://github.com/cloudera/Impala/. As of Monday, July 25, it will be
at
https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git.
Unfortunately, for all of your in-progress patches in gerrit, you will
either have to
(a) Abandon them and reprocue them
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3637/2/be/src/exec/kudu-scan-node.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 7:
No prob, just wanted to make sure it wasn't lost in the shuffle.
--
To view,
Michael Ho has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 7:
Sorry, let me get back to it later today.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
..
Patch Set 7:
Ping. It would be good to find a way to move forward with this even though
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads
..
Patch Set 2:
(2 comments)
Regarding FragmentExecState:
We could possibly do away with that and migrate whatever pieces of it
are still needed into RuntimeState (and possibly rename RuntimeState
to make it conform to the naming hierarchy). FragmentExecState is a
bit of a misnomer at the moment anyway, because it's really
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3804: Push per-split filtering into scanners
..
Patch Set 2:
Ping, just in case you missed my comments from July 12. Would be good to get
this one squared
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode.
..
Patch Set 12: Verified-1
Build failed:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()
..
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG
Tim Armstrong has posted comments on this change.
Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
..
Patch Set 2:
(2 comments)
Thanks for working on this, looking forward to the final result. Some
Sure. Currently we duplicate state in fragment instances of a single query,
for example each plan fragment executor creates its own descriptor table,
which could actually be shared among all fragment instances. For RPC
batching (IMPALA-2550) we will transmit the descriptor table only once, and
it
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3662
to look at the new patch set (#3).
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2979: Fix scheduling on remote hosts
..
Patch Set 27:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/2200/24/be/src/scheduling/simple-scheduler.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3201: HEADER ONLY: buffer pool
..
Patch Set 1:
This is an updated header where was have a new InMemPageHandle abstraction that
guarantees that the
Could you say something about the use cases you're trying to address?
That'll make it easier to review the design.
On 20 July 2016 at 10:08, Lars Volker wrote:
> Hi all,
>
> I started drafting a header file for a query-wide QueryExecState class
> here:
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3688
Change subject: IMPALA-3201: HEADER ONLY: buffer pool
..
IMPALA-3201: HEADER ONLY: buffer pool
Change-Id:
Hi all,
I started drafting a header file for a query-wide QueryExecState class
here: https://gerrit.cloudera.org/#/c/3686/2
It's not much and I couldn't figure out how much of the overall changes
needed for RPC batching should be included in this change. Most notably we
might want to replace
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3686
Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
..
PREVIEW: IMPALA-2550 Introduce query-wide execution
A lot of our developer docs are Google docs, which facilitate
commenting, and it would be good to keep it that way.
Should we link to those docs from the Apache Impala wiki?
On Wed, Jul 20, 2016 at 9:06 AM, Tim Armstrong wrote:
> I also think the wiki is the best
Attila Jeges has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 2:
(1 comment)
I think Tom's points are correct.
Another option would be plain text or markdown files inside the git
repo. Those would be harder to update, but then would have review for
developer docs changes, which might be nice.
FWIW, right now getting a wiki login requires asking for one on this
mailing
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-3886: Improve log of pip_download.py
..
Patch Set 1: Code-Review+2
(1 comment)
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3687
Change subject: IMPALA-3886: Improve log of pip_download.py
..
IMPALA-3886: Improve log of pip_download.py
pip_download.py prints the
Lars Volker has posted comments on this change.
Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration
keys
..
Patch Set 2:
(2 comments)
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't
running
..
IMPALA-3779: Disable cache pool reader thread when HDFS isn't running
When
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't
running
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3577
To
On Wed, Jul 20, 2016 at 4:56 AM, Dimitris Tsirogiannis
wrote:
> Hi community,
>
> We need to move our developer documentation to a proper location.
> Currently, it's in Cloudera's internal wiki and in the wiki pages of the
> Cloudera Impala git repo (
>
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
..
IMPALA-3729: batch_size=1 coverage for avro scanner
Also fix a stale comment in the avro scanner
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3413
To unsubscribe, visit
84 matches
Mail list logo