[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Internal Jenkins has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3998

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

Amos Bird has abandoned this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Abandoned Abandoned for https://gerrit.cloudera.org/#/c/3942 -- To view, visit

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Internal Jenkins has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Internal Jenkins has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4018 To

[Impala-ASF-CR] IMPALA-3996: Migrate to updated Kudu insert string API

Internal Jenkins has posted comments on this change. Change subject: IMPALA-3996: Migrate to updated Kudu insert string API .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Marcel Kornacker has uploaded a new patch set (#5). Change subject: IMPALA-3988: Only use first 104 bits of query id .. IMPALA-3988: Only use first 104 bits of query id This adds utility function in uid-util.h to create query

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Sailesh Mukil has uploaded a new patch set (#5). Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3988: Only use first 104 bits of query id .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/util/uid-util.h File

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 44: (7 comments)

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

David Knupp has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 6: > Added a brief note [...] I think this was already like this, but the link on the Wiki to the Google

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4020/3/tests/common/test_result_verifier.py

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 10: Code-Review+2 +2 after rebase -- To view, visit

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Internal Jenkins has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

Tim Armstrong has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Henry Robinson has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3998

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 4: (1 comment) re: tests, you should confirm that

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Henry Robinson has posted comments on this change. Change subject: IMPALA-3988: Only use first 104 bits of query id .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4065/2//COMMIT_MSG Commit Message: PS2, Line

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Henry Robinson has posted comments on this change. Change subject: IMPALA-3988: Only use first 104 bits of query id .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/scheduling/simple-scheduler.cc

Re: [DISCUSS] Criteria for becoming a committer

https://cwiki.apache.org/confluence/display/IMPALA/Committer+Criteria Feel free to edit. On Mon, Aug 8, 2016 at 12:36 PM, Henry Robinson wrote: > I don't think it should have either. Productivity is not so easily > measured. Provide some guidance in this document about what

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Marcel Kornacker has uploaded a new patch set (#4). Change subject: IMPALA-3988: Only use first 104 bits of query id .. IMPALA-3988: Only use first 104 bits of query id This adds utility function in uid-util.h to create query

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Michael Ho has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 3: Code-Review+2 Rebase. Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3988: Only use first 104 bits of query id .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3988: Only use first 104 bits of query id

Marcel Kornacker has uploaded a new patch set (#3). Change subject: IMPALA-3988: Only use first 104 bits of query id .. IMPALA-3988: Only use first 104 bits of query id This adds utility function in uid-util.h to create query

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 6: > Seems like there's consensus on the mailing list. Could you add a > page to the wiki explaining what

[Impala-ASF-CR] IMPALA-3999: Embed the query-wide fragment instance index in the instance id

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3999: Embed the query-wide fragment instance index in the instance id .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Internal Jenkins has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe,

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. IMPALA-3962: Clean up scratch tuple batch on scan failures The parquet scanner doesn't

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 4: (2 comments) Also, all the shell tests pass with

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4066 Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters

[Impala-ASF-CR] IMPALA-3999: Embed the query-wide fragment instance index in the instance id

Henry Robinson has posted comments on this change. Change subject: IMPALA-3999: Embed the query-wide fragment instance index in the instance id .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 3: (6 comments)

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Marcel Kornacker has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3886 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator

[Impala-ASF-CR] IMPALA-3999: Embed the query-wide fragment instance index in the instance id

Marcel Kornacker has uploaded a new patch set (#2). Change subject: IMPALA-3999: Embed the query-wide fragment instance index in the instance id .. IMPALA-3999: Embed the query-wide fragment instance index in the instance id

[Impala-ASF-CR] IMPALA-3221: Copyright / license audit

Jim Apple has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461:

[Impala-ASF-CR] IMPALA-3221: Copyright / license audit

Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-3221: Copyright / license audit .. IMPALA-3221: Copyright / license audit Populates LICENSE.txt with known third-party licenses in the Impala codebase.

[Impala-ASF-CR] IMPALA-3221: Copyright / license audit

Henry Robinson has posted comments on this change. Change subject: IMPALA-3221: Copyright / license audit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3995/1/LICENSE.txt File LICENSE.txt: Line 461:

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

Dan Hecht has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3791 To unsubscribe,

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4018 To

Re: [DISCUSS] Branching for a release soon?

Todd, I see this as being useful for future releases, even if it doesn't get used for this one. Thanks for volunteering to look into that. On Fri, Aug 19, 2016 at 11:12 AM, Todd Lipcon wrote: > I believe the newer versions of gerrit support a label-like concept called >

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 6: PS6 Added BreakBeforeBinaryOperators: 'NonAssignment' from http://gerrit.cloudera.org:8080/4046 --

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Hello Marcel Kornacker, Henry Robinson, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3886 to look at the new patch set (#6). Change subject: Add .clang-format for Impala's C++ style

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 2: Verified-1 This version adds NonAssignment and then shows how it behaves on simple-scheduler.cc

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Jim Apple has uploaded a new patch set (#2). Change subject: REVIEW-ONLY: the results of running clang-format .. REVIEW-ONLY: the results of running clang-format See https://gerrit.cloudera.org/#/c/3886 for the configuration

[Impala-ASF-CR] IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose

Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose .. Patch Set 2: (6 comments) Were any tests affected?

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 2: It passed the packaging build:

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 3: -Code-Review It passed the packaging build:

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3998 to look at the new patch set (#9). Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4018 to look at the new patch set (#5). Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

[Impala-ASF-CR] IMPALA-3996: Migrate to updated Kudu insert string API

Dan Hecht has posted comments on this change. Change subject: IMPALA-3996: Migrate to updated Kudu insert string API .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4055 To unsubscribe, visit

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Marcel Kornacker has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Henry Robinson has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Kathy Sun has uploaded a new patch set (#8). Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page The /memz page

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Dan Hecht has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4064 To

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Kathy Sun has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 7: (13 comments)

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: Code-Review+2 (1 comment) Oops, sorry missed your comment.

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: > Does this pass the tests? Yes, I mentioned about that it passed the

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: Does this pass the tests? -- To view, visit

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail HdfsTableSink::Close()

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 3: (1 comment) Passed private build:

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail HdfsTableSink::Close()

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

Henry Robinson has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4020/2/be/src/exec/hdfs-scanner.cc

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. IMPALA-(3895,3859): Don't log file data on parse errors Logging file or table data is a bad idea, and

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 1: (1 comment)

Re: [DISCUSS] Branching for a release soon?

I believe the newer versions of gerrit support a label-like concept called 'hashtags' (apparently the authors of Gerrit love Instagram). They allow you to tag a review/commit with arbitrary strings. Perhaps this feature could be used so that patch authors can tag their reviews/commits as

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 5: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/3991

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3991 to look at the new patch set (#5). Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ..

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Jim Apple has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Michael Ho has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Jim Apple has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 5: > i posted a comment on the preview of the reformatting results you > sent out, please address that first.

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Internal Jenkins has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Marcel Kornacker has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 5: Code-Review-1 i posted a comment on the preview of the reformatting results you sent out, please

[Impala-ASF-CR] REVIEW-ONLY: the results of running clang-format

Marcel Kornacker has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner .. Patch Set 1: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 4: Hi Shirish, have you had a chance to look at the comments? -- To view, visit

[Impala-ASF-CR] IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page

Henry Robinson has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner

Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4064 Change subject: IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner .. IMPALA-3662: Don't double allocate tuples' buffer

[Impala-ASF-CR] Add .clang-format for Impala's C++ style

Henry Robinson has posted comments on this change. Change subject: Add .clang-format for Impala's C++ style .. Patch Set 5: Code-Review+2 Seems like there's consensus on the mailing list. Could you add a page to the wiki

[Impala-ASF-CR] IMPALA-2581: LIMIT can be propagated down into some aggregations

Jim Apple has posted comments on this change. Change subject: IMPALA-2581: LIMIT can be propagated down into some aggregations .. Patch Set 4: I will be able to look at this again in about 9 days. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3153: Incorrect behaviour around slash escaping single quotes

Jim Apple has abandoned this change. Change subject: IMPALA-3153: Incorrect behaviour around slash escaping single quotes .. Abandoned This change is small enough that it should be re-sent on the new gerrit project

[Impala-CR](cdh5-trunk) IMPALA-1654: Support general predicates in most partition DDL operations.

Jim Apple has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. .. Patch Set 9: This is now getting reviewed on https://gerrit.cloudera.org/#/c/3942/.

  1   2   >