[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408092#comment-16408092 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408093#comment-16408093 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-17 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403472#comment-16403472 ] Lucene/Solr QA commented on SOLR-10912: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-16 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403172#comment-16403172 ] Steve Rowe commented on SOLR-10912: --- {quote} bq. 6. Request ASF Infrastructure to add LUCENE and SOLR to

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401355#comment-16401355 ] Steve Rowe commented on SOLR-10912: --- The short-term TODO is all taken care of: {quote} # Commit current

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401347#comment-16401347 ] Steve Rowe commented on SOLR-10912: --- bq. 6. Request ASF Infrastructure to add LUCENE and SOLR to the

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401336#comment-16401336 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401335#comment-16401335 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401338#comment-16401338 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401334#comment-16401334 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401337#comment-16401337 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401333#comment-16401333 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401319#comment-16401319 ] Steve Rowe commented on SOLR-10912: --- bq. compile does a basic compile test. javac looks in the output

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401308#comment-16401308 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401015#comment-16401015 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401014#comment-16401014 ] Allen Wittenauer commented on SOLR-10912: - compile does a basic compile test. javac looks in the

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401010#comment-16401010 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400996#comment-16400996 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400995#comment-16400995 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400674#comment-16400674 ] ASF subversion and git services commented on SOLR-10912: Commit

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-14 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399885#comment-16399885 ] Steve Rowe commented on SOLR-10912: --- {quote}The current change is here:

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-03-01 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382093#comment-16382093 ] Shawn Heisey commented on SOLR-10912: - On what to do if there's no CHANGES.txt entry: The goal is to

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-28 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381324#comment-16381324 ] Steve Rowe commented on SOLR-10912: --- bq. If there's not an entry in CHANGES.txt that mentions the issue

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-28 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381062#comment-16381062 ] Shawn Heisey commented on SOLR-10912: - Some thoughts: If there's not an entry in CHANGES.txt that

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-28 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380775#comment-16380775 ] Allen Wittenauer commented on SOLR-10912: - Github PR support is sort of there. test-patch does.

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-28 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380464#comment-16380464 ] Steve Rowe commented on SOLR-10912: --- bq. I'm confused what the state is right now. In JIRA I see these

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380458#comment-16380458 ] David Smiley commented on SOLR-10912: - I'm confused what the state is right now. In JIRA I see these

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-23 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374812#comment-16374812 ] Steve Rowe commented on SOLR-10912: --- bq. can we PLEASE rename the "Submit Patch" button to something

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-23 Thread Jason Gerlowski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374787#comment-16374787 ] Jason Gerlowski commented on SOLR-10912: bq. can we PLEASE rename the "Submit Patch" button +1,

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-02-23 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374760#comment-16374760 ] Hoss Man commented on SOLR-10912: - comment/request from someone who hasn't really followed the progress

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-01-16 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327038#comment-16327038 ] Mano Kovacs commented on SOLR-10912: Hey Steve, that would be great as I couldn't work on this lately

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2018-01-15 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326538#comment-16326538 ] Steve Rowe commented on SOLR-10912: --- [~manokovacs]: I'd like to push this forward.  What are the next

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-04 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191046#comment-16191046 ] Mano Kovacs commented on SOLR-10912: Thank you [~aw], [~steve_rowe]! > Adding automatic patch

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-03 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190247#comment-16190247 ] Steve Rowe commented on SOLR-10912: --- bq. Add Patch Available status for SOLR project [] Steve Rowe,

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-03 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189931#comment-16189931 ] Allen Wittenauer commented on SOLR-10912: - * If the plan is to use

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-03 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189738#comment-16189738 ] Mano Kovacs commented on SOLR-10912: As you can see from the last comment above, the minimal setup is

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-03 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189539#comment-16189539 ] Mano Kovacs commented on SOLR-10912: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-10-02 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189033#comment-16189033 ] Mano Kovacs commented on SOLR-10912: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-29 Thread Cassandra Targett (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185770#comment-16185770 ] Cassandra Targett commented on SOLR-10912: -- bq. I would like to move the topic about

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-29 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185565#comment-16185565 ] Mano Kovacs commented on SOLR-10912: [~ctargett], [~cpoerschke], [~mdrob], thank you for the inputs.

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-22 Thread Cassandra Targett (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176578#comment-16176578 ] Cassandra Targett commented on SOLR-10912: -- bq. If doc updates are not (yet) present then it

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-22 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176532#comment-16176532 ] Christine Poerschke commented on SOLR-10912: bq. One thing I'd like to see added to validation

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176520#comment-16176520 ] Mike Drob commented on SOLR-10912: -- I agree with Cassandra, and would go even further in saying that

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-22 Thread Cassandra Targett (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176500#comment-16176500 ] Cassandra Targett commented on SOLR-10912: -- One thing I'd like to see added to validation is an

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162164#comment-16162164 ] Mano Kovacs commented on SOLR-10912: The latest test-patch only tested the three module was changed

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162155#comment-16162155 ] Mano Kovacs commented on SOLR-10912: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162140#comment-16162140 ] Mike Drob commented on SOLR-10912: -- There's some dependency work here. A change in solr-core shouldn't

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162042#comment-16162042 ] Mano Kovacs commented on SOLR-10912: Yeah, that would make sense. Do you think it would be enough just

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161973#comment-16161973 ] Mike Drob commented on SOLR-10912: -- bq. solr in the patch failed would be good to see if we can say

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161950#comment-16161950 ] Mano Kovacs commented on SOLR-10912: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161786#comment-16161786 ] Mano Kovacs commented on SOLR-10912: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mano Kovacs (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161753#comment-16161753 ] Mano Kovacs commented on SOLR-10912: [~mdrob], thanks for the followup :) Well, there is no automated

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161707#comment-16161707 ] Mike Drob commented on SOLR-10912: -- [~manokovacs] - was there supposed to be a QA run for the patch you

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-06-19 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054869#comment-16054869 ] Jan Høydahl commented on SOLR-10912: This would be awesome > Adding automatic patch validation >

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-06-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054147#comment-16054147 ] Mike Drob commented on SOLR-10912: -- [~manokovacs] - I'm on board with this. There was some discussion