HTTP based API using REST architectural style

arkmail.org/message/ai6q2fbksowaayn4 [2] https://issues.apache.org/jira/browse/OFBIZ-4274 -- Mathieu Lirzin

Re: HTTP based API using REST architectural style

Hello Jacques, Jacques Le Roux writes: > Le 10/04/2018 à 11:05, Mathieu Lirzin a écrit : >> >> I have recently started a 5 month internship at Néréide >> <https://nereide.fr/> during which I will work on implementing a >> HTTP based API using REST archit

Re: HTTP based API using REST architectural style

Hello Paul, Paul Foxworthy writes: > This might be of interest too: > > https://martinfowler.com/articles/richardsonMaturityModel.html Thanks for the link. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Confusing entity names

n is to know if changing an entity name is an acceptable breaking change and how it should be handled. Is there a way to deprecate the old entity name, while introducing the new one? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [Discussion] Introduction of Bootstrap and Vue.js

ouple the JS framework from the Renderer, but maybe I am overlooking something? FYI I am currently working on finding a solution to let external applications access OFBiz services/entities via a REST API [1]. [1] https://mail-archives.apache.org/mod_mbox/ofbiz-dev/201804.mbox/%3Ce373cd98-12b7-247b-

Re: svn commit: r1832199 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/JavaEventHandler.java

you puzzled by a specific scenario? Thanks. [1] https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#computeIfAbsent-K-java.util.function.Function- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [Discussion]: Add method attribute to request-map

metimes hard to define, so I just want to emphasize the *try and avoid* part. > 2- I think it would be better to revert this work. I noticed in the > JIRA for example that Mathieu Lirzin asked for some time to review his > work when you just committed his work without checking what he want

Re: [Discussion]: Add method attribute to request-map

gt;> If you or Mathieu would like to start a discussion I'd recommend a new thread I will open a new thread summarizing the goal/intent of adding a ‘method’ attribute to ‘request-map’ elements, and describing the proposed changes. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Contributing/Coding guidelines (was: svn commit: r1834662 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java)

s://svn.apache.org/repos/asf/ofbiz/tools/wiki-files/OFBizJavaFormatter.xml OK I will adjust my code. Maybe the line length of 120 could be explicitly stated as an exception to the Sun standard [1]? Thanks. [1] http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#313 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Add ‘method’ attribute to ‘request-map’ elements

Hello, Following revert of rev 1834917, I want to “properly” propose adding a ‘method’ attribute to ‘request-map’ elements. I am currently working on adding REST based Web APIs to OFBiz [1]. In order to do that, it is important for the HTTP controller to handle various HTTP methods differently,

Re: Add ‘method’ attribute to ‘request-map’ elements

Thank you for the explanation. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

Shi Jinghai writes: > Yeah, I forgot the site-conf.xsd, now I reverted it in rev. 1835043. Thanks, I have updated the patches from OFBIZ-10438 to re-add those :-) -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

ation and example help? Thanks for the feedback. [1] https://www.restapitutorial.com/lessons/httpmethods.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

exciting stuff! > > [1] https://issues.apache.org/jira/browse/OFBIZ-4274 Thanks. [1] https://cxf.apache.org/javadoc/latest/org/apache/cxf/jaxrs/model/URITemplate.html [2] https://www.martinfowler.com/articles/richardsonMaturityModel.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Contributing/Coding guidelines

Jacques Le Roux writes: > Le 05/07/2018 à 17:41, Jacques Le Roux a écrit : >> Yes, good idea, I'll do so >> >> Thanks > Done Thanks Jacques. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

Hello, Taher Alkhateeb writes: > Examining your patch I have a few comments / questions: FYI I have updated the third patch on OFBIZ-10438 [1] to improve the tests for the ‘resolveMethod’ static method. [1] https://issues.apache.org/jira/browse/OFBIZ-10438 Thanks. -- Mathieu Lirzin

Re: Add ‘method’ attribute to ‘request-map’ elements

an be encapsulated like what is done for ‘org.apache.commons.cli.*’ in ‘StartupCommandUtil’. Not depending on it is still a viable option however it will mean having to maintain a non-negligeable amount of non-trivial code in OFBiz. WDYT? Thank you for your insightful review. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

Hello, Just wanted to correct a mistake I have made. Mathieu Lirzin writes: > I needed a MultiMap meaning a map which associates a key to a List of > values not to a scalar. What is nice is that “MultivaluedMap::put” is > not destructive, it just appends the new value to th

Re: Add ‘method’ attribute to ‘request-map’ elements

Mathieu Lirzin writes: > Taher Alkhateeb writes: > >> - I still don't understand your answer on the new data structure >> "MultiValuedMapContext". This is essentially a whole new data >> structure designed by you and it overrides nearly all standard

‘MapStack’ weirdness.

} return super.put(key, value); } --8<---cut here---end--->8--- I don't understand the purpose of such thing. So if someone has some rationale to share, I would be grateful. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: ‘MapStack’ weirdness.

Environment instance and // use it to process the template with the user's settings. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: ‘MapStack’ weirdness.

here---start->8--- The ‘context’ Map is added to the ‘Binding’ as a variable called "context" so that variables can be passed back to the caller. --8<-------cut here---end--->8--- Thanks for your input. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Gradle ‘gretty’ Plugin

/gretty-doc/Hot-deployment.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Gradle ‘gretty’ Plugin

Hello James, James Yong writes: > Have you looked into http://dcevm.github.io/ ? > > No comment about gretty as I haven't tried. I didn't know about it. I will take a look. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Oracle Java release model changes and consequences for the project

eased, OFBiz should keep compatibity with the previous LTS release meaning java 8. Of course This does not mean that OFBiz should not be tested with more recent Java releases too. Having an extra branch has a maintenance burden that should be balanced with the benefits it provides. What benefits

Re: svn commit: r1837697 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/XmlRpcEventHandler.java

ends AbstractReflectiveHandlerMapping implements XmlRpcHandler { Feel free to do whatever you want with it. I am not sure to understand what is the purpose of the ‘getRequest’ method so it would be nice if you could provide a docstring for it. Thanks. [1] https://forax.github.io/ [2] https://www.youtube.com/watch?v=aC1wGHDOQic -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Plugin install process pb

gt; > task hello { > doLast { > println 'tutorialspoint' > } > } > > > > with the previous version of taskExistsInproject it works > > └─$ ./gradlew installPlugin -PpluginId=testPlugin1 > :plugins:testPlugin1:install > install task for my plugin test1 > Bonjour > :installPlugin > installed plugin testPlugin1 > > BUILD SUCCESSFUL > > Total time: 3.134 secs -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Plugin install process pb

Hello again, Mathieu Lirzin writes: >> In my environment (Linux, openjdk version "1.8.0_171") plugin install >> process does not work any more since this commit (june, 20) >> >> def taskExistsInproject(fullyQualifiedProject, taskName) { >> -def tas

Re: Plugin install process pb

do that. Thanks for commiting the fix. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [PROPOSITION] Extend the screen engine via plugins

ngnothing in the framework, identify clearly what > change has been made and a failure support when the extend can't be > applied. > > Currently I didn't found a solution to surcharge ftl. > > If you feel that it's a good way to explore, I will start a new thread. I guess I have started the thread :-) [1] https://en.wikipedia.org/wiki/Monkey_patch -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Issue with opening a bookmarked page when the user is logged out

. +1 for a opening a ticket. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Editing comments in Jira

using JIRA Web Interface instead which doesn't have this updated comment issue. should only be mentioned as an alternative in “degraded” mode. [1] https://issues.apache.org/jira/projects/OFBIZ/summary -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Gradle, Less, Css : Transpile and minify

minification) and in production mode (with minification) to ease the Javascript debugging. Since this is a very common requirement, I guess those Gradle plugins already provide such facility or describe how to customize the impacted tasks. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Impersonation and Documentation

y, maybe Asciidoc provides a way to define variables? If so, file name prefixes could be defined with a variable with a meaningful name that could then be reused when referring to an external file. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1841664 - /ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java

r, false otherwise > */ Next time, please follow OFBiz standards by not adding lines longer than 120 Characters. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1841675 - /ofbiz/tools/verify-ofbiz-release.sh

ES=en_EN.UTF-8 export LC_MESSAGES Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Using alternate dispatcher and delegator for integration tests

introduces a ton of complexity since we can't assume that there is only one dispatcher and delegator shared by all the tests cases. As a consequence I would like to know if we could agree on removing this unused feature? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using alternate dispatcher and delegator for integration tests

Here is what I precisely want to remove. >From 66150cc98d2b7b84ee5aa4dee1e25f60556577e6 Mon Sep 17 00:00:00 2001 From: Mathieu Lirzin Date: Sun, 21 Oct 2018 16:02:38 +0200 Subject: [PATCH] Disallow using alternate dispatcher and delegator for integration tests --- framework/testtools

Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

an inline comment giving a rationale for the current implementation. If that's not the case, I can open a JIRA with a proper patch if needed. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java

--end--->8--- Joke aside :-), it would be *really* great if people could make an effort sticking to the convention of using no more than 120 characters per line which is already enough to make my eyes bleed. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.jav

e the “120 chars max” guideline for newly added code and when refactoring existing one. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Pursuing the “120 chars max” guideline

Jacques Le Roux writes: > Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit : >> I sympathise but I am not sure about this strategy, which depending on >> the capabilities of your VCS might obscure the commit history. I would >> recommend to simply use the “120 chars max” guid

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

rovides even more details. :-) I will be looking into deleting the startup loaders API. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using alternate dispatcher and delegator for integration tests

ions - adding alternate model constructors which doesn't impose passing an XML element - removing abuse of inheritance and replace it with delegation - injecting dependencies instead of embedding them So Strong +1! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

Hello, Mathieu Lirzin writes: > I will be looking into deleting the startup loaders API. As a citizen of the *Start-Up Nation* [1], I am proud to announce that the startup loader abstraction has finally been concretized! :-) I have opened OFBIZ-10638 [2] for review. Thanks. [1] ht

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

./applications/workeffort/groovyScripts ./framework/webtools/groovyScripts ./framework/common/groovyScripts ./framework/base/groovyScript --8<---cut here-------end--->8--- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

he user/developper manual instead of simply deleting the page. This helps people keeping bookmarks on some important Wiki pages which could be hard to retrieve otherwise. Additionally this would help avoiding both internal and external links breakage. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

Jacques Le Roux writes: > Le 08/11/2018 à 23:26, Mathieu Lirzin a écrit : >> Even if IME a majority of links are already broken in the Wiki (which is >> part of the reason why I am strongly convinced that Wikis as a main >> documentation are a bad idea), I would sugge

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

ovy plugin for supporting unit tests written in Groovy beforehand, it should work gracefully. Otherwise looks good to me. [1] https://issues.apache.org/jira/projects/OFBIZ/issues/OFBIZ-10611 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Using plain Groovy classes for services.

at do people think? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

which could reads like the current ‘run’ method of the DSL and provide the same semantics (throwing an exception upon failure). Something like: dispatcher.run service: "fooService" with: [...] Thanks for your questions. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

presentations/Simple-Made-Easy-QCon-London-2012 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

ble methods which would allow cheap better case coverage to complement the integration test which is about checking that the service has the expected effect on the database. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

Hello Jacques, Jacques Le Roux writes: > Le 21/11/2018 à 17:43, Jacques Le Roux a écrit : >> Le 17/11/2018 à 20:12, Mathieu Lirzin a écrit : >>> For services I think the business logic and validation of data contained >>> in services could often be extracted in sep

Re: [DOCUMENTATION] TOCs level and numbers

ectnums: I agree with limiting the table of content level to 3, However I strongly disagree with the removal of section numbers which IME helps both in understanding the structure of the manual and in making references to a specific section. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [DISCUSSION] Checking debug levels in Java and Groovy files

in/loss must be backed by an actual measurement, and this has not been the case in this discussion. Personnally I care about the readability of the code and choosing the option 2 is not helping in that regard. [1] https://youtu.be/z5UkoLaW6ME?t=213 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1848673 [1/4] - in /ofbiz: ofbiz-framework/trunk/ ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/ ofbiz-framework/trunk/applications/a

our processes to achieve both review scalabity and commit atomicity, but in any case I am grateful to Jacques for the important and useful work he is doing by reviewing other people patches. [1] https://issues.apache.org/jira/browse/OFBIZ-10701 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 07

Re: [Discussion] Upgrading OFBiz to work with Java 11

1 is still not available on the GNU/Linux distro I am using. So upgrading it right now would make my life harder. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

if that is the case. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-10606 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: git commit workflow for ofbiz

problem. :-) Joke aside I think the question should rather be: Is there anyone here opposing to the move from SVN to Git? Thanks for reviving this topic! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

OFBiz shell

interactively execute commands and check their results instantly. I have implemented such feature in OFBIZ-10805 [1] which might be interested to follow/review for those who care about interactive development. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-10805 -- Mathieu Lirzin GPG: F2A3 8D7E

Re: OFBiz shell

the implications of using the current thread class loader. What kind of scenario of non-clean termination of shells have you in mind? Thanks for your comment. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Getting rid of the Script helper abstractions

/docs/api/java/util/ServiceLoader.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: future of OFBiz: REST is essential.

REST support (architecture, advantages, drawbacks, limitations, …) and give some pointers to the implementation? Additionally what would be your recommended strategy to port this work? Are you willing to do the work? Thanks. [1] https://guide.elm-lang.org/architecture/ -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: JobManager/JobPoller issues

Hello Scott, Scott Gray writes: > I'm working on implementing the priority queue approach at the moment for a > client. All things going well it will be in production in a couple of > weeks and I'll report back then with a patch. Sounds great! -- Mathieu Lirzin GPG: F2A3

Re: Welcome to Mathieu Lirzin as new committer!

Hello, Taher Alkhateeb writes: > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and > we are happy to announce that he has accepted this role. Thanks everybody for the congratulations and welcoming me as a committer in this project. -- Mathieu Lirzin GPG: F2A3 8D7

Re: svn commit: r1854366 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java

DebugManagedDataSource> // Ensures that the close() method does not throw an >> InterruptedException >> // to conform to the AutoCloseable interface. >> -// This is fixing what should be down in >> org.apache.commons.dbcp2.PoolingDataSource. >> +

Re: [REMOVE?] OWASP Dependency Check feature (Gradle plugin)

work on my machine (See OFBIZ-10700) I can hardly see any reason to keep it. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Using Gradle ‘application’ and ‘distribution’ plugins

target or a convoluted/brittle shell script. If nobody disagree I will commit this in a week. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-10866 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Removing the ‘:terminateOfbiz’ Gradle task

red a bug at first hand, I personnally think this failure is more a symptom of a desperate endeavour which is to guess how the system of a user is managing its processes. As a consequence I will suggest to simply remove this task to not make false promises to users and let them manage the processes

Re: gradlew generateOfbizDocumentation error

t; on svn release 1854593 generation seems correct >> with 1854595 generation works but with a lot of messages >> with 1854818 generation failed >> >> on trunk , if I remove line >>     id 'org.owasp.dependencycheck' version '3.0.2' apply false >> >> generation works but with a lot of messages. >> >> > -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle

with the code. Sure I agree that's an important guideline to follow. Thanks. [1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices [2] https://issues.apache.org/jira/browse/OFBIZ-10866 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

When do we need a JIRA? (was: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle)

Hello, In the same spirit, I want to know if it is OK to improve or add some Javadoc without opening a ticket on JIRA? Thanks. Mathieu Lirzin writes: > Hello Michael, > > Michael Brohl writes: > >> don't we have Jira's for all these changes? >> >>

Defining multi-segment routes in the controller.

org/jira/browse/OFBIZ-4274 [2] https://tools.ietf.org/html/rfc6570 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: buildbot exception in on ofbizTrunkFramework

upload The changes I made has introduced unexpected regression. I have reverted them in revision 1857091. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1857084 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java

/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java >>> > (original) >>> > +++ >>> > >>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java >>> > Sun Apr 7 19:38:09 2019 >>> > @@ -1215,8 +1215,7 @@ public class FormRenderer { >>> > } >>> > int itemIndex = -1; >>> > if (iter instanceof EntityListIterator) { >>> > -EntityListIterator eli = (EntityListIterator) iter; >>> > -try { >>> > +try (EntityListIterator eli = (EntityListIterator) iter) { >>> > if(eli.getResultsSizeAfterPartialList() > 0){ >>> > itemIndex++; >>> > } >>> > >>> > >>> > >>> >> -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [OPTIONS] Java 11 and Java JDK origin

ot’) Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

issue this evening, and after some hours I still do not understand the bug. It is depressing to see how hard it is to work with OFBiz integration tests. If you don't find a solution before the end of the week, please revert revision 1856596 which introduces the issue (meaning removing “OrderTes

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

n hour because of that. Currently only the following syntax is “working”: --8<---cut here---start->8--- --8<---cut here---end--->8--- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

st failing also when doing the test execution against > jdk8? > *Caveat: I recently set this up, so there may still be some configuration > issues in the jdk11-test setup.. * I have just tested the “ordertests” test-suite with Icedtea 3.7 (jdk-8) and it is still failing, so it seems unrelated in that case. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1858094 - in /ofbiz/ofbiz-framework/branches/release18.12: ./ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java

if (throwRequestHandlerExceptionOnMissingLocalRequest) { >throw new RequestHandlerException(requestMissingErrorMessage); > } else { Checking for ‘null’ here is not a solution since ‘resolveURI’ contract it to return a non-nullable collection. This commit is only bypass

Re: Reviving the OFBiz community day

Swapnil M Mane writes: > Wow, thoughts travels Pierre! > I am also working a document for migration of OFBiz from SVN to Git. > It is at very beginning state, hopefully will share it by this end of week. > :) \o/ -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1858350 - in /ofbiz/ofbiz-plugins/trunk: pricat/src/main/java/org/apache/ofbiz/pricat/AbstractPricatParser.java pricat/src/main/java/org/apache/ofbiz/pricat/sample/SamplePricatParser.

errorMessages.put(new CellReference(cell), errorMessage); > +return false; This change seems fishy since it introduces code after a ‘return’ statement in the same block, which mean that this is dead code. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Next step to migrate OFBiz from Subversion (SVN) to Git

for that. Personnally I will be against using Github social features (issues, pull-request, wiki, ...) in our contribution process. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re-designing the ‘Security’ interface

-11019 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: buildbot failure in on ofbizBranch18FrameworkPlugins

ask which doesn't make any sense since the revision 1859124 is not changing any code but only javadoc comments… I assume this is unrelated to the commit I made. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1859877 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/servicedef/ applications/content/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ appli

nitizers > > Thanks: Christoph Neuroth for report This commit breaks the “custrequesttests” test suite with a vanilla framework after ‘loadAll’. If the issue can not be solved tomorrow please revert. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Gradle eclipse task - classpath modification

consent on > this one? I see no reason not to fix this issue. Moreover it would be nice to make it clearer in the ‘build.gradle’ what is the actual problem about having extra entries in the ‘.classpath’. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1859877 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/servicedef/ applications/content/servicedef/ applications/marketing/servicedef/ applications/order/servicedef/ appli

ta.xml > > I have yet not idea why the CustomSafePolicy class (based on Slashdot policy) > rejects it, seems weird to me. > > It's also (even more) weird that when the plugins data are loaded the issue > does not exist Indeed this is weird, thanks for investigating! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1859876 - in /ofbiz/tools/demo-backup: Nicolas/functions.sh Nicolas/trunk.sh trunk.sh

” files in the framework repository? If not what is “.ignore”? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1859876 - in /ofbiz/tools/demo-backup: Nicolas/functions.sh Nicolas/trunk.sh trunk.sh

Nicolas Malin writes: > On 30/05/2019 13:04, Mathieu Lirzin wrote: > >> Nicolas Malin writes: >> >>> hmm not, I just control that if we haven't gradlew we init it. >>> >>> Your remark just alert me that I forget to set the gradlew on .ignore &

Re: Files w/o licenses

Jacques Le Roux writes: > OK, I'll do it in a week if nobody beats me on it. > > But I'll name those that should have done it before :p Shame! :-) <https://www.youtube.com/watch?v=0Tna_vci9IY> -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [DISCUSSION] Committing Minilang test patches under OFBIZ-1463

work. Applying those patches in their current state would simply mean putting the burden on someone else to do the work. So I am strongly opposed to committing thoses patches before the tests are migrated. As far as I am concerned, if people want stuff to be committed then they have to do their

Re: [DISCUSSION] Committing Minilang test patches under OFBIZ-1463

Hello Jacques Le Roux writes: > Le 02/06/2019 à 15:50, Mathieu Lirzin a écrit : >> >> Jacques Le Roux writes: >> >>> We started a discussion in OFBIZ-1463 about committing or not the Minilang >>> test patches. >>> >>> There are alrea

Removing support for global "ofbiz-containers.xml"

d-code the required base container which is loading the components which is currently defined in this file. What do people think? I have opened OFBIZ-11100 [1] with some patches demonstrating what I am exactly proposing. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-11100 -- Mathieu

Re: Reply-to address missing for dev and user mailing list

l every time. Yes, this is how it is supposed to work, you should use "Reply all" when communicating with a group of people. [1] http://www.unicom.com/pw/reply-to-harmful.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Reply-to address missing for dev and user mailing list

lients to automatically respect your personnal preferences. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Reply-to address missing for dev and user mailing list

Hello Deepak, Deepak Dixit writes: > On Thu, Jun 13, 2019 at 4:14 PM Mathieu Lirzin > wrote: > > Hello Aditya, > > Aditya Sharma writes: > > > We can configure reply-to email address for the mailing list which means > > when the user clicks the reply bu

Re: Reply-to address missing for dev and user mailing list

Jacques Le Roux writes: > Le 13/06/2019 à 13:02, Mathieu Lirzin a écrit : >> Hello Jacques >> >> Jacques Le Roux writes: >> >>> 1st please when you answer to dev ML don't add my email to this >>> answer. I continuously and indefectibly follow

Re: Reply-to address missing for dev and user mailing list

; And should we create a specific thread to decide on what do as optimal > (ie based on a consensus or even a vote)? > > Please refer to the links I posted above as food for thoughts, I copy them > here: > > http://www.unicom.com/pw/reply-to-harmful.html > http://david.woodhou.s

  1   2   3   >