Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/20
And why is it closed?
---
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140425575
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1509,65 +1514,62 @@ private boolean isTimeToDelete
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139078626
--- Diff:
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
---
@@ -63,11 +65,36 @@ public RouteInfoManager
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/154
The title should be "[Rocketmq-285] file test error when make link"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134962143
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133863841
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133863133
--- Diff:
namesrv/src/test/java/org/apache/rocketmq/namesrv/NamesrvControllerTest.java ---
@@ -1,46 +0,0 @@
-/*
--- End diff
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133862502
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java ---
@@ -37,16 +37,14 @@
*/
@Test
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/148
I agree with @mark800. IMO, this fix doesn't require unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132808594
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -59,7 +59,7 @@
public static final String WS_DOMAIN_NAME
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/141#discussion_r132088233
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -70,24 +76,28 @@ public static
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/140#discussion_r132087129
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/body/RegisterBrokerBody.java
---
@@ -40,4 +57,114 @@ public void
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/140#discussion_r132086276
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java ---
@@ -148,12 +148,13 @@ private RegisterBrokerResult
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/133
@zhouxinyu The problem is described in the JIRA issue -- "If disk usage
estimates fail because the disk store path is not found (doesn't exist),
message store falsely decides the
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/133
@vongosling @zhouxinyu @lizhanhui @vsair Anyone's willing to review the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131031474
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r131030593
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130764893
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1210,13 @@ public TopicRouteData
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130764799
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1210,13 @@ public TopicRouteData
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/127
@lizhanhui Got it, thanks! How about adding comments with explanations for
each policy class? I think developers will appreciate that.
---
If your project is set up for it, you can
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/127#discussion_r130530039
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/PullIntervalPolicy.java
---
@@ -0,0 +1,25 @@
+/*
+ * Licensed
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130528221
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -255,19 +255,17 @@ public void start
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/134
@Ritabrata-TW In other words, your pull request description has to be in
this format
```
[ROCKETMQ-xxx] Message describing the issue.
Link to ROCKETMQ-xxx, which
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238369
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -717,22 +718,28 @@ public long getEarliestMessageTime
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238308
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1210,13 @@ public TopicRouteData
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r130238297
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1210,13 @@ public TopicRouteData
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/138
`wanting to send a message with...`
yes, this should be the top comment of your class
```java
/**
wanting to send a message with ...
*/
public class
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/138
Please see this pull request description
https://github.com/apache/incubator-rocketmq/pull/130, for example.
---
If your project is set up for it, you can reply to this email and have
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/138
Also you'll need a JIRA issue opened for this, and specified as the
description of this pull request.
Please see other accepted pull requests.
---
If your project is set up
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129781791
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -16,29 +16,7 @@
*/
package
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/131
Merged to develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/130
Merged to develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/130#discussion_r126867179
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/BrokerData.java
---
@@ -37,15 +41,21 @@ public BrokerData(String
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/130#discussion_r126858457
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/BrokerData.java
---
@@ -37,15 +41,21 @@ public BrokerData(String
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/131
Thanks @Jaskey , updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/130
@Jaskey I modified the comment, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/130
@Jaskey It returns a random broker address if the one with MASTER_ID is not
found. Why do you suggest renaming?
I hope the execution flow doesn't depend on the current method
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/127
Looks good, but can you please briefly outline what the problem was --
ROCKETMQ-233 does not say much.
---
If your project is set up for it, you can reply to this email and have your
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
Merged to develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
Ok, if it's good to merge, I will resolve the conflicts and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
Another thing is -- do we need the default topic at all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@lizhanhui Looks good. Can we have some tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/60
@Jaskey No idea about `hasTempMessage()` -- no comments or unit tests...
All the rest is ok to merge.
---
If your project is set up for it, you can reply to this email and have your
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/66#discussion_r115727645
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
---
@@ -401,6 +408,14 @@ public void
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650526
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/80#discussion_r114733797
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -112,18 +156,21 @@ private RemotingCommand
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/80#discussion_r114733685
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -95,52 +141,65 @@ public static BrokerController
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@dongeforever Hmm, sorry I don't understand yet why `JAVA_OPTS` won't work.
Can you please explain how/when it happens? :)
---
If your project is set up for it, you can reply
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Guys, let's merge this fix after the conflicts are resolved.
I also don't like breaks in minor versions, but there are too many spelling
mistakes and writing workarounds for each
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/4#discussion_r112873634
--- Diff: rocketmq-storm/README.md ---
@@ -0,0 +1,2 @@
+# RocketMQ Storm Integration
--- End diff --
Is this pushed
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/86
@Jaskey Incrementing and logging heartbeats on success seems reasonable to
me. All failures are logged in `catch` clause.
---
If your project is set up for it, you can reply
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
Ok, but let's set it through `JVM_OPTS` instead of introducing a variable
for that specific setting.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@dongeforever Sorry, I don't think this modification is needed. A user will
modify this file anyway in order to match his/her system requirements.
Also, there are even more flags
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704133
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeResponseHeader.java
---
@@ -16,15 +16,15
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111704125
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/header/GetEarliestMsgStoreTimeRequestHeader.java
---
@@ -16,15 +16,15
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111700022
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -577,12 +577,12 @@ public void operationComplete
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111699977
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -577,12 +577,12 @@ public void operationComplete
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@zhouxinyu yes, luckily they are :)
IMO, if the difference is just PUSH and PULL models, it's reasonable to
merge them and improve. Any other ideas?
---
If your project
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@vongosling There are two PRs for ROCKETMQ-81. I guess @hustfxj or @vesense
will have to compile them in one, and they recheck it together :)
Guys, please make sure you
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/56#discussion_r108617467
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/consumer/ConsumerProgressSubCommand.java
---
@@ -94,12 +117,14 @@ public void
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@dongeforever Yes, sure. But first please address my comments for that PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/52
@dongeforever Thanks! It seems there are no objections, I will merge it to
`develop` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/83
Merged to `develop` branch. Thanks @vesense. Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
If no special consideration for authentication errors is needed (which was
obviously the intention in the original code), +1 for just removing the
hard-coded snippet
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/84
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/8
@zhouxinyu Sure, I just wanted to be sure this addition to the PR
submission policy is ok ;)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/60#discussion_r105590248
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
---
@@ -449,9 +449,9 @@ private SendResult
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/60#discussion_r105590475
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
---
@@ -46,7 +46,7 @@
private final TreeMap
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
@vongosling @zhouxinyu @lizhanhui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/76
@eoss1990 Have you created this PR by mistake? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
I would rather get suggestions about this modification, if any, instead of
hypothetical considerations. What is described here cannot be done with the
current RocketMQ code base -- it's
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
@Jaskey For this, write your decorated code (what you write above) in, say,
`MyDecoratedClass` and specify "MyDecoratedClass" as your storage to
initialize. That will suffice.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
@Jaskey For a decorated class, you don't write "DecoratedClassA,
DecoratedClassB, DecoratedClassC" in your properties, do you? :) You just
specify your outer class, say "
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
:+1: to this fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@lizhanhui @vongosling I see. I changed the code, please have a look.
Also, I will try to keep the modules in mind, but we need something not to
forget they have to be treated
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@vongosling Is it for `rocketmq-remoting` only or for the whole project?
It doesn't sound exciting to go back to old JDKs, but ok :)
---
If your project is set up for it, you can
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/67
@Jaskey This is a very good description, and now reviewers will understand
well your intentions :) If you clearly state your intentions in JIRA, or
discuss in the ml, it saves much time
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/68
@Jaskey I agree that `setServiceState` should be deprecated. I overlooked
it was _public_.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why
this pr can be merged if a unit test can be easily written. I think we have to
accept PRs with tes
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/8
Added having unit tests as a necessary condition for PR (when applicaâ¦
â¦ble).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@zhouxinyu Probably you misunderstood what I meant :) -- this PR needs unit
tests. I think it's the responsibility of the person who submitted PR to create
them, whenever possible, since
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
Good catch. I would add unit tests though ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
@vongosling Thanks for reviewing!
Sure, unit tests can be completed after we improve this module.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/68
I also think that using `synchronized` fits well here.
But I would do it in the following way:
1. Make `serviceState` volatile
```java
private volatile ServiceState
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
@zhouxinyu Thanks for checking it!
Well, `@Ignore` is there just for finer granularity -- we remove it one by
one when implementing each test. If you think we don't need it, I can
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/61#discussion_r101699903
--- Diff: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
---
@@ -47,6 +47,7 @@
private boolean
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/65
[ROCKETMQ-104] Make MQAdmin commands throw exceptions
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-104
You can merge this pull request into a Git repository by running
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/57#discussion_r101456741
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -1154,7 +1249,7 @@ public AppendMessageResult doAppend(final long
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/57#discussion_r101455998
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -567,6 +577,11 @@ public PutMessageResult putMessage(final
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/53
Sounds good to check for the protocol version in the request header, and
reject with an error when not matched.
Probably, `RemotingCommand.REMOTING_VERSION_KEY` will work, but I would
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/49
[ROCKETMQ-72] DefaultMessageStore cannot be properly shutdown when faâ¦
â¦iled in the middle of start()
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-72
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/37
A suggestion: how about renaming this JIRA issue? This issue is for
RemotingCommand, _'some'_ is very vague.
We can end up with many more _'some'_ tests in future :)
---
If your
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/4#discussion_r95923375
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -73,11 +73,15 @@ Push your branch to Github:
6. When you are satisfied and want
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
Hi @zhouxinyu
I am not sure if I understand your 1st point though, but if you are saying
about printing to `stdout` or `stderr` so that users can find problems with
brokers from
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/29
@zhouxinyu @stevenschew Thanks, guys,
https://issues.apache.org/jira/browse/ROCKETMQ-36 is created to consider the
improvement.
---
If your project is set up for it, you can reply
1 - 100 of 124 matches
Mail list logo
