Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200210 ---

Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200209 --- It would be great if you can find out why some files the variable

Re: Review Request 66373: SENTRY-2194: Upgrade Sentry hadoop-version dependency to 2.7.5 to take advantage of security vulnerability fix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66373/#review200248 --- Ship it! Ship It! - Na Li On March 30, 2018, 7:05 a.m.,

Re: Review Request 66376: SENTRY-2193: Synchronize thrift definition with the generated sources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66376/#review200251 --- Ship it! Ship It! - Na Li On March 30, 2018, 4:33 p.m.,

Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66065/#review199568 --- Ship it! Ship It! - Na Li On March 14, 2018, 2:36 p.m.,

Re: Review Request 66066: SENTRY-2181: Add owner privileges to create database notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66066/#review199583 --- Ship it! Ship It! - Na Li On March 14, 2018, 2:43 p.m.,

Re: Review Request 66066: SENTRY-2181: Add owner privileges to create database notifications

> On March 14, 2018, 3:56 p.m., Na Li wrote: > > what jira will you add code to handle db events processing relate to owner > > privileges? > > kalyan kumar kalvagadda wrote: > SENTRY-2153 will add code to update the cache. > There should another jira created to add inplcit privileges.

Review Request 66146: SENTRY-2184: Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66146/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar

Re: Review Request 66146: SENTRY-2184: Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66146/ --- (Updated March 20, 2018, 11:54 p.m.) Review request for sentry, Alexander

Re: Review Request 66146: SENTRY-2184: Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

> On March 20, 2018, 8:06 p.m., kalyan kumar kalvagadda wrote: > > Lina, Code looks good but we need to run some performance tests with some > > huge data to actually see the results. > > Simple unit test may not be good enough. The performance test code and result is posted in jira

Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar

Review Request 66263: SENTRY-2154: Update schema to grant privileges to user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66263/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar

Re: Review Request 66146: SENTRY-2184: Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66146/ --- (Updated March 21, 2018, 4:52 p.m.) Review request for sentry, Alexander

Re: Review Request 65867: SENTRY-2147 - Fix Javadoc for SentryHiveAuthorizerFactory

> On March 2, 2018, 3:43 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerFactory.java > > Line 34 (original), 34 (patched) > > > > > >

Re: Review Request 65867: SENTRY-2147 - Fix Javadoc for SentryHiveAuthorizerFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65867/#review198528 --- Ship it! Ship It! - Na Li On March 1, 2018, 12:32 p.m.,

Re: Review Request 65867: SENTRY-2147 - Fix Javadoc for SentryHiveAuthorizerFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65867/#review198529 ---

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? Sergio, I don't want to take the trouble to fix the 2.1.0

Review Request 66826: SENTRY-2213: Increase schema version from 2.0.0 to 2.1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66826/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar

Review Request 67774: SENTRY-2289: Tests in TestHDFSIntegrationAdvanced fail from time to time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67774/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Bugs:

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review205524 --- Ship it! Ship It! - Na Li On March 30, 2018, 11:10 p.m.,

Re: Review Request 67695: SENTRY-2277: Add to SentryStore testURI test case testing with multiple URI privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67695/#review205510 --- Ship it! Ship It! - Na Li On June 21, 2018, 9:18 p.m.,

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209485 ---

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

> On Oct. 12, 2018, 3:43 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3437 (patched) > > > > > > if there are

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209487 --- Ship it! Ship It! - Na Li On Oct. 12, 2018, 2 p.m., Arjun

Re: Review Request 68823: SENTRY-2416: FullUpdateInitializer metrics are not reset for each new HMS snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68823/#review209564 ---

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/#review209560 ---

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/#review209572 ---

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/#review209658 --- Ship it! Ship It! - Na Li On Oct. 16, 2018, 4:17 p.m.,

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209760 ---

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/#review209762 ---

Review Request 69074: SENTRY-2429: Transfer database owner drops table owner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69074/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209879 ---

Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69076/#review209799 ---

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209798 ---

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/ --- (Updated Oct. 24, 2018, 4:14 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 4:38 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1118 (original), 1124 (patched) > >

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 3:42 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 929 (original), 932 (patched) > > > >

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 3:42 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 925 (original), 928 (patched) > > > >

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 3:42 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 925 (original), 928 (patched) > > > >

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 3:44 p.m., Arjun Mishra wrote: > > Let me know what you think about this. I think we could minimize the change > > set by keeping changes to the core methods? alterSentryRevokePrivilegeCore > > and alterSentryGrantPrivilegeCore? > > For example there are methods like

Re: Review Request 69122: SENTRY-2432: The case of a username is ignored when determining object ownership

> On Oct. 23, 2018, 3:42 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2837 (original), 2847 (patched) > > >

Re: Review Request 69204: SENTRY-2437: When granting privileges a single transaction per grant causes long delays

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69204/#review210164 --- Ship it! Ship It! - Na Li On Oct. 29, 2018, 9:35 p.m.,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210228 ---

Review Request 69175: SENTRY-2433: Dropping object privileges does not include update of dropping user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69175/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 69212: SENTRY-2329: Integrate sentry with Hadoop 3.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69212/#review210262 ---

Re: Review Request 69175: SENTRY-2433: Dropping object privileges does not include update of dropping user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69175/ --- (Updated Oct. 29, 2018, 5:07 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

> On Oct. 9, 2018, 2:13 p.m., kalyan kumar kalvagadda wrote: > > Lina, > > > > I see advantages of this approach but i also see some dis-advantages which > > are serious. > > > > 1. If there is a failure while handling the notification for any reason > > there is no way to retry. This is not

Re: Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

> On Oct. 4, 2018, 6:26 p.m., Arjun Mishra wrote: > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegePrincipalType.java > > Line 36 (original), 36 (patched) > >

Re: Review Request 68918: SENTRY-2423: Increase the allocation size for auto-increment of id's for Snapshot tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68918/#review209369 --- Ship it! Ship It! - Na Li On Oct. 3, 2018, 8:24 p.m.,

Re: Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

> On Oct. 9, 2018, 2:13 p.m., kalyan kumar kalvagadda wrote: > > Lina, > > > > I see advantages of this approach but i also see some dis-advantages which > > are serious. > > > > 1. If there is a failure while handling the notification for any reason > > there is no way to retry. This is not

Re: Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68890/ --- (Updated Oct. 2, 2018, 9:26 p.m.) Review request for sentry, Arjun Mishra,

Review Request 68982: SENTRY-2426: Update the version in pom file at 2.1 branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68982/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209419 ---

Re: Review Request 68968: SENTRY-2425: Add metric to track the time taken to update the owner privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68968/#review209429 ---

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209427 ---

Re: Review Request 68982: SENTRY-2426: Update the version in pom file at 2.1 branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68982/#review209426 --- Ship it! Ship It! - Na Li On Oct. 10, 2018, 9:42 p.m., Na

Re: Review Request 68973: SENTRY-2305: Optimize time taken for persistence HMS snapshot by persisting in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68973/#review209430 --- do you have measurement on how much time saved on saving big

Re: Review Request 68918: SENTRY-2423: Increase the allocation size for auto-increment of id's for Snapshot tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68918/#review209205 ---

Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68890/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/ --- (Updated Oct. 1, 2018, 9:23 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > > Lines 680 (patched) > > > > > > Do you need to

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/#review208814 ---

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/#review208815 --- can you add unit test? - Na Li On Sept. 20, 2018, 7:32 p.m.,

Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208969 ---

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209007 ---

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209014 --- Ship it! Ship It! - Na Li On Sept. 25, 2018, 9:23 p.m., Hao

Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 288-300 (patched) > > > > > > Is it possible

Re: Review Request 68838: SENTRY-2410: CREATE privileges on Hive does not allow a user to list all tables of a database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68838/#review208995 ---

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208994 --- Ship it! Ship It! - Na Li On Sept. 24, 2018, 11:45 p.m.,

Re: Review Request 69353: SENTRY-2454: Add new sentry store api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review212150 --- Ship it! Ship It! - Na Li On Dec. 18, 2018, 11:23 p.m.,

Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69501/#review211250 --- Ship it! Ship It! - Na Li On Dec. 3, 2018, 5:22 p.m., Arjun

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211145 ---

Re: Review Request 69530: SENTRY-2476: Optimize deleting specific paths for objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211147 --- Can you add more test cases to cover the cases that mutiple

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review211169 --- Ship it! Ship It! - Na Li On Nov. 29, 2018, 10:14 p.m.,

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review211170 ---

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review211171 --- can you add test case to cover the issue you want to fix? There

Re: Review Request 69586: SENTRY-2481: Filter HMS server-side objects based on HMS user authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69586/#review211441 --- Ship it! Ship It! - Na Li On Dec. 19, 2018, 3:24 p.m.,

Re: Review Request 69567: SENTRY-1679: HDFS tests configure MetastorePlugin which is gone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69567/#review211335 --- Ship it! Ship It! - Na Li On Dec. 13, 2018, 9:10 p.m.,

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 29, 2018, 6:44 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 176 (patched) > > > > > > do you want

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210982 --- sentry-dist/src/license/THIRD-PARTY.properties Line 34

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210949 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210950 ---

Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/#review27 --- Ship it! Ship It! - Na Li On Dec. 7, 2018, 3:14 p.m.,

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review28 --- typo: "sentrys tore" should be "sentry store" - Na Li On Dec.

Re: Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review29 ---

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210909 --- Ship it! Ship It! - Na Li On Nov. 27, 2018, 9:34 p.m.,

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

> On Nov. 26, 2018, 7:44 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Line 37 (original), 37 (patched) > > > > > > should this

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210730 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

> On Nov. 20, 2018, 5:08 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 179 (patched) > > > > > > can you set

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210728 ---

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210731 ---

Re: Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/#review210870 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210930 --- Ship it! Ship It! - Na Li On Nov. 27, 2018, 3:32 a.m.,

Re: Review Request 69448: SENTRY-2464: Catch exception thrown on first reload for UpdatableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210874 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210878 ---

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210877 ---

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/ --- (Updated Jan. 9, 2019, 10:39 p.m.) Review request for sentry, Arjun Mishra and

Re: Review Request 69620: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69620/#review211679 ---

<    1   2   3   4   5   6   >