Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2913
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@arunmahadevan yes, it make sense to use a LinkedList here. Thanks for the
explanation.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@revans2 if I am not mistaken I recall that when you reviewed the initial
PR you suggested that a call to nextTuple should send only one tuple/record.
Can you please refresh my mind on the reasons why
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@arunmahadevan what's the motivation to change this to LinkedList?
nextTuple emits only a single tuple because that's the contract of the
method nextTuple, which must be honored
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2775
MINOR - Make raw type assignment type safe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache master_skc_RawTypeAssignSafe
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r187100160
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2667
+1
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186887493
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
+1
@srishtyagrawal thank you for your nice and helpful contribution. It will
benefit a lot of users.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
@srishtyagrawal Thank you for the code review. It is much better now.
Besides my two comments above, I still wonder if it would be better to point
the links with the description of the Kafka properties
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253569
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253611
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253597
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r186253552
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185160807
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168182
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168669
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185167619
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185163739
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168807
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185161496
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2637#discussion_r185168952
--- Diff: docs/storm-kafka-client.md ---
@@ -313,4 +313,37 @@ KafkaSpoutConfig<String, String> kafkaConf =
KafkaSpoutConfig
.setTupleTrackingEn
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
@erikdw I am reviewing this now. Sorry but I was away the last few days.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2584
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2550
+1.
Thanks @erikdw, it's really good. Thanks also for the discussion. Looking
forward to continue it in the dev list, and hopefully agreeing on a good
solution.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2550
@erikdw I am not sure I follow when you wrote:
> All commits of a PR are bunched together. They can all be referenced as a
group in git revert or git cherry-pick.
In the first git
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2550
@HeartSaVioR I understand your point of not putting the burden on the
contributors. I didn't really think that it could be a big hurdle for
contributors. However, taking that into consideration
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2550
@ptgoetz, @srdo and I have been using the following approach for squashing
the patches in storm-kafka-client, which I believe works well:
- It is reasonable to submit a PR for review that has
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2550
@erikdw I agree that in this case where we are cherry-picking several
commits it's very hard to avoid multiple commits, and probably we shouldn't
even try to squash them because that will completely
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
+1
Thanks @HeartSaVioR for working on this right away.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
+1
@HeartSaVioR I meant to say that you should add also to the commit log the
SHA of the 1.x-branch that you checked out and of which copied the entire
storm-kafka-client directory
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
@HeartSaVioR I agree that your approach. Can please add to the commit
message the SHA from the 1.x-branch that was the base for this overwrite, such
that one can trace it down in case it is necessary
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2547
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2538
+1.
Once squashed is good to merge as far as I am concerned. Thanks a lot @srdo.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857516
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857829
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +460,37 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857620
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857949
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857479
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -142,7 +139,7 @@ public void open(Map<String, Obj
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857745
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857816
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +460,37 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165857469
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -75,8 +75,9 @@ public boolean
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2537
+1. Let's squash and as far as I am concerned it is good to merge. Once
this is squash can you please rebase STORM-2913. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165853341
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852737
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -469,11 +437,14 @@ private boolean emitOrRetryTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852835
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852864
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165853160
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852696
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -396,7 +361,10 @@ private void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165853240
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -311,7 +273,10 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852272
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -142,7 +139,7 @@ public void open(Map<String, Obj
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852670
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -396,7 +361,10 @@ private void setWaitingToEmit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165853046
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -469,11 +437,14 @@ private boolean emitOrRetryTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2538#discussion_r165852989
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/CommitMetadataManager.java
---
@@ -0,0 +1,90
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165852132
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -519,6 +519,15 @@ private boolean isEmitTuple(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165852072
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +459,33 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165851895
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -143,28 +146,28 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165852060
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +459,33 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830316
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -196,13 +206,37 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165829893
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -210,23 +215,26 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830237
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +451,33 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830142
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -519,6 +519,15 @@ private boolean isEmitTuple(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830128
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -307,8 +307,12 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830302
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -153,8 +163,8 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830301
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -153,8 +163,8 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830313
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -196,13 +206,37 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830248
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +451,33 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830275
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +451,33 @@ public Builder(String
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830219
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -519,6 +519,15 @@ private boolean isEmitTuple(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830294
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -109,7 +119,7 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830061
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -133,8 +133,8 @@ public void open(Map<String, Obj
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830031
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -89,7 +89,7 @@
private transient
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830279
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java
---
@@ -85,4 +90,12 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830085
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -307,8 +307,12 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830283
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java
---
@@ -85,4 +90,12 @@ public void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2538
@srdo there is a discrepancy between the title of this pull request and the
title of the associated JIRA. What problem are you trying to solve in this
patch? Add meatada, or remove warnings
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2537
@srdo I left the
[comment](https://issues.apache.org/jira/browse/STORM-2914?focusedCommentId=16346102=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16346102)
on the JIRA.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2530
OK, thanks.
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2530
+1, however I don't understand why this module is using the maven app
assembler plugin to copy all the jars under target/app-assembler/repo nor why
all of these jars are posteriorly being copied
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2512
@erikdw @srdo Thanks for checking in with me. I was off for the last few
days and hence just getting back into this, although a bit too late because the
patch just got merged before I got the chance
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120269
--- Diff: external/storm-solr/README.md ---
@@ -97,6 +97,29 @@ field separates each value with the token % instead of
the default | . To use th
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159121022
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilderV2.java
---
@@ -0,0 +1,127 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120398
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -153,4 +160,15 @@ private void failQueuedTuples(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120315
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -88,9 +92,11 @@ private int capacity() {
@Override
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120430
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/SolrFieldTypeFinder.java
---
@@ -70,13 +73,22 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120320
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -128,6 +134,7 @@ private void fail(Tuple tuple, Exception e
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120287
--- Diff: external/storm-solr/README.md ---
@@ -171,7 +194,7 @@ Querying Solr for these patterns, you will see the
values that have been indexe
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120311
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -88,9 +92,11 @@ private int capacity() {
@Override
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120406
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java
---
@@ -54,4 +65,7 @@ public int getTickTupleInterval
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119938
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119896
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119878
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo Thanks for the review. I have addressed the last few things and
squashed the commits right away. It is ready to merge.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo Thanks for the review. I have squashed the commits and it is ready to
merge.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158656447
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/KafkaUtils.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I would like to merge this patch asap. Can you please take a quick
look such that I can squash and merge it in. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo these are all the changes in 1.x-branch already squashed. It is ready
to merge.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo done. Pls check and I will squash the commits right away. I would
like to try to merge this in today. I will update the master PR with everything
squashed already. Thanks.
---
1 - 100 of 782 matches
Mail list logo
