Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r160498347
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,156 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r160501820
--- Diff: storm-core/src/jvm/org/apache/storm/task/TopologyContext.java ---
@@ -386,4 +388,28 @@ public ReducedMetric registerMetric(String name,
IReducer
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2504
@HeartSaVioR not a problem. I often forget that others are not able to
read my thoughts and I sometimes forget to mention the context.
The code was not really a prototype. We intend
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2504
@HeartSaVioR sorry about that I think we probably were not clear enough on
this, what is covered and what is not currently covered by this pull request.
Reading through the description
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2505
@HeartSaVioR It is totally possible to do. The problem we ran into was
that I would change something in one tab (like searching for a specific
keyword), and then refresh a different tab
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2507#discussion_r160277946
--- Diff:
storm-server/src/test/java/org/apache/storm/nimbus/LocalNimbusTest.java ---
@@ -32,42 +37,35 @@
import org.junit.Assert;
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2507#discussion_r160260170
--- Diff:
storm-server/src/test/java/org/apache/storm/nimbus/LocalNimbusTest.java ---
@@ -32,42 +37,35 @@
import org.junit.Assert;
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2507#discussion_r160259977
--- Diff:
storm-server/src/test/java/org/apache/storm/nimbus/LocalNimbusTest.java ---
@@ -32,42 +37,35 @@
import org.junit.Assert;
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160241948
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1081,6 +1088,14 @@ public Nimbus(Map<String, Object> conf, I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160242680
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4166,4 +4184,23 @@ public void shutdown() {
public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160243540
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/MetricStore.java ---
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160241598
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -1023,6 +1023,43 @@
public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160245890
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/rocksdb/RocksDbStore.java
---
@@ -0,0 +1,636 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160244314
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/rocksdb/RocksDbMetricsWriter.java
---
@@ -0,0 +1,306 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160240315
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -291,12 +291,22 @@ public static long bitXor(Long a, Long b) {
* runtime
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160240938
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -1023,6 +1023,43 @@
public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160241831
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1081,6 +1088,14 @@ public Nimbus(Map<String, Object> conf, I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160241080
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -1023,6 +1023,43 @@
public static String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160246323
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/rocksdb/RocksDbStore.java
---
@@ -0,0 +1,636 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r160242577
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4166,4 +4184,23 @@ public void shutdown() {
public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2505#discussion_r160239743
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -307,6 +307,12 @@
@isString
public static final String
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2505
@srishtyagrawal yes my concern was mostly with the number of times that the
REST calls were being hit. If you can reduce it so no new rest calls come in,
that would be great.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2505
@HeartSaVioR That should be very simple to do. Right now we are storing
the data in session storage.
https://github.com/apache/storm/blob/7ecb3d73e8e909c01d39e03a7a7ed45a2fb81859/storm
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2507
STORM-2885: Avoid conflicts with nimbusDaemon LocalCluster Tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159973491
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159973149
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159972982
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -184,30 +191,25 @@ public void remove
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2505
@srishtyagrawal I am fine with the change in principal, but I am not happy
with an implementation that adds many new called to get the cluster
configuration. One for each table on the page.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969475
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -328,20 +328,22 @@ public static boolean isSystemId(String id) {
* @return
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159962361
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java ---
@@ -17,72 +17,124 @@
*/
package org.apache.storm.executor
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969170
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159956952
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968476
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ObjectReader.java ---
@@ -76,6 +76,32 @@ public static Integer getInt(Object o, Integer
defaultValue
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969789
--- Diff: storm-server/src/main/java/org/apache/storm/Testing.java ---
@@ -712,6 +712,6 @@ public static Tuple testTuple(List values,
MkTupleParam param
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954152
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -193,6 +210,24 @@ public void run
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159957697
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969910
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -79,6 +79,7 @@
protected final long
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954450
--- Diff: storm-client/src/jvm/org/apache/storm/cluster/ClusterUtils.java
---
@@ -47,7 +47,6 @@
public static final String STORMS_ROOT = "s
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159967636
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,46 @@
import org.apache.storm.task.GeneralTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159949952
--- Diff: docs/Performance.md ---
@@ -0,0 +1,132 @@
+---
--- End diff --
Great Documentation, but can we have some of the other docs link to it?
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159958378
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159963018
--- Diff: storm-client/src/jvm/org/apache/storm/executor/TupleInfo.java ---
@@ -23,7 +23,7 @@
import java.io.Serializable;
import java.util.List
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159955584
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/metrics/SpoutThrottlingMetrics.java
---
@@ -22,24 +22,25 @@
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960326
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960500
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159966670
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/SerializationFactory.java
---
@@ -20,6 +20,7 @@
import org.apache.storm.Config
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159959648
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -196,19 +197,21 @@ public static Executor mkExecutor(WorkerState
workerState
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968772
--- Diff: storm-client/src/jvm/org/apache/storm/utils/RunningAvg.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2501
Thanks @dvehar I merged this into master
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
I am still seeing test failures when running `mvn clean install -Pall-tests
-fn | tee log.txt`
`integration.org.apache.storm.integration-test` Looks like an NPE at
ExecutorTransfer.java
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
Yes I checked it out wrong... My bad.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2500
@HeartSaVioR thanks...
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
@roshannaik I may have checked it out wrong, I will try again...
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2500
@HeartSaVioR I have not seen the issue on 1.x, but it is also an issue
there. It is a problem with using the mini-dfs cluster, and we use it for
tests in 1.x too. The patch applies mostly cleanly
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159895567
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2498
@arunmahadevan
I think we are all on the same page here. All I am saying is that this
patch by itself does not fix STORM-2881 for 2.x and as such I don't want it to
go in as is, we need
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2241
Sorry it has taken me so long to get back to this. I did a quick pass
through the code, but I need to spend some time to go more in depth. I expect
to be doing this this afternoon and tomorrow
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742244
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159742835
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159736224
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159734646
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -184,30 +191,25 @@ public void remove
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159735761
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159735958
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2493
@danny0405 I merged this into master, but the patch does not apply cleanly
to 1.x (Slot.java moved locations)
Could you please provide a 1.x patch as well? Also do you have a JIRA ID
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2498
This patch is problematic without shading. With this the unit tests will
run with a different version of curator from how it will run in production. So
it ends up being a NOOP with masking errors
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2500
STORM-2876: Work around memory leak, and try to speed up tests
The actual fix is just the changes in storm-hdfs/pom.xml But this added 1
min to the build time on a decently powerful box. So
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2487
@kishorvpatil could you put up a pull request to 1.x for this?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2477
@srdo I moved it over to being a Rule annotation
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2463
@srdo that sounds fine to me.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2477#discussion_r158338596
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
---
@@ -65,11 +67,33
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2463
@srdo One of the issues I was trying to address with using the array was
both performance and memory usage. Maps are very slow and use lots of memory
compared to an array. Hadoop did a very
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2477
STORM-2863: Reset NormalizedResources for tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2863
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2442
@jerrypeng TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_SEARCH is not an effective
limit on the max stack depth. The max stack depth is the number of bolt and
spout instances in a topology. If we want
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2442
@jerrypeng I reverted the one rename you asked about and rebased to fix a
merge conflict. I also squashed because I thought we were really close on this.
I don't understand your comment
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r157803142
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/multitenant/NodePool.java
---
@@ -98,7 +98,7 @@ public RoundRobinSlotScheduler
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2442
@HeartSaVioR I rebased it and made the changes. My updates are in the last
commit f5e9532
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2442
@HeartSaVioR sorry I have been out for the past 2 weeks. I will update the
configs accordingly.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz I think that is a good start. Not sure if users would be upset
that their bolt B.1 now looks like B_1. We might have issues though if someone
has both a B.1 bolt and a B_1 bolt. It might
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz for me this is all about the metadata for the metric.
The code we have been working on for storing metrics in a DB that we can
then use for scheduling is getting close to being done
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154193748
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154197827
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154194020
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154194603
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154193911
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154194294
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154195212
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154194951
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154195462
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r154194548
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2441
@srdo I agree that we don't want slf4j-log4j12 on the classpath whenever
possible. The use case we have is adding hadoop to our daemon classpath with
all of the configs and everything else needed
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2442
STORM-2837: ConstraintSolverStrategy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2837
Alternatively you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
The new overhead for metrics_v2_replace_meters_to_counters_with_sampling
looks like it is in an acceptable range for me. Right about a 1% difference
for latency. (0.97% to 1.29%) and right about
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2439
@MichealShin thanks I merged this in.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2436
@srdo I made the name change you suggested.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2436
STORM-2833: Use the original host name when closing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2833
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2435
STORM-2833: use the same host name for removal too
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2833-1.x
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
I did a quick analysis of the latency vs CPU usage for the branch from
@HeartSaVioR and this branch based off of the test results posted by
@HeartSaVioR (just to get more of an apples to apples
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152407885
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152368944
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152368599
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
501 - 600 of 3470 matches
Mail list logo
