GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2710
STORM-3099: Extend metrics on supervisor and workers
The first commit refactored and commented code in Slot.java
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2709
STORM-3099: Extend metrics on supervisor and workers
The first commit refactored and commented code in Slot.java
You can merge this pull request into a Git repository by running:
$ git pull
Github user zd-project closed the pull request at:
https://github.com/apache/storm/pull/2709
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2708
STORM-3098: Fixed method filterChangingBlobsFor()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zd-project/storm STORM-3098
Alternatively
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2708
I extended the test to cover the testing of filterChangingBlob now.
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2714
STORM-3101: Add filter to StormMetricsRegistry.
The current implementation is based on the idea to set a source for a
certain process. All the metrics not belonging to the source (e.g
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Some questions:
1. Currently, by rejecting a metric, StormMetricsRegistry simply discard it
and log the warning without throwing any errors to the calling method/classes
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195246920
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195467563
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Additional questions:
1. Is worker considered a separate daemon from supervisor? How should we
differentiate worker's metrics from supervisor's metrics? For example, the
worker's kill/restart
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
Another implementation would be to require all metrics to be registered
when at least one instance of a class has been instantiated. This will
disqualify the final property of all metrics
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2720
STORM-3109: Fixed incorrect conversion from relative path to absolute path
for STORM_LOCAL_DIR
See issue: https://issues.apache.org/jira/browse/STORM-3109
You can merge this pull request
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2720
It would break if itâs given as a relative path. File.getCanonicalPath
converts it to cwd/STORM_LOCAL_DIR
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
Iâll make incremental commits to this pull request as it involves
multiple changes, as described in the original apache issue page. Thanks.
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2702
STORM-3092: Refactor code to correct launch initialization of Supervisor
Fixed the issue STORM-3092
You can merge this pull request into a Git repository by running:
$ git pull https
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
DRPC metrics:
- [x] Avg/Max Time to respond to Http Request
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2740
Fixed startTime assignment to using Storm Time util.
Current implementation uses System.currentTimeMillis() instead of
Time.currentTimeMillis() to get state start time. This may create problem
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2739
[STORM-3125/3126/3127]: Refactoring methods in components for Supervisor
and DRPC
This is a supplement issue page to STORM-3099, separating out refactoring
work from newly implemented metrics
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
#2739
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
New supervisor level metrics:
- [ ] Worker Kill/Restart Statistics
- [x] Kill Count by Category - assignment change/HB too old/Heap space
(memory limit?)
- [x
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199578276
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199577394
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199600941
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531108
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199534448
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531884
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2743
I'm wondering how I should organized my code changes if I have some new
changes that depend on this PR but don't belong to this PR. Do I have to wait
until this PR has been merged? Or can I file
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207326393
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2787#discussion_r207329210
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/utils/LogCleanerTest.java
---
@@ -87,8 +88,9 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207328701
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java
---
@@ -0,0 +1,29
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2789
STORM-3173: flush metrics to ScheduledReporter on shutdown
https://issues.apache.org/jira/browse/STORM-3173
You can merge this pull request into a Git repository by running:
$ git pull
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207376890
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -133,10 +123,15 @@ public int compare(File f1
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
`name()` has been removed from this PR.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207586437
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java
---
@@ -0,0 +1,29
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2787
Squashed.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2788#discussion_r207587787
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/testsupport/MockRemovableFileBuilder.java
---
@@ -0,0 +1,29
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207599113
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
I have rebase this PR onto #2763, and I have also moved out
`registerMetricSet`, `unregisterMetricSet` and `registerTimer` to the
corresponding patch.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
change with `name()` is retained for now but have not been incorporated
into other PR dependents because I'm not clear if we'll benefit from this.
Should I remove this from PR for now and create
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2763
All nits are addressed and PR is rebased on current master branch. Do you
want to merge this PR right now or merge this together with #2771?
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r205520696
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2710#discussion_r207645153
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -28,11 +29,14 @@
import
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2783
Additionally, it still seems to be not ideal that if we want to measure
things inside a static method, we'd have to pass the metric in as a parameter.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2710
Should I squash to one per daemon?
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
The metrics of IO exceptions on logviewer is kind of fuzzy as I go through
the call stack manually and eyeballed all thrown exceptions. I'm not sure if
it's complete or if it will over-count
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207636496
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -50,19 +61,19 @@ public static void startMetricsReporters
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207638261
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2771#discussion_r207640687
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -12,28 +12,30 @@
package org.apache.storm.metric
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2783
Extensibility and Centralized management would be my concerns. I think this
PR has improved on the centralized management of metrics. For example I think
the slotMetrics class is a great example
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2763
@srdo I've squashed the commits. Sorry about the delay.
---
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2788
STORM-3170: Fixed bug to eliminate invalid file deletion
https://issues.apache.org/jira/browse/STORM-3170
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2787
STORM-3169: Correctly convert configured minutes to milliseconds
See https://issues.apache.org/jira/browse/STORM-3169 for details
You can merge this pull request into a Git repository by running
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2788
This will affect #2754
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2787
Seems this PR is passing on my repo but failed here. There may be some
unrelated bugs out there.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205907197
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,67 @@
@SuppressWarnings("unch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205907405
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -89,13 +89,8 @@ public void prepare(Map conf
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
As suggested by @Ethanlm, I would like merge #2763 into this one and then
port the changes for MetricSet and Timer to the patches where they're actually
invoked. How does that sound?
@srdo
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
This will become the base for #2743, #2764, #2754, and #2709.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205906955
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208745736
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746090
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208747514
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749367
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2219,21 +2305,16 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746266
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Please notice that only the last commit is under #2764, which was
previously out of sync with #2754 because I don't want to have too many
dependencies between PR. For issue specific to #2754 I
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208743919
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
---
@@ -52,6 +52,7 @@ public void prepare
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208744273
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -,13 +2231,23 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746949
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2131,17 +2223,13 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746736
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208748414
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749692
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208751049
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208748740
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749524
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749175
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209363589
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367121
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
All nits addressed?
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
What do you think @srdo
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Added clarifications to ClusterSummaryMetricSet
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367723
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296628
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209303203
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296760
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209305125
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301358
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209297840
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301707
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209305519
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209311426
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209315575
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298109
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209299849
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209312212
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2800
STORM-3162: Fix concurrent modification bug
See: https://issues.apache.org/jira/browse/STORM-3162
I managed to alter the Java implementation and it seems to be passing
storm-server test
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209335050
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209337293
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298650
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209302512
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
All nits should have been addressed as of now.
---
1 - 100 of 225 matches
Mail list logo
