Re: Switch to Google C++ Style Wholesale (was Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++)

2015-07-15 Thread Benjamin Smedberg
On 7/15/2015 5:47 PM, Andrew Sutherland wrote: Would it be crazy for us to resort to a poll on these things? A poll will not be useful for informing this decision. --BDS ___ dev-platform mailing list dev-platform@lists.mozilla.org

Switch to Google C++ Style Wholesale (was Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++)

2015-07-14 Thread Benjamin Smedberg
On 7/8/2015 7:31 AM, Nathan Froyd wrote: If somebody is willing to do the formatting, I'm willing to do the review. I think the thread has reached the point of people repeating ad nauseum what was already said earlier in the thread, so it's time for a decision. Benjamin? Aww, I was

Re: GTK3 linux builds

2015-06-17 Thread Benjamin Smedberg
On 6/16/15 4:16 PM, Jeff Muizelaar wrote: We're working on making all of the tests green for GTK3. This means that we could be changing the default linux configuration to GTK3 as early as FF42. What are the advantages of the GTK3 build? Is there a list of which distros/versions would continue

Firefox Data Collection Practices - How to Collect Data

2015-06-10 Thread Benjamin Smedberg
I'd like to point Firefox and platform developers at this doc: https://wiki.mozilla.org/Firefox/Data_Collection Several times recently I've discovered that developers are unsure what the rules are for collecting data. Last year, I worked with Marshall Erwin to clarify decision-making about

Re: Update: Intent to Ship Adjust SDK in Fennec

2015-05-20 Thread Benjamin Smedberg
On 5/20/2015 1:07 PM, Winston Bowden wrote: We've done an enormous amount of due diligence prior to integration. Adjust went through a legal and privacy review. It also went through and open source review/analysis. As the data steward I've been working with both Winston and the engineering

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-05-13 Thread Benjamin Smedberg
, -- Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform -- Benjamin Smedberg Engineering Manager, Firefox ___ dev-platform mailing list dev

Re: No more binary components in extensions

2015-05-05 Thread Benjamin Smedberg
On 5/4/2015 6:53 PM, Philipp Kewisch wrote: So to be clear, this is just removed/disabled for Firefox? Other projects like Thunderbird are not affected? Followups to dev-extensions please! That is incorrect. This is currently disabled for all gecko applications. B2G has asked that binary

No more binary components in extensions

2015-05-04 Thread Benjamin Smedberg
(Followup questions or comments to mozilla.dev.extensions only, please.) With the landing of bug 1159737, I have removed support for binary XPCOM components in extensions. This is planned to ride the Firefox 40 train. This change is necessary because we no longer expose or intend to expose a

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-04-29 Thread Benjamin Smedberg
-- Benjamin Smedberg Engineering Manager, Firefox ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: changing the default platform and operating-system on bugzilla.mozilla.org to all / all

2015-04-14 Thread Benjamin Smedberg
On 4/14/2015 11:40 AM, Dave Townsend wrote: Are the platform fields actually useful? Most bugs apply to all platforms and in the cases that don't it is normally clear from the bug conversation that it is platform specific. It seems like we rarely go an update the platform fields to match the

The e10s throbber

2015-04-07 Thread Benjamin Smedberg
With desktop e10s on there can be a noticeable delay after switching tabs where there is a throbber displayed before the page content. Is the duration of this delay measured in telemetry anywhere, and do we have criteria for how much delay is acceptable in this case? If e10s were off, do we

Re: FYI: Serious windows bug affecting WebRTC when mem use is over 2GB

2015-03-26 Thread Benjamin Smedberg
On 3/26/2015 3:00 AM, Randell Jesup wrote: Force a buffer in 2GB memory and always copy into/out of that buffer? That may work, other than it's inconvenient to force a buffer into 2GB space at the time when you need it, and thus we'd have to perma-allocate a large enough buffer for this.

Re: Fwd: [blink-dev] Intent to Ship: Plugin Power Saver Poster Images

2015-02-09 Thread Benjamin Smedberg
On 2/7/2015 4:38 AM, Jet Villegas wrote: We should pick this up too. I'm skeptical of the immediate value. We need to focus on Flash hangs and also the security issues surrounding Flash 0-days especially as distributed by ad networks. Power saving is not our immediate or medium-term focus.

Firefox desktop platform team: Q1 areas of focus

2015-01-06 Thread Benjamin Smedberg
I wanted to shared publicly the projects and areas of focus that the Firefox Desktop Platform team in Q1. *Video quality issues, especially Flash video:* We have market data which indicates that one of the most important pain points for Firefox users is problems with video. We have several

Re: Updating the policy for Talos performance regression in 2015

2014-12-19 Thread Benjamin Smedberg
On 12/19/2014 10:05 AM, Ehsan Akhgari wrote: Acceptable outcomes: * A promise to attempt a fix at the bug is agreed upon, the bug is assigned to someone and put in a queue. How do we ensure that the follow-up bug actually does get fixed and it fixes the regression completely?

Re: Critical - XULRunner 34 fails with Couldn't load XPCOM in MacOSX

2014-11-28 Thread Benjamin Smedberg
On 11/27/2014 10:38 PM, allencb...@gmail.com wrote: I've reported this in bugzilla. Any one has any workaround? I commented in the bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1105044). This is probably due to the MacOS v2 signing work which restructured the bundles. Since XULRunner

Re: How do you run unit tests against Firefox?

2014-11-12 Thread Benjamin Smedberg
On 11/12/2014 5:49 PM, Nicholas Nethercote wrote: What exactly do you mean by unit tests? I presumed that this meant all of our pass/fail test suites (not the performance tests): xpcshell, the various flavors of mochitest, reftests, etc. --BDS

Re: Changing our help messages to mention --foo options instead of -foo options

2014-10-24 Thread Benjamin Smedberg
On 10/23/14 9:20 PM, Nicholas Nethercote wrote: Hello. Our command-line option handling is *interesting*. Did you know that: - our options work in -foo form and --foo form; - they are case-insensitive; - this holds for both short options (e.g. -h) and long options (e.g. -help). I did in fact

gtests that start XPCOM

2014-10-22 Thread Benjamin Smedberg
Is there a mechanism for running single gtests that start XPCOM? With the current gtest mechanism, normal gtests can't start XPCOM (NS_InitXPCOM, event loops, component manager, etc) for various reasons: * gtests are run in parallel and XPCOM has globals and thread-locals which don't allow

Re: gtests that start XPCOM

2014-10-22 Thread Benjamin Smedberg
On 10/22/2014 10:49 AM, Kyle Huey wrote: I've been wanting this too. I was thinking about just making the gtest harness itself start XPCOM. - Kyle I don't think that's quite right. 1) We'd have to serialize a bunch of tests 2) it would be really easy for tests to interfere with eachother.

Re: Win64 builds tests coming soon!

2014-10-22 Thread Benjamin Smedberg
On 10/21/2014 8:37 PM, Gijs Kruitbosch wrote: Is there a tracking bug for the work on 64-bit itself? There is bug support-win64. But at this point most of these bugs aren't being tracked as part of a win64-specific project, but more as work for each team to prioritize. If there are serious

Re: Compiler version expectations

2014-10-16 Thread Benjamin Smedberg
On 10/16/2014 3:49 PM, Jeff Muizelaar wrote: After some discussion some IRC it was clear that our compiler deprecation schedule is not very clear. Now that we’re using VS2013 on trunk and will soon not being using GCC 4.4 for B2G, I expect we’ll be dropping support for building with VS2010

Tool for generation of regression-range links

2014-10-13 Thread Benjamin Smedberg
tl;dr: I have a tool for generating regression-range links from buildids. http://bsmedberg.github.io/firefox-regression-range-finder/ Often times when we're investigating regressions (crashes, etc), we have the build ID of the nightly where the regression started. But it's not the easiest

Re: c++ unit test in content process

2014-10-03 Thread Benjamin Smedberg
On 10/3/2014 4:59 AM, Patrick Wang wrote: Hi, I am trying to write a C++ unit test for code that runs in child process, but all c++ tests I found run in parent process. Is it possible to write a c++ test case that runs in child process, or is there any example in our code? Could you be more

Re: c++ unit test in content process

2014-10-03 Thread Benjamin Smedberg
On 10/3/2014 9:46 AM, Patrick Wang wrote: The test I am writing is to test an implementation of WebRTC's TCP socket in content process. These codes are build on top of TCPSocket's IPDL in C++ and don't have IDL so it cannot be called directly from JS, and the tests for chrome process version

Re: Upcoming changes to Mac package layout, signing

2014-08-28 Thread Benjamin Smedberg
On 8/28/14, 1:04 AM, Dave Townsend wrote: If my reading of the patches are correct then the extension manager will start looking in the new location in the app bundle for extensions (Contents/Resources/browser/extensions) automatically. We'll have to support this as that is where the default

Re: PSA: ./mach build subdirectory doesn't work reliably any longer

2014-08-27 Thread Benjamin Smedberg
On 8/27/14, 9:47 AM, Gregory Szorc wrote: I interpret this this use case as building a related set of object files for the purpose of quick/imprecise validation of changes to a specific component. So what you really want is to build specific modules. Is that accurate? That sounds like a

Re: PSA: ./mach build subdirectory doesn't work reliably any longer

2014-08-27 Thread Benjamin Smedberg
On 8/27/14, 10:22 AM, Gregory Szorc wrote: There is additional cognitive load required to map a logical feature into a set of directories. I would prefer this burden go away, as it only breeds confusion and a higher barrier to contributing (new contributors don't know these shortcuts so they

Handing over XPCOM module ownership to Nathan Froyd

2014-08-26 Thread Benjamin Smedberg
Over the past year, Nathan Froyd has been an excellent peer for the XPCOM code module, providing thoughtful and fast reviews and guidance. I'm happy and excited to hand over ownership responsibilities to Nathan. I have been a peer/owner of XPCOM for close to ten years now, since before I was

Re: Switching to Visual Studio 2013

2014-08-23 Thread Benjamin Smedberg
On 8/23/2014 6:15 AM, Neil wrote: David Major wrote: * No more linker OOM crashes. VS2013 includes a 64-bit toolchain for 32-bit builds, so the linker will no longer be limited to 4GB address space. So will you be requiring 64-bit builders? For PGO builds, probably yes. For normal

Re: Switching to Visual Studio 2013

2014-08-22 Thread Benjamin Smedberg
On 8/22/2014 5:04 AM, xunxun wrote: And we should use VC2013 update2 or newer edition, whose PGO is faster than WPO. Yes, we had to wait for update 2 for fixes that would allow Firefox PGO builds to complete at all (there were previously internal compile errors during the link phase).

Re: Switching to Visual Studio 2013

2014-08-22 Thread Benjamin Smedberg
On 8/22/2014 10:34 AM, Gijs Kruitbosch wrote: Do we have a configure check for this so people trying this won't waste oodles of time only to get internal errors? :-) No we don't. It only affects PGO builds, which no normal person ever does, so I think the relative effort of implementing

Re: Experiment with running debug tests less often on mozilla-inbound the week of August 25

2014-08-20 Thread Benjamin Smedberg
On 8/20/2014 3:07 AM, Mike Hommey wrote: Optimized builds have been the default for a while, if not ever[1]. Bug 54828 made optimized builds the default in 2004 right before we released Firefox 1.0. It only took four years to make that decision ;-) --BDS

Re: Upcoming changes to Mac package layout, signing

2014-08-13 Thread Benjamin Smedberg
On 8/13/2014 3:34 AM, Philipp Kewisch wrote: Does this also affect binary extensions in any way? I'd imagine that globally installed extensions would break signing if placed incorrectly. You cannot place anything in the Firefox bundle. Any extensions, binary or not, would need to be

Getting rid of already_AddRefed?

2014-08-12 Thread Benjamin Smedberg
Just reading bug 1052477, and I'm wondering about what are intentions are for already_AddRefed. In that bug it's proposed to change the return type of NS_NewAtom from already_AddRefed to nsCOMPtr. I don't think that actually saves any addref/release pairs if done properly, since you'd

Re: Getting rid of already_AddRefed?

2014-08-12 Thread Benjamin Smedberg
On 8/12/2014 12:28 PM, Joshua Cranmer  wrote: But now that nsCOMPtr/nsRefPtr support proper move constructors, is there any reason for already_AddRefed to exist at all in our codebase? Could we replace every already_AddRefed return value with a nsCOMPtr? The rationale for why we still

Re: Are StaticAuto/RefPtr good?

2014-08-08 Thread Benjamin Smedberg
On 8/8/2014 11:25 AM, Ehsan Akhgari wrote: The problem I was mentioning is not related to the leak at all. What if one of these destructors runs code that writes something to the disk for example, which we expect to go to the disk before we shut down? Then we should assert in debug builds!

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Benjamin Smedberg
On 8/6/2014 1:20 PM, Chris Peterson wrote: I don't understand this sentence, but I strongly oppose automatically clearing Static*Ptr in the static destructor in any build. In the past we have had static comptr cause final release of objects after XPCOM shutdown, which causes crashes due to

Re: Deprecating localstore.rdf

2014-08-05 Thread Benjamin Smedberg
On 8/5/2014 9:14 AM, rviti...@mozilla.com wrote: What do you mean exactly by addon validation warning? I mean an rule in the AMO automated checking/validation system: normally they are simple grep rules to detect that an addon is using an obsolete interface or code pattern. This will warn on

Re: Deprecating localstore.rdf

2014-08-04 Thread Benjamin Smedberg
On 7/22/2014 8:47 AM, Roberto Agostino Vitillo wrote: Localstore.rdf will soon be replaced with a json store (see Bug 559505). I am currently planning to leave the localstore.rdf implementation as it is and issue a warning when a client tries to access to it. This is needed as some add-ons

Re: Deprecating localstore.rdf

2014-08-04 Thread Benjamin Smedberg
On 8/4/2014 5:06 PM, Gavin Sharp wrote: This is certainly a big one, but https://bugzilla.mozilla.org/showdependencytree.cgi?id=833098maxdepth=1hide_resolved=1 suggests we will still need to worry about mimeTypes.rdf and install.rdf/update.rdf, unfortunately... ok. mimeTypes.rdf is read/write

Intent to deploy: plugin timeout A/B test experiment, bug 1018200

2014-07-16 Thread Benjamin Smedberg
This is an official notice of intent to deploy the experiment in bug 1018200 to the beta channel. The experiment is an A/B test to determine the optimal value of the dom.ipc.plugins.unloadTimeoutSecs on the FF32 beta. This setting determines primarily how long we wait to unload Flash and

Re: Intent to deploy: plugin timeout A/B test experiment, bug 1018200

2014-07-16 Thread Benjamin Smedberg
On 7/16/2014 3:35 PM, Jet Villegas wrote: after a user isn't using it any more How good are we at determining any more? We start counting when the last instance for that plugin is destroyed (NPP_Destroy). --BDS ___ dev-platform mailing list

Re: PSA: Refcounted classes should have a non-public destructor should be MOZ_FINAL where possible

2014-07-10 Thread Benjamin Smedberg
On 7/10/2014 10:46 AM, Daniel Holbert wrote: First, if your class is abstract, then it shouldn't have AddRef/Release implementations to begin with. Those belong on the concrete subclasses -- not on your abstract base class. What's correct code for abstract class Foo (implementing

Re: Rethinking the crash experience

2014-07-09 Thread Benjamin Smedberg
On 7/9/2014 4:46 PM, Robert Kaiser wrote: Most probably would not type a comment when they're not immediately prompted for it. We could do an experiment around it, but I'd be surprised if anything else comes out of it. There's no reason to guess or use personal anecdotes for this. We'll do

Re: Capturing the JS stack in case of crash

2014-07-08 Thread Benjamin Smedberg
On 7/8/2014 9:25 AM, David Rajchenbach-Teller wrote: Often, we find ourselves attempting to debug JS code that causes a crash, generally by miscalling a XPCOM component that causes an assertion failure. Unfortunately, in such cases, the native stack captured gives little to no indication that

Re: Rethinking the crash experience

2014-07-08 Thread Benjamin Smedberg
On 7/5/2014 8:21 AM, David Rajchenbach-Teller wrote: Could we redesign this as follows? 1. Something goes wrong in the code of Firefox; 2. Firefox dies; 3. Crash report is stored to disk, without any dialog; 4. If the crash happened during Firefox shutdown, do nothing, otherwise restart

Re: Firefox/Thunderbird and GRE/XRE/XULRunner

2014-07-08 Thread Benjamin Smedberg
On 7/8/2014 2:51 PM, Tobias Besemer wrote: As far as I can remember, at the beginning when GRE was build, there was the try that Firefox/Thunderbird/Mozilla-Suite will use this ... After Thunderbird is now back, a Mozilla Update Service exist and the Crash Reporter needs to be re-done, but

Re: Unit testing internal JS

2014-07-07 Thread Benjamin Smedberg
On 7/7/2014 1:53 PM, Josh Matthews wrote: Garvan is referring to JS files that implement XPCOM interfaces. It's impossible to test internal details of the components without exposing them via an interface, which can end up convoluting the code in some cases. I expect you can import them

Re: Guidelines for naming preferences?

2014-07-01 Thread Benjamin Smedberg
On 6/30/2014 9:53 AM, Masayuki Nakano wrote: On 2014/06/30 22:51, Masayuki Nakano wrote: Hi, I wrote a draft of the guideline in MDN roughly. I hope a lot of developers discuss the rules and improve this draft! Oops, the draft is here. Sorry for the spam.

Re: Guidelines for naming preferences?

2014-06-20 Thread Benjamin Smedberg
On 6/19/2014 10:00 PM, Masayuki Nakano wrote: I'm looking for guidelines for naming preferences. However, I've never found it yet. I guess that there is no guidelines. That is correct. The current rule is to use common sense and coordinate with the module owner. If the pref will be exposed

Telemetry now enabled by default in the beta channel of Firefox desktop and Android

2014-06-18 Thread Benjamin Smedberg
With the 31 train going to beta last week, Firefox telemetry is now enabled by default for new and existing beta users for Firefox desktop and Firefox for Android. Existing users will see the data-choices prompt again. The beta population in particular is much more representative of our

New crash signatures for out-of-memory crashes: OOM | ...

2014-06-17 Thread Benjamin Smedberg
Starting yesterday, you will see new crash signatures for out-of-memory crashes in crash-stats. The changes were implemented in bug 1007530, but here's the summary: OOM crashes are divided into three groups: known-small, known-large, and unknown-size. The known-small crashes will all have a

Re: API propose to public place.

2014-06-17 Thread Benjamin Smedberg
On 6/17/2014 10:58 AM, luoyongg...@gmail.com wrote: At the current time, there is four function can not be accessed outside but required. You may file a bug and attach a patch for these if you wish. I presume the code you pasted below would go in nsStringAPI.h but all patches and reviews

Re: xpcom supported

2014-06-02 Thread Benjamin Smedberg
On 6/2/14, 2:38 PM, savani1ama...@gmail.com wrote: developing .so / dylib / .dll using xulrunner sdk and then calling it in extension in javascript is that still supported. i see very poor documentation on the web on it. and no good working example. Savani, you have posted variants of this same

Re: OMTC on Windows

2014-05-19 Thread Benjamin Smedberg
On 5/18/2014 3:16 AM, Bas Schouten wrote: remove a lot of code that we've currently been duplicating. Furthermore it puts us on track for enabling other features on desktop like APZ, off main thread animations and other improvements. What is APZ? Is OMTC turned on in all graphics setups,

Re: Gecko style: Braces with enums and uninons

2014-05-19 Thread Benjamin Smedberg
On 5/18/2014 11:16 PM, Dave Hylands wrote: My interpretation of this is that the only time braces go on the end of the line is when you're starting a control structure https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structures structs, enums, classes, and

Re: Adding a recommendation that one-argument constructors be explicit to the C++ style guide

2014-05-13 Thread Benjamin Smedberg
On 5/12/2014 4:07 PM, Boris Zbarsky wrote: So I'd like to propose that our C++ style require one-arg constructors to be marked explicit unless there's a clear comment explaining why the constructor is implicit. Seems there's general agreement. Please make this change to the style guide.

Re: Intent to implement: Media Source Extensions

2014-05-07 Thread Benjamin Smedberg
On 5/7/2014 2:36 AM, Matthew Gregan wrote: Summary: This specification extends HTMLMediaElement to allow JavaScript to generate media streams for playback. Allowing JavaScript to generate streams facilitates a variety of use cases like adaptive streaming and time

Re: Is there any method i can use to kill child process after killing parent process in Js

2014-05-05 Thread Benjamin Smedberg
On 5/1/2014 9:24 PM, zero wrote: i fork a process from his parent process using nsIProcess.runAsync() when i kill the parent process , the child process is untraceable. is there any method i can use to kill child process after killing parent process This is a hard problem in general.

Telemetry experiments now in nightly

2014-04-24 Thread Benjamin Smedberg
Telemetry experiments is enabled as of this morning's Nightly. Our first experiment is already live: it reorders the tiles in about:newtab so that the most-frecent tile is in the center instead of the top-left. The experiment should deploy to 25% of nightly users for a 5-day period from now

Re: Can we remove NS_HIDDEN, NS_HIDDEN_(...)?

2014-04-22 Thread Benjamin Smedberg
On 4/22/2014 7:31 AM, Robert O'Callahan wrote: It's all over the tree, inconsistently applied. Is it relevant anymore? Can we remove it entirely, or there some places where it's still relevant, and if so, where ... XPCOM? Or should we be using it everywhere? Short answer: I don't think it's

Re: Removing [PID] prefix from |make mozmill| warning/error/assertion lines?

2014-04-19 Thread Benjamin Smedberg
On 4/18/2014 7:07 PM, ISHIKAWA,chiaki wrote: Does anyone know how to disable this prefixing short of modifying the source code? Why can't you just accept this in your parsing regex? There is no runtime control for this behavior. It was made non-optional so that we could which process an

Re: Intent to Implement: Web Activities for Android

2014-04-16 Thread Benjamin Smedberg
On 4/16/2014 12:37 PM, Wes Johnston wrote: Something like this is needed for integration of B2G WebApps on Android. Without it, they have no way of talking to one another, let alone any way of talking to Native Apps. The best they can provide is launching a uri with a specific scheme and to

Re: Intent to ship navigator.sendBeacon

2014-04-16 Thread Benjamin Smedberg
On 4/16/2014 2:18 PM, Richard Barnes wrote: I don't know about problematic, but ISTM that it might be useless. If people disable sendBeacon in an effort to avoid tracking, then the trackers can always just test and polyfill with XHR. If you really want disable tracking, you're going to have

Re: MOZ_ASSUME_UNREACHABLE is being misused

2014-04-01 Thread Benjamin Smedberg
On 4/1/2014 10:54 AM, Benoit Jacob wrote: Let's see if we can wrap up this conversation soon now. How about: MOZ_MAKE_COMPILER_BELIEVE_IS_UNREACHABLE I counter-propose that we remove the macro entirely. I don't believe that the potential performance benefits we've identified are worth the

Re: MOZ_ASSUME_UNREACHABLE is being misused

2014-04-01 Thread Benjamin Smedberg
On 4/1/14 5:37 PM, Karl Tomlinson wrote: Karl Tomlinson writes: However, I would like to discourage use of MOZ_CRASH in future code unless failure to match cases in a switch is really more scary than crashing. I think in general we should be willing to make more of our assertions fatal in

Re: Firefox build (Nightly) thread with root permission

2014-03-31 Thread Benjamin Smedberg
On 3/31/14 4:56 AM, Paul wrote: Q1: Because my function is related to kernel, root privilege is necessary. Hence, I got the error message as shown in the following: root privileges needed to run this function--- What function are you talking about? Something in Firefox already, or new

Re: Too many system compartments at start-up

2014-03-21 Thread Benjamin Smedberg
On 3/21/2014 2:46 AM, Nicholas Nethercote wrote: Hi, At start-up, with a new profile, Firefox creates more than 230 system compartments. This is about 90 more than a year ago, and it's part of the reason why Firefox uses almost twice as much physical memory at start-up than it did two years

Re: Too many system compartments at start-up

2014-03-21 Thread Benjamin Smedberg
On 3/21/2014 10:34 AM, Marco Bonardo wrote: Or directly make Cu.import act like defineLazyModuleGetter... Would that be possible? I don't think that's a good idea. It's not an uncommon pattern to try/catch around a module import in case it's not present in a particular configuration or the

Re: Please do not add new web-exposed XPCOM objects

2014-03-17 Thread Benjamin Smedberg
On 3/14/2014 11:26 PM, Boris Zbarsky wrote: For non-core, if you control the Gecko you build against, then the answer is the same. If you have to work against a random Gecko, that's a problem we don't have a good solution for yet. Assuming you really need to expose the object to a web

Re: Using preferences off the main thread now asserts

2014-03-07 Thread Benjamin Smedberg
On 3/6/2014 4:05 PM, Benoit Girard wrote: Thanks for doing this. However I feel like our options for code that need preferences off the main thread are a bit poor. Yes. This is mostly intentional, because it's unusual to actually have user preferences affect threaded code behavior in ways that

Plugin whitelist

2014-03-03 Thread Benjamin Smedberg
On Friday Chad posted and blogged about our proposed plugin whitelisting policy. https://wiki.mozilla.org/Plugins/Firefox_Whitelist https://blog.mozilla.org/security/2014/02/28/update-on-plugin-activation/ The primary goal of this policy is to give plugin vendors who are working on moving

Re: Including Adobe CMaps

2014-02-27 Thread Benjamin Smedberg
On 2/26/2014 4:36 PM, Bobby Holley wrote: On Wed, Feb 26, 2014 at 12:58 PM, Wesley Hardman whardma...@gmail.comwrote: It seems like it would be trivial to add a button in the Preferences UI to let people precache all dynamically-loaded data. I don't think that would be trivial. In particular,

Re: mochitest logging changes

2014-02-27 Thread Benjamin Smedberg
On 2/27/2014 10:00 AM, Nathan Froyd wrote: - If there is a TEST-FAIL or a TEST-UNEXPECTED-PASS, then the failure itself is logged, along with some number of messages (currently capped at 100) since the start of the test or the last failure. The intent here was to provide most of the benefits

Re: Including Adobe CMaps

2014-02-26 Thread Benjamin Smedberg
On 2/26/2014 3:21 PM, Jonathan Kew wrote: On 26/2/14 19:57, Andreas Gal wrote: Lets turn this question around. If we had an on-demand way to load stuff like this, what else would we want to load on demand? A few examples: Spell-checking dictionaries Hyphenation tables Fonts for additional

Re: Platform SDK: What do we really want it to be?

2014-02-10 Thread Benjamin Smedberg
On 2/6/2014 2:08 AM, ajvinc...@gmail.com wrote: I recently submitted a bug and patch to copy the stub executable and application bundling script (install_app.py) from XULRunner to Firefox. Mike Hommey (glandium) thinks that's a bad idea. [2] His objection is that that just makes it stay

WebAudio popping

2014-02-01 Thread Benjamin Smedberg
Not sure if there's a better group to ask about WebAudio stuff specifically. Is there a way to keep WebAudio from popping when I start/stop an oscillator or change gain? The WebAudio spec claims that changes in gain should be dezippered to avoid popping, but that doesn't seem to happen in

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-31 Thread Benjamin Smedberg
On 1/30/2014 7:25 PM, Nicholas Nethercote wrote: One of my primary goals with starting this discussion was to reach agreement that mass style fixes (e.g. covering entire files) are acceptable. I agree. We should focus our efforts on converting whole files of code to our new style and then

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-29 Thread Benjamin Smedberg
On 1/27/2014 7:08 PM, Nicholas Nethercote wrote: It's been a couple of weeks now. Can we move forward? Anthony Jones has done some work on using clang-format to restyle lines that have changed in a file, but I don't think anyone has done any evaluation of clang-format for whole-file changes.

Telemetry Experiments: experiment, A/B, and questionnaire implementation in Firefox

2014-01-28 Thread Benjamin Smedberg
One of the things I have been looking at in some detail recently is how we can use qualitative measurements in Firefox. This includes better integration of existing Telemetry and FHR systems, but also measurements which don't fit into those systems. Part of my study was prompted by a request

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Benjamin Smedberg
On 1/17/2014 4:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. Does this mean that the moving GC is also enabled, or is that a later step? If we see an increase in the crash rate for nightly builds, is it likely that they will share a

Re: Terminating xulrunner?

2014-01-14 Thread Benjamin Smedberg
On 1/14/2014 2:30 PM, mka...@gmail.com wrote: On Tuesday, January 14, 2014 1:06:19 PM UTC-6, Benjamin Smedberg wrote: Or do a repack to remove the Firefox-specific files from a Firefox install. Certainly without branding issues it's not a problem anyway, right? So in my testing, this worked

Re: Terminating xulrunner?

2014-01-14 Thread Benjamin Smedberg
On 1/14/2014 3:17 PM, ajvinc...@gmail.com wrote: I'd like to get a clarified list of requirements for the Firefox SDK: * Will we support a stub executable? If somebody writes a patch to include a stub executable in the SDK, I will accept that patch. If you include automated tests for it, I'll

Re: Terminating xulrunner?

2014-01-13 Thread Benjamin Smedberg
On 1/12/2014 7:34 PM, Mike Hommey wrote: Hi, I propose that we just stop pretending, and terminate xulrunner, considering the following: This has in fact been the plan for a while now. The only reason we continue to do any regular XULRunner builds at all is because we do need to publish an

Re: Style guide clarity on C++-isms

2014-01-13 Thread Benjamin Smedberg
On 1/13/2014 2:33 PM, Milan Sreckovic wrote: I didn't mean no inlining :), I was just talking about the format: class A { public: inline int hello { return 4; } }; vs. class A { public: inline int hello(); }; inline int A::hello() { return 4; } We're pretty far from the

Re: Sharing string literals

2014-01-10 Thread Benjamin Smedberg
On 1/10/2014 12:19 AM, Daniel Holbert wrote: Just to be clear -- does this mean we should strictly prefer str.Assign(NS_LITERAL_STRING(foo)) over str.AssignLiteral(foo) now? For wide strings, I'm pretty sure the pattern we want is AssignLiteral(MOZ_UTF16(foo)). And as Henri mentioned, we

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2014-01-07 Thread Benjamin Smedberg
On 1/6/2014 7:43 PM, smaug wrote: Why this deprecation? Karl is right, we are removing the macros that hide control flow (as well as warnings, in this case). I'm considering the NS_WARN_IF_FAILED(rv) proposal. It's obviously a less typing then NS_WARN_IF(NS_FAILED(rv)), but I'm not

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-07 Thread Benjamin Smedberg
On 1/5/2014 9:34 PM, Nicholas Nethercote wrote: I propose that we officially remove this implicit discouragement, and even encourage changes that convert non-Mozilla-style code to Mozilla-style (with some exceptions; see below). When modifying badly-styled code, following existing

Style guide clarity on C++-isms

2014-01-07 Thread Benjamin Smedberg
There are a few C++-isms which vary widely across the tree and I'd like to clarify before we start any major refactorings. 1) Bracing of method bodies in a C++ class declaration Currently, C++ method bodies inline within a class declaration are documented to start on the next line, e.g.

Re: Reacting more strongly to low-memory situations in Firefox 25

2013-12-12 Thread Benjamin Smedberg
= Data and Background = See, as some anecdotal evidence: Bug 930797 is a user who just upgraded to Firefox 25 and is seeing these a lot. dmajor tracked this down to our video implementation creating many threads, each of which has an x86 stack as well as a 1MB memory reservation for the

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread Benjamin Smedberg
On 12/10/2013 9:49 AM, Benoit Jacob wrote: std::set compared to using a hashtable to do the same thing, since AFAIK we don't have a HashSet class in mfbt or xpcom. nsTHashtableKeyType is the XPCOM hashset. --BDS ___ dev-platform mailing list

Re: Can we start using C++ STL containers in Mozilla code?

2013-12-10 Thread Benjamin Smedberg
On 12/10/2013 4:28 AM, Chris Pearce wrote: Hi All, Can we start using C++ STL containers like std::set, std::map, std::queue in Mozilla code please? Many of the STL containers are more convenient to use than our equivalents, and more familiar to new contributors. njn already mentioned the

Re: Should we disable autoplay feature of HTMLMediaElement on mobile?

2013-12-09 Thread Benjamin Smedberg
On 12/8/2013 4:31 AM, Tetsuharu OHZEKI wrote: I welcome your feedback to polish Firefox for mobile and web. Note that autoplay is not the most interesting case, because most of the top video sites don't actually use it; instead they use a scripted .play() call on load.

DLLs with missing symbols that make crash signatures less useful

2013-12-09 Thread Benjamin Smedberg
With some recent improvements in crash-stats data[1], we now have the ability to report on which crashes don't have the necessary symbols to produce a useful crash signature. I have generated the following reports from yesterday's crash data:

Re: Reacting more strongly to low-memory situations in Firefox 25

2013-11-26 Thread Benjamin Smedberg
On 11/25/13 8:15 PM, Bas Schouten wrote: I'm a little confused, when I force OOM my firefox build on 64-bit windows it -definitely- goes down before it reaches more than 3GB of working set. Am I missing something here? I think so. I did not mention working set at all. I am merely calculating

Reacting more strongly to low-memory situations in Firefox 25

2013-11-25 Thread Benjamin Smedberg
In crashkill we have been tracking crashes that occur in low-memory situations for a while. However, we are seeing a troubling uptick of issues in Firefox 23 and then 25. I believe that some people may not be able to use Firefox because of these bugs, and I think that we should be reacting

Re: Reacting more strongly to low-memory situations in Firefox 25

2013-11-25 Thread Benjamin Smedberg
On 11/25/2013 12:11 PM, Ehsan Akhgari wrote: Do we know how much memory we tend to use during the minidump collection phase? No, we don't. It seems that the Windows code maps all of the DLLs into memory again in order to extract information from them. Does it make sense to try to reserve an

Re: Reacting more strongly to low-memory situations in Firefox 25

2013-11-25 Thread Benjamin Smedberg
On 11/25/2013 1:09 PM, Ryan VanderMeulen wrote: So we're clear, this analysis is of 32bit Firefox builds running a 64bit Windows OS, right? So the process is still limited to 4GB of address space. Wouldn't a native 64bit Firefox build have significantly higher address space available to it?

Is for...of on a live DOM node list supposed to do the right thing?

2013-11-22 Thread Benjamin Smedberg
Is for..of on live DOM nodelists supposed to correctly iterate even when items are removed from the list? I have a testcase where this does not seem to be working correctly: http://jsfiddle.net/f8xzQ/ Is there a simple way to do this correctly? --BDS

<    1   2   3   >