Re: Replace password encryption SHA-1 by SHA-512

2016-12-14 Thread Scott Gray
Maybe ask LinkedIn, Zappos, Evernote, Living Social or Adobe if it's prudent to assume that no one will ever get hold of your password hashes. One researcher was able to recover 80% (~140 million) of passwords from the LinkedIn breach in a single day, they were using unsalted SHA1. Regards Scott

Re: Serialized Inventory issue with backorder item

2016-12-22 Thread Scott Gray
+1 on binding status to InventoryItemDetail. Regards Scott On 22 December 2016 at 21:50, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Very interesting thread, thanks to you all for the valuable exchange of > information. > > My two cents: > * it would be great to refactor Se

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java

2016-12-28 Thread Scott Gray
I guess it depends on how this will be used but I think there is a big difference between " // do not validate results with errors" and returning false from an isValid method. IMO an error output response is perfectly valid. Regards Scott On 28 December 2016 at 21:47, wrote: > Author: jleroux

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/Model Service.java

2016-12-29 Thread Scott Gray
cause it's used >>>> before running the service. >>>> I guess it's how it should be used (why running isValid() before >>>> running?). So I guess we can simply use that >>>> >>>> public boolean isValid(Map context, String mode, >>>> L

Re: Proposal to rename specialpurpose to plugins

2017-01-02 Thread Scott Gray
What's the plan for the hot-deploy folder? Remove it? Regards Scott On 3 January 2017 at 08:26, gil portenseigne wrote: > +1 > > Gil > > > > On 02/01/2017 17:45, Taher Alkhateeb wrote: > >> Hello Everyone, >> >> In reference to earlier discussions and threads on the above subject, I am >> here

Re: Proposal to rename specialpurpose to plugins

2017-01-02 Thread Scott Gray
nd prepare > a mechanism for handling plugins. Perhaps we can start aanother thread to > discuss the next steps moving forward. > > Cheers, > > Taher Alkhateeb > > On Jan 2, 2017 11:02 PM, "Scott Gray" > wrote: > > > What's the plan for the hot-

Re: Proposal to rename specialpurpose to plugins

2017-01-03 Thread Scott Gray
e a massive amount of lib dependencies and some entanglements with > core. > > On Jan 2, 2017 11:42 PM, "Scott Gray" > wrote: > > > Ok thanks, it just wasn't clear to me. > > > > My only concern with renaming it just for the sake of renaming it is t

Re: What is the "Apache OFBiz" product?

2017-01-12 Thread Scott Gray
I prefer "Business" to "ERP" or "Enterprise" but I'm not sure about the repeating syllables involved in saying "Apache OFBiz Business {thing}". The biz biz doesn't flow well so I'm inclined to fall back to "Enterprise". Another adjective to consider over "framework" might be "platform". The frame

Re: MODERATE for dev@ofbiz.apache.org

2017-01-16 Thread Scott Gray
Did you check if the email in the body was subscribed? ad...@officefans.net Regards Scott On 16 January 2017 at 20:52, Jacques Le Roux wrote: > Hi, > > We receive a lot of the forwarded email (attachment) in the OFBiz dev ML. > Since ad...@fcc-foshan.com is not registered they are moderated and

Re: Use ecomseo on demo rather than ecommerce

2017-01-22 Thread Scott Gray
gt;> >> Le 22/09/2016 à 14:07, Jacques Le Roux a écrit : >> >>> Le 22/09/2016 à 13:22, Scott Gray a écrit : >>> >>>> This mostly to somehow battle test it, even if I know it works well >>>>> >>>> So does it need battle testing

Re: Use ecomseo on demo rather than ecommerce

2017-01-22 Thread Scott Gray
wrote: > OK, I'll answer your questions step by step. I just need time... > > Jacques > > > Le 22/01/2017 à 22:01, Scott Gray a écrit : > >> 1. Ask for input >> 2. Get no responses except a -1 >> 3. Wait for a few months >> 4. Proceed anyway without fu

Re: Does the deleteWorkEffort really always works?

2017-01-22 Thread Scott Gray
What comments are you looking for? It either works or it doesn't. A couple of things to consider: - Is there really a good reason to delete a WorkEffort record when changing its status should be sufficient? - Maybe it doesn't work now because the data model has changed since it was introduced? -

Re: svn commit: r1780790 - in /ofbiz/trunk: common.gradle plugins/component-load.xml plugins/ebaystore/ofbiz-component.xml

2017-01-29 Thread Scott Gray
Hi Pierre, It was disabled and it is still disabled, the only change relevant to ebaystore is the means of disablement. I'm not sure what needs to be re-thought? Eventually someone will decide that addressing the 3rd party library issues in ebaystore is an itch they want to scratch, but until th

Re: svn commit: r1780790 - in /ofbiz/trunk: common.gradle plugins/component-load.xml plugins/ebaystore/ofbiz-component.xml

2017-01-29 Thread Scott Gray
Scott On 30 January 2017 at 09:54, Pierre Smits wrote: > Maybe removing code that doesn't work from the code base? > > Best regard, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace

Re: buildbot failure in on ofbiz-trunk

2017-01-30 Thread Scott Gray
Try and be patient Jacques, I'm also having trouble understanding what you are saying. Here's what I've been able to understand so far: - Pre-gradle OFBiz tests run fine on buildbot - Gradle OFBiz fails on buildbot with a complaint that the default ports are in use - The test framework in OFBiz ha

Re: Git for commiters

2017-02-18 Thread Scott Gray
I've been using git-svn for years, I don't think my setup involved as many steps as that document shows though. I think I just started from git svn init. The main advantages for me was to be able to stash works in progress and to make multiple local commits before pushing to svn. Regards Scott

Re: Git for commiters

2017-02-19 Thread Scott Gray
Well it's been a while since I worked on the trunk but yes, I would still use git svn for the work. Regards Scott On 19/02/2017 21:18, "Jacques Le Roux" wrote: Thanks Scott, Do you mean you are still using it, or? Jacques Le 18/02/2017 à 23:03, Scott Gray a écrit : > I

Re: Git for commiters

2017-02-28 Thread Scott Gray
setup who put it in place more recently? Regards Scott On 19 February 2017 at 22:22, Jacques Le Roux wrote: > OK thanks, so would you say that the steps in the document are too much > and you could change them or it's OK and up to date as is? > > Jacques > > > > Le 1

Re: [discussion] With plugins, is hot-deploy necessary?

2017-03-04 Thread Scott Gray
I imagine it would be fairly simple to add another top level folder with the same functionality as plugins if desired. Easy enough that we don't have to include it out of the box. On 5/03/2017 03:42, "Wai" wrote: > Either way is fine for me. I'll name my components directories in 'plugins' > wit

Default theme (WAS: [proposal] actions to take with plugins)

2017-03-12 Thread Scott Gray
We seemingly couldn't agree on the best logo either, yet we have only one. I think an instant run-off vote ( https://en.wikipedia.org/wiki/Instant-runoff_voting) would probably be the most appropriate way to come to a conclusion, given the large number of themes and relatively small number of votes

Re: svn commit: r1786919 - in /ofbiz/ofbiz-framework/trunk/applications/accounting/widget: FieldLookupForms.xml LookupScreens.xml

2017-03-16 Thread Scott Gray
I'm not familiar with the work Adrian did any subsequent work but I do believe the basis of the idea has merit. While there are some similarities between a form and a table, I think there are enough differences that it would be easier to move forward with new features specific to one or the other

Re: Drop plugins/birt/webapp/birt/webcontent ?

2017-03-24 Thread Scott Gray
I'm curious as to how it was ever added, when the birt component was first introduced I'm pretty sure we agreed to not include this part of it because of licensing concerns. On 25 March 2017 at 02:34, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Thu, Mar 23, 2017 at 10:01

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

2017-03-24 Thread Scott Gray
I agree with Jacopo, these are very functional changes that shouldn't be made without understanding the workflow. It's good to clean up the code but it shouldn't be done blindly. On 25 March 2017 at 02:13, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Fri, Mar 24, 2017 at

Re: svn commit: r1789863 - /ofbiz/ofbiz-framework/trunk/applications/content/widget/content/DataResour ceForms.xml

2017-04-03 Thread Scott Gray
I agree with Jacques and Deepak. The code is an improvement on what was there, end of story. A contributor is a volunteer who is free to do as much or as little as they please so long as each contribution is a full step forward. Regards Scott On 3/04/2017 17:13, "Deepak Dixit" wrote: > I agree

Date filtered queries shouldn't be cached

2017-04-05 Thread Scott Gray
In the current project I'm working on I see a lot of developers making the mistake of caching date filtered queries. Why shouldn't you cache date filtered queries? 1. If you're filtering by the current moment in time then the results are irrelevant within a few moments of them being retrieved. So

Re: Date filtered queries shouldn't be cached

2017-04-06 Thread Scott Gray
> it seems to be quite a specific workaround as opposed to a generic > solution. Shouldn't we instead have something that works for all dates > instead of just specific dates with the name "fromDate" when compared with > current date / time? > > On Thu, Apr 6, 2017

Re: Validating telecom numbers

2017-04-14 Thread Scott Gray
I think Google has a phone number library that could be put to use to take the heavy lifting off our shoulders. Regards Scott On 15/04/2017 00:53, "Pierre Smits" wrote: > For (to be) OFBiz definitions, I suggest to review ITU and country policies > regarding the various kinds of telephone defin

Re: svn commit: r1792270 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/quote/QuoteServices.xml servicedef/services_quote.xml

2017-04-24 Thread Scott Gray
Having tests setup and teardown the data they need would possibly allow us to run test suites in parallel which would dramatically decrease the processing time. I like having the tests depend on the database though, in the past it's been helpful for spotting deadlocks. Regards Scott On 24 April

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

2017-04-27 Thread Scott Gray
Could you expand on that please Taher? The tests are run once all demo data is loaded are they not? Regardless, I appreciate this effort as it's long overdue. Regards Scott On 28/04/2017 00:13, "Taher Alkhateeb" wrote: > Does not work, it will fail tests if you put them in that order. Feel fre

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

2017-04-29 Thread Scott Gray
I would prefer they were left assigned to the committer since the onus tends to fall on them if there are any post closure issues. My guess if that Pierre wants to track what tickets he contributed to beyond being the reporter. Could you confirm Pierre? Beyond what I've mentioned is there any ot

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

2017-05-02 Thread Scott Gray
based solutions & services >> >> OFBiz Extensions Marketplace >> http://oem.ofbizci.net/oci-2/ >> >> On Sun, Apr 30, 2017 at 10:18 AM, Michael Brohl > > >> wrote: >> >> Hi Scott, >>> >>> thanks for trying to clarify and gi

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

2017-05-02 Thread Scott Gray
). > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Tue, May 2, 2017 at 10:15 AM, Scott Gray > wrote: > > &

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

2017-05-03 Thread Scott Gray
ut if you feel that strong about it, I suggest you > find out. > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Wed, Ma

Re: Broken pipe (write failed) [BUG]

2017-05-07 Thread Scott Gray
I've seen that error before when one of two things happened: 1. Apache timed out waiting for a response from OFBiz 2. The client (browser) cancelled the request before OFBiz was able to respond. e.g. the user closed the browser or refreshed or navigated away. So it isn't a bug as such, it's more a

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.02

2017-05-16 Thread Scott Gray
+1 Regards Scott On 16 May 2017 at 20:11, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > This is the vote thread to release a new bug fix release for the > release16.11 branch. This new release, "Apache OFBiz 16.11.02" will > supersede the 16.11.01 release. > > The release fi

Re: svn commit: r1798104 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntityListIterator.java

2017-06-11 Thread Scott Gray
Isn't a stacktrace pointless given that this would happen during finalize? It wouldn't say anything about where the problem is. Regards Scott On 10/06/2017 07:21, "Jacques Le Roux" wrote: > Actually I just added "\n Please report by creating an OFBIZ-9297 subtask > with the stack trace, thanks"

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Scott Gray
The project I'm currently on is actively using clustering (session replication) and I know for certain this isn't the only project nor are we the only vendor to use it. I'm using an older version of OFBiz though so I can't confirm if the latest codebase has it working. It can be tricky to set up

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-19 Thread Scott Gray
;> > >>> On Tue, Jun 13, 2017 at 9:17 AM, Taher Alkhateeb < > >>> slidingfilame...@gmail.com > >>> > >>>> wrote: > >>>> So the good thing is that the refactoring exercise surfaced this > issue. > >>>> Based on feedback from Sc

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2017-06-28 Thread Scott Gray
Hi Taher, I can understand your frustration, but this: > This commit is wrong and bad on multiple levels. Please revert is an unproductive and unreasonable request. Whether you want to or not, you have to justify the request. Obviously the developer doesn't know what is wrong or they wouldn't

Re: svn commit: r1800245 - in /ofbiz/ofbiz-framework/trunk/applications/accounting: groovyScripts/rate/RateServices.groovy minilang/rate/ servicedef/services_rate.xml

2017-07-03 Thread Scott Gray
Hi Nicolas, My first code review in a while so I apologize if I'm wrong on any points, or if they've been discussed already. 1. It would be good if the services were converted one per commit, with the empty minilang file removed at the end with a separate commit. That would allow reviewers to co

Re: [Discussion] Failing the build if data loading fails

2017-07-09 Thread Scott Gray
I don't mind if the behavior changes, but it's never bothered me since the information is only a few lines above the build's success/fail message. Or at least, it was with the ant build system, I haven't tried with gradle recently enough to recall. Regards Scott On 10 July 2017 at 07:18, Taher A

Re: Rule to deprecated a service

2017-08-06 Thread Scott Gray
+1 for logging a warning instead of an error +1 for using an element to deprecate. Although I'd prefer "deprecated" for the element name and I'd prefer "use-instead" for the attribute name. Would keep us consistent with java conventions, @deprecated and the text is often "use X instead". I think

Re: Quantity UOM in Supplier Product

2017-08-10 Thread Scott Gray
Hi Vaibhav, It's a good question and mailing list archives (that are available) don't really answer the question clearly. At the moment as far as I can tell, the quantityUomId and unitsIncluded field do nothing, they're display only. I think SupplierProduct.unitsIncluded is the same as Product.q

Re: Rule to deprecated a service

2017-08-10 Thread Scott Gray
; the first release of the last freezed branch > > Opinions? > > Jacques > > > Le 07/08/2017 à 00:02, Scott Gray a écrit : > >> Some additional nice to haves: >> - Add a "since" attribute to the "deprecated" element that would contain >> ei

Re: Quantity UOM in Supplier Product

2017-08-13 Thread Scott Gray
Hi Vaibhav, Comments inline. Regards Scott On 11 August 2017 at 02:55, Vaibhav Jain wrote: > Thank you so much Scott for sharing these details, indeed they are really > helpful. > Kindly see my comments inline. > > > On Thu, Aug 10, 2017 at 3:22 PM, Scott Gray > wr

Re: Remove Order data model dependency for POS sales

2017-08-31 Thread Scott Gray
It's also used for pricing rule and promotion capabilities. Laybys/layaways, rainchecks and purchases on account also would benefit from the order model. If POS were extended to hospitality that would also rely on an order model. Regards Scott On 29/08/2017 23:29, "Arun Patidar" wrote: > Hello

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java

2017-09-04 Thread Scott Gray
Definitely changes the behavior, but the behavior wasn't good before (and still isn't good now). If we can't return an accurate order item sub-total then we should be throwing an exception IMO. This is often why we can't just bulk fix the issues reported by static analysis tools, because the fix

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Scott Gray
Since this is such a complex problem perhaps we better come up with a best practice since we have so many Helper/Worker/Reader classes in OFBiz and a bit of API consistency goes a long way. If a GenericEntityException is thrown within a Helper/Worker/Reader class method, how should we handle it?

Re: Services with no definition and usage

2017-09-11 Thread Scott Gray
I'm in favor of keeping them and adding the service definitions. As Taher mentions, these are CRUD services and IMO if we have the table, we should have the set of services allowing management of the data. These implementations are quite synonymous with the FacilityContactMech services, they're o

Re: All roleType entities should maintain lifespan

2017-09-29 Thread Scott Gray
Hi Suraj, I still haven't seen an example of a useful use case for adding from/thruDate fields to the PartyRole table. Did you have anything in mind that it might help with? I'd honestly prefer to remove it rather than expand it. Regards Scott On 29 September 2017 at 20:41, Suraj Khurana < sur

Re: svn commit: r1811699 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofb iz/service/config/model/ThreadPool.java

2017-10-12 Thread Scott Gray
Honestly I think the topic is generic enough that OFBiz doesn't need to provide any information at all. Thread pool sizing is not exclusive to OFBiz and it would be strange for anyone to modify the numbers without first researching sources that provide far more detail than a few sentences in our c

Re: Updates to EntityQuery

2017-10-25 Thread Scott Gray
I think it's better to have for-update available for use for the majority of use-cases than it is to exclude it altogether. I'd rather lose the databases that don't support it than constrain the ones that do and are used most by pretty much everyone. It would be nice to hear from anyone using a d

Re: Unable to Launch 16.11.x in Isolation

2017-11-14 Thread Scott Gray
Yeah I learned this one the hard way after boarding a 12 hour flight. Fortunately I had a few old copies of OFBiz lying around from back in the good old days. Regards Scott On 15 November 2017 at 05:15, Michael Brohl wrote: > Reminder to self: update the (great) README.md for this switch :-) >

Re: Service returning incorrect records

2017-11-15 Thread Scott Gray
I'm in favor of removing, it's been there since at least 2003 and is most likely from a legacy search screen that has since been superseded. Regards Scott On 15 November 2017 at 21:14, Suraj Khurana wrote: > Thanks, Jacques and Michael for your inputs, > > I agree with both the points, either s

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Scott Gray
I agree with Paul that FinAccountTrans shouldn't reference orderId or returnId. I have nothing to add, his reasoning is spot on. Regards Scott On 21 November 2017 at 16:56, Paul Foxworthy wrote: > Hi Vaibhav, > > I'm really uncomfortable about this. > > As Pierre said, FinAccountTrans is for a

Re: Permission overrides auth parameter of service

2017-11-29 Thread Scott Gray
auth="false" and a permission service are completely incompatible scenarios. In what situation could you possibly have no userLogin and successfully run a permission service? What would you expect to happen instead of the current behavior? Regards Scott On 3 November 2017 at 17:35, Suraj Khuran

Re: [OFBIZ] - Job schedules and Multi instance

2018-01-02 Thread Scott Gray
You can treat each instance as a separate pool in serviceengine.xml, so that instance A sends jobs and runs jobs from poolA and instance B uses poolB. Regards Scott On 3/01/2018 03:04, "Nicolas Malin" wrote: When a job is created by an instance, there are no information on who will be run it

Re: [DISCUSSION] Disentanglement of the ExampleExt component

2018-01-07 Thread Scott Gray
I'm not familiar with commonext or exampleext, but the purpose of the entity-ext component was to allow the entity engine to exist without the service engine. That's why all the entity-related logic that relies on the service engine is implemented there (EECAs, EntitySync, DCC). The alternative w

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Scott Gray
I'm in favor of the status quo. It's useful to have them available out of the box to be able to pick the one you need and proceed without having to look elsewhere. The same goes for the fieldtype definitions. Regards Scott On 8/01/2018 6:26 AM, "Pierre Smits" wrote: We could consider having ex

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Scott Gray
The argument was that the configs weren't being used by default, so the same would, in theory, apply to those files. Regards Scott On 9/01/2018 5:14 AM, "Jacques Le Roux" wrote: Le 08/01/2018 à 01:36, Scott Gray a écrit : > The same goes for the fieldtype definitions. >

Re: [DISCUSSION] Disentanglement of the ExampleExt component

2018-01-08 Thread Scott Gray
ity-core-impl.jar: entity engine available to > > legacy applications (built from scratch) > > 2) service-core-api.jar + service-core-impl.jar: service engine available > > to legacy applications (built from scratch) > > 3) entity-core-api.jar + entity-core-custom impl.jar: cus

Re: Permission overrides auth parameter of service

2018-01-23 Thread Scott Gray
t; >> If an service implements and do checks for the permissions then it must > >>> have the auth set as true. If any occurrences found then it should be > by > >>> mistake and service definition should be fix to match. > >>> > >>> So I th

Re: [Proposal] OR search criteria within performFind

2018-02-07 Thread Scott Gray
A little bit off topic but I recently wrote an EntityCondition converter for use with the rsql-parser[1] library. Using it on an html client to write free-form queries would need some javascript wizardry but it's worth looking at if we ever wanted to implement something like Jira's JQL capability.

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-09 Thread Scott Gray
Every code change is at a minimum an improvement. Our other tags are just more specific improvements e.g. a fix is an improvement to something that was previously broken. Regards Scott On 9/02/2018 06:19, "Jacques Le Roux" wrote: > I use completed for these cases because it's not really an impr

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-19 Thread Scott Gray
Jacques, as a first step, please consider not using "no functional change" any longer. It used to be that it was simply used for basic formatting fixes, but now that I look closer, I notice you've had a trend going for a while now that you're using it for anything you consider to be minor. Example

Re: svn commit: r1825436 - /ofbiz/ofbiz-framework/trunk/framework/security/ofbiz-component.xml

2018-02-28 Thread Scott Gray
Hi Taher, I'm not sure I understand or if something has changed in the last few years but seed-initial should always expect to be loaded after seed data so it shouldn't be a problem for seed-initial to depend on seed data. You would never just load seed-initial into an empty database. Regards Sc

Re: svn commit: r1825436 - /ofbiz/ofbiz-framework/trunk/framework/security/ofbiz-component.xml

2018-02-28 Thread Scott Gray
order of > writing the readers in the command line. There are still some issues > in other areas of loading, so I need to study it a bit further. > > On Thu, Mar 1, 2018 at 12:46 AM, Scott Gray > wrote: > > Hi Taher, > > > > I'm not sure I understand or if someth

Re: buildbot failure in on ofbizTrunkFramework

2018-03-13 Thread Scott Gray
It's easy to just search the log output for "JUNIT (failure)", which reports this test failed: 2018-03-13 13:18:52,725 |main |TestRunContainer |W| [JUNIT (failure)] - auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier : Assertion failed: [acctgTr

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
Hi Rajesh, It looks like the XmlRpcEventHandler class doesn't support this but it could easily be modified to do so. I'd suggest filing a ticket, and perhaps even providing a patch :-) The tenantId just needs to be derived from the url and then passed into the userLogin service in the OfbizRpcAu

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
request.getAttribute("delegator"); > if (report != null) { > BufferedReader reader = null; > StringBuilder buf = new StringBuilder(); > try { > // read the inputstream buffer > > > > On Thu, Mar

Re: Demo Trunk Break

2018-03-15 Thread Scott Gray
I guess what Michael is getting at, is that the demo server is for demos, it's not intended for use as a development sandbox. As far as I can tell you don't *need* to be using the demo servers for this, it's just convenient for you. But the problem is, if you're modifying the code on the demos an

Re: Demo Trunk Break

2018-03-16 Thread Scott Gray
mporary poor man solution. I have no other domain > available. > > Jacques > > > Le 16/03/2018 à 03:08, Scott Gray a écrit : > >> I guess what Michael is getting at, is that the demo server is for demos, >> it's not intended for use as a development sandbox. &

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Scott Gray
Something else must be wrong Jacques, I can't understand what you're saying in the ticket description or in your reply above but I do know the following: OFBiz is perfectly capable of knowing that org.apache.catalina.connector.RequestFacade implements the javax.servlet.http.HttpServletRequest and i

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-23 Thread Scott Gray
Scott On 23 March 2018 at 07:36, Jacques Le Roux wrote: > Did you try what I said? > > You can easily check by svn updating to r1819133 and removing the wrapper > in ContextFilter.java. > > Maybe we need to revert Tomcat SSO then? > > Jacques > > > >

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-24 Thread Scott Gray
expensive. I'm also not even sure if our custom ObjectType methods for checking this type of thing are necessary any more with so many new java versions since it was decided these were needed for performance reasons. Regards Scott On 24 March 2018 at 10:59, Jacques Le Roux wrote: > Le

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-24 Thread Scott Gray
side there. e.g. UtilValidate.isHttpServletRequest(Object request) { // do the new test here } In the service definition: That would solve the problem for now until the service engine is improved and tested or the tomcat SSO login design is improved. Regards Scott On 24 March 2018 at 17

Fwd: [jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements

2018-03-25 Thread Scott Gray
s are discussed in the dev mailing list. It's also absolutely critical that issues raised in review are discussed rather than ignored, nothing should ever be committed when the only reviews are doubtful ones. Regards Scott -- Forwarded message ------ From: Scott Gray (JIRA) Date:

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-26 Thread Scott Gray
Yeah, I said exactly that elsewhere in the same email. Regards Scott On 26 March 2018 at 21:17, Jacques Le Roux wrote: > Le 24/03/2018 à 18:49, Scott Gray a écrit : > >> I'm also not even sure if our custom ObjectType methods for checking this >> type of thing are nec

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Scott Gray
It would be good to leave it on somewhere in the system like the example entities maybe On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, wrote: > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : > > I'm not sure about the field in the entity component though! it > > might be needed in some unit tests?

Re: Deprecate properties in favour of SystemProperties

2018-04-04 Thread Scott Gray
If there's an ongoing discussion on the dev list then I don't think it's a good idea to try to move it to jira until there's some consensus on the path forward. Regards Scott On 4 April 2018 at 10:14, Taher Alkhateeb wrote: > I am a little lost in this JIRA and cannot follow the discussion. Can

Re: Deprecate properties in favour of SystemProperties

2018-04-05 Thread Scott Gray
then renaming > the > > SystemProperty entity to BusinessProperty is necessary. Having a specific > > UI for DB access for these properties is also necessary. I foresee the > > webtools as the best place for this UI. It should be accessible by > tenants. > > > >

Re: Check for only QOH while doing reservations

2018-04-06 Thread Scott Gray
Hi Suraj, I haven't reviewed the code in question so I don't have any comment at this stage. But one thing I want to point out is that OFBiz has many years of history available in commit logs, jira and mailing lists. It's often quite a simple task to look back over that history and determine why a

Re: Confusing entity names

2018-04-18 Thread Scott Gray
Just to throw in my 2 cents, I don't think the naming is so confusing that it warrants changing. The number of replies in this thread highlights that it isn't a straightforward thing to change, and personally I don't think the names are so bad that it's worth any of the pain that might come from c

Re: svn commit: r1830236 - /ofbiz/ofbiz-framework/trunk/framework/webtools/widget/ServiceForms.xml

2018-04-26 Thread Scott Gray
Hi Gil, Maybe I'm missing something but crashed jobs are reset at the same time that they're marked as crashed (during startup). I don't have the latest code in front of me but it used to be in JobManager.reloadCrashedJobs(). Basically when an instance restarts, any jobs marked as running are move

Re: svn commit: r1830236 - /ofbiz/ofbiz-framework/trunk/framework/webtools/widget/ServiceForms.xml

2018-05-01 Thread Scott Gray
issing to offer a way to reset it, i guess > it was > > no harm to commit it into trunk... > > > > I will look for an explanation of our issue soon, to check if there is > > something to fix. > > > > Now that I understand better the crashed job mechanism, i&#

Re: [Proposal] Make accounting entry configurable

2018-05-07 Thread Scott Gray
Another additional option we could consider at some point is to extract the GL out to it's own component. It would simplify evaluation for people who do want to use it, and removal for that don't or replacement for anyone who wants to use something else. Regards Scott On Thu, 3 May 2018, 18:12 Am

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-14 Thread Scott Gray
I think no matter what we use someone will always want something different. I'm beginning to lose count of the number of custom APIs I've written over the years to support custom UIs. I think the bigger win would be to start providing APIs and rewriting our existing screens to use them. From there

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-14 Thread Scott Gray
On Mon, 14 May 2018, 20:38 Taher Alkhateeb, wrote: > Hello Scott, thank you for your thoughts, inline ... > > On Mon, May 14, 2018 at 10:45 AM, Scott Gray > wrote: > > I think no matter what we use someone will always want something > different. > > I'm beginnin

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-15 Thread Scott Gray
would appreciate a bit more elaboration to get a better understanding of > your point of view since this seems to be a critical architectural > decision. > > > On Mon, May 14, 2018, 9:39 PM Scott Gray > wrote: > > > On Mon, 14 May 2018, 20:38 Taher Alkhateeb, > > w

License issue with iText 4.2.0

2018-06-07 Thread Scott Gray
Hi All, I just noticed that the iText maven bundle is a bit tricksy and includes iText 5.6.6 as a dependency, with the latter being GPL licensed. You can see it by running "./gradlew -q dependencies": +--- com.lowagie:itext:4.2.0 |\--- com.itextpdf:itextpdf:5.5.6 I haven't checked to see if

Re: License issue with iText 4.2.0

2018-06-08 Thread Scott Gray
under the Affero General > Public License > >> <https://en.wikipedia.org/wiki/Affero_General_Public_License> version > 3.>> > >> > >> MPL being OK as binary > >> > >> Jacques > >> > >> Le 08/06/2018 à 03:57

Re: License issue with iText 4.2.0

2018-06-08 Thread Scott Gray
; exclude 'com.itextpdf:itextpdf:5.5.6' > } > > On Fri, Jun 8, 2018, 11:40 AM Scott Gray > wrote: > > > Hey Jacques, > > > > Maybe I wasn't clear, OFBiz is downloading 5.5.6 as a dependency of > 4.2.0, > > does it make sense? > > >

Re: License issue with iText 4.2.0

2018-06-13 Thread Scott Gray
My first inclination is that taking legal advice from a company that is trying to sell you a license, probably isn't a good idea. They have a vested interest in trying to convince you not to use the MIT version. Regardless, I think Taher's solution works in the short term and the other alternativ

Re: License issue with iText 4.2.0

2018-06-14 Thread Scott Gray
Are there any genuine doubts about 2.1.7? Or just a warning from the company trying to sell the AGL licensed versions? If we revert back to 2.1.7 then I don't think we need to ask legal anything. Regards Scott On 14 June 2018 at 18:56, Jacques Le Roux wrote: > Le 14/06/2018 à 07:2

Re: ‘MapStack’ weirdness.

2018-07-19 Thread Scott Gray
I think it relates to the "context" variable that is frequently used in groovy data prep scripts for the script output. I'm not in front of a computer, but looking at it in that light may help. Regards Scott On Thu, 19 Jul 2018, 09:24 Taher Alkhateeb, wrote: > I didn't get into it before, but

Re: svn commit: r1813640 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity: GenericDelegator.java GenericEntity.java GenericPK.java GenericValue.java

2018-07-26 Thread Scott Gray
FYI, I think this commit accidentally introduced a weird import into GenericPK: import org.apache.sis.internal.jdk7.Objects probably intended to be java.util.Objects Regards Scott On 28 October 2017 at 15:19, wrote: > Author: mbrohl > Date: Sat Oct 28 15:19:56 2017 > New Revision: 1813640 > >

Re: ‘MapStack’ weirdness.

2018-07-26 Thread Scott Gray
2018 at 17:12, Mathieu Lirzin wrote: > Hello Scott, > > Scott Gray writes: > > > I think it relates to the "context" variable that is frequently used in > > groovy data prep scripts for the script output. > > > > I'm not in front of a comp

Re: svn commit: r1813640 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity: GenericDelegator.java GenericEntity.java GenericPK.java GenericValue.java

2018-07-27 Thread Scott Gray
Thanks Michael! On Fri, 27 Jul 2018, 08:48 Michael Brohl, wrote: > Hi Scott, > > thanks for spotting this, I will fix it! > > Regards, > > Michael > > > Am 26.07.18 um 23:40 schrieb Scott Gray: > > FYI, I think this commit accidentally introduced a weird i

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-16 Thread Scott Gray
Hi Jacques, Assuming I was looking at the correct patch, it looks like I could use this feature to login as anyone. All I need to do is send any userLoginId to getJwtToken and then I can login as that user with the token that comes back. Am I missing something? Regards Scott On 15 August 2018

Re: HTTP Compression not working for some files (JS and CSS)

2018-08-20 Thread Scott Gray
See the note under the compression config here: https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#Standard_Implementation Regards Scott On 20 August 2018 at 07:38, girish.vasmat...@hotwaxsystems.com < girish.vasmat...@hotwaxsystems.com> wrote: > > > On 2018/08/20 07:20:38, Michael Brohl

  1   2   3   4   5   6   7   8   9   10   >