Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
On Fri, Sep 6, 2019 at 10:46 AM Vincent Massol wrote: > > > > > On 6 Sep 2019, at 10:42, Thomas Mortagne wrote: > > > > And why do you guys think about raisin the history to 30 at least > > platform pipeline jobs? > > We need to first check if we h

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
s/why/what/ Not good with mails today... On Fri, Sep 6, 2019 at 10:42 AM Thomas Mortagne wrote: > > And why do you guys think about raisin the history to 30 at least > platform pipeline jobs? > > On Fri, Sep 6, 2019 at 10:39 AM Vincent Massol wrote: > > > > > &

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
And why do you guys think about raisin the history to 30 at least platform pipeline jobs? On Fri, Sep 6, 2019 at 10:39 AM Vincent Massol wrote: > > > > > On 6 Sep 2019, at 10:35, Thomas Mortagne wrote: > > > > On Fri, Sep 6, 2019 at 10:32 AM Vincent Massol

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
On Fri, Sep 6, 2019 at 10:42 AM Thomas Mortagne wrote: > > And why do you guys think about raisin the history to 30 at least > platform pipeline jobs? > > On Fri, Sep 6, 2019 at 10:39 AM Vincent Massol wrote: > > > > > > > > > On 6 Sep 201

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
On Fri, Sep 6, 2019 at 10:32 AM Vincent Massol wrote: > > Hi Simon, > > > On 6 Sep 2019, at 10:27, Simon Urli wrote: > > > > Hi all, > > > > On 05/09/2019 17:40, Simon Urli wrote: > >> On 05/09/2019 17:24, Thomas Mortagne wrote: > &

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-06 Thread Thomas Mortagne
On Fri, Sep 6, 2019 at 10:27 AM Simon Urli wrote: > > Hi all, > > On 05/09/2019 17:40, Simon Urli wrote: > > > > > > On 05/09/2019 17:24, Thomas Mortagne wrote: > >> On Thu, Sep 5, 2019 at 3:43 PM Simon Urli wrote: > >>> > >>>

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-05 Thread Thomas Mortagne
On Thu, Sep 5, 2019 at 5:40 PM Simon Urli wrote: > > > > On 05/09/2019 17:24, Thomas Mortagne wrote: > > On Thu, Sep 5, 2019 at 3:43 PM Simon Urli wrote: > >> > >> Hi everyone, > >> > >> reopening this thread since I started to close so

Re: [xwiki-devs] [Proposal] Cleaning of flickering tests

2019-09-05 Thread Thomas Mortagne
14386: appwithinminutes.AppsLiveTableTest.testEditApplication is > >> possibly flaky (https://jira.xwiki.org/browse/XWIKI-14386) > >> * XWIKI-14835: DeletePageTest#deletePageIsImpossibleWhenNoDeleteRights > >> is flickering (https://jira.xwiki.org/browse/XWIKI-14835) > >> * XWIKI-14860: LoginTest#testDataIsPreservedAfterLogin is flickering > >> (https://jira.xwiki.org/browse/XWIKI-14860) > >> > >> And I propose in general to close the flickers we don't remember having > >> seen after a cycle as inactive. > >> > >> WDYT? > >> > >> Simon > >> -- > >> Simon Urli > >> Software Engineer at XWiki SAS > >> simon.u...@xwiki.com > >> More about us at http://www.xwiki.com > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [GSoC] GSoC 2019 has concluded. Congratulations, XWiki students!

2019-09-05 Thread Thomas Mortagne
>> > > * Fawad Ali - > >> > > https://gist.github.com/9inpachi/b02fd831de7d79a7f3823634019470c4 > >> > > > >> > > We are very happy to have have had them in XWiki's community during > >> this > >> > > summer. We hope they had a good time while gaining practical > >> experience > >> > and > >> > > guidance in an open source project and that they found XWiki to be an > >> > > interesting and welcoming project that they can continue contributing > >> in > >> > > the future, by either continuously improving their GSoC project or > >> other > >> > > interesting parts of the XWiki project itself. > >> > > > >> > > See you around (on the mailing list, on the chat, forum, github, > >> etc.), > >> > > keep up the good work, good luck at school and thanks for helping the > >> > XWiki > >> > > project grow! > >> > > > >> > > -The XWiki Development Team > >> > > >> > > >> > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Remove XWiki.User enable property and introduce email_check property

2019-08-22 Thread Thomas Mortagne
+1 never been a big fan of the duplicate. Would still be better to have a migration in case someone used the new disabled property to avoid bad surprises with security Le jeu. 22 août 2019 à 16:01, Simon Urli a écrit : > Hi everyone, > > I recently (in XWiki 11.6RC1) introduced a new property

[xwiki-devs] [ANN] XWiki 11.7 RC1 released

2019-08-20 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 11.7 RC1. This release brings a new date picker and various merge improvements. Developers will also be able to reuse the standard color picker and the merge API give more details about the conflicts. You can download it

Re: [xwiki-devs] [contrib] any interest in another authenticator that deals with failed logins

2019-08-19 Thread Thomas Mortagne
iki.contrib.blockingauth' and > maybe even a Jira project like 'BLOCKINGAUTH' ? > > Best, > Clemens > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Best practice: tests must not output anything outside of the target directory

2019-08-01 Thread Thomas Mortagne
> > > PS: Ideally we should have a automatic verification in the build but it > > doesn’t seem easy to implement, so right now, I’m only proposing it as a > > best practice. > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [VOTE] Officially support for Tomcat 9

2019-07-31 Thread Thomas Mortagne
Updated https://dev.xwiki.org/xwiki/bin/view/Community/SupportStrategy/ServletContainerSupportStrategy/. On Wed, Jul 31, 2019 at 4:05 PM Thomas Mortagne wrote: > > So Debian decided for us: tomcat8 is not provided anymore in the > current Debian stable (buster) so looks like we need

Re: [xwiki-devs] [VOTE] Officially support for Tomcat 9

2019-07-31 Thread Thomas Mortagne
9 at 10:27 AM Vincent Massol wrote: > > > > > > > > On 13 Apr 2019, at 12:59, Thomas Mortagne > > wrote: > > > > > > On Sat, Apr 13, 2019 at 11:39 AM Vincent Massol > > wrote: > > >> > > >> Since it’s a vote I think I am -

Re: [xwiki-devs] [Proposal] Use an attribute whitelist for HtmlCleaner restricted mode

2019-07-25 Thread Thomas Mortagne
ttribute in restricted mode and discard only those, I don't see other > usecase where it could be a problem. > > > > > WDYT? > > > > Simon > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] Request for Account on Nexus

2019-07-15 Thread Thomas Mortagne
e Maps Application > (org.xwiki.contrib:application-interactive-maps) version 1.0-SNAPSHOT. > > *Requested username:* ginpachi > > Best, > Fawad -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] New wikimacro script binding

2019-07-03 Thread Thomas Mortagne
On Wed, Jul 3, 2019 at 8:39 AM Simon Urli wrote: > > Hi everyone, > > On 28/06/2019 21:32, Thomas Mortagne wrote: > > On Fri, Jun 28, 2019 at 7:12 PM Vincent Massol wrote: > >> > >> > >> > >>> On 28 Jun 2019, at 19:10, Vincent Massol

Re: [xwiki-devs] [Proposal] New wikimacro script binding

2019-06-28 Thread Thomas Mortagne
l the time > > * $macro.parameters.foo.rawValue() or toString() <- string, as specified by > > the user when using the macro > > > > $macro.parameters.foo would return some MacroParameter object. > > > > Note that $macro.parameters.foo when used in a string context would call > > $macro.parameters.foo.toString() which would return the raw value. > > > > Thanks > > -Vincent > > > > > > > >> > >> Thanks, > >> Simon > >> > >> > >> -- > >> Simon Urli > >> Software Engineer at XWiki SAS > >> simon.u...@xwiki.com > >> More about us at http://www.xwiki.com > -- Thomas Mortagne

Re: [xwiki-devs] [Docker] Move to java11 or drop arm64v8 architecture support?

2019-06-27 Thread Thomas Mortagne
e note: we could also decide to move to java11 everywhere on our CI agents > and keep some tests weekly on java8 (ie invert the current situation) > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

[xwiki-devs] [ANN] XWiki 11.5RC1 released

2019-06-18 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 11.5RC1. This release continue the work on improving concurrent editing of documents, introduce new page and attachment pickers for macros. The code macro get a new layout to display line numbers. Inline editing support for

Re: [xwiki-devs] [Proposal] Rerun flaky tests several times?

2019-06-11 Thread Thomas Mortagne
try to have a > better solution towards moving to a Continuous Delivery solution. > > WDYT? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [VOTE] API breakage - Extension point org.xwiki.platform.html.head

2019-06-06 Thread Thomas Mortagne
this vote passes: > >https://github.com/xwiki/xwiki-platform/pull/1115 > > Thanks to Caty for spotting the issue and the guidance on how to fix it, and > to Simon and Vincent. > > Kind regards > > Stéphane > > > -- > Stéphane Laurière > XWiki – https://xwiki.com > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update database support strategy

2019-06-05 Thread Thomas Mortagne
gt; >>>>>> On 13 Nov 2018, at 11:50, Guillaume Delhumeau < > >>>> guillaume.delhum...@xwiki.com> wrote: > >>>>>> > >>>>>> Hello, > >>>>>> > >>>>>> We are in a weird situation w

Re: [xwiki-devs] [Proposal] Remove not supported HBM files

2019-06-05 Thread Thomas Mortagne
pported DBs… OTOH we don’t > support them... > > WDYT? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Brainstorming] Controlling transformations

2019-05-30 Thread Thomas Mortagne
Yes the rest is fine and 5 days is comfortable IMO. On Wed, May 29, 2019 at 1:59 PM Vincent Massol wrote: > > Hi Thomas, > > > On 21 May 2019, at 14:20, Thomas Mortagne wrote: > > > > bq. * Make RenderingConfiguration.getTransformationNames() search in > > the c

Re: [xwiki-devs] Improve Android XWiki authenticator GSOC-19

2019-05-25 Thread Thomas Mortagne
r=doneissues >- >https://jira.xwiki.org/projects/ANDAUTH/issues/ANDAUTH-27?filter=doneissues > > > Regards, > Divyansh Jain -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Merge on save

2019-05-23 Thread Thomas Mortagne
t; >>>>>>> The main idea of the merge on save, is to try to merge users work in > >>>>>> case of save conflict. Knowing that the merge might led to merge > >>>>>> conflict > >>>>>> in case of edits on the same places. Those merge conflict can be > >>>>>> tackled > >>>>>> automatically, but a priority will be then given to one version over > >>>>>> another. > >>>>>>> > >>>>>>> I first propose to add an option in user profile, so users would have > >>>>>> the possibility to choose between: > >>>>>>> 1. Always merge automatically the work, even in case of merge > >>>>>>> conflict > >>>>>> > >>>>>> I don’t understand this part. If there’s a conflict it means it cannot > >>>>>> be > >>>>>> merged… So would it do? Take latest version and overwrite previous > >>>>>> version? > >>>>>> > >>>>>>> 2. Always merge automatically, but ask what to do in case of merge > >>>>>> conflict > >>>>>>> 3. Always ask what to do in case of save conflict > >>>>>>> > >>>>>>> Now the question is: what should be the default option? > >>>>>> > >>>>>> Certainly not 1! 2 is really the best to me. > >>>>>> > >>>>>> Thanks > >>>>>> -Vincent > >>>>>> > >>>>>>> Option 1 looks like a good fit for decreasing the number of clicks to > >>>>>> do, but I'm a bit afraid that in case of conflict they would have the > >>>>>> same > >>>>>> feeling as before the warning conflict window: i.e. to loose some part > >>>>>> of > >>>>>> their work. > >>>>>>> > >>>>>>> WDYT? > >>>>>>> > >>>>>>> Simon > >>>>>>> > >>>>>>> -- > >>>>>>> Simon Urli > >>>>>>> Software Engineer at XWiki SAS > >>>>>>> simon.u...@xwiki.com > >>>>>>> More about us at http://www.xwiki.com > >>>>>> > >>>>>> > >>>> > >>>> -- > >>>> Simon Urli > >>>> Software Engineer at XWiki SAS > >>>> simon.u...@xwiki.com > >>>> More about us at http://www.xwiki.com > >> > >> -- > >> Simon Urli > >> Software Engineer at XWiki SAS > >> simon.u...@xwiki.com > >> More about us at http://www.xwiki.com > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Brainstorming] Controlling transformations

2019-05-21 Thread Thomas Mortagne
jira.xwiki.org/browse/XWIKI-13167 at > the same time, with the query string in the URL overriding the > transformations. > > WDYT? > > Any idea of the cost of adding such a feature in term of days? Does 7 days > sounds good to you? (inluding testing and doc). > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Roadmaps for 11.5 and 11.6

2019-05-21 Thread Thomas Mortagne
> > @devs: please confirm that you’re ok. @Simon, please let me know if it’s ok > for the item where there’s a question mark. @Marius: same for you. > > @evalica: I didn’t put any investigations/designs but we should IMO. Any > proposals? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] Map Application - GSoC 19

2019-05-20 Thread Thomas Mortagne
gt; > > in > > > > a big building and locate point of interests. > > > > > *Maps on mobile* - Special design arrangements will be made for > > easily > > > > viewing of maps and availing all the features of the application on > > > mobile > > > > devices. > > > > > *Custom map backgrounds* - Custom backgrounds will make the > > environment > > > > of interactive maps much suitable for a specific purpose > > > > > > > > If you have any features in mind that will make the Map Application > > > better > > > > please feel free to reply to this mail. > > > > This is all for the summary of the project, if you want to have a more > > > > deeper insight, please check out the full proposal. > > > > > > > > *Project Proposal: * > > > > https://drive.google.com/open?id=14qXC7Oy2bPUASfVtSTIsNG1sPcfm5Ikr > > > > > > > > > > > > Thanks for reading through the mail. I will be looking forward to your > > > > guidance through this summer and your contributions to the project. > > > > If you have any questions or suggestions, please feel free to reply to > > > this > > > > mail. > > > > > > > > Au revoir. :) > > > > > > > > Best, > > > > Fawad Ali > > > > > > > > > -- Thomas Mortagne

Re: [xwiki-devs] Building/Installing XWiki Platform

2019-05-16 Thread Thomas Mortagne
can be the waiting time? I feel like i am not doing something > right sadly. > Do i keep waiting for the downloads to finish? cause its been a while it is > still downloading > > Regards, > Mua > > On Wed, May 15, 2019, 07:58 Thomas Mortagne > wrote: > > > L

Re: [xwiki-devs] Building/Installing XWiki Platform

2019-05-15 Thread Thomas Mortagne
] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn -rf :xwiki-platform-rendering-async-default > MacBook-Pro-de-MACBOOK:xwiki-platform-renderi

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-08 Thread Thomas Mortagne
e wikimacroccontent, so I have a first working > > POC, but I'd like to know WDYT about this. > > > > I would also be really happy if you could give me some wikimacro > > examples where the inline editing would make sense, so I could use it in > > my tests. > > > > Thanks, > > Simon > > -- > > Simon Urli > > Software Engineer at XWiki SAS > > simon.u...@xwiki.com > > More about us at http://www.xwiki.com > > -- Thomas Mortagne

Re: [xwiki-devs] Analysis of BFD releases 11.2 and 11.3

2019-05-02 Thread Thomas Mortagne
ssues (128) > * Resolved issues (123) > > So we were not even able to catch up with created bugs during the period. > > So the question is: why are we not able to catch up? > > Let’s look at who closed bugs during the period: > https://www.evernote.com/l/AHfj3Z0DW8RAuZ0AHw9BX6cno

Re: [xwiki-devs] [Proposal] Define Xmx value in jvm.config for xwiki-* repositories

2019-04-30 Thread Thomas Mortagne
ml > > It could be interesting to do so in our repos so that all users run with the > right values. > > Or we could decide that the values depend too much on the profiles being > executed and it’s not worht it. > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

Re: [xwiki-devs] XAR source projects should allow source files

2019-04-18 Thread Thomas Mortagne
mpt allows project developers to nicely edit files > and let them be combined into a xar when it is the time. See the issue > for an example realisation. > > I would love your comments. > > Paul -- Thomas Mortagne

Re: [xwiki-devs] [Brainstorming] Remove Tomcat 7.x support? (was Re: [VOTE] Officially support for Tomcat 9)

2019-04-13 Thread Thomas Mortagne
be curious to know if users would be ok to run > > Tomcat 9.x in production. Now we would still support 8.5.x so users who > > want to stay on Tomcat 8.5.x can. > > > > WDYT? > > > > Thanks > > -Vincent > > > > PS: I thought I saw a jira i

Re: [xwiki-devs] [VOTE] Officially support for Tomcat 9

2019-04-13 Thread Thomas Mortagne
WDYT? > > Thanks > -Vincent > > PS: I thought I saw a jira issue being closed on this topic, did I dream it > or did you anticipate the vote results? ;) Providing a Debian package which work with Tomcat 9 does not make it officially supported as you said. > > > On 12 A

Re: [xwiki-devs] [VOTE] Officially support for Tomcat 9

2019-04-12 Thread Thomas Mortagne
On Fri, Apr 12, 2019 at 5:42 PM Vincent Massol wrote: > > > > > On 12 Apr 2019, at 17:35, Thomas Mortagne wrote: > > > > On Fri, Apr 12, 2019 at 5:07 PM Vincent Massol wrote: > >> > >> > >> > >>> On 12 Apr 2019, at 17:00, Thoma

[xwiki-devs] [VOTE] Officially support for Tomcat 9

2019-04-12 Thread Thomas Mortagne
/xwiki/bin/view/Community/SupportStrategy/ServletContainerSupportStrategy/ (only Tomcat 8 right now). Another argument is that it's the current recommended stable version from Tomcat point of view so people will use it more and more. WDYT ? Here is my +1 -- Thomas Mortagne

[xwiki-devs] [ANN] XWiki 10.11.6 released

2019-04-12 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 10.11.6. This is a bugfix release that covers important issues that we have discovered since 10.11.5 has been released. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Thomas Mortagne
; > Rationale: > * This adds warnings in the xwiki logs when users navigate to those pages > which isn’t nice. > * It also helps reducing the number of deprecated methods we use (I have the > feeling this is not reducing) and helps us move towards being able to move > the deprecated code to legacy. > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy (TAKE 3)

2019-03-21 Thread Thomas Mortagne
ay. > > See > http://maven.xwiki.org/site/clover/20190321/XWikiReport-20190320-0128-20190321-1059.html > > So we need to fix it now. > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Feedback] Installation choices

2019-03-18 Thread Thomas Mortagne
lect the version, OS, type and package > > * Depending on the user selection, there is an option to Download the > > package, or you just get Installation steps (personalized for each option > > selected). > > > > I've iterated currently just for the ZIP package (for Demo+Mac), but > > imagine something similar for all the other packages. > > > > What do you think? Should I continue in this direction? > > > > Thanks, > > Caty > -- Thomas Mortagne

Re: [xwiki-devs] [Feedback] Installation choices

2019-03-18 Thread Thomas Mortagne
st get Installation steps (personalized for each option > > selected). > > > > I've iterated currently just for the ZIP package (for Demo+Mac), but > > imagine something similar for all the other packages. > > > > What do you think? Should I continue in this direction? > > > > Thanks, > > Caty > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Feedback] Installation choices

2019-03-18 Thread Thomas Mortagne
). I feel the whole page is about installation. * I guess this way is going to hide more the demo packages (since I doubt it will be selected by default), maybe that's a problem ? * I would put the STABLE version first and selected by default since that's the one we want people to test > > Thanks, > Caty -- Thomas Mortagne

Re: [xwiki-devs] asking for help, issues for a team

2019-03-13 Thread Thomas Mortagne
nknak kell felvennie egy issuet vagy ha van 2-3 nagyobb issue, > akkor mindegyiken a csapatból 2-3 ember is dolgozhatna. > > Az első mérföldkövet jövő héten kell bemutatnunk, addig meg kell ismernünk > a projektet és szereznünk kell feladatot is. > > Hálásak lennénk, ha tudnátok segíteni! > > Előre is köszönöm... -- Thomas Mortagne

Re: [xwiki-devs] [xwiki-notifications] About the GSOC mentors email address

2019-03-08 Thread Thomas Mortagne
am very interested in some projects, and would like to try it. So I want to > have a discussion with the project’s mentor. But I find the email address in > the mentor profile is incomplete. > > Would you give me some suggestions about how to get complete address? > > Thanks & Best Regards, > > CaiWeiqiang -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Introduce a new table BackLinks for solving issues on wiki farms

2019-02-26 Thread Thomas Mortagne
ould have: > - sourceType > - targetType > > to identify precisely what this backlink represents? > In that case shouldn't we put it in link table too? > > > > Thanks, > > Marius > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Introduce a new table BackLinks for solving issues on wiki farms

2019-02-26 Thread Thomas Mortagne
understanding of links and backlinks, solve > the issues on farm and help us to maintain this code. + it doesn't break > any legacy since we keep the existing Link table. > > WDYT? > > Simon > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Changes to remove Dashboard, Crypto, Macros, Rendering entries in the Navigation Panels

2019-02-26 Thread Thomas Mortagne
we should reserve the top level root for user content. It would be much > better to have a place under “XWiki”, such as “XWiki.Extensions. name>..” where each extension could put its content. > > We already started discussing this. The past thread(s) needs to be unearthed > and the discussion resumed. > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] New Functional test best practice for docker-based tests

2019-02-12 Thread Thomas Mortagne
.e. video recording save) > should be the same as before. > > So I think it’s worth it. Out of 3mn, 3-6 more seconds for 3 tests is not too > much (between 2% and 3% more). > > WDYT? Why only docker based tests and not all UI tests ? > > Thanks > -Vincent > > > > > > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy (TAKE 3)

2019-02-11 Thread Thomas Mortagne
get addressed before the release day so that we’re ready on the > release day. > * Implementation detail: don’t send a failure email when there are failing > tests in the build, to avoid false positives > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Get rid of Activity Stream and the Watchlist

2019-02-04 Thread Thomas Mortagne
it for example) ? > - move Watchlist and AS into "attic" in 11.2 > > Thanks you, > > -- > Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project -- Thomas Mortagne

[xwiki-devs] Location for extensions ideas

2019-01-31 Thread Thomas Mortagne
do the job well. -- Thomas Mortagne

Re: [xwiki-devs] Update objects on class rename

2019-01-31 Thread Thomas Mortagne
re often used in > scripts (e.g. a live table) and those scripts are not updated so there's a > high chance that something will not work correctly after the class rename. +1, object/class almost always imply that some code is manipulating them it's not going to be fixed so the risk is still the same level for me > > WDYT? > > Thanks, > Marius -- Thomas Mortagne

[xwiki-devs] [ANN] XWiki 11.0.2 released

2019-01-30 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 11.0.2. This is a bugfix release that covers important issues that we have discovered since 11.0.1 has been released. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

[xwiki-devs] [ANN] XWiki 11.0.1 released

2019-01-30 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 11.0.1. This is a bugfix release that covers important issues that we have discovered since 11.0 has been released. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

Re: [xwiki-devs] [ANN] XWiki 11.0 released

2019-01-30 Thread Thomas Mortagne
; Make sure to review the release notes: > https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/11.0 > > Thanks for your support > -The XWiki dev team -- Thomas Mortagne

[xwiki-devs] [ANN] XWiki 9.11.9 released

2019-01-29 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 9.11.9. This is a bugfix release that covers important issues that we have discovered since 9.11.8 has been released. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

[xwiki-devs] [ANN] XWiki 10.11.2 released

2019-01-29 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 10.11.2. This is a bugfix release that covers important issues that we have discovered since 10.11.1 has been released. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

Re: [xwiki-devs] MyXWiki.org legal information

2019-01-23 Thread Thomas Mortagne
e committers from different companies > and not just XWiki SAS. Also some non-active committers should be removed IMO > (Caleb for example). > > Easiest might be to point to > https://www.myxwiki.org/xwiki/bin/view/XWiki/XWikiAdminGroup. Not sure why we > need an XWikiSASGroup BTW. +1, XWiki SAS is a sponsor here and not an admin > > WDYT? > > Thanks > -Vincent > > > Thanks, > > Caty > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Thomas Mortagne
ly to prove that it works and to have something to report for > > > users in the release notes and to show progress. > > > > > > Thanks > > > -Vincent > > > > > > > > > > >> > > > >> Thanks > > > >> -Vincent > > > >> > > > >>> * Introduce a new annotation to macro parameters to specify / override > > > >>> its type (different from its actual java type). > > > >>> > > > >>> The new annotation will mostly be useful for the WYSIWYG side. In our > > > >>> case we want to use the document parameter which is a String. The > > > >>> annotation will allow us to work with a DocumentReference instead > > > >>> which can be used to display the document picker when editing the > > > >>> macro in WYSIWYG mode. > > > >>> > > > >>> To be clear, here is how we would use it: > > > >>> @PropertyType(DocumentReference.class) > > > >>> public void setDocument(String document) > > > >>> > > > >>> WDYT? > > > >>> > > > >>> Thanks, > > > >>> Adel > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-17 Thread Thomas Mortagne
ublic void setDocument(String document) > > WDYT? > > Thanks, > Adel +1 -- Thomas Mortagne

Re: [xwiki-devs] [Proposl] Improve JIRA resolution and introduce a "Solved by" resolution

2019-01-10 Thread Thomas Mortagne
resolution named “Solved by” > * Best practice: when using “solved by”, also use the “depends on” link "depends on" is not really semantically correct either, if it's possible add custom links it would be nicer to have corresponding ones. > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy (TAKE 2)

2019-01-09 Thread Thomas Mortagne
ared to the baseline report (negative > >>> contribution per module) > >>> * The baseline report is the report generated just after each XS release. > >>> This means that we keep the same baseline during a XS release > >>> ** Technically it means that the pipeline will update the latest.txt file > >>> (which contains the clover report timestamp) when it notices a version > >>> change > >>> * We add a step in the Release Plan Template to have the report passing > >>> before we can release. > >>> * The RM is in charge of a release from day 1 to the release day (already > >>> the case), and is also in charge of making sure that the global coverage > >>> job failures get addressed before the release day so that we’re ready on > >>> the release day. > >>> > >>> Options: > >>> * Make it easier and only fail the pipeline job when the global TPC value > >>> is lower than the baseline (vs failing whenever a module has negative > >>> contribution) > >>> > >>> WDYT? > >>> > >>> Thanks > >>> -Vincent > >>> > >> > > > -- Thomas Mortagne

Re: [xwiki-devs] [Discussion] Coding practice for location of internal package name

2018-12-31 Thread Thomas Mortagne
job.handler.internal > > and org.xwiki.job.handler.internal.question . So maybe there's something to > > discuss/change > > * I guess we have a mix of both now so we should discuss it and adjust our > > rules if need be > > “ > > > > So I think we don’t have all the same rules/understanding of the definition > > at > > http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HPackagenames > > > > I’d like to discuss with you to see what you prefer and adjust our rules so > > that it matches what we do in practice. > > > > Any take in this? > > > > Thanks > > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Change of XS Cycle strategy to account for Christmas

2018-12-10 Thread Thomas Mortagne
> > * No release during Christmas, yeah :) > > * More time to prepare the first LTS bugfix release, i.e. N.10.1, which can > > be done during the month of January. > > * More time for the first released of N+1 (i.e. N+1.0). This is important > > since that’s the release where we can do heavy refactoring and it’s not bad > > to get some more time. > > > > Cons: > > * One less release > > > > WDYT? Do you see other cons? > > > > Thanks > > -Vincent > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] New xwiki-clover-maven repository

2018-11-30 Thread Thomas Mortagne
linked to releases of XWiki. But it should be maintained by the > xwiki dev team since we use it in our pipeline to compute the global coverage > and generate reports/emails when global TPC is lowered. > > WDYT? > > Thanks > -Vincent -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] WCAG exception: consecutive line breaks

2018-11-26 Thread Thomas Mortagne
On Mon, Nov 26, 2018 at 12:00 PM Marius Dumitru Florea wrote: > > On Thu, Nov 22, 2018 at 11:22 AM Thomas Mortagne > wrote: > > > On Thu, Nov 22, 2018 at 9:57 AM Vincent Massol wrote: > > > > > > > > > > > > > On 21 Nov 2

Re: [xwiki-devs] [Proposal] WCAG exception: consecutive line breaks

2018-11-22 Thread Thomas Mortagne
tive breaks is encountered > >> > >> pros: > >> * ? > >> > >> cons: > >> * we would miss some consecutive that are used only for style > >> and we would catch some others in translations if we do 3 linebreaks > >> instead of 2. IMO it's only moving the problem > >> > >> D. Create a rendering syntax dedicated to translation pages > >> > >> pros: > >> * remove completely the problem of consecutive in translations > >> * can maybe be used to present them in another way? > >> > >> cons: > >> * need to develop/test/maintain a new rendering syntax > >> > >> I'd personnaly vote like this: > >> A: +0 > >> B: +1 > >> C: -1 > >> D: +0 > >> > >> WDYT? > >> > >> Simon > >> -- > >> Simon Urli > >> Software Engineer at XWiki SAS > >> simon.u...@xwiki.com > >> More about us at http://www.xwiki.com > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Always add a link to the reference doc in the RN items

2018-11-20 Thread Thomas Mortagne
it be nicer if the links were in the text (better flow) and it > > > would take less visual space (if we have a field we’ll need to add the > > info > > > somewhere which will take more space). The downside is that everyone is > > > forgetting to do it and it's not enforceable automatically. > > > > > > WDYT? > > > > > > Thanks > > > -Vincent > > > > > > > > > > > -- > Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Change of XS Cycle strategy to account for Christmas

2018-11-19 Thread Thomas Mortagne
time. > > Cons: > * One less release > > WDYT? Do you see other cons? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-16 Thread Thomas Mortagne
>>>>>>>>>>>>>>>>>>>>>> > > @PropertyGroup("target") > @PropertyFeature("reference") > page > > @PropertyGroup({"target", "entityReference"}) > @PropertyFeature("refere

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
On Thu, Nov 15, 2018 at 2:06 PM Adel Atallah wrote: > > On Thu, Nov 15, 2018 at 1:56 PM Thomas Mortagne > wrote: > > > > On Thu, Nov 15, 2018 at 1:24 PM Adel Atallah wrote: > > > > > > On Thu, Nov 15, 2018 at 11:13 AM Thomas Mortagne > > > wrot

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
On Thu, Nov 15, 2018 at 1:24 PM Adel Atallah wrote: > > On Thu, Nov 15, 2018 at 11:13 AM Thomas Mortagne > wrote: > > > > On Thu, Nov 15, 2018 at 11:06 AM Adel Atallah > > wrote: > > > > > > Ok so it seems like we are getting back to the propositi

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
ation on > "reference" and "type" because we should have all the necessary > information to *deduce* the conflicting parameters. It's true that > removing the "Alternative" annotation of one of "reference" or "type" > should produce t

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
with the following use case: @PropertyFeature("reference") page @PropertyGroup("entityReference") @PropertyFeature("reference") reference @PropertyGroup(entityReference") type @PropertyFeature("reference") document On Thu, Nov 15, 2018 at 10:58 AM Thomas Mortagne

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
On Thu, Nov 15, 2018 at 10:23 AM Marius Dumitru Florea wrote: > > On Thu, Nov 15, 2018 at 10:51 AM Thomas Mortagne > wrote: > > > I'm also really not a fan of having to implement a component just to > > indicate that two groups of properties are conflicting. > > &g

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Thomas Mortagne
"target" > >>>> parameter group of the Include Macro we would create > >>>> > >>>> @Named("include/target") > >>>> public class TargetParameterGroup implements ParameterGroup {} > >>>> > >>>> To specify that the members of a parameter group are exclusive we can > >>>> either use a method in the ParameterGroup interface (e.g. isExclusive()) > >>> or > >>>> use an annotation on the implementation TargetParameterGroup. > >>>> > >>>> Thanks, > >>>> Marius > >>>> > >>>> > >>>> On Tue, Nov 13, 2018 at 12:03 PM Adel Atallah > >>>> wrote: > >>>> > >>>>> Hello, > >>>>> > >>>>> I'd like to briefly summarize the situation so that we can make some > >>>>> progress. > >>>>> > >>>>> What we have: > >>>>> * We define "parameters" in a macro by creating a Java Bean, which > >>>>> provides all the getters and setters of the parameters we want. > >>>>> * We can use annotations on these getters/setters to define some > >>>>> behavior or metadata for these parameters (description, mandatory, > >>>>> deprecated...) > >>>>> > >>>>> What we want: > >>>>> * Being able to handle conflicting parameters. For instance when we > >>>>> deprecate a parameter and add a new one to replace it, we should be > >>>>> able to either use the deprecated parameter or the new one but not > >>>>> both. > >>>>> * We also want to group parameters that are related to each other. > >>>>> > >>>>> What we proposed: > >>>>> * Use annotations on the parameters to express the conflict. > >>>>> * Marius proposed to see the problem as a boolean expression such as: > >>>>> (page XOR (reference AND type) XOR document) OR section OR context. > >>>>> This would translate as: the user can use the 'section' and/or > >>>>> 'context' parameters (if they want), can use only one of these > >>>>> parameters: 'page', ('reference' and 'type') or 'document', where > >>>>> 'reference' and 'type' depend on each other and you can't use one > >>>>> without the other. > >>>>> * You can see on previous e-mails the kind of annotations we proposed > >>>>> to solve the issue. > >>>>> > >>>>> Thanks, > >>>>> Adel > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update servlet container support strategy

2018-11-13 Thread Thomas Mortagne
g on https://hub.docker.com/_/tomcat/) > > * For Jetty (standalone packaging or standard), I propose to say we support > > Jetty 9.x (which means Jetty 9.4.12 as of today, see “latest” tag on > > https://hub.docker.com/_/jetty/) > > > > WDYT? > > > > Thanks > > -Vincent > > > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update database support strategy

2018-11-12 Thread Thomas Mortagne
ork/database/enterprise-edition/downloads/index.html > > ) > > >> > > >> Question 2: review what we support > > >> > > >> * For MySQL I think we could also start supporting MySQL 8.x (ie the > > latest version of that cycle). We have an issue open for it currently: > > https://jira.xwiki.org/browse/XWIKI-15215 > > >> * For PostgreSQL we could also start supporting versions 11.x (ie the > > latest version of that cycle) > > >> * For Oracle, we could also start supporting versions 12.x (ie the > > latest version of that cycle) > > >> > > >> Question 3: decide if we drop some support > > >> > > >> * Is there any cycle that we should support for? Right now I think that > > MySQL 5.x is still heavily used, same for postgreSQL 9.x I guess. Don’t > > know for Oracle. > > >> * Any idea? > > >> > > >> So WDYT about the 3 questions? > > >> > > >> Thanks > > >> -Vincent > > > > > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update database support strategy

2018-11-12 Thread Thomas Mortagne
n of that cycle). We have an issue open for it currently: > >> https://jira.xwiki.org/browse/XWIKI-15215 > >> * For PostgreSQL we could also start supporting versions 11.x (ie the > >> latest version of that cycle) > >> * For Oracle, we could also start supporting versions 12.x (ie the latest > >> version of that cycle) > >> > >> Question 3: decide if we drop some support > >> > >> * Is there any cycle that we should support for? Right now I think that > >> MySQL 5.x is still heavily used, same for postgreSQL 9.x I guess. Don’t > >> know for Oracle. > >> * Any idea? > >> > >> So WDYT about the 3 questions? > >> > >> Thanks > >> -Vincent > > > -- Thomas Mortagne

Re: [xwiki-devs] [Brainstorming] Should we merge the 3 xwiki repos: commons, rendering & platform?

2018-11-12 Thread Thomas Mortagne
(from commons) > |_ xwiki-component-multi (from platform) > |_ xwiki-rendering > |_ … > |_ xwiki-tools > |_ ... > > (it would mean that in xwiki-tools, we apply similar rules that for runtime > code or override the maven configs) > > WDYT? > > Thanks > -Vincent So again big +1 for moving rendering into commons since it's easy but I see more cons than pros for platform right now. -- Thomas Mortagne

Re: [xwiki-devs] [Brainstorming] Should we merge the 3 xwiki repos: commons, rendering & platform?

2018-11-12 Thread Thomas Mortagne
t;> |_ xwiki-component-api (from commons) > >> |_ xwiki-component-multi (from platform) > >> |_ xwiki-rendering > >> |_ … > >> |_ xwiki-tools > >> > >> We could even try to go with an even flatter structure: > >> > >> xwiki > >> |_ xwiki-component > >> |_ xwiki-component-api (from commons) > >> |_ xwiki-component-multi (from platform) > >> |_ xwiki-rendering > >> |_ … > >> |_ xwiki-tools > >> |_ ... > >> > >> (it would mean that in xwiki-tools, we apply similar rules that for > >> runtime code or override the maven configs) > >> > >> WDYT? > >> > >> Thanks > >> -Vincent > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-07 Thread Thomas Mortagne
" parameter. > > WDYT? > > Thanks, > Adel > > On Tue, Sep 25, 2018 at 11:51 AM Marius Dumitru Florea > wrote: > > > > On Wed, Sep 19, 2018 at 4:31 PM Vincent Massol wrote: > > > > > > > > > > > >

Re: [xwiki-devs] [Proposal] Jobs for the multiple configuration testing

2018-11-07 Thread Thomas Mortagne
On Wed, Nov 7, 2018 at 9:20 AM Vincent Massol wrote: > > Hi Thomas, > > > On 7 Nov 2018, at 08:44, Thomas Mortagne wrote: > > > > On Mon, Nov 5, 2018 at 5:22 PM Vincent Massol wrote: > >> > >> Hi devs, > >> > >> I’m still not sur

Re: [xwiki-devs] [Proposal] Jobs for the multiple configuration testing

2018-11-06 Thread Thomas Mortagne
2, we won't need to have the smoke tests I add as > part of the platform JenkinsFile. > > WDYT? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update database support strategy

2018-11-06 Thread Thomas Mortagne
rosoft SQL Server? > >>>>> > >>>>> Another reference: > >>>>> https://db-engines.com/en/ranking > >>>>> > >>>>> * MongoDB also is in the top 5 for 2018 in multiple resources. Should / > >>>>> could we also support that? I

Re: [xwiki-devs] [Proposal] Update servlet container support strategy

2018-10-31 Thread Thomas Mortagne
I know but it should also be on the support page IMO. On Wed, Oct 31, 2018 at 10:44 AM Vincent Massol wrote: > > > > > On 31 Oct 2018, at 10:42, Thomas Mortagne wrote: > > > > Actually there is another very important thing missing in that page: > > we should als

Re: [xwiki-devs] [Proposal] Update database support strategy

2018-10-31 Thread Thomas Mortagne
Here is the one for postgresql (since we also have a pgsql based Debian package) https://packages.debian.org/search?keywords=postgresql=names=1 So 9.4, 9.6 and 11 > > Thanks > -Vinent > > > > > Simon > > > >> So WDYT about the 3 questions? > >> Thanks > >> -Vincent > > > > -- > > Simon Urli > > Software Engineer at XWiki SAS > > simon.u...@xwiki.com > > More about us at http://www.xwiki.com > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Update servlet container support strategy

2018-10-31 Thread Thomas Mortagne
would be more clear to say we support 8.5.x. > > > * For Jetty (standalone packaging or standard), I propose to say we > > > support Jetty 9.x (which means Jetty 9.4.12 as of today, see “latest” tag > > > on https://hub.docker.com/_/jetty/) > > > > > > WDYT? > > > > > > Thanks > > > -Vincent > > > > > > > > > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Move Doxia-based syntaxes in contrib

2018-10-29 Thread Thomas Mortagne
oxia github repository > (doxia-common, doxia-twiki, doxia-docbook, doxia-twiki). > > WDYT? > > Thanks > -Vincent > -- Thomas Mortagne

Re: [xwiki-devs] [Best Practice] Use lowercase for JIRA labels

2018-10-24 Thread Thomas Mortagne
istent naming scheme for jira labels and > > use lowercase (and fix all the upper case we can find). > > > > Ok for everyone? > > > > Thanks > > -Vincent > > > > -- Thomas Mortagne

Re: [xwiki-devs] What do we do with Watchlist and Activity Stream

2018-10-24 Thread Thomas Mortagne
miss 10.9RC1. > > The release of 10.9RC1 is already late, so what do you think is the best > option? > > Thanks, > > -- > Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Thomas Mortagne
t;>>>>>>> > >>>>>>>>>>>>>> So you suggest we shouldn't do 2? > >>>>>>>>>>>>> > >>>>>>>>>>>>> So +1 to prevent/warn the user when doing a move/renaming > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>>> AND copy pages containing XClass definitions > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> FTR, copying a single page having an XClass definition is not > >>>>>>>>>>>> dangerous (it > >>>>>>>>>>>> won't break the application that owns the page), as it only > >>>>>>>>>>>> creates a new > >>>>>>>>>>>> class definition. Copying an entire application is not dangerous > >>>>>>>>>>>> either. > >>>>>>>>>>>> The copy won't work like the original application (this > >>>>>>>>>>>> justifies a warning > >>>>>>>>>>>> as it may fail the user expectations), but the original > >>>>>>>>>>>> application will > >>>>>>>>>>>> still work. Renaming or moving an application is dangerous as it > >>>>>>>>>>>> breaks the > >>>>>>>>>>>> application. > >>>>>>>>>>> > >>>>>>>>>>> Yes you’re correct. Unless the user does a copy + delete ;) > >>>>>>>>>>> > >>>>>>>>>>> Thanks > >>>>>>>>>>> -Vincent > >>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>>> (the message should list all such pages). > >>>>>>>>>>>>> > >>>>>>>>>>>>> -1 to hide the action from the menu (if you’re talking about the > >>>>>>>>>>>>> “Move/Rename” and “Copy" actions) because: > >>>>>>>>>>>>> 1) you get to choose whether you move/rename/copy children > >>>>>>>>>>>>> after you click > >>>>>>>>>>>>> the action > >>>>>>>>>>>>> 2) even when the current page has an XClass, the user wouldn't > >>>>>>>>>>>>> understand > >>>>>>>>>>>>> why he cannot see/click on the action. It’s better that he can > >>>>>>>>>>>>> do it but > >>>>>>>>>>>>> get an error message, explaining why and telling him that to > >>>>>>>>>>>>> contact an > >>>>>>>>>>>>> advanced users if he really needs to do it. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Thanks > >>>>>>>>>>>>> -Vincent > >>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>>> On Fri, Sep 21, 2018 at 4:44 PM Simon Urli > >>>>>>>>>>>>>>> > >>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Hi all, > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> users might currently break their AWM application by > >>>>>>>>>>>>>>>> renaming/moving > >>>>>>>>>>>>>>>> pages containing XClass definition. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> We need a proper refactoring operation to be able to > >>>>>>>>>>>>>>>> properly do such > >>>>>>>>>>>>>>>> move/rename. But this feature might take a while to be > >>>>>>>>>>>>>>>> completely > >>>>>>>>>>>>>>>> available. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> In the meantime I propose that we prevent users from > >>>>>>>>>>>>>>>> renaming/moving > >>>>>>>>>>>>>>>> pages containing XClass. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> What I propose is the following: > >>>>>>>>>>>>>>>> - Forbid completely *simple users* to rename/move pages > >>>>>>>>>>>>>>>> containing > >>>>>>>>>>>>> XClass > >>>>>>>>>>>>>>>> - Display a warning to *advanced users* when they perform > >>>>>>>>>>>>>>>> such > >>>>>>>>>>>>>>>> operation: the same kind of warning we already have when > >>>>>>>>>>>>>>>> performing > >>>>>>>>>>>>> edit > >>>>>>>>>>>>>>>> on XWiki pages > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> WDYT? > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Simon > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> -- > >>>>>>>>>>>>>>>> Simon Urli > >>>>>>>>>>>>>>>> Software Engineer at XWiki SAS > >>>>>>>>>>>>>>>> simon.u...@xwiki.com > >>>>>>>>>>>>>>>> More about us at http://www.xwiki.com > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> -- > >>>>>>>>>>>>>> Simon Urli > >>>>>>>>>>>>>> Software Engineer at XWiki SAS > >>>>>>>>>>>>>> simon.u...@xwiki.com > >>>>>>>>>>>>>> More about us at http://www.xwiki.com > >>>>>>>>>>> > >>>>>>>>> > >>>>>>>>> -- > >>>>>>>>> Simon Urli > >>>>>>>>> Software Engineer at XWiki SAS > >>>>>>>>> simon.u...@xwiki.com > >>>>>>>>> More about us at http://www.xwiki.com > >>>>>>> > >>>>>>> -- > >>>>>>> Simon Urli > >>>>>>> Software Engineer at XWiki SAS > >>>>>>> simon.u...@xwiki.com > >>>>>>> More about us at http://www.xwiki.com > >>>>> > >>>>> -- > >>>>> Simon Urli > >>>>> Software Engineer at XWiki SAS > >>>>> simon.u...@xwiki.com > >>>>> More about us at http://www.xwiki.com > >>> > >>> -- > >>> Simon Urli > >>> Software Engineer at XWiki SAS > >>> simon.u...@xwiki.com > >>> More about us at http://www.xwiki.com > > > > -- > > Simon Urli > > Software Engineer at XWiki SAS > > simon.u...@xwiki.com > > More about us at http://www.xwiki.com > -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

2018-10-17 Thread Thomas Mortagne
gt; > Do you know if the current behaviour is required at some places? > Else do you agree on changing it? > > Simon > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Thomas Mortagne
>>> Thanks > >>>> -Vincent > >>>> > >>>>> > >>>>>> On Fri, Sep 21, 2018 at 4:44 PM Simon Urli > >>>> wrote: > >>>>>>> > >>>>>>> Hi all, > >>>>>>> > >>>>>>> users might currently break their AWM application by renaming/moving > >>>>>>> pages containing XClass definition. > >>>>>>> > >>>>>>> We need a proper refactoring operation to be able to properly do > >>>>>>> such > >>>>>>> move/rename. But this feature might take a while to be completely > >>>>>>> available. > >>>>>>> > >>>>>>> In the meantime I propose that we prevent users from renaming/moving > >>>>>>> pages containing XClass. > >>>>>>> > >>>>>>> What I propose is the following: > >>>>>>> - Forbid completely *simple users* to rename/move pages containing > >>>> XClass > >>>>>>> - Display a warning to *advanced users* when they perform such > >>>>>>> operation: the same kind of warning we already have when performing > >>>> edit > >>>>>>> on XWiki pages > >>>>>>> > >>>>>>> WDYT? > >>>>>>> > >>>>>>> Simon > >>>>>>> > >>>>>>> -- > >>>>>>> Simon Urli > >>>>>>> Software Engineer at XWiki SAS > >>>>>>> simon.u...@xwiki.com > >>>>>>> More about us at http://www.xwiki.com > >>>>> > >>>>> -- > >>>>> Simon Urli > >>>>> Software Engineer at XWiki SAS > >>>>> simon.u...@xwiki.com > >>>>> More about us at http://www.xwiki.com > >> > > > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com -- Thomas Mortagne

[xwiki-devs] [ANN] XWiki 10.8.1 released

2018-10-15 Thread Thomas Mortagne
The XWiki development team is proud to announce the availability of XWiki 10.8.1. This is a bugfix release that covers important issues that we have discovered since 10.8 has been released. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

  1   2   3   4   5   6   7   8   9   10   >